Commit Graph

214511 Commits

Author SHA1 Message Date
Jason Orendorff
fbc4057168 Bug 1090537, part 11 - Delete a special case for arrays in SetNonexistentProperty that is (a) unreachable; (b) redundant with a check in DefinePropertyOrElement. r=efaust.
The code being deleted would be ineffective even if we did have Reflect.set, but Reflect.set does enable a very near miss (where receiver, not obj, is an array), so we leave a sleeper test for that case.

--HG--
extra : rebase_source : ea38558aaa9e52ebb999cf1eea53abfde5608161
2014-10-28 12:49:17 -05:00
Jason Orendorff
f678c3bb6c Bug 1090537, part 10 - Factor out SetNonexistentProperty. No change in behavior. r=efaust.
--HG--
extra : rebase_source : f9bbad80dcb455bfccb5ad9cead6dcb7b53d71d3
2014-11-07 13:02:49 -06:00
Jason Orendorff
eee003c854 Bug 1090537, part 9 - Just move SetPropertyByDefining. No change in behavior. r=efaust.
--HG--
extra : rebase_source : 8accf39f3c7e3d9d4121244213173aa5581f57d3
2014-11-07 13:00:50 -06:00
Jason Orendorff
71f2ace8eb Bug 1090537, part 8 - In SetPropertyHelper, if defining a new data property, define it on receiver, not obj. r=efaust.
Most of the diff is just renaming an argument. The only new code is necessary because unlike obj, receiver can be non-native.

--HG--
extra : rebase_source : 115769a212724dddec315663a7a7e71a9abaa992
2014-10-18 16:49:50 -05:00
Jason Orendorff
5ab816f69d Bug 1090537, part 7 - Eliminate useless attrs argument to SetPropertyByDefining. No change in behavior. r=efaust.
--HG--
extra : rebase_source : 4eb90cb86d576f9014265b9b00808a099f589915
2014-10-18 16:43:25 -05:00
Jason Orendorff
76d852286b Bug 1090537, part 6 - Factor out a big chunk of SetPropertyHelper into a separate function template, SetPropertyByDefining. No change in behavior. r=efaust.
--HG--
extra : rebase_source : 5bd292385b3d2a04f28311305a1cb99b27494193
2014-10-18 16:30:32 -05:00
Jason Orendorff
c42c34a04e Bug 1090537, part 5 - Remove legacy special case in baseops::SetPropertyHelper that cloned the getter and setter of JSPROP_SHADOWABLE properties when shadowed on another native object. r=Waldo.
--HG--
extra : rebase_source : c1478c335a9f5a1484b87ce9c566f1f8c4d9f20d
2014-10-15 14:05:29 -05:00
Jason Orendorff
554e5e3e19 Bug 1090537, part 4 - Take NativeSet private. No change in behavior. r=efaust.
--HG--
extra : rebase_source : 1c802d28c3f828412624cdcc689fa4a76ee3e59c
2014-10-15 12:08:37 -05:00
Jason Orendorff
b7988df161 Bug 1090537, part 3 - Pass receiver argument through from JSObject::setGeneric and setElement to Proxy::set. r=efaust.
ES6 specifies [[Set]] as an operation taking both a "this" object and a "receiver" parameter. Both JSObject::setGeneric and Proxy::set support the receiver parameter, but ObjectOps::setGeneric does not; in this patch, we add a little workaround for that. The test shows how this is observable using only standard builtins.

The changes in JSObject::setElement are untestable since currently all call sites pass the same value for obj as for receiver.

(This was reviewed as "part 2" but it was necessary to switch parts 2 and 3 and add part 2b.)

--HG--
extra : rebase_source : 617decfa9be34b01a0f923a9717ad2544d913af9
2014-10-15 22:54:57 -05:00
Jason Orendorff
66460e97d2 Bug 1090537, part 2b - In Proxy::set, do not assume that proxy == receiver or that both have the same handler. r=efaust, r=bholley.
--HG--
extra : rebase_source : 0aa0e3e37a2a95f3cfa0399e4380de73a95ab48a
2014-10-28 20:58:36 -05:00
Jason Orendorff
940ab6cec8 Bug 1090537, part 2a - In BaseProxyHandler::set(), do not assume that proxy == receiver or that both have the same handler. r=efaust.
(This was reviewed as "part 3" but it was necessary to switch parts 2 and 3 and add part 2b.)

--HG--
extra : rebase_source : 7ae9ba80620475ff3e001e7b1e041c98194152a6
extra : source : dd32aa64b825cff02ce72df7533cbcc57f782f8f
2014-10-16 08:06:13 -05:00
Jason Orendorff
3e771fa684 Bug 1090537, part 1 - Remove an old hack where Proxy::hasOwn permitted SET access. r=bholley.
The comments being deleted here are incorrect; Proxy::set no longer calls handler->hasOwn().

--HG--
extra : rebase_source : 328433d668e99e99373d77bb1956291fb788fac9
2014-10-17 07:33:57 -05:00
Nathan Froyd
9e29dd4ef8 Bug 1095117 - forward-declare cycle collection things in nsRefPtr.h; r=mccr8 2014-11-07 09:13:18 -05:00
Mats Palmgren
814bf7a9fb Bug 415491, part 4 - Make UnEscapeURIForUI always escape the result if it contains blacklisted characters. r=bzbarsky 2014-11-08 02:42:05 +00:00
Mats Palmgren
030c05be51 Bug 415491, part 3 - Use NS_EscapeURL of _retval as the result. r=bzbarsky 2014-11-08 02:42:04 +00:00
Mats Palmgren
ed0ab3c98c Bug 415491, part 2 - Implement a char16_t version of NS_EscapeURL. r=bzbarsky 2014-11-08 02:42:04 +00:00
Mats Palmgren
13820c950e Bug 415491, part 1 - Make UnEscapeURIForUI escape the URI if it contains any 'network.IDN.blacklist_chars' characters (except space). r=bzbarsky 2014-11-08 02:42:04 +00:00
Diwas Joshi
6ff0c62b14 Bug 739568 - nsXULTreeGridRowAccesible should cache its kids as nsXULTreeGridCellAccessibles not generic accessibles, r=tbsaunde 2014-11-05 21:16:37 +05:30
Luke Wagner
780a49b605 Bug 1094570 - OdinMonkey: tidy up TryEnablingIon (r=hannes) 2014-11-05 17:30:30 -06:00
Wes Kocher
cc195f9ec5 Merge m-c to inbound a=merge 2014-11-07 17:55:00 -08:00
Wes Kocher
ec3922bb1d Merge inbound to m-c a=merge 2014-11-07 17:48:37 -08:00
Wes Kocher
c90ab61992 Merge fx-team to m-c a=merge 2014-11-07 17:35:52 -08:00
Ben Turner
8de8424858 Bug 1081703, r=khuey. 2014-11-07 16:42:53 -08:00
Tom Schuster
228962f9c7 Bug 993026 - Fix rooting. no-r 2014-11-08 01:15:52 +01:00
Tom Schuster
107172fa13 Bug 993026 - Rename NewResolve to Resolve in browser. r=bz 2014-11-08 01:07:12 +01:00
Tom Schuster
93dc15aa0c Bug 993026 - Change resolve hook in browser/XPC. r=bholley 2014-11-08 01:07:12 +01:00
Tom Schuster
e34d3251d3 Bug 993026 - Simplify JS resolve hook. r=jorendorff 2014-11-08 01:07:12 +01:00
Tom Schuster
9d229e017e Bug 993026 - Change XPIDLScriptable NewResolve to simpler Resolve. r=bholley 2014-11-08 01:07:12 +01:00
Tom Schuster
6e143a6b0c Bug 1091900 - Move ForOfIterator to its own file. r=jandem
--HG--
rename : js/src/jsiter.cpp => js/src/vm/ForOfIterator.cpp
2014-11-08 01:07:12 +01:00
Wes Kocher
1dabf1f0b5 Backed out changesets 156eee9f2d2a,6e5aee097c86 (bug 1094545) for bc1 and xpcshell orange on a CLOSED TREE 2014-11-07 14:23:05 -08:00
B2G Bumper Bot
8d662a9027 Bumping manifests a=b2g-bump 2014-11-07 12:52:51 -08:00
Boris Zbarsky
0730704a75 Bug 1094545 followup: only do system stuff for non-worker descriptors, and rename one consumer that was colliding with the new URL global. r=bholley pending, but checking in now to fix CLOSED TREE 2014-11-07 15:48:51 -05:00
Michael Wu
0a330769d5 Bug 1092073 - Set Fira as the default font for Greek, r=jfkthame ui-r=patryk 2014-11-07 15:24:21 -05:00
Monica Chew
ccfc8984aa Bug 1030135: Promote pin for services.mozilla.com to production mode (r=keeler) 2014-11-07 12:00:50 -08:00
Jessica Jong
897c16255b Bug 1095332 - B2G RIL: Fix false alarms "WARNING: 'jsapi.Init(mWindow)'...". r=echen 2014-11-06 23:56:00 -05:00
B2G Bumper Bot
803f2b5d89 Bumping manifests a=b2g-bump 2014-11-07 11:36:51 -08:00
B2G Bumper Bot
961c7c67a8 Bumping gaia.json for 2 gaia revision(s) a=gaia-bump
========

https://hg.mozilla.org/integration/gaia-central/rev/fe471b147dad
Author: James Lal <james@lightsofapollo.com>
Desc: Merge pull request #25906 from eliperelman/bug-1067625

Bug 1067625 - Fixing broken profile-test creation which errors first performance test

========

https://hg.mozilla.org/integration/gaia-central/rev/5bda8faef639
Author: Eli Perelman <eli@eliperelman.com>
Desc: Bug 1067625 - Fixing broken profile-test creation which errors first performance test
2014-11-07 11:25:49 -08:00
Ryan VanderMeulen
7583a1d0ef Merge m-c to b2g-inbound. a=merge 2014-11-07 14:04:37 -05:00
B2G Bumper Bot
742bbf8e1d Bumping manifests a=b2g-bump 2014-11-07 11:02:16 -08:00
B2G Bumper Bot
08fdd1596b Bumping gaia.json for 1 gaia revision(s) a=gaia-bump
========

https://hg.mozilla.org/integration/gaia-central/rev/0763a823613b
Author: Kevin Grandon <kevingrandon@yahoo.com>
Desc: Revert "Bug 1092195 - Investigate failure in test_cost_control_ftu.py"

This reverts commit 07f5ea2d845d6d17c05c388090b77528ac87ddb4.
2014-11-07 10:55:53 -08:00
Ryan VanderMeulen
dd8705ee02 Merge fx-team to m-c. a=merge 2014-11-07 13:35:28 -05:00
Ryan VanderMeulen
beecc739b3 Merge inbound to m-c. a=merge 2014-11-07 13:24:00 -05:00
B2G Bumper Bot
9418d1469b Bumping manifests a=b2g-bump 2014-11-07 09:41:12 -08:00
B2G Bumper Bot
ff07d86269 Bumping manifests a=b2g-bump 2014-11-07 09:02:23 -08:00
B2G Bumper Bot
f7df1f2562 Bumping gaia.json for 2 gaia revision(s) a=gaia-bump
========

https://hg.mozilla.org/integration/gaia-central/rev/210bb51b51b7
Author: Kevin Grandon <kevingrandon@yahoo.com>
Desc: Merge pull request #25873 from sv99/1094716

Bug 1094716 - [collection] bad unit test initialization in collection/test/unit/setup.js r=kgrandon

========

https://hg.mozilla.org/integration/gaia-central/rev/c1699cee99d6
Author: sv99 <sv99@inbox.ru>
Desc: Bug 1094716 - [collection] bad unit test initialization in collection/test/unit/setup.js
2014-11-07 08:50:53 -08:00
B2G Bumper Bot
b3708149cb Bumping manifests a=b2g-bump 2014-11-07 07:42:16 -08:00
B2G Bumper Bot
281959a69a Bumping gaia.json for 6 gaia revision(s) a=gaia-bump
========

https://hg.mozilla.org/integration/gaia-central/rev/739ec414e24e
Author: Florin Strugariu <florin.strugariu@softvision.ro>
Desc: Merge pull request #25835 from viorelaioia/bug_1092195

Bug 1092195 - Investigate failure in test_cost_control_ftu.py

========

https://hg.mozilla.org/integration/gaia-central/rev/ffb6927d7020
Author: Viorela Ioia <viorelaioia@gmail.com>
Desc: Bug 1092195 - Investigate failure in test_cost_control_ftu.py

========

https://hg.mozilla.org/integration/gaia-central/rev/6b5a7178a208
Author: Florin Strugariu <florin.strugariu@softvision.ro>
Desc: Merge pull request #25755 from chirarobert/bug_1090087

Bug 1090087 - Add test for saving an image from a webpage

========

https://hg.mozilla.org/integration/gaia-central/rev/ee7698008343
Author: Robert Chira <robertchira@P5075.(none)>
Desc: Bug 1090087 - Add test for saving an image from a webpage

========

https://hg.mozilla.org/integration/gaia-central/rev/f9eac9319dcf
Author: Florin Strugariu <florin.strugariu@softvision.ro>
Desc: Merge pull request #25764 from bebef1987/MMS

Bug 1080169 - Update test_sms_with_attachments.py to correlate with the ...

========

https://hg.mozilla.org/integration/gaia-central/rev/79eae80aa9c1
Author: Bebe <bebe@mozilla.ro>
Desc: Bug 1080169 - Update test_sms_with_attachments.py to correlate with the manual test
2014-11-07 07:35:53 -08:00
Carsten "Tomcat" Book
8a65bd2299 Backed out changeset 9fa06a2e1a98 (bug 1092156) for breaking nightly builds 2014-11-07 16:35:14 +01:00
Carsten "Tomcat" Book
659b5581e6 Backed out changeset f786dcb23eca (bug 1092156) 2014-11-07 16:34:22 +01:00
B2G Bumper Bot
8a76d84ba9 Bumping manifests a=b2g-bump 2014-11-07 07:27:16 -08:00