Commit Graph

6000 Commits

Author SHA1 Message Date
L. David Baron
37e896e0d7 Bug 1230668 - Don't use frame when not in composed document. r=heycam 2016-01-08 21:15:44 +11:00
Tooru Fujisawa
b57eb9b772 Bug 382721 - Part 0: Add missing includes and namespaces. r=jrmuizel 2015-09-10 19:24:34 +09:00
Xidorn Quan
fade80b73a Bug 1230408 - Move suppress line break check out from control of SkipParentDisplayBasedStyleFixup. r=dbaron
The flag SkipParentDisplayBasedStyleFixup is for flex/grid fixup, and it is set
for all pseudo elements other than before/after. This is not desirable for ruby
case.

Moving the code out also means elements will inherit the suppress flag directly
from "display: contents" parent (instead of the container), which is fine since
the parent should have had its flag set properly as well.
2016-01-08 14:34:08 +11:00
Boris Zbarsky
a16f65c4ea Bug 1230172. Update CSS.escape to never throw and instead replace U+0000 with U+FFFD, per recent spec change. r=dbaron 2016-01-05 15:05:23 -05:00
John Daggett
fdc20b64e0 Bug 1157064 - implementation of font-display. r=heycam,khuey 2016-01-07 14:03:05 +09:00
John Daggett
bb31e75a7b Bug 1157064 - font-display descriptor parsing. r=dbaron 2016-01-07 14:02:58 +09:00
Daniel Holbert
6ebeaf810f Bug 1236506: Add support for "-webkit-filter" as an alias for CSS property "filter". r=heycam 2016-01-06 16:35:33 -08:00
Brian Birtles
5d4b94b32a Bug 1232563 part 1 - Request a layer update if an animation is newly finished; r=heycam
When requesting restyles we take special care to detect when an animation has
newly finished so we perform the necessary restyle to represent the fill state.
However, we should really explicitly pull the animation off the layer at this
point by requesting a layer update. (That is, when an animation is
newly-finished we should use RestyleType::Layer instead of
RestyleType::Standard. Currently we just use RestyleType::Standard.)

In this bug we plan to move restyle requests down to the effect (since it is
the *effect* that is restyled). However, only the Animation has the notion of
"finished" or not so we detect this particular case in the Animation and
request the layer update there. We already request layer updates in the
Animation for other situations such as pausing so doing *layer* updates in the
Animation and regular restyles in the effect is not inconsistent.

This patch also tweaks test_animations_omta.html since it was previously
erroneously testing that a finished animation was still running on the
compositor.
2016-01-06 11:04:06 +09:00
Brian Birtles
43952d6224 Bug 1232561 part 4 - Add EffectCompositor::ComposeAnimationRule; r=heycam
This patch just moves a piece of functionality from
AnimationCollection::EnsureStyleRuleFor to the EffectCompositor. In subsequent
bugs we will move more and more of this functionality across until this
logic is fully contained in the EffectCompositor.
2016-01-06 11:04:06 +09:00
Brian Birtles
3e7c8ce60a Bug 1232561 part 3 - Move AnimValuesStyleRule to a separate file; r=heycam
As we gradually move logic from layout/style/AnimationCommon.cpp to
dom/animation/EffectSet and EffectCompositor it makes sense to let this class
live in its own file inside dom/animation where it is used.
2016-01-06 11:04:06 +09:00
Brian Birtles
703208dd98 Bug 1232561 part 2 - Move the animation style rules from AnimationCollection to EffectSet; r=heycam
This is needed in order to support script-generated animations since they do not
belong to any AnimationCollection.

This patch adopts the naming "animation rule" over "style rule". Currently we
are inconsistent about this (e.g. GetAnimationRule vs EnsureStyleRuleFor).
We don't do a mass rename here but just a few places near where we're touching.
Many of the other references to "style rule" will be revised in this bug or
related bugs so we can fix those references when we come to them.
2016-01-06 11:04:06 +09:00
Brian Birtles
2eb2ff7cff Bug 1232561 part 1 - Replace AppliesToTransitionsLevel() with a cascade level enumeration; r=heycam
Introducing an enum will simplify further patches in this series by providing
a common vocabulary for this distinction.
2016-01-06 11:04:05 +09:00
Brian Birtles
407c5626ab Bug 1229280 - Move animation generation from AnimationCollection to EffectSet; r=dbaron 2016-01-06 11:04:05 +09:00
Brian Birtles
5d3c8ad924 Bug 1228229 part 10 - Remove no-longer-used cascade functions; r=dbaron 2016-01-06 11:04:05 +09:00
Brian Birtles
9f7a1ae4df Bug 1228229 part 9 - Use EffectCompositor::UpdateCascadeResults; r=dbaron 2016-01-06 11:04:05 +09:00
Brian Birtles
0204436137 Bug 1228229 part 7 - Add a method to Animation to indicate if it applies to the transitions level of the cascade; r=dbaron
For transitions, this method returns true so long as the transition is
bound to markup. This is based on the below discussion,

  https://github.com/w3c/web-animations/issues/97
  https://github.com/w3c/web-animations/issues/62#issuecomment-117357703
  https://github.com/w3c/web-animations/issues/62#issuecomment-117374689

We will likely reuse this method when we come to implement animation style rule
generation in a more generic manner.
2016-01-06 11:04:05 +09:00
Brian Birtles
bfb3085c3b Bug 1228229 part 3 - Factor out a method to get compositor-animatable overridden properties; r=dbaron
This patch also simplifies this logic by simply always looking for overrides of
'transform' and 'opacity'.
2016-01-06 11:04:04 +09:00
Brian Birtles
26f51aa4d1 Bug 1228229 part 2 - Add a helper to get the appropriate (pseudo-)element for a frame; r=dbaron
We will use similar logic later in this patch series so we separate it out into
a separate helper function here.
2016-01-06 11:04:04 +09:00
Wes Kocher
68bd190072 Backed out changeset b7cd1bc458a3 (bug 1230172) because something from this push turned browser_video_test.js permafail on mulet CLOSED TREE 2016-01-05 15:14:44 -08:00
Mats Palmgren
3be3b273fb Bug 1233106 part 2 - [css-align] Updated tests due to changes to align-/justify-* properties. 2016-01-05 21:27:13 +01:00
Mats Palmgren
f6191ecd14 Bug 1233106 part 1 - [css-align] Update align-/justify-* properties to the current CSS Align spec (adding 'normal' keyword, dropping 'auto' in some cases etc). r=dholbert
The CSSWG minutes for reference:
https://lists.w3.org/Archives/Public/www-style/2015Dec/0233.html

With subsequent correction for the root node:
https://lists.w3.org/Archives/Public/www-style/2016Jan/0015.html
2016-01-05 21:27:13 +01:00
Mats Palmgren
86b0a22c5d Bug 1234644 - [css-grid] Avoid calling GetROCSSValueList() when we don't need the allocated object. r=dholbert 2016-01-05 21:27:13 +01:00
Mats Palmgren
55d0421623 Bug 1230398 - [css-align] Don't output 'unsafe' in serialization because it's the default. r=dholbert
Prompted by a CSS Align spec change:
https://lists.w3.org/Archives/Public/www-style/2015Dec/0067.html
2016-01-05 21:27:13 +01:00
Mats Palmgren
8948acf074 Bug 1230478 part 2 - [css-align] Change 'true' to 'unsafe' in tests. 2016-01-05 21:27:13 +01:00
Mats Palmgren
d91c130dfa Bug 1230478 part 1 - [css-align] Rename 'true' to 'unsafe' in <overflow-position>. r=dholbert 2016-01-05 21:27:13 +01:00
Boris Zbarsky
7f04f185b9 Bug 1230172. Update CSS.escape to never throw and instead replace U+0000 with U+FFFD, per recent spec change. r=dbaron 2016-01-05 15:05:23 -05:00
Bogdan Postelnicu
bcb310cacc Bug 1234535 - Avoid spurious null dereference complaint from Coverity. r=froydnj 2016-01-04 07:24:00 -05:00
Xidorn Quan
0d57808249 Bug 1231485 part 3 - Fix style tests for text-emphasis properties. r=dbaron 2016-01-04 10:47:05 +11:00
Xidorn Quan
021e59715e Bug 1231485 part 2 - Add NeutralChange hint to nsStyleText::MaxDifference(). r=dbaron 2016-01-04 10:47:05 +11:00
Xidorn Quan
c693aeacd2 Bug 1231485 part 1 - Fix text-emphasis shorthand with style part unspecified being computed incorrectly. r=dbaron 2016-01-04 10:47:05 +11:00
Cameron McCormack
0d3c96d822 Bug 1234773 - Followup assertion. 2016-01-04 10:25:28 +11:00
Cameron McCormack
a820d5d61f Bug 1234773 - Build and parse preference style sheet as a single string. r=dholbert 2016-01-04 09:26:59 +11:00
Cameron McCormack
976b2ac24c Bug 1234758 - Fix errors in preference style sheet focus ring rules. r=dholbert 2016-01-04 09:26:58 +11:00
Cameron McCormack
3de88ce1b8 Bug 1229567 - Back out bug 1194856 data: URL hack. r=dholbert 2016-01-04 09:26:58 +11:00
Cameron McCormack
d1a269d254 Bug 1235969 - Unprefix uses of -moz-transform, -moz-transform-origin and -moz-backface-visibility in UA style sheets. r=xidorn 2015-12-31 19:13:18 +11:00
Daniel Holbert
7b0e0164c2 Bug 1208344 part 7: Add mochitest to test how "-webkit-box-orient" maps to "flex-direction". r=heycam 2015-12-30 23:36:31 -08:00
Daniel Holbert
f452085c6b Bug 1208344 part 6: Move new CSS_PROPERTY_LOGICAL_CUSTOM flag up with other LOGICAL flags, and adjust bits accordingly. r=heycam 2015-12-30 23:36:31 -08:00
Daniel Holbert
e345c9badf Bug 1208344 part 5: Add (preffed-off) support for "-webkit-box-orient" CSS property, as a writing-mode-dependent alias for "flex-direction". r=heycam 2015-12-30 23:36:31 -08:00
Daniel Holbert
809b0c4364 Bug 1208344 part 4: Make MapSinglePropertyInto() take the source property as an arg (unused for the moment). r=heycam 2015-12-30 23:36:31 -08:00
Daniel Holbert
d2e60e455d Bug 1208344 part 3: Rename MapSinglePropertyInto() args, to make src-vs-target distinctions clearer. r=heycam 2015-12-30 23:36:31 -08:00
Daniel Holbert
3413199795 Bug 1208344 part 2: Make EnsurePhysicalProperty() (not its callers) check whether property is logical. r=heycam 2015-12-30 23:36:31 -08:00
Daniel Holbert
5fc4aad237 Bug 1208344 part 1: Make EnsurePhysicalProperty() return the property directly, instead of using in/out-param. r=heycam 2015-12-30 23:36:31 -08:00
Xidorn Quan
5a90edf90b Bug 1215365 - Update ua style sheet of fullscreen element. r=heycam 2015-12-31 14:11:36 +11:00
Boris Zbarsky
2b658b4dfd Bug 1230639 - Propagate the namespace ID to AttributeRuleProcessorData on attribute changes. r=dbaron 2015-12-05 01:09:13 -05:00
Chris Peterson
10848ade35 Bug 1235306 - Fix -Wimplicit-fallthrough warnings in layout/. r=dholbert
layout/base/nsCSSRendering.cpp:3913:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsCSSRendering.cpp:3943:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsCSSRendering.cpp:4066:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsCSSRendering.cpp:4096:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsCSSRenderingBorders.cpp:646:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsLayoutUtils.cpp:4639:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsLayoutUtils.cpp:4659:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsLayoutUtils.cpp:5004:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/nsLayoutUtils.cpp:5200:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/TouchManager.cpp:192:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/base/TouchManager.cpp:196:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFlexContainerFrame.cpp:2497:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFlexContainerFrame.cpp:2687:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFlexContainerFrame.cpp:2973:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFrame.cpp:4277:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFrame.cpp:4310:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFrame.cpp:4313:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFrame.cpp:6703:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsFrame.cpp:6751:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsGridContainerFrame.cpp:2649:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsGridContainerFrame.cpp:935:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsHTMLReflowState.cpp:1141:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsHTMLReflowState.cpp:1145:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsHTMLReflowState.cpp:1148:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsLineLayout.cpp:2942:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsLineLayout.cpp:2958:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsLineLayout.cpp:3134:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/generic/nsLineLayout.cpp:3150:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/printing/nsPrintPreviewListener.cpp:199:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/CSSLexer.cpp:129:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/Declaration.cpp:1069:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/Declaration.cpp:366:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/Declaration.cpp:442:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/Declaration.cpp:981:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsComputedDOMStyle.cpp:3597:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsComputedDOMStyle.cpp:3616:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsComputedDOMStyle.cpp:539:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsComputedDOMStyle.cpp:540:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsComputedDOMStyle.cpp:542:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10628:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10630:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10671:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10673:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10769:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10770:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10774:43 [-Wimplicit-fallthrough] fallthrough annotation does not directly precede switch label
layout/style/nsCSSParser.cpp:10775:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10776:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:10780:43 [-Wimplicit-fallthrough] fallthrough annotation does not directly precede switch label
layout/style/nsCSSParser.cpp:2542:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:2715:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:4124:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:4313:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9513:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9697:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9699:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9743:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9745:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9826:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9827:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9832:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9833:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsCSSParser.cpp:9980:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsRuleNode.cpp:160:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsRuleNode.cpp:187:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsRuleNode.cpp:722:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/nsRuleNode.cpp:753:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/StyleAnimationValue.cpp:139:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/StyleAnimationValue.cpp:1687:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/style/StyleAnimationValue.cpp:1869:7 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/FixedTableLayoutStrategy.cpp:264:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/FixedTableLayoutStrategy.cpp:267:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsCellMap.cpp:1043:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsCellMap.cpp:930:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsCellMap.cpp:953:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsCellMap.cpp:997:3 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:6943:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:6953:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:6959:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:6966:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:6974:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:7151:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:7161:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:7170:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:7177:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableFrame.cpp:7186:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/nsTableRowFrame.cpp:663:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/SpanningCellSorter.cpp:112:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/SpanningCellSorter.cpp:142:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/tables/SpanningCellSorter.cpp:157:9 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/xul/nsResizerFrame.cpp:86:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/xul/nsResizerFrame.cpp:87:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/xul/nsResizerFrame.cpp:88:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/xul/nsResizerFrame.cpp:90:13 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/xul/nsSliderFrame.cpp:551:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/xul/nsSliderFrame.cpp:560:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
layout/xul/nsXULPopupManager.cpp:2268:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
2015-11-22 21:33:47 -08:00
Wes Kocher
b1a77cbe35 Backed out changeset 8e026b0e24a5 (bug 1215365) for gij failures 2015-12-28 16:29:30 -08:00
Xidorn Quan
a797598062 Bug 1215365 - Update ua style sheet of fullscreen element. r=heycam 2015-12-29 09:48:37 +11:00
Daniel Holbert
9afbfa46e3 Bug 1234676 part 5: Update indentation & rewrap some nsComputedDOMStyle function-decls. rs=heycam 2015-12-28 14:42:09 -08:00
Daniel Holbert
974742350a Bug 1234676 part 4: Remove now-obsolete comment. r=heycam 2015-12-28 14:42:09 -08:00
Daniel Holbert
b029032940 Bug 1234676 part 3: Remove some now-unneeded local RefPtr variables. r=heycam 2015-12-28 14:42:09 -08:00
Daniel Holbert
1f82e01374 Bug 1234676 part 2: Make nsComputedDOMStyle getters return an already_AddRefed value, instead of a raw pointer with refcount of 0. r=heycam 2015-12-28 14:42:08 -08:00
Daniel Holbert
48ad358bdd Bug 1234676 part 1: Give nsComputedDOMStyle a private typedef for mozilla::dom::CSSValue. r=heycam 2015-12-28 14:42:08 -08:00
Chris Peterson
149404728e Bug 1235186 - Part 1: Fix -Wformat warnings in layout/. r=dholbert
layout/base/AccessibleCaret.cpp:129:48 [-Wformat-extra-args] data argument not used by format string
layout/generic/nsContainerFrame.cpp:425:71 [-Wformat] more '%' conversions than data arguments
layout/style/FontFaceSet.cpp:798:10 [-Wformat] format specifies type 'int' but the argument has type 'size_type' (aka 'unsigned long')
layout/style/Loader.cpp:1817:12 [-Wformat] format specifies type 'unsigned int' but the argument has type 'nsICSSLoaderObserver *'
layout/style/Loader.cpp:1817:35 [-Wformat] format specifies type 'unsigned int' but the argument has type 'mozilla::css::SheetLoadData *'
layout/style/Loader.cpp:1827:12 [-Wformat] format specifies type 'unsigned int' but the argument has type 'nsICSSLoaderObserver *'
layout/style/Loader.cpp:1827:23 [-Wformat] format specifies type 'char *' but the argument has type 'mozilla::css::SheetLoadData *'
2015-12-24 16:04:20 -07:00
Hiroyuki Ikezoe
d8660dc34f Bug 1234966 - nsStylePosition::MaxDifference should include nsChangeHint_NeutralChange because CalcDiffrence returns it. r=heycam 2015-12-24 09:35:18 +09:00
Daniel Holbert
57a1d0aea9 Bug 1234707: Make nsDOMCSSValueList::AppendCSSValue() take an already_AddRefed arg (instead of a raw pointer, usually with refcount of 0). r=heycam 2015-12-23 16:25:43 -08:00
Jan Horak
cf90751d51 Bug 1205643 - "Wrong scrollbar border prevents scrolling to cursor when mouse is on the screen edge". r=karlt 2015-12-22 05:05:00 +01:00
Daniel Holbert
d8506cadf5 Bug 1234409: Give percentage positions to the dummy transparent color-stops that we use to pad CSS -webkit-gradient() expressions. r=heycam
DONTBUILD because backed out & re-landed just to fix bug number
2015-12-22 22:48:16 -08:00
Daniel Holbert
4358fd1d14 Backed out changeset 6fb4628a5eeb because it landed with the wrong bug number 2015-12-22 22:49:30 -08:00
Daniel Holbert
8e30232024 Bug 1204897: Give percentage positions to the dummy transparent color-stops that we use to pad CSS -webkit-gradient() expressions. r=heycam 2015-12-22 22:48:16 -08:00
Mats Palmgren
9ac0b6e37b Bug 1118820 part 1 (style system part) - [css-grid] Implement the 'auto-fill' and 'auto-fit' keywords in the repeat() function. r=dholbert 2015-12-22 23:03:15 +01:00
Ting-Yu Lin
f0cb7d3677 Bug 1221459 - Remove TouchCaret and SelectionCarets. r=mtseng, r=roc
All the files modified are straightforward deletion except TouchManager
and ZoomConstraintsClient. I add some includes and wrap TouchManager by
mozilla namespace to fix build errors due to the removal of TouchCaret.
2015-12-22 14:14:12 +08:00
Nigel Babu
5342ec0bac Backed out changeset 9f30d3caa231 (bug 1221459) 2015-12-22 14:03:21 +05:30
Ting-Yu Lin
bb9ed63ce1 Bug 1221459 - Remove TouchCaret and SelectionCarets. r=mtseng,roc
All the files modified are straightforward deletion except TouchManager
and ZoomConstraintsClient. I add some includes and wrap TouchManager by
mozilla namespace to fix build errors due to the removal of TouchCaret.
2015-12-22 14:14:12 +08:00
Brian Birtles
a0fa9f35c2 Bug 1232829 - Detach obsolete DocumentTimeline from refresh driver when the document is reset; r=smaug 2015-12-22 10:08:19 +09:00
L. David Baron
e9da0c1aad Bug 1233276 - Make css::Declaration::List more useful again, given that it degraded a bit in bug 978833 (/ bug 1221436). r=heycam 2015-12-21 13:11:32 -05:00
Hiroyuki Ikezoe
b790b37b32 Bug 1219543 - Part 2: Avoid the period that mIsRunningOnCompositor is false between restyling and building display list. r=bbirtles
Without this fix, mIsRunningOnCompositor will be unpredictable in
MutationObserver callbacks.

For example:

 mIsRunningOnCompositor will be false if the micro task for
 the MutationObserver is processed before building display list.

 mIsRunningOnCompositor will be true if there is no room to process
 the micro task before building display list.
2015-12-20 14:17:00 +01:00
Hiroyuki Ikezoe
3dac187bfb Bug 1219543 - Part 1: isRunningOnCompositor flag is now a member of AnimationProperty. r=bbirtles 2015-12-20 14:16:00 +01:00
Daniel Holbert
bf1403415c (no bug) Fix typo in grid style-struct comment: s/grid-columns-rows/grid-template-rows/. No review, DONTBUILD 2015-12-18 16:28:38 -08:00
Bogdan Postelnicu
af0b9732b8 Bug 1232596 - initialize variable changed = false, flagged by Coverity. r=dbaron 2015-12-15 00:41:00 +01:00
Mats Palmgren
3fedf78825 Bug 1230672 part 3 - Add support for multicol layout on <fieldset> elements. r=bz 2015-12-15 02:51:03 +01:00
Mats Palmgren
0e14d0c6b5 Bug 1230672 part 1 - Make '-moz-column-fill:auto' work also when 'overflow' isn't 'visible'. r=bz 2015-12-15 02:51:03 +01:00
Mats Palmgren
b95adfa268 Bug 1230207 - Add support for display:grid/flex layout on <fieldset> elements. r=bz,dholbert 2015-12-15 02:51:02 +01:00
Kartikaya Gupta
599ba11c0b Bug 1229052 - Log a warning when we detect a scroll-linked effect based on the scroll event. r=roc 2015-12-14 14:47:24 -05:00
Kartikaya Gupta
5f3ab4eb0a Back out 5 csets from bug 1229052 on a CLOSED TREE for failing to fix the nonunified build error even after many attempts. r=backout 2015-12-14 15:52:31 -05:00
Kartikaya Gupta
cfeeb6f5b4 Bug 1229052 - Log a warning when we detect a scroll-linked effect based on the scroll event. r=roc 2015-12-14 14:47:24 -05:00
Xidorn Quan
d81577181d Bug 1230508 - Always compute position to fixed for top layer elements for now. r=dbaron
Although the spec says absolute is allowed for top layer elements, and actually
other values should be computed to absolute, but this is mostly fine because
the only way we currently support for web content to use the top layer is via
the Fullscreen API, however, fullscreen elements are forced to be fixed by the
UA sheet.

Given only fixed is safe for top layer element currently, rather than doing
what the spec says, we should prefer always force it, until we really add
support for the other value.
2015-12-14 12:31:23 +11:00
Tobias Schneider
f36090f488 Bug 978212 - [css-grid] Resolved value of grid-template-{columns,rows} in px units. r=mats 2015-11-24 17:27:54 -08:00
Daniel Holbert
e026f21e96 (no bug) Fix typo (repeated word) in comment. comment-only, no review, DONTBUILD 2015-12-09 09:52:12 -05:00
Xidorn Quan
48369159bf Bug 1229278 - Fix dynamic changes to text-emphasis-style. r=dbaron 2015-12-08 12:55:01 -05:00
Xidorn Quan
a496570db2 Bug 1225018 part 1 - Trigger reflow on some text emphasis changes for line height calculation. r=dbaron 2015-12-08 12:55:01 -05:00
Nigel Babu
e6a2f84ae9 Backed out changeset c798c2576ad4 (bug 978212) for mochitest bustage 2015-12-08 15:55:13 +05:30
Mike Taylor
98ad3ca9be Bug 1230426 - Remove support for -webkit-border-image longhand CSS property aliases. r=dholbert
It turns out Edge had added them at one point, but ended up removing them because they
were never shipped in WebKit/Blink browsers (oops).
2015-12-04 08:43:00 +01:00
Tobias Schneider
2a6dddeb61 Bug 978212 - Resolved value of grid-template-{columns,rows} in px units. r=mats 2015-12-03 14:23:00 +01:00
L. David Baron
197a23ea00 Bug 1230701 - Make will-change:position create a containing block for absolutely-positioned elements. r=dholbert 2015-12-07 18:39:41 -05:00
Nicholas Nethercote
ccc3105501 Bug 1230863 - Remove unused nsPresContext args from many functions. r=roc. 2015-12-06 17:15:53 -08:00
Xidorn Quan
4f8dbcd83b Bug 1224013 part 1 - Enable text-emphasis in UA sheets. r=dbaron
The only usage of text-emphasis in UA sheets is to clear it on ruby text. Making
it enabled in UA sheets allows that rule to take effect without additional code
to reload html.css when the pref changes.
2015-12-04 15:16:54 +11:00
Xidorn Quan
8b3ca31ddc Backed out 8 changesets (bug 1225018, bug 1229278, bug 1224013) for reftest failures on CLOSED TREE 2015-12-04 13:08:17 +11:00
Xidorn Quan
54c1b42e60 Bug 1224013 part 1 - Enable text-emphasis in UA sheets. r=dbaron
The only usage of text-emphasis in UA sheets is to clear it on ruby text. Making
it enabled in UA sheets allows that rule to take effect without additional code
to reload html.css when the pref changes.
2015-12-04 12:02:41 +11:00
Xidorn Quan
88234c56b2 Bug 1229278 - Fix dynamic changes to text-emphasis-style. r=dbaron 2015-12-04 11:58:59 +11:00
Xidorn Quan
f0c1e1ac0e Bug 1225018 part 1 - Trigger reflow on some text emphasis changes for line height calculation. r=dbaron 2015-12-04 11:58:59 +11:00
Brian Birtles
186e1d0faf Bug 1226118 part 14 - Rewrite GetAnimationCollection(nsIFrame*) in terms of the existing GetAnimationCollection; r=dholbert
This simply allows us to share the code that maps from pseudo-types to atoms.
2015-12-04 08:34:18 +09:00
Brian Birtles
11fdf2a0ab Bug 1226118 part 13 - Move the GetAnimationCollection definitions side-by-side; r=dholbert
This is to match the order in the header file and because in the next patch I'd
like to somewhat re-implement one method in terms of the other and having them
side-by-side will make it easier to read the code.

This patch makes no code changes whatsoever besides shifting the placement of
the function definitions within the .cpp file.
2015-12-04 08:34:17 +09:00
Brian Birtles
df158e0d92 Bug 1226118 part 12b - Rename CommonAnimationManager::GetAnimations to GetAnimationCollection; r=dholbert
This is to align with the existing GetAnimationCollection method that takes
a frame. Also, by making this name more specific hopefully it will be used less
since we are trying to move as much code as possible over to using EffectSet
instead of AnimationCollection.
2015-12-04 08:34:17 +09:00
Brian Birtles
dd79e63f78 Bug 1226118 part 11 - Remove CommonAnimationManager::GetAnimationsForCompositor; r=dholbert 2015-12-04 08:34:17 +09:00
Brian Birtles
01072f313f Bug 1226118 part 7 - Rename and rework KeyframeEffectReadOnly::CanAnimatePropertyOnCompositor to ShouldBlockCompositorAnimations; r=hiro
KeyframeEffectReadOnly::CanAnimatePropertyOnCompositor has a comment that says
it, "Returns true |aProperty| can be run on compositor for |aFrame|" but it
does nothing of the sort.

What it *does* do is check answer the question, "If there happened to be an
animation of |aProperty| on |aFrame|, should we still run animations on the
compositor for this element?".

This patch renames the method accordingly and moves the step where we iterate
over a given effect's animated properties from
AnimationCollection::CanPerformOnCompositor to inside this method, making this
method a class method rather than a static method at the same time.

As noted in the expanded comment, the approach of blocking opacity animations
in these situations seems unnecessary but for now this patch just preserves the
existing behavior.
2015-12-04 08:32:53 +09:00
Brian Birtles
52e54a7480 Bug 1226118 part 6 - Remove no longer used LayerAnimationRecord/Info code from AnimationCommon; r=dholbert
This code has now been moved to LayerAnimationInfo.{h,cpp} and is not used in
AnimationCommon.
2015-12-04 08:32:53 +09:00
Brian Birtles
657ea3b306 Bug 1226118 part 5 - Move LogAsyncAnimationFailure to AnimationUtils; r=dholbert
This patch also moves AnimationUtils out of the dom namespace since it seems
unnecessary. We typically only put actual DOM interfaces in the dom namespace.
2015-12-04 08:32:53 +09:00
Brian Birtles
ec42c2b226 Bug 1226118 part 3 - Use EffectSet in CommonAnimationManager::ClearIsRunningOnCompositor; r=hiro, r=dholbert 2015-12-04 08:32:53 +09:00
Brian Birtles
0a77f40330 Bug 1226118 part 2 - Use EffectSet in nsLayoutUtils animation functions; r=dholbert 2015-12-04 08:32:52 +09:00
Botond Ballo
ecac74cd13 Bug 1069417 - Generalize Matrix4x4 into Matrix4x4Typed<SourceUnits, TargetUnits>. r=Bas
Matrix4x4 remains a typedef for Matrix4x4Typed<UnknownUnits, UnknownUnits>.

No client code needed changing, except for forward-declarations of Matrix4x4
as a class (since it's now a typedef).
2015-12-02 18:52:00 -05:00
Nicholas Nethercote
0056a1863e Bug 1229458 - Remove SizeOfIncludingThisMustBeUnshared() from string classes. r=mccr8.
The patch changes all uses of SizeOfIncludingThisMustBeUnshared() to
SizeOfIncludingThisIfUnshared(). This incurs the (tiny) cost of an unnecessary
IsReadonly() check for guaranteed-unshared strings, but avoids the possible
assertion failures that would occur when MustBeUnshared() was used incorrectly
on shared strings, which is an easy mistake to make.
2015-12-01 15:36:26 -08:00
Anup Kumar
9bf5d3691a Bug 1197307 - remove PR_snprintf calls in layout/ r=froydnj r=dholbert 2015-12-01 12:50:47 -08:00
Gabor Krizsanits
3c2a45e0db Bug 1228542 - Resetting AuthorStyleSheets. r=bz 2015-12-01 13:54:34 +01:00
Anup Kumar
54598822a8 Bug 1228051 - Remove PR_snprintf calls in nsCSSParser.cpp's CSSParserImpl::ParseColor. r=dholbert 2015-11-26 03:19:00 +01:00
Carsten "Tomcat" Book
26131b3c04 Backed out changeset 427dc5894094 (bug 1197307) for bustage 2015-12-01 10:04:50 +01:00
Anup Kumar
b5f6c9d24a Bug 1197307 - remove PR_snprintf calls in layout. r=froydnj r=dholbert 2015-11-27 21:44:00 +01:00
L. David Baron
27c347b65f Bug 1224251 patch 3 - Return nsChangeHint_UpdateUsesOpacity when opacity changes between 1 and non-1. r=xidorn 2015-11-30 21:25:54 -08:00
Daniel Holbert
bab1e2cca7 Bug 1229212: Manually make the text frame inside of <input type="number"> satisfy the requirement that all flex items are block-level. r=mats 2015-11-30 21:22:44 -08:00
L. David Baron
c2fdecb7c3 Bug 1228877 - Make nsStyleContext::HasChildThatUsesGrandancestorStyle by setting bit on grandchild's parent instead of grandchild. r=xidorn 2015-11-30 16:16:46 -08:00
L. David Baron
9d8c072a03 Bug 1227766 patch 3 - Make will-change cause creation of a containing block for fixed and absolutely positioned elements when needed. r=dholbert 2015-11-30 15:46:44 -08:00
L. David Baron
f08883dca0 Bug 1227766 patch 2 - Add will-change bit for establishing a containing block for fixed positioned elements. r=dholbert 2015-11-30 15:46:44 -08:00
L. David Baron
e58dd9591a Bug 1227766 patch 1 - Add flag for CSS properties that establish a containing block for fixed positioned elements. r=dholbert 2015-11-30 15:46:44 -08:00
L. David Baron
a940f6d504 Bug 196292 - Make table inside align=left reset alignment just like for align=center and align=right. r=bz
Without the patch, cell-align-stopped-at-table-1-standards.html fails
because the th in the align=left cell is left-aligned rather than
centered.
2015-11-30 15:31:30 -08:00
Xidorn Quan
661c7d9ba4 Bug 1202940 part 2 - Remove layout.css.ruby.enabled pref. r=dbaron 2015-12-01 09:39:37 +11:00
Xidorn Quan
4ecb3bdeee Bug 1202940 part 1 - Move html.css and ua.css back to be loaded in constructor of nsLayoutStylesheetCache. r=dbaron
DependentPrefChanged and InvalidateSheet are no longer used anywhere, but it is
probably better to keep them as-is, since we may need them again in the future.
2015-12-01 09:39:37 +11:00
L. David Baron
ee4294fedf Bug 1228501 patch 5 - Remove NS_FONT_DECORATION_* constants. r=jdaggett
Decorations in Gecko are associated with the CSS 'text-decoration'
property, so the constants should live in nsStyleConsts.h, as they
largely already do (since the names defined there are the vast majority
of the uses).
2015-11-30 14:02:26 -08:00
L. David Baron
58aa024e1b Bug 1228501 patch 4 - Remove nsStyleFont::CalcFontDifference, which now duplicates the list of tests in nsFont::Equals. r=jdaggett 2015-11-30 14:02:25 -08:00
L. David Baron
8fc316aea7 Bug 1228501 patch 2 - Remove nsFont::decorations member variable. r=jdaggett
The member variable was always set to 0 or to NS_FONT_DECORATION_NONE,
which is 0.

Although this does leave a gap in the structure, I don't see any
opportunities for reordering members to actually shrink nsFont.
2015-11-30 14:02:25 -08:00
Carsten "Tomcat" Book
3fb7508c0b Backed out changeset 91898a35b414 (bug 1224251) 2015-11-30 12:10:43 +01:00
Carsten "Tomcat" Book
fdd02de915 Backed out changeset 3a3cd254f508 (bug 1228501) 2015-11-30 12:10:38 +01:00
Carsten "Tomcat" Book
6aa7698031 Backed out changeset ec79945130ff (bug 1228501) 2015-11-30 12:10:35 +01:00
Carsten "Tomcat" Book
871230aca0 Backed out changeset cce90c9b7d1d (bug 1228501) 2015-11-30 12:10:34 +01:00
Carsten "Tomcat" Book
0b32eb2889 Backed out changeset 4a3c509bcb25 (bug 1228877) 2015-11-30 12:10:32 +01:00
L. David Baron
44dd382ffd Bug 1228877 - Make nsStyleContext::HasChildThatUsesGrandancestorStyle by setting bit on grandchild's parent instead of grandchild. r=xidorn 2015-11-29 23:15:37 -08:00
L. David Baron
51657f35c8 Bug 1228501 patch 5 - Remove NS_FONT_DECORATION_* constants. r=jdaggett
Decorations in Gecko are associated with the CSS 'text-decoration'
property, so the constants should live in nsStyleConsts.h, as they
largely already do (since the names defined there are the vast majority
of the uses).
2015-11-29 23:15:37 -08:00
L. David Baron
6392a39736 Bug 1228501 patch 4 - Remove nsStyleFont::CalcFontDifference, which now duplicates the list of tests in nsFont::Equals. r=jdaggett 2015-11-29 23:15:26 -08:00
L. David Baron
66e68e26cb Bug 1228501 patch 2 - Remove nsFont::decorations member variable. r=jdaggett
The member variable was always set to 0 or to NS_FONT_DECORATION_NONE,
which is 0.

Although this does leave a gap in the structure, I don't see any
opportunities for reordering members to actually shrink nsFont.
2015-11-29 23:15:01 -08:00
L. David Baron
542bc3abe1 Bug 1224251 patch 3 - Return nsChangeHint_UpdateUsesOpacity when opacity changes between 1 and non-1. r=xidorn 2015-11-29 23:15:01 -08:00
Mats Palmgren
204b656161 Bug 1227162 - [css-grid][css-align] Make the scrolled pseudo frame inherit more CSS Align / Grid properties. r=dholbert 2015-11-28 21:37:44 +01:00
Mats Palmgren
296017be07 Bug 1225592 - [css-grid] Apply a max limit to the number of explicit tracks we will store (kMaxLine - 1). Also make the layout code more robust so it doesn't depend on that. r=dholbert 2015-11-28 21:37:44 +01:00
Mats Palmgren
e5edd89526 Bug 1225376 part 2 - [css-align] Add mochitests for align/justify-items/self/content computed values. 2015-11-28 21:37:44 +01:00
Mats Palmgren
daefdf771a Bug 1225376 part 1 - [css-align] Don't compute left/right to start in the style system anymore (due to pending spec change). Map the used value instead (in layout). r=dholbert
For background, see this www-style thread:
https://lists.w3.org/Archives/Public/www-style/2015Nov/0280.html
2015-11-28 21:37:44 +01:00
Xidorn Quan
406c51b290 Bug 1040668 part 15 - Make the default value of text-emphasis-position aware of the language. r=dbaron 2015-11-28 11:56:33 +11:00
Xidorn Quan
936220069e Bug 1040668 part 14 - Add helper function nsStyleUtil::MatchesLanguagePrefix for doing simple language matching. r=dbaron 2015-11-28 11:56:33 +11:00
Xidorn Quan
78598e73d6 Bug 1040668 part 13 - Move first part of nsStyleFont::GetLanguage to nsPresContext::GetContentLanguage. r=dbaron 2015-11-28 11:56:33 +11:00
Xidorn Quan
bdd4660d35 Bug 1040668 part 10 - Implement emphasis mark rendering. r=jfkthame 2015-11-28 11:56:33 +11:00
Xidorn Quan
6238cc1a66 Bug 1040668 part 2 - Parse and compute text emphasis properties. r=dbaron 2015-11-28 11:56:33 +11:00
Xidorn Quan
ec0818c98f Bug 1040668 part 1 - Avoid queuing transition event for disabled properties. r=dbaron 2015-11-28 11:56:33 +11:00
Daniel Holbert
a7bc74cb18 Bug 1227377: Change ImageRequest::mRequests hashtable to use more specific type in its key (s/nsISupports/nsIDocument/). r=khuey 2015-11-27 14:54:47 -08:00
Boris Zbarsky
5e8b61d2d8 Bug 1226400 - crashtest for FontFaceSet::Load() crasher. r=birtles 2015-11-27 08:22:37 +09:00
John Daggett
5b79527e28 Bug 1226400 - throw an error in addition to returning null. r=bz 2015-11-27 08:20:55 +09:00
John Daggett
7bd20a139a Bug 1224975 - add telemetry for font loading. r=m_kato 2015-11-25 14:48:16 +09:00
Mats Palmgren
16d2dcd827 Bug 1227917 - Update |disp| after we've (potentially) cloned the Display struct so that subsequent tests of 'display' use the new value. r=jfkthame 2015-11-25 04:27:00 +01:00
Nicholas Nethercote
62223b6a10 Bug 1187144 (part 7) - Replace nsBaseHashtable::Enumerate() calls in layout/ with iterators. r=dholbert. 2015-11-22 21:37:07 -08:00
Nicholas Nethercote
26345d13fd Bug 1187144 (part 6) - Replace nsBaseHashtable::Enumerate() calls in layout/ with iterators. r=dholbert. 2015-11-22 21:35:32 -08:00
Nicholas Nethercote
6c2f70f4c9 Bug 1187144 (part 5) - Replace nsBaseHashtable::Enumerate() calls in layout/ with iterators. r=dholbert. 2015-11-22 21:20:54 -08:00
Nicholas Nethercote
9118e44c2e Bug 1187144 (part 4) - Replace nsBaseHashtable::Enumerate() calls in layout/ with iterators. r=dholbert. 2015-11-22 21:12:49 -08:00
Nicholas Nethercote
6336c5c219 Bug 1187144 (part 3) - Replace nsBaseHashtable::Enumerate() calls in layout/ with iterators. r=dholbert. 2015-11-22 21:08:23 -08:00
Nicholas Nethercote
458a919277 Bug 1187144 (part 2) - Replace nsBaseHashtable::Enumerate() calls in layout/ with iterators. r=dholbert. 2015-11-22 21:08:22 -08:00
John Daggett
24939405e6 Bug 1226400 - null-check GetParentObject(). r=m_kato 2015-11-25 16:05:18 +09:00