wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity
134,682 Commits 1 Branch 166 Tags 1.2 GiB
ab3082aff7
Commit Graph

610 Commits

Author SHA1 Message Date
Edward Lee
ab278f01cd Bug 556509 - folders description not synchronised [r=mconnor] 
Allow descriptions to be set on folder records and set description on creation.

--HG--
extra : rebase_source : d380f5d28130bd53532e5b4d293468aa053c19b2
 2010-04-01 15:11:42 -07:00
Edward Lee
05af24a32c Bug 535326 - Need to rethink tab sync limit of 25 [r=mconnor] 
Fit as many tabs as possible in 20000 characters by linearly estimating how many will fit then remove extras one by one.

--HG--
extra : rebase_source : 1ef3700a9cddd7e3cb0f96b9affada15e98ea672
 2010-02-17 18:24:22 -08:00
Mike Connor
23d76a73c9 bug 539056 - Better Tab sync UI and discoverability, r=Mardak 
--HG--
extra : rebase_source : d0c98d78b889ed74f5b130077a6ee1806bd81282
 2010-03-12 16:14:09 -08:00
Paul O’Shannessy
9aefb399d5 Bug 555015 - JavaScript strict warning: bookmarks.js: undeclared variable record [r=Mardak] 
Just make sure the record variable is declared before using it.
 2010-03-25 13:58:27 -07:00
Edward Lee
21f7747109 Bug 548066 - JavaScript strict warning: clientData.js, line 194: reference to undefined property this.clients[id] [r=mconnor] 
Get rid of get/setInfo on ClientEngine and ClientStore and expose functions to read/modify client data: stats, clearCommands, sendCommand. Also expose the local client information as local[ID,Name,Type,Commands] and rework the storage to use these instead of trying to keep the JS object clients entry in sync with prefs, etc. Update users of the old interface (service/tabs/chrome) to use the new local*. Set the client type based on app id instead of from each app's overlay.
 2010-03-16 16:39:08 -07:00
Edward Lee
15e1f02e87 Bug 554427 - Move syncID from clients.js to service.js [r=mconnor] 
Switch from Clients.syncID to this.syncID for service.js. Don't special case resetSyncID and just use = "".
 2010-03-25 16:52:45 +00:00
Edward Lee
af0bf0ab2a Bug 546772 - Encrypt the clients records [r=mconnor] 
Store data in cleartext instead of directly in the payload to have it encrypted with the CryptoWrapper. This cleans up some hacks needed to get the plain WBO client record to behave nicely with other encrypted data.
 2010-03-16 16:31:55 -07:00
Edward Lee
dced4ea743 Bug 554472 - Only sync prefs under extensions.weave.prefs.sync. (with a trailing dot) [r=mconnor] 
Add a "." to the end of WEAVE_SYNC_PREFS value and fix up uses that did extra work to remove the dot (or something that might not have been a dot).
 2010-03-23 18:51:47 -07:00
Paul O’Shannessy
59471f450c Bug 548939 - Use SessionStore in tab engine [r=Mardak] 
Created a fake SessionStore service for Fennec that imitates the parts of Firefox's SessionStore API that we need. Then used the now "consistent" SessionStore service in the Tabs engine.
 2010-03-16 15:14:32 -07:00
Edward Lee
1ce05d4603 Bug 549633 - Standardize record creation so all SyncEngines encrypt data [r=mconnor] 
Always add the id and encryption value so client and delete records can be encrypted.
 2010-03-05 14:46:48 -08:00
Edward Lee
a9c2e6c4c2 Bug 549632 - Remove storage cache, which is mostly un/incorrectly used [r=mconnor] 
Remove incorrectly used cache from some engines and clean up references from SyncEngine.
 2010-03-05 14:43:11 -08:00
Paul O’Shannessy
f39831ac01 Bug 546397 - Exception: Clients.getClients()[Clients.clientID] is undefined [r=Mardak] 
Overrode _wipeClient in ClientEngine; treat resetting the same as wiping.
 2010-02-19 13:36:42 -08:00
Edward Lee
3273de6ac1 Bug 545785 - Actively remove passwords that we don't want to sync 
Check if we haven't deleted yet, and if not, grab the guids for weave credentials and delete them from the server.
 2010-02-11 17:14:57 -08:00
Edward Lee
1ad29052b7 Bug 545767 - Clean up various names/strings needed for each set of engines/stores/trackers 
Pass the engine name when constructing a subclass engine and construct the store/tracker with the same name.
 2010-02-11 15:29:15 -08:00
Edward Lee
b8de893593 Bug 545764 - Convert constructor -> _init pattern to just use constructor 
Inline various _init calls and do super's init with <Super>.call(this, args..). Add various get/set sugar to those missing e.g., meta.keyring. Also simplify crypto record creation by setting cleartext in the parent.

--HG--
extra : rebase_source : 6c9a9f210f8f46ac338adb84188538e7353c9673
 2010-02-11 15:25:31 -08:00
Paul O’Shannessy
a3f801887c Bug 545487 - Cleanup TabTracker_observe [r=Mardak] 
Remove the "load" event listener and don't QI since we don't need to.
 2010-02-11 15:08:28 -08:00
Edward Lee
e238de1fc6 Bug 545701 - explicitly exclude Weave password/passphrase from pw sync 
Don't include weave passwords when getting all ids and ignore their changes.
 2010-02-11 15:05:22 -08:00
Edward Lee
ed5e098629 Bug 544068 - Assume moved bookmarks should be where they're moved 
Don't keep the annotation around in-case the predecessor/parent finally syncs because the user positioned it otherwise.
 2010-02-03 15:34:42 -08:00
Edward Lee
39e968e8de Bug 531489 - weave lost bookmarks with same url 
Do dupe detection for bookmarks like how we do folders/separators but check against the url/title. Add parentName to bookmark records, so bump version.
 2010-01-25 09:33:49 -08:00
Edward Lee
4cbaa75427 Lower tab logging to trace when wrapping tabs. 2010-01-21 09:59:27 -08:00
Edward Lee
8dfdbe920a Bug 526937 - Bookmarks are re-uploaded when they get visited 
Don't mark item as changed on a favicon notification to avoid churn that can result in merge messing up bookmark ordering.
 2010-01-19 11:24:00 -08:00
Edward Lee
48b1cf979f Bug 537954 - Some tabs don't get synced 
Listen for load before adding the unload listener (and the Tab listeners).
 2010-01-06 09:54:15 -08:00
Edward Lee
d3218dee1f Bug 535479 - Be smarter in getting rid of the "remote tabs" notification 
Add a tri-state pref that is unset, 0, or a number (modified time in seconds) and don't show the notification if it's in the "0" state. Unset pref means no modified time has been saved, and a non-0 state is the modified time of the last synced tab. So when tabs arrive with a different modified time, switch to the 0 state. Additionally, still remember if the user ever dismissed the notification and never show it again.
 2009-12-17 12:20:07 -08:00
Edward Lee
1213f59b7e Bug 534923 - Only show Mobile Bookmarks if there are mobile bookmarks 
Fix up existing users as well as only creating the place query under AllBookmarks if there are mobile bookmarks.
 2009-12-15 14:21:13 -08:00
Edward Lee
baf9c41432 Bug 534687 - Weave's pref syncing can sync lightweight themes in a broken fashion 
Trigger lightweight theme manager's currentTheme setter when changing the usedThemes pref.
 2009-12-14 16:05:07 -08:00
Edward Lee
c77f5b2807 Have wipeRemote wipe just the engines' data and make sure the clients process the command. 2009-12-10 18:39:51 -08:00
Edward Lee
a48b0da141 Bug 532936 - Add root level node for bookmarks synced from Fennec 
Create a mobile root in Firefox and link it to the Library UI as a query that fixes its own title if changed. Mark the mobile root on Firefox/Fennec as special so Weave uses "mobile" for the guid in the record, and items will appear in the appropriate folder.

--HG--
extra : rebase_source : fbd3afa2647204a370f7dacdf9d824e462ebb9b9
 2009-12-10 16:12:14 -08:00
Edward Lee
6f16e5f19c Bug 532770 - Allow tab sync's filtered urls to be set by pref 
Expose engine.tabs.filteredUrls as a string to be used as regex and filter case insensitively.
 2009-12-03 14:54:23 -08:00
Edward Lee
4676b9cb18 Bug 488922 - Treat bookmarks restore specially 
Add observers for bookmarks-restore-* and ignore changes during import and trigger a fresh start on success.
 2009-12-02 19:20:44 -08:00
Edward Lee
bef67b3db3 Bug 532173 - Don't sync tabs of some pages (weave firstrun, about:blank) 
Ignore certain filtered urls when creating a list of tabs for remote machines.
 2009-12-02 14:46:02 -08:00
Edward Lee
08eca0017c Bug 530717 - sync after wipe local should always replace local values with remote 
Always take the incoming item after a wipe and otherwise do the normal reconcile.
 2009-12-02 14:44:52 -08:00
Edward Lee
c5bc7653dd Bug 531239 - clear out duplicate/old machines from Clients record 
Get rid of persistent storage for clients and tabs to always fetch fresh records.
 2009-12-02 14:44:17 -08:00
Edward Lee
a46e202447 Share tab-gathering code for both createRecord and locallyOpenTabMatches. 2009-12-01 11:36:56 -08:00
Edward Lee
eb87765d7b Bug 530823 - Engines need to be able to specify a prefName for sharing prefs (different history types) 
Use prefName for checking if an engine is enabled and have forms share a prefName with history.
 2009-11-30 12:15:18 -08:00
Edward Lee
d4295ef8e9 Remove unused prefs and imports. (Bug 524916) 
--HG--
extra : rebase_source : 074e542f63ee840b61db7fe63a6c3540c13a31a5
 2009-11-25 17:49:15 -08:00
Mike Connor
7e923534c2 archive local bookmarks before wiping 
--HG--
extra : rebase_source : dd54af2118cf60c9e4f4b3bf08b7a5c61e9e78b8
 2009-11-25 17:09:32 -08:00
Edward Lee
df947df75e Bug 531177 - Tabs don't sync from firefox (when there's lots of tabs) 
Simplify tab record to just use deferGetSet like the other records and sort tabs based on their last usage to pick out a subset.
 2009-11-25 15:22:45 -08:00
Edward Lee
dd2f688ee2 Bug 531171 - Tabs don't always update 
Only expose that the tab engine knows about the current client's tabs, so always create/apply incoming and only create records tabs for local.
 2009-11-25 15:17:39 -08:00
Edward Lee
877e53a9da Bug 531170 - Tabs don't sync from fennec 
Add listeners for Fennec tab events the same way we do it for Firefox and share listener logic for various event types.

--HG--
extra : rebase_source : 685e45c16052db3d285c25c68db47680b7d15f72
 2009-11-25 15:14:56 -08:00
Edward Lee
b4233752d2 Bug 524916 - remove any/all code/images/strings that we aren't using anymore 
Remove unused sync engines (cookies, extensions, input, microformats, plugins, themes).
 2009-11-24 16:02:55 -08:00
Edward Lee
c05e0c5f94 Remove trailing whitespace from the codebase. 2009-11-20 14:34:20 -08:00
Edward Lee
d032f1effe Bug 527790 - Allow client names to be different from the default "Firefox" 
Generate a client name based on the logged in username, appname, hostname, and profile name.
 2009-11-19 23:31:04 -08:00
Edward Lee
c9efc4abfe Bug 514545 - weave mangles bookmarks 
For both folders and separators, use the parent name (not guid) in addition to the item's title/position to determine if it's a dupe. This modifies the bookmark format for folders and separators, so a storage version bump is needed.
 2009-11-19 21:34:17 -08:00
Edward Lee
19934febcc Bug 507666 - Handle deleting places history 
Use onBeforeDeleteURI to get the page's GUID and upload the delete record and process it by removing the page.
 2009-11-18 11:47:25 -08:00
Edward Lee
ac2b6c824d Bug 529103 - Removing folders must use removeItem not removeFolder 
Switch to Svc.Bookmark.removeItem from this._bms.removeFolder.
 2009-11-18 10:24:09 -08:00
Edward Lee
8b8ea72a82 Bug 528343 - Tabs don't sync 
Set the current client on any tab change for tracker.changedIDs and reset that when sync finishes.

--HG--
extra : rebase_source : 3100141bc1fdfaaa959b5f990a9538527761aace
 2009-11-12 14:48:54 -08:00
Edward Lee
79f980a983 Bug 527767 - Sync more history items on first sync 
Syncing 1000 items should be good enough for anybody......
 2009-11-12 13:51:28 -08:00
Edward Lee
2c1baed50d Remove unwanted info logging for bookmark indices. 2009-11-11 15:20:19 -08:00
Edward Lee
89460e2378 Bug 527766 - Sync history pages with a single visit 
Backout bug 518972 (6954c93b8903) so now we push all data instead of pages with more than 1 visit.
 2009-11-10 15:52:40 -08:00
Mike Connor
14acb12656 bug 518075 - tweak original patch and item values 2009-11-09 12:57:58 -05:00
Edward Lee
06bb9dbc7d Bug 519139 - Weave freezes the browser for 5-10 secs when starting sync 
Correctly remove the separator getter just like for folders to prevent triggering the lazy loader on every sync.
 2009-11-04 16:07:05 -08:00
Mike Connor
bcb7b750cb bug 485108 - drop status dialog, show status including engines on statusbar, remove dead status bits 2009-10-28 03:42:35 -04:00
Edward Lee
e5604f6745 Bug 517598 - Put useful interestingness/index values for bookmark 
Use places to figure out the frecency of a bookmark and give items (not just bookmarks) a bonus if it's sitting in the toolbar.
 2009-10-16 16:19:28 -07:00
Edward Lee
02e3dda699 Bug 517598 - Put useful interestingness/index values for history 
Additionally get the frecency for a history GUID/page when getting the url and title.
 2009-10-16 16:18:53 -07:00
Edward Lee
a9a420b1bb Keep the unsorted bookmark folder unsorted and not worry about the ordering. 2009-10-13 16:27:10 -07:00
Edward Lee
4f389c5c8a Bug 518972 - Only upload history records that have more than one visit 
Allow each engine to provide a custom Collection object and have History provide a collection that filters out certain data. This is inefficient because we have to first create then encrypt the record before we can filter it out.
 2009-09-25 16:52:12 -07:00
Edward Lee
51a7e2fb0b Bug 518958 - Only sync tabs if there has been tab activity 
Check the score, which gets bumped up on tab open/close/select, to decide if tabs should be marked as changed.
 2009-09-25 16:14:26 -07:00
Edward Lee
f042fdc078 Bug 514601 - Don't send DELETE for old history/form data on every sync 
Don't send any deletes as the server will do the delete with bug 518945.
 2009-09-25 15:30:26 -07:00
Edward Lee
666d0373fe Land about-weave on weave. Bug 516350 - about:weave round 3 followup fixes. r=thunder 2009-09-17 14:51:00 -07:00
Edward Lee
0611761d74 Use trace logging for reporting GUIDs. 2009-09-17 14:41:24 -07:00
Dan Mills
5094a04f3d initial patch 
--HG--
extra : rebase_source : 250c8f0d85483300147a6f0d691e0214db6d837b
 2009-09-15 21:54:05 -04:00
Edward Lee
7efe9c1d76 Merge weave-partial-view to weave. Bug 507429 - Partial sync download support. r=thunder 2009-09-11 16:48:58 -07:00
Edward Lee
7556f0c2cd Address review comments nits. r=thunder 2009-09-11 16:44:26 -07:00
Edward Lee
7f9b6c7f87 Be less chatty when showing GUIDs and ignore cases. 2009-09-11 14:39:48 -07:00
Edward Lee
e856402be7 Add some comments to partial download code and remove other comments. 2009-09-11 08:24:42 -07:00
Edward Lee
9380981a9e Merge weave to weave-partial-view. 2009-09-10 23:18:33 -07:00
Edward Lee
dadc08925c Use a short-circuiting check to determine if a history visit already exists. 2009-09-10 21:27:47 -07:00
Edward Lee
dc6d0cb84b Don't create a GUID when looking for dupes and set the GUID when adding a url. 2009-09-10 20:04:34 -07:00
Edward Lee
87de5afcd8 Detect dupe separators by identifying them by their position and generate the lookup lazily with the folder/title mapping for now. 2009-09-08 23:33:58 -07:00
Edward Lee
258a985cee Expose a _handleDupe on engines and provide a custom one for bookmarks that tracks GUID changes so that it can keep an alias mapping to fix incoming item properties (id, parent, predecessor). Move out _reparentOrphans so that it is triggered on update and not just create because folders can change ids to the right parent. 2009-09-08 23:33:15 -07:00
Edward Lee
0e889ae8fb Resolve bookmarks.js merge conflicts switching to batchSync (with trailing comma). 2009-08-31 18:04:40 -07:00
Edward Lee
5a3c53fd6a Merge weave to weave-partial-view w/ conflicts. 2009-08-31 18:03:35 -07:00
Edward Lee
678f177443 Detect dupe folders by title for now. Might need to update the hash during sync if titles are added. 2009-08-31 17:54:21 -07:00
Edward Lee
97e3f746cb Switch end-of-sync deletes to something SyncEngine is aware of and runs at _syncFinish. 2009-08-31 17:30:34 -07:00
Edward Lee
5e9d07e643 Use places utils to find an existing bookmark dupe for an incoming record. 2009-08-31 17:29:47 -07:00
Edward Lee
5468320159 Convert uses of recordLike/findLikeId to findDupe except Bookmarks is unimplemented. 2009-08-31 17:27:30 -07:00
Edward Lee
c70241b5ce Bug 512457 - Report errors before they get eaten up by runInBatchMode 
Save the exception from inside runBatched and not have runInBatchMode return failure, so we can then expose the exception.
 2009-08-31 16:28:00 -07:00
Edward Lee
4d055dc574 Bug 506297 - Livemarks with null site/feed uris cause sync to fail 
It's possible for livemarks to not have a siteURI, so don't assume it to be there.

--HG--
extra : rebase_source : 870bb41c980834ef3e5f302739d20adfed6f7f8d
 2009-08-26 14:22:11 -07:00
Edward Lee
dfe8e7e513 Don't include changes to special places Library "exclude from backup" items. 2009-08-25 16:15:05 -07:00
Edward Lee
ca002d3239 Create records with the correct parent/pred if it's still waiting for them to sync. 2009-08-24 16:17:59 -07:00
Edward Lee
94e6abd74c Extend Utils.anno to handle pages and clean up GUID code for history engine. Also fix a bug where changeItemID would set annotations to expire on session. 2009-08-21 14:29:37 -07:00
Edward Lee
a4b22bc213 Remove old dumping code for debugging bug 476903. 2009-08-21 14:29:35 -07:00
Edward Lee
381bdb6576 Bug 511794 - Always use _view instead of _temp + table or just table 
Also use subqueries instead of multiple queries and drop the query count down to 2.
 2009-08-21 14:29:30 -07:00
Edward Lee
c4393b5e3b Handle holes in bookmark folders and fix up bookmarks to be at an earlier position if a hole was detected. 2009-08-19 19:32:05 -07:00
Edward Lee
87f47c35a6 Attach followers for both created items and updated items (call from applyIncoming) when it's under the right parent. Share logic for attaching followers when creating a folder then fixing the reparented children and when creating/updating an item in the right parent. 2009-08-18 18:42:15 -07:00
Edward Lee
fae8b93210 Add the successor ids when adding/removing items as well as both old and new successors when moving. 2009-08-18 18:39:10 -07:00
Edward Lee
b264174b42 When updating the position of an item, move all of its followers with it. Share chain moving logic used for fixing followers on create and updating positions. 2009-08-18 18:36:31 -07:00
Edward Lee
0435aca087 For items that have the correct parent, see if there's an item following it and reposition the chain of items to after the correct parented item. A chain of followers starts at the item with the predecessor annotation and goes until the end of the folder, an item that is looking for a predecessor, or ends up at where we started (the predecessor). 2009-08-17 02:34:03 -07:00
Edward Lee
7a297f3b5f Simplify the debug output when creating bookmarks and include the parent and position. 2009-08-16 12:39:30 -07:00
Edward Lee
7c3bc745a0 Use the predecessorid to figure out where to put the item or save the predecessor as an annotation. 2009-08-16 12:39:15 -07:00
Edward Lee
96a4461af4 Set the predecessorid when creating records for upload. 2009-08-16 12:39:00 -07:00
Edward Lee
4cb51d9bde Remove the missing parent annotation after reparenting an orphan. 2009-08-15 14:43:10 -07:00
Edward Lee
306fc8507b Reparent orphans when creating the parent folder. 2009-08-15 01:07:40 -07:00
Edward Lee
7cc5c17773 Use a shared setGUID for new items and changing guids so that the item always ends up with the GUID (because conflicts shouldn't have been Weave generated). 2009-08-15 01:04:06 -07:00
Edward Lee
004fdf436d Store the parent GUID as an annotation if the item is missing a parent and share some parent lookup code. 2009-08-15 01:00:46 -07:00
Edward Lee
31270d064c Move _preprocess to before applyIncoming to share code for create/update/remove. 2009-08-15 01:00:32 -07:00
Edward Lee
cbba430108 Rename weaveId to just GUID and share a id<->guid function across store and tracker. 2009-08-15 00:59:49 -07:00
Edward Lee
fae7aaa071 Temporarily append everything and don't use sortindex for ordering within a folder. 2009-08-15 00:57:09 -07:00
Edward Lee
2335b057db Get rid of depth and sort on index instead. 2009-08-15 00:56:27 -07:00
Edward Lee
3ca750f464 Remove meta/mini records. Bye! 2009-08-13 18:50:54 -07:00
Edward Lee
39895d48b2 Put Annotations in Svc and expose a get/set Utils.anno call to use from bookmarks. 2009-08-13 17:59:26 -07:00
Edward Lee
983afb76a9 Remove unused bookmark annotations/constants. 2009-08-13 17:43:20 -07:00
Edward Lee
bc5f3d3be8 Bug 507296 - Sync bookmarks and history in batched mode. r=thunder 
Wrap the original SyncEngine._sync function with a call to runInBatchMode, so SQL disk writes happen at the end of batch mode instead of on every change.
 2009-07-30 11:52:26 -07:00
Edward Lee
1a4c241fc9 Change client engine to override findLikeId instead of recordLike to save on some work (iterating over changed ids). 2009-07-28 10:07:07 -07:00
Edward Lee
6ddbaa9a8e Bug 506795 - Handle adding duplicate logins. r=thunder 
Refactor reconcile to call findLikeId that by default will look for recordLike in the outgoing queue as it does now. Override findLikeId for password engine to search local logins.
 2009-07-28 10:06:02 -07:00
Edward Lee
551f097468 Convert various debug messages to trace. 2009-07-22 21:40:18 -07:00
Edward Lee
4f7ab3c5c2 Remove pref tracker init debug message. 2009-07-14 18:47:29 -07:00
Edward Lee
68d361380a Bug 504230 - Use Engine's logging level for Store and Tracker 
Use the log.logger.engine.* prefs to determine what the Store and Tracker should log with. This requires putting the same engine name on each Store/Tracker object, so there's some duplicate string values right now.
 2009-07-14 18:34:03 -07:00
Edward Lee
9fde263097 Bug 504216 - Force various engines to be disabled 
Have the disabled engines return null for enabled instead of the pref's true/false.
 2009-07-14 17:03:57 -07:00
Anant Narayanan
7cd35a2c36 Limit form history records (bug 494952, r=thunder) 
--HG--
extra : rebase_source : c3e983d30a14efd972eea2651a59be76924da256
 2009-07-14 12:28:18 -07:00
Edward Lee
5ad22f9709 Bug 479189 - weave does not sync tag smart folders properly 
Create a new record type, BookmarkQuery, to handle place: uri smart bookmarks. Store what tag name the query wants and lookup the id for that tag on other machines on create/update.
 2009-07-13 17:43:15 -07:00
Edward Lee
22570f2932 Bug 503938 - Tags with a single bookmark keep generating new tag ids 
Share a tagging code for create/update that will tag a dummy uri temporarily while it untags the bookmark to make sure every tag has at least one child during this untag/tag process.
 2009-07-13 13:40:49 -07:00
Edward Lee
6ddece8b22 Bug 502482 - error while syncing bookmarks from server 
Set the item type for generic PlacesItems, but don't do anything when trying to create it.
 2009-07-09 17:15:00 -07:00
Edward Lee
5c482eea0d merge weave. resolve comments added to resource.js. 2009-07-09 11:21:20 -07:00
Edward Lee
1c1025b37d Convert a log.info to log.debug for passwords so it doesn't clutter the brief log. 2009-06-25 22:52:28 -07:00
Edward Lee
39f333a78e Bug 500598 - Undefined item in tabContainer.childNodes after closing tabs 
The childNodes NodeList keeps its indices even after removal, so it's safer to convert the array-like thing into an actual array. Condense the QueryInterface code to the instanceof magic.
 2009-06-25 22:46:14 -07:00
Edward Lee
84c52a6411 merge weave. resolve addition of kSpecialIds to bookmarks.js near removal of Async.sugar. 2009-06-23 22:34:57 -07:00
Anant Narayanan
22bd439624 Change priority of some log messages to trace 2009-06-22 18:19:42 -07:00
Edward Lee
eeef9a8201 Bug 487282 - "browser is null" error in tabs.js 
Share browser detection code for register and unregister tab listeners and better check for tabbrowser windows.
 2009-06-22 15:53:42 -07:00
Edward Lee
ad7d001bb3 Bug 498924 - Refactor bookmark special ids out of BookmarksStore 
Lazily load places ids for a given weave id/place name pair into kSpecialIds and update all consumers. Expose a Svc.Bookmark in utils.
 2009-06-17 09:28:15 -07:00
Edward Lee
3ef568c718 Cleanup/refactor followup to bug 481327. 
Change _ignore to take itemId to find folderId and pull out addChanged/getItemGUID/upScore to addId.
 2009-06-17 08:51:54 -07:00
Edward Lee
34400917b0 Bug 481327 - Script gets stuck during startup. r=Mardak 2009-06-17 08:51:54 -07:00
Mikhail Stepura (mishail)
fde4deb743 Bug 486042 - "Load this bookmark in the sidebar" status not synced. r=Mardak 2009-06-16 16:16:39 -07:00
Philipp von Weitershausen
210f20ecd4 Bug 652666 - ltm is not defined in prefs engine. r=rnewman 2011-04-25 22:07:47 -07:00
Edward Lee
57adfb688b merge weave 2009-06-06 13:12:03 -07:00
Edward Lee
df1fc601da Fix form engine to correctly pass in the engine. 2009-06-05 18:36:31 -07:00
Edward Lee
6bc0e717ec Clean up various engines to remove Async.sugar and random self/yields. 2009-06-05 15:34:40 -07:00
Edward Lee
68ce1e4224 Change SyncEngine._reconcile to not be async/yield. 2009-06-04 14:18:04 -07:00
Edward Lee
428d54a14a Change Resource.get() to be sync (no callback) and fix up call sites used for login + sync now. 2009-06-04 10:16:07 -07:00
Wladimir Palant
753b7da199 Bug 495996 - Bookmark observer doesn't implement onBeforeItemRemoved method. r=Mardak 2009-06-02 21:25:55 +02:00
Wladimir Palant
8f33b68063 Bug 495924 - TabTracker wrongly assumes that "this" pointer will be set correctly for event handlers 2009-06-02 11:25:37 +02:00
Anant Narayanan
252a823626 Preference sync (bug #428370) 2009-05-24 02:11:05 +02:00
Anant Narayanan
dbad6932cb Use first login found if there are multiple GUIDs 2009-05-24 00:25:30 +02:00
Anant Narayanan
b6a3ce9d6e Use searchLogins instead of caching passwords (bug #489268) 2009-05-24 00:03:53 +02:00
Edward Lee
0a32933db7 Bug 493004 - Create stubs of unimplemented engines to list them as disabled (extension, microformat, plugin, theme) 
Add the 4 engines with just the base code to set their name and register them for Firefox.
 2009-05-14 11:50:59 -05:00
Edward Lee
93847aa32d Bug 493002 - List partially implemented engines (cookies, input history) as disabled 
Import the outdated engines, but delete their pref so they show up as disabled. Clean up the old engines a little bit so they don't allocate unnecessarily and to not use syncCore.
 2009-05-14 11:43:56 -05:00
Edward Lee
690c26f9d5 Fix form engine displayname to displayName 2009-05-14 11:09:08 -05:00
Edward Lee
48f3b8796d Remove old Firefox 3 places DB code. 
Min version is 3.1/5, so we grab DBConnection from places directly now.
 2009-05-13 16:31:42 -05:00
Myk Melez
bab5749a17 bug 492435: work around crasher bug 492442 by not calling isVisited for a history entry without a URL; r=thunder 2009-05-11 16:11:04 -07:00
Edward Lee
e55cf3a52a Bug 488190 - Use record properties instead of cleartext properties 
Switch pretty much all references to cleartext in modules/engines/ to just use the record. Also clean up some references to null cleartext to use deleted. The only reference to cleartext is to iterate over that hash in bookmarks.
 2009-04-13 16:39:29 -05:00
Edward Lee
2c5fc6c54f Bug 488170 - Consistently set record cleartext URIs as text spec uris 
Switch cleartext properties to Uri that always takes a text spec, so eventually URI refers to nsIURI. GeneratorURIs seems to have been broken either way.. makeURI of an already URI and storing of a URI into cleartext. This landed with changes to keys, so the server wipe also handles the local name changes.
 2009-04-13 16:39:29 -05:00
Edward Lee
b7a138755c Bug 488142 - Make it easier to add simple deferred cleartext/payload values 
Add a couple Utils helper to create a pair of simple [gs]etters that use a hash property instead. Apply this to various records: WBORecord, {Priv,Pub}Key, Crypto{Meta,Wrapper}, and every engine's type records. Migrate by making sure key data exists (name change).
 2009-04-13 16:39:29 -05:00
Edward Lee
253a6ca0d8 Bug 488182 - Use an Iterator to grab both key and values from cleartext for processing bookmarks 
Get rid of extra record.cleartext references within the for/each/switch -- even for unused keys like incomingSharedAnno.
 2009-04-13 16:18:11 -05:00
Edward Lee
9a582a606e Bug 488165 - Correct set the record object type when processing records 
Set _recordObj for Bookmarks/History engines and override PlacesItem.decrypt to switch itself to the right type after CryptoWrapper decrypts the payload.
 2009-04-13 14:54:31 -05:00
Dan Mills
c92f210ac9 oops fix missing .prototype 2009-04-10 17:30:05 -07:00
Dan Mills
a789863032 Remove __proto__.__proto__ it's fail-prone 2009-04-10 16:08:31 -07:00
Dan Mills
67fd1f1e82 can't get guid on expiration 2009-04-10 16:04:13 -07:00
Edward Lee
f1f0742fae Bug 487541 - form submission caused exception 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface] 
Get rid of the QueryInterface and just use instanceof while copying the logic of nsFormHistory::Notify to avoid divergent logic until satchel provides a notification.
 2009-04-08 22:48:26 -05:00
Dan Mills
ebca2e9c0f don't track history deletes at all; don't built id->guid mapping hash for history tracker 2009-04-08 18:11:14 -07:00
Myk Melez
c699fdf732 switch from --utc to -u flag to enable UTC output for date command so it works on both Linux/Windows (which support --utc in addition to -u) and Mac OS X (which only supports -u) 2009-04-08 15:00:02 -07:00
Edward Lee
d6a16ace0a Bug 487378 - Use the app name as the default client name 
Use nsIXULAppInfo to get the name and remove Fennec specific bits.
 2009-04-08 02:12:57 -05:00
Mikhail Stepura
e97e9389db Bug 486481 - Weird behavior when syncing the bookmark with tags 
Add the remaining special top level folders and ignore them for certain behavior like getAllIDs and wipe. Have the tracker ignore changes to things in the tags folder.
 2009-04-07 23:17:40 -05:00
Edward Lee
25b484a48a Bug 487363 - Share bookmark tracker ignore logic 
Share the ignore logic that takes a parent folder and ignore if the engine says so or it's a livemark.
 2009-04-07 22:56:04 -05:00
Edward Lee
09653caf66 Bug 487338 - Track special folder weave GUIDs <-> bookmark id mapping 
Create a specialIds hash and use it to for getting weaveId/id, determine top level, if a folder is a root, getting all ids, wiping, and tracker ignoring.
 2009-04-07 19:22:36 -05:00
Anant Narayanan
da004b2423 Update form sync engine to work with Weave0.3/FF3.5 2009-04-06 19:05:16 +02:00
Edward Lee
3993035a59 Bug 482670 - WBORecord should implement a .deleted property 
Expose a .deleted property that engines can set to true to store an even thinner deleted payload (empty string "" instead of "[null]") on the server. Handle deserializing of deleted records by setting the property. Note: Engines must set their payloads to something JSON-able if it's not a delete record.
 2009-04-03 12:38:47 -05:00
Edward Lee
eebdf48521 Bug 486667 - Clients get amnesia -- forget who they are after a wipe 
Set the local client info after resetting the clients store hash
 2009-04-03 09:26:12 -05:00
Edward Lee
2e72dcf2a7 Bug 480929 - RSS names not synced 
Set the title in the record just like any other bookmark (folder)
 2009-04-01 17:12:08 -05:00
Edward Lee
0d1e91ca16 Bug 482896 - Unify local client data and remote client data storage 
Initialize unified client store from disk json and local prefs and update on pref changes + sync. Clean up client engine code (local vs inherited, alphabetical), and create a helper modify() to save snapshots.
 2009-04-01 01:56:32 -05:00
Edward Lee
b0633f2208 Bug 486234 - Give changes json file name for history, passwords 2009-03-31 20:07:43 -05:00
Edward Lee
ba7af5037c Bug 486230 - Share json disk caching with Utils.json{Load,Save} 2009-03-31 19:52:16 -05:00
Edward Lee
4f6ebe6be5 Bug 481741 - Switch to JSON from nsIJSON 2009-03-31 14:09:38 -05:00
Dan Mills
fd14693e9f Bug 478328: delete old history data from the server 2009-03-30 15:19:00 -07:00
Dan Mills
9df4203349 remove dump() debugging from tabs engine 2009-03-30 15:18:20 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
53fa9e5846 Bug 485539 - added guard to the tab engine to handle the case where there are undefined items in tabContainer.childNodes. 2009-03-27 11:06:43 -07:00
Dan Mills
51c55c8f41 Bug 484848: try #3 2009-03-26 10:58:54 -07:00
Dan Mills
f6f3adc09e Bug 481319: try again 2009-03-25 19:47:37 -07:00
Dan Mills
4abd146e4f merge upstream changes 2009-03-25 19:33:51 -07:00
Dan Mills
a3725fab15 Bug 484848: modifyLogin sends an array of nsILoginMetaInfos to observers 2009-03-25 19:27:24 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
b690a2858d Fixed name of TabStore.changeItemID so that it correctly overrides the abstract base class method. Whoops. 2009-03-25 17:36:11 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
6555e1e1ef Experimenting with getting tab last-used-time data on Fennec 2009-03-18 12:40:27 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
0f809c8372 Removed unused code from tab tracker. 2009-03-17 18:02:13 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
a6e05ab37a TabTracker now keeps track of when each tab was most recently used; tabStore wraps this data for sync, and fennec UI uses it to sort incoming tabs by most-recently-used date. This fixes 481326. 2009-03-17 17:57:53 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
95ae06e497 If you click the button to show synced tabs before Weave has been configured, it will now take you straight to the sign-in screen. Fixes bug 482818. 2009-03-16 16:49:56 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
859e51e20b The remote-tabs menu (on both firefox and fennec) no longer shows tabs you already have open locally. Fixes bug 480405. 2009-03-12 15:54:26 -07:00
Edward Lee
dfc2d1f68a Bug 481266 - Provide a way to perform actions on remote clients. r=thunder 2009-03-03 17:29:35 -06:00
Dan Mills
489e86bdc5 oops, client was not updating depth/index of records 2009-03-11 02:02:58 -07:00
Dan Mills
7b9eedde66 Bug 478327: Send minimal '[null]' payload for deleted records 2009-03-11 01:40:04 -07:00
Edward Lee
a45ed6623b Bug 482178 - Clean up services -> lazy services. r=thunder 2009-03-10 06:30:30 -05:00
Dan Mills
2e61ae02f3 remove dump() debug statements 2009-03-10 01:20:50 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
02d92a86ca Fennec now launches first run page, and updates extensions.weave.lastversion, so that it's no longer resetting syncId and therefore resetting the server every single time it tries to sync. Also set the download in resource.js to use LOAD_BYPASS_CACHE. Together these changes seem to fix bug 480270. 2009-03-07 00:55:47 -08:00
Edward Lee
edda1db597 Bug 480457 - Expose a resetClient API for weave service and engines. r=thunder 2009-02-26 22:36:14 -08:00
Dan Mills
bf29e922ae disable recordLike for clients 2009-03-03 11:53:56 -08:00
Dan Mills
47ac6a5d0c create new records with correct guid set 2009-03-03 01:48:13 -08:00
Dan Mills
26e63650e6 override _recordLike for passwords; add logging calls; make getAllIDs return full nsLoginInfos 2009-03-03 01:32:10 -08:00
Dan Mills
3e1235a9e5 Switch away from __defineGetter__ due to bug 481104; explicitly cache logins in password engine; whitespace fixes 2009-03-02 18:55:26 -08:00
Anant Narayanan
0f6fdde06c Remove getter that fixes the 'two-store' problem 2009-03-03 01:15:48 +01:00
Anant Narayanan
088a5457a5 Rename methods to be less confusing 2009-03-03 00:57:37 +01:00
Anant Narayanan
05dfbc7c8a Password sync for 0.3 (bug #468697) 2009-03-03 00:42:57 +01:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
ff833098f5 Resource.js now always validates the cache (VALIDATE_ALWAYS) when downloading stuff. This seems to fix bug 480270 on Firefox but not on Fennec. 2009-02-27 18:28:26 -08:00
Dan Mills
f17dafb475 fix args list for observe() 2009-02-26 17:37:49 -08:00
Dan Mills
7cdfbeed20 track local client data changes so we can upload it as necessary 2009-02-26 15:06:57 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
85f96743c6 Changed how firefox populates tabs-from-other-computers menu and how it opens a tab picked from that menu, so that it can restore the history of the tab and not just the latest URL. 2009-02-25 00:56:46 -08:00
Dan Mills
c46ffd1071 random fixes, actually syncs client data now :) 2009-02-20 01:52:07 -08:00
Dan Mills
bc248c608c don't load old crypto module 2009-02-20 01:49:00 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
94e49ca097 Tab sync now skips empty tabs. This fixes bug 479216. 2009-02-19 11:20:23 -08:00
Dan Mills
128ac21239 go back to storing the local client name and type as prefs. also store a 'syncID' (gets reset upon a server wipe) 2009-02-19 04:07:23 -08:00
Dan Mills
d0e9169992 pass the cryptoMetaURL to the store's createRecord 2009-02-19 00:36:55 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
2d099f33ea Fixed a bug with my fix -- I had inadvertently created an infinite loop. 2009-02-18 22:23:48 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
cffc8dfb3a Fixed a bug in how Firefox gets URL history to save when syncing tabs up. Also some more work on the Fennec tabs UI. 2009-02-18 18:18:50 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
59677a949c First pass at Fennec tab UI. There's now a button that opens a fullscren panel from the left, which contains the names of all remote tabs. They're not clickable yet. 2009-02-17 16:28:54 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
b1ffa834cc Tab sync works, and has UI in firefox (though not yet in Fennec) 2009-02-11 19:14:25 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
4f990b3937 Fixed bug in tab encoding in Firefox. 2009-02-10 22:15:25 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
941849dd9d Fixed tab encoding bug on Fennec 2009-02-10 21:54:11 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
1506738c72 Fennec tabs and Firefox tabs now handled in different functions, and the Fennec one at least works. 2009-02-10 19:23:06 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
c5df6dd7dd SessionStore not available on Fennec, so now using alternate methods to get the list of tabs. 2009-02-09 21:16:18 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
6137ee85a6 Fixed some minor problems with TabEngine; identified places where TabEngine will need to use alternate methods to work on Fennec. 2009-02-09 20:23:42 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
98ba92c195 Switched TabTracker to register listeners on window open and remove them at window close -- need to find an alternate way to make this work on Fennec, where windows don't have tabContainers. 2009-02-06 17:50:12 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
bab93ee645 Added debugging info to TabEngine. Instantiated and registered TabEngine in both Firefox weave glue and Fennec weave glue. 2009-02-06 11:19:50 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
cde0013f0f Rewrote tabs engine to work with 0.3 API. (Not yet tested). 2009-02-04 19:51:20 -08:00
Dan Mills
5b9b4696f2 ignore all events when tracker.ignoreAll is true; ignore most bookmark annotations (except for the ones we sync) 2009-02-02 11:43:06 -08:00
Dan Mills
abdf4fec19 set record ID for bookmark deletes too 2009-01-27 17:23:23 -08:00
Dan Mills
465c145c78 set record ID in history store when creating a record 2009-01-27 17:08:47 -08:00
Dan Mills
03d78b3d84 set record IDs inside the store; fix bookmarks tracker, it was ignoring change events (e.g., changed title and such) 2009-01-27 16:54:54 -08:00
Dan Mills
a3d9640e3c Make records not extend Resource, instead they have a serialize() method that can be used to create a Resource for uploading if necessary. 
Use global service instances under Svc.*
Consolidate various record managers (caches/convenience factories) to extend the same base object
Log exceptions caught by notify wrapper
 2009-01-27 13:35:10 -08:00
Dan Mills
be7f853da4 make it so clients list can be modified from any client, and so it doesn't upload client info on every sync; clients list no longer stores data (except the local client's guid) in the firefox prefs 2009-01-23 15:09:21 -08:00
Dan Mills
a94f85b7c3 wrap microsummary creation code in try/catch; catch unknown items during onItemMoved (should not happen, but...) 2009-01-21 19:04:13 -08:00
Dan Mills
914ac78e2a simpler reconciliation for history 2009-01-20 13:13:31 -08:00
Dan Mills
704d1c079a fix url vs uri typo 2009-01-15 18:43:44 -08:00
Dan Mills
6891a3b69a merge upstream changes 2009-01-15 15:53:51 -08:00
Dan Mills
fedd698bbb fix typo 2009-01-15 15:53:34 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
e823363952 Merged 2009-01-15 14:06:00 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
cd797f05a7 Added a method to historyStore called tempTableExists which does a SELECT (rather than using tableExists) to correctly tell whether a temp table is there or not, so that historyEngine will work correctly on both Fennec and Firefox (See bug 472963) 2009-01-15 14:05:50 -08:00
Dan Mills
3dd2a14339 Bug 468671: Don't synchronize livemarks. Based on patch by Jorge Alves <jag.alves@gmail.com> 2009-01-15 13:58:59 -08:00
Dan Mills
67f99f74cd add some extra log info to engine; have tracker ignore all changes when applying a change to prevent the tracker from generating new guids for new items before the store has a chance to set the right one 2009-01-14 22:01:04 -08:00
Dan Mills
23aaa6fcb7 disable unused engines; fix trackers trying to call enable which is gone now; improve bookmarks tracker logging 2009-01-13 16:55:51 -08:00
Dan Mills
d34aba46fd make tracker return true/false when adding a changed ID to indicate if it was a valid add or not; change bookmarks & history trackers to match; fix some problems in bookmarks tracker 2009-01-13 15:55:35 -08:00
Dan Mills
445916b2e6 ignore/unignore specific weave IDs instead of a blanket enable/disable of the tracker during sync. 2009-01-13 14:43:21 -08:00
Dan Mills
51d51a26ed small getchildren/getsiblings cleanup 2009-01-13 13:40:40 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
730c9b4ef5 History sync now works in Fennec, by simply skipping all the temp tables that don't exist in Fennec. This should also fix bug 472853 for weave in Firefox. 2009-01-09 15:44:27 -08:00
Dan Mills
3c586f5121 merge upstream changes 2009-01-08 21:34:43 -08:00
Dan Mills
ee4044e7e1 when an orphan bookmark is found, reparent it to the unfiled bookmarks folder 2009-01-08 21:33:59 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
308841e718 Merged 2009-01-08 16:59:56 -08:00
Dan Mills
793c17b023 commit so hg will let me merge 2009-01-08 16:57:35 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
8bff01bd48 The Weave check box on the Fennec preferences screen now logs you in/out when you click it in addition to enabling/disabling the scheduler. Improved the fennec-connect page by making the text fields auto-select when you click in them and turning the 'accept TOS' check box into a button. 2009-01-08 16:37:36 -08:00
Dan Mills
f65179b732 set guid when creating history entries 2009-01-07 17:46:31 -08:00
Dan Mills
7167b95ceb Bug 472480: catch errors when changing history item IDs 2009-01-07 15:01:12 -08:00
Dan Mills
ff240dd3ce add clients sync (list of clients with names and types); make it simpler to create Engine subclasses; remove the 2nd 'authenticator' parameter for Resources; resetServer is now wipeServer; consider 0 an invalid place ID (fixes bug when calculating item depths); add a Svc global exported from utils.js where commonly used services can live 2009-01-06 13:54:18 -08:00
Dan Mills
767ad5d9b3 update history engine to work again with latest engine changes, and re-enable history sync 2009-01-03 01:04:17 -08:00
Dan Mills
34a114606d fix depth/index record generation 2009-01-02 21:13:32 -08:00
Dan Mills
df54949485 extra debugging to catch getFolderIdForItem errors 2009-01-02 19:35:23 -08:00
Dan Mills
fd1579088c fix tracker's onItemRemoved 2009-01-02 16:16:38 -08:00
Dan Mills
5e7867a4de add a _getWeaveParentIdForItem method; fix getAllIDs; add a createMetadataRecord method 2009-01-02 13:49:19 -08:00
Dan Mills
5e3ac9586e add a generic cache class for storing records during reconciliation. cache has 100 item limit, and is cleared before and after reconciliation so the OS can reclaim memory after GC 2008-12-30 23:52:20 -08:00
Dan Mills
380b614133 make engine keep less records in memory by limiting the outgoing queue to a maximum of 100 records, and fetch the rest from the store each time 2008-12-29 23:28:17 -08:00
Dan Mills
6b260498e0 switch to generating individual bookmark records directly from the places store, without using a cache (to improve memory performance); create objects for bookmark types; temporarily disable history sync 2008-12-28 19:59:44 -08:00
Dan Mills
58318f5332 remove commented-out code 2008-12-26 21:50:07 -08:00
Dan Mills
62a45ad0ab Various engine/bookmark changes: 
* Rely on the server to sort incoming records, remove all sorting code client-side.
* Streamline sync to be able to process incoming records one at a time, as soon as they are downloaded.  This changes reconciliation to be able to process a single incoming record.
* Engine base class will automatically convert parentid, depth, and sortindex into toplevel WBO objects.  This is good for now but kinda broken, engine subclasses should really be generating WBO records themselves.
* Since index is now a toplevel WBO property, there is no need for the bookmarks sync code to subclass recordLike.
* Refactor bookmarks store to be a little cleaner and work directly with records instead of "commands".
 2008-12-23 11:30:31 -08:00
Dan Mills
92a77b80e1 remove accidentally committed logging calls 2008-12-23 11:23:10 -08:00
Dan Mills
efdd9ff7cf fix typo in history sql queries, clarify valid sort order values for collections 2008-12-19 17:00:12 -08:00