Commit Graph

1483 Commits

Author SHA1 Message Date
Marco Bonardo
877c2f729e followup to bug 459934, fix memory leak, mpa=mano, for post facto review 2008-10-17 08:56:25 -04:00
Marco Bonardo
4d5942f11f Bug 459934 - should lazy-load places autocomplete statements
r=dietrich
r=sdwilsh
2008-10-17 06:12:53 -04:00
Shawn Wilsher
8cb912ef64 Bug 459789 - lazily get mDB[Invalid|Old]Frecencies
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
10cebaa66f Bug 459788 - Lazily get mDBBookmarkToUrlResult
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
2f47ae77b2 Bug 459786 - lazily get mDBVisitTo[Visit|URL]Result
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
653538e53f Bug 459787 - remove mDBUrlToUrlResult
This changeset removes an unused query that was in the startup path.
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
bb7e0e8c36 Bug 459781 - create our string bundle in a more sane way
This changeset only creates the string bundle when we need it, and only in one
place as opposed to two separate places.
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
d9d1b7f304 Bug 459776 - date formatter is unused
This changeset removes a small part of code that places does in startup that is
not used or needed.
r=dietrich
2008-10-17 06:12:52 -04:00
Shawn Wilsher
1d0921f3e0 Bug 459773 - Creating a collation is expensive
This makes a lazy getter for getting our collation saving us about 3% of places
startup time.
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
867daf5b5f Bug 455474 - cleanup nsNavBookmarks::Init
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
53ea567322 Bug 459491 - nsPlacesDBFlush could use async queries instead of background thread
r=sdwilsh

--HG--
rename : toolkit/components/places/tests/background/head_background.js => toolkit/components/places/tests/sync/head_sync.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_modifyBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_modifyBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_quit_application.js => toolkit/components/places/tests/sync/test_database_sync_after_quit_application.js
rename : toolkit/components/places/tests/background/test_multiple_bookmarks_around_sync.js => toolkit/components/places/tests/sync/test_multiple_bookmarks_around_sync.js
rename : toolkit/components/places/tests/background/test_multiple_visits_around_sync.js => toolkit/components/places/tests/sync/test_multiple_visits_around_sync.js
2008-10-17 06:12:52 -04:00
Shawn Wilsher
f5d2e83ae5 Bug 459315 - Wrap favicon work in a transaction
This wraps a series of statements that run on the main thread to reduce the
number of fsyncs that end up happening.
r=dietrich
2008-10-17 06:12:52 -04:00
Shawn Wilsher
4d5fb2f862 Bug 459299 - nsNavHistory::SetPageTitleInternal is slow
This caches a statement that is created any time a pages title changes.  The
creation of the statement took roughly 66% of the functions execution time
according to shark.
It also removes a transaction that was not needed in this method.
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
b71369cd19 Bug 456029 - optimize the temp table triggers
This changeset makes the triggers work much faster which should greatly reduce
the timings of adding a visit and a bookmark.
r=sdwilsh
2008-10-17 06:12:52 -04:00
Shawn Wilsher
4f97936d8c Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77

--HG--
rename : toolkit/components/places/tests/unit/head_bookmarks.js => toolkit/components/places/tests/background/head_background.js
2008-10-17 06:12:51 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
5715c324ab Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-10-17 06:12:51 -04:00
Shawn Wilsher
5790687517 Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-10-17 06:12:50 -04:00
Shawn Wilsher
810e90b149 Bug 460315 - set journal_mode to TRUNCATE
Sets the journal_mode to the places database to TRUNCATE
r=dietrich
2008-10-16 15:59:33 -04:00
Ehsan Akhgari
7ebe50fe0c Bug 459988 - Download manager does not send the dl-cancel notification, r=sdwilsh 2008-10-15 10:57:23 +03:30
Ehsan Akhgari
4c6e8ba514 Bug 457110 - Support in-memory DB for the downloads manager back-end, r=sdwilsh 2008-10-15 10:54:52 +03:30
Marco Bonardo
564c306794 Bug 458683 - Backup only uri nodes into tag containers, r=dietrich 2008-10-14 17:24:08 +02:00
Neil Rashbrook
b50d21d9c9 Bug 459571 Places autocomplete results contain incorrect search string r=sdwilsh,mardak 2008-10-14 14:54:17 +01:00
Neil Rashbrook
434a05f6c1 Bug 459329 Download Manager should honour --disable-vista-sdk-requirements r=sdwilsh 2008-10-14 14:48:55 +01:00
Marco Bonardo
3b22c3d551 Bug 457698 - nsNavHistoryFolderResultNode::OnItemAdded ignores dynamic containers, r=dietrich 2008-10-13 18:14:50 +02:00
Marco Bonardo
6d926ff1b7 Bug 457686 - appendURINode should not append to a dynamic container if we are inside an excludeItems query, r=dietrich 2008-10-13 18:06:50 +02:00
Marco Bonardo
56441e9d6e Bug 457681 - if ExcludeReadOnlyFolders is false, readonly dynamic containers are still excluded, r=dietrich 2008-10-13 17:58:36 +02:00
Marco Bonardo
b1351fc910 Bug 457677 - PlacesUtils ignores dynamic containers, r=dietrich 2008-10-13 17:54:25 +02:00
Markus Stange
47b6afd709 Merge backout of bug 398928 2008-10-13 14:33:01 +02:00
Markus Stange
b6747539e3 Backed out changeset 151e51ec625e (bug 398928) because of unit test orange 2008-10-13 14:30:47 +02:00
Marco Bonardo
68881489cf Bug 458013 - QueryResultNode Tag refresh optimization is useless as it is, r=dietrich 2008-10-13 14:11:27 +02:00
Markus Stange
6cbd4557ec Bug 398928 - Allow moving a window by dragging toolbar or statusbar, r=enndeakin 2008-10-13 11:24:51 +02:00
Justin Dolske
d2a5ba9d51 Bug 394611 - Always prompt the user before changing a stored password. r=gavin
(relanding with workaround to avoid leak)
2008-10-12 20:05:11 -07:00
Ben Turner
311284ddff Bug 455436 - "XPConnect insists on using its own error reporter even when another is already set." r+sr=jst. 2008-10-12 11:32:34 -07:00
Justin Dolske
d3e7c4da65 Merge retardedness. 2008-10-10 21:42:19 -07:00
Justin Dolske
1d366de337 Backed out changeset 2f36cde1694c (bug 394611, due to leaks) 2008-10-10 21:39:25 -07:00
Jim Mathies
4976b1709a Bug 445158 - Consider providing a pref that allows users to avoid check for "Launching Applications and Unsafe Files" Internet option; r=(sdwilsh + tellrob) 2008-10-11 03:15:51 +02:00
Steffen Wilberg
afdcf5bda0 In about:config, make accel+f focus the filter box instead of invoking the find bar; r=neil 2008-10-11 03:10:48 +02:00
Justin Dolske
addac0ea7f Bug 394611 - Always prompt the user before changing a stored password. r=gavin 2008-10-10 18:05:48 -07:00
Justin Dolske
9b815f280a Bug 426991 - Form submission extremely slow on large forms (with form Form history turned on). r=sdwilsh, r=gavin 2008-10-10 14:51:49 -07:00
Arpad Borsos
8b11d938d2 Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan 2008-10-10 17:04:34 +02:00
stefanh@inbox.com
afd0f25554 Follow-up fix for bug 458775 (actually use the right attribute). NPOTDFB. 2008-10-09 19:30:47 +02:00
stefanh@inbox.com
f550b0f0e5 Bug 458775 - Make use of new search textbox widget in Help. r=dao. NPOTDFB. 2008-10-09 18:32:45 +02:00
Robert Sayre
6579c458ac Merge. 2008-10-08 21:17:03 -04:00
Shawn Wilsher
acda45683c Backout of places fsync work. 2008-10-08 20:43:03 -04:00
Shawn Wilsher
8b2eb62a70 Removing debugging code from earlier today in the download manager test. 2008-10-08 19:37:05 -04:00
Robert Sayre
bef8140a39 Bug 458959. this.JSON is enumerable. r+sr=mrbkap 2008-10-08 19:33:26 -04:00
Shawn Wilsher
de1e984f08 More test file cleanup so failed runs don't cause perpetual failures... 2008-10-08 16:31:14 -04:00
Shawn Wilsher
a4fad3b421 Remove the places.sqlite file for download manager tests because of expiration tests. 2008-10-08 16:07:22 -04:00
Shawn Wilsher
c98997004c A bit more debugging output for the test... 2008-10-08 15:57:10 -04:00
Shawn Wilsher
51502c3da6 Adding some dump statements to figure out what is gong on with tinderbox. 2008-10-08 15:26:39 -04:00
Marco Bonardo
aa1a80c7fa Bug 456029 - optimize the temp table triggers
This changeset makes the triggers work much faster which should greatly reduce
the timings of adding a visit and a bookmark.
r=sdwilsh
2008-10-08 13:12:53 -04:00
Shawn Wilsher
e957f42a86 Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77

--HG--
rename : toolkit/components/places/tests/unit/head_bookmarks.js => toolkit/components/places/tests/background/head_background.js
2008-10-08 13:12:48 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
3489e87121 Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-10-08 13:12:42 -04:00
Shawn Wilsher
871b5a0213 Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-10-08 13:10:04 -04:00
Ryan Flint
253b150aeb Bug 394979 - Search Service is slow on startup. r=gavin 2008-10-06 16:57:18 -04:00
Daniel Holbert
72c410a648 Bug 458167 - (comments-only changes) Grammar Nazi Vol1: s/it's/its/ for the posessive version of the word, and a few other misc comment-typos, in these directories: accessible browser config profile rdf toolkit tools xpcom xpfe 2008-10-01 23:49:45 -07:00
Justin Dolske
f5dac2e8aa Bug 457358 - need to reset UTF8 converter after it encounters invalid input (pwmgr problems in FF3.0.3). r=gavin 2008-09-30 22:08:46 -07:00
Dave Camp
da772567c5 Merge for backout of bug 453723. 2008-09-30 12:25:20 -07:00
Dave Camp
60ab0e3cd6 Backed out changeset 74aad43f37a5 (bug 453723). 2008-09-30 12:24:43 -07:00
Dave Camp
39772c885f Merge for backout of 38a48d485876 2008-09-30 12:24:10 -07:00
Dave Camp
c7fe99888b Backed out changeset 38a48d485876 (bug 426932). 2008-09-30 12:23:31 -07:00
Marco Bonardo
bd07734758 Bug 448584 - Don't save invalid uri nodes while doing a JSON backup (don't stop while saving data), r=dietrich 2008-09-30 10:41:36 +02:00
Dietrich Ayala
89c275d5aa Bug 420331 - wyciwyg: uris show up in location bar (r=mardak) 2008-09-29 23:46:52 -07:00
Dietrich Ayala
2fa7f086c3 test for bug 331459 - Places query ignores onlyBookmarked 2008-09-29 23:28:08 -07:00
Dietrich Ayala
5d9c44b264 pushing test for bug 433317, forgot to check-in initially 2008-09-29 23:22:46 -07:00
Dave Camp
54db31ddcb Workaround for race in tests for bug 453723. Tracking a better solution in bug 457790. 2008-09-29 18:49:41 -07:00
Marco Bonardo
a599a40812 Follow-up to Bug 329534 - Live bookmarks load way too aggressively. Try to workaround possible VM timers bugs that could cause test failures. r=dietrich 2008-09-30 01:24:44 +02:00
Dave Camp
670a9b8f96 Bug 453723: Short-circuit known-clean hosts in the url-classifier. r=tony 2008-09-29 16:18:21 -07:00
Dave Camp
415594b7fe Backed out changeset 1a971f9406f8 due to unit test failures. 2008-09-28 17:14:46 -07:00
Dave Camp
7a5ba0ed93 Bug 453723: Short circuit known-clean hosts and fragments in the url-classifier. r=tony 2008-09-28 16:42:19 -07:00
Mark Banner
273f9cbd00 Backed out changeset 93928936b1ab bug 382690 due to check-in during string freeze. 2008-09-28 15:54:24 +01:00
Steffen Wilberg
282fdc2971 Bug 382690: In about:config, make accel+f focus the filter box instead of invoking the find bar. r=neil 2008-09-28 09:49:08 +02:00
Dietrich Ayala
c75159123b Bug 457396 - in test_history_expiration add the visit in the past to circumvent possible VM timing bugs (for mak77@bonardo.net, r=sdwilsh) 2008-09-27 14:17:30 -07:00
Takeshi Ichimaru
820d6827ba Bug 329534 - Live bookmarks load way too aggressively (lock up/hang/freeze browser), r=dietrich, mak77 2008-09-27 13:05:28 +02:00
Shawn Wilsher
25ae6c3b9f merge for backout of bug 456910 2008-09-26 15:55:41 -04:00
Shawn Wilsher
abd0d61c89 Backed out changeset ebafcda56f98 (bug 456910)
Backed out for Tp regression (bug 457288)
2008-09-26 15:55:03 -04:00
Shawn Wilsher
4a538b5c1c Backout of last four changesets (places fsync work) 2008-09-26 14:20:14 -04:00
Marco Bonardo
ac570e5be2 Bug 456029 - optimize the temp table triggers
This changeset makes the triggers work much faster which should greatly reduce
the timings of adding a visit and a bookmark.
r=sdwilsh
2008-09-26 13:47:29 -04:00
Shawn Wilsher
2a6d34742b Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77

--HG--
rename : toolkit/components/places/tests/unit/head_bookmarks.js => toolkit/components/places/tests/background/head_background.js
2008-09-26 13:47:19 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
b9562883b9 Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-09-26 13:45:59 -04:00
Shawn Wilsher
124206e4de Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-09-26 13:43:41 -04:00
Taras Glek
63334ec525 bug 417125: fix prbool issues, r+sr=roc 2008-09-25 15:39:18 -07:00
Shawn Wilsher
af8e0300cd Bug 456910 - Stop using exclusive locking in places
This allows us to greatly reduce the number of fsyncs when upgrading to sqlite.
The perf loss in no longer using this locking is not significant (10^-6 %).
r=dietrich
2008-09-25 13:50:41 -04:00
Marco Bonardo
77bb2e6d9c Bug 407468 - Livemark loading and failed to load messages should be static menuitems from menu.xml, original patch by Michael Schonfeld <dev@schonfeld.org>, r=mano 2008-09-25 12:30:33 +02:00
Mark Banner
8e77653874 Part of bug 360648 Thunderbird autocomplete migration, enable building of the toolkit autocomplete implementation for Thunderbird. Only affects Thunderbird. t=ted,dmose 2008-09-24 17:54:14 +01:00
Justin Dolske
d261d66277 Bug 454708 - storage-Legacy can throw when calling ConvertToUnicode. r=gavin 2008-09-24 09:12:23 -07:00
Gavin Sharp
97caa62981 Merge backout with previous tip 2008-09-23 11:47:43 -04:00
Phil Ringnalda
b65979710c Bug 454360 - Use Components.results.NS_BINDING_ABORTED instead of hardcoding the value, r=gavin 2008-09-09 21:33:27 -07:00
Ted Mielczarek
468a3823fc bug 447642 - get rid of --disable-mochitest, replace MOZ_MOCHITEST with ENABLE_TESTS. r=bsmedberg 2008-09-09 13:59:11 -04:00
Dão Gottwald
9e167ed4c8 Bug 331940 - Should be able to pass a line number to the external viewer/editor (add missing semicolon) 2008-09-08 14:10:11 +02:00
Simon Bünzli
e5ebc38a43 Bug 331940 - Should be able to pass a line number to the external viewer/editor. r=gavin 2008-09-08 14:06:06 +02:00
Steffen Wilberg
5222d5ac9f Bug 449669 - use the new search textbox binding in about:config. r=mano 2008-09-07 17:57:24 +02:00
Serge Gautherie
d583b6d94c Bug 450938 - "test_417228-other-roots.js:89: strict warning: assignment to undeclared variable excludedFolderId"; Av1; r=mano 2008-09-07 16:46:41 +02:00
Justin Dolske
f2847be93e Bug 399703 - Password manager offers to store logins with empty passwords. r=gavin 2008-09-07 00:12:34 -07:00
Justin Dolske
b371c503be Bug 447788 - Login not filled if existing form username differs in case. r=gavin. 2008-09-07 00:01:11 -07:00
Justin Dolske
3047dd6c7e Bug 446109 - Password manager can overwrite an existing password in an input. r=gavin 2008-09-06 23:52:15 -07:00
Justin Dolske
46a8525595 Bug 400795 - initial form fill and username autocomplete should share common code. r=gavin 2008-09-06 22:19:02 -07:00
Simon Bunzli
49182a7674 b=338039, p=zeniko, r=enndeakin. Provide easy, right way to restart an application. 2008-09-06 23:30:13 -05:00
Jason Barnabe
c6373484d6 Bug 318048 - viewing source in external editor never deletes the temp. file; r=gavin.sharp 2008-09-22 21:16:27 +02:00
Michael Kaply
1874e128b3 Bug #430540 - r=sayrer - Microformats - handle microformats in a floated div 2008-09-21 20:14:45 -05:00