Marco Bonardo
3b22c3d551
Bug 457698 - nsNavHistoryFolderResultNode::OnItemAdded ignores dynamic containers, r=dietrich
2008-10-13 18:14:50 +02:00
Marco Bonardo
6d926ff1b7
Bug 457686 - appendURINode should not append to a dynamic container if we are inside an excludeItems query, r=dietrich
2008-10-13 18:06:50 +02:00
Marco Bonardo
56441e9d6e
Bug 457681 - if ExcludeReadOnlyFolders is false, readonly dynamic containers are still excluded, r=dietrich
2008-10-13 17:58:36 +02:00
Marco Bonardo
b1351fc910
Bug 457677 - PlacesUtils ignores dynamic containers, r=dietrich
2008-10-13 17:54:25 +02:00
Marco Bonardo
68881489cf
Bug 458013 - QueryResultNode Tag refresh optimization is useless as it is, r=dietrich
2008-10-13 14:11:27 +02:00
Ben Turner
311284ddff
Bug 455436 - "XPConnect insists on using its own error reporter even when another is already set." r+sr=jst.
2008-10-12 11:32:34 -07:00
Arpad Borsos
8b11d938d2
Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan
2008-10-10 17:04:34 +02:00
Daniel Holbert
72c410a648
Bug 458167 - (comments-only changes) Grammar Nazi Vol1: s/it's/its/ for the posessive version of the word, and a few other misc comment-typos, in these directories: accessible browser config profile rdf toolkit tools xpcom xpfe
2008-10-01 23:49:45 -07:00
Marco Bonardo
bd07734758
Bug 448584 - Don't save invalid uri nodes while doing a JSON backup (don't stop while saving data), r=dietrich
2008-09-30 10:41:36 +02:00
Dietrich Ayala
89c275d5aa
Bug 420331 - wyciwyg: uris show up in location bar (r=mardak)
2008-09-29 23:46:52 -07:00
Dietrich Ayala
2fa7f086c3
test for bug 331459 - Places query ignores onlyBookmarked
2008-09-29 23:28:08 -07:00
Dietrich Ayala
5d9c44b264
pushing test for bug 433317, forgot to check-in initially
2008-09-29 23:22:46 -07:00
Marco Bonardo
a599a40812
Follow-up to Bug 329534 - Live bookmarks load way too aggressively. Try to workaround possible VM timers bugs that could cause test failures. r=dietrich
2008-09-30 01:24:44 +02:00
Takeshi Ichimaru
820d6827ba
Bug 329534 - Live bookmarks load way too aggressively (lock up/hang/freeze browser), r=dietrich, mak77
2008-09-27 13:05:28 +02:00
Shawn Wilsher
abd0d61c89
Backed out changeset ebafcda56f98 (bug 456910)
...
Backed out for Tp regression (bug 457288)
2008-09-26 15:55:03 -04:00
Shawn Wilsher
af8e0300cd
Bug 456910 - Stop using exclusive locking in places
...
This allows us to greatly reduce the number of fsyncs when upgrading to sqlite.
The perf loss in no longer using this locking is not significant (10^-6 %).
r=dietrich
2008-09-25 13:50:41 -04:00
Marco Bonardo
77bb2e6d9c
Bug 407468 - Livemark loading and failed to load messages should be static menuitems from menu.xml, original patch by Michael Schonfeld <dev@schonfeld.org>, r=mano
2008-09-25 12:30:33 +02:00
Marco Bonardo
5edd5fff2c
Bug 418671 - Clean up places views drag and drop code, r=mano
2008-09-19 17:47:45 +02:00
Shawn Wilsher
5d3ab665f0
backout merge
2008-09-18 15:05:36 -04:00
Shawn Wilsher
9bf0fdc3ad
backout merge
2008-09-18 15:03:15 -04:00
Shawn Wilsher
f46423d1af
Backed out changeset eb14737f8488 (places fsync work)
2008-09-18 15:02:55 -04:00
Shawn Wilsher
9bc5bb6827
backout merge
2008-09-18 15:02:17 -04:00
Shawn Wilsher
47008f4df3
Backed out changeset c99b7659dc0a (places fsync work)
2008-09-18 15:01:51 -04:00
Shawn Wilsher
8df9786bcd
backout merge
2008-09-18 15:01:01 -04:00
Shawn Wilsher
900250bc91
Backed out changeset f3c9af143cc1 (places fsync work)
2008-09-18 15:00:30 -04:00
Shawn Wilsher
09255da4ab
Backed out changeset dabae13daacb
2008-09-18 14:47:31 -04:00
Shawn Wilsher
f909f6ff81
Test breakage fix from bug 449640
2008-09-18 13:51:33 -04:00
Shawn Wilsher
16fef55947
Bug 450290 - Sync the temp tables to the permanent tables.
...
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones. For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark. For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77
--HG--
rename : toolkit/components/places/tests/unit/head_bookmarks.js => toolkit/components/places/tests/background/head_background.js
2008-09-18 11:10:47 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
ec97557606
Bug 449640 - Modify the places backend to use the temporary tables &
...
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-09-18 11:10:34 -04:00
Shawn Wilsher
a981391a48
Bug 449086 - Create temporary tables for frequently used places tables
...
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits. This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-09-18 11:10:09 -04:00
Marco Bonardo
1d4ddeb7ae
Bug 430442 - Undo and redo in the library are sometimes not correctly working, r=dietrich
2008-09-11 16:16:54 +02:00
Phil Ringnalda
b65979710c
Bug 454360 - Use Components.results.NS_BINDING_ABORTED instead of hardcoding the value, r=gavin
2008-09-09 21:33:27 -07:00
Ted Mielczarek
468a3823fc
bug 447642 - get rid of --disable-mochitest, replace MOZ_MOCHITEST with ENABLE_TESTS. r=bsmedberg
2008-09-09 13:59:11 -04:00
Serge Gautherie
d583b6d94c
Bug 450938 - "test_417228-other-roots.js:89: strict warning: assignment to undeclared variable excludedFolderId"; Av1; r=mano
2008-09-07 16:46:41 +02:00
Marco Bonardo
016e09eab3
Bug 451499 - wrong folder icon appears on smart bookmarks, r=dietrich
2008-09-06 17:21:55 +02:00
Shawn Wilsher
c7fa5f7164
Bug 453181 - Remove code that is labeled REMOVE ME
...
This changeset removes a bunch of code that was labeled REMOVE ME with a release
stated. All those releases have passed, so let's get rid of the code.
r=dietrich
2008-09-05 12:20:40 -04:00
Oleg Romashin
77c933f0f8
Bug 453821 - Places building in embedding-minimal profile failed. r=edilee.
2008-09-05 17:49:49 +03:00
Shawn Wilsher
6f881e6434
Bug 451590 - nsNavHistory needs nsIClassInfo with THREADSAFE flag
...
This changeset marks nsNavHistory as threadsafe so we can use the database
connection on more than one thread in JS. It also adds assertions on every
other public API to ensure that it is only running on the main thread.
r=dietrich
r=bent
2008-09-04 18:11:14 -04:00
Simon Wagner
2c6f2ecec6
Bug 452958 - Livemarks service does not show children with empty titles, r=dietrich
2008-09-04 19:00:18 +02:00
Shawn Wilsher
f22841cdcd
Bug 452777 - regression from lastInsertRowID: Undo folder deletion mix up views
...
r=Mak77
2008-09-03 12:45:20 -04:00
Marco Bonardo
fed5a1056a
Bug 442731 - GIF favicons are not resampled in places.sqlite (large icons are stored), r=dietrich, pavlov
2008-09-02 13:59:59 +02:00
Shawn Wilsher
538d2ecdf2
Bug 429988 - Use a background thread for places work when possible
...
This changeset creates a JS module that acts as a wrapper for a background
thread to do places work on.
Tests included!
r=bent
r=dietrich
2008-08-27 22:33:01 -04:00
Edward Lee
2958cfc7b7
Bug 451760 - Allow matching at beginning of title/url by pref. r=dietrich
2008-08-24 10:45:33 -05:00
Shawn Wilsher
631638c56c
Bug 451244 - nsNavHistory does not use threadsafe refcounting
...
This changeset makes nsNavHistory use the threadsafe addref and release macros
so database access can be done off of the main thread via nsPIPlacesDatabase.
r=dietrich
2008-08-19 23:31:53 -05:00
Marco Bonardo
f682e17963
Bug 411966 - Wrong favicon appears in the bookmarks list, r=dietrich
2008-08-19 11:26:16 -04:00
Marco Bonardo
9ac24ff28a
Bug 427142 sporadic test_393498.js failure on bm-win2k3-pgo01 because of VM timer issues. r=dietrich
2008-08-18 12:55:24 -04:00
Dietrich Ayala
974dc64fd8
Bug 450674 - Fix test_expiration.js
...
r=sdwilsh
2008-08-16 18:34:36 -04:00
Shawn Wilsher
b77395a679
Bug 449884 - Stop using mozIStorageConnection::GetLastInsertRowID
...
It turns out that this is not a safe function to use at all when you start using
the database connection on more than one thread. It also does not work as
expected when triggers are used to insert data into a database.
r=dietrich
2008-08-16 18:28:28 -04:00
Shawn Wilsher
186dba48ff
Bug 444763 - Use an unshared cache connection instead of a shared one
...
This makes places no longer use a shared cache for the database. This wins us
about 7% for location bar queries. For those needing access to the places
database now, they should QI nsINavHistoryService to nsPIPlacesDatase and get
the database connection off of it.
r=dietrich
2008-08-16 18:23:24 -04:00
Shawn Wilsher
d2b18f154b
Bug 449506 - Expose the places db connection
...
This adds a private interface that consumers can QI to to get access to the
internal database connection.
r=dietrich
2008-08-16 18:21:23 -04:00
Dão Gottwald
d6eb562dc8
Backed out changeset be5521120b06
2008-08-13 09:52:48 +02:00
Marco Bonardo
56162e6327
Bug 411966 – Wrong favicon appears in the bookmarks list. r=dietrich
2008-08-13 08:44:38 +02:00
L. David Baron
7732175080
Merge backout of changeset fb56f835e52d due to test failure and leaks.
2008-08-06 11:54:04 -07:00
L. David Baron
a2d75eb595
Backed out changeset fb56f835e52d due to test failure and leaks.
2008-08-06 11:53:44 -07:00
Dietrich Ayala
e8837e2090
bustage fix for bug 329534
2008-08-06 10:20:30 -07:00
Dietrich Ayala
a8f3c3d3f3
[mq]: bug-329534-livemarks-load
2008-08-06 09:51:14 -07:00
Edward Lee
bb6e4fbb75
Bug 422698 - different levels of URL decoding for address bar and autocomplete suggestions
2008-08-05 18:16:35 -07:00
Edward Lee
e3376d97b9
Bug 424717 - Location bar autocomplete should be willing to complete to a URL with a different protocol
2008-08-05 18:16:12 -07:00
Edward Lee
ead983f50a
Bug 424509 - Location bar autocomplete favors "http://" over domain name starting with "h". r=dietrich
2008-08-05 17:56:04 -07:00
Shawn Wilsher
f7c9f5d3ec
Bug 443433 - [refactor] move places table creation statements to one file
...
This refactors how tables are created in places. There is no change in logic.
r=dietrich
2008-08-04 13:14:17 -04:00
Shawn Wilsher
1082eae412
Address spelling mistake from review comment for bug 443068.
2008-08-04 13:07:17 -04:00
Shawn Wilsher
dbc4d6734f
Bug 443068 - Move triggers into migration code
...
This moves all the triggers created by places into the appropriate migration
functions. This saves us two queries to sqlite_master every time the places
service starts up.
r=dietrich
2008-08-04 12:59:56 -04:00
Edward Lee
5920dfe5d5
Backout 6831521f03ac to fix Bug 446621 - Slowdown on AutoComplete - AwesomeBar. a=beltzner
2008-07-22 08:49:39 -07:00
Edward Lee
aced9a6487
Bug 412736 - in the case of a frecency tie, break it with h.typed and h.visit_count. r=dietrich
2008-07-21 23:29:51 -07:00
Edward Lee
3f4c03d18d
Bug 424557 - Allow AwesomeBar to default search only urls (or history/titles/bookmarks/tags). r=dietrich
2008-07-21 14:27:50 -07:00
Marco Bonardo
f93c481bb8
bug 427142 - sporadic test_393498.js failure on bm-win2k3-pgo01 because of VM timer issues. r=dietrich
2008-07-21 11:41:09 -04:00
Edward Lee
26fd4468ea
Bug 395161 - Make it possible to restrict the url bar autocomplete results to bookmarks/tagged/history entries and match only url/title. r=dietrich
2008-07-19 01:51:34 -07:00
Edward Lee
b8397c4e80
Bug 249468 - Add all bookmark keywords to location bar autocomplete drop-down list
2008-07-17 04:50:37 -07:00
Edward Lee
2fb181ae19
Bug 392143 - show keywords as url bar autocomplete choices. r=dietrich, r=gavin
2008-07-17 04:48:40 -07:00
Edward Lee
45d4dba4ef
Bug 406422 - Globally decay adaptive input history to allow for new entries. r=dietrich
2008-07-16 13:45:42 -07:00
Serge Gautherie
6f72cab4f0
Bug 311672 – Remove the obsolete 2nd parameter from |nsIStringBundleService::createBundle(...)| "JS" callers. r=zeniko/mano
2008-07-12 11:56:02 +02:00
Olli Pettay
7283e91f7c
Relanding Bug 444432 - Mozilla2 Tinderbox 'qm-win2k3-moz2-01': test_places/unit/test_419731.js: FAIL
2008-07-11 16:00:41 +03:00
Asaf Romano
3337b10e2a
Bug 443734 - Remove initBookmarksToolbar. r=gavin.
2008-07-05 22:00:06 +03:00
Dietrich Ayala
95d3caf46a
Bug 429832 - Add API to nsIFaviconService to handle data URIs (for manish@flock.com, r=marco, r=dietrich)
2008-07-03 11:07:56 -07:00
Dietrich Ayala
83dda5c1b7
Bug 433317 - Renamed title of saved search folder isn't updated outside the Library until Firefox is restarted (r=marco, r=mano)
2008-07-03 10:40:16 -07:00
Dietrich Ayala
835d7d6453
Bug 437078 - GUIDs not included in bookmark backups (r=mano)
2008-07-03 10:17:13 -07:00
Dietrich Ayala
244dee2500
Bug 436219: nsINavBookmarksService.runInBatchMode comment is incorrect (r=mano)
2008-07-02 14:35:46 -07:00
Shawn Wilsher
5fe28f1ea4
Bug 429987
...
Remove unused IN_MEMORY_LINKS
r=dietrich
2008-06-11 16:52:24 -04:00
peterv@propagandism.org
4f89aa34f4
Fix for bug 426261 (Crash in nsNavHistoryContainerResultNode::GetSortType() during bookmark synchronization). Patch by ondrej and me, r=Mano, a=beltzner.
2008-05-27 08:48:31 -07:00
edward.lee@engineering.uiuc.edu
fa22d6cd43
Leak bustage fix for Bug 434340 - The bookmark tags feature is broken on Firefox 3.0rc1 for OpenSolaris
2008-05-26 19:28:47 -07:00
edward.lee@engineering.uiuc.edu
36ae19345e
Bug 434340 - Firefox 3.0pre crashes with auto completion for tagged bookmark. p=ginn.chen@sun.com (Ginn Chen), r=Mardak, r=dietrich, b-ff3=beltzner, a1.9=beltzner
2008-05-26 14:20:34 -07:00
dietrich@mozilla.com
5cffbd5640
Bug 433525 - crash [@ nsNavHistoryQueryResultNode::IsContainersQuery()] (r=marco, r=mano, a=schrep)
2008-05-23 09:22:54 -07:00
gavin@gavinsharp.com
0cbe08eec3
Back out bug 432938 because it caused bug 433241, a=schrep/beltzner
2008-05-11 13:12:29 -07:00
reed@reedloden.com
fd10d2e6de
Bug 398811 - "Remove MOZILLA_1_8_BRANCH ifdefs from toolkit on trunk" [p=mh+mozilla@glandium.org (Mike Hommey) r=gavin a1.9=damons]
2008-05-09 00:25:29 -07:00
dietrich@mozilla.com
7514f91623
Bug 430792 - Site's favicon is replaced if browser error page is shown (comment change only, for ehsan.akhgari@gmail.com, r=dietrich)
2008-05-08 09:36:54 -07:00
dietrich@mozilla.com
c62383ea7b
Bug 430792 - Site's favicon is replaced if browser error page is shown (for ehsan.akhgari@gmail.com, r=dietrich, a=beltzner)
2008-05-07 21:35:08 -07:00
dietrich@mozilla.com
60892555a5
Bug 428481 - nsFaviconService calls Abandon on a scoped global statement (for mak77@supereva.it, r=dietrich, a=schrep)
2008-05-07 21:26:10 -07:00
dietrich@mozilla.com
90eb744768
Bug 419957 - History sidebar "By Site" should use visit_count to avoid display of empty sites (for ondrej@allpeers.com, r=dietrich, a=beltzner)
2008-05-06 21:33:05 -07:00
dietrich@mozilla.com
833ad69d76
backing out, tree is closed
2008-05-06 20:28:03 -07:00
dietrich@mozilla.com
2c1cf52261
Bug 419957 - History sidebar "By Site" should use visit_count to avoid display of empty sites (for ondrej@allpeers.com, r=dietrich, a=beltzner)
2008-05-06 20:26:19 -07:00
dietrich@mozilla.com
1070f8fb32
Bug 417228 - Bookmarks outside the three default folders aren't restored (r=mano, a=schrep)
2008-05-06 13:58:45 -07:00
dietrich@mozilla.com
13b94c3c5c
Bug 429811 - Tag container isn't updated immediately when bookmark is removed (r=mano, a=mconnor)
2008-05-05 12:57:22 -07:00
dietrich@mozilla.com
cbcab9ee50
perf testing bug 431758 (a=mconnor)
2008-05-05 11:11:49 -07:00
philringnalda@gmail.com
839d05e947
Ignore siteURI annotation changes that are for the default livemark, not our livemark
2008-05-03 13:33:24 -07:00
philringnalda@gmail.com
a19c377f31
Better logging for livemark siteURI test failures
2008-05-03 12:38:23 -07:00
gavin@gavinsharp.com
eca397a97a
Bug 421180: When removing bookmarks existing keywords aren't deleted/removed, patch by Marco Bonardo <mak77@supereva.it>, r=dietrich, a=damon
2008-04-29 12:20:50 -07:00
gavin@gavinsharp.com
21fa60bf1c
Bug 402799: Saved searches that match on tags show duplicates, patch by Marco Bonardo <mak77@supereva.it>, r=dietrich, a=beltzner
2008-04-29 12:16:42 -07:00
gavin@gavinsharp.com
67d9eaeb3a
Bug 425230: add a transaction to ClearHistory, patch by Marco Bonardo <mak77@supereva.it>, r=dietrich, a=mconnor
2008-04-28 03:11:08 -07:00
dietrich@mozilla.com
50056ce3ac
Bug 423212 - ###!!! ASSERTION: EndUpdateBatch without a begin: 'mBatchInProgress' (r=mano, a=mconnor)
2008-04-25 16:40:48 -07:00
dietrich@mozilla.com
d21da5f02b
Bug 405938 - problems when import/exporting of saved searches (r=mano, a=mconnor)
2008-04-25 16:37:26 -07:00