Commit Graph

4362 Commits

Author SHA1 Message Date
Trevor Saunders
2756d3cc25 bug 1243077 - simplify GetRoleCB some r=davidb
We can replace the code  dealing with Accessibles and proxies differently with
a call to AccessibleOrProxy::Role()
2016-01-27 18:42:45 -05:00
Trevor Saunders
3533020369 bug 1243077 - add ToXPC{,Document} overloads for proxied accessibles r=davidb 2016-01-27 18:42:44 -05:00
Trevor Saunders
ed7112af70 bug 1243077 - make it possible to get MaiAtkObject::mAccWrap from an AtkObject* without casting to Accessible* or ProxyAccessible* r=davidb 2016-01-27 18:42:44 -05:00
Trevor Saunders
68157e1e81 bug 1243077 - add AccessibleOrProxy::Role() r=davidb 2016-01-27 18:42:44 -05:00
Trevor Saunders
d45bd1dd7a bug 1243077 - implement xpcAccessible::GetChildCount() for proxied accessibles
r=davidb
2016-01-27 18:42:43 -05:00
Trevor Saunders
0f1a4e92f4 bug 1243077 - add AccessibleOrProxy xpcAccessible::IntlGeneric() r=davidb
It will be useful to get mIntl without casting it to either Accessible* or
  ProxyAccessible*.  sadly C++ won't let us overload the name Intl() this way
  so for now this method is named IntlGeneric().
2016-01-27 18:42:43 -05:00
Trevor Saunders
a3a485c619 bug 1243077 - add AccessibleOrProxy::ChildCount() r=davidb 2016-01-27 18:42:42 -05:00
Trevor Saunders
eaa9db8267 bug 1243077 - add AccessibleOrProxy::IsNull() r=davidb 2016-01-27 18:42:42 -05:00
Mats Palmgren
c20fce3514 Bug 1241840 - Set table cell colspan=0 to 1 instead per the HTML spec. r=bz 2016-01-27 17:02:12 +01:00
Trevor Saunders
8c619bee29 bug 1241453 - fire nsIAccessibleCaretMoveEvents for proxies r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders
de7f21d8e9 bug 1241453 - fire nsIAccessibleEvents for proxied accessibles r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders
f5e0d1168e bug 1241453 - fire nsIAccessibleTextChangeEvents for proxies r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders
071de9db69 bug 1241453 - fire nsIAccessibleStateChangeEvents for proxied accessibles r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders
6ec025eab0 bug 1241453 - factor dispatching nsIAccessibleEvents out of HandleAccEvent() r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders
5cf41fab72 bug 1241453 - add DocAccessibleParent::GetXPCAccessible() r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders
f74ed4bb3b bug 1241453 - allow caching proxies in xpcAccessibleDocuments r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders
5aa2104440 bug 1241453 - assert accessibles are only added to non remote xpcAccessibleDocuments r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders
973d0ef356 bug 1241453 - allow caching xpc documents for remote documents r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders
66dfc5d929 bug 1241453 - fixup xpcAccessible Intl() methods to not assume mIntl is always an Accessible r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders
e5c491e88c bug 1241453 - allow xpcAccessibleDocument::mCache to use proxies as keys r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders
e9a6911336 bug 1241453 - allow constructing xpcAccessibles with proxies r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders
68c4c04937 bug 1241453 - allow storing proxies in xpcAccessibleGeneric::mIntl r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders
6db1192c25 bug 1241453 - clean up GetAccessibleWrap() r=davidb
We can simplify it some to make better use of AccessibleOrProxy.
2016-01-26 07:49:25 -05:00
Trevor Saunders
2e7c424cea bug 1241453 - switch MaiHyperLink to use AccessibleOrProxy r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders
65cdeb5b7b bug 1241453 - switch MaiAtkObject to use AccessibleOrProxy r=davidb 2016-01-26 07:49:25 -05:00
Trevor Saunders
5a6d7c2794 bug 1241453 - add an AccessibleOrProxy class r=davidb
We have several places that store either a ProxyAccessible* or an Accessible*
 in the same member using a uintptr_t and stealing the lowest bit of the
 pointer.  The goal of the AccessibleOrProxy class is to make this simpler and
 consolidate the logic involved in doing it.
2016-01-26 07:49:25 -05:00
Sylvestre Ledru
14ec5bc735 Bug 1218816 - Remove useless semicolons. Found by coccinelle. r=Ehsan 2016-01-22 16:58:49 +01:00
David Rajchenbach-Teller
41e4edde4b Bug 1224374 - Profiler labels for the 25 top chrome hangs;r=BenWa,MarcoZ
Experience shows that we do not have enough profiler labels to make
BHR hang reports meaningful. This patch adds enough labels to let us
exploit hang reports matching the 25 topmost chrome hangs.
2016-01-14 23:03:11 +01:00
Alexander Surkov
28d32c5bd2 Bug 1233118 - implement IAccessible2_3::selectionRanges, r=yzen 2016-01-20 12:53:03 -05:00
Sebastian Hengst
e687c33b0f Backed out 2 changesets (bug 1224374) for Windows bustage. r=bustage on a CLOSED TREE
Backed out changeset 5f458e6e4997 (bug 1224374)
Backed out changeset 0dc02cb0b604 (bug 1224374)
2016-01-19 21:30:41 +01:00
David Rajchenbach-Teller
3a3c914116 Bug 1224374 - Profiler labels for the 25 top chrome hangs;r=BenWa,MarcoZ
Experience shows that we do not have enough profiler labels to make
BHR hang reports meaningful. This patch adds enough labels to let us
exploit hang reports matching the 25 topmost chrome hangs.
2016-01-14 23:03:11 +01:00
Jonathan Kew
04e7780340 Bug 1239301 - Use 'ch' units rather than 'ex' units when specifying a width that is intended to fit a specific number of characters. r=tbsaunde 2016-01-18 13:27:59 +00:00
Eitan Isaacson
17f0419b09 Bug 1239051 - Labels should expose labeled controllers action. r=tbsaunde 2016-01-14 12:37:15 -08:00
Jonathan Kew
bb2f64218c Bug 1239007 - Replace nsIntRect by strongly-typed rects in a couple of nsCocoaUtils functions. r=mstange 2016-01-13 07:32:55 +00:00
Till Schneidereit
4818bc57dd Bug 1101817 - Part 1: Remove usages of WeakMap.prototype.clear from Gecko. r=yzen,mak,yoric,gijs,jlongster 2016-01-04 13:06:50 +01:00
Nathan Froyd
f63b2e1061 Bug 1222531 - turn off -Wextra-tokens on clang-cl in accessible/ directories; r=tbsaunde
The Windows MIDL code generator creates things like:

    #endif !_MIDL_USE_GUIDDEF_

which clang-cl complains about.  MSVC doesn't, so turn this warning off.
2015-11-06 13:10:03 -05:00
Trevor Saunders
b4b5b08e9b bug 1235965 - null check mDoc in AccessibleWrap::Shutdown() r=davidb 2016-01-08 14:23:08 -05:00
Trevor Saunders
7fad434095 bug 1203861 - use strncmp() instead of nsCString.equals() to compare names r=davidb
AtkObject stores the name as a C string, but nsCString can store strings with
'\0' in the middle.  That means that if we compute a name containing '\0'
nsCString.equals() will nevr consider that string to be equal to
AtkObject::name, however we only want to compare up to the first '\0' because
that is the only part Atk will ever see.  So we should use strncmp() instead of
nsCString.equals().
2016-01-08 14:23:08 -05:00
Trevor Saunders
0204efbf5d bug 1228400 - null check tabChild before notifying the parent process about new child documents r=davidb 2016-01-07 14:18:40 -05:00
Nicholas Nethercote
4d571fac6a Bug 1232852 (part 3) - Remove unused parameters from some accessibility code. r=tbsaunde. 2015-12-15 21:24:06 -08:00
Bogdan Postelnicu
5bbc94187d Bug 1235373 - Add an assert to check validity of pointers: mElement->GetPrimaryFrame() and frame. r=surkov 2015-12-28 06:25:00 -05:00
Alexander Surkov
ae937250ed Bug 1231919 - crash in mozilla::a11y::DocAccessible::ValidateARIAOwned, r=davidb 2015-12-14 12:02:23 -05:00
Jim Mathies
fbdb9901db Bug 1198459 - Prevent accessibility from initializing in content processes when e10s is running. r=tbsaunde 2015-12-10 14:28:33 -05:00
Carsten "Tomcat" Book
22ca09e4b0 Backed out changeset bcb4ebf6ffac (bug 1198459) for bustage 2015-12-10 11:14:27 +01:00
Jim Mathies
06f24062b9 Bug 1198459 - Prevent accessibility from initializing in content processes when e10s is running. r=tbsaunde 2015-12-09 08:35:06 -05:00
Phil Ringnalda
e5b51ed668 Bug 845176 - Skip relations/test_embeds.xul on Linux debug and ASan, where it times out constantly 2015-12-09 18:48:26 -08:00
Mike Hommey
36c12bd405 Bug 1231148 - Avoid requiring IDL files installed in $DIST/idl to run AccEventGen.py. r=ted
While working on growing the fastermake backend to do compilation, I ran into
the problem that there's an implicit dependency from AccEventGen.py on the fact
that IDL files are installed in $DIST/idl. While we may need some way to
express such things in general, it turns out that for this specific use case,
we don't actually /need/ IDLs in $DIST/idl, and a couple paths are enough to
get things to work.
2015-12-09 19:23:53 +09:00
Ted Mielczarek
56d30d0b18 bug 1160185 - support GENERATED_FILES in EXPORTS. r=glandium
This change allows specifying objdir-relative paths in EXPORTS to enable
exporting entries from GENERATED_FILES. Objdir paths in EXPORTS that are
not in GENERATED_FILES will raise an exception.

Example:
```
EXPORTS += ['!g.h', 'f.h']
GENERATED_FILES += ['g.h']
```

Given the implementation, this should also work for FINAL_TARGET_FILES,
FINAL_TARGET_PP_FILES, and TESTING_FILES, but those are not well-tested.

This patch also renames the install manifest for '_tests' to match the
directory name for convenience in some code I refactored.
2015-12-01 09:53:16 -05:00
Bogdan Postelnicu
8788be63f1 Bug 1230118 - added asserts on aOwner and aOwner->Elm() r=surkov 2015-12-03 14:07:43 -08:00
Wes Kocher
eeb9653e5f Backed out 2 changesets (bug 1230118, bug 1230110) for windows debug assertions in browser_perf-categories-js-calltree.js
Backed out changeset a9ce85f77af9 (bug 1230118)
Backed out changeset b9d8d05aa4ee (bug 1230110)
2015-12-03 15:38:04 -08:00
Bogdan Postelnicu
8718be8320 Bug 1230118 - added asserts on aOwner and aOwner->Elm() r=surkov 2015-12-03 14:07:43 -08:00
Robert O'Callahan
884728e2c1 Bug 1221043. Revert to including trailing whitespace for accessibility APIs. r=marcoz,mats 2015-12-01 02:21:25 +13:00
Nicholas Nethercote
47f7804bad Bug 1187139 (part 3) - Replace nsBaseHashtable::Enumerate() calls in accessible/ with iterators. r=tbsaunde. 2015-11-29 14:02:07 -08:00
Nicholas Nethercote
5a8d025266 Bug 1187139 (part 2) - Replace nsBaseHashtable::Enumerate() calls in accessible/ with iterators. r=tbsaunde. 2015-11-29 14:02:07 -08:00
Nicholas Nethercote
79d571c5c9 Bug 1187139 (part 1) - Replace nsBaseHashtable::Enumerate() calls in accessible/ with iterators. r=tbsaunde. 2015-11-29 14:02:07 -08:00
Nicholas Nethercote
409736b8f8 Bug 1225007 (part 2, attempt 3) - Use LayoutDevicePixel more in Cocoa widget code. r=kats. 2015-11-19 17:34:20 +11:00
Alexander Surkov
c6ff5773fa Bug 1213281 - crash in mozilla::a11y::DocAccessible::UpdateTreeOnInsertion, r=davidb 2015-11-26 20:46:12 -05:00
Alexander Surkov
f074f0378b Bug 1226000 - control may pick up its name from wrong label, r=yzen 2015-11-24 14:44:24 -05:00
Trevor Saunders
43663f4822 bug 1218762 - proxy ia2Accessible::scrollTo{,Point}() r=davidb 2015-11-20 09:45:23 -05:00
Phil Ringnalda
05685d140b Backed out 2 changesets (bug 1225007) for frequent OS X "Shouldn't return empty rect" assertion failures, a=backout
Backed out changeset c5b352c74b35 (bug 1225007)
Backed out changeset 8a513c70ce7c (bug 1225007)
2015-11-19 20:55:26 -08:00
Nicholas Nethercote
c42a6f6b24 Bug 1225007 (part 2, attempt 2) - Use LayoutDevicePixel more in Cocoa widget code. r=kats. 2015-11-19 17:34:20 +11:00
Kyle Huey
588db30b9f Bug 1222127: Use the inner window to compute style. r=baku 2015-11-19 14:47:20 +08:00
Nicholas Nethercote
81aa29c752 Backout 52ba24123046 and 66768d6a50fa (bug 1225007) for causing lots of test assertions on Mac. CLOSED TREE 2015-11-17 17:02:39 -08:00
Nicholas Nethercote
c4ca8db337 Bug 1225007 (part 2) - Use LayoutDevicePixel more in Cocoa widget code. r=kats. 2015-11-16 19:40:53 -08:00
Chris Manchester
cace689ddb Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in r=glandium,tbsaunde 2015-11-16 16:51:51 -08:00
John Daggett
58aea8d328 Bug 1173260 - stub out tests that fail when 'cursive' is looked up via fontconfig. r=m_kato 2015-11-16 08:48:45 +09:00
Nicholas Nethercote
ed2c7d6ad2 Bug 1224403 (part 8) - Use LayoutDeviceIntMargin more in HyperTextAccessible. r=kats. 2015-11-12 05:34:27 -08:00
Nicholas Nethercote
92d3c8eb1b Bug 1224403 (part 2) - Split GetClientOffset() into typed and untyped versions. r=kats. 2015-11-11 19:56:06 -08:00
Nicholas Nethercote
7215329de9 Bug 1223310 (part 2) - Use LayoutDeviceIntRect for bounds-related functions in nsIWidget. r=kats.
The patch renames the existing functions (GetBounds(), GetClientBounds(), etc)
by adding an |Untyped| suffix. It then adds typed equivalents, and uses those
typed equivalents in all the call sites where it's easy to do so. The trickier
remaining call sites are converted to use the Untyped-suffix version.
2015-11-09 21:37:32 -08:00
Trevor Saunders
a3ee5aa18b bug 1213402 - add another , to fix silly string concatonation r=me landed on a CLOSED TREE 2015-11-10 21:45:12 -05:00
Trevor Saunders
c433e1166f bug 1213402 - fixup silly array , on windows r=me landing on a CLOSED TREE 2015-11-10 17:39:27 -05:00
Trevor Saunders
99fc633d9a bug 1213402 - Fire numeric value change events for proxies r=davidb 2015-11-10 15:55:09 -05:00
Trevor Saunders
4871fe153a bug 1213402 - separate value change events into text value changes and numeric value changes r=davidb
Arguably these are different things, and it will be easier to proxy events for
atk this way because atk only wants the numeric value changes.
2015-11-10 15:55:08 -05:00
Nicholas Nethercote
6474cc9afe Bug 1222943 (part 1) - Change Touch::mRadius from nsIntPoint to LayoutDeviceIntPoint. r=kats.
This adds a three missing unit conversions for touch radii.
2015-11-09 21:37:31 -08:00
Alexander Surkov
dc5dbfe957 Bug 1221542, bug 1221543 - crash in mozilla::a11y::DocAccessible::SeizeChild/PutChildrenBack, r=davidb 2015-11-09 14:47:38 -05:00
Justin Obara
d248d5e184 Bug 1169019 - Removed screenreader announcement from gecko. r=yzen 2015-11-08 21:24:41 -08:00
Alexander Surkov
24f3111282 Bug 1220897 - fix IAccessible2::get_accessibleWithCaret, r=tbsaunde 2015-11-06 23:31:12 -05:00
Trevor Saunders
220e2e029c bug 1221551 - unbind child documents before rebinding them r=davidb
It seems possible that a child document could be bound to a parent document
without first being unbound.  Some evidence for this being possible is that
OuterDocAccessible::InsertChildAt() explicitly checks for this and does
something similar if it already has a child.
2015-11-06 17:29:17 -05:00
Nathan Froyd
2215616591 Bug 1222174 - add override declarations in AccessibleWrap.h; r=tbsaunde
clang-cl complains about not having these otherwise.
2015-11-05 15:20:09 -05:00
Alexander Surkov
3b2b3cbc7c Bug 582024 - ARIA active-descendant should work for ARIA owned elements, r=yzen 2015-11-03 11:03:34 -05:00
Alexander Surkov
a167ada93b Bug 499917 - take into account aria-owns when calculating group attributes, test only, r=yzen 2015-11-03 11:03:23 -05:00
Yura Zenevich
369950b2c9 Bug 1220860 - fixing an error with getting documentElement on AccessFu stop. r=eeejay 2015-11-02 15:28:53 -08:00
Alexander Surkov
f84f5ef832 Bug 1219744 - no child_of/parent_of relations for aria-owns, r=yzen 2015-11-02 12:42:27 -05:00
Birunthan Mohanathas
94998cf5fe Bug 1219392 - Capitalize mozilla::unused to avoid conflicts. r=froydnj 2015-11-02 07:53:26 +02:00
Robert O'Callahan
c9cf62c475 Bug 264412. Refactor nsIFrame::GetRenderedText API to be more sane. r=mats,marcoz
The test changes here are to adjust for the fact that
nsTextFrame::GetRenderedText can now trim whitespace from the end of lines
that end in a hard line break.
2015-10-30 19:23:10 +13:00
Alexander Surkov
3b1f584fc6 Bug 1219743 - remove special ARIA owns support for ARIA menus, r=yzen 2015-10-30 23:19:52 -04:00
Trevor Saunders
c2aeb25607 bug 1219528 - don't bail out of AccessibleWrap::accNavigate if the accessible wraps a proxy r=davidb 2015-10-30 19:27:42 -04:00
Trevor Saunders
3518d844e8 bug 1219528 - make AccessibleWrap::accNavigate cases using relations work with proxies r=davidb 2015-10-30 19:27:42 -04:00
Trevor Saunders
aaa572adef bug 1219528 - make NAVDIR_{FIRST,LAST}CHILD and NAVDIR_{NEXT,PREVIOUS} cases of AccessibleWrap::accNavigate deal with proxies r=davidb 2015-10-30 19:27:42 -04:00
Trevor Saunders
3cdf822985 bug 1219528 - add ProxyAccessible::{Next,Prev}Sibling() and ProxyAccessible::{First,Last}Child() r=davidb 2015-10-30 19:27:42 -04:00
Alexander Surkov
5c8dc74dae Bug 1219299 - rework aria-owns implementation, r=yzen 2015-10-29 18:08:48 -04:00
Trevor Saunders
e2745b6fcb bug 1218564 - remove check for password roles in AccessibleWrap::get_accValue r=surkov
The text computed for a password entry's accessible should not include the
actual password text, so this check is not necessary.
2015-10-28 14:58:24 -04:00
Kyle Huey
fffe5cc829 Bug 1216401: Eviscerate nsIDOMWindow, move still needed methods to nsPIDOMWindow. r=bz 2015-10-26 14:37:32 -07:00
Ryan VanderMeulen
c07626a475 Bug 448064 - Add crashtest. 2015-10-24 15:03:19 -04:00
Robert O'Callahan
37b74104b6 Revert incorrectly committed changes ab657569f554 and a396f4262479 2015-10-24 22:38:22 +13:00
Robert O'Callahan
162b00750e Bug 264412. Refactor nsIFrame::GetRenderedText API to be more sane. r=mats,marcoz
The test changes here are to adjust for the fact that
nsTextFrame::GetRenderedText can now trim whitespace from the end of lines
that end in a hard line break.
2015-10-24 22:27:29 +13:00
Tooru Fujisawa
82a15bf54f Bug 1217038 - Remove for-each and legacy array comprehension from accessible/. r=yzen 2015-10-18 23:21:31 +09:00
Nicholas Nethercote
e9d0adefb3 Bug 1186786 - Replace nsBaseHashtable::EnumerateRead() calls in accessible/ with iterators. r=tbsaunde. 2015-10-19 17:52:43 -07:00
James Teh
6b55ec5a35 Bug 1210549 - Fix AccessibleWrap::GetXPAccessibleFor for proxied accessibles r=tbsaunde 2015-10-21 19:54:09 -04:00
James Teh
70a159051f Bug 1210549 - Allow IServiceProvider::QueryService to work for proxied accessibles r=tbsaunde 2015-10-21 19:54:09 -04:00