Commit Graph

736 Commits

Author SHA1 Message Date
Marco Bonardo
b2e922b709 backing out bug 414715 due to possible Ts regression 2008-11-27 16:10:36 +01:00
Dietrich Ayala
9f81601ddc Bug 414715. Notify the user if places.sqlite is locked. r=pike, r=mak77, ui-review=faaborg, a=blocking-firefox3.1 2008-11-26 20:59:47 -05:00
mak77@bonardo.net
3d576ef8ce Bug 463471 - temp tables are not correctly synced to disk when the user clear private data on shutdown (r=sdwilsh, r=dietrich) 2008-11-13 22:45:49 -08:00
Ehsan Akhgari
a89e46f55a Bug 461710 - Write an automated test to ensure that visited link coloring is turned off in private browsing mode (further fixes); r=dietrich (NPOTB) 2008-11-13 23:12:03 +03:30
Dietrich Ayala
d6bf19faab Fix for bug 445704 (JSON bookmarks backup has localized filename (and can't be easily restored). r=zeniko, a=beltzner. 2008-11-13 17:54:25 +01:00
Marco Bonardo
45455110de backout test for bug 463471 causing orange 2008-11-13 11:33:01 +01:00
Dietrich Ayala
127a3341a9 [mq]: backout-bug-463471 2008-11-12 23:50:19 -08:00
Marco Bonardo
36f739f320 Bug 463471 - temp tables are not correctly synced to disk when the user clear private data on shutdown, r=dietrich, sdwilsh a=beltzner 2008-11-12 21:50:02 +01:00
Marco Bonardo
20ae2fab49 Bug 462366 - correct bogus importBookmarksHTML behaviour, r=dietrich a=beltzner 2008-11-12 21:45:53 +01:00
Edward Lee
a246ed282d Bug 463661 - Create a pref to control the location bar search sources (history, bookmark, both, none). r=dietrich, a1.9.1b2=beltzner
Bug 463535 - Continuing search immediately after changing prefs give wrong results
2008-11-10 10:04:36 -06:00
Marco Bonardo
d2ef7735fd Bug 459493 - remove placesBackground, r+a=mconnor 2008-11-06 23:22:10 +01:00
mak77@bonardo.net
234918c058 Bug 418643 - Bookmark folder deletion executes too many SQL statements (r=dietrich) 2008-11-05 14:02:12 -08:00
Dietrich Ayala
029ea93f23 Bug 419792 - Use optimized query to get tags for nsNavHistoryResultNode (r=mano) 2008-11-05 10:20:00 -08:00
Dietrich Ayala
81891e2697 Bug 457473 - Bookmark copy creates bookmark with duplicate guid - regression in FF 3.0.3 (r=mano) 2008-11-05 10:15:49 -08:00
Shawn Wilsher
0a32f72c76 Bug 453180 - Adding moz_annos_placeattributeindex should be done in migration code not shutdown
r=dietrich
2008-11-03 22:41:16 -05:00
Shawn Wilsher
1f89b4462e Bug 453179 - Remove unused indecies in a migration code path - not shutdown
r=dietrich
2008-11-03 22:41:15 -05:00
Shawn Wilsher
cf48f23ca7 Bug 453177 - Move moz_places.user_title removal back to MigrateV6Up
r=dietrich
2008-11-03 22:41:15 -05:00
Ehsan Akhgari
5fdab7c48c Bug 461710 - Write an automated test to ensure that visited link coloring is turned off in private browsing mode; r=dietrich 2008-11-04 02:52:23 +03:30
Ehsan Akhgari
a2e1bc51b4 Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [Places unit test fix]; r=dietrich 2008-11-04 02:52:22 +03:30
Ehsan Akhgari
4770654ff7 Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [unit test API changes]; r,sr=mconnor 2008-11-04 02:52:22 +03:30
Dietrich Ayala
46b4a3eec0 Bug 462379 - (NS_ERROR_FAILURE) [nsINavBookmarksService.insertBookmark] when trying to star a bookmark (r=sdwilsh, for marco, sdwilsh) 2008-10-31 17:59:38 -07:00
Dietrich Ayala
15440bfcb0 Bug 415960 - bookmark tags edit control should provide autocomplete (r=mano, core by asouzis@users.sf.net) 2008-10-31 09:16:22 -07:00
Dietrich Ayala
b6d5857bc6 backing out bug 462379 due to persistent test failures 2008-10-30 23:11:04 -07:00
Edward Lee
7314b9afe4 More bug 462379 followup (both == 2) rs=sdwilsh 2008-10-30 20:30:35 -05:00
Dietrich Ayala
f1def076d9 bug 462379 followup (for sdwilsh@forerunnerdesigns.com) 2008-10-30 16:36:14 -07:00
Shawn Wilsher
a2d0e846cb Bug 462379 - (NS_ERROR_FAILURE) [nsINavBookmarksService.insertBookmark] when trying to star a bookmark
r=dietrich
2008-10-30 17:20:33 -04:00
Marco Bonardo
8d17009bde Bug 462206 - finalize statements in nsPlacesDBFlush, r=sdwilsh 2008-10-30 09:51:34 +01:00
Marco Bonardo
3e6ce6e98a Bug 462205 - add statementCallback interface to nsPlacesDBFlush, r=sdwilsh 2008-10-30 09:45:21 +01:00
Marco Bonardo
bd5be67a29 Bug 462204 - Don't try to cancel a not existant timer in nsPlacesDBFlush, r=sdwilsh 2008-10-30 09:42:36 +01:00
Marco Bonardo
04d3fb42d9 Bug 462213 - make migrateV8 tolerant to downgrade-upgrade paths, r=sdwilsh 2008-10-30 09:37:49 +01:00
Shawn Wilsher
ffb57e62b1 Bug 462047 - nsPlacesDBFlush.js should have an error handler.
This changeset adds the handleError method from mozIStorageStatementCallback to
nsPlacesDBFlush so we can report errors to the error console if they occur.
r=dietrich
2008-10-28 17:44:35 -04:00
Marco Bonardo
f118fc44e0 Bug 460947 - fsync stuff has a wrong query for expiration sites cap
r=dietrich
2008-10-27 18:52:23 -04:00
Marco Bonardo
ed77be778c Bug 459934 - should lazy-load places autocomplete statements
r=dietrich
r=sdwilsh
2008-10-27 18:52:23 -04:00
Shawn Wilsher
53d9ccaa7e Bug 459789 - lazily get mDB[Invalid|Old]Frecencies
r=dietrich
2008-10-27 18:52:23 -04:00
Shawn Wilsher
d3792f99c1 Bug 459788 - Lazily get mDBBookmarkToUrlResult
r=dietrich
2008-10-27 18:52:23 -04:00
Shawn Wilsher
53bf616b5a Bug 459786 - lazily get mDBVisitTo[Visit|URL]Result
r=dietrich
2008-10-27 18:52:23 -04:00
Shawn Wilsher
5c893a5e9c Bug 459787 - remove mDBUrlToUrlResult
This changeset removes an unused query that was in the startup path.
r=dietrich
2008-10-27 18:52:22 -04:00
Shawn Wilsher
c7e57e1cb1 Bug 459781 - create our string bundle in a more sane way
This changeset only creates the string bundle when we need it, and only in one
place as opposed to two separate places.
r=dietrich
2008-10-27 18:52:22 -04:00
Shawn Wilsher
d3d72c5b09 Bug 459776 - date formatter is unused
This changeset removes a small part of code that places does in startup that is
not used or needed.
r=dietrich
2008-10-27 18:52:22 -04:00
Shawn Wilsher
34a4755e8b Bug 459773 - Creating a collation is expensive
This makes a lazy getter for getting our collation saving us about 3% of places
startup time.
r=dietrich
2008-10-27 18:52:21 -04:00
Marco Bonardo
27bd310336 Bug 455474 - cleanup nsNavBookmarks::Init
r=dietrich
2008-10-27 18:52:21 -04:00
Marco Bonardo
e8ac5aeecb Bug 459491 - nsPlacesDBFlush could use async queries instead of background thread
r=sdwilsh

--HG--
rename : toolkit/components/places/tests/background/head_background.js => toolkit/components/places/tests/sync/head_sync.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_modifyBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_modifyBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_quit_application.js => toolkit/components/places/tests/sync/test_database_sync_after_quit_application.js
rename : toolkit/components/places/tests/background/test_multiple_bookmarks_around_sync.js => toolkit/components/places/tests/sync/test_multiple_bookmarks_around_sync.js
rename : toolkit/components/places/tests/background/test_multiple_visits_around_sync.js => toolkit/components/places/tests/sync/test_multiple_visits_around_sync.js
2008-10-27 18:52:21 -04:00
Shawn Wilsher
866c0b3978 Bug 459315 - Wrap favicon work in a transaction
This wraps a series of statements that run on the main thread to reduce the
number of fsyncs that end up happening.
r=dietrich
2008-10-27 18:52:21 -04:00
Shawn Wilsher
2a07d62a96 Bug 459299 - nsNavHistory::SetPageTitleInternal is slow
This caches a statement that is created any time a pages title changes.  The
creation of the statement took roughly 66% of the functions execution time
according to shark.
It also removes a transaction that was not needed in this method.
r=dietrich
2008-10-27 18:52:21 -04:00
Marco Bonardo
f6e56b6916 Bug 456029 - optimize the temp table triggers
This changeset makes the triggers work much faster which should greatly reduce
the timings of adding a visit and a bookmark.
r=sdwilsh
2008-10-27 18:52:21 -04:00
Shawn Wilsher
7a2e763702 Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77
2008-10-27 18:52:20 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
3fc608c2a6 Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-10-27 18:52:20 -04:00
Shawn Wilsher
825b607244 Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-10-27 18:52:19 -04:00
Ehsan Akhgari
229637b291 Bug 248970 - Private Browsing mode (global toggle for saving/caching everything) [places part]; r=dietrich 2008-10-20 00:44:59 +03:30
Shawn Wilsher
5edc587690 Backout places fsync changes 2008-10-17 12:29:34 -04:00
Marco Bonardo
877c2f729e followup to bug 459934, fix memory leak, mpa=mano, for post facto review 2008-10-17 08:56:25 -04:00
Marco Bonardo
4d5942f11f Bug 459934 - should lazy-load places autocomplete statements
r=dietrich
r=sdwilsh
2008-10-17 06:12:53 -04:00
Shawn Wilsher
8cb912ef64 Bug 459789 - lazily get mDB[Invalid|Old]Frecencies
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
10cebaa66f Bug 459788 - Lazily get mDBBookmarkToUrlResult
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
2f47ae77b2 Bug 459786 - lazily get mDBVisitTo[Visit|URL]Result
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
653538e53f Bug 459787 - remove mDBUrlToUrlResult
This changeset removes an unused query that was in the startup path.
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
bb7e0e8c36 Bug 459781 - create our string bundle in a more sane way
This changeset only creates the string bundle when we need it, and only in one
place as opposed to two separate places.
r=dietrich
2008-10-17 06:12:53 -04:00
Shawn Wilsher
d9d1b7f304 Bug 459776 - date formatter is unused
This changeset removes a small part of code that places does in startup that is
not used or needed.
r=dietrich
2008-10-17 06:12:52 -04:00
Shawn Wilsher
1d0921f3e0 Bug 459773 - Creating a collation is expensive
This makes a lazy getter for getting our collation saving us about 3% of places
startup time.
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
867daf5b5f Bug 455474 - cleanup nsNavBookmarks::Init
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
53ea567322 Bug 459491 - nsPlacesDBFlush could use async queries instead of background thread
r=sdwilsh

--HG--
rename : toolkit/components/places/tests/background/head_background.js => toolkit/components/places/tests/sync/head_sync.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addBookmark_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addBookmark_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit.js
rename : toolkit/components/places/tests/background/test_database_sync_after_addVisit_batched.js => toolkit/components/places/tests/sync/test_database_sync_after_addVisit_batched.js
rename : toolkit/components/places/tests/background/test_database_sync_after_modifyBookmark.js => toolkit/components/places/tests/sync/test_database_sync_after_modifyBookmark.js
rename : toolkit/components/places/tests/background/test_database_sync_after_quit_application.js => toolkit/components/places/tests/sync/test_database_sync_after_quit_application.js
rename : toolkit/components/places/tests/background/test_multiple_bookmarks_around_sync.js => toolkit/components/places/tests/sync/test_multiple_bookmarks_around_sync.js
rename : toolkit/components/places/tests/background/test_multiple_visits_around_sync.js => toolkit/components/places/tests/sync/test_multiple_visits_around_sync.js
2008-10-17 06:12:52 -04:00
Shawn Wilsher
f5d2e83ae5 Bug 459315 - Wrap favicon work in a transaction
This wraps a series of statements that run on the main thread to reduce the
number of fsyncs that end up happening.
r=dietrich
2008-10-17 06:12:52 -04:00
Shawn Wilsher
4d5fb2f862 Bug 459299 - nsNavHistory::SetPageTitleInternal is slow
This caches a statement that is created any time a pages title changes.  The
creation of the statement took roughly 66% of the functions execution time
according to shark.
It also removes a transaction that was not needed in this method.
r=dietrich
2008-10-17 06:12:52 -04:00
Marco Bonardo
b71369cd19 Bug 456029 - optimize the temp table triggers
This changeset makes the triggers work much faster which should greatly reduce
the timings of adding a visit and a bookmark.
r=sdwilsh
2008-10-17 06:12:52 -04:00
Shawn Wilsher
4f97936d8c Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77

--HG--
rename : toolkit/components/places/tests/unit/head_bookmarks.js => toolkit/components/places/tests/background/head_background.js
2008-10-17 06:12:51 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
5715c324ab Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-10-17 06:12:51 -04:00
Shawn Wilsher
5790687517 Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-10-17 06:12:50 -04:00
Shawn Wilsher
810e90b149 Bug 460315 - set journal_mode to TRUNCATE
Sets the journal_mode to the places database to TRUNCATE
r=dietrich
2008-10-16 15:59:33 -04:00
Marco Bonardo
564c306794 Bug 458683 - Backup only uri nodes into tag containers, r=dietrich 2008-10-14 17:24:08 +02:00
Neil Rashbrook
b50d21d9c9 Bug 459571 Places autocomplete results contain incorrect search string r=sdwilsh,mardak 2008-10-14 14:54:17 +01:00
Marco Bonardo
3b22c3d551 Bug 457698 - nsNavHistoryFolderResultNode::OnItemAdded ignores dynamic containers, r=dietrich 2008-10-13 18:14:50 +02:00
Marco Bonardo
6d926ff1b7 Bug 457686 - appendURINode should not append to a dynamic container if we are inside an excludeItems query, r=dietrich 2008-10-13 18:06:50 +02:00
Marco Bonardo
56441e9d6e Bug 457681 - if ExcludeReadOnlyFolders is false, readonly dynamic containers are still excluded, r=dietrich 2008-10-13 17:58:36 +02:00
Marco Bonardo
b1351fc910 Bug 457677 - PlacesUtils ignores dynamic containers, r=dietrich 2008-10-13 17:54:25 +02:00
Marco Bonardo
68881489cf Bug 458013 - QueryResultNode Tag refresh optimization is useless as it is, r=dietrich 2008-10-13 14:11:27 +02:00
Ben Turner
311284ddff Bug 455436 - "XPConnect insists on using its own error reporter even when another is already set." r+sr=jst. 2008-10-12 11:32:34 -07:00
Arpad Borsos
8b11d938d2 Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan 2008-10-10 17:04:34 +02:00
Daniel Holbert
72c410a648 Bug 458167 - (comments-only changes) Grammar Nazi Vol1: s/it's/its/ for the posessive version of the word, and a few other misc comment-typos, in these directories: accessible browser config profile rdf toolkit tools xpcom xpfe 2008-10-01 23:49:45 -07:00
Marco Bonardo
bd07734758 Bug 448584 - Don't save invalid uri nodes while doing a JSON backup (don't stop while saving data), r=dietrich 2008-09-30 10:41:36 +02:00
Dietrich Ayala
89c275d5aa Bug 420331 - wyciwyg: uris show up in location bar (r=mardak) 2008-09-29 23:46:52 -07:00
Dietrich Ayala
2fa7f086c3 test for bug 331459 - Places query ignores onlyBookmarked 2008-09-29 23:28:08 -07:00
Dietrich Ayala
5d9c44b264 pushing test for bug 433317, forgot to check-in initially 2008-09-29 23:22:46 -07:00
Marco Bonardo
a599a40812 Follow-up to Bug 329534 - Live bookmarks load way too aggressively. Try to workaround possible VM timers bugs that could cause test failures. r=dietrich 2008-09-30 01:24:44 +02:00
Takeshi Ichimaru
820d6827ba Bug 329534 - Live bookmarks load way too aggressively (lock up/hang/freeze browser), r=dietrich, mak77 2008-09-27 13:05:28 +02:00
Shawn Wilsher
abd0d61c89 Backed out changeset ebafcda56f98 (bug 456910)
Backed out for Tp regression (bug 457288)
2008-09-26 15:55:03 -04:00
Shawn Wilsher
af8e0300cd Bug 456910 - Stop using exclusive locking in places
This allows us to greatly reduce the number of fsyncs when upgrading to sqlite.
The perf loss in no longer using this locking is not significant (10^-6 %).
r=dietrich
2008-09-25 13:50:41 -04:00
Marco Bonardo
77bb2e6d9c Bug 407468 - Livemark loading and failed to load messages should be static menuitems from menu.xml, original patch by Michael Schonfeld <dev@schonfeld.org>, r=mano 2008-09-25 12:30:33 +02:00
Marco Bonardo
5edd5fff2c Bug 418671 - Clean up places views drag and drop code, r=mano 2008-09-19 17:47:45 +02:00
Shawn Wilsher
5d3ab665f0 backout merge 2008-09-18 15:05:36 -04:00
Shawn Wilsher
9bf0fdc3ad backout merge 2008-09-18 15:03:15 -04:00
Shawn Wilsher
f46423d1af Backed out changeset eb14737f8488 (places fsync work) 2008-09-18 15:02:55 -04:00
Shawn Wilsher
9bc5bb6827 backout merge 2008-09-18 15:02:17 -04:00
Shawn Wilsher
47008f4df3 Backed out changeset c99b7659dc0a (places fsync work) 2008-09-18 15:01:51 -04:00
Shawn Wilsher
8df9786bcd backout merge 2008-09-18 15:01:01 -04:00
Shawn Wilsher
900250bc91 Backed out changeset f3c9af143cc1 (places fsync work) 2008-09-18 15:00:30 -04:00
Shawn Wilsher
09255da4ab Backed out changeset dabae13daacb 2008-09-18 14:47:31 -04:00
Shawn Wilsher
f909f6ff81 Test breakage fix from bug 449640 2008-09-18 13:51:33 -04:00
Shawn Wilsher
16fef55947 Bug 450290 - Sync the temp tables to the permanent tables.
This changeset adds code that is run at app-startup that will flush out changes
to the temporary tables into the permanent ones.  For moz_places, this is done
whenever we sync moz_historyvisits and when we add or modify a bookmark.  For
moz_historyvisits, this is done on a timer controlled by the preference
places.syncDBTableIntervalInSecs.
Changeset includes full test coverage for the above behaviors.
r=dietrich
r=Mak77

--HG--
rename : toolkit/components/places/tests/unit/head_bookmarks.js => toolkit/components/places/tests/background/head_background.js
2008-09-18 11:10:47 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
ec97557606 Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-09-18 11:10:34 -04:00
Shawn Wilsher
a981391a48 Bug 449086 - Create temporary tables for frequently used places tables
This changeset creates two temporary tables that will be used when inserting
data into moz_places and moz_historyvisits.  This will reduce the number of
writes as well as the number of fsyncs that happen.
r=dietrich
2008-09-18 11:10:09 -04:00