Commit Graph

1781 Commits

Author SHA1 Message Date
L. David Baron
446b33c572 Fix Windows bustage by using the alloca-inclusion incantation from jstracer.cpp. (Bug 636039) 2011-03-17 20:43:06 -07:00
L. David Baron
a16e79db9e Make nsCachedStyleData store arrays of nsStyleStruct*, and use style struct IDs for faster access to those arrays. (Bug 639231, patch 3) r=bzbarsky 2011-03-17 20:14:32 -07:00
L. David Baron
f7e180061f Fix indentation. (Bug 639231, patch 2) r=bzbarsky 2011-03-17 20:14:32 -07:00
L. David Baron
17fb4b6565 Keep reset and inherited style struct IDs separate. (Bug 639231, patch 1) r=bzbarsky 2011-03-17 20:14:31 -07:00
L. David Baron
f1fb6dbc73 Add poisoning for nsRuleData::mValueOffsets. (Bug 636039, patch 19) r=bzbarsky
I tested manually that after:
 (a) removing the |ruleData.mValueOffsets[aSID] = 0;| in
     nsRuleNode::WalkRuleTree
 (b) removing the NS_ABORT_IF_FALSE(aRuleData->mValueOffsets[aSID] == 0,
     ...) from nsRuleNode::CheckSpecifiedProperties and
     UnsetPropertiesWithoutFlags
that we crash dereferencing the poison address in a SetCoord call inside
nsRuleNode::ComputeTextResetData
2011-03-17 20:14:31 -07:00
L. David Baron
7dfaf2124a Make test_property_database.html give all the errors rather than throwing an exception for the first missing longhand property. (Bug 636039, patch 18) r=bzbarsky
The main fix is in the first of the three for loops modified, but the
new structure of that one seems like an improvement worth applying to
the other two.
2011-03-17 20:14:31 -07:00
L. David Baron
bfca304c0a Remove now unused nsRuleData* structs. (Bug 636039, patch 17) r=bzbarsky 2011-03-17 20:14:31 -07:00
L. David Baron
d5df3b1e50 Remove Moz prefixes from names of subproperty tables. (Bug 636039, patch 16) r=bzbarsky
This fixes the FIXME introduced in patch 4.
2011-03-17 20:14:31 -07:00
L. David Baron
8f037974d7 Instead of stack-allocating nsRuleData* structs in separate methods for each style struct, allocate an array of nsCSSValue using alloca. (Bug 636039, patch 15) r=bzbarsky 2011-03-17 20:14:31 -07:00
L. David Baron
aa39d3bc8d Add index and count data for the properties that need to be computed for each style struct. (Bug 636039, patch 14) r=bzbarsky
This adds a second occurrence of the ugliest pattern of nsCSSPropList.h
inclusion.
2011-03-17 20:14:31 -07:00
L. David Baron
8214ac4261 Make the three CSS_PROP_INCLUDE_NOT_CSS properties much more like normal CSS properties, and (importantly) give them property IDs in the longhand range. Replace CSS_PROP_INCLUDE_NOT_CSS with CSS_PROP_STUB_NOT_CSS for callers that need stubs. (Bug 636039, patch 13) r=bzbarsky 2011-03-17 20:14:31 -07:00
L. David Baron
863712f142 Remove now-unneeded parameters to COMPUTE_START_{INHERITED,RESET}. (Bug 636039, patch 12) r=bzbarsky 2011-03-17 20:14:31 -07:00
L. David Baron
2add6d4298 Convert nsRuleNode::Compute*Data to property getters instead of accessing struct members. (Bug 636039, patch 11) r=bzbarsky 2011-03-17 20:14:31 -07:00
L. David Baron
59b4de6d7d Correct checks that were for the wrong pseudo-property (script-level vs. script-size-multiplier). (Bug 636039, patch 10) r=bzbarsky 2011-03-17 20:14:31 -07:00
L. David Baron
bdbc263fe7 Remove unused *AtOffset methods. (Bug 636039, patch 9) r=bzbarsky 2011-03-17 20:14:31 -07:00
L. David Baron
019db3ab80 Convert custom style rules to property getters instead of accessing struct members. (Bug 636039, patch 8) r=bzbarsky 2011-03-17 20:14:31 -07:00
L. David Baron
a285ab1c0a Add nsRuleData::ValueForBackgroundColor, etc., methods for each CSS property. (Bug 636039, patch 5) r=bzbarsky 2011-03-17 20:14:30 -07:00
L. David Baron
6256bf49b3 Allow the method field in nsCSSPropList.h to be used with or without prefixes. (Bug 636039, patch 4) r=bzbarsky 2011-03-17 20:14:30 -07:00
L. David Baron
1bcb281e20 Don't bloat nsCSSTable for members that only need to exist in nsRuleDataTable. (Bug 636039, patch 3) r=bzbarsky 2011-03-17 20:14:30 -07:00
L. David Baron
dbf25be692 Correct comment describing nsRuleData::ValueFor. (Bug 636039, patch 2) r=bzbarsky
nsRuleData::ValueFor does not return null; it checks conditions that
would cause it to do so with NS_ABORT_IF_FALSE.  Callers are required to
check mSIDs.
2011-03-17 20:14:30 -07:00
Boris Zbarsky
0618ee48ae Bug 641856. column-rule needs to work even when overflow is not visible. r=roc 2011-03-17 13:41:52 -04:00
Craig Topper
c232171343 Bug 577002 Part 3: Make various ImportRule functions non-virtual and cleanup some return types. r=bzbarsky 2011-03-17 13:41:52 -04:00
Craig Topper
51c51ac5d7 Bug 577002 Part 2: Remove nsICSSImportRule. r=bzbarsky
--HG--
rename : layout/style/nsICSSImportRule.h => layout/style/ImportRule.h
2011-03-17 13:41:52 -04:00
Craig Topper
ed7596665a Bug 577002 Part 1: Rename CSSImportRuleImpl to mozilla::css::ImportRule. r=bzbarsky 2011-03-17 13:41:52 -04:00
Craig Topper
c4eb4e1d09 Bug 576877 Part 3: De-virtualize methods in NameSpaceRule. r=bzbarsky 2011-03-17 13:41:52 -04:00
Craig Topper
16a0c17c96 Bug 576877 Part 2: Remove nsICSSNameSpaceRule. r=bzbarsky
--HG--
rename : layout/style/nsICSSNameSpaceRule.h => layout/style/NameSpaceRule.h
2011-03-17 13:41:52 -04:00
Craig Topper
e09f420a06 Bug 576877 Part 1: Rename CSSNameSpaceRuleImpl to mozilla::css::NameSpaceRule. r=bzbarsky 2011-03-17 13:41:52 -04:00
L. David Baron
34651d06fe Include the opening "url(" in URL and Bad_URL tokens (though the latter do not have a close paren), and make tokenization of url() function be noncontextual, as required by CSS. (Bug 604179, patch 7) r=bzbarsky
Note that tokenization of url-prefix() and domain() remains contextual.

Needed to help CSS 2.1 meet Proposed Recommendation entrance criteria.
2011-03-11 11:29:45 -06:00
L. David Baron
62b1274403 Include the close parenthesis in the URL token and make quoted URLs produce URL tokens rather than string tokens. (Bug 604179, patch 6) r=bzbarsky 2011-03-11 11:29:45 -06:00
L. David Baron
d2fff89944 Disallow control characters less than space inside unquoted url(), per spec. (Bug 604179, patch 5) r=bzbarsky 2011-03-11 11:29:44 -06:00
L. David Baron
d03d993c7b Fix incorrect indentation in nsCSSScanner::NextURL. (Bug 604179, patch 4) r=bzbarsky 2011-03-11 11:29:44 -06:00
L. David Baron
0041c7ae2e Move the consumption of beginning whitespace (for all forms) and ending whitespace (for the string form) inside url() into the tokenizer. (Bug 604179, patch 3) r=bzbarsky 2011-03-11 11:29:44 -06:00
L. David Baron
866f3aece4 Rename CSS tokens to be closer to the names of newly-added tokens (BAD_STRING, BAD_URI) in the CSS 2.1 tokenization. (Bug 604179, patch 2) r=bzbarsky 2011-03-11 11:29:44 -06:00
L. David Baron
d321398917 Use GatherURL in ParseNameSpaceRule and ParseImageRect, and rename GatherURL to ParseURLOrString for clarity. (Bug 604179, patch 1) r=bzbarsky
Note that this adds a missing UngetToken(), which affects the other
consumer of GatherURL, parsing of @import rules.
2011-03-11 11:29:44 -06:00
Craig Topper
d52db340a6 Bug 576831 part 6. DeCOMtaminate some StyleRule method signatures. r=bzbarsky. 2011-03-10 21:50:20 -05:00
Craig Topper
45ad1bbe6f Bug 576831 part 5. Make some methods that used to be virtual non-virtual. r=bzbarsky 2011-03-10 21:50:12 -05:00
Craig Topper
72d7c1f754 Bug 576831 part 4. Remove nsICSSStyleRule and use mozilla::css::StyleRule instead. r=bzbarsky
--HG--
rename : layout/style/nsCSSStyleRule.cpp => layout/style/StyleRule.cpp
rename : layout/style/nsICSSStyleRule.h => layout/style/StyleRule.h
2011-03-10 21:48:57 -05:00
Craig Topper
5331afcc56 Bug 576831 part 3. Rename CSSImportantRule to mozilla::css::ImportantRule. r=bzbarsky 2011-03-10 21:48:26 -05:00
Craig Topper
2465d73b63 Bug 576831 part 2. Rename DOMCSSStyleRuleImpl to mozilla::css::DOMCSSStyleRule. r=bzbarsky 2011-03-10 21:47:52 -05:00
Craig Topper
40e645b9da Bug 576831 part 1. Rename CSSStyleRuleImpl to mozilla::css::StyleRule. r=bzbarsky 2011-03-10 21:47:08 -05:00
L. David Baron
802da587ae Merge layout work from projects/birch, part 2. 2011-03-23 17:39:29 -07:00
Boris Zbarsky
ef5a70b33c Bug 608759. Stop calling ContentEnumFunc through a function pointer; just call it directly. r=dbaron 2011-03-07 12:45:25 -05:00
L. David Baron
0c50a7e668 Use ParseSingleValueProperty for the components inside the 'transition' shorthand as well. (Bug 636029) r=bzbarsky 2011-03-05 09:58:33 -08:00
L. David Baron
7d588db662 Make generic mechanism for parsing lists of single values with ParseVariant. (Bug 636029) r=bzbarsky 2011-03-05 09:58:33 -08:00
L. David Baron
9576960b8d Drive the ParseVariant calls in ParseSingleValueProperty from data rather than a big switch. (Bug 636029) r=bzbarsky 2011-03-05 09:58:33 -08:00
L. David Baron
f66feda91a Fix keyword table entries in nsCSSPropList and code in nsRuleNode to match those used in the parser. (Bug 636029) r=bzbarsky 2011-03-05 09:58:33 -08:00
L. David Baron
36d847de86 Add 'parsevariant_' parameter to CSS_PROP macro, with all properties initially zero. (Bug 636029) r=bzbarsky 2011-03-05 09:58:33 -08:00
L. David Baron
1f77843f84 Separate properties that are parsed in ParseSingleValueProperty with something other than ParseVariant. (Bug 636029) r=bzbarsky 2011-03-05 09:58:33 -08:00
L. David Baron
ca34183567 Separate the non-property parsed in ParseSingleValueProperty. (Bug 636029) r=bzbarsky 2011-03-05 09:58:33 -08:00
L. David Baron
be4c804463 Disable parsing of 'marker', 'run-in', and 'compact' in a less hacky way. (Bug 636029) r=bzbarsky
This simply removes all the code for the values.  This removes a
special-case that would otherwise need to become more complicated in a
later patch in this series.
2011-03-05 09:58:33 -08:00
L. David Baron
97c0bdb8a8 Add parse types for CSS properties so we don't parse them in one huge switch. (Bug 636029) r=bzbarsky
With this patch, every CSS property is required to have one of the parse
type values (CSS_PROPERTY_PARSE_{FUNCTION,VALUE,INACCESSIBLE}) in its
flag bits.  This avoids needing a switch in
CSSParserImpl::ParseProperty(nsCSSProperty).

Note that this reserves more space in CSS_PROPERTY_PARSE_PROPERTY_MASK
than appears to be necessary; that space will be used in a later patch
in this series.
2011-03-05 09:58:33 -08:00
L. David Baron
185c0cd717 Make sure all properties in nsCSSPropList.h have useful values for the method_ field. (Bug 636039) r=bzbarsky
Note that these are unprefixed to be consistent with the similar
existing methods for other logical box properties.  Prefixing doesn't
matter for the dom property field of CSS_PROP_LIST_EXCLUDE_INTERNAL
properties, since dom property field of such properties is not exposed
to the Web.
2011-03-05 09:58:33 -08:00
Craig Topper
07e8b64cd1 Bug 585867 part 5. Remove outparam and AddRef from all property getters. r=bzbarsky 2011-03-04 12:28:57 -05:00
Craig Topper
aab3b367c9 Bug 585867 part 4. Make SetValueToStyleImage return void. r=bzbarsky 2011-03-04 12:28:57 -05:00
Craig Topper
04c3f87d46 Bug 585867 part 3. Make AppendCSSValue infallible. r=bzbarsky 2011-03-04 12:28:57 -05:00
Craig Topper
7dd8d4bedc Bug 585867 part 2. Make SetToRGBAColor return void. r=bzbarsky 2011-03-04 12:28:57 -05:00
Craig Topper
8a8824e583 Bug 585867 part 1. Remove OOM checks on the return value of GetROCSSPrimitiveValue and GetROCSSValueList. r=bzbarsky 2011-03-04 12:28:56 -05:00
Boris Zbarsky
1e753295f6 Bug 616137. Skip to the nearest ']' when parsing an attr selector fails. r=dbaron 2011-03-04 10:27:02 -05:00
L. David Baron
4fcef65cfe -moz-box-ordinal-group should not accept 0, since the code that uses the property ignores values of 0. (Bug 636034) r=bzbarsky 2011-03-03 13:18:42 -08:00
L. David Baron
31bb14549e Remove tracking of whether the font family comes from HTML, since we no longer use the information. (Bug 636040) r=jdaggett 2011-03-03 13:18:42 -08:00
L. David Baron
4a7745e74d Remove tracking of which font families are quirky, since we no longer use the information. (Bug 636040) r=jdaggett 2011-03-03 13:18:42 -08:00
L. David Baron
937df71675 Fix skipping of @-rules that are inside blocks to conform to new rule in CSS 2.1, which says that we must look for end-of-outer-block in addition to a semicolon or a block. (Bug 604175) r=bzbarsky
This fixes http://test.csswg.org/suites/css2.1/20110111/html4/at-rule-013.htm

Needed to help CSS 2.1 meet Proposed Recommendation entrance criteria.
2011-03-03 13:18:42 -08:00
L. David Baron
df01b98efe Make GatherMedia() stop at block or semicolon in invalid cases. (Bug 604172) r=bzbarsky
Needed to help CSS 2.1 meet Proposed Recommendation entrance criteria.
2011-03-03 13:18:42 -08:00
L. David Baron
f597990bf0 Add missing UngetToken() for invalid contents of @charset rule. (Bug 604172) r=bzbarsky
Needed to help CSS 2.1 meet Proposed Recommendation entrance criteria.
2011-03-03 13:18:42 -08:00
Boris Zbarsky
0685bcc521 Bug 635286. Fix dynamic handling of :not() inside :-moz-any(). r=dbaron, a=dbaron 2011-02-24 13:42:15 -05:00
L. David Baron
56e6f8182f Merge layout work from projects/birch, part 1. a=bsmedberg 2011-03-23 12:36:08 -07:00
Brad Lassey
715c879877 bug 623820 - Text zoom reflow messes up layout on AMO and other sites r=roc,dbaron a=blocking-fennec 2011-03-10 23:33:43 -05:00
Jonathan Kew
c4c9f2d9e9 bug 499292 - hide fallback text for a short time while a font downloads. r=jdaggett a=beltzner 2011-01-05 21:48:48 +00:00
Boris Zbarsky
0e2f2b9189 Bug 631352. Changes to @lang need to restyle all descendants. r=dbaron, a=blocker 2011-02-08 16:30:57 -05:00
Ehsan Akhgari
dbba341a45 Bug 573960 - Make the bordercolor attribute on table elements work again; r=bernd a=blocking-betaN+ 2011-01-31 16:23:01 -05:00
Boris Zbarsky
3693ed3012 Bug 631682. Make sure to start background image loads for the root element when we compute its style and decide to construct a frame. r+a=dbaron 2011-02-04 22:43:13 -05:00
Zack Weinberg
59157fdf7c Bug 631615: suppress CSS parser diagnostics in ParseSelectorString. r=dbaron a2.0=dbaron 2011-02-04 14:17:00 -08:00
Ehsan Akhgari
2b53877e27 Bug 630564 - Ctrl+Shift+X in the location bar in RTL mode should change the text alignment in addition to directionality; r=roc a=blocking-final+ 2011-02-03 01:31:14 -05:00
Jeff Walden
15fda24aa9 Bug 497869 - Future reserved words are syntax errors in strict mode. r=brendan 2011-01-22 17:46:22 -08:00
Jeff Walden
882117c5e3 Back out everything from the last several hours for turning into a disaster zone finally ending in total orange. r=return-to-sanity 2011-01-23 03:12:28 -08:00
Jeff Walden
5ef527b523 Another round of orange fixes, sigh. r=orange yet again 2011-01-23 00:12:05 -08:00
Ehsan Akhgari
f336cece56 Bug 581536 - Resizer direction doesn't handle dynamic changes correctly; r=bsbarsky a=blocking-betaN+
--HG--
rename : layout/reftests/forms/textarea-rtl.html => layout/reftests/forms/textarea-rtl-dynamic-attr.html
rename : layout/reftests/forms/textarea-rtl.html => layout/reftests/forms/textarea-rtl-dynamic-style.html
extra : rebase_source : c12e9bcce6d2af527d15fe2f78a80f056888846c
2010-12-10 19:25:25 -05:00
Ryan VanderMeulen
897def2555 Bug 586130 - Warning C4099 fixes (layout). r=dholbert a=bsmedberg 2011-01-20 19:49:09 -08:00
Boris Zbarsky
bca8ab1b11 Backed out changeset 4e9a62d516ef (bug 573960) on suspicion of causing test orange. 2011-01-18 22:58:44 -05:00
Daniel Kirsch
e2778245c3 Bug 573960. When bordercolor is set, it should also be used as the table grid color. r=fantasai, a=blocker 2011-01-18 21:20:35 -05:00
Boris Zbarsky
a7138566b2 Bug 625434. Make sure we don't get into a situation where we're failing to gc the ruletree for a page. r=dbaron, a=blocker 2011-01-18 21:20:35 -05:00
Neil Deakin
fee5806e2b Bug 489303, show resizer when statusbar is hidden, r=roc,gavin a=blocking 2011-01-17 09:35:32 -05:00
L. David Baron
2b85e5bd4e Make this test more reliable given imperfect timers, to fix TEST-UNEXPECTED-FAIL that has happened once so far. (Bug 613888) a=tests 2011-01-15 10:24:41 -08:00
L. David Baron
79ccd5106a Correctly fix up the parentage of child sheets when removing the primary nsCSSStyleSheet from an nsCSSStyleSheetInner. (Bug 623351) r=bzbarsky a2.0=blocking 2011-01-14 19:57:53 -08:00
SHIMODA Hiroshi ext:(%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
49ff43d268 Add test for transitionend events firing for transitions that, prior to bug 613888, were canceled right before completing. r=bzbarsky a2.0=blocking 2011-01-14 19:57:53 -08:00
L. David Baron
8ba3daf109 Don't cancel transitions that are almost completed (and round to their final value) when we get an unrelated style change. (Bug 613888) r=bzbarsky a2.0=blocking 2011-01-14 19:57:53 -08:00
Boris Zbarsky
f650e1ccdc Bug 589615 part 2. Rename the HTML preshint level to just the preshint level, since it's the only preshint level now. r=dbaron, a=dbaron 2011-01-14 21:14:41 -05:00
Boris Zbarsky
c58b055ea9 Bug 589615 part 1. Get rid of the non-HTML preshint level. r=dbaron 2011-01-14 21:14:41 -05:00
Ehsan Akhgari
b3f2d74515 Bug 620906 - Back out part of bug 289384 to make sure that scrollbars work in CKEditor fields again; r=roc a=blocking-final+ 2011-01-11 16:00:44 -05:00
L. David Baron
c6323b36fe Fix backwards handling of zero-duration transitions. (Bug 622461) r=bzbarsky a2.0=blocking2.0:betaN 2011-01-04 10:10:54 -05:00
Robert O'Callahan
e946441ff1 Bug 602757. Part 3: Change IsOpaque to GetOpaqueRegion so we can get useful opaque regions for content that uses border-radius. r=tnikkel,sr=dbaron,a=blocking 2011-01-03 14:48:09 +13:00
Robert O'Callahan
49d4e095a0 Bug 593604. Part 5: Mark CSS gradient images as opaque when all their stops are opaque. r=dbaron,a=blocking 2011-01-03 14:48:09 +13:00
L. David Baron
3c79fb9460 Correct handling of unitless zero in calc() expressions. (Bug 595648) r=bzbarsky a=blocking2.0:betaN+
This ensures that we treat a unitless zero as a number rather than a
length inside of calc() expressions.  This causes both the acceptance of
previously-rejected expressions (such as -moz-calc(0 * 1em)) and the
rejection of previously-accepted ones (such as -moz-calc(0 + 1em)).
2010-12-30 12:59:33 -05:00
L. David Baron
3efa9fabcc In contexts where the CSS parser accepts numbers and lengths, treat unitless zero as a number rather than a length. (Bug 595648) r=bzbarsky,dholbert a=blocking2.0:betaN+
This patch has the side-effect of changing the representation of '0'
values in properties added by SVG to use the number representation
rather than the length representation.  This requires marking the
stroke-dashoffset:0 test in test_value_computation.html as known to
fail, since computed style code now returns 0 rather than 0px, and also
requires changing some inputs and results in some SMIL tests (which
seems like it's showing a bug that we can't interpolate between
equivalent values when we ought to be able to do so).
2010-12-30 12:59:33 -05:00
Brian Birtles
98d103fe8b Bug 607537 - SVG SMIL: Support paint servers an animation values; r=dholbert,dbaron; a=roc 2010-12-29 10:31:14 +09:00
Gavin Sharp
82f380c4da Back out 0ab0603bea99 (bug 489303) due to suspected Txul regression, a=backout 2010-12-25 14:55:35 -05:00
Neil Deakin
49b5659acf Bug 489303 - No resizer since the statusbar is gone, r=gavin+roc, a=b 2010-12-21 13:19:00 -08:00
Mounir Lamouri
02dcd4ad59 Bug 612752 - Change :-moz-ui-invalid default style when the invalid element is focused. r=dbaron ui-r=limi a=blocking-final
--HG--
rename : layout/reftests/css-ui-invalid/default-style/button-ref.html => layout/reftests/css-ui-invalid/default-style/button-focus-ref.html
rename : layout/reftests/css-ui-invalid/default-style/button.html => layout/reftests/css-ui-invalid/default-style/button-focus.html
rename : layout/reftests/css-ui-invalid/default-style/input-ref.html => layout/reftests/css-ui-invalid/default-style/input-focus-ref.html
rename : layout/reftests/css-ui-invalid/default-style/input.html => layout/reftests/css-ui-invalid/default-style/input-focus.html
rename : layout/reftests/css-ui-invalid/default-style/select-ref.html => layout/reftests/css-ui-invalid/default-style/select-focus-ref.html
rename : layout/reftests/css-ui-invalid/default-style/select.html => layout/reftests/css-ui-invalid/default-style/select-focus.html
rename : layout/reftests/css-ui-invalid/default-style/textarea-ref.html => layout/reftests/css-ui-invalid/default-style/textarea-focus-ref.html
rename : layout/reftests/css-ui-invalid/default-style/textarea.html => layout/reftests/css-ui-invalid/default-style/textarea-focus.html
2010-12-21 19:58:04 -05:00
Serge Gautherie
cababf0538 Bug 558705 - [Debug] mochitests-4: intermittent "test_value_cloning.html | Test timed out."; (Av1) Increase timeout factor to 4 from 3.
r=dbaron a=(test only).
2010-12-21 03:08:23 +01:00
Chris Pearce
1b4176f2dc Bug 604885 commit backout merge. a=backout 2010-12-21 07:43:48 +13:00
Chris Pearce
7b3410e272 Bug 604885 - backout 00cabcc7d182 a=backout 2010-12-21 07:42:41 +13:00
Mihai Sucan
215e61a4b2 Bug 606498 - Make sure the new nsIScriptError2 is used in all possible places- part 3; r=bzbarsky,dbaron,mrbkap sr=jst a=blocking2.0 2010-12-20 12:21:59 -04:00
timeless@mozdev.org
2c5b4a64dc Bug 619785 - nsComputedDOMStyle::DoGetMozBackgroundSize leaks valY when it has problems with valX, r+a=bz 2010-12-16 14:01:00 -08:00
Chris Pearce
8ef4f2a1d5 Bug 604885 - Don't render video controls outside of css-specified width/height. r=roc a=blocking2.0 2010-11-25 07:34:56 +13:00
Mounir Lamouri
b857423fb5 Bug 613249 - <output> should have :-moz-ui-invalid and :-moz-ui-valid applying. r=bz a=jst
--HG--
rename : layout/reftests/css-invalid/output/output-invalid.html => layout/reftests/css-ui-invalid/output/output-invalid.html
rename : layout/reftests/css-invalid/output/output-ref.html => layout/reftests/css-ui-invalid/output/output-ref.html
rename : layout/reftests/css-invalid/output/output-valid.html => layout/reftests/css-ui-invalid/output/output-valid.html
rename : layout/reftests/css-invalid/output/reftest.list => layout/reftests/css-ui-invalid/output/reftest.list
rename : layout/reftests/css-invalid/output/style.css => layout/reftests/css-ui-invalid/output/style.css
rename : layout/reftests/css-valid/output/output-invalid.html => layout/reftests/css-ui-valid/output/output-invalid.html
rename : layout/reftests/css-valid/output/output-ref.html => layout/reftests/css-ui-valid/output/output-ref.html
rename : layout/reftests/css-valid/output/output-valid.html => layout/reftests/css-ui-valid/output/output-valid.html
rename : layout/reftests/css-valid/output/reftest.list => layout/reftests/css-ui-valid/output/reftest.list
rename : layout/reftests/css-valid/output/style.css => layout/reftests/css-ui-valid/output/style.css
2010-11-24 11:13:05 +01:00
Mounir Lamouri
2e73d2b24f Bug 605125 (1/5) - Add :-moz-ui-valid pseudo-class. r=bz a=jst 2010-11-24 00:54:29 +01:00
Mounir Lamouri
f047fa2dbd Bug 609017 - Default style for :-moz-ui-invalid. r=bz ui-r=limi a=sicking 2010-11-24 00:51:43 +01:00
Mounir Lamouri
261a755de9 Bug 605124 (1/5) - Add :-moz-ui-invalid pseudo-class. r=bz a=bsmedberg 2010-11-24 00:48:18 +01:00
Mounir Lamouri
18a60e943d Bug 609016 - Remove default style for :invalid. r=bz a=bsmedberg 2010-11-24 00:47:26 +01:00
L. David Baron
6808a1e824 For transition reversing computations, ensure valuePortion is within 0.0-1.0. (Bug 611238) r=bzbarsky a=blocking2.0:final
Without the change to ensure that valuePortion is nonnegative, duration
might become negative, which it's not allowed to be.  Without this
change, this can happen when a transition starts off moving into
negative value space, which happens when y1 in the timing function is
negative.  The result that we want should come from using the absolute
value (rather than clamping to zero): if we reverse the transition when
it's in this negative space, we want the same movement we'd get if it
were the same distance into positive value space, just in the opposite
direction.

Additionally, I'm clamping valuePortion to be at most 1.  This affects
"bouncy" transitions where the timing function's y2 is greater than
one.  This is less critical, but ensures the invariant that a transition
will never take longer than its specified time, which seems like a good
thing to ensure.

I believe doing this computation at this stage is preferable to doing it
before the multiplication by oldPT.mReversePortion, since we should be
clamping the value within the range of the complete transition, not just
relative to the most recent reverse.
2010-12-16 08:53:17 -08:00
L. David Baron
476d1363df Remove comment that I forgot to remove in the previous patch (which fixed the issue it was pointing out). (Bug 617372) a2.0=tests 2010-12-16 08:53:17 -08:00
Mark Finkle
03f0b98a1e Bug 618016 - Make a new media query for device orientation [r=dbaron a=blassey] 2010-12-10 13:35:36 -05:00
timeless@mozdev.org
9a2f4154dd Bug 617971 nsStyleAnimation::ExtractComputedValue leaks pair when StyleCoordToCSSValue fails.
r=bz a=bz
2010-12-10 10:31:37 -08:00
L. David Baron
ac228b186b Make style system mochitests handle cases where initial font family is sans-serif. (Bug 617372) a2.0=tests 2010-12-09 20:38:53 -08:00
Daniel Brooks
597dd0c5a7 back out about:startup due to crashes during mochitests (a89f24bf1798) a=bustage 2010-12-08 03:43:33 -06:00
Daniel Brooks
115293a267 Bug 593743 - about:startup page showing historical startup timings; final merge with trunk. ui-r=beltzner feedback=mak77 r=mossop sr=vlad a=bsmedberg 2010-12-07 22:10:14 -06:00
Daniel Brooks
37d3c66f90 about:startup - merge vlad's review comments with the trunk
--HG--
rename : testing/mochitest/runtests.py.in => testing/mochitest/runtests.py
2010-11-23 09:49:19 -06:00
Daniel Brooks
4e4c6fce15 about:startup - merge with trunk 2010-10-24 16:24:58 -05:00
L. David Baron
88c9a20f8d Add test for nsStyleAnimation::ComputeDistance. (Bug 598099) r=bzbarsky a2.0=blocking-betaN 2010-10-23 16:31:55 -07:00
L. David Baron
8cb1c8371d Change distance computation for transforms so that distance ratios match interpolation. (Bug 598099) r=bzbarsky a2.0=blocking-betaN 2010-10-23 16:31:55 -07:00
L. David Baron
2a41b9c1dc Make AnimValuesStyleRule::MapRuleInfoInto check that property hasn't been filled in yet, so that it cascades correctly and interacts correctly with nsStyleSet::ResolveStyleByAddingRules. (Bug 598099) r=bzbarsky a2.0=blocking-betaN 2010-10-23 16:31:55 -07:00
L. David Baron
606f3325dc Revert code changes from changeset 1640dcbf1d4c (bug 541406), and add embed:-moz-focusring too, now that bug 542595 is fixed. r=roc 2010-10-23 16:31:55 -07:00
Daniel Brooks
7961ced955 about:startup - merge with trunk 2010-09-27 05:38:17 -05:00
Daniel Brooks
45773d35d8 about:startup - merge with trunk 2010-09-21 15:06:04 -04:00
L. David Baron
7b399c630c Add NS_FINAL_CLASS annotations to rule classes. r=bzbarsky Add virtual that I missed on nsCSSGroupRule. (Bug 596140) a=me 2010-09-18 12:15:31 -07:00
L. David Baron
c8b09f7d85 Eliminate all virtual functions from nsCSSRule to eliminate its vtable pointer. (Bug 596140) r=bzbarsky a2.0=roc 2010-09-18 11:43:17 -07:00
L. David Baron
5e6ca7ce7e Save a word in nsCSSStyleRule on 32-bit systems by merging mWasMatched into one bit of mLineNumber. (Bug 596140) r=bzbarsky a2.0=roc 2010-09-18 11:43:17 -07:00
L. David Baron
f13a8c3dc3 Make NBSP an identifier character per resolution of CSS 2.1 issue 196. (Bug 591589) r=bzbarsky a2.0=roc 2010-09-18 11:43:17 -07:00
L. David Baron
f9f83b43d4 Remove another piece of code I missed when removing min() and max(). (Bug 363249) r=bzbarsky a2.0=blocking 2010-09-17 12:29:53 -07:00
Mounir Lamouri
2900163868 Bug 557087 (3/6) - Make layout aware of the new disabled state rule. r=dbaron a=sicking
--HG--
extra : rebase_source : 9e7d0a515c3f1bcacdcccc906c611849654ab484
2010-09-19 03:43:15 +02:00
Timothy Nikkel
d4615fd0e6 Bug 593262. The stop/reload button is chasing me. Keep running from it. r=roc a=fix a test
--HG--
rename : layout/style/test/hover_helper.html => layout/style/test/chrome/hover_helper.html
rename : layout/style/test/test_hover.html => layout/style/test/chrome/test_hover.html
2010-09-03 00:43:26 -05:00
Boris Zbarsky
668eb611a1 Bug 594737. Disabled selects with size and multiple should still look disabled. r=dbaron 2010-09-15 12:40:11 -07:00
Boris Zbarsky
f7eeb3d973 Bug 592698. We might not have a presshell by this point, so null-check it. r=dbaron 2010-09-15 12:40:11 -07:00
L. David Baron
4219ac310a Add test for animation of calc() values of background-position and background-size. (Bug 520234, bug 594934) a=tests 2010-09-15 08:11:27 -07:00
L. David Baron
c8d807ef1f Remove null-checks for infallible array allocations. (Bug 520234) r=bzbarsky a=blocking2.0:beta7 2010-09-15 08:11:27 -07:00
L. David Baron
63b684953a Add a fallible version of nsCSSValue::Array::Create. (Bug 520234) r=bzbarsky a=blocking2.0:beta7 2010-09-15 08:11:26 -07:00
L. David Baron
2cd46b5b84 Allow calc() as an intermediate common animation unit for background-position and background-size. (Bug 520234) r=bzbarsky a=blocking2.0:beta7 2010-09-15 08:11:26 -07:00
L. David Baron
26b2700a1e Allow calc() as an intermediate common animation unit between lengths, percentages, and calc(). (Bug 520234) r=bzbarsky a=blocking2.0:beta7 2010-09-15 08:11:26 -07:00
L. David Baron
c885417e47 Add CSS property bit for which properties have stored calc() in style structs. (Bug 520234) r=bzbarsky a=blocking2.0:beta7 2010-09-15 08:11:26 -07:00
L. David Baron
dd9ab05cf6 Extract calc() values in nsStyleAnimation when needed. (Bug 520234) r=bzbarsky a=blocking2.0:beta7 2010-09-15 08:11:26 -07:00
L. David Baron
c9bc69a037 Add calc() unit to nsStyleAnimation::Value. (Bug 520234) r=bzbarsky a=blocking2.0:beta7 2010-09-15 08:11:26 -07:00
L. David Baron
06bd2147cd Support calc() on background-position, background-size, -moz-transform-origin, and background-image gradient stop positions. (Bug 594934) r=bzbarsky a=blocking2.0:betaN
(Note:  this also depends on the change to nsStyleAnimation.cpp's StyleCoordToValue in bug 520234 and on other changes in that bug.)
2010-09-15 08:11:26 -07:00
L. David Baron
d79b3f75c2 Change storage of background-size and background-position to allow percentages and lengths. (Bug 594934) r=bzbarsky a=blocking2.0:betaN 2010-09-15 08:11:26 -07:00
Robert Longson
d796beb26c Bug 489871 - CSS comments should not be allowed in presentation attribute values. r=dbaron a=roc
--HG--
extra : rebase_source : 7a41fca1422a024934839ebe0c50cc479223915f
2010-12-05 20:37:39 +00:00
Daniel Holbert
59aec5e3a8 Bug 615977: Make nsCSSValue::BufferFromString() return an already_AddRefed pointer. r=dbaron a=roc
--HG--
extra : rebase_source : b4048d8fbde522f05a01df693887e0e26a5afb97
2010-12-05 13:17:29 +00:00
Ehsan Akhgari
1bd8b7c9e7 Bug 613130 - Don't sanitize style nodes and attributes in the sanitizing parser if we have not found any unsafe properties; r=roc,bzbarsky a=blocking-final+ 2010-11-24 13:31:52 -05:00
Boris Zbarsky
ce4d032cff Bug 608914 part 2. Get rid of some temporary strings now that we can AppendFloat to an nsAString. r=dbaron 2010-11-30 13:18:15 -05:00
Dave Townsend
7a0e0a5cd9 Backing out bug 614058, bug 609272, bug 478445, bug 499628, bug 605296, bug 608914 and bug 614724 due to potentially causing bug 615736 CLOSED TREE. a=backout 2010-12-01 11:01:56 -08:00
Boris Zbarsky
325022b283 Bug 608914 part 2. Get rid of some temporary strings now that we can AppendFloat to an nsAString. r=dbaron 2010-11-30 13:18:15 -05:00
Robert O'Callahan
7db127ab8d Bug 584494 - Regression: Transform rotation testcase performs significantly worse - r=dbaron 2010-09-02 14:07:37 -04:00
L. David Baron
6d0e099a47 Cache non-percent margin and padding calc() on the style struct. (Bug 585715) r=bzbarsky a2.0=blocking:beta6+ 2010-08-31 12:05:12 -04:00
L. David Baron
26ed2a5639 Add support for calc() to 'vertical-align' and 'text-indent'. (Bug 585715) r=bzbarsky a2.0=blocking:beta6+ 2010-08-31 12:05:12 -04:00
L. David Baron
ed01917887 Add support for calc() to the '{margin,padding}-{top,right,bottom,left}' and '-moz-margin-{start,end}' properties. (Bug 585715) r=bzbarsky a2.0=blocking:beta6+ 2010-08-31 12:05:12 -04:00
L. David Baron
b3fa68a978 Make nsStyleCoord::operator== check deep equality of calc() expressions rather than just doing pointer comparison. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-31 12:05:12 -04:00
Timothy Nikkel
dbe82d94fd Bug 549799. Open the hover test in a new window so things in the chrome don't trigger reflows during the test. r=roc
--HG--
rename : layout/style/test/test_hover.html => layout/style/test/hover_helper.html
2010-08-27 18:15:08 -05:00
Ms2ger
806677bfc9 Bug 585014 - Use Element in nsDOMCSSAttributeDeclaration; r=bzbarsky approval2.0=benjamin 2010-08-27 09:03:36 +02:00
Boris Zbarsky
90139f083f Bug 589672 followup. Don't unget on code paths where it's already been handled for us. Fixes test orange. r+a=dbaron 2010-08-25 17:10:11 -04:00
Boris Zbarsky
341cd11eb6 Bug 589672. Parsing of malformed namespace rules can skip over too many tokens while recovering. r=dbaron, a=dbaron 2010-08-25 14:54:48 -04:00
Boris Zbarsky
19c43a518c Bug 586400. Cellpadding changes need to reresolve descendants. r=dbaron 2010-08-25 14:54:47 -04:00
L. David Baron
065207f2c7 Add support for calc() to the 'top', 'right', 'bottom', and 'left' properties. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:56 +02:00
L. David Baron
de93cb92ab Make it possible to store pointer values in nsStyleSides. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:56 +02:00
L. David Baron
20bf35dbf2 Avoid serializing calc() expressions in computed style when the calc() expression has no percentages and we have no percentage basis. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:56 +02:00
L. David Baron
b99a005c4c Add support for calc() to the 'min-width' and 'max-width' properties. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:56 +02:00
L. David Baron
091d6b7837 Add support for calc() to the 'height', 'min-height', and 'max-height' properties. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:55 +02:00
L. David Baron
6f943b1da3 Introduce nsStyleCoord::HasCoordOrNonPercentCalc to check for either a coord value or a calc() value not containing a percent. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:55 +02:00
L. David Baron
1a458f4877 Introduce nsStyleCoord::HasPercent to check for either a percent value or a calc() value containing a percent. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:55 +02:00
L. David Baron
698bb0f927 Add support for calc() to ComputeWidthDependentValue and ComputeHeightDependentValue. Also change calc() handling of percents from using round to using floor, which changes our handling of percents on 'width' back to using floor, reverting an earlier change in this bug. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:55 +02:00
L. David Baron
3fc44d5786 Fix computed style for percents for offset properties when the element doesn't have a frame. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:55 +02:00
L. David Baron
4bec3e8641 Add prerequisites for better testing of 'top', 'right', 'bottom', and 'left'. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:55 +02:00
L. David Baron
b1710a1d59 Add prerequisites for better testing of min/max-width/height properties. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:55 +02:00
L. David Baron
d742138a00 Add prerequisites for better testing of 'height'. (Bug 585715) r=bzbarsky a2.0=blocking+ 2010-08-25 12:17:55 +02:00
Mounir Lamouri
100dc92dd8 Bug 566045 - Default style for invalid form elements with :invalid. r=dbaron ui-r=limi a2.0=sicking 2010-08-25 06:40:31 +02:00
Mounir Lamouri
41d31e0af5 Bug 457801 (1/2) - Implement -moz-placeholder pseudo-class. r=dbaron a2.0=blocking 2010-08-25 06:39:10 +02:00
Mounir Lamouri
a998cdc78c Backing out unintentional push ba7b3f3d3451, b21458f2e3a2 and f69cabe709ca. a=backout 2010-08-25 02:40:47 +02:00
Mounir Lamouri
5de293a274 Bug 457801 (1/3) - Implement -moz-placeholder pseudo-class. r=dbaron a2.0=blocking 2010-08-24 21:02:09 +02:00
Ms2ger
0cf7a5d525 Bug 562698 - Part c: Pass Elements to AttributeWillChange; r=bzbarsky, a=dbaron 2010-08-24 09:06:20 +02:00
Jonathan Kew
727aef0e67 bug 585718 - support -moz-font-feature-settings and -moz-font-language-override in nsCSSFontFaceStyleDecl::GetPropertyValue. r+a=dbaron 2010-08-23 11:32:03 +01:00
Timothy Nikkel
b8932db7ab Bug 593491. Load an external file instead of data URI to see if anything changes for random orange. a=test 2010-11-24 19:35:02 -06:00
Zack Weinberg
0b50a47186 Bug 576044 (12/12): fix assertions in nsStyleAnimation triggered by part 3. r=dbaron a2.0=dbaron 2010-08-19 15:33:45 -04:00
Zack Weinberg
56198f48ed Bug 576044 (11/12): Make all assertions fatal in Declaration.h, Declaration.cpp, nsCSSDataBlock.h, nsCSSDataBlock.cpp, nsCSSValue.h, nsCSSValue.cpp, nsCSSProps.h, and nsCSSProps.cpp. r=dbaron a2.0=dbaron 2010-08-19 15:33:44 -04:00
Zack Weinberg
bd1cdb9ce4 Bug 576044 (10/12): Don't directly manipulate the contents of mTempData in the CSS parser. r=dbaron a2.0=dbaron 2010-08-19 15:33:44 -04:00
Zack Weinberg
a589629d5e Bug 576044 (9/12): Add an AddLonghandProperty method to nsCSSExpandedDataBlock. r=dbaron a2.0=dbaron 2010-08-19 15:33:44 -04:00
Zack Weinberg
33b5fbfe1b Bug 576044 (8/12): remove the last MoveValue call from the CSS parser. r=dbaron a2.0=dbaron 2010-08-19 15:33:44 -04:00
Zack Weinberg
c400e27e25 Bug 576044 (7/12): cleanup pass on css/Declaration.{h,cpp} and nsCSSDataBlock.{h,cpp}. r=dbaron a2.0=dbaron 2010-08-19 15:33:44 -04:00
Zack Weinberg
bc4afbe28a Bug 576044 (6/12): remove vestiges of nsCSSType. r=dbaron a2.0=dbaron 2010-08-19 15:33:44 -04:00
Zack Weinberg
a5a3802007 Bug 576044 (5/12): eliminate ValueList as a storage type. r=dbaron a2.0=dbaron 2010-08-19 15:33:44 -04:00
Zack Weinberg
0251ba5a66 Bug 576044 (4/12): eliminate ValuePairList as a storage type. r=dbaron a2.0=dbaron 2010-08-19 15:33:44 -04:00
Zack Weinberg
e0203804f9 Bug 576044 (3/12): eliminate Rect as a storage type. r=dbaron a2.0=dbaron 2010-08-19 15:33:44 -04:00
Zack Weinberg
5922bd1bb5 Bug 576044 (2/12): eliminate ValuePair as a storage type. r=dbaron a2.0=dbaron 2010-08-19 15:33:44 -04:00
Zack Weinberg
e93186d2e7 Bug 576044 (1/12): Move all the CSS 'storage types' (rect, value pair, etc) to nsCSSValue.h and their code to nsCSSValue.cpp. r=dbaron a2.0=dbaron 2010-08-19 15:33:43 -04:00
Mounir Lamouri
d45aa3e0d0 Bug 604673 - <output> should be subject for constraint validation. r=smaug ui-r=limi a=bsmedberg 2010-11-17 17:30:03 +01:00
Daniel Holbert
7218dcc764 Bug 606722 followup: Remove now-unused variable "tfunc" from nsStyleAnimation::ComputeDistance. r+a=dbaron 2010-11-16 15:19:21 -08:00
Daniel Holbert
babe295a0e Bug 604816 followup: Remove now-unused variable "stretch" from CheckFontCallback in nsRuleNode.cpp. r=dbaron a=dbaron 2010-11-16 10:35:59 -08:00
L. David Baron
ef78257c0c Animate skew in angle space rather than tangent space for interop and to avoid issues with infinite tangents. (Bug 606722) r=bzbarsky a2.0=blocking 2010-11-16 09:56:03 -08:00
Kyle Huey
99fecd3066 Backing out Bug 590181 since the GCC 4.5 upgrade failed on this CLOSED TREE 2010-11-11 12:36:01 -05:00
Justin Lebar
c50ec5e108 Bug 590181 - Part 1: Fix linux tests broken by GCC at -O3. r=dbaron 2010-09-29 14:32:17 -07:00
L. David Baron
2bee206d34 Don't use ComputeDistance in nsTransitionManager when shortening reversals of partially running transitions, and shorten only transitions that are actually back to the current start point. (Bug 582379, bug 526784) r=bzbarsky a2.0=blocking 2010-11-10 07:49:53 -08:00
L. David Baron
e0c6877082 Fix division-by-zero crash that dholbert saw, although I haven't been able to, and make the code a bit more robust. (Bug 582379) r=bzbarsky a2.0=blocking 2010-11-10 07:49:53 -08:00
L. David Baron
ed2ce3bf01 Make 'bolder' and 'lighter' values of 'font-weight' be computed in the style system, per recent edits to CSS 2.1. (Bug 93725) r=jdaggett a2.0=joedrew 2010-11-10 07:49:52 -08:00
L. David Baron
850dc81ab2 Remove support (style system only) for 'wider' and 'narrower' values of 'font-stretch'. (Bug 604816) r=jdaggett a2.0=joedrew 2010-11-10 07:49:52 -08:00