Shawn Wilsher
bc8e10dcd1
Backed out changeset 998cc827bfb1 due to leaks found with the added tests.
2008-06-16 15:00:06 -04:00
Shawn Wilsher
b20109dead
Bug 438653
...
This moves the two remaining browser tests in toolkit/mozapps/downloads/tests to
an xpcshell test and a chrome test. The reason for this change is to remove the
dependency of the browser from download manager tests since it is a toolkit
component.
r=gavin
--HG--
rename : toolkit/mozapps/downloads/tests/browser/browser_bug_406857.js => toolkit/components/downloads/test/unit/test_bug_406857.js
rename : toolkit/mozapps/downloads/tests/browser/browser_bug_412360.js => toolkit/mozapps/downloads/tests/chrome/test_bug_412360.xul
2008-06-16 12:58:28 -04:00
Shawn Wilsher
9965f93d2f
Bug 438998
...
This changes the anonymous functions in DownloadProgressListener.js to named
functions so that tools like dtrace and JS debuggers actually know what is
being called so they can do something useful.
r=Mossop
2008-06-13 11:44:30 -04:00
Shawn Wilsher
6511ccbaa7
Bug 438993
...
This makes the anonymous functions in DownloadUtils.jsm into non-anonymous ones
so things like dtrace and JS debuggers know where they are actually at instead
of having no idea.
r=Mossop
2008-06-13 11:44:13 -04:00
Shawn Wilsher ext:(%2C%20Edward%20Lee%20%3Cedward.lee%40engineering.uiuc.edu%3E)
0773365035
Bug 437302
...
Tests that don't depend on the browser should be chrome tests
r=Mardak
--HG--
rename : toolkit/mozapps/downloads/tests/browser/browser_bug_411172_mac.js => toolkit/mozapps/downloads/tests/chrome/test_backspace_key_removes.xul
rename : toolkit/mozapps/downloads/tests/browser/browser_basic_functionality.js => toolkit/mozapps/downloads/tests/chrome/test_basic_functionality.xul
rename : toolkit/mozapps/downloads/tests/browser/browser_bug_429247.js => toolkit/mozapps/downloads/tests/chrome/test_bug_429247.xul
rename : toolkit/mozapps/downloads/tests/browser/browser_cleanup_search.js => toolkit/mozapps/downloads/tests/chrome/test_cleanup_search.xul
rename : toolkit/mozapps/downloads/tests/browser/browser_bug_411172.js => toolkit/mozapps/downloads/tests/chrome/test_delete_key_removes.xul
rename : toolkit/mozapps/downloads/tests/browser/browser_bug_416303.js => toolkit/mozapps/downloads/tests/chrome/test_esc_key_closes_clears.xul
rename : toolkit/mozapps/downloads/tests/browser/browser_multi_select.js => toolkit/mozapps/downloads/tests/chrome/test_multi_select.xul
rename : toolkit/mozapps/downloads/tests/browser/browser_multiword_search.js => toolkit/mozapps/downloads/tests/chrome/test_multiword_search.xul
rename : toolkit/mozapps/downloads/tests/browser/browser_bug_410289.js => toolkit/mozapps/downloads/tests/chrome/test_pause_button_state.xul
rename : toolkit/mozapps/downloads/tests/browser/browser_bug_394039.js => toolkit/mozapps/downloads/tests/chrome/test_removeDownload_updates_ui.xul
rename : toolkit/mozapps/downloads/tests/browser/browser_bug_413093.js => toolkit/mozapps/downloads/tests/chrome/test_retention_is_0_closes.xul
rename : toolkit/mozapps/downloads/tests/browser/browser_search_clearlist.js => toolkit/mozapps/downloads/tests/chrome/test_search_clearlist.xul
rename : toolkit/mozapps/downloads/tests/browser/browser_select_all.js => toolkit/mozapps/downloads/tests/chrome/test_select_all.xul
rename : toolkit/mozapps/downloads/tests/browser/browser_bug_413985.js => toolkit/mozapps/downloads/tests/chrome/test_space_key_pauses_resumes.xul
rename : toolkit/mozapps/downloads/tests/browser/browser_bug_397935.js => toolkit/mozapps/downloads/tests/chrome/test_ui_stays_open_on_alert_clickback.xul
2008-06-11 11:06:39 -04:00
Dão Gottwald
788833b26d
Bug 437646
...
make use of :nth-child in the download list, remove stripeifyList()
r=sdwilsh
2008-06-11 10:11:14 -04:00
Edward Lee
4943c4e435
Bug 419691 - Get multiword search testcase working on windows. r=sdwilsh
2008-06-07 16:29:38 -07:00
Nochum Sossonko
91304d0cf2
Bug 429247
...
Double-clicking on empty white space in the Download Manager activates the currently selected item
r=sdwilsh
2008-06-04 11:05:09 -04:00
edward.lee@engineering.uiuc.edu
33ab985b80
Bug 431188 - Clear list active / inactive state not working properly. r=sdwilsh, a1.9=beltzner
2008-05-06 16:25:36 -07:00
kairo@kairo.at
a8b1834668
bug 431453 - Make browser-chrome mochitests pass on SeaMonkey: make some platform tests Firefox-only or non-SeaMonkey (as applicable), r=smontagu for docshell, r=dwitte for cookie, r=gavin for dlmgr, a1.9=damons for platform tests; make SeaMonkey sanitizer tests pass, sr=Neil
2008-05-02 06:13:19 -07:00
edward.lee@engineering.uiuc.edu
88e1f673ec
Bug 430486 - Clear List button doesn't disable when it should. r=sdwilsh, r=mconnor, ui-r=mconnor, a1.9=mconnor. Fixes Bug 430597 - New clearListButton does not accomodate larger fonts
2008-04-24 22:59:31 -07:00
edward.lee@engineering.uiuc.edu
bc05f2d225
Bug 400495 - Add "Clear List" button to download manager. r=mconnor, ui-r=beltzner, ui-r=mconnor, b-ff3=beltzner, a1.9=mconnor
2008-04-22 20:57:05 -07:00
edward.lee@engineering.uiuc.edu
1574b4d209
Fix testcase for bug 429614 to check platform (cmd-a vs ctrl-a)
2008-04-19 01:47:09 -07:00
edward.lee@engineering.uiuc.edu
be272ae0e4
Bug 429614 - add select all keyboard shortcut and context menu item to download manager. p=beltzner, r=sdwilsh, r=Mardak, ui-r=mconnor, a1.9=mconnor
2008-04-19 00:36:39 -07:00
mozilla.mano@sent.com
a41e0911c9
Bug 420405 - Download triggered by <iframe src=...exe> fails if containing page has refreshed. r+a=mconnor.
2008-04-18 11:08:00 -07:00
edward.lee@engineering.uiuc.edu
224482cf75
Bug 429144 - If downloaded file is removed, but saved dir still exists, then "Open Containing Folder" menu item should be disabled. r=sdwilsh, a1.9=beltzner
2008-04-15 22:28:59 -07:00
edward.lee@engineering.uiuc.edu
4c5b079d80
Bug 426983 - Make the download option Clear List always available. r=sdwilsh, a1.9=beltzner
2008-04-12 12:42:03 -07:00
edward.lee@engineering.uiuc.edu
be7f2c274f
Update testcase for bug 406857 using bug 425753 notification
2008-04-09 10:34:32 -07:00
edward.lee@engineering.uiuc.edu
ddc6189578
Bug 228842 - Allow multiple selections in Download Manager. r=sdwilsh, a1.9=beltzner
2008-04-08 22:33:39 -07:00
edward.lee@engineering.uiuc.edu
f1b5a0bf87
Re-disable test for windows
2008-04-05 22:47:30 -07:00
edward.lee@engineering.uiuc.edu
f32db9996f
Bug 425753 - Send notification when download manager finishes building the list. r=sdwilsh, a1.9=beltzner
2008-04-05 21:26:18 -07:00
reed@reedloden.com
aa19a372c7
Bug 424547 - "Fix strings so they are more descriptive from bug 416683" [p=jmathies@mozilla.com (Jim Mathies) r=sdwilsh ui-r+a1.9=beltzner]
2008-04-04 00:08:24 -07:00
sdwilsh@shawnwilsher.com
f6ab64ca11
Bug 397935 - Download Manager ("Downloads") window doesn't stay open when clicking on download-complete alert notification with auto-close pref ("close when done"). r=Mardak, sr=mconnor
2008-04-02 20:05:22 -07:00
dolske@mozilla.com
1b346b4adc
Bug 299372 - Content-Disposition headers no longer looked at for Save Link As filename. original-patch=dmose, r=mconnor, r=biesi, a=blocking-ff3+
2008-04-02 20:02:08 -07:00
edward.lee@engineering.uiuc.edu
403a848b2a
Land testcase for bug 397935. r=sdwilsh
2008-03-27 11:22:06 -07:00
dbaron@dbaron.org
0ba7646d32
Make the download manager tests remove their temporary files, and rename the prefix they use to work around the Mac unit test machine having filled up all of dmuitest.file through dmuitest-9999.file in its temp dir. rs=sdwilsh a=tests+orange
2008-03-21 20:57:47 -07:00
edward.lee@engineering.uiuc.edu
4e8a61dfba
More bustage fix for bug 416683. r=sdwilsh
2008-03-21 19:03:01 -07:00
edward.lee@engineering.uiuc.edu
421fa9ed67
Bustage fix for bug 416683
2008-03-21 18:55:51 -07:00
edward.lee@engineering.uiuc.edu
06f1bb8e8f
Bug 416683 - binary downloads are deleted on completion when "Launch applications and unsafe files" is disabled. p=jmathies, r=Mardak, r=robarnold, sr=bsmedberg, a1.9b5=beltzner, b-ff3=beltzner
2008-03-21 17:23:45 -07:00
reed@reedloden.com
5c36caeb58
Bug 411214 - "New MIME type set with "Do this automatically ..." fails to locate helper app" [p=jmathies@mozilla.com (Jim Mathies) r=sdwilsh a1.9=beltzner]
2008-03-19 23:09:02 -07:00
edward.lee@engineering.uiuc.edu
248ae6dccf
Bug 420482 - Big discrepancy in ETA between Downloads Manager & Downloads status bar panel. r=sdwilsh, b-ff3=beltzner
2008-03-18 11:01:39 -07:00
edward.lee@engineering.uiuc.edu
2f260f9c63
Bug 414850 - "Clear List" in download manager should only remove visible downloads. r=sdwilsh, a1.9=beltzner
2008-03-18 10:59:27 -07:00
edward.lee@engineering.uiuc.edu
d60abf1895
Bug 403412 - Download Manager window title fails to clear/update upon download completion. r=sdwilsh, a1.9=beltzner
2008-03-18 10:57:26 -07:00
dolske@mozilla.com
aab42d0740
Backing out bug 420595 due to causing bug 422585. r=sdwilsh.
2008-03-13 15:58:15 -07:00
mattwillis@gmail.com
2ac0c39bd4
Bug 422161 - Fix JS strict errors in *.jsm modules. r and rs=gavin, a1.9+=damons
2008-03-12 14:56:59 -07:00
edward.lee@engineering.uiuc.edu
5cc36da189
Bug 413093 - With "Remember what I've download" disabled/unchecked (browser.download.manager.retention set to 0), the Download Manager window remains open until clicked/focused. p=sdwilsh, r=Mardak, b-ff3=beltzner
2008-03-11 14:34:19 -07:00
reed@reedloden.com
6aac76c268
Bug 420595 - ""you have chosen to open" dialog uses wrong icon" (Change the accept button icon to a save one when the only choice is "save") [p=frnchfrgg-mozbugs@altern.org (RIVAUD Julien [_FrnchFrgg_]) r=sdwilsh a1.9=damons]
2008-03-11 01:11:08 -07:00
edward.lee@engineering.uiuc.edu
27004fc15c
Bug 412360 - Download Manager remains empty, downloads don't start, with this 3.0b2 downloads.sqlite. r=sdwilsh, r=biesi, sr=biesi, b-ff3=beltzner
2008-03-08 17:02:06 -08:00
reed@reedloden.com
2a6fde4795
Back out not completely reviewed changes from bug 326228.
2008-03-08 02:06:10 -08:00
reed@reedloden.com
d6296c455b
Bug 326228 - "No error message when download manager tried to store file in folder with insufficent access rights" [p=steveisok1@yahoo.com (Steve) ui-r=madhava r=sdwilsh a1.9=beltzner a=blocking-firefox3+]
2008-03-08 02:04:05 -08:00
edward.lee@engineering.uiuc.edu
de4eadb545
Disable bug 419403 test on windows. r=sdwilsh
2008-02-26 11:19:39 -08:00
edward.lee@engineering.uiuc.edu
15c83f4737
Bustage fix for bug 419403 - do more timeouts
2008-02-26 10:42:47 -08:00
edward.lee@engineering.uiuc.edu
7b954899d4
Bug 419403 - Pimp My Download Manager Search! (multi word, match any text). r=sdwilsh, a1.9=beltzner
2008-02-26 09:52:17 -08:00
edward.lee@engineering.uiuc.edu
f99e988e7b
Bug 406857 - Don't clear referrer when restarting downloads. r=sdwilsh, a1.9=beltzner
2008-02-22 00:35:59 -08:00
edward.lee@engineering.uiuc.edu
1bbeb5f5de
Backing out bug 406857 to wait for red to go away.
2008-02-21 22:05:18 -08:00
edward.lee@engineering.uiuc.edu
57197d31b5
Bug 406857 - Don't clear referrer when restarting downloads. r=sdwilsh, a1.9=beltzner
2008-02-21 21:32:17 -08:00
roc+@cs.cmu.edu
24381328f1
Backing out fix for bug 406857 due to win2k3 test failure
2008-02-21 18:04:14 -08:00
edward.lee@engineering.uiuc.edu
1e7d063a59
Bug 406857 - Don't clear referrer when restarting downloads. r=sdwilsh, a1.9=beltzner
2008-02-21 16:17:19 -08:00
edward.lee@engineering.uiuc.edu
adb4a9fc8f
Bug 416303 - Show default list, clear search, focus list when hitting escape from the search box. r=sdwilsh, a1.9=beltzner
2008-02-21 12:49:56 -08:00
dbaron@dbaron.org
cd8717f447
Call cancel() if we can't show the helper app dialog, so we break cycles, avoid leaks, and don't continue doing the download. b=417949 sr=bzbarsky r=gavin.sharp a=schrep
2008-02-20 08:30:21 -08:00