Commit Graph

47 Commits

Author SHA1 Message Date
Alfred Kayser
a06970896c Bug 513738 - [r=JOEDREW!] 2009-09-04 20:47:11 -05:00
Joe Drew
df1ed238ec Bug 511689 - Ensure we're always on the correct frame when decoding GIF images. r=jrmuizel,alfredkeyser sr=vlad 2009-09-02 11:50:14 -04:00
Benjamin Smedberg
2e9438fd2f Followup to bug 398573 - remove REQUIRES from the tree since it is no longer used... automatically generated patch, rs=ted 2009-08-25 08:59:31 -07:00
Joe Drew
ec0ef86e27 Bug 505474 - Restore tracking of whether we've finished decoding a given GIF frame, so we don't call EndImageFrame() twice for a single frame. r=vlad
Before bug 753 landed, we implicitly tracked whether we'd called
EndImageFrame() by setting mImageFrame to null inside EndImageFrame(). Once
we stopped doing that, we tried writing to memory that had already been freed.

(This memory is actually freed once we error out on the invalid GIF, but the
internal state-tracking mechanics made it so we never wrote to that memory
even though we have stale pointers to it. Unfortunately when we entered
EndImageFrame() a second time, that state tracking was invalid and we
attempted to write to the stale pointer.)

This patch introduces a tracking variable, mCurrentFrame, which is set to the
frame of the currently-decoding frame when we're in the middle of decoding
it, and -1 otherwise. This ensures we don't enter EndImageFrame() a second
time, restoring the functionality we had prior to bug 753.
2009-07-21 21:20:01 -07:00
Joe Drew
6c441f55f7 Bug 753 - Remove nsIImage, gfxIImageFrame, and their implementations, and expose an equivalent api on imgIContainer. r=roc,josh,bz,longsonr,vlad,karlt,jimm,bsmedberg,mfinkle,peterw,peterv sr=vlad,roc
--HG--
rename : gfx/src/shared/gfxImageFrame.cpp => modules/libpr0n/src/imgFrame.cpp
rename : gfx/src/shared/gfxImageFrame.h => modules/libpr0n/src/imgFrame.h
2009-07-20 18:50:15 -07:00
Joe Drew
8d0a42255e Bug 472590 - Always call OnStopFrame() from the GIF decoder, even if we didn't decode any rows (due to an invalid GIF). r=vlad 2009-05-14 21:56:54 -04:00
Alfred Kayser
5fa1beb6bc Bug 488685. GIF decoder should pass correct frame width. r=vlad,sr=joe
--HG--
extra : rebase_source : 1effad65df83ee2e2e50882f702c159a88fe909b
2009-05-13 22:20:36 +12:00
Jeff Muizelaar
9980cb2188 Bug 481926 - Rewrite color management component sr=vlad, r=ted, r=joedrew (\o/)
Replaces lcms with qcms
2009-04-07 12:02:11 -04:00
Alfred Kayser
c8e30768ab Bug 418871 - Remove unused parts from imgIContainer.idl. r=joe, sr=vlad 2009-04-05 16:52:18 +02:00
Joe Drew
fc5c15825a Backed out changeset 6f3c2171bbb2:
Bug 481926 - Rewrite color management component. r=joe,ted sr=vlad
2009-04-03 16:27:27 -04:00
Jeff Muizelaar
eaef2088cb Bug 481926 - Rewrite color management component. r=joe,ted sr=vlad 2009-04-03 15:09:56 -04:00
Doug Turner
a49e520740 Bug 453836 - handle OOM while images decoding. r=jim 2008-09-10 13:23:29 -07:00
Marco Bonardo
fed5a1056a Bug 442731 - GIF favicons are not resampled in places.sqlite (large icons are stored), r=dietrich, pavlov 2008-09-02 13:59:59 +02:00
Bobby Holley
3b34cb4ebc Bug 449681 – switch color_management pref from off/on bool to off/on/taggedonly int. r=vlad 2008-08-11 21:55:36 -07:00
reed@reedloden.com
67056548e6 Back out Alfred Kayser and Joe Drew's patch from bug 399925 in order to find out if it caused the 7% Tp regression (bug 425941). 2008-03-30 00:17:08 -07:00
reed@reedloden.com
e24e952a2b Bug 399925 - "GIF decoder needs to allow its data to be discarded" [p=alfredkayser@gmail.com (Alfred Kayser) / joe@drew.ca (Joe Drew [JOEDREW!]) r=stuart sr=tor a=blocking1.9+] 2008-03-28 01:36:27 -07:00
reed@reedloden.com
223ffcf984 Back out Alfred Kayser's patch from bug 399925 due to Tp crashes. 2008-03-09 23:09:37 -07:00
reed@reedloden.com
fd30224781 Bug 399925 - "GIF decoder needs to allow its data to be discarded" [p=alfredkayser@gmail.com (Alfred Kayser) r=stuart sr=tor a=blocking1.9+] 2008-03-09 22:09:24 -07:00
jag@tty.nl
2fbcb59ed7 Bug 416998: Fix the order of member variable initializers for a few constructors. sr=bz, a=schrep 2008-02-18 23:36:50 -08:00
jag@tty.nl
057bc17743 Bug 73353: Clean up our MODULE/REQUIRES story. rs=dbaron, a=brendan 2008-02-18 00:50:04 -08:00
mats.palmgren@bredband.net
9d4e123ff6 Don't decrement the loop variable when it's zero. b=414854 r+sr=jag approval1.9b3=beltzner 2008-01-30 17:04:36 -08:00
jag@tty.nl
7bbff4292c Bug 413143: trunk is broken(sigbus) on SPARC since 20071221. r/sr=pavlov, a=beltzner Unaligned 32-bit memory reads cause a sigbus on SPARC. Turns out that fixing this also gets us a little performance boost on other platforms because we're now mostly doing aligned 32-bit reads. 2008-01-29 22:22:23 -08:00
reed@reedloden.com
9d5e82db62 Bug 413931 - "Crash [@nsGIFDecoder2::DoLzw] when loading GIF file, part 2" [p=alfredkayser@gmail.com (Alfred Kayser) r=stuart sr=tor a1.9=beltzner a=blocking1.9+] 2008-01-26 20:45:56 -08:00
reed@reedloden.com
ea5d5976bc Back out akayser's patch from bug 399925 due to Tp crash. 2008-01-24 09:30:17 -08:00
reed@reedloden.com
a1e2ae5e2c Bug 399925 - "GIF decoder needs to allow its data to be discarded" [p=alfredkayser@gmail.com (Alfred Kayser) r=stuart sr=tor a=blocking1.9+] 2008-01-24 08:51:30 -08:00
reed@reedloden.com
b980913cfe Bug 413373 - "Crash [@nsGIFDecoder2::DoLzw] when loading GIF file" (detect malformed LZW encoding [p=alfredkayser@gmail.com (Alfred Kayser) r=stuart sr=tor a1.9=beltzner] 2008-01-24 01:29:38 -08:00
reed@reedloden.com
a2bce09846 Bug 411874 - "Crash [@ ffff068b nsGIFDecoder2::EndImageFrame] while loading MySpace page (hard to repro)" [p=alfredkayser@gmail.com (Alfred Kayser) r=stuart a1.9=schrep] 2008-01-18 23:00:24 -08:00
reed@reedloden.com
56c4d2753e Bug 409878 - "Garbage displayed for part of bluebar.gif animation" [p=alfredkayser@nl.ibm.com (Alfred Kayser) r+a1.9=stuart] 2008-01-08 01:51:13 -08:00
reed@reedloden.com
100f2a76b4 Bug 406580 - "Faster copying of RGB pixel data" (Where Alpha=0xFF, keep RGB values contiguous in pixel copying) [p=swsnyder@insightbb.com (Steve Snyder) r+a1.9=stuart] 2007-12-21 02:26:31 -08:00
reed@reedloden.com
0bd3fbe93c Bug 408310 - "20071213 trunk crash when visiting protopage.com @ all platforms" (Make sure to use the right paletteSize to prevent crashes) [p=alfredkayser@nl.ibm.com (Alfred Kayser) r=stuart sr=tor a=blocking1.9+] 2007-12-20 01:38:53 -08:00
martijn.martijn@gmail.com
ed2ac513cb Bug 403578 - glibc detected firefox-bin: malloc(): memory corruption, patch by Alfred Kayser, r=pavlov, sr=tor, a=blocking1.9 2007-12-12 08:56:39 -08:00
reed@reedloden.com
96f5ba58d1 Bug 364221 - "[cairo] bad page scrolling performance with large background images" [p=alfredkayser@nl.ibm.com (Alfred Kayser) / vladimir@pobox.com (Vladimir Vukicevic [vlad]) r=stuart sr=tor a=blocking1.9+] 2007-11-27 01:35:18 -08:00
pavlov@pavlov.net
1f88978ad9 bug 143046. Keep GIFs at original 8bit. patch from Alfred Kayser <alfredkayser@nl.ibm.com>. r=me sr=tor 2007-11-07 13:33:57 -08:00
jdaggett@mozilla.com
9061c61d0a Bug 328258. Prevent images larger than 32K pixels in height from loading to workaround Quartz bug. r=pavlov,vlad, a=beltzner 2007-10-23 23:01:16 -07:00
reed@reedloden.com
9fc9d59934 Bug 398369 - "Break friendship between imgContainer and nsGIFDecoder2" [p=alfredkayser@nl.ibm.com (Alfred Kayser) r+sr+a1.9=stuart] 2007-10-03 20:07:38 -07:00
reed@reedloden.com
21e7e02314 Bug 394403 - "Crash Viewing Image [ @ nsGIFDecoder2::DoLzw]" (don't write image pixels outside of image) [p=alfredkayser@nl.ibm.com (Alfred Kayser) r=pavlov sr=tor a1.9=dsicore] 2007-09-10 12:09:59 -07:00
philringnalda@gmail.com
9a5f4e3ae2 Bug 366465 - GIF Decoding in Cairo can skip all row buffers, patch by Alfred Kayser <alfredkayser@nl.ibm.com>, r=pavlov, sr=tor, a1.9=pavlov 2007-08-25 22:08:53 -07:00
vladimir@pobox.com
10ea784eab b=391583, DoesARGBImageDataHaveAlpha is slow, r=stuart,a=me 2007-08-17 12:54:58 -07:00
philringnalda@gmail.com
5b4cb5308a Bug 378881 - imgContainerGIF no longer used, patch by Alfred Kayser <alfredkayser@nl.ibm.com>, r=pavlov, sr=tor, a1.9=pavlov 2007-08-16 21:13:16 -07:00
bzbarsky@mit.edu
82ee29bb76 Remove animation hrottling that we don't want. Bug 386269, patch by tor and Alfred Kayser <alfredkayser@nl.ibm.com>, r=pavlov, sr=tor 2007-08-08 09:32:57 -07:00
flamingice@sourmilk.net
1b7bba6183 Bug 386268, Animated GIF doesn't loop properly, Patch by Alfred Kayser, r=pavlov, sr=tor, a=blocking1.9 2007-08-07 09:41:30 -07:00
pavlov@pavlov.net
d04ad3b03b adding color management capabilities -- preffed off. bug 16769. patch from tor. r=bsmedberg, sr=me 2007-07-23 15:02:17 -07:00
jwalden@mit.edu
e3c4baccae Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
tor@cs.brown.edu
13ee412ff4 Bug 196295 - move/merge GIF2.cpp into nsGIFDecoder2.
Patch by alfredkayser@nl.ibm.com,  r=biesi, sr=tor
2007-06-25 09:41:21 -07:00
tor@cs.brown.edu
1c3c025984 Bug 317748 - Merge BlackenFrame and SetMaskVisibility into ClearFrame.Patch by alfredkayser@nl.ibm.com, r=pavlov, sr=tor 2007-06-07 08:10:25 -07:00
crowder@fiverocks.com
5295d19da2 Bug 373794: crash with bad gif image, r=tor@acm.org, sr=pavlov@pavlov.net 2007-03-23 09:15:43 -07:00
hg@mozilla.com
465265d0d4 Free the (distributed) Lizard! Automatic merge from CVS: Module mozilla: tag HG_REPO_INITIAL_IMPORT at 22 Mar 2007 10:30 PDT, 2007-03-22 10:30:00 -07:00