Commit Graph

12559 Commits

Author SHA1 Message Date
David Anderson
8261fa8d52 Fix call mechanism and recompilation (bug 609222, r=dmandelin,adrake,m_kato). 2010-11-10 15:49:31 -08:00
Nicholas Nethercote
7a526fe5ab Update nanojit-import-rev stamp. 2010-11-10 15:01:02 -08:00
Nicholas Nethercote
9cf6db33a1 Bug 609121 - nanojit: handle small immediates specially in CseFilter. r=wmaddox.
--HG--
extra : convert_revision : 04d7771f3f85877cf12395ffecfc4f2f6d4a0b50
2010-11-10 14:40:07 -08:00
Nicholas Nethercote
8bcd915a2d Bug 610815 - TM: print more info for guards in LIR dumps. r=bz. 2010-11-10 14:23:37 -08:00
Blake Kaplan
df7a668a02 Bug 571849 - Fix enumerateOwn and the Iterate constructor on Xray wrappers. r=gal 2010-11-10 14:08:44 -08:00
Blake Kaplan
57a2e504c5 Bug 605760 - Deal with null a subject principal here. r=jst 2010-11-10 14:08:11 -08:00
Jim Blandy
15430ee67a Bug 553778: Don't orphan placeholder definition nodes when a real definition is found. r=brendan
When we incorporate an inner function's lexdeps into our own lexdeps and
decls tables, always create a fresh definition node for an identifier we
don't have an entry for yet, and turn the inner definition node into a use
of that definition, to ensure that references to those definitions from
TOK_UPVARS nodes properly resolve to the outer definitions that capture
them.

This patch also changes MakePlaceholder to initialize the new node's type
and op. Normally, JSParseNode::create initializes them from the current
token, but that creates a fragile dependency of placeholder construction on
lexing state, and is not actually what two out of (now) three call sites
want.
2010-11-10 13:18:15 -08:00
Luke Wagner
6d8362bfc5 Bug 592992 - hoist outerizing from js::Invoke to js::ExternalInvoke (r=mrbkap) 2010-11-10 11:43:22 -08:00
Luke Wagner
fe37ac898b Bug 610848 - merge js::Int32ToString and js_IntToString (r=waldo) 2010-11-10 11:43:22 -08:00
Luke Wagner
7f39d48096 Bug 605013 - obj_keys should be cool with object ids (r=waldo) 2010-11-10 11:43:22 -08:00
Luke Wagner
94f3b9a8d2 Bug 610901 - need to explicitly construct/destruct JITScript (r=dvander) 2010-11-10 11:43:22 -08:00
Ginn Chen
e033f58482 Bug 605428 Implement NJ_EXPANDED_LOADSTORE for SPARC r=wmaddox
--HG--
extra : convert_revision : e3715e4e883cc90ab92d02e688ee22d9c365ffb5
2010-11-05 16:25:14 +08:00
Rick Reitmaier
fab45d40d1 Bug 601724 - nanojit: Reduce indirect call overhead caused by CodeAlloc.alloc (r+wmaddox,nnethercote)
Part I re-work addMem() with no functional changes.

--HG--
extra : convert_revision : 480ca3961ba156b7654f1cf361963e9532717684
2010-11-04 15:41:24 -07:00
Rick Reitmaier
146df9729a Remove dead code introduced with nop insertion checkin
--HG--
extra : convert_revision : 41e11d89f9d92656e1924ab600651dcd381b8655
2010-11-04 12:39:12 -07:00
Jan de Mooij
59027dc8e7 Bug 604864 - Optimize undefined, NaN and Infinity in methodjit. r=dmandelin 2010-11-01 21:47:45 +01:00
Johnny Stenback
17607078e7 Fixing bug 585787. Compare compartments instead of global objects in quickstubs when deteremining whether we need to wrap the return value or not. r=mrbkap@gmail.com, a=bzbarsky 2010-10-22 09:32:09 -07:00
Gavin Sharp
f9289aaa14 Backed out changeset 759b21bbb64b (bug 610223) due to Windows build bustage, a=red 2010-11-15 23:15:02 -05:00
Gavin Sharp
b3af616f19 Backed out changeset 031e9ea92ed1 (bug 605754) due to Windows build bustage, a=red 2010-11-15 23:13:20 -05:00
Chris Leary
ed9f0e208b Bug 605754 - regexp topcrash diagnostics. r=dmandelin, a=dmandelin 2010-11-15 19:40:26 -08:00
Chris Leary
0715f9cef8 Encapsulate RegExpStatics more. (r=gal, b=610223) 2010-11-10 17:02:08 -08:00
Ben Turner
d0066f07ca Bug 608170 - 'ChromeWorkers should have atob, btoa'. r=jst, a=blocking+ 2010-11-15 17:39:28 -08:00
Edwin Smith
7a56c25bf8 CodeAlloc comment updates
.
. attachment 483153 - Clarify block and chunk terminology and roles of CodeList and CodeAlloc
.

--HG--
extra : convert_revision : 3b0fb708c5c9e12f20897d6d7de8ff79ebc66d6d
2010-10-14 07:10:00 -07:00
Rick Reitmaier
b8b2a58c9f Bug 587727 - nanojit: Reduce paging traffic from calls to CodeAlloc.markExec (r+nnethercote,edwsmith)
Second patch in the series which is explained in
https://bugzilla.mozilla.org/show_bug.cgi?id=587727#c14

--HG--
extra : convert_revision : aac6fffb12645c20a91f8151fb74778de75e3da2
2010-11-03 18:09:05 -07:00
David Mandelin
e88a9ce469 Backout merge, a=backout beta8+ diagnostic 2010-11-15 13:16:41 -08:00
David Mandelin
24c3ce0a02 Backed out changeset 6eef4ea21123 -- it was a temporary diagnostic. 2010-11-15 13:15:59 -08:00
David Mandelin
375bd67b4c Backout merge, a=backout beta8+ diagnostic 2010-11-15 13:06:06 -08:00
David Mandelin
c0d16889c7 Backed out changeset 1ccf7b6e0eb7 -- it was a temporary diagnostic. 2010-11-15 13:02:37 -08:00
David Mandelin
c5ffe3dddd Bug 601457 diagnostic: check for setting zero ids into shapes, r=lw, a=beta8+ 2010-11-08 16:20:22 -08:00
David Mandelin
9894ece070 Bug 609063 diagnostic: check for concurrent slots realloc, r=dvander, a=beta8+ 2010-11-08 14:12:35 -08:00
Chris Leary
dbca7cdb52 Add return statement to fix build break, a=bustage 2010-11-12 19:20:10 -08:00
David Mandelin
8f658c24e0 Bug 605752: don't crash on OOM inside ExecutablePool, r=dvander, a=beta8+ 2010-11-12 18:17:21 -08:00
Vladimir Vukicevic
32ff3a0c50 b=604196; jsval return types in xpidl are broken (non-quickstubs); r=jorendorff, a=b 2010-11-12 12:01:50 -08:00
David Mandelin
f50fdd538d Bug 608868: check for non-native objects when binding in scope name ICs, r=dvander, a=beta8+ 2010-11-04 18:05:39 -07:00
Kyle Huey
99fecd3066 Backing out Bug 590181 since the GCC 4.5 upgrade failed on this CLOSED TREE 2010-11-11 12:36:01 -05:00
Steve Fink
80ba8d7cfd Bug 605330 - extend jscalls (bug 507012) tracking to cover JM and fix some mismatched calls, r=dvander, a=NPODB
--HG--
extra : rebase_source : 77f64a8ee2c88cbb00ac5671ba2532f71551f28b
2010-09-20 12:43:51 -07:00
Boris Zbarsky
e06eeb9206 Bug 610583. When guarding on no indexed properties on our proto chain, use a branch exit, and reduce the number of guards involved. r=brendan 2010-11-09 21:46:18 -05:00
Brendan Eich
fdf9d2fd7c Handle extended indexes around JSOP_*BLOCKCHAIN (610026, r=billm). 2010-11-05 15:03:39 -07:00
Daniel Holbert
44a3f3c372 Bug 610642: s/NULL/0/ to fix build warning "NULL used in arithmetic". r=dmandelin a=shaver
--HG--
extra : transplant_source : %92H%08%90%1D%CE%90%DDx%97%99/%F9%90%F3%CCX%BDnb
2010-11-09 11:50:24 -08:00
Brendan Eich
7ca60435b0 Lazy resolution of standard classes changes the shape of Object.prototype (610697, r=mrbkap).
--HG--
extra : rebase_source : 7d95f23e2dbf9b11a416f07ae51d409d95e130cb
2010-11-09 12:09:07 -08:00
Jim Blandy
f27d13f045 Bug 602139: Add js_UpdateWatchpointsForShape, to correctly update watchpoints after shape changes. r=jorendorff
Many of the watchpoint bugs have to do with wp->setter and wp->shape
getting out of sync. The new function js_UpdateWatchpointsForShape takes
care of bringing all relevant watchpoints fully up to date; it is called
from the places in jsscope.cpp where property changes take place, and is
also used by the watchpoint creation code. DropWatchPointAndUnlock becomes
simpler; js_FindWatchPoint, js_WrapWatchedSetter and js_watch_set_wrapper
become static to jsdbgapi.cpp.
2010-11-09 15:04:12 -08:00
Jim Blandy
f591cd6663 Bug 602139: Trivial cleanups to watchpoint implementation. r=jorendorff
Separated for ease of review.
2010-11-09 15:04:11 -08:00
Jim Blandy
4b9db975ae Bug 602139: Watchpoint tests. r=jorendorff
This includes:
- a test showing how adding and deleting watchpoints can lose a property's JSPropertyOp setter;
- tests for watchpoints on properties that change from setters to value properties and vice versa, or from one setter to another; and
- tests for watchpoints set on inherited setter properties.
2010-11-09 15:04:11 -08:00
David Mandelin
a7b546995a Bug 608868 part 2: verify that scope chain start is native before IC'ing, r=dvander, a=beta8+ 2010-11-09 12:28:11 -08:00
Brendan Eich
126b6b5647 Prebrand standard classes with standard methods (610698, r=jorendorff). 2010-11-09 11:40:56 -08:00
Robert Sayre
78fcef6d2d Merge mozilla-central to tracemonkey. 2010-11-09 15:29:44 -05:00
Chris Leary
8a45dd1cea Back out 8ae5fce0f19b. 2010-11-09 10:12:53 -08:00
Walter Meinl
48d1e8997b Bug 577011 - [OS/2] make _declspec unconditionally default symbol export r=daveryeo@telus.net a=benjamin
--HG--
extra : rebase_source : f73a926174bd7905f177b2e914492e42b90ac8c0
2010-11-09 11:13:03 +01:00
Chris Leary
0cc4fbc8f7 Bug 576837: Fix YARR character-class range parsing. (r=jwalden)
--HG--
extra : rebase_source : 95095586a0a15f774b304ad797e59322f9ec0c37
2010-11-08 18:08:32 -08:00
Luke Wagner
36b12087f9 Bug 610038 - apply should not ignore indexed properties on the prototype (r=waldo) 2010-11-09 09:06:57 -08:00
Jeff Walden
66a45d8a26 Back out 9e5cd5815d4d, our own tests turn it orange -- paging compartments people... r=#ffa500 2010-11-08 18:05:54 -08:00
Chris Jones
703c658a1c Bug 562424: Switch IPDL interfaces to infallible TArray. r=bent a=blocking 2010-11-08 20:49:00 -06:00
Brendan Eich
769e50b90a Bug 609617 - delete(eval(...)) calls indirect eval (r=jimb). 2010-11-04 16:06:08 -07:00
Jeff Walden
db9224e4da Bug 608855 - Make compartment checks fatal in release builds. r=gal 2010-11-01 16:54:21 -07:00
Jeff Walden
ca150eab9b Bug 609256 - With strict this, there's no longer any need to compute this when a syntactically direct eval doesn't resolve to the eval function. r=luke 2010-11-08 16:14:29 -08:00
Jeff Walden
b5ac7e26bd Bug 608959 - Don't call non-scripted getters with a proxy as its |this|, because that would require most non-scripted getters to unwrap and maybe do some prototype-chain walking. r=mrbkap 2010-11-04 15:53:50 -07:00
Jeff Walden
0132e2e110 Rename a JS test from *.diff to *.js. r=iamsosmrt
--HG--
rename : js/src/tests/ecma_5/misc/explicit-undefined-optional-argument.diff => js/src/tests/ecma_5/misc/explicit-undefined-optional-argument.js
2010-11-04 15:51:59 -07:00
Luke Wagner
c286afd4be Bug 609075 - speed up JSString::flatten a bit, part 2 (r=gal) 2010-11-08 14:35:30 -08:00
Luke Wagner
79e2deb8a5 Bug 609075 - speed up JSString::flatten a bit, part 1 (r=gal) 2010-11-08 14:35:29 -08:00
Luke Wagner
91e9e4d5be Bug 608120 - optimize js_ValueToString on int32s (r=waldo) 2010-11-08 14:35:27 -08:00
Luke Wagner
3e678c7088 Fix strict-aliasing warning from 18d56745c3e6
--HG--
extra : rebase_source : 446fc01cba89ea45825cd1dc10716a05b9ec9818
2010-11-08 14:35:06 -08:00
David Mandelin
885bc95c14 Bug 486653: fix minor warning for return value 2010-11-08 14:06:38 -08:00
David Mandelin
ca8b7a1bd4 Bug 608868: check for non-native objects when binding in scope name ICs, r=dvander, a=beta8+ 2010-11-04 18:05:39 -07:00
Boris Zbarsky
c5a2cf663d Backed out changeset 298e753a1726 (bug 610370) due to test orange. 2010-11-08 16:45:51 -05:00
Boris Zbarsky
4f8630a253 Bug 610370. Make sure to hash shapes in dictionary lists too, if they need it. r=brendan, a=shaver 2010-11-08 15:18:18 -05:00
Luke Wagner
a09b2e2c71 Bug 610306 - MarkStackRangeConservatively in jsgc.cpp marked wrong objects on big endian system (r=gal)
--HG--
extra : rebase_source : ed1dcf2c3627127f6160845350d827d4da9e46ca
2010-11-08 09:28:20 -08:00
Luke Wagner
c8b83168a6 Bug 543100 - Shrink Parser::statement stack frame size (r=waldo)
--HG--
extra : rebase_source : f0e11ae51ced168b5c575a2840077393a1179d00
2010-11-05 11:10:02 -07:00
Luke Wagner
a5861fe116 Bug 603045 - JM: don't optimize away JSFRAME_HAS_RVAL check in debug mode (r=bhackett)
--HG--
extra : rebase_source : 6c975694160595fa65e0acf174b9b7f6c5997d56
2010-11-08 09:28:12 -08:00
Leon Sha
2a012f6591 Bug 610309 - Increase DEFAULT_MAX_STACK_SIZE to make 'make check' happy on sparc. r=gal 2010-11-08 15:01:12 +08:00
Leon Sha
a1abec16cb Bug 610303 - Function fpclassify in v8-dtoa/platform.cc may return random value. r=gal 2010-11-08 14:56:48 +08:00
David Anderson
7b4e37ac1d Fix pinned registers being clobbered while syncing under heavy pressure (bug 609970, r=dmandelin). 2010-11-05 16:57:11 -07:00
David Anderson
bba4e2e364 IC for JSOP_CALLELEM, re-landed (bug 604031, r=dmandelin). 2010-10-29 10:28:31 -07:00
David Anderson
4cf7772e50 Back out bug 604031 for re-landing. 2010-11-02 10:56:17 -07:00
Igor Bukanov
92b67c9caf bug 607695 - Avoid unnecessary JS_GetStringBytes. r=gal 2010-10-28 17:15:53 +02:00
Nicholas Nethercote
3faf0ec6c7 merge 2010-11-04 16:55:13 -07:00
Nicholas Nethercote
5d6cb0bd45 Bug 605700 - TM: improve naming in LIR dumps. r=lw. 2010-11-04 16:51:25 -07:00
Nicholas Nethercote
c8ae37081d Bug 607242 - TM: inline js_Array_dense_setelem_hole. r=gal. 2010-11-03 20:48:51 -07:00
David Mandelin
63c79a2f69 Bug 606662: Don't methodjit scripts that have sharps, r=dvander 2010-11-03 18:38:41 -07:00
Robert Sayre
d1a33fd04c Merge. 2010-11-03 18:38:11 -07:00
David Anderson
8e00f02dd7 Fix recompilation under jsd and simplify frame searching (bug 609363, r=lw, a=b7+). 2010-11-03 18:34:20 -07:00
Blake Kaplan
a4b38abdeb Bug 609141 - Compartments mismatch in jsdScript::GetFunctionSource. r=sayrer 2010-11-03 18:04:22 -07:00
Chris Leary
5e66fb3ca8 Bug 608778: Rename JSString::MUTABLE to JSString::EXTENSIBLE. (r=jorendorff)
--HG--
extra : rebase_source : 411b842e9b23d3e856f32218f559348bd2f4cac3
2010-11-03 15:34:00 -07:00
Nicholas Nethercote
da155db4d8 Bug 609129 - TM: fix emitIf(), re-enable implicit guard optimization (TM-specific part). r=dvander. 2010-11-03 15:23:46 -07:00
Nicholas Nethercote
871fb12359 Update nanojit-import-rev stamp. 2010-11-03 15:07:11 -07:00
Nicholas Nethercote
d09fc9b6b7 Bug 609129 - TM: fix emitIf(), re-enable implicit guard optimization (NJ-specific part). r=dvander.
--HG--
extra : convert_revision : f348fd5b02118c7151d991f51d76abe69976952e
2010-11-03 15:04:51 -07:00
Werner Sharp (wsharp@adobe.com)
0be07ddc2a bug 601135. switch x86/x64 to use cvttsd2di. add documentation (+r nick)
--HG--
extra : convert_revision : 6e1ed02c675eafc3195d67439854ba1a7b4f7c13
2010-11-03 16:30:00 -04:00
Rick Reitmaier
9740d93c46 Fixup for lirasm Windows test failure
cygwin sed wasn't trimming the output in the same fashion
than osx's version of sed.  Removing the escape slash appears
to work.

--HG--
extra : convert_revision : cf0963c16a8c560566fdce0b7187db3a97a060a7
2010-11-02 20:48:44 -07:00
Rick Reitmaier
3e780fbc0a Poor winmo neglect killed the build
--HG--
extra : convert_revision : eb5465db2a02a3706d11f8fc1e35bb99cc7a1d04
2010-10-28 18:12:54 -07:00
Rick Reitmaier
a98e7f02ec Bug 602786 - lirasm: fix trivial Windows test failure (r=nnethercote)
--HG--
extra : convert_revision : fa319402f3bb2e661a6e906ea9d92b4f62a87b0e
2010-11-01 17:09:00 -07:00
Chris Leary
e5217dbc60 Fix build warning. 2010-11-03 12:15:22 -07:00
Chris Leary
9ff0cd58c9 Bug 596580: Fix mozJSSubScriptLoader's version finding. (r=brendan) 2010-11-03 12:09:24 -07:00
Paul Biggar
372664c735 Bug 582161 - Add test case. 2010-11-03 11:30:35 -07:00
Robert Sayre
28f659d794 Merge. 2010-11-02 18:53:40 -07:00
Robert Sayre
bb710d32b2 Bug 608763 - JSD breakpoint does not work. r=gal 2010-11-02 18:52:55 -07:00
Luke Wagner
eabe24988e Bug 593559 - JSFUN_CONSTRUCTOR should not use the same bit as JSPROP_READONLY (r=brendan)
--HG--
extra : rebase_source : af02c04c4ee2255aa938aef7b50b91587f061769
2010-11-02 17:40:46 -07:00
Luke Wagner
0a6acc2075 Bug 607243 - JS_New should report error on primitive return; JSProxyHandler::construct should not call JS_New (r=brendan)
--HG--
extra : rebase_source : e81f0f4fbfbfafe40a5827f01a1e6bb92103bb64
2010-11-02 17:39:05 -07:00
Luke Wagner
0499a94583 Bug 607659 - Avoid calling getters/setters from TraceRecorder::callNative (r=jorendorff)
--HG--
extra : rebase_source : f1cd30d6a50c12fc7884122aebeb69d9010b04d6
2010-11-02 17:36:26 -07:00
Nicholas Nethercote
335453513b Bug 607856 - long hang loading page (TM-specific part). r=dvander 2010-11-02 16:28:47 -07:00
Nicholas Nethercote
f5831e3fac Update nanojit-import-rev stamp. 2010-11-02 16:18:53 -07:00
Nicholas Nethercote
3bae3314c9 Bug 607856 - long hang loading page. r=dvander.
--HG--
extra : convert_revision : 18279f425cd8e3f63f7a13cd1b1b62cba57b7ecd
2010-11-02 16:16:40 -07:00
Edwin Smith
4fa79000db Bug 602387 - nanojit: make Register a non-numeric type on PPC (r=nnethercote+)
This patch removes REGINC(), and adds several operator overloads to
make working with Register values more convenient without introducing
implicit downcasts to int.

--HG--
extra : convert_revision : 7bec0eb6482c99dbf3051377d032d2698a7784f9
2010-11-02 15:43:39 -04:00
Rick Reitmaier
72e5feb3c9 Whitespace cleanup and comment out unused parameter
--HG--
extra : convert_revision : eb6ff4c45ba4edebad7f79fac7f13504f4140482
2010-11-01 16:20:22 -07:00
Rick Reitmaier
c348a161dc Bug 595034 - nanojit: harden via random no-op instruction insertion (r+nnethercote,wmaddox,edwsmith)
Insert no-op instructions when JIT'ing with the intention of making exploitable
patterns within the generated code less predicable.

--HG--
extra : convert_revision : d3116f2abd879b0b79a6cfb2f7817e36645cf915
2010-11-01 14:02:18 -07:00
David Mandelin
a41660d2e7 Bug 605274: properly detect OOMs in mjit vectors, r=dvander 2010-11-02 15:18:59 -07:00
Chris Leary
4d3fc89539 Bug 597811: Make mozJSComponentLoader use JSVERSION_LATEST. (r=sayrer) 2010-11-01 17:33:22 -07:00
Brendan Eich
2c853ae9ce Property enumeration order is altered after a method has been read (601399, r=jorendorff). 2010-10-26 19:12:40 -07:00
Nicholas Nethercote
f64646389e Bug 608313 - TM: AccSet assertion failure in typed arrays. r=dvander. 2010-11-01 17:25:30 -07:00
Andreas Gal
2e92e6a345 Switch compartments when walking stacks (bug 608800, r=mrbkap). 2010-11-01 16:18:01 -07:00
Blake Kaplan
c0e2873909 Bug 596031 - 'this' is wrong in getters and setters when a proxy object is on the prototype chain. r=brendan/jorendorff/gal
--HG--
extra : rebase_source : 609b96c4b461e33f0f79dc74f714edfa882d1da0
2010-10-29 10:42:35 -07:00
David Anderson
3c02390373 Fix Windows build. 2010-11-01 11:54:06 -07:00
David Anderson
8cbc4442fa Refactor SETELEM into an IC (bug 607293, r=dmandelin). 2010-11-01 11:14:58 -07:00
Bill McCloskey
49c7d74849 Bug 607196 - Remove bogus atom assertion in JSOP_DOUBLE (r=lw) 2010-10-31 10:38:06 -07:00
Johnny Stenback
7528c7b226 Remove new JS_ASSERT() that triggers during browser-chrome runs. Will investigate further. r=orange, a=orange 2010-10-30 22:51:35 -07:00
Andreas Gal
80039beea8 Merge from mozilla-central. 2010-10-30 21:57:42 -07:00
Robert Sayre
5ad2152acd Merge mozilla-central to tm. 2010-10-30 17:11:52 -04:00
Robert Sayre
aecb00a979 Follow-up fix for bug 595243. Don't try to place non-main thread scripts in debug mode, and don't attempt to set debug mode from a non-main thread. r=gal 2010-10-30 15:07:46 -04:00
Robert Sayre
03513401da Bug 595243 - Expose debugMode to JSD. Relanding test bustage fixed up. r=gal. 2010-10-30 12:13:02 -04:00
Andreas Gal
142e029c97 Follow-up for bug 608142: disallow sending between main and non-main thread only (r=orange). 2010-10-30 08:39:53 -07:00
Andreas Gal
a82c4be516 Merge. 2010-10-30 06:01:38 -07:00
Andreas Gal
682ce67f2d Re-land bug 608142. 2010-10-30 06:01:25 -07:00
Jeff Walden
737b66b063 Merge backout. 2010-10-29 22:39:44 -07:00
Jeff Walden
27484886a8 Backed out changeset 71728ff7002c, seems to have turned mochitest-plain-2 orange. 2010-10-29 22:39:19 -07:00
Jeff Walden
f48a8e6d43 Merge backout. 2010-10-29 22:36:37 -07:00
Jeff Walden
ff603e73f4 Backed out changeset 85feecf161fe (Career Limiting Move? <http://bonsai.mozilla.org/cvsquery.cgi?who=sspitzer%40netscape.com&whotype=regexp&date=explicit&mindate=2001-01-25+10%3A00&maxdate=2001-01-25+10%3A15>), seems to have turned mochitest-plain-4 orange. 2010-10-29 22:31:12 -07:00
Johnny Stenback
03e709926a Backed out changeset e7436725f170 due to crashes in mochitest and elsewhere. a=backout 2010-10-29 17:33:29 -07:00
Robert Sayre
19cc79ccf3 Bug 595243 - Expose debugMode to JSD. r=gal 2010-10-29 18:35:07 -04:00
Andreas Gal
4f2e656d40 Disallow sending JS functions to a different thread (608142, r=jst). 2010-10-29 15:03:44 -07:00
Paul Biggar
6e1d638c76 Merge backout. 2010-10-29 14:53:14 -07:00
Paul Biggar
01cf037eee Backed out changeset 66f4a212edeb (bug 605133). Configure broke shell and unclobbered-build with js-config problem. 2010-10-29 14:52:28 -07:00
Peter Van der Beken
18ce843491 Fix for bug 606705 (Browser crash when using many web workers [@ GCGraphBuilder::NoteXPCOMChild ] or beyond). r=jst, a=beta7+ 2010-10-29 14:43:02 -07:00
Peter Van der Beken
42793743d1 Fix for bug 606705 (Browser crash when using many web workers [@ GCGraphBuilder::NoteXPCOMChild ] or beyond). r=jst, a=beta7+ 2010-10-29 14:43:02 -07:00
Walter Meinl
e80289fa8a Bug 606834 - Fix int32/int32_t on OS/2 (r=daveryeo,wmccloskey) 2010-10-29 13:57:41 -07:00
Blake Kaplan
8b9d3ee3e5 Merge backout. 2010-10-29 12:55:36 -07:00
Blake Kaplan
8d23c3e1c4 Backed out changeset fcd3fcf8a35c. It broke deep wrapping. 2010-10-29 12:55:23 -07:00
Blake Kaplan
6317e3db02 Merge backout. 2010-10-29 10:48:19 -07:00
Blake Kaplan
ea9d8bbc17 Backed out changeset f76fd418024c. This was never meant to be checked in. 2010-10-29 10:48:09 -07:00
Blake Kaplan
7416dcca84 Bug 596031 - 'this' is wrong in getters and setters when a proxy object is on the prototype chain. r=brendan 2010-10-29 10:42:35 -07:00
Paul Biggar
5f3e99f798 Bug 605133 - Synchronize common areas of configure.in and js/src/configure.in. r=jimb 2010-10-28 12:23:00 -07:00
Robert Sayre
7d1a213607 Merge m-c to tm 2010-10-28 22:01:23 -04:00
Nicholas Nethercote
dfd14af5e6 Fix ARM bustage caused by bug 602703. 2010-10-28 18:58:58 -07:00
Nicholas Nethercote
505e8ac40a Bug 602703 - TM: create a layer over Nanojit's LIR creation API. r=lw. 2010-10-28 18:28:36 -07:00
Robert Sayre
05033a2e47 Merge m-c to tm 2010-10-28 21:26:36 -04:00
David Mandelin
d243e20633 Backout merge, a=backing out diagnostic for b7 blocker 2010-10-28 17:44:48 -07:00
David Mandelin
35fc61d36c Backed out changeset c133d3c084c0: now we want to measure if not doing sync stuff on background thread reduces crashes. 2010-10-28 17:44:24 -07:00
Luke Wagner
036c4f5377 Bug 606138 - Gatling gun should guard against clobbered callee/this (r=waldo) 2010-10-28 17:26:19 -07:00
Blake Kaplan
5df760df9e Bug 607799 - Make typeof wrapper(regexp) be function.
--HG--
extra : rebase_source : 36598f7a268721eb569215d0ccd6859c3cd88701
2010-10-27 18:02:28 -07:00
David Anderson
954c83cd7b IC for JSOP_CALLELEM (bug 604031, r=dmandelin). 2010-10-29 10:28:31 -07:00
Blake Kaplan
1802eb481e Bug 606585 - Make the compartment map use principals properly. r=peterv/bz
--HG--
extra : rebase_source : b4585beb4aa5f9f44cb02beb3f0f91212345f1f8
2010-10-26 23:57:31 -07:00
Nicholas Nethercote
03a06266f2 Update nanojit-import-rev stamp. 2010-10-28 15:44:27 -07:00
Nicholas Nethercote
e5312a6b54 Bug 607225 - nanojit: add MODRM() and SIB() to Nativei386.cpp, plus other clean-ups. r=rreitmai.
--HG--
extra : convert_revision : 5012f8eb917c654d4756025fd90f1f98a1f07626
2010-10-28 15:22:05 -07:00
Ginn Chen
6d2e0fc102 Bug 605427 Implement FpReg move on icc or fcc for asm_cmov() on SPARC r=wmaddox
--HG--
extra : convert_revision : ce344dfb7fcb8d6f8fea281074cac9c472cc9d0c
2010-10-29 05:51:39 +08:00
Ginn Chen
ee7eccd45b Bug 604334 add support for param number above 6 (many_params.in) for SPARC r=wmaddox
--HG--
extra : convert_revision : 5a600b5166ea320289291a5b8bf085d4e5dc8653
2010-10-29 05:49:05 +08:00
Ginn Chen
18b2762a54 Bug 603876 Add support for addjovi and subjovi on Sparc platform r=wmaddox
--HG--
extra : convert_revision : d372626d5b878cc31facbf9e58a5ab66e7af6a34
2010-10-29 05:46:22 +08:00
Werner Sharp (wsharp@adobe.com)
49253f7a60 bug 607630. SoftFloatFilter needs to support LIR_d2i (sr+ nnethercote)
--HG--
extra : convert_revision : f43789d6bdbd848b943f3aac937b545e0872beb9
2010-10-28 12:47:12 -04:00
Nicholas Nethercote
a61b8d48e4 Bug 607864 - TM: systematically annotate bytecode boundaries in LIR dumps. r=dmandelin. 2010-10-28 15:08:10 -07:00
Brian Hackett
c5760d4a28 Special case object lookup lambda in String.replace, bug 605317. r=jorendorff 2010-10-28 14:33:32 -07:00
David Anderson
ddabc8f166 Fix Windows orange. 2010-10-28 13:53:54 -07:00
David Anderson
41328585a9 Refactor and improve GETELEM IC (bug 602641, r=dmandelin). 2010-10-27 21:04:13 -07:00
Nicholas Nethercote
3a40c011d1 Update nanojit-import-rev stamp. 2010-10-27 21:45:20 -07:00
Nicholas Nethercote
bcf5f8be52 Bug 575850 - nanojit: generated better code for LIR_eqd on i386.
--HG--
extra : convert_revision : 8cb17c62aaa615416ac901106292b69f691c51cf
2010-10-27 21:03:29 -07:00
David Anderson
d4bbfae64f Backed out changeset 921334ab1ea5 2010-10-27 21:35:47 -07:00
David Anderson
a5d01b38c7 Refactor and improve GETELEM IC (bug 602641, r=dmandelin). 2010-10-27 21:04:13 -07:00
Nicholas Nethercote
929c78da00 Bug 607555 - TM: fix interleaving of bytecode and LIR with TMFLAGS=recorder (TM-specific part). r=dmandelin. 2010-10-27 16:45:16 -07:00
Nicholas Nethercote
2dec3365d1 merge 2010-10-27 16:31:40 -07:00
Chris Leary
8692140272 Bug 607724: Minor scope chain function cleanup. (r=mrbkap) 2010-10-27 16:18:16 -07:00
Nicholas Nethercote
fb95a07348 Update nanojit-import-rev stamp. 2010-10-27 16:14:55 -07:00
Nicholas Nethercote
d224dbf553 Bug 607555 - TM: fix interleaving of bytecode and LIR with TMFLAGS=recorder. r=edwsmith.
--HG--
extra : convert_revision : 53c69eca7d94694ff55d59d39c0d8a26f8d8c111
2010-10-27 15:49:04 -07:00
Chris Leary
f501d81983 Fix bad mochitest for bug 601299. (rs=Waldo) 2010-10-27 14:21:09 -07:00
Chris Leary
cee380ffc0 Bug 601299: Find RegExpStatics in cx->globalObject if necessary. (r=mrbkap) 2010-10-27 12:33:55 -07:00
Leon Sha
705886a03f Bug 607553 - [JAEGER] Multiple cases failed in MONOIC only build. r=dvander 2010-10-27 14:09:47 +08:00
Andreas Gal
5517b072ad Bug 606875 - Object.prototype.toString no longer works for arrays created in sandboxes or windows from a different principal. r=mrbkap, a=blocker 2010-10-27 17:30:59 -07:00
Doug Turner
69d9465cd2 Backed out changeset dd50da0646a4 2010-10-27 13:36:15 -07:00
Siarhei Siamashka
12a18918a8 Bug 601914 - XPCOM does not work with ARM hardfp ABI. r=Jacob.Bramley a=blocking-fennec
--HG--
extra : rebase_source : a9d44cf330e338abf041c6755dbdeba54cfd9b6e
2010-10-27 08:15:08 +03:00
Nicholas Nethercote
4e8f68915a Bug 606441 - TM: specialize Math.abs() for integers when possible. r=dvander. 2010-10-26 20:21:39 -07:00
Blake Kaplan
4cc16a6dd2 Bug 607174 - Add assertions to jsdbgapi.cpp and enter compartments where it isn't possible for the caller to do so. landing with r=gal, a=beta7+ 2010-10-26 19:48:51 -07:00
Blake Kaplan
0947251bf8 Bug 606585 - Make the compartment map use principals properly. r=peterv/bz, a=beta7+ 2010-10-26 23:57:31 -07:00
Blake Kaplan
f4cc477379 Bug 607174 - Add assertions to jsdbgapi.cpp and enter compartments where it isn't possible for the caller to do so. landing with r=gal
--HG--
extra : rebase_source : f0e69380a0ef144e07af7d75b859712fe67bb753
2010-10-26 19:48:51 -07:00
Blake Kaplan
745db0123d Bug 601829 - Protect ourselves against a null sandbox. r=jst
--HG--
extra : rebase_source : 0fc1079f16ac97f2b27c2038f7ee6cfa17652a84
2010-10-26 19:48:41 -07:00
David Mandelin
63fab7fb8e Bug 604756 diagnostic: serialize flatten to test if concurrent calls cause the bug, r=dvander, a=beta 7 blocker 2010-10-26 19:02:01 -07:00
Brendan Eich
be1b695d0f Skip evalcx-based test in browser. 2010-10-26 18:44:53 -07:00
David Mandelin
61c89f1888 Backout merge, a=backing out changeset tried for b7 blocker 2010-10-26 18:20:20 -07:00
David Mandelin
5aa436fc27 Backed out changeset 8dd996c91f40 -- it doesn't fix the problem, but does make it harder to analyze. 2010-10-26 18:14:25 -07:00
Brendan Eich
8bda248822 Fix expression and value-generator decompilation to accept prolog ops, required due to ES5 metaprogramming APIs (607513, r=Waldo). 2010-10-26 17:22:55 -07:00
Nicholas Nethercote
1b80093032 Bug 607244 - nanojit: add LIR_comment (TM-specific part). r=dmandelin. 2010-10-26 16:58:08 -07:00
Nicholas Nethercote
d4b11eee91 Update nanojit-import-rev stamp. 2010-10-26 16:57:08 -07:00
Nicholas Nethercote
1c2d701a4f Bug 607244 - nanojit: add LIR_comment. r=edwsmith.
--HG--
extra : convert_revision : 50bb48a9d8ce1c6bca6163d73abcddea8f6c5afc
2010-10-26 16:45:19 -07:00
Rick Reitmaier
11a11094eb Bug 602386 - nanojit: fix winmo build breakage (r+Jacob.Bramley)
winmo is puking on R0,D7 usage in First/LastRegNum.

--HG--
extra : convert_revision : ec207b83f9d831024e8942e4c46a2a31e6803522
2010-10-26 11:41:05 -07:00
Werner Sharp (wsharp@adobe.com)
350ec14772 bug 570476. Support integer division on x86/x64. (r=wmaddox)
--HG--
extra : convert_revision : 064dc57a57630e1bc2ab256308cb373e3049fb0c
2010-10-26 09:09:00 -04:00
David Mandelin
a4768a8a4b Bug 604756 first try: restrict ropes optimization to main-thread content JS, r=lw, a=b7-blocker 2010-10-25 17:28:18 -07:00
Tero Koskinen
3e1a9e035e Add support for ARM's 'hard' EABI variant. (FP arguments go in VFP registers.) [Bug 602834] [r=jbramley,rreitmai]
--HG--
extra : convert_revision : 113a2e56c62fca5adc557906dd729a4ec632d994
2010-10-25 09:51:59 +01:00
Luke Wagner
d71e4fe2da Bug 605186 - js_NewStringFromCharBuffer should create short strings if it can (r=waldo) 2010-10-26 16:20:21 -07:00
Andreas Gal
4c759a0b88 Remove bogus assert, follow-up for bug 604523. a=blocking beta 7
--HG--
extra : rebase_source : 66290385e5f6af23c970c33897c4755952b4bcce
2010-10-22 17:21:18 -07:00
Andreas Gal
a752defcd2 Remove obsolete wrappedObject extended class hook (604523, r=mrbkap/vlad/dvander).
--HG--
extra : rebase_source : fcb81dcb8d9d5bb3b03f10dd5209019db22f6944
2010-10-22 15:40:11 -07:00
Blake Kaplan
00ac287852 Bug 604430 - Make the wantXrays flag apply to values obtained off of the sandbox object itself. r=peterv
--HG--
extra : rebase_source : c7a193f44e76f5851f7228c1ceba803f486595bd
2010-10-25 16:29:13 -07:00
David Mandelin
c6e138bf30 Backout merge, a=backout of existing changeset 2010-10-25 15:53:20 -07:00
David Mandelin
1557ecc6da Backed out changeset dafb1d54cf74 -- it was a temporary diagnostic and we got the data. 2010-10-25 15:51:41 -07:00
Jacob Bramley
038c5c805d Re-enable MICs on ARM and fix a couple of glitches. r=cdleary a=blocking-fennec 2010-10-25 14:44:17 -07:00
David Mandelin
738271936a Bug 604756 diagnostic: get blackbox information about JSString::flatten crash, r=lw, a=damons 2010-10-22 16:04:19 -07:00
Jeff Walden
630aabe371 Bug 604504 - Implement an eval kernel that obj_eval and JSOP_EVAL can each call. r=jorendorff,dvander 2010-10-21 14:31:29 -07:00
David Mandelin
d6fffb8112 Fix MSVC warnings. 2010-10-29 16:37:43 -07:00
David Mandelin
1f754fcd0f Bug 604798: move JM global data to compartment, r=dvander 2010-10-29 15:37:13 -07:00
David Mandelin
747cf33686 Backed out changeset ecd2f8753d5a: argh, fixes didn't land for some reason 2010-10-29 16:22:44 -07:00
David Mandelin
7779114001 Bug 604798: move JM global data to compartment, r=dvander 2010-10-29 15:37:13 -07:00
David Mandelin
867a8a9f10 Backed out changeset 394e0bd325b1: tinderbox bustage 2010-10-29 16:08:47 -07:00
David Mandelin
1932408866 Bug 604798: move JM global data to compartment, r=dvander
--HG--
extra : rebase_source : 459bbec8a3f8ab3739806da7336a0a10cee9bcd1
2010-10-29 15:37:13 -07:00
Robert Sayre
8d2832a579 Merge. 2010-10-29 18:36:24 -04:00
David Mandelin
f0c657cf0a Bug 605274 part 1: add OOM checks to JM use of vectors, r=dvander 2010-10-29 15:06:07 -07:00
Luke Wagner ext:(%2C%20Jan%20de%20Mooij%20%3Cjandemooij%40gmail.com%3E)
43464cfd48 Bug 595884 - JM: make f.apply(x, arguments) fast (r=dvander)
--HG--
extra : rebase_source : 81f5bd888164aecab2f3e701fb31ccf81affbc21
2010-10-21 11:42:28 -07:00
Luke Wagner
f57c947fc9 Bug 605192 - JM: make f.apply(x, obj) fast, part 4 (r=dvander)
--HG--
extra : rebase_source : 2dec4f92e1306ef1594262607ffca908b9ed1c64
2010-10-21 11:33:22 -07:00
Luke Wagner
db7bcbff85 Bug 605192 - JM: make f.apply(x, obj) fast, part 3 (r=sstangl)
--HG--
extra : rebase_source : 1341b9bc98d1ab74d8b8ba35243331d62a36fa34
2010-10-28 17:15:49 -07:00
Luke Wagner
6b39ea3337 Bug 605192 - JM: make f.apply(x, obj) fast, part 2 (r=dvander)
--HG--
extra : rebase_source : ed6ddf4e79424bfd22ad9daf79675ac0eef5b16a
2010-10-20 23:52:55 -07:00
Luke Wagner
977a639eeb Bug 605192 - JM: make f.apply(x, obj) fast, part 1 (r=waldo)
--HG--
extra : rebase_source : cceaabf5a68cae8bfa67320b4a47f0673ade86c6
2010-10-20 23:52:55 -07:00
Peter Van der Beken
23e34abd3d Fix for bug 607284 (getOwnPropertyDescriptor on a proxy misbehaves). r=mrbkap.
--HG--
extra : rebase_source : 87c28c7f37b36762c8257ca8f310107f37d69e49
2010-10-26 15:21:49 -07:00
Jeff Walden
d28e360c14 Bug 602441 - Remove unreachable property-cache-testing code, now that MT objects are history. r=brendan 2010-10-25 18:22:07 -07:00
Bill McCloskey
efc89ce679 Bug 563126 - Rename JS instruction tracing -> logging, and ensure it doesn't convert call objs (r=brendan) 2010-10-26 12:07:26 -07:00
Bill McCloskey
fa4b1f6ed8 Bug 606650 - Treat typeof() tests as constant in JIT profiler (r=dmandelin) 2010-10-26 12:03:16 -07:00
Brian Hackett
808bc99839 Analysis for defined variables, bug 604426. r=dvander 2010-10-26 12:00:54 -07:00
Robert Sayre
7ce5faeded Merge mozilla-central to tracemonkey. 2010-10-26 14:16:43 -04:00
Jacob Bramley
da5d6e26e4 Fix build warnings on ARM. [Bug 606949] [r=cdleary] 2010-10-26 15:29:04 +01:00
Jacob Bramley
34336dddb8 Use the correct BKPT encoding on ARM. [Bug 606955] [r=cdleary] 2010-10-26 15:28:30 +01:00
Bill McCloskey
902f25208d Fix jsop_equality_int_string() for known non-int types. b=606829, r=sstangl. 2010-10-26 02:25:18 -04:00
Chris Leary
be918c7ed5 Moved file from trace-test to jit-test.
--HG--
rename : js/src/trace-test/tests/basic/bug568276.js => js/src/jit-test/tests/basic/bug568276.js
2010-10-25 21:40:10 -07:00
Chris Leary
8748bbe3cd Bug 568276: Check for strange-variable-combination regression. (r=brendan) 2010-10-25 21:35:13 -07:00
Walter Meinl
2c58d91ead Bug 604778 - Don't export unnecessarily V8 headers to dist. r=gal. 2010-10-25 21:26:15 -07:00
Blake Kaplan
8789cb1eec Bug 604430 - Make the wantXrays flag apply to values obtained off of the sandbox object itself. r=peterv
--HG--
extra : rebase_source : 5c4c04829b8db95cc47954b11152ec328bbd7b98
2010-10-25 16:29:13 -07:00
Jeff Walden
ca6294d553 Bug 607148 - Remove unnamed namespaces from SpiderMonkey code. rs=luke 2010-10-25 16:47:11 -07:00
Blake Kaplan
c7f9cb0697 Bug 606106 - Avoid tripping an assertion under CC. r=gal
--HG--
extra : transplant_source : x%D1%3C%A8%8D%D2%F0%1E%9FL%E8%E9%21%C5%EA%0ET%2C%7B%E3
2010-10-25 12:12:43 -07:00
Blake Kaplan
babfa71137 Bug 606357 - Make jsd values not compartment mismatch. r=gal
--HG--
extra : transplant_source : %DD49k%A8%D8%92p%1EC%07NKU%9D%BFY8%A0U
2010-10-25 12:12:32 -07:00
Brendan Eich
54fd156cb3 PropertyTable::{init,change} should use js_calloc/js_free, and JSObject::addPropertyInternal should report OOM on change failure (606880, r=anygregor). 2010-10-24 19:24:53 -07:00
David Anderson
da981b1848 Compile JSOP_FORGLOBAL,ARG,PROP,NAME,ELEM (bug 597455, r=dmandelin). 2010-10-25 10:01:21 -07:00
Nicholas Nethercote
6331d0c5bf Update nanojit-import-rev stamp. 2010-10-24 20:47:40 -07:00
Nicholas Nethercote
10003a285a Fix typo that leads to assertion failure. No bug, r=me.
--HG--
extra : convert_revision : a52df753119f0b9c3b6b9a3e6b8efc664b164dec
2010-10-24 20:42:58 -07:00
Nicholas Nethercote
65902927de Update nanojit-import-rev stamp. 2010-10-24 20:31:49 -07:00
Nicholas Nethercote
9b191da1f1 Bug 606066 - nanojit: some i386 backend clean-ups. r=rreitmai.
--HG--
extra : convert_revision : 08f542f7fe1e16f1ec230af5d688527aa6feaece
2010-10-24 19:30:45 -07:00
Werner Sharp (wsharp@adobe.com)
d3bc7cd335 bug 409216. Add 8 byte alignment for MSVC. (r+ edwsmith, gal)
--HG--
extra : convert_revision : 15146f891b3a5cd9755b99f3b51b2acf8a692947
2010-10-22 13:20:41 -07:00
Ginn Chen
a71da8c8b5 Bug 603890 add big endian test cases r=nnethercote
--HG--
extra : convert_revision : a8165439796e6f0c6d377f7252fbacfe5c61db45
2010-10-22 19:22:13 +08:00
Ginn Chen
5e1533734b Bug 603890 add --endianness to lirasm, make tests endianness aware r=nnethercote
--HG--
extra : convert_revision : c7cd544f32aae57d3d359756db867bb33dd83e73
2010-10-22 16:53:42 +08:00
Andreas Gal
257334300b Backed out changeset 685accd622f0 (bug 606065). 2010-10-24 13:21:33 -07:00
Andreas Gal
61a710e895 Move deflated string cache into compartment (606065, r=jorendorff). 2010-10-24 02:07:42 -07:00
Andreas Gal
4d36561b99 Follow-up fix for 606573. 2010-10-24 00:52:38 -07:00
David Anderson
154d66a02a Refactor code related to ICs (bug 603779, r=dmandelin,sstangl).
* * *
Make Assembler derive from value-format assemblers (bug 603779 part 1, r=sstangl).
* * *
Refactor dense array load generation (bug 603779 part 2, r=dmandelin).
* * *
Add object class helpers to Assembler (bug 603779 part 3, r=dmandelin).
* * *
Refactor StateRemat and fix nearby IC bugs (bug 603779 part 4, r=dmandelin).
* * *
Refactor ValueRemat (bug 603779 part 5, r=dmandelin).
* * *
Factor out and rename some common IC structures (bug 603779 part 6, r=dmandelin).
2010-10-17 22:28:49 -07:00
Andreas Gal
4ef624448b Don't wrap StopIteration singleton, just translate it to the current global's StopIteration object and freeze StopIteration at birth (606573, r=mrbkap). 2010-10-23 16:24:32 -07:00
Brian Hackett
17384528d1 Reland followup warning fix for rev d20abbebe373. 2010-10-22 22:34:05 -07:00
David Anderson
a9d05951c1 Fix register allocation bug in return values (bug 604996, r=dmandelin). 2010-10-22 21:08:22 -07:00
Andreas Gal
de49671a75 Merge from mozilla-central. 2010-10-22 19:46:37 -07:00
Andreas Gal
9e84075376 Remove bogus assert, follow-up for bug 604523. 2010-10-22 17:21:18 -07:00
Jason Orendorff
bfaf004fd7 Merge. 2010-10-22 19:11:26 -05:00
Jason Orendorff
42d03e7276 Address review comments in bug 606029, mainly removing JSTitle from jslock.{h,cpp}. 2010-10-22 19:06:26 -05:00
Jason Orendorff
596862d852 Remove JSObject::title. Bug 606029, r=igor. 2010-10-22 19:04:22 -05:00
David Anderson
8d3e18ebbd Trace returning from JSOP_STOP with callDepth=0 (bug 606083, r=billm). 2010-10-22 16:27:28 -07:00
Andreas Gal
a4b0c37cda Remove obsolete wrappedObject extended class hook (604523, r=mrbkap/vlad/dvander). 2010-10-22 15:40:11 -07:00