Commit Graph

77 Commits

Author SHA1 Message Date
Kartikaya Gupta
9b28ae4a9f Bug 716673 - Encapsulate the velocity, locked, and disableSnap variables in Axis. r=pcwalton 2012-01-10 10:06:01 -05:00
Kartikaya Gupta
507223b40b Bug 716673 - Use the locked velocity instead of unlocked velocity in a couple of places. r=pcwalton 2012-01-10 10:05:59 -05:00
Kartikaya Gupta
f33ee7053e Bug 716673 - Fix up the advanceFling() step. r=pcwalton
- Refactor the code a little to ensure we don't do any flinging
  if the panning is being overridden.
- Collapse duplicated/inconsistent code in the fling-termination
  conditions so that it makes sense now.
2012-01-10 10:05:57 -05:00
Kartikaya Gupta
4ac7142036 Bug 716673 - Collapse unused WAITING_TO_SNAP and SNAPPING flingstates into STOPPED. r=pcwalton 2012-01-10 10:05:55 -05:00
Kartikaya Gupta
d7cab97e1a Bug 716673 - Completely encapsulate Axis variables lastTouchPos and touchPos. r=pcwalton 2012-01-10 10:05:53 -05:00
Kartikaya Gupta
98f37bcfd2 Bug 716673 - Completely encapsulate Axis variable firstTouchPos. r=pcwalton 2012-01-10 10:05:51 -05:00
Kartikaya Gupta
5eeb9e791f Bug 716673 - Refactor some more duplicated code from the track() functions. r=pcwalton 2012-01-10 10:05:49 -05:00
Kartikaya Gupta
c95e0eb66a Bug 716673 - Refactor some repeated code into a startTouch method. r=pcwalton 2012-01-10 10:05:48 -05:00
Kartikaya Gupta
88b3405314 Bug 716673 - Misc cleanups in PanZoomController. r=pcwalton
- Remove unused imports.
- Move all class variables together, and make some final.
- Fix up some comments.
- Remove unused methods.
- Remove some dead code
- Move some functions around so they are grouped based on behaviour.
2012-01-10 10:05:46 -05:00
Kartikaya Gupta
b796ad67a5 Bug 716673 - Remove some dead code. r=pcwalton
Events that come in for the non-primary pointer are ACTION_POINTER_DOWN
rather than ACTION_DOWN, so this code will never get exercised.
2012-01-10 10:05:43 -05:00
Kartikaya Gupta
0e66e28bb0 Bug 716673 - Refactor some code that sends messages to Gecko. r=pcwalton 2012-01-10 10:05:42 -05:00
Kartikaya Gupta
7e531bbeb4 Bug 716673 - Remove unnecessary finalize() function. r=pcwalton
The finalize will never be called because GeckoAppShell holds
on to the PZC (as a GeckoEventListener) thereby preventing it
from ever getting GC'd.
2012-01-10 10:05:40 -05:00
Chris Peterson
adf7970c58 Bug 714874 - Fix Java warnings about redundant casts. r=pcwalton r=dougt a=dougt 2012-01-06 12:21:49 -08:00
Chris Peterson
b576548e57 Bug 714874 - Fix some Java warnings. r=dougt a=dougt 2012-01-05 10:49:33 -08:00
Kartikaya Gupta
8aa0553439 Bug 715164 - Guard against another race condition in PZC. r=pcwalton 2012-01-05 18:13:25 -08:00
Kartikaya Gupta
a14cc99e99 Bug 715011 - Ensure that panning of subwindows can still happen while the top window is locked on one or both axes. r=Cwiiis 2012-01-04 13:25:11 -05:00
Patrick Walton
37040a8f9f Bug 709492 - Part 3: Tie viewport updates to drawing to avoid page transition flicker. r=kats 2012-01-03 22:55:04 -08:00
Mark Finkle
4dca8cf6bc Bug 714711 - A few unused local variables in PanZoomController.onScaleEnd [r=kats] 2012-01-03 12:19:49 -05:00
Kartikaya Gupta
ffe7d6d96d Bug 713586 - Robustify against undetected race conditions. r=pcwalton
The exception in bug 713586 can only occur if there are race conditions
in the PanZoomController that we haven't fixed yet. Until the race conditions
are fixed, we can robustify the code from dying horribly by making
the bounce-related variables local to the BounceRunnable, so that
different BounceRunnables running concurrently don't interfere with each
other.
2012-01-02 19:06:49 -05:00
Patrick Walton
d075492ab2 Backed out bug 709492 due to breakage with external urls. r=backout 2011-12-30 18:47:06 -05:00
Kartikaya Gupta
413ca00d80 Bug 713729 - Ensure that a fling is in progress when doing velocity-based fling adjustments. r=pcwalton 2011-12-29 22:29:16 -05:00
Patrick Walton
0fff0f0bdd Bug 709492 - Part 4: Hide the page when navigating, and expose it when the new page appears. r=kats 2011-12-29 15:10:30 -08:00
Kartikaya Gupta
c89a2e3670 Bug 712386 - Limit how much zoom can be applied. r=Cwiiis 2011-12-27 00:56:57 -05:00
Geoff Lankow
c801a48c75 Backed out 3 changesets (bug 710297, bug 712386, bug 712761) for perma-orange on Android native m1 and m2
Backed out changeset 3b1e6033d3ff (bug 712761)
Backed out changeset bb41941cdf9d (bug 710297)
Backed out changeset d4f9960e286a (bug 712386)
2011-12-28 01:00:02 +13:00
Margaret Leibovic
9243887289 Bug 711216 - Form autocomplete popup doesn't disappear when input gets out of view after pinch zoom [r=mfinkle] 2011-12-21 17:03:21 -08:00
Kartikaya Gupta
6e2b14a747 Bug 712386 - Limit how much zoom can be applied. r=Cwiiis 2011-12-27 00:56:57 -05:00
Kartikaya Gupta
78d4624638 Bug 711453 - Fix infinite zoom scale. r=pcwalton 2011-12-20 17:15:09 -05:00
Kartikaya Gupta
a09efe8450 Bug 709817 - Don't clobber mState if animations are aborted. r=pcwalton
Ensure that if the animation is aborted by changing the value of
mState (such as if we get an onTouchStart and set the mState to
TOUCHING), then we don't clobber it and set it back to NOTHING.
Only set it back to NOTHING when the animation finishes normally.
2011-12-20 16:53:39 -05:00
Kartikaya Gupta
36b1a1f54b Bug 709817 - Ensure PZC is always accessed on the UI thread. r=pcwalton
Ensure that all public functions in PZC are always called from
the UI thread, so that internal variables are not mutated on
different threads. I also made animatedZoomTo private so that
it can't be inadvertently called from a non-UI thread outside
the class.
2011-12-20 16:53:39 -05:00
Kartikaya Gupta
c5f70b0a51 Bug 709817 - (Cleanup) Replace geometryChanged() with abortAnimation() and remove dead calls. r=pcwalton
Since the geometryChanged function does nothing if the parameter passed
in is false, better to rename the function to be more indicative of
what it actually does, and remove all the resulting dead code.
2011-12-20 16:53:39 -05:00
Kartikaya Gupta
e8312c4295 Bug 712037 - Add lots of logging to help diagnose viewport issues. r=Cwiiis 2011-12-19 22:32:41 -05:00
Kartikaya Gupta
2bedc5c02c Bug 711232 - Avoid unnecessary bounce animations. r=pcwalton 2011-12-16 17:01:02 -05:00
Kartikaya Gupta
0b7c833306 Bug 711453 - Avoid potentially corrupting the fling velocity. r=pcwalton 2011-12-19 09:26:41 -05:00
Doug Turner
143c82d10a Backout of 9d027bf631d3 2011-12-17 21:52:54 -08:00
Kartikaya Gupta
72dad14f60 Bug 711232 - Avoid unnecessary bounce animations. r=pcwalton 2011-12-16 17:01:02 -05:00
Patrick Walton
35e3d0eb37 Bug 710119 - Use a low friction for long flings and a high friction for short ones. r=Cwiiis 2011-12-15 12:04:49 -08:00
Kartikaya Gupta
e99b90b671 Bug 708893 - Allow panning after releasing pinch zoom finger. r=pcwalton 2011-12-15 14:50:04 -05:00
Kartikaya Gupta
12e78e9171 Bug 710393 - Stop using Math.copySign which doesn't exist on Froyo. r=Cwiiis a=ehsan 2011-12-14 16:57:29 -05:00
Sriram Ramasubramanian
90c2cc8371 Bug 695444 - Form history autocomplete. r=mfinkle a=android-only 2011-12-06 16:44:08 -08:00
Patrick Walton
302ed2cf16 Bug 710096 - Hold the monitor on the layer controller when adjusting and rendering the viewport metrics. r=Cwiiis a=java-only 2011-12-13 14:43:08 -08:00
Doug Turner
f2f02f7573 Bug 709595 - Add a name for each java thread and timer to aide with debugging. r=blassey
--HG--
extra : rebase_source : 1f5472ef5301739425b162d5ce4b28a577daf0fb
2011-12-12 16:27:35 +08:00
Chris Lord
961a907049 Bug 705092 - Kinetic scrolling is too slow. r=pcwalton a=java-only
This introduces a friction factor, so that the deceleration is relative to
the current velocity. Now, the faster you scroll, the slower the view
decelerates, allowing you to page through longer pages easier.
2011-12-12 18:56:15 +00:00
Kartikaya Gupta
e24b9c4f9e Bug 704738 - Resize page content on device rotation. r=Cwiiis a=java-only
Some cleanup: ensure we abort and re-bounce the viewport
if the device is rotated during a double-tap zoom. Also
rename variables to be more appropriate
2011-12-12 11:22:34 -05:00
Kartikaya Gupta
d072b75773 Bug 708683 - Fix NaN viewport values. r=pcwalton
The zero page width and height values were
causing the zoom scale to go to Infinity, introducing
all sorts of badness in the viewport values.
2011-12-09 22:57:57 -05:00
Mark Finkle
78ed00239a Backout 03ed6af51318, c65be44ac489, 0ce8da61c6cc, bcc015450e7a because of mochitest failures r=mfinkle a=mfinkle 2011-12-12 09:02:01 -05:00
Doug Turner
bd7b08414e Bug 709595 - Add a name for each java thread and timer to aide with debugging. r=blassey
--HG--
extra : rebase_source : 552494a1086e706109296ca4c503c1d75796d852
2011-12-12 16:27:35 +08:00
Patrick Walton
9622e412bc Bug 708947 - Repair overscroll resistance, and add overscroll resistance when zooming. r=kats 2011-12-09 12:06:15 -08:00
Patrick Walton
7532e6f648 Bug 708928 - Don't render when a finger is down. r=Cwiiis 2011-12-09 12:06:10 -08:00
Patrick Walton
2b937fcd38 Bug 708921 - Bounce back during overscroll when the magnitude of the velocity vector exceeds the stopped threshold. r=kats 2011-12-09 12:06:06 -08:00
Wes Johnston
7e051c8490 Bug 706146 - Limit how far we can zoom into a page r=chrislord 2011-12-09 12:03:19 -05:00