Commit Graph

120 Commits

Author SHA1 Message Date
Ben Turner
6e20a64631 Backing out changesets ed8d3323a50d, 3930bbdffdd5, 36e32abd2cc8, f4bcfc703ff9, 21051d997076, and 49f489315dd9 at the request of bsmedberg. 2009-12-11 12:48:37 -08:00
Benjamin Smedberg
1c4aa9f2e3 Defer the PluginCrashed notification so that we don't delete the PluginModuleParent while we're in the middle of a crash notification. 2009-12-04 21:20:06 -05:00
Benjamin Smedberg
5035b52067 Partly fix test bustage from bug 532751: set mShutdown before notifying the nsNPAPIPlugin, so that it doesn't re-enter IPC methods. 2009-12-04 18:41:56 -05:00
Benjamin Smedberg
6e3d83cf38 Bug 532751 - Stop cacheing the nsNPAPIPlugin when it crashes, so that refreshing the page immediately reloads the plugin, r=bent pending r?joshmoz 2009-12-04 13:24:57 -05:00
Benjamin Smedberg
c29bfd6d3d Bustage fix 2009-12-03 15:44:33 -05:00
Benjamin Smedberg
c1afb3a76f Bug 532671 - After a plugin crashes, the module entry points (most importantly NPP_New) should fail, r=bent
--HG--
extra : rebase_source : 389d54e70fea2801d28bdf2e48740dcaaec31a07
2009-12-03 15:31:52 -05:00
Benjamin Smedberg
7fa499445d When the plugin crashes, set NPP->pdata to NULL, and null-check NPP->pdata in the callbacks that matter. r=bent
--HG--
extra : rebase_source : 32489b985b05b9da68546d37a2f0302bac8fd467
2009-12-03 15:31:01 -05:00
Benjamin Smedberg
f29a8b92d2 Bug 532659 - PluginScriptableObjectParent gets double-deleted when the plugin crashes, and fix the IPDL bug where we delete the actor if construction fails, instead of calling Deallocate on it, r=bent
--HG--
extra : rebase_source : dbe9a100735b1e0d0a8b07f4421e1ccb6055a78a
2009-12-03 15:30:05 -05:00
Ben Turner
998844d951 Fix bad invalidation bug in child NPObjects 2009-12-03 11:53:09 -08:00
Chris Jones
4572a1920a bug 529005: detect child process shutdowns vs. crashes, and expose this information to IPDL actors in a new |ActorDestroy(why)| interface. also ensure that subprotocol actors are notified of shutdown and cleaned up properly. r=bsmedberg r=bent 2009-12-03 02:16:28 -06:00
Chris Jones
4a0c6ae1dc bug 525342: make IPDL dtors part of the destructed actor's protocol instead of the manager's. r=bsmedberg 2009-12-03 02:16:14 -06:00
Chris Jones
f2a7be3825 bug 524220: add a |nullable| type qualifier denoting whether C++ actor params are allowed to be NULL. r=bent 2009-12-03 00:35:22 -06:00
Chris Jones
411500f1ca Build fix 2009-12-01 17:33:51 -06:00
Ben Turner
b17063546e Bug 526401 - Fixup handling of null NPP. r=bsmedberg. 2009-12-01 13:27:13 -08:00
Jim Mathies
0ffd1b2e75 Bug 522299 - Electrolysis: Get windowless plugins drawing on win32. r=jmuizelaar. 2009-12-01 15:05:26 -06:00
Benjamin Smedberg
96bcd263ae XXX removal: don't destroy the stream on failure (a future ActorDestroy callback will take care of that), and other shutdown- and crash-related XXX removal which are handled by bug 529005 2009-11-25 15:34:49 -05:00
Benjamin Smedberg
aa44111ad9 TODO-removal: make NullableStringGet an inline function instead of a macro, and make NullableString an inline function in mozilla::plugins instead of in an anonymous namespace: no need to have a separate copy of it for each translation unit. 2009-11-25 15:07:45 -05:00
Benjamin Smedberg
3815e2f045 More TODOs in the the plugin stream code, use the NullableString mechanisms which were invented after this landed. 2009-11-25 10:34:59 -05:00
Benjamin Smedberg
f7eb5c27ab Bug 530894 - Clean up TODOs in the plugin stream remoting: if NPN_{Get,Post}URLNotify fail, clean up the actor properly. Also deal with null postdata, which currently causes significant problems for the in-process case (NPN_PostURLNotify succeeds, but NPP_URLNotify is never called). r=bent 2009-11-25 09:26:01 -05:00
Benjamin Smedberg
bb315f002e Backed out changeset 97c456993dbd -- red herring, no need for this debugging spew. 2009-11-20 13:48:42 -05:00
Chris Jones
fe82937760 temporary debugging spew to check bug 529234 2009-11-20 11:54:46 -06:00
Benjamin Smedberg
bda0f732bc Don't crash if NP_Initialize failed remotely: PluginLibrary::NP_Initialize returns an nsresult, not a NPError; nsNPAPIPlugin::CreatePlugin fails but still sets the outparam; nsPluginHost doesn't properly rv-check nsNPAPIPlugin::CreatePlugin, which causes us to think the bad plugin is actually good. I hate stupid failure chains! 2009-11-20 10:34:20 -05:00
Chris Jones
9a696edbf3 bug 530007: fix crashing edge cases in the hope of getting better diagnostics about failed tests 2009-11-20 02:23:07 -06:00
Benjamin Smedberg
8f0adb5fe2 Don't use a static nsCString (causing leaks in the plugin process). Also, use NS_LogInit/NS_LogTerm for the child process so that leaks are reported at the right time. 2009-11-19 17:57:56 -05:00
Ben Turner
e9917531bc Fix bad allocation pattern in NPP_New 2009-11-19 14:47:09 -08:00
Ben Turner
b6ef9679ad Followup to bug 527876 2009-11-13 13:19:33 -08:00
Ben Turner
42c5c160d1 Bug 527876 - 'test_windowed_invalidate.html hangs during mochitest-ipcplugins'. 2009-11-13 12:20:03 -08:00
Chris Jones
64b9366a4d no need to include in C++ protocol-common headers |include protocol|'d from IPDL. this is an accident of history 2009-11-12 16:20:20 -06:00
Ben Turner
cafe07f11b Bug 525792 - 'Fix leaks running mochitests'. 2009-11-12 14:16:54 -08:00
Benjamin Smedberg
effd77def4 Don't rely on the plugin methods to return a non-null actor when the say NPERR_NO_ERROR... crashing here is a no-no even if the plugin is stupid. 2009-11-11 17:01:07 -05:00
Ben Turner
0a4603ecea Fix invalidation algorithm so that we never leave a deleted actor in the live hash map. 2009-11-11 17:12:01 -08:00
Chris Jones
5629855e23 mac builds and runs with --enable-ipc, but the subprocess nsAppShell dies for an apparently Cocoa-related reason. IPC is fine though 2009-11-10 20:25:10 -06:00
Ben Turner
401a6884be Fix silly bugs 2009-11-09 17:30:02 -08:00
Phineas T. Farnsworth
c1f7d557dc bug 526626: band-aids for shutdown assertions 2009-11-09 16:56:55 -06:00
Ben Turner
d1a97dd911 Bug 522414 - 'RPC and Sync channels will deadlock easily on Windows'. r=jimm+rs. 2009-11-06 14:33:12 -08:00
Chris Jones
721479dcd3 bug 523894: wstrings are bad news in OPT builds due to chromium/Mozilla -fshort-wchar mismatch 2009-11-05 18:24:27 -06:00
Chris Jones
f1358e3105 bug 525792: fix leaking PluginModules, call NP_Shutdown() on plugins. minor, no r= 2009-11-03 15:37:07 -06:00
Benjamin Smedberg
3367daa125 Remove stale TODO, this will be properly covered by parent-side error handling events. 2009-11-02 11:48:52 -05:00
Benjamin Smedberg
f0f56fb840 Linux build bustage from previous commit, bug 525605. 2009-10-31 15:32:06 -04:00
Benjamin Smedberg
c7b65d066d Bug 525605 - Windows unit tests orange loading plugins: on Windows, the directly-imported plugin functions are WINAPI, so we need to use careful typedefs to get the calling convention right. 2009-10-31 15:22:02 -04:00
Benjamin Smedberg
b0a9529f7f Bug 525454 - Crash in mochitest-ipcplugins where NPP_Invoke returns the last reference to an object. Also fixes an operator-precedence error. 2009-10-30 17:02:47 -04:00
Chris Jones
4f942a96f2 bug 523761: give top-level IPDL actors handles to each others' processes. r=bent 2009-10-27 16:52:37 -05:00
Chris Jones
db4d86c978 Make a DEBUG_cjones log message DEBUG 2009-10-27 16:07:49 -05:00
Benjamin Smedberg
1b97d8b940 Linux build bustage from bug 522122. 2009-10-27 16:59:40 -04:00
Jeff Muizelaar
31d0efb7ae Bug 522122. Electrolysis: Forawrd windows events to windowless plugins. r=cjones,karlt
This gets windowless plugin events mostly working. We don't forward IME events because
they are much more complicated.
2009-10-27 15:58:33 -04:00
Josh Aas
39b3aac40a Allow multiple types of OOP plugins to load. b=516509 r=cjones 2009-10-27 15:51:12 -04:00
Chris Jones
0564ad103d bug 523143: switch protocols using nsTArray to native IPDL arrays 2009-10-19 14:10:52 -05:00
Chris Jones
e1e761401a bug 506171: rewrite lower.py and add native IPDL arrays. 2009-10-16 18:31:53 -05:00
Ben Turner
927eca0769 Add NPN_Evaluate and NPN_Push/PopPopupsEnabledState support 2009-10-13 10:54:41 -07:00
Karl Tomlinson
3fa2368891 b=521376 remove XSynchronize from plugin process r=cjones 2009-10-12 12:54:49 +13:00