Neil Deakin
1c5ceca087
Bug 610545, check for a transition earlier to avoid assertion if a panel is opened while it is closing, r=neil
2014-03-31 08:42:33 -04:00
Neil Deakin
ce52b1b9cf
Bug 610545, arrow panels should animate when opening and when cancelling, r=neil,dao
2014-03-31 08:42:32 -04:00
Jonathan Watt
ecdb8cca65
Bug 988818 - Stop creating a Thebes (gfxASurface) backed gfxContext in nsSVGImageFrame (Moz2D migration). r=longsonr
2014-03-31 12:53:54 +01:00
Jonathan Watt
4ea99f4230
Bug 988904 - Stop creating a Thebes gfxImageSurface in PresShell::PaintRangePaintInfo (Moz2D migration). r=mattwoodrow
2014-03-31 12:53:31 +01:00
Jonathan Kew
cf66ed437a
bug 617008 - avoid creating a rendering context that we may not need. r=roc
2014-03-31 11:53:09 +01:00
Peter Van der Beken
17b498a5a1
Bug 988334 - Stop reusing SpecialPowers for different windows. r=jmaher.
...
--HG--
extra : rebase_source : ffeb4f2d49c6a20a95cc3ca0da63b49c10dee904
2014-03-24 21:12:41 +01:00
Paul Adenot
cfb673b6a0
Bug 946618 - Add native tests for cubeb. r=kinetik
...
--HG--
extra : rebase_source : 9b2e8e702ce5f8ea4d5416f3b45c91bc4cd94432
2014-02-25 14:21:59 +01:00
Jonathan Watt
fcf83c889b
Bug 990683 - Stop calling DeprecatedGetCurrentAsSurface in nsLayoutUtils::SurfaceFromElement(HTMLVideoElement* aElement,...). (Moz2D migration.) r=mattwoodrow
2014-04-02 12:32:24 +01:00
Simon Sapin
bc4b99a25a
Bug 989755: Fix up serialization of the grid-template shorthand. r=dholbert
...
* Refuse to serialize some combinations of values that the shorthand
can not represent: 'grid-template-areas: (not none)' combined with
'grid-template-rows: subgrid' or 'grid-template-columns: subgrid'.
(The former used to cause an assertion failure.)
* Remove an extraneous trailing space that occured when a <track-list>
was last. (ie. followed by an omitted <line-names>)
* Add tests for the result of this serialization.
2014-03-31 13:31:00 +02:00
Simon Sapin
f410d8a001
Bug 978478 part 2: Add support for repeat() in <track-list> (CSS Grid) r=dholbert
2014-03-31 22:49:51 -07:00
Simon Sapin
e6f3513409
Bug 978478 part 1: Add support for repeat() in <line-name-list> (CSS Grid) r=dholbert
2014-03-31 22:49:45 -07:00
Masayuki Nakano
a63f35fff1
Bug 984271 part.2 Rename nsEventStateManager to mozilla::EventStateManager r=smaug
...
--HG--
rename : dom/events/nsEventStateManager.cpp => dom/events/EventStateManager.cpp
rename : dom/events/nsEventStateManager.h => dom/events/EventStateManager.h
2014-04-01 13:09:23 +09:00
L. David Baron
4e6a059a99
Bug 470769 - Store computed styles of integer-valued properties as integers in nsROCSSPrimitiveValue, so they round-trip correctly. r=bzbarsky
2014-03-29 09:29:30 -07:00
Daniel Holbert
3fb4371541
Bug 989436 part 3b: Add some reftests with various cross-axis margins on baseline-aligned flex items, in a fixed-size flexbox. r=mats
2014-03-29 01:20:59 -07:00
Daniel Holbert
c8ac9ad684
Bug 989436 part 3a: Rename tests flexbox-align-self-baseline-horiz-[23].xhtml to -[45]. (no review)
...
--HG--
rename : layout/reftests/w3c-css/submitted/flexbox/flexbox-align-self-baseline-horiz-2-ref.xhtml => layout/reftests/w3c-css/submitted/flexbox/flexbox-align-self-baseline-horiz-4-ref.xhtml
rename : layout/reftests/w3c-css/submitted/flexbox/flexbox-align-self-baseline-horiz-2.xhtml => layout/reftests/w3c-css/submitted/flexbox/flexbox-align-self-baseline-horiz-4.xhtml
rename : layout/reftests/w3c-css/submitted/flexbox/flexbox-align-self-baseline-horiz-3-ref.xhtml => layout/reftests/w3c-css/submitted/flexbox/flexbox-align-self-baseline-horiz-5-ref.xhtml
rename : layout/reftests/w3c-css/submitted/flexbox/flexbox-align-self-baseline-horiz-3.xhtml => layout/reftests/w3c-css/submitted/flexbox/flexbox-align-self-baseline-horiz-5.xhtml
2014-03-29 01:20:58 -07:00
Daniel Holbert
0c3e690428
Bug 989436 part 2: Clone existing baseline-alignment reftest, with "flex-flow: wrap-reverse", to make sure baseline-alignment works with bottom-to-top cross axis. r=mats
...
--HG--
rename : layout/reftests/w3c-css/submitted/flexbox/flexbox-align-self-baseline-horiz-1.xhtml => layout/reftests/w3c-css/submitted/flexbox/flexbox-align-self-baseline-horiz-1a.xhtml
rename : layout/reftests/w3c-css/submitted/flexbox/flexbox-align-self-baseline-horiz-1.xhtml => layout/reftests/w3c-css/submitted/flexbox/flexbox-align-self-baseline-horiz-1b.xhtml
2014-03-29 01:20:56 -07:00
Daniel Holbert
ae47fc3927
Bug 989436 part 1: Add a reftest to exercise all "flex-flow" values, with extra space left over on the final flex line. r=mats
...
--HG--
rename : layout/reftests/w3c-css/submitted/flexbox/flexbox-flex-flow-1-ref.html => layout/reftests/w3c-css/submitted/flexbox/flexbox-flex-flow-2-ref.html
rename : layout/reftests/w3c-css/submitted/flexbox/flexbox-flex-flow-1.html => layout/reftests/w3c-css/submitted/flexbox/flexbox-flex-flow-2.html
2014-03-29 01:20:51 -07:00
Boris Zbarsky
9553dba3d6
Bug 987112. Remove the redundant and somewhat annoying parentObject argument to dictionary ToObject() methods. r=bholley
2014-03-29 01:45:10 -04:00
Timothy Nikkel
6006f990ab
Bug 989574. Enable reftests in layout/reftests/invalidation on all platforms. r=dbaron
...
A mistake caused them to never be enabled (except on b2g).
2014-03-28 23:54:37 -05:00
L. David Baron
77915404c0
Bug 986807 patch 3 - Use preprocessor to avoid duplicating reftest default preference lists. r=ted
...
Note that the reordering in Makefile.in is because the addition to
PP_TARGETS must be before including rules.mk. (Logically, I was moving
_DEST_DIR, _HARNESS_FILES, and the _HARNESS_PP_FILES chunk up, but diff
shows it the other way around.)
2014-03-28 20:13:25 -07:00
Timothy Nikkel
7236146d49
Bug 961431. Round the final screen position of the popup to pixels, not the offset between it's view and parent view. r=enndeakin
2014-03-28 20:00:27 -05:00
Bill McCloskey
11308f107e
Bug 986653 - Add --e10s option to reftests (r=ted)
2014-03-18 16:31:28 -07:00
Bill McCloskey
04c455ac87
Bug 986691 - [e10s] Disable some layout tests (r=roc)
2014-03-28 11:25:11 -07:00
Kartikaya Gupta
0c67224bf9
Bug 948377 - Remove unwanted rounding in CalculateCompositedRectInCssPixels; add a CalculateCompositedSizeInCssPixels also. r=botond
2014-03-28 10:36:47 -04:00
Kartikaya Gupta
be80698012
Bug 980679 - Filter redundant scroll offset updates by scroll generation value. r=botond,tn
2014-03-28 08:21:19 -04:00
Neil Rashbrook
fe80fce47a
Bug 514280 Consistently declare and define IID accessors r=bsmedberg
2014-03-28 08:45:02 +00:00
Ehsan Akhgari
345b35a6e8
Bug 798158 - Part 1: Use a pointer-sized type to store refcounts internally; r=bsmedberg
2014-03-27 16:38:33 -04:00
Ms2ger
b765dd44d3
Bug 984006 - Remove xpcom/ds from local includes; r=ehsan
2014-03-27 21:05:14 +01:00
Max Vujovic
5727154044
Bug 948265 - Rename intermediate space to filter space and change filter space origin to user space origin. r=mstange, r=longsonr
2014-03-26 16:21:48 -07:00
Simon Sapin
6064ae5c0e
Bug 983175 - Part 2: Add style system support for 'subgrid' in the grid-template* properties. r=dholbert
...
http://dev.w3.org/csswg/css-grid/#subgrids
2014-03-27 11:54:40 -04:00
Simon Sapin
3f0ca1cfe4
Bug 983175 - Part 1: Refactor ParseGridLineNames (CSS Grid). r=dholbert
...
Return a CSSParseResult rather than a bool to distinguish between
an empty list of names '()' and the lack of a list.
2014-03-27 11:54:40 -04:00
Simon Sapin
0a31fb78d4
Bug 983175 - Part 0: Rename nsParsingStatus to CSSParseResult. r=dbaron
2014-03-27 11:54:40 -04:00
Ryan VanderMeulen
180f819eb9
Bug 919482 - Replace mozilla-banner.gif with a plain blue image in 163504-1*.html since we aren't trying to test individual pixel differences in resized image painting there. r=tn
2014-03-27 11:02:27 -04:00
Ryan VanderMeulen
b091b0dd52
Bug 909305 - Replace mozilla-banner.gif with a plain blue image in 163504-2*.html since we aren't trying to test individual pixel differences in resized image painting there. r=tn
2014-03-27 11:02:26 -04:00
Timothy Nikkel
385cfbb602
Bug 957668. Protect against a null frame. r=nullcheck CLOSED TREE
2014-03-26 23:20:23 -05:00
Timothy Nikkel
24f3430ec2
Bug 957668. Add comment based on review comment. DONTBUILD
2014-03-26 21:23:14 -05:00
Timothy Nikkel
af1fa4611b
Bug 957668. Set the display port base rect in several places. r=roc
2014-03-26 21:46:24 -04:00
Timothy Nikkel
8ccbcd870e
Bug 957668. Add and implement plumbing for a display port margins api. r=kats
2014-03-26 21:46:23 -04:00
Timothy Nikkel
90ca2854ab
Bug 957668. Factor out a few helper functions. r=roc
2014-03-26 21:46:23 -04:00
Timothy Nikkel
79463c4f16
Bug 986413. Limit composition bounds used for display port calculation to root composition bounds. r=kats
2014-03-26 19:24:25 -04:00
Ryan VanderMeulen
beaad0859b
Bug 980247 - Fix silly rebase error. r=fail
2014-03-26 15:38:08 -04:00
L. David Baron
67734de948
Bug 989560 patch 4 - Remove most uses of CheckEndProperty()/ExpectEndProperty(). r=heycam
2014-04-01 11:53:32 -07:00
L. David Baron
94c2eb86fa
Bug 989560 patch 3 - Add one more ExpectEndProperty() call that is needed for variables. r=heycam
...
This adds a check that is currently present in most but not all
codepaths leading to this point, but which patch 4 will remove from many
of those codepaths.
2014-04-01 11:53:32 -07:00
L. David Baron
e7c2035cb7
Bug 989560 patch 2 - Don't accept an empty value for font-variant-alternates. r=heycam
...
Had patch 3 not been present, this would be needed to prevent a test
failure with patch 4 (which removes the ExpectEndProperty check from the
CSS_PROPERTY_PARSE_VALUE case in
CSSParserImpl::ParseProperty(nsCSSProperty) since its callers handle
checking for appropriate endings), since the way this function returns
success for empty values leads var() functions alone inside
font-variant-alternates to be rejected, since
CSSParserImpl::ParseProperty(nsCSSProperty) won't try reparsing with
variables.
2014-04-01 11:53:32 -07:00
L. David Baron
418dc99018
Bug 989560 patch 1 - Make it an error to have an empty item within an animation or transition shorthand. r=heycam
...
This is needed to make the test in the next patch (which tests that we
reject entirely-empty properties) pass.
2014-04-01 11:53:31 -07:00
L. David Baron
8592c4c03a
Bug 988702 patch 3 - Fix missing UngetToken() calls in ParseCounterData(), and avoid evil CheckEndProperty() calls while I'm there. r=heycam
...
I tested that test_property_syntax_errors.html gives a failure on the
new test without the patch, and that the failure is not present with the
patch.
2014-04-01 11:53:31 -07:00
L. David Baron
0c81f40b4b
Bug 988702 patch 2 - Test invalid CSS property values for their balanced-ness of () [] or {}. r=heycam
...
(This provides an easy mechanism for testing for missing UngetToken()
calls as in the following patch.)
2014-04-01 11:53:31 -07:00
L. David Baron
1d5f54dbab
Bug 988702 patch 1 - Remove duplication between invalidGradientAndElementValues and the list of invalid values in background-image. r=heycam
...
Values that are already in invalidGradientAndElementValues don't also
need to be listed in an array that has invalidGradientAndElementValues
appended to it.
2014-04-01 11:53:31 -07:00
L. David Baron
8b0d19ca2d
Bug 989688 patch 6 - Run the reftests in toolkit/content/tests/reftests/. r=enndeakin
...
This should have been added in
https://hg.mozilla.org/mozilla-central/rev/0c2c2c895e5d (bug 442419) or
perhaps also in bug 841001 when another test was added to this
directory.
2014-04-01 11:53:31 -07:00
L. David Baron
863f4a15c7
Bug 989688 patch 5 - Run the reftests in layout/reftests/view-source/. r=roc
...
This should have been added in
https://hg.mozilla.org/mozilla-central/rev/745c0c2aa1fe (bug 464339).
Furthermore, the image being missing was the result of using
checkin-needed on a non-GIT-style diff "containing" an image.
--HG--
rename : layout/reftests/view-source/reftests.list => layout/reftests/view-source/reftest.list
2014-04-01 11:53:31 -07:00
L. David Baron
39c4d936c7
Bug 989688 patch 4 - Only include the reftests in layout/reftests/css-valid/output/ once. r=jwatt
...
All three lines were added in
https://hg.mozilla.org/mozilla-central/rev/2eb1331a2bc4
2014-04-01 11:53:30 -07:00
L. David Baron
ef72a7da6e
Bug 989688 patch 3 - Run the reftests in layout/reftests/css-invalid/form/. r=jwatt
...
This should have been added in
https://hg.mozilla.org/mozilla-central/rev/7fa9d642fe74 (bug 596515).
jhk, do you still happen to have a copy of the missing
form-dynamic-not-invalid-barred.html file?
2014-04-01 11:53:30 -07:00
L. David Baron
d1b1737dd6
Bug 989688 patch 2 - Run the reftests in layout/reftests/async-scrolling/. r=roc
...
This should have been added in
https://hg.mozilla.org/mozilla-central/rev/a888be20e9d7 (bug 975931).
2014-04-01 11:53:30 -07:00
L. David Baron
eea176941f
Bug 989688 patch 1 - Only include the webcomponents reftest.list once. r=wchen
...
These duplicate lines were added in two changesets with only one
changeset between them:
https://hg.mozilla.org/mozilla-central/rev/08afb5a033eb
https://hg.mozilla.org/mozilla-central/rev/79b61f9909c0
2014-04-01 11:53:30 -07:00
L. David Baron
a6d999c810
Bug 989574 patch 2 - Fix comment to match code.
2014-04-01 11:53:30 -07:00
L. David Baron
0f609689eb
Bug 989130 - Back out changeset fe119a83b1f2 (bug 942017) while leaving the corresponding test from changeset 3c63decb4e7e. r=jfkthame
...
This should be backed out for two reasons:
(1) It caused a serious regression with bullets from list-style-image,
which no longer affect the line box height and thus overlap.
(2) The dependency on 'line-height: normal' doesn't make sense; there's
no reason for whether line-height is 'normal' or not to affect the
behavior of bullets.
I don't currently have time to figure out why Gecko behavior differs
from other browsers on bug 942017, but that should be re-analyzed and
the bug fixed in a different way. At first glance, the code should
already be leading to the expected behavior, since the bullet ought to
have the same metrics and alignment as the block's influence on the line
box's height. Why this isn't the case should be investigated.
2014-04-01 11:53:29 -07:00
Abel Lin
b82c67b50d
Bug 980247 - Add a reftest for different continuations of a sticky element having the same offsets. r=dbaron
2014-03-26 14:46:47 -04:00
Abel Lin
0b1203962c
Bug 980247 - Use offsets from GetNormalPosition() when updating continuations of position:sticky elements instead of assuming that they're all currently offset by the same amount. r=dbaron, r=corey
2014-03-26 14:45:17 -04:00
Boris Zbarsky
235a752941
Bug 610733. Vertically center the text in the combobox display area when a non-default height is set for the combobox. r=dbaron
2014-03-25 22:48:46 -04:00
Brian Birtles
827ab27605
Bug 986367 - Make paint_listener.js check for paint suppression; r=mattwoodrow
...
This patch adds an extra check for paint suppression when waiting for paint
events. This is because on some platforms (notably B2G) we can think all paints
have completed because paint suppression is in effect and as a result call the
callback too soon.
This patch use window.setTimeout(..., 0) to wait for paint suppression to finish
before preceding to check for pending paint events.
When the refresh driver is under test control, if we detect that paint events
are pending we need to force a refresh driver tick. This patch adds that tick.
I suppose we had previously never hit this situation before and never noticed
this.
This patch also rearranges the main loop so that early returns appear first and
calling the callback appears at the end.
2014-03-26 09:20:07 +09:00
Jeff Muizelaar
2f91140e71
Bug 980186. Tell automation.environment about the debugger. r=jgriffin
...
This lets it set the crash reporting envs properly.
--HG--
rename : layout/reftests/abs-pos/table-internal-5-ref.html => layout/reftests/abs-pos/table-internal-1-ref.html
rename : layout/reftests/abs-pos/table-internal-6-ref.html => layout/reftests/abs-pos/table-internal-3-ref.html
rename : layout/reftests/abs-pos/table-internal-7-ref.html => layout/reftests/abs-pos/table-internal-4-ref.html
rename : webapprt/test/chrome/mozpay-failure.html => webapprt/test/chrome/mozpay-success.html
extra : rebase_source : 903979ef854d1c1737ed4b2eb21be26b2bcb7017
2014-03-07 15:38:48 -05:00
Jonathan Griffin
e167be0896
Bug 979650 - Always build with Marionette for Firefox, b2g desktop, r=ted
2014-03-11 13:22:34 -07:00
Bobby Holley
8ce8fa17a7
Bug 987672 - Use a more reliable Function constructor and |bind| implementation for marquee event handler compilation. r=bz
2014-03-25 12:36:39 -03:00
Birunthan Mohanathas
7ac995a949
Bug 987320 - Remove unnecessary null checks for do_QueryFrame arguments. r=bz
2014-03-25 11:36:49 -04:00
Nicolas E. Bordenabe
98620a9c7e
Bug 973345 - Include gradient values in the return value of getCSSValuesForProperty() for properties that can have an <image> value specified. r=bz
2014-03-25 11:36:48 -04:00
Carsten "Tomcat" Book
bb598f226f
Backed out changeset b6c3d52bf61e (bug 791480) for breaking B2G ICS Emulator Reftest - 8
2014-03-25 14:36:48 +01:00
Carsten "Tomcat" Book
205e52b113
Backed out changeset 259991514082 (bug 791480)
2014-03-25 14:36:16 +01:00
Kartikaya Gupta
0e225bf776
Bug 984548 - Ifdef APZ overflow:hidden behaviour so it doesn't regress Fennec pending a proper fix. r=tn
2014-03-25 09:25:56 -04:00
Gorman Ho
f829937556
Bug 983285 - Add a generic destructor for property values allocated with new. r=kats, r=bz
2014-03-25 09:25:47 -04:00
Jonathan Kew
e1bd0b806a
bug 827779 - reftest for modified hyphen-break rules. r=masayuki
2014-03-25 09:29:18 +00:00
Robert O'Callahan
a71360107a
Bug 791480. Reenable test on Windows 7. r=dbaron
2014-03-25 22:15:49 +13:00
Robert O'Callahan
62432f22ec
Bug 791480. Make reftests enter print mode before reftest-wait is removed, so canvas-print-callback tests can finish drawing before the test ends. r=dbaron
...
--HG--
extra : rebase_source : c545bfbfd4a449c4e880052da0e1e046e37eaf83
2014-03-25 22:11:27 +13:00
Jonathan Watt
d195236d65
Bug 959128 - Fix transforms of clipPath content for clipPath being used within SVG-in-OpenType glyph. r=heycam
2014-03-25 08:51:10 +00:00
Matt Woodrow
2cabdd6d95
Bug 976365 - Make 'perspective' create a containing block for absolute and fixed positioned children. r=dbaron
2014-03-25 11:45:43 +13:00
Ryan VanderMeulen
ccc7ff136b
Bug 948389 - Replace mozilla-banner.gif with a plain blue image in 405577-1.html since we aren't trying to test individual pixel differences in resized image painting there. r=roc
2014-03-24 17:44:01 -04:00
Simon Montagu
3766f98942
Aways use the root span's writing mode when recursing into child spans in nsLineLayout::ApplyFrameJustification. Bug 986899, r=jfkthame
2014-03-24 10:50:13 -07:00
Simon Sapin
72897b9af2
Bug 984728 - Refactor grid-auto-flow parsing to use ParseBitmaskValues; r=dholbert
2014-03-24 14:26:04 +01:00
James Kitchener
3e0faecbe5
Bug 986799 - Handle rtl mtable padding properly. r=fredw
2014-03-24 08:58:29 -04:00
Simon Montagu
27a769cf38
Correction to typo in checkin for bug 789096. Bug 983691, r=jfkthame
2014-03-24 02:23:12 -07:00
L. David Baron
1c941712ca
Bug 986807 patch 2 - Sync APZC/viewport prefs from bug 975931 from desktop reftest code to Android/B2G reftest code. r=roc
2014-03-23 18:44:50 -07:00
L. David Baron
44c7eeef75
Bug 986807 patch 1 - Sync lower-risk prefs over from desktop reftest code to Android reftest code. r=roc
2014-03-23 18:44:50 -07:00
L. David Baron
a085fede18
Bug 986409 - Skip fewer entire reftest directories on B2G. r=roc
2014-03-23 18:44:50 -07:00
L. David Baron
38aadb6a27
Bug 986406 - Don't skip entire reftest directories on Android. r=roc
2014-03-23 18:44:49 -07:00
L. David Baron
c6269e36e7
Bug 986404 - Mark test as failing due to scrollbars showing up.
2014-03-22 22:07:15 -07:00
L. David Baron
0797c82c4a
Bug 986404: Disable fade-out of overlay scrollbars during reftest. r=mstange
2014-03-22 21:55:04 -07:00
Boris Zbarsky
4326c51942
Bug 955860 followup to add a pointer to the source of the tests.
2014-03-21 23:07:12 -04:00
Simon Sapin
6161867d62
Bug 984760 part 2: Use GridTemplateAreasValue though nsRefPtr pointers. r=dholbert
2014-03-21 23:06:16 +08:00
Simon Sapin
4d0c20f01f
Bug 984760 part 1: Rename nsCSSValueGridTemplateAreas to css::GridTemplateAreasValue. r=dholbert
2014-03-21 23:06:13 +08:00
Simon Sapin
e83e296f58
Bug 981752 part 3: Add the grid shorthand. r=dholbert
2014-03-21 23:06:12 +08:00
Simon Sapin
48d0651e87
Bug 981752 part 2c: Add the grid-template shorthand. r=dholbert
2014-03-21 23:06:12 +08:00
Simon Sapin
4d9684360b
Bug 981752 part 2b: Refactor grid-template-{columns,rows} parsing, preparing for the grid-template shorthand. r=dholbert
...
... and a bit of grid-auto-flow, for the grid shorthand.
* Avoid using CheckEndProperty() when possible
* Distinguish between "error" and "not a <track-size>"
* Split out parsing of a <track-list>, given its initial [<line-names>?]
2014-03-21 23:06:12 +08:00
Simon Sapin
c27572613c
Bug 981752 part 1: Add the grid-column, grid-row and grid-area shorthands. r=dholbert
2014-03-21 23:06:12 +08:00
Jonathan Watt
bffb9388c5
Bug 985470 - Replace the Moz2D Matrix().Translate() calls with Matrix::Translation() for better perf. r=mattwoodrow
...
--HG--
extra : rebase_source : 7181564bdaa57a970a256e9676857a7195874631
2014-03-22 07:56:11 +08:00
Brian Birtles
9647a9f855
Bug 981508 - Fix comment in nsDisplayTransform::ShouldPrerenderTransformedContent; r=roc
2014-03-22 05:59:58 +08:00
Brian Birtles
880027c0e0
Bug 975261 part 5 - Fix OMTA animations with backwards fill; r=dzbarsky
...
When we have a backwards fill and we sample at *exactly* the start of the
animation on the next refresh driver tick, when we get to
RestyleManager::ComputeStyleChangeFor (or more specifically
ElementRestyler::CaptureChange) we notice that the style hasn't changed (since
the first frame of the animation produces the same value as the backwards fill)
and end up with an empty change list. As a result we never schedule a view
manager flush and rebuild the layer. Hence, the animation never gets sent to the
compositor thread. On the next tick we're already throttling the main thread.
This patch fixes this by applying the same approach as is used for transitions,
that is, explicitly marking which animations are running on the compositor
thread so we know if we need to trigger a layer transaction or not. This should
not only be more robust than the previous code but also facilitate aligning
animations and transitions code (bug 880596).
2014-03-22 05:59:58 +08:00
Brian Birtles
11a7708f98
Bug 975261 part 4 - Add test for starting OMTA animations with backwards fill; r=dzbarsky
...
This test reproduces a bug where we don't send an animation to the compositor
thread. The important step is the sample precisely at the start of the animation
interval.
2014-03-22 05:59:58 +08:00
Brian Birtles
d362de8251
Bug 975261 part 3 - Add test for transforms; r=dzbarsky
...
Adds a test for transform animations with a delay where there is already
a transform specified on the element.
This test used to fail but bug 828173 fixed it. It is included here as
a regression test.
(Prior to bug 828173 we were able to fix this by triggering
ForceLayerRerendering inside nsAnimationManager::nsFlushAnimations whenever we
detected *different* style rules but canThrottleTick=true)
The issue stemmed from the fact that when an element has a transform property,
LayerIsPrerenderedDataKey would get set on the layer because in
nsDisplayTransform::ShouldPrerenderTransformedContent we would only check for
the *presence* of an animation, not whether it is running. Then in
RestyleManager::DoApplyRenderingChangeToTree we wouldn't do an invalidating
paint because TryUpdateTransformOnly() returns true since it looks at
LayerIsPrerenderedDataKey.
Bug 828173 fixes this, at least in part, by checking if an animation is running.
This bug may resurface if we put animations with a delay on the compositor
thread hence it is worth including here.
2014-03-22 05:59:57 +08:00
Brian Birtles
036a91443e
Bug 975261 part 2 - Trigger animations with a delay; r=dzbarsky
...
Animations with a delay are not put on the compositor thread until the end of
the delay phase. However, there is currently nothing that explicitly triggers
this transaction. It may occur due to flushes that arise from UI events but it
is not guaranteed.
This patch detects the end of a delay phase and turns off throttling for that
sample. It re-uses the mLastNotification member which is not ideal but
a subsequent patch in this queue removes this and replaces it with the approach
used for transitions.
2014-03-22 05:59:57 +08:00
Brian Birtles
dda03127b6
Bug 975261 part 1 - Add test for OMTA animations that start with a delay; r=dzbarsky
2014-03-22 05:59:57 +08:00
Chadd Williams
be019a3d12
Bug 980493 - Transition FrameMetrics::mScrollId to use a getter/setter. r=botond
...
--HG--
extra : histedit_source : 1c84496d4b61f019e6e6cc24591ee3a10434e4cc
2014-03-21 17:48:08 -04:00
