Commit Graph

338 Commits

Author SHA1 Message Date
Phil Ringnalda
8a89e647fd Backed out 9 changesets (bug 1142775, bug 1139683, bug 1143810, bug 1142761, bug 1142784, bug 1142794, bug 1144819) for widespread bustage
CLOSED TREE

Backed out changeset 7613fc978d36 (bug 1142794)
Backed out changeset e5f0cb31263d (bug 1142784)
Backed out changeset dcd0af73ac84 (bug 1142784)
Backed out changeset 034f9c8e79ee (bug 1142784)
Backed out changeset ce0ee37e3ca9 (bug 1142775)
Backed out changeset 1519b8f2bbba (bug 1142761)
Backed out changeset 26fd55677841 (bug 1139683)
Backed out changeset 7ebc76a450c3 (bug 1144819)
Backed out changeset 92adb459d519 (bug 1143810)
2015-03-22 09:34:25 -07:00
Jason Orendorff
60373a960b Bug 1142794 - Change 'receiver' argument to SetProperty functions and ProxyHandler::set methods to be a HandleValue. r=Waldo.
Also: Change signature of these functions and methods to all have the same arguments in the same order: (cx, obj, id, v, receiver). Also change v from MutableHandleValue to HandleValue.

There is no change in behavior.

In fact the new error message `JSMSG_SET_NON_OBJECT_RECEIVER` is
impossible to trigger from scripts for now, I think (after re-reading
the whole patch with this in mind). JS_ForwardSetPropertyTo is the only
way to get a non-object receiver into the engine, but no caller
currently does so.

We're installing new pipes here, and they should work, but for now it's
the same cold water flowing through as before. Actually hooking up the
hot water is left for another bug (one with tests, not to put too fine a
point on it).

Notes:

*   InvokeGetterOrSetter had to be split into two functions:
    InvokeGetter takes a MutableHandleValue out-param,
    InvokeSetter a HandleValue in-param.

*   Watchpoints can still tamper with values being assigned. So can
    JSSetterOps. I'm pleased we can support this craziness in a way that
    doesn't have to spread via the type system to encompass the entire
    codebase.

*   Change in GlobalObject::setIntrinsicValue is not really a change.
    Yes, it asserted before, but an exception thrown during self-hosting
    initialization is not going to go unnoticed either.

*   Since the receiver argument to js::SetProperty() is at the end now, it
    makes sense for it to be optional. Some callers look nicer.
2015-03-01 13:16:19 -06:00
Jason Orendorff
6b90d382df Bug 1142784, part 2 - Change ProxyHandler::defineProperty() to make the desc argument a non-mutable handle. r=Waldo. 2015-02-17 11:58:43 -06:00
Ehsan Akhgari
33bb32f549 Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
This patch was automatically generated using the following script:

function convert() {
echo "Converting $1 to $2..."
find . \
       ! -wholename "*/.git*" \
       ! -wholename "obj-ff-dbg*" \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Blake Kaplan
b9d723a7c1 Bug 1134006 - Avoid IPC for domElement.QueryInterface(nsISupports) and nsIClassInfo. r=billm 2015-03-10 14:36:01 -07:00
Carsten "Tomcat" Book
fcc855696d Backed out changeset 6c7ebb2f5a92 (bug 1134006) for bustage 2015-03-10 12:37:24 +01:00
Blake Kaplan
f064117eb7 Bug 1134006 - Avoid IPC for domElement.QueryInterface(nsISupports) and nsIClassInfo. r=billm 2015-03-09 15:01:00 +01:00
Boris Zbarsky
7f7b76aa0c Bug 1140573 part 1. Drop the parent argument from JS_NewFunction. r=waldo 2015-03-09 12:50:03 -04:00
Jason Orendorff
e218a3988f Bug 1113369, part 7 - [[SetPrototypeOf]] ObjectOpResult support. r=Waldo, r=bz in dom, r=dvander in js/ipc, r=bholley in js/xpconnect. 2015-02-05 16:36:50 -06:00
Jason Orendorff
3322381e4f Bug 1113369, part 6 - [[PreventExtensions]] ObjectOpResult support. r=Waldo, r=bz in dom, r=dvander in js/ipc, r=bholley in js/xpconnect. 2015-02-04 12:01:01 -06:00
Jason Orendorff
d1204e0adb Bug 1113369, part 5 - [[Delete]] ObjectOpResult support. r=Waldo, r=bz in dom, r=dvander in js/ipc, r=bholley in js/xpconnect. 2015-02-04 10:20:04 -06:00
Jason Orendorff
e065e5cceb Bug 1113369, part 4 - [[Set]] ObjectOpResult support. r=Waldo, r=bz in dom, r=dvander in js/ipc, r=bholley in js/xpconnect. 2015-02-03 19:51:40 -06:00
Jason Orendorff
f43c96af4d Bug 1113369, part 3 - [[DefineOwnProperty]] ObjectOpResult support. r=Waldo, r=bz in dom, r=dvander in js/ipc, r=bholley in js/xpconnect.
Add an ObjectOpResult out-param for DefineProperty functions everywhere. We leave a few js::DefineProperty() convenience functions with no *result out-param. These have strict behavior: that is, they automatically check the result and throw if it is false. In bug 1125624 these strict signatures may end up being called DefinePropertyOrThrow, as that is what the spec calls it.
2015-01-30 11:37:07 -06:00
Jason Orendorff
155abd81e7 Bug 1130576 - Rename JSPropertyOp -> JSGetterOp and JSStrictPropertyOp -> JSSetterOp. r=efaust. 2015-01-30 13:56:15 -06:00
Jan de Mooij
c85567bd32 Bug 1137523 part 2 - Unprefix a few js_* functions I forgot in part 1. r=bhackett 2015-03-03 09:33:22 +01:00
Jan de Mooij
c588ad661c Bug 1137523 - Unprefix most js_* functions. r=bhackett CLOSED TREE 2015-02-27 16:08:15 +01:00
Boris Zbarsky
29c02a7c07 Bug 1136925 part 3. Stop passing parents to js::NewProxyObject. r=waldo 2015-02-26 15:58:59 -05:00
Wes Kocher
bc62dd3b33 Backed out 4 changesets (bug 1136925) for potentially busting m-e10s-dt on a CLOSED TREE
Backed out changeset 331761aaae22 (bug 1136925)
Backed out changeset 2faa0e91fe23 (bug 1136925)
Backed out changeset a00f2530c911 (bug 1136925)
Backed out changeset d5e658bc0792 (bug 1136925)
2015-02-26 23:17:34 -08:00
Wes Kocher
0bcfdb9d36 Backed out changeset d7d9bbfa72c5 (bug 674779) for m-bc orange on a CLOSED TREE 2015-02-26 17:55:37 -08:00
David Rajchenbach-Teller
6180d4f4c6 Bug 674779 - Add per-compartment CPU accounting. r=jandem, r=blassey, r=bz 2015-02-26 11:53:41 +01:00
Boris Zbarsky
e8c2fb81d9 Bug 1136925 part 3. Stop passing parents to js::NewProxyObject. r=waldo 2015-02-26 15:58:59 -05:00
Tom Schuster
c5a7857326 Bug 1127475 - Remove unnecessary parent arguments. r=bz 2015-02-13 12:20:02 +01:00
Tom Schuster
b4b0e6daa3 Bug 1125437 - Remove CheckDefineProperty and use StandardDefineProperty instead. r=efaust 2015-02-11 23:40:47 +01:00
Tom Schuster
8f3890f934 Bug 1131003 - Move jsproxy.h to js/Proxy.h. r=efaust
--HG--
rename : js/src/jsproxy.h => js/public/Proxy.h
2015-02-10 19:58:18 +01:00
Gabor Krizsanits
df3314aad3 Bug 1090592 - GetPrototypeOf hook for CPOWProxyHandler. r=billm 2015-02-10 16:29:41 +01:00
Bill McCloskey
144291b5ce Bug 1123461 - Rename CpowIdHolder to CrossProcessCpowHolder (r=dvander) 2015-01-26 13:32:31 -08:00
Bill McCloskey
411974faf9 Bug 1123461 - Make a real interface for js/ipc (r=dvander) 2015-01-26 13:32:18 -08:00
Tom Schuster
8875fc0ed6 Bug 1125356 - Use JS_NewPlainObject in the browser. r=bz 2015-01-24 16:38:08 +01:00
Wes Kocher
604504d962 Backed out 3 changesets (bug 1123461, bug 1123090) for windows build bustage
Backed out changeset 2c442905d0af (bug 1123461)
Backed out changeset d7aa4c72ebab (bug 1123461)
Backed out changeset 8bb689ec8086 (bug 1123090)
2015-01-22 21:04:33 -08:00
Bill McCloskey
d4364ab812 Bug 1123461 - Rename CpowIdHolder to CrossProcessCpowHolder (r=dvander) 2015-01-22 20:00:19 -08:00
Bill McCloskey
72bdc7e0df Bug 1123461 - Make a real interface for js/ipc (r=dvander) 2015-01-22 20:00:19 -08:00
Kyle Huey
591c252165 Bug 1121673: Use move references in IPDL. r=bent 2015-01-16 11:58:52 -08:00
Bill McCloskey
44582d1bb5 Bug 1119753 - Fix CPOW GC crash (r=jonco) 2015-01-16 09:56:30 -08:00
Peter Van der Beken
408543d91c Bug 1096328 - Remove nativeOwnership from Bindings.conf, templatize deferred finalization. r=bz.
--HG--
extra : rebase_source : 2486e80073d49ffc5ed93676382846fe7c87bd64
2014-11-01 14:48:19 +01:00
Ehsan Akhgari
7b8691121b Bug 1119265 - Mark virtual overridden functions as MOZ_OVERRIDE in JS IPC; r=billm 2015-01-08 23:10:41 -05:00
Chris Peterson
96586f375e Bug 1115477 - Fix -Wunused and -Wtype-limits warnings in js/src. r=jandem 2014-12-24 21:06:21 -08:00
Bill McCloskey
2dfcf804fc Bug 1102640 - [e10s] Shouldn't be able to create CPOWs to the inner window (r=mrbkap) 2014-12-18 17:34:24 -08:00
Bill McCloskey
52d9ccaf3d Bug 1102637 - [e10s] Control CPOW logging with env var (r=mrbkap) 2014-12-18 17:34:24 -08:00
Bill McCloskey
21e71d7986 Bug 1102637 - [e10s] Log the address of objects sent using CPOWs (r=mrbkap) 2014-12-18 17:34:24 -08:00
Tom Schuster
f64a27048c Bug 1094176 - Remove lookup API from browser. r=bholley 2014-12-17 00:28:39 +01:00
Tom Schuster
a135bf8d75 Bug 783829 - Remove getEnumerablePropertyKeys. r=efaust,bholley 2014-12-17 00:28:38 +01:00
Tom Schuster
71db988913 Bug 783829 - Change from Proxy iterate to enumerate. r=efaust,bholley 2014-12-17 00:28:38 +01:00
Jason Orendorff
3adebb6c77 Bug 1103368, part 5 - Make Class::getProperty and setProperty nullable instead of needing stub functions. Never store stub functions in JSPropertyDescriptors. r=bhackett.
--HG--
extra : rebase_source : a44070dd6155426ef6026c1575116f90b5fdac0c
extra : amend_source : 8d8fcf05dfd5fdf214a39501663347a6d6b56463
2014-11-22 12:23:39 -06:00
Jason Orendorff
734d01443d Bug 1103368, part 4 - Ban stub getter/setter arguments to js::CheckDefineProperty. r=bhackett.
--HG--
extra : rebase_source : 407e9adaca3ee23e768f750cd84a0a8f3432e2fa
2014-11-22 08:43:56 -06:00
Brad Lassey
1f3bac026c bug 1104160 - crash in CPOWTimer::~CPOWTimer() r=billm 2014-11-25 13:04:07 -05:00
Bobby Holley
26fc283b27 Bug 1102521 - Use AutoEntryScript/AutoJSAPI for CPOW answers. r=billm 2014-11-23 15:23:21 -08:00
Brad Lassey
9be6642203 bug 1074567 - measure time spent processing in sync CPOW calls per compartment r=bholley,billm
* * *
try: -b do -p linux64-b2g-haz -u none
2014-11-19 18:54:34 -05:00
Tom Schuster
5775dbcbf7 Bug 783829 - Rename Proxy enumerate trap to getEnumerablePropertyKeys. r=efaust 2014-11-14 16:21:12 +01:00
Bill McCloskey
3f3dd80fb9 Bug 1091964 - Avoid spurious rooting hazard on a CLOSED TREE 2014-11-05 17:52:38 -08:00
Bill McCloskey
a4186ac75a Bug 1091970 - [e10s] Cache object tag in add-on shims for remote objects (r=mrbkap) 2014-11-04 17:40:08 -08:00