I added these to BrowserApp to match the use of Adjust.onCreate in BrowserApp.
These sessions don't perfectly match the FHR sessions they replace which get
called in:
GeckoApp.onPause (session end)
BrowserHealthRecorder.onEnvironmentTransition (session end)
BrowserHealthRecorder.checkForOrphanSessions (session start)
- From BHR.initializeStorage <- BHR.handleMessage. I didn't figure out
where this message comes from but given "initializeStorage", I assume
this comes from a startup routine of GeckoApp.
However, the Adjust docs are explicit about adding these values to
onPause/onResume and presumably written under the assumption that those methods
are called in the appropriate places.
The docs also mention these calls should occur in all Activities but I followed
FHR where only the main Activity is logged - I don't predict any negative side
effects from this change.
AppCompat capitalizes all text in `Button`s so we have to override
that behavior to maintain the same UI. Ideally, we do this through
`android:buttonStyle` but the place I found the issue doesn't inherit
from that style so we can't and we change the style directly.
There may be issues with other `Button`s, but this is the only one I found.
We're using the Theme.AppCompat styles so we have to extend AppCompatActivity.
It is a subclass of the previous class GeckoApp extended so we shouldn't run
into an ClassCastExceptions.
I tested the home panels, tabs tray, hyperlink long-press context menus,
door hangers, the 3-dot menu, and browser search to make sure there was no
change in UI appearance.
AppCompat capitalizes all text in `Button`s so we have to override
that behavior to maintain the same UI. Ideally, we do this through
`android:buttonStyle` but the place I found the issue doesn't inherit
from that style so we can't and we change the style directly.
There may be issues with other `Button`s, but this is the only one I found.
We're using the Theme.AppCompat styles so we have to extend AppCompatActivity.
It is a subclass of the previous class GeckoApp extended so we shouldn't run
into an ClassCastExceptions.
I tested the home panels, tabs tray, hyperlink long-press context menus,
door hangers, the 3-dot menu, and browser search to make sure there was no
change in UI appearance.
DONTBUILD NPOTB
The top source directory configuration requires
mobile/android/gradle/m2repo/**, so it stays. There's no value
changing the location; it contains an Android-specific Gradle plugin.
We note the removal of |mach gradle-install| and point to the new
documentation.
There is no noticeable difference in background color of the menu on my 4.* GS4
or my 2.3 Nexus S, though perhaps it affects more than the menu.
The menu_panel_bg drawable is now unused so I removed that too.
This required us to use the menu button to open the menu and check
if the menu is open by looking at more menu items due to intermittent
issues where the menu would not always be scrolled to the top (I
think Robotium scrolled the menu before it finished appearing so
we couldn't see the first item and failed the isOpen test).
We added some Asserts but the robocop tests fail for an unknown reason. The
error was:
E/MessageQueue-JNI( 1972): java.lang.IllegalAccessError: Class ref in pre-verified class resolved to unexpected implementation
I tried a few things but in the end just decided to remove them.
This required us to use the custom menu inflater and panels on GB.
One side effect of this change is that the menu button no longer
closes the menu on GB. I tried to fix this but BrowserApp.onKeyDown
is not fired when the menu is open on GB and I'm not sure why that
is. However, I don't think it's worth my time to fix since it's GB.
We send query text events when flushing IME changes, and sometimes these
events make Gecko commit more pending changes. In that case, we should
try flushing again, so we pick up the new changes.
This patch also makes the process of flushing text changes
transactional, so that if we have to bail due to more pending changes,
nothing will be committed.
This patch adds a test for triggering re-flushing IME changes to
testInputConnection, by ending a composition followed by setting the
value of the input field.
A test for this bug requires the Robocop test call some JS functions.
This patch gives testInputConnection the ability to make calls to
content JS. It also converts the existing tests to use JS instead of
using previous workarounds (e.g. using URL hash to set the initial text,
using tab key to change input focus).
