wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity
215,376 Commits 1 Branch 166 Tags 1.2 GiB
87ee06b2a4
Commit Graph

2158 Commits

Author SHA1 Message Date
Shigeki Ohtsu
55c24f6b7c Bug 1051982 - fix integer prefix to encode Header Table Size Update r=hurley 2014-08-12 09:31:26 +09:00
Michael Wu
58f9bd9241 Bug 1036394 - Add support for getting the zip entry from the jar channel, r=jduell 2014-08-04 11:54:28 -04:00
Dragana Damjanovic
29ae85f646 Bug 1043256 - If unKnownDecoder needs to be used, Content_Encodings will be loaded before OnStartRequest is called on the listener. This makes an error in e10s because Content_Encodings will be loaded before HttpChannelParent can disable them. r=bagder 2014-08-13 10:52:00 -04:00
Nicholas Nethercote
8c60d14a1a Bug 1050009 - Initialize pldhash tables with a length, not a capacity. r=roc. 
* * *
imported patch rm-dummy-params

--HG--
extra : rebase_source : c25987eb11bae197218d5fc53b77def19afa36ac
 2014-08-06 06:31:21 -07:00
Nicholas Hurley
bd47f77470 Bug 1046892 part 1 - HTTP/2 draft 14 client implementation r=mcmanus 2014-08-05 08:41:09 -07:00
Jeremy Poulin
a70b8ed90e Bug 1020419 - Extend nsHttpChannel to skip validation for IsForcedValid. r=michal 2014-07-18 11:52:30 -07:00
Ehsan Akhgari
7207465c1b Bug 1047782 - Fix some bad impliciit constructors in netwerk/; r=mcmanus 2014-08-05 09:20:50 -04:00
Ehsan Akhgari
77dfc12d57 Bug 1048271 - Fix more bad implicit constructors in netwerk; r=mcmanus 2014-08-05 09:20:24 -04:00
Patrick McManus
49dc4df69c bug 1027720 - enforce h2 requirement that sever uses aead r=hurley r=dkeeler 2014-08-04 16:54:10 -04:00
Patrick McManus
2a6917939a bug 1047698 - reorder alpn/npn offer lists r=hurley 2014-08-04 16:54:08 -04:00
Ryan VanderMeulen
f8e5caee0f Merge inbound to m-c on a CLOSED TREE. a=merge 2014-08-04 16:06:19 -04:00
Ethan Tseng
d5e2bf4155 Bug 1038046 - [RTSP] RTSP cannot play some H263 video streaming. r=sworkman 2014-07-30 22:59:08 +08:00
Dragana Damjanovic
6a9806b987 Bug 1007020 - Also send progress information when connection is LOAD_BACKGROUND. r=bz 2014-08-01 02:10:00 -04:00
Ed Morley
70fd63dbf8 Backed out changeset 972daa5dd3c5 (bug 1027720) for build failures 2014-08-04 14:33:14 +01:00
Patrick McManus
14ff8aa315 bug 1027720 - enforce h2 requirement that sever uses aead r=hurley r=dkeeler 2014-08-01 16:59:00 -04:00
Patrick McManus
a2300b7795 bug 1043402 - spdy/h2 ce errors should be stream local r=hurley 2014-08-01 16:31:41 -04:00
Patrick McManus
7a1103a065 bug 1047474 - spdy/h2 dispatch with shift-reload sometimes sticks r=hurley 2014-08-01 12:11:02 -04:00
Ryan VanderMeulen
c8904618ee Backed out changeset 0b900c9e0940 (bug 1038046) for Wasabi bustage. a=backout 2014-08-01 15:40:53 -04:00
Ethan Tseng
f958802821 Bug 1038046 - [RTSP] RTSP cannot play some H263 video streaming. r=sworkman 2014-07-30 22:59:08 +08:00
Ethan Tseng
3156eb2288 Bug 1038037 - B2G crash when opening malformed MP4A-LATM audio streaming over RTSP. r=sworkman 2014-07-24 23:21:25 +08:00
Oleg Romashin
30a5c9e2bd Bug 966814 - Build with disabled X11 on linux failing to compile. r=ted 2014-07-29 19:21:08 +02:00
Mike Hommey
20d181268e Bug 1043820 - Remove PARALLEL_DIRS. r=gps 2014-07-29 08:57:59 +09:00
Patrick McManus
b1fdba12bd bug 1041272 - websockets partial last frame stall r=jduell 2014-07-25 20:37:02 -04:00
Patrick McManus
8d789efedf Bug 354493 - revert Add nsINetworkZonePolicy to protect resources loaded from private IPs r=backout a=backout 2014-07-24 10:05:36 -04:00
Patrick McManus
88c58d592b bug 1040930 - part 4 wss over https proxying r=hurley 
--HG--
extra : rebase_source : 1e115e22468e7df06a2ca407bbcfd7e92f5a649a
 2014-07-18 14:59:01 -04:00
Patrick McManus
c72aa3b293 bug 1040930 - part 3 https is a transaction property not a connection property r=hurley 
--HG--
extra : rebase_source : dff8ea4b4e6f55f9e8dff99700400890b4492a31
 2014-07-17 20:52:23 -04:00
Ben Kelly
2d74adee1a Bug 1029620 P4 Make HTTP token and header value validation accessible via nsNetUtil.h r=ehsan r=mcmanus 2014-07-24 12:38:55 -04:00
Mike Hommey
d10b15b035 Bug 1041860 - Avoid setting FINAL_LIBRARY to libraries that further use a FINAL_LIBRARY. r=mshal 2014-07-23 08:37:51 +09:00
Ethan Tseng
e308a1933d Bug 1026923 - [RTSP] Change the User-Agent string of RTSP client. r=sworkman 2014-07-19 10:49:02 +08:00
Patrick McManus
1dacb7015a bug 1038304 - websockets offline hang r=sworkman 2014-07-17 11:56:38 -04:00
Steve Workman
793520eac4 Bug 354493 - Add nsINetworkZonePolicy to protect resources loaded from private IPs r=mcmanus 2014-07-17 11:08:20 -07:00
Shian-Yow Wu
63d29bd74a Bug 988816 - Support multiple OpenNSPRFileOpen() on RemoteOpenFile. r=aklotz, jduell 2014-07-18 10:46:22 +08:00
Patrick McManus
79840fddcb Bug 1039776 - http response version telemetry r=sworkman 2014-07-17 21:54:04 -04:00
Wes Kocher
9ad6223bc1 Merge inbound to m-c a=merge 2014-07-16 17:08:26 -07:00
Carsten "Tomcat" Book
8bcfa7bb61 Merge mozilla-central to fx-team 2014-07-16 16:01:26 +02:00
Benoit Girard
e7aea75462 Bug 1037691 - Fix instances where refcounted classes expose a public destructor. r=ehsan,bent,mayhemer,jrmuizel 2014-07-15 11:37:45 -04:00
Honza Bambas
6e3e816527 Bug 1009531 - Failing to use preloaded cache for hosted applications over https, r=jduell 2014-07-16 16:16:29 +02:00
Jeremy Poulin
894ed6c712 Bug 1037184 - Extended the speculative connection overrider to track predictor preconnects. r=hurley 2014-07-14 11:30:18 -07:00
Tim Taubert
af7f2cb616 Bug 1028187 - Enable IndexedDB for about:looppanel and about:loopconversation, sharing an origin r=bz 2014-07-03 17:16:08 -07:00
Rui You
baac8bbde3 Bug 1037339 - Update nsIHttpChannel.idl to reflect the changes of requestMethod property. r=hurley 2014-07-15 01:36:00 +02:00
Ryan VanderMeulen
ffa2468a1f Merge m-c to inbound. a=merge 2014-07-14 16:19:58 -04:00
Ryan VanderMeulen
28579f0ccd Merge b2g-inbound to m-c. a=merge 2014-07-14 16:17:10 -04:00
Andrew McCreight
77d782bb63 Bug 1038207 - Fix various classes that reimplement nsISupports. r=ehsan 2014-07-14 12:21:34 -07:00
Patrick McManus
52aa907e51 bug 1037082 - part 3/3 407 proxy auth for https over https r=hurley 2014-07-07 11:43:11 -04:00
Patrick McManus
05b64f53db bug 1037082 - part 2/3 407 proxy auth for http over https r=hurley 2014-06-24 16:52:48 -04:00
Patrick McManus
047d57f2c1 bug 1037082 - part 1/3 dont doauthretry with closed persistent connection r=hurley 2014-07-09 18:06:12 -04:00
Dragana Damjanovic
764a21b4be Bug 915024 - Add ForcePending for HttpChannel. r=jduell 2014-07-10 10:13:00 -04:00
Ethan Tseng
18144ac588 Bug 1032065 - RTSP video playback quality is poor if payload type is MP4V-ES. r=sworkman, r=bechen 2014-07-11 17:29:47 +08:00
Nicholas Hurley
ae1c7f98f3 Bug 1014600 part 2 - Properly truncate buffers when processing new header blocks. r=mcmanus 2014-07-11 09:48:34 -07:00
Nicholas Hurley
efe457b7ab Bug 1014600 part 1 - Improve HPACK logging. r=mcmanus 2014-07-11 09:48:32 -07:00
Boris Zbarsky
bdb030720d Bug 965413 part 13. Stop propagating null principal owners across redirects in nsHttpChannel, since we now handle that via loadInfo. r=smaug 2014-07-10 02:56:38 -04:00
Boris Zbarsky
1987b0c856 Bug 965413 part 10. Use a LoadInfo for loading documents in various places where we force a particular principal. r=smaug 2014-07-10 02:56:37 -04:00
Boris Zbarsky
799aef1492 Bug 965413 part 8. Make HTTP redirects propagate along the load info. r=smaug 2014-07-10 02:56:37 -04:00
Boris Zbarsky
da8d201a1f Bug 965413 part 7. Make it safe to GetOwner() and SetOwner() on channels without asserting. r=smaug 
We're going to want to check whether a channel has an existing owner in some cases, but some channels currently assert if you just ask them whether they have an owner.
 2014-07-10 02:56:37 -04:00
Boris Zbarsky
e8aa2f7514 Bug 965413 part 3. Add a .loadInfo property to channels. r=mcmanus 2014-07-10 02:56:36 -04:00
Michal Novotny
c3742f1212 Bug 1013395 - HTTP cache v2: have a limit for write backlog, r=honzab 2014-07-10 07:59:29 +02:00
Wes Kocher
4a69a1eeba Backed out changeset 7b5a6cc2a244 (bug 354493) for frequent intermittent xpcshell oranges 2014-07-09 18:20:54 -07:00
Steve Workman
f80ce043ba Bug 354493 - Add nsINetworkZonePolicy to restrict private resource loads from public networks r=mcmanus 2014-07-09 11:16:39 -07:00
Steve Workman
8b6d2429ab Bug 1036056 - Remove dangerous public destructor of nsFileUploadContentStream r=mcmanus 2014-07-09 11:02:06 -07:00
Patrick McManus
33f50185aa bug 1035993 - spdy sessions threadsafe as nshttpchannel MT refcounts them r=hurley 2014-07-09 11:20:41 -04:00
Benoit Jacob
0895eca019 Bug 1035394 - Fix dangerous public destructors in netwerk - r=mcmanus 2014-07-08 17:23:18 -04:00
Patrick McManus
31329c1ae8 bug 1034918 - nshttptransaction dtor can be private r=sworkman 2014-07-08 12:43:04 -04:00
Patrick McManus
96989188e3 revert bug 1034918 r=backout 
--HG--
extra : rebase_source : 005df8e7a680767c2ebd890d653b623eb31ac552
 2014-07-07 16:16:29 -04:00
Patrick McManus
222bf05494 bug 1034918 - nshttptransaction dtor can be private r=sworkman 2014-07-07 10:40:08 -04:00
Wes Kocher
08588cef30 Backed out 2 changesets (bug 1028187) for mochitest-oth orange 
Backed out changeset 01cba8ff52dd (bug 1028187)
Backed out changeset caf43baf3306 (bug 1028187)
 2014-07-02 17:29:33 -07:00
Tim Taubert
cbb86fdf3f Bug 1028187 - Enable IndexedDB for about:looppanel and about:loopconversation, sharing an origin r=bz 2014-06-28 11:56:06 +02:00
Honza Bambas
c4a894b69d Bug 1018883 - Assertion failure: progress <= progressMax (unexpected progress values), at nsHttpChannel.cpp:5464, with 206 response, r=michal 2014-07-02 18:16:21 +02:00
Nicholas Hurley
6bd9fe0ff7 Bug 1030203 - Send PROTOCOL_ERROR when receiving PUSH_PROMISE with push disabled. r=mcmanus 2014-06-27 13:13:42 -07:00
Steve Workman
ef258ae285 Bug 1024015 - Only enable HTTP response timeout when TCP Keepalives are disabled for HTTP r=mcmanus 2014-06-26 11:03:45 -07:00
Dragana Damjanovic
a025cf6b18 Bug 748117 - Make sure http channel is pending in OnStartRequest & OnDataAvailable r=jduell 2014-06-26 18:51:49 -07:00
Ryan VanderMeulen
3fb7520283 Merge inbound to m-c on a CLOSED TREE. a=merge 2014-06-26 17:13:04 -04:00
Carsten "Tomcat" Book
c481d404e3 Merge mozilla-central to b2g-inbound 2014-06-26 15:58:35 +02:00
Ehsan Akhgari
654864a447 Backed out bug 1023058 because the upstream LLVM bug was fixed. 
Upstream bug: http://llvm.org/bugs/show_bug.cgi?id=19987
 2014-06-25 22:24:49 -07:00
Benjamin Chen
fbb1394204 Bug 1021006 - [RTSP] Browser pops up a network warning message in the end of RTSP streaming. r=sworkman 2014-06-17 17:47:13 +08:00
Andrea Marchesini
417cb89983 Bug 1016352 - WebSocketChannelChild must be thread-safe. r=jduell 2014-06-23 22:43:00 -04:00
Benoit Jacob
4180218bc7 Bug 1028588 - Fix dangerous public destructors in netwerk/ - r=mcmanus 2014-06-24 12:36:44 -04:00
Patrick McManus
926e563e62 bug 1029163 - part 3 tunnel https/h1 over h2 could duplicate bytes in upload and corrupt data r=hurley 2014-06-24 07:56:08 -04:00
Patrick McManus
064aa10644 bug 1029163 - part 2 tlsproxy incomplete upload flushes need to be rescheduled r= hurley 2014-06-24 07:56:07 -04:00
Patrick McManus
3649523288 bug 1029163 - part 1 nsPipe can turn failures into OK, consider that in the tlsproxy code r=hurley 2014-06-24 07:56:07 -04:00
Patrick McManus
6d4aa948ec bug 1027364 - multiple http/2 header frames on same stream r=hurley 2014-06-19 23:42:29 -04:00
Jeremy Poulin
f5bbeec25a Bug 1028426 - Move check for unused speculative connections to where they are removed. r=hurley 2014-06-20 15:17:23 -07:00
Honza Bambas
3972f064c7 Bug 1030426 - network.negotiate-auth.allow-insecure-ntlm-v1-https allows sending NTLMv1 credentials in plain to HTTP proxies, r=mcmanus 2014-06-26 15:08:35 +02:00
Honza Bambas
c3a79a614e Bug 1023748 - Allow NTLMv1 over SSL/TLS by default, r=jduell 2014-06-23 19:43:40 +02:00
Nicholas Hurley
11c5c7db1e Bug 1026609 - HTTP/2 draft 13 part 1 - client implementation. r=mcmanus 2014-06-25 17:33:15 -07:00
Valentin Gosu
375c508db3 Bug 1020539 - clear about:networking hostname list when deleting history r=mcmanus 2014-06-21 04:12:56 +03:00
Daniel Stenberg
e2306dd3e3 Bug 1027353: avoid Http2Session NULL deref. r=hurley 2014-06-18 23:15:00 -04:00
Benoit Jacob
f8aed38cee Bug 1027251 - Fix or whitelist dangerous public destructors in netwerk/ - r=mcmanus 2014-06-20 07:08:24 -04:00
Nicholas Nethercote
39f29c384a Bug 1010064 - Allow memory reports to be anonymized. r=bsmedberg. 
--HG--
extra : rebase_source : 5eb756b17a97e751deb0f47e909fdb35533cb23b
 2014-05-20 23:06:54 -07:00
Jeremy Poulin
7769347d37 Bug 1024639 - Added telemetry tracking for used, total, and unused telemetry connections. r=hurley 2014-06-17 13:35:25 -07:00
Kyle Huey
5b596dc0ff Bug 1024898: Allow (most) nsBaseChannel subclasses to retarget OnDataAvailable to other threads. r=jduell,sworkman 2014-06-17 09:39:26 -07:00
Daniel Stenberg
a29ee21efd Bug 237623 - detect broken HTTP1.1 transfers. r=mcmanus,seth 
Return error when the protocol layer detects a framing error. More data
was supposed to be delivered than what actually did arrive.

Error code returned for this: NS_ERROR_NET_PARTIAL_TRANSFER

In HTTP1.1 for Content-Length: and chunked-encoding underruns

In http2 and SPDY for framing errors when data has already been received.

imgRequest::OnStopRequest will keep partially loaded images shown but
remove them from cache.
 2014-06-09 00:15:00 +02:00
Nicholas Hurley
e1d1268cfc Bug 1025071 - Save header table space by not indexing :path r=mcmanus 2014-06-13 15:02:05 -07:00
Patrick McManus
eee36d8e7d bug 1025075 - http2 CONNECT streams should have consistent priority r=hurley 
---
 netwerk/protocol/http/Http2Session.cpp  | 3 ++-
 netwerk/protocol/http/SpdySession3.cpp  | 3 ++-
 netwerk/protocol/http/SpdySession31.cpp | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

---
 netwerk/protocol/http/Http2Session.cpp  | 3 ++-
 netwerk/protocol/http/SpdySession3.cpp  | 3 ++-
 netwerk/protocol/http/SpdySession31.cpp | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)
 2014-06-13 09:29:00 -04:00
Ethan Tseng
e9a798f62a Bug 1021890 - [RTSP] Compiler warning - character constant too long in RTSPConnectionHandler.h. r=sworkman 2014-06-10 15:36:46 +08:00
"Kan-Ru Chen (陳侃如)"
8019b23d50 Bug 879475 - Part 006. Fix http auth prompts for nested content processes r=honzab 
Based on original patch by David Zbarsky <dzbarsky@gmail.com>
 2014-06-11 13:44:36 +08:00
Jeff Muizelaar
5d2a4b8817 Bug 1022049. Switch to <intrin.h>. r=nfroyd 
Instead of declaring these ourselves just use intrin.h
This has the advantage of allowing them to work with clang-cl

--HG--
extra : rebase_source : b78c756edb5dcdf1fd9127ad5e1a7ae183e72e3c
 2014-06-09 17:26:55 -04:00
Patrick McManus
7a06049ac4 bug 1022076 - http/2 explicit gzip for post h2-12 r=hurley 
bug 1022076 - http/2 explicit gzip for post h2-12 r=hurley

--HG--
extra : rebase_source : 8603c97c9ed664520e748ebba405e6a1bce6b3e8
 2014-06-06 19:18:00 -04:00
Patrick McManus
5eb912a5c5 bug 1021396 - duplicate spdy syn_stream can hang necko thread r=hurley 
bug 1021396 - duplicate spdy syn_stream can hang necko thread r=hurley

--HG--
extra : rebase_source : caf1ad18fced8e9c7ef78c1eccbfb2dec2d6181c
 2014-06-06 11:18:00 -04:00
Patrick McManus
5076fc930a bug 1022195 - http2 allow indexing of cookie crumbs with decent entropy r=hurley 
--HG--
extra : rebase_source : fb48d4aaf4d81007ac5532f493a87babb23257f7
 2014-06-07 11:54:38 -04:00
Ryan VanderMeulen
d277adb90b Merge m-c to b2g-inbound. a=merge 2014-06-06 17:34:22 -04:00
Ethan Tseng
395bed4bb7 Bug 1020379 - [RTSP] Fix trivial compile warnings. r=sworkman 2014-06-06 11:28:45 +08:00
Ethan Tseng
df66611f95 Bug 1020379 - [RTSP] Fix potential infinite loop in ARTPConnection.cpp. r=sworkman 2014-06-06 10:59:47 +08:00
Nicholas Hurley
f875e6894a Bug 1019918 - Remove pushed stream from SpdyPushCache when cleaning it up. r=mcmanus 
--HG--
extra : rebase_source : 2c1c23668adf041eb27c8f0509aebfbfab9497ca
 2014-06-04 15:37:00 -04:00
Valentin Gosu
5dedb5bf3f Bug 1006575 - Redirected iframe inserts 2 entries into resource timing buffer 2014-06-05 22:24:47 +03:00
Patrick McManus
5c9442b6f0 bug 1003566 - part 1 - allowSTS attribute to nsIHttpChannel r=honzab 2014-06-04 09:57:15 -07:00
Nicholas Hurley
dc01333be4 Bug 1019921 - [http/2] Don't change to discarding padding state when all padding has been processed. r=mcmanus 2014-06-03 19:41:26 -07:00
Valentin Gosu
7300110fdb Bug 983243 - WSS WebSocket leaks TCP/IP connection if closed prematurely r=mcmanus 
Prevent WebSocketChannel::OnTransportAvailable from reinitializing the channel's references after it has been closed.
 2014-06-04 02:15:14 +03:00
Nicholas Hurley
1345f7f10b Bug 1019577 - Always make room in the table before emitting an entry. r=mcmanus 2014-06-03 13:09:08 -07:00
Robert O'Callahan
9170085906 Bug 1015664. Part 1: Remove NS_HIDDEN_() usage. r=bsmedberg 2014-06-03 00:08:21 +12:00
Phil Ringnalda
61966eed95 Merge f-t to m-c 2014-05-31 20:31:07 -07:00
Victor Porof
5643294005 Bug 1007203 - Always add categories when pushing to the pseudostack, r=djvj 2014-05-23 17:12:29 -04:00
David Fifield
1d3720fb4e Bug 1017769 - Make the CONNECT Host header the same as the Request-URI. r=mcmanus 
It's possible to construct a request where the Host header differs from
the authority in the URL, for example in an extension with
nsIHttpChannel and setRequestHeader. MakeConnectString generates a
host:port string for the CONNECT Request-Line, but peeks into the
tunneled request in order to copy the Host header to the proxy request.

Instead, use the same host:port string for Host as is used in the
Request-URI, to avoid revealing the plaintext of the Host header outside
of the tunnel.
 2014-05-29 11:01:02 -07:00
Bob Owen
ea60bbce24 Bug 985135 - When owner is a null principal, propagate to replacement channel on redirect. r=bz 2014-05-28 15:04:04 +01:00
Nicholas Hurley
cb23e52576 Bug 1017692 - More logging for HPACK. r=mcmanus 2014-05-30 16:16:23 -07:00
Wes Kocher
80e3272ce0 Merge b2g-inbound to m-c 2014-05-29 17:44:25 -07:00
Ryan VanderMeulen
68a976dd72 Merge m-c to b2g-inbound. 2014-05-29 14:36:11 -04:00
Honza Bambas
87a7dbe8fd Bug 1017636 - Remove all conditional request headers when cache entry's sec-info or input fails to open. r=mcmanus 2014-05-29 19:42:33 +02:00
Ethan Tseng
e0568ee193 Bug 1015169 - Cannot play RTSP streaming after reloading web page. r=vchang 2014-05-27 16:49:34 +08:00
Monica Chew
3f0f699d9c Bug 974018: Implement nsIRedirectHistory (r=mayhemer) 2014-05-22 12:58:23 -07:00
Patrick McManus
8c23b34502 bug 1014589 - problem with https proxying and http pipelines r=hurley 
--HG--
extra : rebase_source : 7c4f9f80d37102baa8951961d54b6ff842a19afb
 2014-05-22 17:49:04 -04:00
Birunthan Mohanathas
f9b1b35c3e Bug 869836 - Part 11: Use Append('c') instead of AppendLiteral("c"). r=ehsan 
--HG--
extra : rebase_source : 08bcbfd804f1adcab40c7d59fa56deda1f6e0829
 2014-05-26 21:54:58 +03:00
Carsten "Tomcat" Book
c509721e94 merge b2g-inbound to mozilla-central 2014-05-26 15:26:11 +02:00
Ethan Tseng
6b62d29960 Bug 1009497 - Crash happened while device plays MP3 stream over RTSP. r=sworkman 2014-05-23 11:37:18 +08:00
Vincent Chang
36031f56d3 Bug 1006484 - [RTSP][V2.0] Cannot replay RTSP streaming. r=sworkman 2014-05-22 10:11:38 +08:00
Carsten "Tomcat" Book
57c5c82667 merge b2g-inbound to mozilla-central 2014-05-22 15:21:43 +02:00
Wes Kocher
5ac095d953 Merge m-c to b2g-inbound 2014-05-21 20:38:07 -07:00
Birunthan Mohanathas
76ca8ec617 Bug 869836 - Part 7: Use AppendLiteral instead of Append where possible. r=ehsan 2014-05-22 06:48:51 +03:00
Birunthan Mohanathas
c4568a7085 Bug 869836 - Part 6: Use EqualsLiteral instead of Equals where possible. r=ehsan 2014-05-22 06:48:51 +03:00
Birunthan Mohanathas
e2a009d822 Bug 869836 - Part 5: Use AssignLiteral instead of Assign where possible. r=ehsan 2014-05-22 06:48:51 +03:00
Birunthan Mohanathas
807e72372f Bug 869836 - Part 4: Use EqualsLiteral instead of Equals(NS_LITERAL_STRING(...)). r=ehsan 2014-05-22 06:48:51 +03:00
Birunthan Mohanathas
62570a8716 Bug 869836 - Part 2: Use AppendLiteral instead of Append(NS_LITERAL_STRING(...)). r=ehsan 2014-05-22 06:48:50 +03:00
Birunthan Mohanathas
5d51a7d58f Bug 869836 - Part 1: Use EqualsLiteral instead of == NS_LITERAL_STRING(...). r=ehsan 2014-05-22 06:48:50 +03:00
Honza Bambas
05454905d8 Bug 779899 - Move nsHttpChannel::CreateNewURI to a different place in the file, r=mcmanus 2014-05-21 23:42:08 +02:00
Patrick McManus
566a392ad9 bug 1013934 - NS_ERROR_CORRUPTED_CONTENT should be a stream local error in http2 r=hurley 2014-05-21 14:09:48 -04:00
Patrick McManus
c095e081f4 bug 1013623 - make nsHttpPipeline.mConnection a smart pointer r=hurley 2014-05-21 10:01:56 -04:00
Wes Kocher
64c4381b8e Merge m-c to inbound 2014-05-23 17:37:56 -07:00
Kyle Huey
8a1ded0d50 Bug 996133: Remove unnecessary NS_DISPATCH_NORMAL arguments to NS_DispatchToMainThread. r=ehsan 2014-05-23 12:53:17 -07:00
Vincent Chang
249de385e8 Bug 951278 - [RTSP][V1.3] The RTSP streaming always stops at the last 1st or 2nd second. r=sworkman 2014-03-18 14:30:51 +08:00
Honza Bambas
1993caee58 Bug 1017636 - Remove all conditional request headers when cache entry's sec-info or input fails to open, r=mcmanus, a=ryanvm on a CLOSED TREE 2014-05-29 19:42:33 +02:00
Doug Turner
7a046ac045 Bug 995430 - send header when user is signed into a children\'s account. r=mcmanus 2014-05-05 14:30:42 -07:00
Patrick McManus
3794ffe8c0 bug 1012827 - release https proxy connect serialization earlier r=hurley 2014-05-19 15:37:58 -04:00
Patrick McManus
ab3d1b6589 bug 1012825 - https proxying over http/2 connect stream r=hurley 2014-05-19 15:37:35 -04:00
Trevor Saunders
4abce4092c bug 1004746 - part 1 - Remove a bunch of usage of nsAutoPtr's copy ctor r=froydnj 2014-05-07 18:05:37 -04:00
Honza Bambas
3ea4ce8b03 Bug 998608 - Intermittent netwerk/test/unit/test_range_requests.js | request reports itself as not pending from onDataAvailable, r=michal 2014-05-17 15:38:50 +02:00
Ryan VanderMeulen
6b74e5a464 Merge m-c to inbound. 2014-05-16 15:28:18 -04:00
Patrick McManus
653d8ee125 bug 378637 part 15 - pipeline::setconnection(nullptr) is never assertable r=hurley 
--HG--
extra : rebase_source : e408216599be91fa3c33e84fa3ef41c0d93b8d7d
 2014-05-16 11:46:13 -04:00
Patrick McManus
86f1d898a3 bug 378637 part 14 - https proxying for spdy31 and http2 r=hurley 
--HG--
extra : rebase_source : 03a62d69b08f725c85f092b182a95de9c4eb7288
 2014-05-16 11:46:13 -04:00
Patrick McManus
8b977b2f91 bug 378637 part 13 - https proxying changes to casting and trans lifecycle r=hurley 
--HG--
extra : rebase_source : 9ba1d5a5c97e6fb42956433dd6738cbec0e8e90c
 2014-05-16 11:46:12 -04:00
Carsten "Tomcat" Book
b901a51d16 Merge mozilla-central to b2g-inbound 2014-05-16 14:35:35 +02:00
Ethan Tseng
5de2d6c622 Bug 996765 - [RTSP] Support TCP-interleaved RTP transport. r=sworkman 2014-05-12 16:27:07 +08:00
Wes Kocher
202d548b78 Merge inbound to m-c 2014-05-15 15:59:45 -07:00
John Shih
3661153c3f Bug 966625 - Make RTSP be tracked by NetworkActivityMonitor. r=sworkman 
--HG--
extra : rebase_source : 526906c9e13236acb8356018c6994d5f357f3cdd
 2014-05-13 16:51:58 +08:00
Daniel Stenberg
21d61134ab Bug 1007024 - CopyAsNetwork32 inserts 32bit network byte order values. r=mcmanus 
CopyAsNetwork32 is a convenience function to make the PR_htonl() +
memcpy use in the code less repetitive.
 2014-05-14 01:01:00 +02:00
Patrick McManus
7b65ad0857 bug 378637 part 12 - proxy over TLS (i.e. https proxying) r=hurley 
--HG--
extra : rebase_source : 85b4f6b3eb1a3977ff888fa70214055a41f72da5
 2014-04-16 09:52:43 -04:00
Patrick McManus
34bfbf073e bug 378637 part 11 - move MakeConnectString() to nsHttpHandler r=hurley 
--HG--
extra : rebase_source : 683d8c5203a17d8869bbce0bbdaeee0dc683442a
 2014-04-22 15:46:06 -04:00
Patrick McManus
57ed828988 bug 378637 part 10 - implement nsAHttpTransaction::ConnectionInfo r=hurley 
--HG--
extra : rebase_source : b4b955c652b14e750013130428b71e2e308fead3
 2014-04-20 12:01:35 -04:00
Patrick McManus
94d5eb9b05 bug 378637 part 9 - https proxy info added to connection info and reqeuest head r=hurley 
--HG--
extra : rebase_source : 30bfa9973c18e2a53ece4ea5056b38c151f49cf0
 2014-04-16 09:23:20 -04:00
Patrick McManus
e43fc836b0 bug 378637 part 7 - new spdysession() no longer takes first transaction r=hurley 
--HG--
extra : rebase_source : af83fcffa83f1da4250b0a9528e148619f9e3838
 2014-05-16 11:46:11 -04:00
Patrick McManus
8dbfa21bc9 bug 378637 part 6 - implement nsAHttpTransaction::QueryHttpTransaction r=hurley 
--HG--
extra : rebase_source : d2981bb9e47cf9a8f6d038a0c6db6a85f3170f97
 2014-04-15 17:40:23 -04:00
Patrick McManus
f8efbbee1e bug 378637 part 5 - move Spdy*::EnsureBuffer to nsHttp r=hurley 
--HG--
extra : rebase_source : 147ffb4842069ac7531e99d7decb9362a2566556
 2014-04-15 17:06:59 -04:00
Patrick McManus
ce4dbb322c bug 378637 part 4 - more proactive failed to connect detection in nsHttpConnection r=hurley 
--HG--
extra : rebase_source : 65004f57b9c464f03050a8597b28a678c6ca8f47
 2014-04-02 17:26:58 -04:00
Patrick McManus
f8a53af3a1 bug 378637 part 3 - fix http style: comments, whitespace, formatters r=hurley 
--HG--
extra : rebase_source : 9d2b0692298fca2655023b3bc6295386a96625e6
 2014-04-17 19:55:04 -04:00
Patrick McManus
9d67ad9905 bug 378637 part 2 - change some stack nscstrings to spdystream* autocstring r=hurley 
--HG--
extra : rebase_source : 9b88e9c875416576c8770e1b1f1d6de8b2402ac5
 2014-04-25 16:01:23 -04:00
Patrick McManus
adcb4acc71 bug 378637 part 1 - add leak detection macros to http classes r=hurley 
--HG--
extra : rebase_source : c846cba060509be22a2a3387929ffa724dba7f40
 2014-04-21 08:54:07 -04:00
Ryan VanderMeulen
96ed00e142 Revert to revision 63dfac3c9c87 due to mass bustage pile-ups that landed after it on a CLOSED TREE. 2014-05-16 12:29:37 -04:00
Honza Bambas
f801eecbce Bug 998608 - Intermittent netwerk/test/unit/test_range_requests.js | request reports itself as not pending from onDataAvailable!, r=michal 2014-05-16 17:13:04 +02:00
Shian-Yow Wu
19422a5329 Bug 945152 - Part 3-1: New libjar APIs. r=aklotz 2014-05-16 13:34:43 +08:00
Nicholas Hurley
19786453ec Bug 1006804 - Enforce TLS key type and size restrictions in HTTP/2. r=mcmanus. 2014-05-14 10:37:05 -07:00
Sylvestre Ledru
2a9f2685ae Bug 1003929: Remove some useless declarations in netwerk/protocol/ found by scan-build, the LLVM/Clang static analyzer. r=mcmanus 2014-05-13 17:18:20 +02:00
Ethan Tseng
d70b412bb4 Bug 1007577 - [RTSP] Remove nsIInterfaceRequestor from RtspControllerParent. r=sworkman 2014-05-09 15:08:09 +08:00
Ethan Tseng
668e2a70b7 Bug 1006530 - Closing a audio RTSP streaming via tab page causes system crash. r=sworkman 2014-05-08 16:16:11 +08:00
Carsten "Tomcat" Book
42f044ab31 Merge mozilla-central to b2g-i 2014-05-09 14:20:02 +02:00
John Shih
15c1be4a21 Bug 996535 - Convert linux socket to NSPR/PRFileDesc. r=sworkman 2014-04-15 14:39:57 +08:00
Neil Rashbrook
f9520ae677 Bug 514280 Only use nsCOMPtr for interfaces r=bsmedberg 2014-05-08 20:08:38 +01:00
Daniel Stenberg
8062d4e1da Bug 1007029 - GenerateGoAway: Remove pointless memset(). r=mcmanus 2014-05-08 09:27:00 -04:00
Robert O'Callahan
949537330f Bug 1006248. Part 1: Add MOZ_EXPORT in various places. r=glandium 
--HG--
extra : rebase_source : cfe209a412cae28d405eae413415cebb6959072a
 2014-05-06 17:26:46 +12:00
Bobby Holley
7c7704aa07 Bug 1052052 - Hoist Auto*JSContext into nsContentUtils and kill nsCxPusher.{cpp,h}. r=gabor 2014-08-14 18:47:15 -07:00
Ryan VanderMeulen
7c3098f03b Backed out changesets 5b1a3161f614, 17a9673ed782, and a9b8c346d295 (bug 1052052) for B2G non-unified bustage. 2014-08-14 17:23:10 -04:00
Bobby Holley
e5da39b71b Bug 1052052 - Hoist Auto*JSContext into nsContentUtils and kill nsCxPusher.{cpp,h}. r=gabor 2014-08-14 12:54:34 -07:00
Daniel Stenberg
e1333d42f7 Bug 1005821 - http2: store streamID on correct index within frame. r=hurley 
Http2Session::GenerateGoAway() inserts the 'mOutgoingGoAwayID' at index
7 while the comment (and the current http2 spec draft-12) says it should
be at index 8.
 2014-05-05 10:58:00 +02:00
Ed Morley
8bc370d126 Merge mozilla-central and inbound 2014-05-01 16:23:05 +01:00
Ed Morley
9ce0855816 Merge latest green inbound changeset and mozilla-central; r=khuey to work around bug 1002652 comment 13 2014-05-01 15:49:37 +01:00
Honza Bambas
3c1571370b Bug 916052 - Adapt about:cache to the HTTP cache v2 API, r=michal+MattN 2014-05-01 13:28:12 +02:00
Patrick McManus
f17cec63b3 bug 1003935 - call dontreuse() on reclaimed conns with transaction refs r=sworkman 2014-04-30 13:15:46 -04:00
Nicholas Hurley
babf542f3f Bug 1003320 - Send HPACK buffer size updates when receiving SETTINGS_HEADER_TABLE_SIZE. r=mcmanus 2014-04-29 18:46:07 -07:00
Nicholas Hurley
38835efd4e Bug 1001022 part 1 - http/2 draft 12 client implementation. r=mcmanus 2014-04-29 18:46:03 -07:00
Nicholas Hurley
0f06849f17 Bug 993037 (part 1) - http/2 draft 11 client implementation. r=mcmanus 2014-04-29 18:45:59 -07:00
Nathan Froyd
4c20a67b0d Bug 1003306 - part 2 - use services::GetPermissionManager everywhere that's appropriate; r=ehsan 2014-04-29 13:27:26 -04:00
Honza Bambas
e0a27b1b69 Backing out bug 916052 (2557b51a47a0) for build bustage on linux/osx, r=bustage on CLOSED TREE 2014-04-30 13:05:43 +02:00
Honza Bambas
31fe98bfc2 Bug 916052 - Adapt about:cache to the HTTP cache v2 API, r=michal+MattN 2014-04-30 12:39:18 +02:00
Birunthan Mohanathas
ff8ce9bd42 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
R Kent James
0b0934ea1c Bug 698730 - Add username to connection cache hash so NTLM gets correct connection, r=mcmanus 2014-04-26 12:01:39 -07:00
Honza Bambas
cd415d3c36 Bug 913810 - make nsHttpChannel properly react to FILE_NOT_FOUND from the cache, r=michal 2014-04-26 18:42:07 +02:00
Wes Kocher
20d24e2d94 Merge inbound to m-c 2014-04-22 17:54:44 -07:00
Ethan Tseng
5f43c64159 Bug 992568 - Part 2: Refactor RtspChannel to support redirection. r=sworkman 2014-04-03 19:08:34 +08:00
Makoto Kato
a3c69f7ea9 Bug 26767 - FTP client detects UTF-8 if server returns UTF8 on FEAT. r=michal.novotny 2014-04-23 01:12:58 +09:00
Valentin Gosu
dc77147231 Bug 822480 - Fix e10s bits of Resource Timing implementation. r=bz, r=honzab 
* Move nsITimedChannel to HttpBaseChannel which is inherited by HttpChannelChild
* Return mZeroTime instead of 0 in nsPerformanceTiming
* Pass redirect count from parent to child channel
 2014-04-21 09:34:33 -04:00
Adrian Lungu
ad51575296 Bug 822480 - Add in the Resource Timing API. r=honzab, r=jst 2013-10-15 18:35:44 -07:00
Patrick McManus
f5f3f65dee Bug 997690 - nsHttpConnection::IdleTimeout default can be set internally r=hurley 2014-04-16 12:34:56 -04:00
Ethan Tseng
a88d902e0f Bug 996688 - Prevent potential crash in RtspConnectionHandler::parsePlayResponse. r=sworkman 2014-04-16 00:59:30 +08:00
Doug Turner
57abebc9bf Bug 995070 - Add preference to send 'Prefer: Safe' header as defined by draft-nottingham-safe-hint-01. r=mcmanus 2014-04-13 21:39:13 -07:00
John Shih
54c0637fed Bug 949956 - Move duplicated code to NetStatistics.h. r=mcmanus 2014-01-14 17:55:29 +08:00
Steve Workman
587b992345 Bug 990268 - Send FTPChannelParent::mStatus in IPDL messages to FTPChannelChild r=mayhemer 2014-04-07 11:26:22 -07:00
Ryan VanderMeulen
620c42bcde Merge inbound to m-c. 2014-04-04 14:51:38 -04:00
Benjamin Smedberg
cd2fddc1ce Bug 986582 - Get rid of the toolkit.telemetry.enabledPreRelease pref and make the toolkit.telemetry.enabled pref do the right thing for beta users who are testing a final release build, r=rnewman 
--HG--
extra : rebase_source : 43f70e2c1c3207f37ba0789245958cb0c34187f6
 2014-04-03 14:55:42 -04:00
Honza Bambas
4c264d97de Bug 984994 - Reintroduce 'network.http.use-cache' pref, r=jduell 2014-04-04 14:42:06 +02:00
Ryan VanderMeulen
3681541071 Merge inbound to m-c. 2014-04-03 15:24:54 -04:00
Ethan Tseng
133ebdb593 Bug 990862 - [RTSP] Rename RtspChannel to RtspChannelChild. r=sworkman 
--HG--
rename : netwerk/protocol/rtsp/RtspChannel.cpp => netwerk/protocol/rtsp/RtspChannelChild.cpp
rename : netwerk/protocol/rtsp/RtspChannel.h => netwerk/protocol/rtsp/RtspChannelChild.h
 2014-04-02 16:32:26 +08:00
Masayuki Nakano
ff8b968574 Bug 990855 part.2 Remove dom/events from local includes of moz.build files r=smaug 2014-04-03 13:18:38 +09:00
Patrick McManus
ded0fc52d9 bug 968417 - revalidating images needs loadgroup parent for spdy push r=seth 2014-01-29 22:35:40 -05:00
snigdha
90f0f64d5b Bug 798033 - Headers should generally not do "using namespace" at file scope. r=jib, r=jmathies, r=rjesup, r=ekr, r=ncameron, r=blassey 2014-04-01 08:29:25 -04:00
Jason Duell
b9a49e8b1c Bug 985230 - mStatus is not correct in HttpChannelChild::OnStartRequest r=sworkman 2014-03-31 14:43:04 -07:00
Steve Workman
45128fccdb Bug 925623 - Support delivery of WebSocket events off-main-thread in WebSocketChannel r=jduell 2014-03-27 13:58:19 -07:00
Ehsan Akhgari
5b9f45a1a5 Bug 798158 - Part 1: Use a pointer-sized type to store refcounts internally; r=bsmedberg 2014-03-27 16:38:33 -04:00
Steve Workman
93d4f4cba6 Bug 983910 - Set mParentListener for HttpChannelParent objects created after HTTP redirects 2014-03-27 13:11:50 -07:00
Ms2ger
794257a824 Bug 984006 - Remove xpcom/ds from local includes; r=ehsan 2014-03-27 21:05:14 +01:00
Ethan Tseng
fbbf59cfc8 Bug 977518 - [RTSP] Resource leak from RtspMediaResource, RtspController and RTSPSource. r=sworkman 2014-02-27 15:28:18 +08:00
Patrick McManus
625fdb05fb bug 988421 - spdy push concurrency mismatch r=hurley 2014-03-26 12:48:23 -04:00
John Shih
6aa0595d71 Bug 960426 - Part 2: Modifications for IDL change. r=blassey 2014-03-05 11:54:55 +08:00
Ryan VanderMeulen
f7acda1bd6 Backed out changeset 636fa3174368 (bug 983910) for xpcshell failures. 
CLOSED TREE
 2014-03-26 15:47:54 -04:00
Nathan Froyd
dfd53166ec Bug 986082 - add memory reporters for SPDY zlib buffers; r=hurley,njn 2014-03-20 14:22:17 -04:00
Nicholas Hurley
10802b03b1 Bug 965869 (part 1) - HTTP/2 draft10 client implementation. r=mcmanus 2014-03-26 10:58:09 -07:00
Steve Workman
ddce428119 Bug 983910 - Set mParentListener for HttpChannelParent objects created after HTTP redirects r=jduell 2014-03-26 10:30:58 -07:00
Andrea Marchesini
78d2c5e587 Bug 910010 - Implementation of PFileDescriptorSet - part 2, r=bent 2014-03-25 18:37:28 +00:00
Andrea Marchesini
4fad1489fb Bug 910010 - Implementation of PFileDescriptorSet - part 1, r=khuey 2014-03-25 18:37:13 +00:00
Sid Stamm
0f1689a71a Bug 835357 - fix telemetry probes for DNT so they accumulate before the pings are sent. r=mcmanus 2014-03-20 16:37:47 -07:00
Patrick McManus
88cc90ed8f bug 477578 - http methods should be case sensitive r=hurley 2014-03-18 12:36:18 -04:00
Honza Bambas
2aeb021d60 Bug 975787 - With cache disabled, assertion fails in nsWyciwygChannel::WriteToCacheEntry, r=michal 2014-03-17 18:21:37 +01:00
Kyle Huey
df0e7828eb Bug 981150: Use nsTArrayForwardDeclare.h more. r=ehsan 2014-03-15 12:00:17 -07:00
Kyle Huey
84360900b0 Bug 967364: Pass already_AddRefed by reference instead of by value. r=bsmedberg 2014-03-15 12:00:17 -07:00
Kyle Huey
e78b977cbc Bug 967364: Use every already_AddRefed. r=bsmedberg 2014-03-15 12:00:16 -07:00
Kyle Huey
510a49016d Bug 967364: Rename already_AddRefed::get to take. r=bsmedberg 2014-03-15 12:00:15 -07:00
Steve Workman
0764dccb8b Bug 975338 - Enable diverting of HTTP and FTP channels back to parent process from child r=jduell 2014-03-10 23:04:28 +01:00
Ed Morley
1ca60296b0 Backed out changeset 97858e5c1f13 (bug 975338) 2014-03-10 17:57:53 +00:00
Ed Morley
d931878edd Backed out changeset 1b4b0a309453 (bug 975338) 2014-03-10 17:57:49 +00:00
Ed Morley
953fb3f2ff Backed out changeset 7a78f199e1cd (bug 975338) 2014-03-10 17:57:46 +00:00
Steve Workman
99dfff0973 Bug 975338 - Implement nsI|ADivertableChannel in FTPChannelChild|Parent r=jduell 2014-03-10 18:31:57 +01:00
Steve Workman
399d6ef2ff Bug 975338 - Implement nsI|ADivertableChannel in HttpChannelChild|Parent r=jduell 2014-03-10 18:31:21 +01:00
Steve Workman
7f0e691e37 Bug 975338 - Add PChannelDiverter and new messages to PHttpChannel r=jduell 2014-03-10 18:31:05 +01:00
Robert O'Callahan
f91984df65 Bug 955888. Part 6: In chaos mode, when reading from an HTTP connection, sometimes read less than the full amount of available data. r=jduell 
--HG--
extra : rebase_source : aab04fbb2a52c7b89dda30410b77bb323fd80de6
 2014-03-03 18:12:42 +13:00
Robert O'Callahan
bc86039685 Bug 955888. Part 5: In chaos mode, insert an HTTP transaction into the pending queue at a random position among transactions with the same priority. r=jduell 
This effectively means HTTP transactions issue in a random order but priorities
are still respected.

--HG--
extra : rebase_source : 04e3888eee67ca2985d0307ac86c24cfa66de6a8
 2014-03-03 18:12:38 +13:00
Ryan VanderMeulen
412db33851 Merge m-c to inbound. 2014-03-06 13:56:13 -05:00
Ethan Tseng
3c20eea18f Bug 979761 - [RTSP] Crash when playing RTSP streaming with MPEG AAC Audio codec (regression caused by bug 970271). r=vchang 2014-03-05 16:12:21 +08:00
Honza Bambas
daa91e8ec5 Bug 960902 - Disallow concurrent HTTP cache read read when validation is needed, r=michal 2014-03-06 14:36:20 +01:00
Ryan VanderMeulen
760e2a311f Backed out changeset 6f05267b4afc (bug 798033) for Android bustage. 2014-03-05 09:55:52 -05:00
Honza Bambas
38bceaf674 Bug 904571 - crash in mozilla::net::HttpChannelParentListener::OnRedirectResult, r=jduell 2014-03-05 15:01:54 +01:00
snigdha
ef5d7c4e73 Bug 798033 - Headers should generally not do "using namespace" at file scope. r=jib, r=jmathies, r=rjesup, r=ekr, r=ncameron, r=blassey 2014-03-05 08:47:45 -05:00
Kent James
ca83307c02 Bug 977736 - Rewind stream early in DoAuthRetry. r=honzab 2014-03-04 13:51:37 -05:00
Ehsan Akhgari
c8b87eb077 Bug 977964 - Move some flags to moz.build; r=glandium 2014-03-03 21:58:37 -05:00
Benjamin Smedberg
680808b45a Bug 881413 - Avoid a race condition in HTTP shutdown by explicitly cancelling nsHttpConnectionMgr::mTimer when we shut down the socket thread, r=mcmanus 2014-02-28 16:40:38 -08:00