Edward Lee
7a297f3b5f
Simplify the debug output when creating bookmarks and include the parent and position.
2009-08-16 12:39:30 -07:00
Edward Lee
7c3bc745a0
Use the predecessorid to figure out where to put the item or save the predecessor as an annotation.
2009-08-16 12:39:15 -07:00
Edward Lee
96a4461af4
Set the predecessorid when creating records for upload.
2009-08-16 12:39:00 -07:00
Edward Lee
4cb51d9bde
Remove the missing parent annotation after reparenting an orphan.
2009-08-15 14:43:10 -07:00
Edward Lee
306fc8507b
Reparent orphans when creating the parent folder.
2009-08-15 01:07:40 -07:00
Edward Lee
7cc5c17773
Use a shared setGUID for new items and changing guids so that the item always ends up with the GUID (because conflicts shouldn't have been Weave generated).
2009-08-15 01:04:06 -07:00
Edward Lee
004fdf436d
Store the parent GUID as an annotation if the item is missing a parent and share some parent lookup code.
2009-08-15 01:00:46 -07:00
Edward Lee
31270d064c
Move _preprocess to before applyIncoming to share code for create/update/remove.
2009-08-15 01:00:32 -07:00
Edward Lee
cbba430108
Rename weaveId to just GUID and share a id<->guid function across store and tracker.
2009-08-15 00:59:49 -07:00
Edward Lee
fae7aaa071
Temporarily append everything and don't use sortindex for ordering within a folder.
2009-08-15 00:57:09 -07:00
Edward Lee
2335b057db
Get rid of depth and sort on index instead.
2009-08-15 00:56:27 -07:00
Edward Lee
3ca750f464
Remove meta/mini records. Bye!
2009-08-13 18:50:54 -07:00
Edward Lee
39895d48b2
Put Annotations in Svc and expose a get/set Utils.anno call to use from bookmarks.
2009-08-13 17:59:26 -07:00
Edward Lee
983afb76a9
Remove unused bookmark annotations/constants.
2009-08-13 17:43:20 -07:00
Edward Lee
bc5f3d3be8
Bug 507296 - Sync bookmarks and history in batched mode. r=thunder
...
Wrap the original SyncEngine._sync function with a call to runInBatchMode, so SQL disk writes happen at the end of batch mode instead of on every change.
2009-07-30 11:52:26 -07:00
Edward Lee
1a4c241fc9
Change client engine to override findLikeId instead of recordLike to save on some work (iterating over changed ids).
2009-07-28 10:07:07 -07:00
Edward Lee
6ddbaa9a8e
Bug 506795 - Handle adding duplicate logins. r=thunder
...
Refactor reconcile to call findLikeId that by default will look for recordLike in the outgoing queue as it does now. Override findLikeId for password engine to search local logins.
2009-07-28 10:06:02 -07:00
Edward Lee
551f097468
Convert various debug messages to trace.
2009-07-22 21:40:18 -07:00
Edward Lee
4f7ab3c5c2
Remove pref tracker init debug message.
2009-07-14 18:47:29 -07:00
Edward Lee
68d361380a
Bug 504230 - Use Engine's logging level for Store and Tracker
...
Use the log.logger.engine.* prefs to determine what the Store and Tracker should log with. This requires putting the same engine name on each Store/Tracker object, so there's some duplicate string values right now.
2009-07-14 18:34:03 -07:00
Edward Lee
9fde263097
Bug 504216 - Force various engines to be disabled
...
Have the disabled engines return null for enabled instead of the pref's true/false.
2009-07-14 17:03:57 -07:00
Anant Narayanan
7cd35a2c36
Limit form history records (bug 494952, r=thunder)
...
--HG--
extra : rebase_source : c3e983d30a14efd972eea2651a59be76924da256
2009-07-14 12:28:18 -07:00
Edward Lee
5ad22f9709
Bug 479189 - weave does not sync tag smart folders properly
...
Create a new record type, BookmarkQuery, to handle place: uri smart bookmarks. Store what tag name the query wants and lookup the id for that tag on other machines on create/update.
2009-07-13 17:43:15 -07:00
Edward Lee
22570f2932
Bug 503938 - Tags with a single bookmark keep generating new tag ids
...
Share a tagging code for create/update that will tag a dummy uri temporarily while it untags the bookmark to make sure every tag has at least one child during this untag/tag process.
2009-07-13 13:40:49 -07:00
Edward Lee
6ddece8b22
Bug 502482 - error while syncing bookmarks from server
...
Set the item type for generic PlacesItems, but don't do anything when trying to create it.
2009-07-09 17:15:00 -07:00
Edward Lee
5c482eea0d
merge weave. resolve comments added to resource.js.
2009-07-09 11:21:20 -07:00
Edward Lee
1c1025b37d
Convert a log.info to log.debug for passwords so it doesn't clutter the brief log.
2009-06-25 22:52:28 -07:00
Edward Lee
39f333a78e
Bug 500598 - Undefined item in tabContainer.childNodes after closing tabs
...
The childNodes NodeList keeps its indices even after removal, so it's safer to convert the array-like thing into an actual array. Condense the QueryInterface code to the instanceof magic.
2009-06-25 22:46:14 -07:00
Edward Lee
84c52a6411
merge weave. resolve addition of kSpecialIds to bookmarks.js near removal of Async.sugar.
2009-06-23 22:34:57 -07:00
Anant Narayanan
22bd439624
Change priority of some log messages to trace
2009-06-22 18:19:42 -07:00
Edward Lee
eeef9a8201
Bug 487282 - "browser is null" error in tabs.js
...
Share browser detection code for register and unregister tab listeners and better check for tabbrowser windows.
2009-06-22 15:53:42 -07:00
Edward Lee
ad7d001bb3
Bug 498924 - Refactor bookmark special ids out of BookmarksStore
...
Lazily load places ids for a given weave id/place name pair into kSpecialIds and update all consumers. Expose a Svc.Bookmark in utils.
2009-06-17 09:28:15 -07:00
Edward Lee
3ef568c718
Cleanup/refactor followup to bug 481327.
...
Change _ignore to take itemId to find folderId and pull out addChanged/getItemGUID/upScore to addId.
2009-06-17 08:51:54 -07:00
Edward Lee
34400917b0
Bug 481327 - Script gets stuck during startup. r=Mardak
2009-06-17 08:51:54 -07:00
Mikhail Stepura (mishail)
fde4deb743
Bug 486042 - "Load this bookmark in the sidebar" status not synced. r=Mardak
2009-06-16 16:16:39 -07:00
Edward Lee
57adfb688b
merge weave
2009-06-06 13:12:03 -07:00
Edward Lee
df1fc601da
Fix form engine to correctly pass in the engine.
2009-06-05 18:36:31 -07:00
Edward Lee
6bc0e717ec
Clean up various engines to remove Async.sugar and random self/yields.
2009-06-05 15:34:40 -07:00
Edward Lee
68ce1e4224
Change SyncEngine._reconcile to not be async/yield.
2009-06-04 14:18:04 -07:00
Edward Lee
428d54a14a
Change Resource.get() to be sync (no callback) and fix up call sites used for login + sync now.
2009-06-04 10:16:07 -07:00
Wladimir Palant
753b7da199
Bug 495996 - Bookmark observer doesn't implement onBeforeItemRemoved method. r=Mardak
2009-06-02 21:25:55 +02:00
Wladimir Palant
8f33b68063
Bug 495924 - TabTracker wrongly assumes that "this" pointer will be set correctly for event handlers
2009-06-02 11:25:37 +02:00
Anant Narayanan
252a823626
Preference sync (bug #428370 )
2009-05-24 02:11:05 +02:00
Anant Narayanan
dbad6932cb
Use first login found if there are multiple GUIDs
2009-05-24 00:25:30 +02:00
Anant Narayanan
b6a3ce9d6e
Use searchLogins instead of caching passwords (bug #489268 )
2009-05-24 00:03:53 +02:00
Edward Lee
0a32933db7
Bug 493004 - Create stubs of unimplemented engines to list them as disabled (extension, microformat, plugin, theme)
...
Add the 4 engines with just the base code to set their name and register them for Firefox.
2009-05-14 11:50:59 -05:00
Edward Lee
93847aa32d
Bug 493002 - List partially implemented engines (cookies, input history) as disabled
...
Import the outdated engines, but delete their pref so they show up as disabled. Clean up the old engines a little bit so they don't allocate unnecessarily and to not use syncCore.
2009-05-14 11:43:56 -05:00
Edward Lee
690c26f9d5
Fix form engine displayname to displayName
2009-05-14 11:09:08 -05:00
Edward Lee
48f3b8796d
Remove old Firefox 3 places DB code.
...
Min version is 3.1/5, so we grab DBConnection from places directly now.
2009-05-13 16:31:42 -05:00
Myk Melez
bab5749a17
bug 492435: work around crasher bug 492442 by not calling isVisited for a history entry without a URL; r=thunder
2009-05-11 16:11:04 -07:00
Edward Lee
e55cf3a52a
Bug 488190 - Use record properties instead of cleartext properties
...
Switch pretty much all references to cleartext in modules/engines/ to just use the record. Also clean up some references to null cleartext to use deleted. The only reference to cleartext is to iterate over that hash in bookmarks.
2009-04-13 16:39:29 -05:00
Edward Lee
2c5fc6c54f
Bug 488170 - Consistently set record cleartext URIs as text spec uris
...
Switch cleartext properties to Uri that always takes a text spec, so eventually URI refers to nsIURI. GeneratorURIs seems to have been broken either way.. makeURI of an already URI and storing of a URI into cleartext. This landed with changes to keys, so the server wipe also handles the local name changes.
2009-04-13 16:39:29 -05:00
Edward Lee
b7a138755c
Bug 488142 - Make it easier to add simple deferred cleartext/payload values
...
Add a couple Utils helper to create a pair of simple [gs]etters that use a hash property instead. Apply this to various records: WBORecord, {Priv,Pub}Key, Crypto{Meta,Wrapper}, and every engine's type records. Migrate by making sure key data exists (name change).
2009-04-13 16:39:29 -05:00
Edward Lee
253a6ca0d8
Bug 488182 - Use an Iterator to grab both key and values from cleartext for processing bookmarks
...
Get rid of extra record.cleartext references within the for/each/switch -- even for unused keys like incomingSharedAnno.
2009-04-13 16:18:11 -05:00
Edward Lee
9a582a606e
Bug 488165 - Correct set the record object type when processing records
...
Set _recordObj for Bookmarks/History engines and override PlacesItem.decrypt to switch itself to the right type after CryptoWrapper decrypts the payload.
2009-04-13 14:54:31 -05:00
Dan Mills
c92f210ac9
oops fix missing .prototype
2009-04-10 17:30:05 -07:00
Dan Mills
a789863032
Remove __proto__.__proto__ it's fail-prone
2009-04-10 16:08:31 -07:00
Dan Mills
67fd1f1e82
can't get guid on expiration
2009-04-10 16:04:13 -07:00
Edward Lee
f1f0742fae
Bug 487541 - form submission caused exception 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface]
...
Get rid of the QueryInterface and just use instanceof while copying the logic of nsFormHistory::Notify to avoid divergent logic until satchel provides a notification.
2009-04-08 22:48:26 -05:00
Dan Mills
ebca2e9c0f
don't track history deletes at all; don't built id->guid mapping hash for history tracker
2009-04-08 18:11:14 -07:00
Myk Melez
c699fdf732
switch from --utc to -u flag to enable UTC output for date command so it works on both Linux/Windows (which support --utc in addition to -u) and Mac OS X (which only supports -u)
2009-04-08 15:00:02 -07:00
Edward Lee
d6a16ace0a
Bug 487378 - Use the app name as the default client name
...
Use nsIXULAppInfo to get the name and remove Fennec specific bits.
2009-04-08 02:12:57 -05:00
Mikhail Stepura
e97e9389db
Bug 486481 - Weird behavior when syncing the bookmark with tags
...
Add the remaining special top level folders and ignore them for certain behavior like getAllIDs and wipe. Have the tracker ignore changes to things in the tags folder.
2009-04-07 23:17:40 -05:00
Edward Lee
25b484a48a
Bug 487363 - Share bookmark tracker ignore logic
...
Share the ignore logic that takes a parent folder and ignore if the engine says so or it's a livemark.
2009-04-07 22:56:04 -05:00
Edward Lee
09653caf66
Bug 487338 - Track special folder weave GUIDs <-> bookmark id mapping
...
Create a specialIds hash and use it to for getting weaveId/id, determine top level, if a folder is a root, getting all ids, wiping, and tracker ignoring.
2009-04-07 19:22:36 -05:00
Anant Narayanan
da004b2423
Update form sync engine to work with Weave0.3/FF3.5
2009-04-06 19:05:16 +02:00
Edward Lee
3993035a59
Bug 482670 - WBORecord should implement a .deleted property
...
Expose a .deleted property that engines can set to true to store an even thinner deleted payload (empty string "" instead of "[null]") on the server. Handle deserializing of deleted records by setting the property. Note: Engines must set their payloads to something JSON-able if it's not a delete record.
2009-04-03 12:38:47 -05:00
Edward Lee
eebdf48521
Bug 486667 - Clients get amnesia -- forget who they are after a wipe
...
Set the local client info after resetting the clients store hash
2009-04-03 09:26:12 -05:00
Edward Lee
2e72dcf2a7
Bug 480929 - RSS names not synced
...
Set the title in the record just like any other bookmark (folder)
2009-04-01 17:12:08 -05:00
Edward Lee
0d1e91ca16
Bug 482896 - Unify local client data and remote client data storage
...
Initialize unified client store from disk json and local prefs and update on pref changes + sync. Clean up client engine code (local vs inherited, alphabetical), and create a helper modify() to save snapshots.
2009-04-01 01:56:32 -05:00
Edward Lee
b0633f2208
Bug 486234 - Give changes json file name for history, passwords
2009-03-31 20:07:43 -05:00
Edward Lee
ba7af5037c
Bug 486230 - Share json disk caching with Utils.json{Load,Save}
2009-03-31 19:52:16 -05:00
Edward Lee
4f6ebe6be5
Bug 481741 - Switch to JSON from nsIJSON
2009-03-31 14:09:38 -05:00
Dan Mills
fd14693e9f
Bug 478328: delete old history data from the server
2009-03-30 15:19:00 -07:00
Dan Mills
9df4203349
remove dump() debugging from tabs engine
2009-03-30 15:18:20 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
53fa9e5846
Bug 485539 - added guard to the tab engine to handle the case where there are undefined items in tabContainer.childNodes.
2009-03-27 11:06:43 -07:00
Dan Mills
51c55c8f41
Bug 484848: try #3
2009-03-26 10:58:54 -07:00
Dan Mills
f6f3adc09e
Bug 481319: try again
2009-03-25 19:47:37 -07:00
Dan Mills
4abd146e4f
merge upstream changes
2009-03-25 19:33:51 -07:00
Dan Mills
a3725fab15
Bug 484848: modifyLogin sends an array of nsILoginMetaInfos to observers
2009-03-25 19:27:24 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
b690a2858d
Fixed name of TabStore.changeItemID so that it correctly overrides the abstract base class method. Whoops.
2009-03-25 17:36:11 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
6555e1e1ef
Experimenting with getting tab last-used-time data on Fennec
2009-03-18 12:40:27 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
0f809c8372
Removed unused code from tab tracker.
2009-03-17 18:02:13 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
a6e05ab37a
TabTracker now keeps track of when each tab was most recently used; tabStore wraps this data for sync, and fennec UI uses it to sort incoming tabs by most-recently-used date. This fixes 481326.
2009-03-17 17:57:53 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
95ae06e497
If you click the button to show synced tabs before Weave has been configured, it will now take you straight to the sign-in screen. Fixes bug 482818.
2009-03-16 16:49:56 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
859e51e20b
The remote-tabs menu (on both firefox and fennec) no longer shows tabs you already have open locally. Fixes bug 480405.
2009-03-12 15:54:26 -07:00
Edward Lee
dfc2d1f68a
Bug 481266 - Provide a way to perform actions on remote clients. r=thunder
2009-03-03 17:29:35 -06:00
Dan Mills
489e86bdc5
oops, client was not updating depth/index of records
2009-03-11 02:02:58 -07:00
Dan Mills
7b9eedde66
Bug 478327: Send minimal '[null]' payload for deleted records
2009-03-11 01:40:04 -07:00
Edward Lee
a45ed6623b
Bug 482178 - Clean up services -> lazy services. r=thunder
2009-03-10 06:30:30 -05:00
Dan Mills
2e61ae02f3
remove dump() debug statements
2009-03-10 01:20:50 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
02d92a86ca
Fennec now launches first run page, and updates extensions.weave.lastversion, so that it's no longer resetting syncId and therefore resetting the server every single time it tries to sync. Also set the download in resource.js to use LOAD_BYPASS_CACHE. Together these changes seem to fix bug 480270.
2009-03-07 00:55:47 -08:00
Edward Lee
edda1db597
Bug 480457 - Expose a resetClient API for weave service and engines. r=thunder
2009-02-26 22:36:14 -08:00
Dan Mills
bf29e922ae
disable recordLike for clients
2009-03-03 11:53:56 -08:00
Dan Mills
47ac6a5d0c
create new records with correct guid set
2009-03-03 01:48:13 -08:00
Dan Mills
26e63650e6
override _recordLike for passwords; add logging calls; make getAllIDs return full nsLoginInfos
2009-03-03 01:32:10 -08:00
Dan Mills
3e1235a9e5
Switch away from __defineGetter__ due to bug 481104; explicitly cache logins in password engine; whitespace fixes
2009-03-02 18:55:26 -08:00
Anant Narayanan
0f6fdde06c
Remove getter that fixes the 'two-store' problem
2009-03-03 01:15:48 +01:00
Anant Narayanan
088a5457a5
Rename methods to be less confusing
2009-03-03 00:57:37 +01:00
Anant Narayanan
05dfbc7c8a
Password sync for 0.3 (bug #468697 )
2009-03-03 00:42:57 +01:00
