Commit Graph

64 Commits

Author SHA1 Message Date
Benjamin Smedberg
24e7cb1f78 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
50621e4f9f Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
d0b948876f Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Robert O'Callahan
b817cb2bbf Bug 469203. Don't try to make toplevel HTML documents transparent, it just doesn't work and the window can disappear in a mysterious way. r+sr=dbaron 2008-12-29 21:17:08 +13:00
Robert O'Callahan
bbdc2a9552 Bug 465913. Don't need to call BreakFromPrevInFlow in nsContainerFrame::DeleteNextInFlowChild. r+sr=dbaron 2008-12-08 13:39:11 +13:00
Robert O'Callahan
f9d2d59b5e Bug 465928. Avoid SetInvalidateTextRuns being called by nsBlockFrame::DoRemoveFrame when we're just deleting empty continuation frames. r+sr=dbaron 2008-12-03 14:27:19 +13:00
Markus Stange
2c38adaec7 Bug 450944 - Implement -moz-window-shadow functionality on Mac OS X, r=hwaara sr=roc.
This patch turns on window shadows for transparent windows by default, so the identity popup and the "edit bookmarks" popup will get a shadow, too. ui-r=faaborg
2008-10-14 17:33:40 +02:00
Mats Palmgren
6499cb8fdb Undo frame list formatting change from bug 243519. b=454727 r+sr=roc 2008-10-11 03:08:20 +02:00
Arpad Borsos
d0e70a51bf Bug 452797 - Clean up unused variables in layout/; v6; r+sr=roc 2008-09-20 15:42:03 +02:00
Keith Schwarz
dc907e1ec7 Bug 435293. Implement CSS transforms. r=dbaron,r+sr=roc 2008-09-13 21:42:11 +12:00
timeless@mozdev.org
5819f54b4e merging backout part two of two
to fix Bug 454186
SM crashes when try to download file [@ nsString::ToInteger - nsTreeBodyFrame::PaintProgressMeter]
2008-09-08 16:01:00 +02:00
timeless@mozdev.org
b0c349250f Backed out changeset 54215f2cbc66
to fix Bug 454186
SM crashes when try to download file [@ nsString::ToInteger - nsTreeBodyFrame::PaintProgressMeter]
2008-09-08 16:00:32 +02:00
timeless@mozdev.org
14a159413b merging part one of backout 2008-09-08 16:00:02 +02:00
timeless@mozdev.org
001755d5a8 Backed out changeset 18b48ea2b188
to fix Bug 454186
SM crashes when try to download file [@ nsString::ToInteger - nsTreeBodyFrame::PaintProgressMeter]
2008-09-08 15:59:01 +02:00
Robert O'Callahan
cddb22d87c Bug 243519. Rework root element frame construction and the CanvasFrame so that the CanvasFrame is an abs-pos container and the root element frame can be positioned. r=fantasai,sr=dbaron 2008-09-08 20:13:17 +12:00
Serge Gautherie
2466a54798 Bug 452797 - Clean up unused variables in layout/; (debug) bustage fix; noticed by Jesse on irc. 2008-09-06 21:12:09 +02:00
Arpad Borsos
1f62482141 Bug 452797 - Clean up unused variables in layout/; r+sr=roc 2008-09-06 20:38:31 +02:00
Robert O'Callahan
ea7596e60c Backing out changesets 75919d3eb3d0 and 14ce7619e9c1 due to test failures 2008-09-07 00:35:20 +12:00
Robert O'Callahan
f7339a0460 Bug 243519. Rework root element frame construction and the CanvasFrame so that the CanvasFrame is an abs-pos container and the root element frame can be positioned. r=fantasai,sr=dbaron 2008-09-06 21:35:05 +12:00
Robert O'Callahan
be904c4d3d Bug 376662. Convert nsIFrame::GetOffsetTo to not use views. We need to ensure that for popups and scrollframes, views and frames are kept in sync at *all* times. Also fixes bugs in tests for NS_FRAME_NO_MOVE_FRAME. r+sr=bzbarsky 2008-09-06 20:52:56 +12:00
Robert O'Callahan
43ba0d18d7 Bug 422283. Make sure that an overflow container's next-in-flows are always also overflow containers. This means that when we convert a normal frame into an overflow container, we need to scan through its next-in-flows and make them overflow containers too. r=fantasai,sr=mats 2008-09-06 20:48:09 +12:00
Robert O'Callahan
ca15953a6e Backing out changeset 1bdd5da49865 (for bug 376662) due to regression bug 453661 2008-09-05 15:40:06 +12:00
Robert O'Callahan
1eeada5faa Bug 376662. Make nsIFrame::GetOffsetTo not explicitly use views. r+sr=bzbarsky 2008-09-04 09:35:52 +12:00
Rob Arnold
f6bda8fda0 Implement Aero Glass effect support - bug 418454 r=vlad r=roc 2008-08-12 17:44:14 -07:00
Andrew Smith ext:(%2C%20Rob%20Arnold%20%3Ctellrob%40gmail.com%3E%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
49c9b3d67e Implement css3 border-image property. (Bug 378217) r=vlad,dbaron,robarnold 2008-07-16 23:30:25 -07:00
L. David Baron
9e4ceade8e Backed out changeset 9b0b2391485c due to linker errors related to nsStyleStructInlines.h not being included enough. 2008-07-16 22:59:14 -07:00
Andrew Smith ext:(%2C%20Rob%20Arnold%20%3Ctellrob%40gmail.com%3E%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
bb4be48531 Implement css3 border-image property. (Bug 378217) r=vlad,dbaron,robarnold 2008-07-16 22:18:38 -07:00
roc+@cs.cmu.edu
45ac0e7ce6 Bug 398332. Merge reflow statuses from out-of-flow frames more carefully so that we don't lose information about the primary reflow. r=fantasai,r+sr=dbaron,a=shaver 2008-05-28 06:39:41 -07:00
uriber@gmail.com
dce1edd834 Don't reserve space for start (end) margin on the first- (last-) in-flow if it has a previous (next) bidi continuation. bug=421419 r+sr=dbaron a1.9=dsicore 2008-03-11 14:54:34 -07:00
dbaron@dbaron.org
7003061847 Fix the weird Get* API on nsStyleSides in favor of returning structs by value, to avoid further occurrences of bug 420069. b=420069 r+sr=roc a=beltzner 2008-03-05 16:05:26 -08:00
dbaron@dbaron.org
38ba81cbd4 Fix bug under some valid types of optimization where we cross margin and padding. b=420069 r+sr=roc a1.9b4=damons a-sheriff=sayrer 2008-02-28 17:52:06 -08:00
fantasai.cvs@inkedblade.net
adcaddd746 fixed positioned elements print only on first and last pages b=417676 r+sr=roc 2008-02-24 04:19:17 -08:00
fantasai.cvs@inkedblade.net
d4dc37580f switch GetOverflowAreaProperty callers to GetOverflowRect b=417116 r+sr=roc a=roc 2008-02-19 23:08:55 -08:00
bzbarsky@mit.edu
8b8a07f4a7 Fix bug 416073: invalidate more things as needed during table reflow to prevent glitches. r+sr=roc 2008-02-08 01:36:32 -08:00
roc+@cs.cmu.edu
59db392f04 Bug 405721. nsContainerFrame::RemoveFrame should search the frame's overflow list if the frame isn't found in the main child list. r+sr=bzbarsky 2008-01-14 17:12:01 -08:00
roc+@cs.cmu.edu
41ba318410 Bug 404146. Simplifying the code a little 2008-01-09 19:23:35 -08:00
roc+@cs.cmu.edu
bf79c23ed9 Bug 404146. Advancing through nsContainerFrame next-in-flows can make our InlineData->line invalid, so just null it out if it might have become invalid. r+sr=dbaron 2008-01-09 19:18:44 -08:00
roc+@cs.cmu.edu
372c15673e Bug 322074. Check more carefully whether a transparent document is actually a top-level window. r+sr=bzbarsky 2008-01-09 14:50:29 -08:00
karlt+@karlt.net
604fec8a96 FinishReflowChild() with the final position for <msqrt> and <mpadded> b=410132, r+sr+a=roc 2008-01-02 20:33:21 -08:00
hwaara@gmail.com
730486f134 bug 392040, <select> menu requires multiple clicks to show up in zoom pages, r=bz, sr=roc, a=blocking1.9+. Also checking in a testcase for bug 404872 2007-12-22 13:07:58 -08:00
hwaara@gmail.com
9fc1c6a41c bug 307204, implement support for transparent windows in XUL for Mac OS X. r=josh, sr=roc, approval1.9=damons 2007-12-19 11:40:18 -08:00
dholbert@cs.stanford.edu
0951ed356d Bug 404219: Reinsert (instead of discarding) frameList after failing to remove a frame from it. r=fantasai sr=roc a=blocking1.9 2007-12-18 11:22:12 -08:00
roc+@cs.cmu.edu
55da4ea6d8 Bug 407397. Don't 'optimize' by not reflowing when a 0x0 frame is removed. Bad Kipp. r+sr=dbaron 2007-12-10 17:14:25 -08:00
bzbarsky@mit.edu
b7743fbcec Fix bug 406485. Patch by fantasai, r+sr=roc 2007-12-04 19:22:55 -08:00
fantasai.cvs@inkedblade.net
7595405d06 fix incorrect loop test condition for skipping irrelevant frames; update code to deal properly with skipped frames; b=404213 r+sr=roc 2007-12-01 19:13:23 -08:00
bzbarsky@mit.edu
1cec19400e Backing out bug 392040 to fix bug 404872. a="it's a blocker regression, and it's keeping me and Gavin from using Bugzilla" 2007-11-25 15:17:23 -08:00
hwaara@gmail.com
9eae694ac6 bug 392040, SELECT menu requires multiple clicks to show up on some pages. This also happened when using full page zoom. r+sr=roc, a=blocking1.9+ 2007-11-19 11:20:35 -08:00
fantasai.cvs@inkedblade.net
fb7fdc7e86 nsOverflowContinuationTracker::Insert wasn't expecting to pull from overflowContainers list into same parent's excessOverflowContainers list, b=399843 r+sr=roc 2007-11-15 11:23:07 -08:00
fantasai.cvs@inkedblade.net
d217f92687 nsOverflowContinuationTracker shouldn't assume frame won't get reflowed again before its continuation gets reflowed, b=398322, b=393956, r=dholbert sr=roc 2007-10-09 12:46:21 -07:00
dholbert@cs.stanford.edu
603542e4aa Bug 395316 - Clear OutOfFlowFrame after unregistering placeholder, and make recursive call to RemoveFrame. r/sr/a=roc 2007-10-02 20:44:18 -07:00