Commit Graph

5545 Commits

Author SHA1 Message Date
Mike Hommey
393ced0c9d Bug 1084161 - Use PLDHashTableOps to allocate PLDHashTables. r=nfroyd 2014-10-24 13:08:02 +09:00
Carsten "Tomcat" Book
c3f8f98b4e merge mozilla-inbound to mozilla-central a=merge 2014-10-16 16:07:06 +02:00
Dave Townsend
0843bd72b3 Bug 1079451: Don't log unnecessary warnings from chrome registration. r=bsmedberg 2014-10-15 15:02:42 -07:00
Ryan VanderMeulen
b87718267b Merge inbound to m-c. a=merge
CLOSED TREE
2014-10-15 14:31:16 -04:00
Alessio Placitelli
708864bab4 Bug 1038145 - Make use of the new infoURL item from the blocklist for plugins with an update. r=irving 2014-10-15 15:23:22 +02:00
Brian Marshall
22e9394cb8 Bug 1079311 - Unlock mutex before logging error in RegisterContractIDLocked. r=bsmedberg 2014-10-08 16:08:28 -07:00
Andrew McCreight
33f9c09058 Bug 1035454, part 2 - Paper over late shutdown failures on B2G and Windows in debug content processes by exiting XPCOM early. r=bsmedberg
On B2G, there are crashes very late in shutdown on content processes. On Windows XP,
there is an intermittent test failure. We work around both of these by calling exit(0)
during XPCOM shutdown prior to the points where these errors occur. This enables us to
land part 4, that stops us from crashing in content processes when the xpcom-shutdown
message is sent, and enables leak checking in content processes on Linux.
2014-10-15 20:04:32 -07:00
Ehsan Akhgari
24fd149467 Bug 1082576 - Fix the XPCOM library loading error reporting code; r=froydnj
We build without UNICODE, so we end up calling the ANSI version
of the function, and then we would attempt to interpret the
resulting narrow char buffer as a wide char buffer.
2014-10-14 19:28:24 -04:00
Mark Banner
ed6044700a Bug 1081906 Fix unable to start Firefox due to 'Couldn't load XPCOM'. r=bsmedberg 2014-10-14 10:06:20 +01:00
Wes Kocher
f5aa6677ce Merge m-c to inbound a=merge 2014-10-13 19:02:56 -07:00
ffxbld
be274d1f29 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2014-10-13 13:39:31 -04:00
Mike Hommey
30febd13b1 Bug 1081000 - Build xpt tests without a dependency on xul, mozalloc and mozglue. r=bsmedberg 2014-10-14 07:14:13 +09:00
Tom Schuster
0db58380c0 Bug 1069694 - Remove OldDebugAPI from the browser. r=shu 2014-10-12 19:37:41 +02:00
Ryan VanderMeulen
a5e63e0f9a Backed out changesets fb6af789bc67 and 313123f12e95 (bug 818307) for non-unified bustage. 2014-10-10 16:24:54 -04:00
Stephen Pohl
6b7b767456 Bug 1077282: Cleanup uses of GreD vs GreBinD, introcuded by v2 signature changes on OSX. Based on initial patch by rstrong. r=bsmedberg 2014-10-10 15:06:57 -04:00
Aaron Klotz
f4a6ebe01f Bug 818307: Part 1 - Add annotation support to ChromeHangs; r=vladan 2014-10-10 12:19:57 -06:00
Georg Fritzsche
39daf17fb6 Bug 1073536 - Allow checking if MOZILLA_OFFICIAL is set via nsIXULRuntime. r=ted 2014-10-10 17:21:17 +02:00
Jon Morton
0f167a14a3 Bug 979835: Port BoxObject and its subclasses to WebIDL. r=khuey sr=bz
--HG--
rename : layout/xul/nsIPopupBoxObject.idl => dom/webidl/PopupBoxObject.webidl
rename : layout/xul/tree/nsITreeBoxObject.idl => dom/webidl/TreeBoxObject.webidl
rename : layout/xul/nsBoxObject.cpp => layout/xul/BoxObject.cpp
rename : layout/xul/nsBoxObject.h => layout/xul/BoxObject.h
rename : layout/xul/nsListBoxObject.cpp => layout/xul/ListBoxObject.cpp
rename : layout/xul/nsMenuBoxObject.cpp => layout/xul/MenuBoxObject.cpp
rename : layout/xul/nsPopupBoxObject.cpp => layout/xul/PopupBoxObject.cpp
2014-10-14 13:15:21 -07:00
Steve Fink
b41205df20 Bug 1061288 - Make it harder for ArrayBuffer data pointers to be held across invalidations. r=smaug,terrence,jdm,roc,khuey 2014-10-07 10:44:07 -07:00
Jean-Yves Avenard
c44e6ab410 Bug 1079655: Do not sanitize the path used to load XPCOM if the path couldn't
be retrieved successfully on OSX. r=spohl
2014-10-09 12:19:45 +11:00
Jean-Yves Avenard
3991b9d059 Bug 1079655: Ensure that the path used to load XPCOM can be sanitized on OSX 10.10. r=spohl 2014-10-09 12:34:04 +11:00
Eric Rahm
96050f224f Bug 806819 - Part 4: Add files that were excluded from unified builds back in. r=ehsan 2014-10-08 13:19:14 -07:00
Eric Rahm
f6bb65afb3 Bug 806819 - Part 3: Remove redundant FORCE_PR_LOG entries. r=ehsan 2014-10-08 13:17:32 -07:00
Bill McCloskey
b030bd8399 Bug 1049879 - Remove urgent and rpc message types and replace with message priorities (r=dvander,bent,ehsan) 2014-10-07 21:32:45 -07:00
Carsten "Tomcat" Book
f107ebbec3 Backed out changeset e56bf4ea89fb (bug 1049879) for bustage in emulator debug builds on a CLOSED TREE 2014-10-08 08:03:57 +02:00
Bill McCloskey
f70f11163a Bug 1049879 - Remove urgent and rpc message types and replace with message priorities (r=dvander,bent,ehsan) 2014-10-07 21:32:45 -07:00
Andrew Halberstadt
2da4ee197d Bug 1066735 - Remove root b2g and android specific xpcshell manifests, r=chmanchester 2014-10-07 18:18:28 -04:00
Bill McCloskey
a02037e1b1 Bug 930243 - Disable process type tests on Android on A CLOSED TREE 2014-10-07 13:35:34 -07:00
Bill McCloskey
46c57009ef Bug 930243 - Add a processType flag to chrome manifest directives (r=froydnj) 2014-10-07 11:46:24 -07:00
Stephen Pohl
9d2ef90102 Bug 1078640: Sanitize path used to load XPCOM on OSX. r=smichaud 2014-10-07 09:33:09 -04:00
Wes Kocher
5d7f3c7007 Backed out 5 changesets (bug 806819) for WinXP test failures on a CLOSED TREE
Backed out changeset 009ae35b0c67 (bug 806819)
Backed out changeset 5a57f87f5061 (bug 806819)
Backed out changeset f06cd735b5b3 (bug 806819)
Backed out changeset e25a2a8d4af4 (bug 806819)
Backed out changeset 70a167982c3f (bug 806819)
2014-10-06 16:32:50 -07:00
Eric Rahm
e523216532 Bug 806819 - Part 4: Add files that were excluded from unified builds back in. r=ehsan
--HG--
extra : rebase_source : 49a3f57d94fc94702f1604175c4e206091b67197
2014-10-06 13:11:24 -07:00
Eric Rahm
baf96b6e07 Bug 806819 - Part 3: Remove redundant FORCE_PR_LOG entries. r=ehsan
--HG--
extra : rebase_source : c96eea1c12ea8c19314393f0e8b4b57a4316a61d
2014-10-06 13:08:20 -07:00
Nicholas Nethercote
24912152f6 Bug 1044709 - Improve the comment describing the memory report file format. r=mccr8.
--HG--
extra : rebase_source : 41738a5a898c67f6dd4a41cbf0d877d85f3f4feb
2014-09-28 18:35:14 -07:00
Nicholas Nethercote
e7c6e0dc5f Bug 1044709 - DMD: emit JSON output and use Python for post-processing. r=mccr8.
--HG--
extra : rebase_source : ddc94d9be1ee0acc6dda30540defd5f40db0adcb
2014-09-02 20:34:58 -07:00
Nicholas Nethercote
b21b892183 Bug 1062709 (part 2, attempt 2) - Clean up stack printing and fixing. r=dbaron.
--HG--
extra : rebase_source : 626fd23a14ec90cfc9807c3d555169ec6463d19d
2014-09-01 22:56:05 -07:00
Nicholas Nethercote
0249afcc66 Bug 1062709 (part 1, attempt 2) - Add a frame number argument to NS_WalkStackCallback. r=dbaron.
--HG--
extra : rebase_source : 4f7060a9ae0bed180899651c50e8ea8857e72d63
2014-09-10 21:47:01 -07:00
Mike Hommey
b4265f0fa8 Bug 1077151 - Always use expandlibs descriptors when they exist. r=mshal
Currently, when there is both an expandlibs descriptor and an actual static
library, expandlibs picks the static library. This has the side effect that
if there are object files in the static library that aren't directly used,
they're dropped when linking, even when they export symbols that would be
exported in the final linked binary.

In most cases in the code base, files are not dropped that way. The most
notable counter-example is xpcomglue, where actually not dropping files
leads to link failure because of missing symbols those files reference
(yes, that would tend to say the glue is broken in some way).

On the opposite side, there is mozglue, which does have both a descriptor
and a static library (the latter being necessary for the SDK), and that
linking as a static library drops files that shouldn't be dropped (like
jemalloc). We're currently relying on -Wl,--whole-archive for those files
not to be dropped, but that won't really be possible without much hassle
in a world where mozglue dependencies live in moz.build land.

Switching expandlibs to use descriptors when they exist, even when there
is a static library (so, the opposite of the current behavior) allows to
drop -Wl,--whole-archive and prepare for a better future. However, as
mentioned, xpcomglue does still require to be linked through the static
library, so we need to make it a static library only.

To achieve that, we make NO_EXPAND_LIBS now actually mean no expandlibs
and use that to build the various different xpcomglues.
2014-10-04 10:33:00 +09:00
Stephen Pohl
e37e4e1a89 Bug 1077099: Add GreBinD to easily differentiate between Contents/Resources (GreD) and Contents/MacOS (GreBinD) on OSX. r=bsmedberg 2014-10-03 16:48:49 -04:00
Ed Morley
ff43ca3cc3 Merge mozilla-central and b2g-inbound 2014-10-03 15:20:08 +01:00
Ed Morley
e322389145 Backed out changeset a0b82c954206 (bug 1062709) for Windows mochitest 5 hangs 2014-10-03 15:06:16 +01:00
Ed Morley
ed062efcdf Backed out changeset 7a1b7d7eba12 (bug 1062709) 2014-10-03 15:05:26 +01:00
Andrew Osmond
758e28dde4 Bug 994912 - Add support for event-based notifications to media streams. r=roc, r=bz 2014-10-03 04:18:00 -04:00
Ryan VanderMeulen
8eb45d35cd Merge b-i to m-c. a=merge 2014-10-02 12:51:02 -04:00
Nicholas Nethercote
5b9ce4cc06 Bug 1062709 (part 2) - Clean up stack printing and fixing. r=dbaron.
--HG--
extra : rebase_source : 18158d4474cb8826813a3866eba57b710e14db99
2014-09-01 22:56:05 -07:00
Nicholas Nethercote
270fd1eda7 Bug 1062709 (part 1) - Add a frame number argument to NS_WalkStackCallback. r=dbaron.
--HG--
extra : rebase_source : 0f9b2d6310433ed56f5552706fcf2a96571aee25
2014-09-10 21:47:01 -07:00
Brian Birtles
5bc3dbc321 Bug 1074651 - Detect integer overflow in BaseTimeDuration::TicksFromMilliseconds; r=bz 2014-10-02 15:14:12 +09:00
Carsten "Tomcat" Book
1f82b2fb58 merge fx-team to mozilla-central a=merge 2014-09-30 15:10:47 +02:00
Stephen Pohl
cf2ca1fd7c Mac v2 signing - Bug 1060562 - Update xpcshell-tests for the new v2 bundle structure on OSX. r=jmaher 2014-09-29 11:51:29 -07:00
Stephen Pohl
b8761ffa6f Mac v2 signing - Bug 1050944 - Get Firefox to launch and run on OSX with the new .app bundle structure, made necessary by Apple's v2 signatures. r=smichaud, r=ted, sr=bsmedberg 2014-09-29 11:51:04 -07:00
Stephen Pohl
34a3832be4 Mac v2 signing - Bug 1048687 - Read dependentlibs.list from Contents/Resources due to the new .app bundle structure. r=bsmedberg 2014-09-29 11:51:00 -07:00
Ben Turner
141df104d6 Bug 994190 - 'Modify main-thread IndexedDB to use PBackground', r=khuey. 2014-09-26 16:21:57 -07:00
Anuj Agarwal
177cdd3fc8 Bug 1071100 - Moved nsRefPtr from nsAutoPtr.h to a new nsRefPtr.h r=froydnj 2014-09-26 10:53:47 -07:00
Cervantes Yu
e8f6bd690e Bug 1051633: Make sure magic file descriptors in the content process will not be taken for other uses. r=khuey
--HG--
extra : rebase_source : 5e2dedb855dd5e0e6637d6f42c80c69df8081971
2014-09-30 00:00:00 +08:00
Jim Mathies
ad73cb6c28 Bug 1072417 - Remove the browser.tabs.remote pref and turn everything it controls on by default. r=felipe 2014-09-29 16:11:08 -05:00
Birunthan Mohanathas
8fad8c433f Bug 1045289 - Change uses of "XPCom" to "XPCOM". r=froydnj 2014-09-26 07:20:23 +03:00
Birunthan Mohanathas
c96a33587d Bug 1045289 - Rename nsXPComInit.cpp to XPCOMInit.cpp. r=froydnj
--HG--
rename : xpcom/build/nsXPComInit.cpp => xpcom/build/XPCOMInit.cpp
2014-09-26 07:20:23 +03:00
Mike Hommey
bd8065dffa Bug 1072152 - Change chrome.manifest read order. r=bsmedberg
In case of multiple "resource" manifest entries for the same keyword, the
last registered one now takes precedence, like any other chrome manifest
entry.
2014-09-25 14:47:03 +09:00
Bob Owen
1d4728e803 Bug 1067312 - Create the low integrity temp directory when first requested. r=froydnj
At least one test expects the temporary directory to exist, so creating it in case other parts of the code do as well.
2014-09-15 16:51:28 +01:00
Brian Birtles
c0aa1e51cf Bug 1039924 part 8 - Include FloatingPoint.h in StickyTimeDuration.h; r=froydnj
Overlooked review feedback from comment:

  https://bugzilla.mozilla.org/show_bug.cgi?id=1039924#c43
2014-09-25 14:35:51 +09:00
Brian Birtles
953d64c3f3 Bug 1039924 part 7 - Add unary minus operator to BaseTimeDuration; r=froydnj
This patch adds the unary minus operator so, for example, we can write:

  TimeDuration sinceBeforeYourSunBurnedHot = -TimeDuration::Forever();
2014-09-25 14:25:50 +09:00
Brian Birtles
4c6a27410d Bug 1039924 part 5 - Add StickyTimeDuration; r=froydnj
This patch adds another implementation of BaseTimeDuration's ValueCalculator
template parameter that is careful to preserve Forever/-Forever values when
performing arithmetic.

It also defines a typedef for a specialization of BaseTimeDuration that uses
this new ValueCalculator definition.
2014-09-25 14:25:50 +09:00
Brian Birtles
c4e801e7cf Bug 1039924 part 4 - Fill out TimeDurationValueCalculator and use it; r=froydnj
This patch builds on the templatization from the previous patch to move
arithmetic on the mValue member of BaseTimeDuration to the ValueCalculator
template parameter.
2014-09-25 14:25:49 +09:00
Brian Birtles
99025a6c9b Bug 1039924 part 3 - Templatize TimeDuration so it can support different behaviors with regards to tick count arithmetic; r=froydnj
This patch prepares the way for having a separate StickyTimeDuration class
by factoring TimeDuration into a templated base class: BaseTimeDuration.
BaseTimeDuration takes a templated parameter, ValueCalculator, which is a helper
object that defines how various arithmetic operations are performed on its
mValue member (an int64_t count of ticks).

This patch does not actually define or use the ValueCalculator parameter yet but
simply performs the renaming and templatization.

With regards to the templatization, arithmetic operators are defined to take
objects with the same ValueCalculator template parameter (so that we don't, for
example, apply non-safe arithmetic to a StickyTimeDuration).
However, comparison operators are defined to also operate on objects with
a different ValueCalculator template parameter since comparison should be
independent of the type of arithmetic used.

Likewise, the constructor and assignment operator are defined to operate on
objects with a different ValueCalculator template parameter so that objects can
be converted from TimeDuration to StickyTimeDuration and vice-versa.
The constructor is marked as explicit, however, so that we don't silently
convert a StickyTimeDuration to a TimeDuration and unwittingly apply
non-safe arithmetic to a StickyTimeDuration.

TimeDuration is defined as a specialization of BaseTimeDuration that uses
TimeDurationValueCalculator as its ValueCalculator type.
TimeDurationValueCalculator is filled-in in a subsequent patch.
2014-09-25 14:25:49 +09:00
Brian Birtles
c668976a1d Bug 1039924 part 2 - Convert between Forever and Infinity when converting TimeDurations; r=froydnj
Now that the implementation of a number of TimeDuration methods have been
delegated to a separate TimeDurationPlatformUtils class, it is easier to add
consistent handling to the parameters passed to and from those methods.

This patch adds checks when converting between TimeDurations and doubles so that
Forever (represented by a tick count of INT64_MAX) is paired with
PositiveInfinity, and INT64_MIN is paired with NegativeInfinity.
2014-09-25 14:25:49 +09:00
Brian Birtles
01e071c1ca Bug 1039924 part 1 - Separate platform-dependent parts of TimeDuration into TimeDurationPlatformUtils; r=froydnj
In order to have different templated versions of TimeDuration we first split out
the platform-specific code so that this code doesn't need to concern itself with
templates (and because putting template code in .cpp files is messy).
2014-09-25 14:25:48 +09:00
Georg Fritzsche
7a7369f03f Bug 1071489 - Make nsTArrays BinaryIndexOf use our unified binary search implementation. r=waldo 2014-09-23 13:15:53 +02:00
Carsten "Tomcat" Book
08a692af54 Backed out changeset 1e25cd3e8219 (bug 1051633) for B2G ICS Emulator Opt m4 test failures 2014-09-24 11:28:37 +02:00
Cervantes Yu
a1663f5599 Bug 1051633: Make sure magic file descriptors in the content process will not be taken for other uses. r=khuey
--HG--
extra : rebase_source : 2c9baf6ac87744d7049c90284990c0aa48e0f058
2014-08-15 17:19:05 +08:00
Georg Fritzsche
8bee7684a2 Bug 1067989 - Unify some more binary search uses. r=waldo 2014-09-17 15:46:24 +02:00
Tom Schuster
314b0c946b Bug 1069694 - Remove or move around functions in OldDebugAPI. r=shu 2014-09-23 15:25:31 +02:00
Ed Morley
885ed792c4 Backed out changeset d353d79e0610 (bug 1051633) for non-unified build failures 2014-09-23 14:23:16 +01:00
Cervantes Yu
88ced9ca82 Bug 1051633: Make sure magic file descriptors in the content process will not be taken for other uses. r=khuey 2014-08-15 17:19:05 +08:00
Eric Rahm
63be794fa7 Bug 1060171 - Part 3: Map log level to logcat level in ConsoleService. r=dhylands 2014-09-22 15:33:36 -07:00
Eric Rahm
d68358c8cd Bug 1060171 - Part 1: Add log levels to nsIConsoleMessage. r=froydnj 2014-09-22 15:32:21 -07:00
Ryan VanderMeulen
6a5ec97f20 Merge m-c to inbound. a=merge 2014-09-22 15:51:51 -04:00
Ryan VanderMeulen
9ff8b15061 Merge m-c to inbound. a=merge 2014-09-22 15:50:08 -04:00
Benjamin Smedberg
dcb398c24f Bug 1069518 - XPTCall should refuse to implement interfaces with [notxpcom] methods, r=froydnj/bholley 2014-09-22 15:10:31 -04:00
Eric Rahm
e16aa3e787 Bug 1069490 - Part 2: Add columnNumber to nsIStackFrame and set in JSStackFrame. r=bz 2014-09-22 11:28:31 -07:00
Vlatko Markovic
2e30280054 Bug 1059216 - Verification of Trusted Hosted Apps manifest signature, part 1. r=dkeeler,rlb 2014-09-22 07:58:59 -07:00
Carsten "Tomcat" Book
796f840b5d Merge m-c to b2g-inbound 2014-09-22 14:11:15 +02:00
Nick Thomas
94293c5fdc Bug 1063237, include android sdk version in FirefoxOS update requests, r=dhylands 2014-09-22 22:08:01 +12:00
Josh Aas
1b3d3f7c47 Bug 1063318: Switch Chromium IPC code to Mozilla's ref/auto ptr types. Also fix thread safety bug. r=nfroyd 2014-09-19 13:17:17 -05:00
Ryan VanderMeulen
d67421653d Backed out changeset 317c684efd2d (bug 997908) for mochitest-e10s leaks. 2014-09-19 13:43:02 -04:00
Andrew McCreight
9b53fab543 Back out bug 1067505 for some kind of make package failure. 2014-09-19 10:31:53 -07:00
Steven Michaud
26428ec3b1 Bug 997908 - Test patch to make crash stacks better. r=mccr8 2014-09-19 11:59:40 -05:00
Andrew McCreight
b87adbdaa9 Bug 1067505 - Make nsCategoryManager into a strong memory reporter. r=njn
The nsCategoryManager singleton lives until very late in shutdown, so the unregister always fails.

It is okay to make it a strong reporter because it will always outlive the memory reporter manager anyways.
2014-09-19 09:35:23 -07:00
Christoph Kerschbaumer
08c7c1ab6a Bug 1038756: Callsites creating a channel in /xpcom/ (r=bsmedberg) 2014-09-21 09:43:58 -07:00
Nicholas Nethercote
4ad02135d1 Bug 1067711 (attempt 2) - Fix an assertion failure in the System memory reporter. r=erahm. 2014-09-17 18:23:33 -07:00
Wes Kocher
93c2bf5d43 Backed out changeset d77733726cae (bug 1063318) for b2g mochitest leaks 2014-09-18 16:30:33 -07:00
Josh Aas
22a272981e Bug 1063318: Switch Chromium IPC code to Mozilla's ref/auto ptr types. Also fix thread safety bug. r=nfroyd 2014-09-18 15:52:59 -05:00
Bill McCloskey
0d6c4e831b Bug 1063669 - Don't enable e10s if IME is detected (r=jimm) 2014-09-18 10:26:33 -07:00
Carsten "Tomcat" Book
568c38815e Backed out changeset ba6a9e60d2c6 (bug 1067711) for XPCshell Test failures 2014-09-18 11:50:34 +02:00
Nicholas Nethercote
cb599999ce Bug 1067711 - Fix an assertion failure in the System memory reporter. r=erahm.
--HG--
extra : rebase_source : 06fa4b0d706414901ce2475e987067d5cb4f0f6f
2014-09-17 18:23:33 -07:00
Nicholas Nethercote
a392905edb Bug 1067699 (part 2) - Add mfbt/JSONWriter.h and use it for memory reporting. r=froydnj.
--HG--
extra : rebase_source : 7eb21c4c20c0434b3b236d1c53cbef9cb6a4759c
2014-09-14 23:36:18 -07:00
Nicholas Nethercote
8ec14a3695 Bug 1067699 (part 1) - Export double-conversion.h normally from MFBT. r=froydnj.
--HG--
extra : rebase_source : 14c3d827f4d8015d8326612e82782c52dcf7335d
2014-09-16 23:33:05 -07:00
Ben Turner
26edfb8667 Backout bug 994190 and merge over some stuff that landed afterwards on a CLOSED TREE. 2014-09-17 19:36:01 -04:00
Andrew McCreight
6c017937fb Bug 1067505 - Make nsCategoryManager into a strong memory reporter. r=njn
The nsCategoryManager singleton lives until very late in shutdown, so the unregister always fails.

It is okay to make it a strong reporter because it will always outlive the memory reporter manager anyways.
2014-09-19 14:07:25 -07:00
Honza Bambas
cbcc956da6 Bug 1034638 - Don't make QPC to GTC fallback in TimeStamp_windows let change differences of previously taken timestamps, r=robarnold 2014-09-16 15:51:51 +02:00
Jeff Walden
21c168f61c Bug 1065774 - Be more precise in PromiseFlatString docs about why assigning PromiseFlatString(...) to a reference is safe. r=froydnj
--HG--
extra : rebase_source : aad06aa3b0a803abb678000f559b4a9d4736813c
2014-09-11 13:25:56 -07:00