This patch cleans up the DBus utilitys and helper classes. All functions
for sending have been removed. Their users have been converted to the
new methods in RawDBusConnection. Include statements have been cleaned
up as well. Some methods of DBusMessageRefPtr have been moved from the
header to the source file to prevent inclusion of the DBus API from within
the header file.
This patch changes BluetoothDBusService to use the new send methods
that have been added to RawDBusConnection. The conversion from the
old functions is
- dbus_func_send to Send,
- dbus_func_send_async to SendWithReply,
- dbus_func_args_async to SendWithReply,
- dbus_func_args to SendWithError, and
- dbus_func_args_timeout to SendWithError.
References to DBusCallback have been removed.
This patch adds methods for sending DBus messages to the class
RawDBusConnection. There are 3 types of interfaces.
- Send Sends a message over DBus. No error checking or
handling of replies is performed. These methods
do not block the sending thread.
- SendWithReply Sends a message over DBus and runs a call-back
function for the reply. This should be the default
case for most scenarios. These methods do not
block the sending thread.
- SendWithError Sends a message over DBus and waits for the reply
or an error. This interface has only been added for
some existing code that can safely block the sending
thread. Don't use it in new code.
These 3 types of interfaces represent what is currently used of the
existing send functions in DBusUtils. When all users have been converted
to the new methods, the interfaces in DBusUtils can be removed.
========
https://hg.mozilla.org/integration/gaia-central/rev/e836e146aa9b
Author: Julien Wajsberg <felash@gmail.com>
Desc: Merge pull request #12515 from julienw/913994-conversation-not-shown-after-sending-sometimes
Bug 913994 - [Messages] When sending SMS to a number included in a SMS, ...
========
https://hg.mozilla.org/integration/gaia-central/rev/3313fb5d45f2
Author: Julien Wajsberg <felash@gmail.com>
Desc: Bug 913994 - [Messages] When sending SMS to a number included in a SMS, we should load the thread after clicking on send r=gnarf
The problem was simple: we were not resetting inThread when handling the #new
hash.
========
https://hg.mozilla.org/integration/gaia-central/rev/b6b5d914d230
Author: Julien Wajsberg <felash@gmail.com>
Desc: Merge pull request #12514 from julienw/919962-dont-show-sms-conversion-banner-after-send
Bug 919962 - [MMS] Converting to text layout when sending a MMS r=gnarf
========
https://hg.mozilla.org/integration/gaia-central/rev/3bb63873c053
Author: Julien Wajsberg <felash@gmail.com>
Desc: Bug 919962 - [MMS] Converting to text layout when sending a MMS r=gnarf
We now display the banner in an asynchronous way therefore the previous way to
hide the banner synchronously didn't work.
This patch changes the logic then: instead of hiding the banner after displaying
it, it now prevents the banner from being displayed at all.
