Commit Graph

54 Commits

Author SHA1 Message Date
Ehsan Akhgari
2189d6a964 Bug 969883 - Remove some unneeded memory allocation failure handling code in table cell map code; r=dbaron
The data structures manipulated by this code use infallible memory
allocation, so the OOM handling code paths here are dead code.
2014-02-19 00:49:15 -05:00
Mats Palmgren
a7a36b9304 Bug 919318 - A few cosmetic changes after dropping the Get prefix on some methods. r=dholbert 2013-09-25 11:42:35 +00:00
Mats Palmgren
5a3cdd8297 Bug 919318 - Drop the Get prefix on the frame methods GetFirstContinuation, GetLastContinuation, GetFirstInFlow, GetLastInFlow and also on nsLayoutUtils::GetLastContinuationWithChild, because they never return null. r=dholbert 2013-09-25 11:42:34 +00:00
Ehsan Akhgari
5ee21d6d3f Bug 895322 - Part 1: Replace the usages of MOZ_STATIC_ASSERT with C++11 static_assert; r=Waldo
This patch was mostly generated by running the following scripts on the codebase, with some
manual changes made afterwards:

# static_assert.sh
#!/bin/bash
# Command to convert an NSPR integer type to the equivalent standard integer type

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name nsXPCOMCID.h \
       ! -name prtypes.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.cc" \
         -o -iname "*.mm" \) | \
    xargs -n 1 `dirname $0`/assert_replacer.py #sed -i -e "s/\b$1\b/$2/g"
}

convert MOZ_STATIC_ASSERT static_assert
hg rev --no-backup mfbt/Assertions.h \
                   media/webrtc/signaling/src/sipcc/core/includes/ccapi.h \
                   modules/libmar/src/mar_private.h \
                   modules/libmar/src/mar.h


# assert_replacer.py
#!/usr/bin/python

import sys
import re

pattern = re.compile(r"\bMOZ_STATIC_ASSERT\b")

def replaceInPlace(fname):
  print fname
  f = open(fname, "rw+")
  lines = f.readlines()
  for i in range(0, len(lines)):
    while True:
      index = re.search(pattern, lines[i])
      if index != None:
        index = index.start()
        lines[i] = lines[i][0:index] + "static_assert" + lines[i][index+len("MOZ_STATIC_ASSERT"):]
        for j in range(i + 1, len(lines)):
          if lines[j].find("                 ", index) == index:
            lines[j] = lines[j][0:index] + lines[j][index+4:]
          else:
            break
      else:
        break
  f.seek(0, 0)
  f.truncate()
  f.write("".join(lines))
  f.close()

argc = len(sys.argv)
for i in range(1, argc):
  replaceInPlace(sys.argv[i])

--HG--
extra : rebase_source : 4b4a4047d82f2c205b9fad8d56dfc3f1afc0b045
2013-07-18 13:59:53 -04:00
Nathan Froyd
1745100c57 Bug 860457 - use uintptr_t instead of unsigned long in celldata.h; r=dholbert 2013-04-10 12:56:22 -04:00
L. David Baron
822b2ca3bc Bug 781360 patch 3: Rename {nsIFrame,nsStyleContext,nsComputedDOMStyle}::GetStyle* to Style*, since they can never return null. r=dholbert
Except for the changes in:
  layout/generic/nsIFrame.h (part)
  layout/style/nsComputedDOMStyle.h (all)
  layout/style/nsRuleNode.cpp (part)
  layout/style/nsStyleContext.cpp (part)
  layout/style/nsStyleContext.h (part)
(see patch 3b in the bug), this patch was written with the sed script:
s/\<GetStyle\(Font\|Color\|List\|Text\|Visibility\|Quotes\|UserInterface\|TableBorder\|SVG\|Background\|Position\|TextReset\|Display\|Content\|UIReset\|Table\|Margin\|Padding\|Border\|Outline\|XUL\|SVGReset\|Column\)\>/Style\1/g
2013-02-16 13:51:02 -08:00
Mats Palmgren
6c53161814 Bug 786533 - Replace NS_MIN/NS_MAX with std::min/std::max and #include <algorithm> where needed. r=ehsan 2013-01-15 13:22:03 +01:00
Trevor Saunders
cdabdac86e bug 781409 - remove nsITableLayout r=roc,davidb 2012-08-08 09:05:17 -04:00
Mats Palmgren
f0b3151f9f Bug 815315 - Avoid crashing if the last row-group child frame was removed. r=bz 2012-12-01 01:10:40 +01:00
Ehsan Akhgari
0fd9123eac Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
This patch was generated by a script.  Here's the source of the script for
future reference:

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name nsXPCOMCID.h \
       ! -name prtypes.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t

convert PRIntn int
convert PRUintn unsigned

convert PRSize size_t

convert PROffset32 int32_t
convert PROffset64 int64_t

convert PRPtrdiff ptrdiff_t

convert PRFloat64 double
2012-08-22 11:56:38 -04:00
Aryeh Gregor
e806eeab4f Bug 777292 part 2 - Change all nsnull to nullptr 2012-07-30 17:20:58 +03:00
Jonathan Watt
6380335603 Bug 767388 - Kill NS_DEBUG. r=bz.
--HG--
extra : rebase_source : d045208a26345712dbb4628c973c616cd9504f28
2012-06-25 20:59:42 +01:00
Gervase Markham
ca171eec44 Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Mats Palmgren
1aca4ac3f0 Bug 720142 - Use nsIntRect for table damage. r=bernd 2012-01-22 23:48:34 +01:00
Bernd
e70661435d bug 710098 - use effective rowspan r=mats 2011-12-29 09:17:55 +01:00
Bernd
149c57c309 bug 711359 - mark all subsequent rows as damaged r=mats 2011-12-27 09:31:09 +01:00
Nicholas Nethercote
56767a7167 Bug 711908 - Fix a bunch of GCC warnings in layout. r=dbaron. 2011-12-19 19:46:39 -08:00
Bernd
86d65398f0 bug 705996 - the damageArea should only be set once the columns are in shape r=mats 2011-12-03 07:21:16 +01:00
Bernd
e1300ce0f1 bug 460637 - the group cellmaps need to set the damageArea relative to the entire table, patch by Mats Palmgren, Randell Jesup and Bernd, r=mats, bernd 2011-10-27 09:58:44 -04:00
Ehsan Akhgari
2a602a5685 Bug 690892 - Replace PR_TRUE/PR_FALSE with true/false on mozilla-central; rs=dbaron
Landing on a CLOSED TREE
2011-10-17 10:59:28 -04:00
Michael Wu
d8e503c38b Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones
--HG--
rename : tools/trace-malloc/bloatblame.c => tools/trace-malloc/bloatblame.cpp
2011-09-28 23:19:26 -07:00
Mats Palmgren
6894179e71 Bug 653649 - New way of getting child lists from frames. (part 4/5) r=roc
Remove the nsIAtom* child list names and use child list ID enum instead.
2011-08-24 22:54:30 +02:00
Ehsan Akhgari
e48161b8ff Bug 677661 - Remove nsTPtrArray and add a SafeElementAt(index_type) API to nsTArray when it's instantiated with a pointer type; r=sicking 2011-08-10 01:36:00 -04:00
Ms2ger
1ffb61c054 Bug 670500 - Make nsCellMap::Init return void; r=roc 2011-07-15 12:18:33 +02:00
Ms2ger
01867114b9 No bug - Fix assertion in nsCellMapColumnIterator::GetNextFrame; r=bz 2011-07-03 11:53:39 +02:00
timeless@mozdev.org
1278fea739 Bug 620259 - add fall through comments to nsTableCellMap::SetNotTopStart and rename to nsTableCellMap::ResetTopStart
r=bernd a=dbaron
2011-02-16 14:14:18 +01:00
Edmund Wong
7ef58c704b Bug 585336: Fix "a the" in comments (for General core code). r=timeless a=NPOTB (comment-only) 2010-08-15 15:50:02 -07:00
Bernd
b9b112f6a2 bug 564054 - rebuild cellmap if inserted rows contain a zero rowspan r=bzbarsky 2010-05-13 16:15:50 +02:00
timeless
83499da47b Bug 334571 Coverity 702, NS_SIDES array limit check - replace NS_FOR_CSS_SIDES defines with enum. r=zwol,mats 2010-04-27 18:15:02 +02:00
timeless
97c43a3297 Bug 334571 strip trailing whitespace. r=zwol 2010-04-27 18:15:01 +02:00
Ehren Metcalfe
e0ac5d5547 Bug 556446: Remove dead code in layout. r=roc,bz 2010-04-03 07:36:19 -04:00
Bernd
06f0fc48fa bug 378935 the border collapse code relies on having mutliple dead cell data entries in a row r=bzbarsky 2010-03-06 10:53:04 +01:00
Bernd
547f5ac844 bug 28800 remove support for scrollable rowgroups moa=roc r=bzbarsky 2010-01-16 17:05:46 +01:00
Reed Loden
d1bd3c0e15 Bug 506267 - [r=bzbarsky sr=dbaron] 2009-10-02 21:09:57 -05:00
Mats Palmgren
948203eb7d Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX. b=512106 r=roc 2009-09-16 17:01:36 +02:00
Alexander Surkov
df93a01d0c Bug 437980 - 9 tests fail in table_indexes.html chrome test file, r=marcoz, davidb, bernd 2009-06-29 18:54:26 +08:00
Boris Zbarsky
d44950aed3 Bug 487899. Start column indices incorrect in nsCellMap::ExpandWithCells if an array with more than one cell is passed in. r=bernd, sr=roc 2009-04-13 11:31:39 -04:00
Arpad Borsos
420adcef91 Bug 481932 - use do_QueryFrame instead of IS_TABLE_CELL + cast; r+sr=roc 2009-03-24 23:10:06 +01:00
Arpad Borsos
b8c7bb681a Bug 481881 - use better template arguments for nsTArray<T> after bug 474369, layout part; r+sr=roc 2009-03-12 08:26:29 +01:00
Karl Tomlinson
6a5bf5d169 backout dac7c3176b33 from bug 481881 2009-03-11 17:09:22 +13:00
Arpad Borsos
27f29d685d Bug 481881 - use better template arguments for nsTArray<T> after bug 474369, layout part r+sr=roc 2009-03-11 15:26:36 +13:00
Arpad Borsos
b2f9b630db Bug 474369 - get rid of nsVoidArray, layout/tables part. r+sr=roc 2009-02-05 10:09:50 +01:00
Mats Palmgren
d7a5093ec9 Subtract the row index from the row count, not the col count. b=284852 r=bernd sr=bzbarsky 2008-10-19 10:25:14 +02:00
bmlk@gmx.de
230b1fc082 use the firstinflow when looking up rowgroups bug 424291 r/sr=bzbarsky a=mtschrep 2008-03-21 13:37:31 -07:00
surkov.alexander@gmail.com
17652cbd2d Bug 416742 - Regression: multiple rowgroups interfere with getColumnAtIndex(), r=bernd, sr=roc, a=beltzner 2008-03-07 02:14:35 -08:00
bmlk@gmx.de
2821c28b31 expand the cellmap to cover empty content rows when rebuilding the cellmap bug 351326 r/sr=bzbarsky a=mtschrep 2008-02-20 21:11:36 -08:00
surkov.alexander@gmail.com
d35a90484c Bug 410052 - Fix our nsHTMLAccessibleTable class so GetIndexAt and GetRowAtIndex and GetColumnAtIndex behave consistently, patch=me, marcoz, r=marcoz, me, bernd, sr=roc, blocking1.9+=dsicore 2008-02-06 23:03:26 -08:00
fantasai.cvs@inkedblade.net
95c1b1c8ad nsTableCellMap::InsertRows shouldn't make damage area smaller, b=244135 p=malcolm.parsons r+sr=bz a=roc 2007-10-19 07:41:29 -07:00
fantasai.cvs@inkedblade.net
5728e0c20d fantasai is clearly having process troubles 2007-10-15 20:08:48 -07:00
fantasai.cvs@inkedblade.net
738be0d0d1 nsTableCellMap::InsertRows shouldn't make damage area smaller, b=244135 p=malcolm.parsons r+sr=bz a=roc 2007-10-15 20:06:36 -07:00