Commit Graph

180 Commits

Author SHA1 Message Date
Shawn Wilsher
385f2d5ef4 Bug 489481 - Get C++ tests for our C++ helper classes
This gets rid of the old, unused native code test file for storage.  It adds two
more test files which test our C++ helper classes to ensure that they behave as
advertised.  Also fixes a bug found in mozStorageTransaction that was uncovered
while writing these tests.
r=asuth
2009-05-13 12:53:57 -04:00
Shawn Wilsher
50a1970205 Bug 490833 - mozIStorageStatement::getParameterIndex should only accept :-named parameters
This makes getParameterIndex only work properly with :-named parameters.  This
simplifies the work callers actually have to do.
r=asuth
2009-05-08 20:29:57 -04:00
Shawn Wilsher
5a70a49dbf Bug 492139 - Expose the Variant publicly so consumers can also use it
This exposes the templated nsIVariant implementation that storage uses
internally so that consumers can use it as well.
r=bsmedberg

--HG--
rename : storage/src/mozStorageVariant.cpp => storage/src/Variant.cpp
rename : storage/src/mozStorageVariant.h => storage/src/Variant.h
2009-05-12 17:08:49 -04:00
Shawn Wilsher
b6c8d54bc7 Backed out changeset b6f09258a505 (bug 490833). 2009-05-08 19:57:37 -07:00
Shawn Wilsher
fa30ee0fe3 Bug 490833 - mozIStorageStatement::getParameterIndex should only accept :-named parameters
This makes getParameterIndex only work properly with :-named parameters.  This
simplifies the work callers actually have to do.
r=asuth
2009-05-08 20:29:57 -04:00
Shawn Wilsher
72e0d71c7b Bug 490084 - Add support for arrays in variantToSQLiteT
This adds support for blobs in variantToSQLiteT which means that functions can
no return blobs, as well as future consumers of variantToSQLiteT.
r=asuth
2009-05-08 20:29:57 -04:00
Shawn Wilsher
ef64e27404 Bug 490083 - Refactor VariantToSQLite3Result to be more abstract
This refactors this refactors a method currently only used by the Connection
object to be more abstract so we can use it in future work.
r=asuth
2009-05-08 20:29:57 -04:00
Shawn Wilsher
97575b6578 Bug 489702 - Update mozStorageStatement.* to follow style guidelines
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-05-08 20:29:56 -04:00
Shawn Wilsher
735ad5f28b Bug 489661 - Update mozStorageStatementWrapper.* to follow style guidelines
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-05-08 20:29:56 -04:00
Shawn Wilsher
9f81f7a68f Bug 489624 - Update mozStorageRow.* to follow style guidelines
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-05-08 20:29:56 -04:00
Shawn Wilsher
73a73e52ca Bug 489617 - Update mozStorageResultSet.* to follow style guidelines
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-05-08 20:29:56 -04:00
Shawn Wilsher
6f67edf0cc Bug 489612 - Update mozStoragePrivateHelpers.* to follow style guidelines
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-05-08 20:29:56 -04:00
Shawn Wilsher
b139ffaf75 Bug 489603 - Update mozStorageError.* to follow style guidelines
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-05-08 20:29:55 -04:00
Shawn Wilsher
41a0fe0c5f Bug 489257 - Rename and update mozStorageEvents.* to mozStorageAsyncStatementExecution.*
Renames the files to be more representative to what they actually contain.  This
also updates the files to follow the storage style guidelines.
r=asuth

--HG--
rename : storage/src/mozStorageEvents.cpp => storage/src/mozStorageAsyncStatementExecution.cpp
rename : storage/src/mozStorageEvents.h => storage/src/mozStorageAsyncStatementExecution.h
2009-04-21 11:27:03 -04:00
Shawn Wilsher
bd98500bbe Bug 489030 - Rename mozStorageValueArray.* to mozStorageArgValueArray.*
Better reflects the contents of the file.  Also updated the file to follow the
storage style guidelines.
r=asuth

--HG--
rename : storage/src/mozStorageValueArray.cpp => storage/src/mozStorageArgValueArray.cpp
rename : storage/src/mozStorageValueArray.h => storage/src/mozStorageArgValueArray.h
2009-04-20 08:01:51 -07:00
Shawn Wilsher
8728b1f8d7 Bug 489018 - Rename mozStorageUnicodeFunctions.* to mozStorageSQLFunctions.*
New filename better reflects current (and future) contents.  Also updates the
files to follow the storage style guidelines.
r=asuth

--HG--
rename : storage/src/mozStorageUnicodeFunctions.cpp => storage/src/mozStorageSQLFunctions.cpp
rename : storage/src/mozStorageUnicodeFunctions.h => storage/src/mozStorageSQLFunctions.h
2009-04-20 07:59:52 -07:00
Shawn Wilsher
c000eb400c Bug 488379 - Update mozStorageConnection.* to follow style guidelines
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-04-17 17:19:31 -04:00
Shawn Wilsher
1500bc4be0 Bug 487871 - Update vim modeline in style doc
Also updates the files that have already been updated.
r=asuth
2009-04-13 12:29:41 -04:00
Shawn Wilsher
147df7d9cf Bug 487715 - Update mozStorageVariant.* to follow style guidelines
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-04-10 13:20:12 -04:00
Matthew Hayward
317c5ccf32 Bug 461902 - Remove obsoleted 'CompletionNotifier::cancel()'
Removes some code that is no longer needed (or executed).
r=sdwilsh
2009-04-08 17:30:26 -04:00
Shawn Wilsher
f4ebe145db Bug 487145 - Update language helpers to follow style guidelines
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-04-08 12:24:25 -04:00
Shawn Wilsher
b8e49cdb07 Bug 487230 - Remove dead code in mozStorageValueArray.*
Removes code that appears to have never been used...
r=asuth
2009-04-08 12:24:22 -04:00
Shawn Wilsher
0f290684b1 Bug 485628 - Clean up mozStorageService.* to match what is in the style guidelines
Consistent spacing, consistent naming, and namespaces - OH MY!
r=asuth
2009-03-31 07:26:16 -07:00
Shawn Wilsher
b8a98024ba Bug 485626 - Update style guidelines to reflect namespace discussions
r=asuth
2009-03-31 07:26:08 -07:00
Paul O’Shannessy
a4489692b8 Bug 485223 - Stop checking mDBConnection is non-null in mozStorageStatement, r=sdwilsh 2009-03-27 10:15:33 -07:00
Shawn Wilsher
2288ad5bd3 Bug 484717 - Assert that our lock is held when the precondition says it should be
Use the new NSPR assertion to assert that a given PRLock is held when entering
a function.
r=asuth
2009-03-26 16:33:35 -04:00
Shawn Wilsher
ed0b0fdfa1 Bug 485071 - implement mozStorageStatementParams::NewEnumerate
This allows for the enumeration of named parameters on the parameter JS helper
object.
r=asuth
r=bent
2009-03-26 16:33:35 -04:00
Ted Mielczarek
dcc2d8f492 bug 482085 - fix all xpcshell tests to not reference files from the srcdir. r=bsmedberg,waldo
--HG--
rename : toolkit/components/downloads/test/downloads.empty.sqlite => browser/components/privatebrowsing/test/unit/downloads.empty.sqlite
rename : dom/src/json/test/fail1.json => dom/src/json/test/unit/fail1.json
rename : dom/src/json/test/fail10.json => dom/src/json/test/unit/fail10.json
rename : dom/src/json/test/fail11.json => dom/src/json/test/unit/fail11.json
rename : dom/src/json/test/fail12.json => dom/src/json/test/unit/fail12.json
rename : dom/src/json/test/fail13.json => dom/src/json/test/unit/fail13.json
rename : dom/src/json/test/fail14.json => dom/src/json/test/unit/fail14.json
rename : dom/src/json/test/fail15.json => dom/src/json/test/unit/fail15.json
rename : dom/src/json/test/fail16.json => dom/src/json/test/unit/fail16.json
rename : dom/src/json/test/fail17.json => dom/src/json/test/unit/fail17.json
rename : dom/src/json/test/fail18.json => dom/src/json/test/unit/fail18.json
rename : dom/src/json/test/fail19.json => dom/src/json/test/unit/fail19.json
rename : dom/src/json/test/fail2.json => dom/src/json/test/unit/fail2.json
rename : dom/src/json/test/fail20.json => dom/src/json/test/unit/fail20.json
rename : dom/src/json/test/fail21.json => dom/src/json/test/unit/fail21.json
rename : dom/src/json/test/fail22.json => dom/src/json/test/unit/fail22.json
rename : dom/src/json/test/fail23.json => dom/src/json/test/unit/fail23.json
rename : dom/src/json/test/fail24.json => dom/src/json/test/unit/fail24.json
rename : dom/src/json/test/fail25.json => dom/src/json/test/unit/fail25.json
rename : dom/src/json/test/fail26.json => dom/src/json/test/unit/fail26.json
rename : dom/src/json/test/fail27.json => dom/src/json/test/unit/fail27.json
rename : dom/src/json/test/fail28.json => dom/src/json/test/unit/fail28.json
rename : dom/src/json/test/fail29.json => dom/src/json/test/unit/fail29.json
rename : dom/src/json/test/fail3.json => dom/src/json/test/unit/fail3.json
rename : dom/src/json/test/fail30.json => dom/src/json/test/unit/fail30.json
rename : dom/src/json/test/fail31.json => dom/src/json/test/unit/fail31.json
rename : dom/src/json/test/fail32.json => dom/src/json/test/unit/fail32.json
rename : dom/src/json/test/fail33.json => dom/src/json/test/unit/fail33.json
rename : dom/src/json/test/fail34.json => dom/src/json/test/unit/fail34.json
rename : dom/src/json/test/fail4.json => dom/src/json/test/unit/fail4.json
rename : dom/src/json/test/fail5.json => dom/src/json/test/unit/fail5.json
rename : dom/src/json/test/fail6.json => dom/src/json/test/unit/fail6.json
rename : dom/src/json/test/fail7.json => dom/src/json/test/unit/fail7.json
rename : dom/src/json/test/fail8.json => dom/src/json/test/unit/fail8.json
rename : dom/src/json/test/fail9.json => dom/src/json/test/unit/fail9.json
rename : dom/src/json/test/json2.js => dom/src/json/test/unit/json2.js
rename : dom/src/json/test/pass1.json => dom/src/json/test/unit/pass1.json
rename : dom/src/json/test/pass3.json => dom/src/json/test/unit/pass3.json
rename : testing/xpcshell/example/location_load.js => testing/xpcshell/example/unit/location_load.js
rename : toolkit/components/commandlines/test/unit/unix/test_bug410156.js => toolkit/components/commandlines/test/unit_unix/test_bug410156.js
rename : toolkit/components/commandlines/test/unit/win/test_bug410156.js => toolkit/components/commandlines/test/unit_win/test_bug410156.js
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug257155/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug257155/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_a_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_a_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_a_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_a_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_b_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_b_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_b_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_b_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_c_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_c_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_c_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_c_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_d_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_d_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_d_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_d_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_e_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_e_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_e_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_e_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_f_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_f_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_f_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_f_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_g_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_g_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug299716_g_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug299716_g_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_3/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_3/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_4/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_4/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_5/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_5/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_6/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_6/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_7/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_7/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_8/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_8/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug324121_9/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug324121_9/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug335238_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug335238_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug335238_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug335238_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_10/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_10/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_11/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_11/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_12/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_12/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_13/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_13/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_3/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_3/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_4/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_4/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_5/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_5/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_6/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_6/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_7/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_7/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_8/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_8/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug378216_9/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug378216_9/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug394300_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug394300_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug394300_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug394300_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_a_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_a_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_a_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_a_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_b_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_b_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_b_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_b_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_c_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_c_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_c_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_c_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_d_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_d_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug396129_d_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug396129_d_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug397778/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug397778/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug425657/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug425657/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_1/README => toolkit/mozapps/extensions/test/addons/test_bug428341_1/README
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_3/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_3/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_4/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_4/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_5/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_5/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_6/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_6/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_7/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_7/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_8/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_8/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug428341_9/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug428341_9/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug436207/install.js => toolkit/mozapps/extensions/test/addons/test_bug436207/install.js
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_1/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_1/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_2/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_2/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_3/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_3/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_4/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_4/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_5/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_5/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_6/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_6/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_7/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_7/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_8/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_8/install.rdf
rename : toolkit/mozapps/extensions/test/unit/addons/test_bug463819_9/install.rdf => toolkit/mozapps/extensions/test/addons/test_bug463819_9/install.rdf
2009-03-21 11:20:00 -04:00
Shawn Wilsher
c0d5aa90c8 Bug 483152 - Stop giving the ability to get the native sqlite3_stmt pointer
We don't really want to give this pointer out to consumers since we track some
state, and if they call SQLite functions on it, can cause our internal state to
be inaccurate.
r=asuth
2009-03-20 18:41:01 -04:00
Shawn Wilsher
29a36fcf35 Bug 483154 - mozStorageStatementParams should use mozIStorageStatement API
This makes us use the public API on mozIStorageStatement, which centralizes some
of our logic.
r=asuth
r=bent
2009-03-20 18:41:01 -04:00
Shawn Wilsher
602c6d3591 Bug 483157 - mozStorageStatementRow needs to use mozIStorageStatement API
This makes our language helper use public API instead of calling SQLite
directly, which centralizes some of our logic.
r=asuth
r=bent
2009-03-20 18:41:01 -04:00
Shawn Wilsher
47975ac83e Bug 483880 - Pull out implementation of mozStorageVariant_base so we can include it in more than one file
The current implementation means it can only be #included once, which makes it
not terribly useful for other consumers.
r=asuth
2009-03-20 16:28:16 -04:00
Shawn Wilsher
3a001ab38a Bug 482159 - Add support for nsCString in mozStorageVariant
r=asuth
r=bent
2009-03-20 16:28:16 -04:00
Shawn Wilsher
20fa4cf2a5 Bug 481261 - Expose when queries are being inefficient in debug builds
Follow-up change to support suppressing the warning for a certain query, and
reducing the verbosity of the message.
r=asuth
2009-03-20 16:28:16 -04:00
Shawn Wilsher
435739dce2 Bug 483739 - Establish style guidelines for storage
This adds style.txt to storage/ that indicates how new code should be styled.
Reviewers are expected to enforce this!
r=asuth
2009-03-20 16:28:16 -04:00
Shawn Wilsher
3479ad4cd4 Bug 479728 - Rename AsyncExecute.
This renames the class to AsyncExecuteStatement to be a bit more clear as to
what it does.
r=asuth
2009-03-13 16:32:19 -07:00
Shawn Wilsher
563239f85e Bug 481261 - Expose when queries are being inefficient in debug builds.
This adds a warning in debug builds about queries that do not use an index to
sort, which tend to be much much slower.
r=asuth
2009-03-12 14:30:15 -04:00
Ben Turner
3c2befe831 Bug 482614 - mozStorageVariant leaks its internal data due to non-virtual destructor
Most commonly seen when using executeAsync and having the results return a
string or blob.
r=sdwilsh
2009-03-10 18:54:24 -04:00
Ryan VanderMeulen
1dbf142783 Bug 479543 - mozStorageConnection::Close should use NS_ERROR instead of NS_WARNING to complain about unfinalized statements; r=sdwilsh 2009-03-01 18:23:26 +01:00
Shawn Wilsher
df06927b79 Bug 479729 - Unable to shutdown using async statements.
This changeset finalizes statements before we try to rollback a transaction with
the async storage API.  This problem only came up when you canceled a statement.
r=asuth
2009-02-26 12:55:47 -05:00
Shawn Wilsher
c546f1d083 merge for backout 2009-02-23 17:35:19 -05:00
Shawn Wilsher
ec8db48c7e Backed out changeset f8926cd4a7b2 (bug 479543) since it breaks unit tests in
debug builds.
2009-02-23 17:34:46 -05:00
Alex Gartrell
57eed89aeb Bug 453781 - Merge TableExists and IndexExists, and replace nsCString with nsCAutoString
r=sdwilsh
2009-02-23 13:05:24 -05:00
Ryan VanderMeulen
a824b114b7 Bug 479543 - mozStorageConnection::Close should use NS_ERROR instead of NS_WARNING to complain about unfinalized statements
r=sdwilsh
2009-02-22 00:11:57 -05:00
Nilay Vaish
4bf92afb22 Bug 473268 - We should use forget instead of swap in mozStorageService.cpp; r=sdwilsh 2009-02-03 15:42:28 +01:00
Andrew Sutherland
d63e071cfb Bug 463907 - mozStorageConnection::ExecuteAsync does not check that provided statements have not been finalized; r=sdwilsh 2009-02-03 15:42:22 +01:00
Fred Jendrzejewski
8759b06c00 Bug 466622. Replace nsCStringArray with nsTArray<nsCString> for more consistent code and fewer heap allocations. r+sr=roc,r=bsmedberg
--HG--
extra : rebase_source : b963bf5de9d9c445b14620479691482512e0faf2
2009-01-22 17:15:34 +13:00
Blake Kaplan
bc907b65e6 Add missing return (from bug 473845). 2009-01-21 17:12:41 -08:00
Shawn Wilsher
5de65e03a2 Bug 473845 - Break a potential cycle with XPConnect and mozStroageService
This changeset removes a cycle that gets created between XPConnect and the
storage service.  This accomplishes this by releasing the cached reference to
XPConnect during xpcom-shutdown.

This was the last remaining leak of the browser-chrome test harness, so this
also sets the leak threshold to zero for that test.

r=bent
2009-01-21 16:52:16 -05:00
Drew Willcoxon
30cb71bdf3 Bug 384954 - Get xpcshell tests for wrapped statements
r=sdwilsh
2009-01-21 14:26:07 -05:00