Commit Graph

524 Commits

Author SHA1 Message Date
Michael Wu
27fd1e717b Bug 273025 - "bad logic results in potential leak xor crash based on flow" (Improve GetURL/PostURL code, v4 (2/2)) [r+sr=jst] 2009-12-27 14:26:00 -06:00
Oleg Romashin
bd7430f326 b=532627; nsPluginHostImpl::WritePluginInfo should call PR_Sync before PR_Close, r=jst 2009-12-23 13:58:54 +02:00
Blake Kaplan
b03049c0f2 Bug 535641 - Move this declaration around. r=jst 2009-12-22 16:54:06 -05:00
Josh Aas
ac8d51b495 Improve plugin instance stopped/started state management. b=535660 r=roc 2009-12-17 21:09:22 -05:00
Josh Aas
76e1222110 Stop storing xpconnect status in the plugin tag, it isn't used any more. b=535502 r=roc 2009-12-17 12:22:46 -05:00
Benjamin Smedberg
211d3738cb Merge mozilla-central to electrolysis. 2009-12-16 19:02:20 -05:00
Josh Aas
df4585ba38 Fix plugin host so that idle event timer can QI correctly and make the callback. b=535357 r=smichaud 2009-12-16 15:54:16 -05:00
Benjamin Smedberg
e9b0ccabad Bug 532751 - Notify the nsNPAPIPlugin and the related nsNPAPIPluginInstances when a plugin crashes so that reloading will create a new plugin process, r=josh 2009-12-16 15:08:45 -05:00
Benjamin Smedberg
234f5858ff Followup to review comment for bug 534866: don't set fCallbacks.size twice on MacOSX. 2009-12-16 09:10:30 -05:00
Benjamin Smedberg
ffeebc91f0 Merge mozilla-central into electrolysis 2009-12-16 08:38:42 -05:00
Josh Aas
a2cdef8b23 Separate plugin tag code from the plugin host. b=533371 r=jst 2009-12-16 08:16:42 -05:00
Benjamin Smedberg
097c85cae3 Bug 534866 - Fix Java and WMP plugins on Windows by initialize NPPluginFuncs.size before calling NP_Initialize, regression from bug 516509 which landed with the e10s merge, a=blocker-regression r?pending from josh 2009-12-15 21:24:26 -05:00
Josh Aas
733399cc7e Windows bustage fix, b=533371 2009-12-15 20:21:57 -05:00
Josh Aas
11a169cbb4 Separate plugin tag code from the plugin host. b=533371 r=jst 2009-12-15 17:47:22 -05:00
Josh Aas
df154de1eb Backed out changeset cbb4f67c6b68 2009-12-15 22:15:39 -05:00
Josh Aas
514a6c5e9d Greatly reduce the number of timers firing when multiple Carbon plugin instances are active on Mac OS X. Should reduce CPU usage. Make all instances use the same (at most two) timers for idle events. b=519598 r=roc 2009-12-15 15:44:52 -05:00
Josh Aas
e4ef56c1b9 Unset the plugin instance on the plugin instance owner if the instance fails to initialize. b=533030 r=jst 2009-12-15 15:28:12 -05:00
Benjamin Smedberg
999be86ac2 Merge mozilla-central into electrolysis. 2009-12-14 08:01:18 -05:00
Ben Turner
6e20a64631 Backing out changesets ed8d3323a50d, 3930bbdffdd5, 36e32abd2cc8, f4bcfc703ff9, 21051d997076, and 49f489315dd9 at the request of bsmedberg. 2009-12-11 12:48:37 -08:00
Benjamin Smedberg
cb534efdff Oh snap! nsPluginTag.mEntryPoint became a nsCOMPtr in a merge and ended up being double-released. Victory is mine! 2009-12-04 23:27:32 -05:00
Benjamin Smedberg
3e06063b78 !MOZ_IPC build bustage from bug 532751
--HG--
extra : rebase_source : a0b3a3318d3cd3d03fb034ae4d9fd5ab6cb9454a
2009-12-04 13:53:59 -05:00
Benjamin Smedberg
6e3d83cf38 Bug 532751 - Stop cacheing the nsNPAPIPlugin when it crashes, so that refreshing the page immediately reloads the plugin, r=bent pending r?joshmoz 2009-12-04 13:24:57 -05:00
Benjamin Smedberg
487e2582f8 Bug 532700 - nsNPAPIPluginInstance can outlive its nsNPAPIPlugin, sr=jst pending r=josh 2009-12-03 15:33:27 -05:00
Benjamin Smedberg
767eb11cb4 Merge mozilla-central into electrolysis 2009-12-04 11:28:50 -05:00
Benjamin Smedberg
13786e8a04 Bug 532605 - _write conflicts with symbols in the MSVC runtime. Remove all vestiges of PR_BEGIN_EXTERN_C from nsNPAPIPlugin.{h,cpp}, so that these functions are given C++ mangled names in the namespace we actually declared for them. 2009-12-03 09:17:49 -05:00
Ben Turner
ce1bd10179 Don't let plugin return a null window object and NPERR_NO_ERROR, r=jst. 2009-12-01 15:08:16 -08:00
Ben Turner
b17063546e Bug 526401 - Fixup handling of null NPP. r=bsmedberg. 2009-12-01 13:27:13 -08:00
Josh Aas
783c445e79 Fixing bug 520639. Make plugin library unloading independent of the lifetime of nsPluginTag objects. Patch and reviews by jst@mozilla.com and joshmoz@gmail.com, a=blocking1.9.2+ 2009-12-02 21:14:13 -08:00
Benjamin Smedberg
9911c2f99d Merge mozilla-central into Electrolysis 2009-11-30 12:59:43 -05:00
Johnny Stenback
c9d4899294 Fix for bug 531290 (Firefox 3.6b4 [@ PL_strlen | nsNPAPIPluginInstance::Initialize(nsIPluginInstanceOwner*, char const*) ] during npietab.dll initialization [@nsCOMPtr_base::assign_from_qi(nsQueryInterface, nsID const&) | xul.dll@0x9cc3c3 ]). r=josh, a=blocking1.9.2+. 2009-11-30 11:11:20 +01:00
Benjamin Smedberg
f7eb5c27ab Bug 530894 - Clean up TODOs in the plugin stream remoting: if NPN_{Get,Post}URLNotify fail, clean up the actor properly. Also deal with null postdata, which currently causes significant problems for the in-process case (NPN_PostURLNotify succeeds, but NPP_URLNotify is never called). r=bent 2009-11-25 09:26:01 -05:00
Josh Aas
a4b1dd24fa Fix a bug that prevents NPAPI plugins from retrieving cookies. b=526462 r=roc 2009-11-25 02:40:46 -05:00
Benjamin Smedberg
bda0f732bc Don't crash if NP_Initialize failed remotely: PluginLibrary::NP_Initialize returns an nsresult, not a NPError; nsNPAPIPlugin::CreatePlugin fails but still sets the outparam; nsPluginHost doesn't properly rv-check nsNPAPIPlugin::CreatePlugin, which causes us to think the bad plugin is actually good. I hate stupid failure chains! 2009-11-20 10:34:20 -05:00
Benjamin Smedberg
737515b2c8 Merge mozilla-central into electrolysis. 2009-11-19 12:41:46 -05:00
Benjamin Smedberg
453514dea2 Bug 523769 - Don't call into plugin hooks (specifically NPObject.deallocate) while mid-GC, r=jst+mrbkap 2009-11-17 14:51:46 -05:00
Ben Turner
cafe07f11b Bug 525792 - 'Fix leaks running mochitests'. 2009-11-12 14:16:54 -08:00
Benjamin Smedberg
17cf638aac Merge mozilla-central into electrolysis. 2009-11-11 12:35:42 -05:00
Benjamin Smedberg
281b9fd4a8 Merge from mozilla-central. 2009-11-06 09:54:28 -05:00
Chris Jones
f1358e3105 bug 525792: fix leaking PluginModules, call NP_Shutdown() on plugins. minor, no r= 2009-11-03 15:37:07 -06:00
Benjamin Smedberg
eba77abeb6 Merge mozilla-central into e10s. 2009-10-28 11:32:00 -04:00
Josh Aas
39b3aac40a Allow multiple types of OOP plugins to load. b=516509 r=cjones 2009-10-27 15:51:12 -04:00
Ben Turner
c650170292 Don't let people get the order of includes wrong in this horrifying patchwork of chromium and mozilla types 2009-10-21 16:01:16 -07:00
Benjamin Smedberg
15de24f35e Merge mozilla-central to electrolysis. 2009-10-20 12:08:28 -04:00
Benjamin Smedberg
fa058fc1f1 Merge mozilla-central to electrolysis to pick up bug 515436. 2009-10-12 10:51:38 -04:00
Rich Walsh
bdab68be3d [OS/2] Bug 516274 - fix plugin focus issues, r=pweilbacher 2009-10-12 11:10:38 +02:00
Ben Turner
80b478e8c5 Bug 516524 - Support NPRuntime across processes. r=bsmedberg. 2009-10-07 16:50:48 -07:00
Ben Turner
62534891fc Merge mozilla-central 2009-10-05 16:08:52 -07:00
Chris Jones
d215e057fe Merge backout 2009-10-02 18:09:39 -05:00
Chris Jones
08de77b6a4 Backed out changeset 8cbc47eee659 2009-10-02 18:09:08 -05:00
Blair McBride
9cdc2ead10 Bug 514327 - Detect outdated plugins and offer upgrade path. ui-r=beltzner, r=dtownsend,josh 2009-10-02 13:26:04 +02:00
Chris Jones
3e5fef214c bug 441324: implement infallible ::operator new(), malloc() and friends. make |new Foo()| infallible, but leave |malloc()| fallible for the time being. r=blassey sr=bsmedberg,vlad 2009-10-01 21:50:09 -05:00
Ben Turner
29c6cc37ec Merge mozilla-central 2009-09-23 13:14:34 -07:00
Rich Walsh
5c1a94f9fe [OS/2] Bug 517880 - Build Break following removal of nsplugindefs.h, r=pweilbacher 2009-09-22 15:49:26 +02:00
Josh Aas
8c81f341a1 Stop loading plugins with the name pattern "npjava*.dll" on Windows - these are old Java DLLs that won't work in Gecko 1.9.2+. b=527543 r=jst 2009-11-13 04:37:25 -05:00
Dave Townsend
8f787ba4fd Bug 471245: Unpacked extensions inadvertently enable plugins when reading chrome file at startup. r+sr=jst 2009-09-22 08:46:32 +01:00
Ben Turner
66a36315ce Merging mozilla-central once more to hopefully clear windows unit tests 2009-09-20 10:47:21 -07:00
Phil Ringnalda
e62c83fdc6 Bug 495228 - Remove checks for mac MOZ_WIDGET_TOOLKIT, r=ted 2009-09-18 19:59:53 -07:00
Benjamin Smedberg
d44f878b56 Merge mozilla-central into Electrolysis. 2009-09-18 16:47:18 -04:00
Jonathan Griffin
96ff9f6933 Bug 523216. Check for NULL message in NPN_SetException. r=joshmoz 2009-10-30 13:15:22 -07:00
Michael Wu
d38ee96a91 Improve GetURL/PostURL code
Bug 273025 - bad logic results in potential leak xor crash based on flow; v4, (1/2)
r+sr=jst
2009-10-29 01:29:44 +01:00
Jae-Seong Lee-Russo
1d5da93973 Bug 530389 - Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX in /modules/plugin/, r=joshmoz 2009-12-13 09:32:10 -08:00
Josh Aas
923b0e293c Gecko should use NPAPI directly, remove nsplugindefs.h abstractions. b=516661 r/sr=jst 2009-09-16 21:30:26 -04:00
Josh Aas
dd80aa5a05 Fix some spelling mistakes. No bug. 2009-11-10 00:16:05 -05:00
Josh Aas
d069d0092b Cocoa event model: 1) fix spurious NPP_SetWindow calls 2) propagate event model immediately. b=527115 r=smichaud r=roc 2009-11-09 22:58:48 -05:00
Benjamin Smedberg
84f70d6422 Bug 510963 - NPN_GetValue(NPNVPluginElementNPObject) is broken, r=josh
--HG--
extra : rebase_source : e1242620d2adfee22a5c8ede076e4d43916e72d9
2009-09-10 14:11:30 -04:00
Josh Aas
193b0904be Remove unused member variable that should have gone away in bug 506985. r=smichaud 2009-09-08 12:36:19 -04:00
Walter Meinl
c61a75f84d Bug 507807 - Clean up linking on OS/2; clean plugins on trunk for real
r=Weilbacher
2009-09-05 00:29:13 +02:00
Benjamin Smedberg
008e309c7f Bug 513032 - remove empty conditionals in our makefiles, r=ted 2009-08-27 10:48:18 -07:00
Ben Turner
fd54229708 Rename plugin protocols and fix up usage
--HG--
rename : dom/plugins/NPP.ipdl => dom/plugins/PPluginInstance.ipdl
rename : dom/plugins/NPAPI.ipdl => dom/plugins/PPluginModule.ipdl
rename : dom/plugins/NPObject.ipdl => dom/plugins/PPluginScriptableObject.ipdl
rename : dom/plugins/NPBrowserStream.ipdl => dom/plugins/PPluginStream.ipdl
rename : dom/plugins/NPPInstanceChild.cpp => dom/plugins/PluginInstanceChild.cpp
rename : dom/plugins/NPPInstanceChild.h => dom/plugins/PluginInstanceChild.h
rename : dom/plugins/NPPInstanceParent.cpp => dom/plugins/PluginInstanceParent.cpp
rename : dom/plugins/NPPInstanceParent.h => dom/plugins/PluginInstanceParent.h
rename : dom/plugins/NPAPIPluginChild.cpp => dom/plugins/PluginModuleChild.cpp
rename : dom/plugins/NPAPIPluginChild.h => dom/plugins/PluginModuleChild.h
rename : dom/plugins/NPAPIPluginParent.cpp => dom/plugins/PluginModuleParent.cpp
rename : dom/plugins/NPAPIPluginParent.h => dom/plugins/PluginModuleParent.h
rename : dom/plugins/NPObjectChild.cpp => dom/plugins/PluginScriptableObjectChild.cpp
rename : dom/plugins/NPObjectChild.h => dom/plugins/PluginScriptableObjectChild.h
rename : dom/plugins/NPObjectParent.cpp => dom/plugins/PluginScriptableObjectParent.cpp
rename : dom/plugins/NPObjectParent.h => dom/plugins/PluginScriptableObjectParent.h
rename : dom/plugins/NPBrowserStreamChild.cpp => dom/plugins/PluginStreamChild.cpp
rename : dom/plugins/NPBrowserStreamChild.h => dom/plugins/PluginStreamChild.h
rename : dom/plugins/NPBrowserStreamParent.cpp => dom/plugins/PluginStreamParent.cpp
rename : dom/plugins/NPBrowserStreamParent.h => dom/plugins/PluginStreamParent.h
2009-09-08 23:31:35 -07:00
Benjamin Smedberg
187a34a633 Merge mozilla-central into Electrolysis 2009-08-26 12:15:27 -04:00
Doug Turner
ea91fe7947 Bug 521257 - Support NPImageExpose on Maemo/Hildon only. r=roc 2009-10-26 22:18:35 -07:00
Benjamin Smedberg
2e9438fd2f Followup to bug 398573 - remove REQUIRES from the tree since it is no longer used... automatically generated patch, rs=ted 2009-08-25 08:59:31 -07:00
Josh Aas
cc8d9ebb04 Remove java-specific preferences from Firefox UI, hidden prefs. Java should be managed via the addons manager. Also improves accuracy of "window.navigator.javaEnabled()". b=506985 r/sr=jst uireview=faaborg 2009-08-24 15:56:43 -07:00
Mats Palmgren
de859aa548 Make the nsPluginInstanceTag destructor non-recursive to avoid exhausting stack space. b=486349 r+sr=jst 2009-08-19 02:25:36 +02:00
Benjamin Smedberg
0df64c6bc4 Additional followup to bug 398573 - remove REQUIRES from the tree even when they are in makefile conditional blocks
--HG--
extra : rebase_source : cc65c34a414e6c67a5651fc9cf0b6bd709ebcdbd
2009-08-27 08:53:13 -07:00
Josh Aas
65e80f6eb0 Implement Cocoa NPAPI event model. b=435041 sr=roc 2009-08-26 17:29:47 -07:00
Karl Tomlinson
0d378950db b=521940 don't paint the plugin socket window to avoid flicker on load r=roc
--HG--
extra : rebase_source : 9a0f5cf10ecd3c939e6f13c14c9bcd88ace5d457
2009-10-14 15:38:31 +13:00
Ben Turner
cd1d42ffe0 Merge mozilla-central 2009-07-30 11:28:07 -07:00
Rich Walsh
6911caefb0 [OS/2] Bug 500654: sync OS/2 plugin code with Windows version, to hopefully fix some Flash-related crashes, r=pweilbacher 2009-07-30 21:20:44 +03:00
Ben Turner
fd28e9de5a Allow out of process tabs and plugins to be disabled via prefs or environment variables, and disable them both by default so that unit tests go green. 2009-07-24 15:21:07 -07:00
Benjamin Smedberg
0501b7a589 Make --disable-ipc work... mac-ppc now builds by default. 2009-07-20 15:04:52 -04:00
Benjamin Smedberg
1e808cd4ea Merge mozilla-central into Electrolysis
--HG--
rename : modules/plugin/base/src/nsPluginHostImpl.cpp => modules/plugin/base/src/nsPluginHost.cpp
2009-07-20 09:36:23 -04:00
Martin Stránský
63b764f9ee Bug 486482 - null deref [@ nsPluginNativeWindowGtk2::CreateXEmbedWindow ]. r=josh, sr=jst 2009-07-21 10:13:38 +02:00
Vladimir Vukicevic
18db6edf40 b=503902; put back npapi DOM object access for WinCE; r=jst 2009-07-16 14:13:43 -07:00
Peter Weilbacher
eed6512282 Bug 503950: OS/2 bustage fix for bug 503377, p=wuno@lsvw, r=pweilbacher 2009-07-14 13:34:07 +02:00
Benjamin Smedberg
f962f665d1 Windows bustage fix for bug 503377 2009-07-13 12:57:32 -04:00
Benjamin Smedberg
7f34fe29a0 nsIPluginInstance.getMIMEType should be a [shared, const] parameter... it doesn't follow the normal XPCOM rules about allocating memory. r=josh sr=jst 2009-07-13 12:27:46 -04:00
Ginn Chen
bf66108343 Bug 501889 _scheduletimer symbol not found on Solaris r=joshmoz sr=jst 2009-07-13 20:23:41 +08:00
Josh Aas
c124a0981e Remove mIsJavaPlugin variable in nsNPAPIPluginInstance, fix some comments. b=503809 sr=roc 2009-07-12 22:44:48 -04:00
Ben Turner
67ac5c13b2 Some windows build fixup 2009-07-02 13:48:33 -07:00
Ben Turner
73f03dff53 merge bent's changes from libchromiumipc. Gtk plugins now drawing 2009-07-01 14:19:32 -07:00
Chris Jones
8aa21b1e90 merge plugin work from libchromiumipc. add env var check for OOP iframe. a few small bugfixes here and there. 2009-07-02 11:54:22 -05:00
Benjamin Smedberg
8620d95413 Plugins stuff: this code is equivalent to electrolysis-tmp revision 61cd9e89fd00, except that I had to merge forward a minor change to the plugin-loading code from Josh's cleanup. 2009-06-30 14:51:05 -04:00
Josh Aas
4a7715939e Bug 501194 - Remove nsplugin.h. r/sr=jst 2009-06-30 01:55:05 -04:00
Josh Aas
c81455d12a Remove plugin instance peers (nsIPluginInstancePeer, nsPIPluginInstancePeer). Second and final part of bug 500889. r/sr=jst 2009-06-29 14:53:52 -04:00
Josh Aas
4e45156e64 Bug 500889 - Remove nsIPluginInstancePeer2 and nsIPluginInstancePeer3, part 1 for removing plugin instance peers. b=500889 r/sr=jst 2009-06-28 19:43:19 -04:00
Josh Aas
c88c69078b Get rid of nsMIMEType type. b=503025 r/sr=jst 2009-07-08 23:25:20 -04:00
Josh Aas
00f32a1cf6 Remove some code that is no longer necessary for the Java plugin on AIX. b=498148 r/sr=jst 2009-07-07 21:01:38 -04:00
Josh Aas
f6ab658dab nsIPlugin and nsIPluginHost should not inherit from nsIFactory. b=502886 r/sr=jst 2009-07-07 21:00:11 -04:00
Hashem Masoud
c8f711113e Bug 489502 - Replace NS_ASSERTION(0, ...) by NS_ERROR(...) in mozilla-central; r=benjamin 2009-08-14 16:09:00 +02:00
Josh Aas
a62bb5d726 Various 64-bit fixes for Mac OS X widget and plugin code. b=509947 r=mstange 2009-08-12 18:32:41 -04:00
timeless@mozdev.org
6abbe0e4d8 Bug 508021 nsNPAPIPluginInstance::Print does not need to null check mCallbacks
r=jst
2009-08-12 11:49:55 +02:00
timeless@mozdev.org
d8ae4735cf Bug 505833 NPObjectMember_Convert is the only function that doesn't null check JS_GetInstancePrivate
r=joshmoz@gmail.com
2009-08-12 11:49:53 +02:00
timeless@mozdev.org
5e5171cd35 Bug 499295 NULL crash [@ nsPluginInstancePeerImpl::GetJSContext]
r=jst sr=jst
2009-06-27 18:42:51 -07:00
Peter Weilbacher
fff7a9a9d4 [OS/2] Bug 500938: fix build break in nsPluginNativeWindowOS2.cpp following bug 499431, p=dragtext@e-vertise, r=pweilbacher 2009-06-28 02:02:57 +03:00
Josh Aas
63a294b7fb Get rid of nsIWindowlessPluginInstancePeer. b=500672 r/sr=jst 2009-06-26 13:30:36 -04:00
Johnny Stenback
c773b6331b Fixing bug 484744. Revert an IID change that broke the old Java plugin. r+sr=mrbkap@gmail.com 2009-06-26 07:57:26 -07:00
Josh Aas
8246f24011 Don't allow access to any XPCOM objects view NPAPI's NPN_GetValue. b=500513 r/sr=jst 2009-06-26 10:33:17 -04:00
Josh Aas
e8777a84be Get rid of nsIPluginInstance::Destroy, it doesn't do anything. b=500593 r/sr=jst 2009-06-26 10:32:32 -04:00
Josh Aas
8cb99ebd34 Minor cleanup in nsPluginHostImpl, no bug. 2009-06-25 23:33:34 -04:00
Josh Aas
8f2046d4f3 Do a better job of checking for exceptions in npruntime, part 2. b=474157 r/sr=jst 2009-06-25 20:29:58 -04:00
Josh Aas
efafbe1392 Bustage fix for bug 499431. 2009-06-25 17:45:35 -04:00
Josh Aas
4734a09527 Remove nsIPluginManager/nsIPluginManager2. Fold their functionality into nsIPluginHost. b=499431 r/sr=jst 2009-06-25 17:06:54 -04:00
Jim Mathies
94a314575e Bug 493601 - Fix crash involving Flash module unloading. (r=emaijala,joshmoz,bent sr=brendan) 2009-06-23 06:27:44 -05:00
Josh Aas
9c6646e6e1 Remove os2wrapper and associated files. b=499367 r=Peter Weilbacher 2009-06-22 17:25:07 -04:00
Josh Aas
6ee771f1a3 Plugin host cleanup. b=501996 r/sr=jst 2009-07-06 02:10:10 -04:00
Peter Van der Beken
ca8ccf47e0 Fix for bug 482788 (Lightweight DOM wrappers). r=jst, sr=mrbkap. 2009-05-12 22:20:42 +02:00
Josh Aas
b7ddfbb92b Remove XPCOM plugin code from nsPluginsDirUnix. b=502045 r/sr=jst 2009-07-03 09:53:00 -04:00
Mats Palmgren
10964859cf Backout bug 486349, due to regression bug 502135. 2009-07-03 13:48:52 +02:00
Josh Aas
ec67370ccc Comment and formatting cleanup for nsIPlugin. No bug. 2009-07-02 15:32:21 -04:00
Mats Palmgren
9efb0b6e25 Make the nsPluginInstanceTag destructor non-recursive to avoid exhausting stack space. b=486349 r+sr=jst 2009-07-02 11:57:37 +02:00
Josh Aas
50f9732c36 Rename nsPluginHostImpl to nsPluginHost. No bug, discussed with jst.
--HG--
rename : modules/plugin/base/src/nsPluginHostImpl.cpp => modules/plugin/base/src/nsPluginHost.cpp
rename : modules/plugin/base/src/nsPluginHostImpl.h => modules/plugin/base/src/nsPluginHost.h
2009-07-02 01:48:08 -04:00
Josh Aas
70edf7241e Remove nsIPluginInstanceInternal, fold it into nsIPluginInstance. b=501786 r/sr=jst 2009-07-02 00:52:07 -04:00
Josh Aas
d5e66a3fb6 Remove nsIPluginTagInfo2, fold it into nsIPluginTagInfo. b=501812 r/sr=jst 2009-07-01 20:54:18 -04:00
Josh Aas
bd853b5bcf Add new timer APIs to NPAPI, NPN_ScheduleTimer and NPN_UnscheduleTimer. b=499921 r/sr=jst 2009-07-01 11:09:49 -04:00
Benjamin Smedberg
812128ba6a Bug 500660 - Don't load XPT files from plugin directories any more r=josh sr=jst 2009-07-01 09:34:31 -04:00
Johnny Stenback
a511964116 Fixing bug 442399. Remove LiveConnect from the tree. r=joshmoz@gmail.com, bclary@bclary.com, sr=brendan@mozilla.org 2009-06-30 15:55:16 -07:00
Josh Aas
c8ac5d9d83 Change plugin unloading behavior to never unload plugins by default. Prior to this patch plugins were unloaded whenever their last instance was destroyed. The old behavior meant that going from one page with a Flash instance to another page with a Flash instance would shut down the entire Flash plugin instead of just destroying one instance and starting another. The new behavior dramatically cuts down on plugin loading/unloading activity. Set "plugins.unloadASAP" to "true" to enable the old behavior of unloading plugins as soon as their last instance is destroyed. b=500925 r=bz sr=jst 2009-06-30 17:16:34 -04:00
Josh Aas
73eb23eeb9 Remove nsPIPluginHost. b=501388 r/sr=jst 2009-06-30 16:49:04 -04:00
Josh Aas
da90f79ce3 Remove nsIEventHandler, part of the XPCOM plugin API. b=499329 sr=sicking 2009-06-19 15:40:31 -04:00
Josh Aas
5dc8045c32 Remove nsIScriptablePlugin, part of the XPCOM plugin API. b=498164 r/sr=sicking 2009-06-19 15:37:09 -04:00
Karl Tomlinson
71d45a3a1a b=489294 XserverRegion leak with composited plugins r=jrmuizel 2009-06-15 12:52:11 +12:00
Josh Aas
86f210e336 Remove nsICookieStorage, part of the XPCOM plugin API. b=432354 r/sr=jst,sicking 2009-06-13 13:16:40 -07:00
Josh Aas
c68b8251be Remove nsIFileUtilities, part of the XPCOM plugin API. b=487977 r/sr=jst 2009-06-12 11:17:00 -07:00
Josh Aas
48858662d8 Disable XPCOM plugin loading. b=488042 r/sr=jst 2009-06-11 10:40:38 -07:00
Arpad Borsos
589f71c968 Bug 467948 - fix some deprecated conversion from string constant warnings; r=dbaron 2009-05-26 10:53:15 +02:00
Josh Aas
4bd6720b31 Simplify code for exposing plugin file names vs. full path. Second landing. b=488181 r/sr=jst,bz 2009-06-10 16:47:49 -04:00
Josh Aas
d3151f8707 Fix typo reversing some npruntime logic, fixes some problems with plugins using scripting. b=492924 sr=roc 2009-06-10 16:32:45 -04:00
Neil Deakin
79321ef1f8 Bug 178324, refactor focus by moving all focus handling into one place and simplifying it, add many tests, fixes many other bugs too numerous to mention in this small checkin comment, r=josh,smichaud,ere,dbaron,marco,neil,gavin,smaug,sr=smaug (CLOSED TREE) 2009-06-10 14:00:39 -04:00
Karl Tomlinson
43d4e0f67e Bug 494027 - Crash @NS_NotifyPluginCall on tinderbox shortly after plugin tests run. r+sr=jst@mozilla.org 2009-05-22 15:24:50 -07:00
Timothy Nikkel
96d0ffa774 Fix crash that can occur with a malformed pluginreg.dat file. b=493545 r=josh sr=bz 2009-05-20 12:21:46 -04:00
Josh Aas
5edcbc52ca Backed out changeset 7cd22106e8d9. Simplify code for exposing plugin file names vs. full path. b=488181 2009-05-16 21:09:48 -04:00
Josh Aas
22c9a18612 Simplify code for exposing plugin file names vs. full path. b=488181 r/sr=jst 2009-05-15 18:26:21 -04:00
Josh Aas
d01189121a Check for more accurate exceptions in npruntime, part 1. b=474157 r/sr=jst 2009-05-08 09:55:04 -04:00
Boris Zbarsky
64b2d5e1bf Bug 490957. Eliminate nsWebShell. r+sr=bsmedberg 2009-05-07 15:21:53 -04:00
Josh Aas
7882e36f78 Backed out changeset 7df4317278f5, bug 491834. 2009-05-07 09:27:08 -04:00
Josh Aas
c97cb0b630 Disable XPCOM plugin loading, removing support in Gecko 1.9.2. This will disable all non-NPAPI Java plugins (I suggest updating to at least Java 6 Update 12). b=488042 r/sr=jst 2009-05-07 01:17:07 -04:00
Dave Townsend
3a27432a29 Bug 427744: List plugin file version number under about:plugins. r=josh, sr=jst 2009-04-22 12:13:10 -07:00
Jeremy Huddleston
2c6c8fb6b9 Bug 486892 - darwin: Use dylib file extension. r=josh 2009-04-20 14:36:49 +02:00
Josh Aas
629cf7f757 64-bit fixes for nsPluginsDirDarwin. b=487972 r=mstange sr=jst 2009-04-14 12:38:11 -04:00
Josh Aas
1669178e09 Fix formatting of nsPluginsDirWin.cpp. b=488163 r/sr=jst 2009-04-14 12:35:35 -04:00
Serge Gautherie
bf78e8e9da Bug 438331 - Remove WIN16 (support) code everywhere; (Jv1) </modules/plugin/>; r=joshmoz sr=jst 2009-04-14 10:34:59 +02:00
John Wolfe
c016140bb4 Fix WinCE plugin bustage. b=487783 r=jimm 2009-04-10 14:33:32 -04:00
Mark Finkle
8e4a1ce44a Fix mobile plugin bustage. b=487795 r=josh 2009-04-10 12:45:24 -04:00
Josh Aas
c6a41e8074 Remove OJI from the tree. b=485984 r/sr=jst 2009-04-09 22:38:21 -04:00
Johnny Stenback
977b7eacfc Fixing bug 486269. Prevent plugins from being destroyed while calling into them. r=joshmoz@gmail.com, sr=bzbarsky@mit.edu 2009-04-07 14:20:57 -07:00
Neil Rashbrook
c0e5a3886c Bug 486946 Allocator mismatch between GetVersion and FreePluginInfo r+sr=jst 2009-04-07 10:22:34 +01:00
Arpad Borsos
f7163821d2 Bug 486940 - fix crash in gtk_xtbin_new; r=karlt, sr=roc 2009-04-06 13:30:55 +02:00
Karl Tomlinson
ebadbd17ad b=486630 detect early GtkXtBin destruction r=roc
--HG--
extra : rebase_source : a17a38faaeffebae0d4d8aadf0a3a58397aab8d9
2009-04-06 13:25:28 +12:00
Arpad Borsos
8d06591a1b Bug 474369 - get rid of nsVoidArray, plugin part; r=joshmoz, sr=jst 2009-03-28 14:57:13 +01:00
Doug Turner
979a387be4 Bug 484918 - Fixes build bustage in plugins on Windows CE. r=blassey 2009-03-23 20:27:27 -07:00
Josh Aas
db2a897753 NPN_SetValue should return an error when attempting to set a value that does not exist. b=479979 r/sr=jst 2009-03-17 14:20:24 -07:00
Josh Aas
3b5692c885 Formatting cleanup for the plugins module. b=462894 2009-03-17 14:20:02 -07:00
Stuart Parmenter
64dbc2c06b bug 482091. patch from Jeff Muizelaar. fix cash on maemo with plugins 2009-03-12 08:11:10 -07:00
Blake Kaplan
f7fb1c08eb Bug 482625 - Fix some warnings and remove some unneeded type declarations. r+sr=jst 2009-03-10 16:21:40 -07:00
Vladimir Vukicevic
162f8e4fdd b=479104; move windows plugin dir service code to UNICODE; r=jst 2009-03-08 22:07:00 -07:00
Jeff Muizelaar
de647c8035 Bug 442109 - youtube videos don't play; r=vladimir 2009-02-25 16:25:12 +01:00
Johnny Stenback
3d56357332 Fixing bug 475646. Don't call GetPeer() on plugins as it's apparently not safe to do so on all plugins. r=joshmoz@gmail.com, sr=bzbarsky@mit.edu 2009-02-24 16:28:35 -08:00
Blake Kaplan
099408ea29 Bug 477918 - Don't cast the narrower type to a wider type and write to it. r+sr=jst 2009-02-10 16:19:12 -08:00
Josh Aas
63e2d096d1 Clean up nsPluginHostImpl. Removes an old workaround for mac Flash 6. Stop using the phrase "active plugin" to refer to plugin instances. Dead code and spelling fixes. b=476409 r/sr=jst 2009-02-09 13:48:06 -05:00
Arpad Borsos
51bf75177c Bug 474116 - Clean up deprecated GTK symbols; r=(bsmedberg + roc) sr=roc 2009-02-02 18:49:58 +01:00
Josh Aas
015a5c7e76 Add API allowing plugins to participate in private browsing. b=468877 r/sr=jst 2009-01-30 16:40:14 -05:00
Johnny Stenback
b1945926a3 Fixing bug 474866. Make the plugin instance peer have a weak reference to its owner, and make the owner tell the peer once it's no longer its owner so we don't have reference cycles, yet the instance can hold on to its peer while being cached between pages. r+sr=mrbkap@gmail.com 2009-01-25 22:00:12 -08:00
Johnny Stenback
389a938400 Backed out changeset abd5a41c0b70 2009-01-25 11:19:51 -08:00
Johnny Stenback
7b13ea308c Fixing bug 474866. Don't null out the peer when stopping plugins to break reference cycles, as cached plugins depend on the peer remaining set. Null out the owner instead. r=joshmoz@gmail.com, sr=bzbarsky@mit.edu 2009-01-25 09:05:00 -08:00
Josh Aas
37e61ae8a0 JS delete operator should invoke npruntime removeProperty on NPObject. b=470291 r/sr=jst 2009-01-16 12:14:43 -05:00
Josh Aas
15d1bd14a4 Fix: npruntime NPN_HasMethod forwards to wrong plugin function (hasProperty). b=467945 r/sr=jst 2009-01-15 15:20:10 -05:00
Jonathan Griffin
b0762ec954 Bug 484729. Fix NPN_Write. r=joshmoz;sr=jst 2009-09-29 16:52:29 -07:00
Makoto Kato
d3cefcbb3b Should use LONG_PTR for plugin code due to Win64. b=472025 r=josh sr=jst 2009-01-13 13:15:39 -05:00
Johnny Stenback
71c558dbe8 Fixing bug 470993. Expose the remainder of the Java plugins XPCOM dependency through the NPAPI. r=joshmoz@gmail.com, sr=bzbarsky@mit.edu 2009-01-12 16:55:52 -08:00
Ben Turner
6eaa912dc9 Fix leaky cycle between nsNPAPIPluginInstance and nsPluginInstancePeer. b=472439 r=josh sr=jst 2009-01-10 12:13:31 -05:00
Josh Aas
d22f132370 NPAPI header updates - comments, cleanup, and webkit compat change. Part of the patch for 386676. r=smichaud sr=roc 2008-12-16 23:48:42 -05:00
Josh Aas
e79f540ada Backed out changeset 2776db2defa2 2008-12-16 14:38:58 -05:00
Josh Aas
6e9c3576aa Add a system for testing plugins. b=386676 r=smichaud sr=roc 2008-12-16 10:27:32 -05:00
Josh Aas
765a564b23 back out bug 468678 to fix Flash on Mac OS X 2008-12-15 12:29:44 -05:00
Josh Aas
5295053066 remove support for resource (.rsrc) files in Mac OS X plugins. b=468678 r=smichaud sr=roc 2008-12-11 16:52:42 -05:00
Josh Aas
026fa64495 windows bustage fix for bug 462023 2008-12-09 14:00:09 -05:00
Steven Michaud
a6e2974fc4 Don't allow plugin to set NPPVpluginWindowBool on OS X. b=466495 r=josh sr=roc 2008-12-09 11:22:51 -06:00
Josh Aas
e25e7f6560 Fix error case leak in nsPluginFile::GetPluginInfo. b=462023 r=mstange sr=jst 2008-12-09 12:15:49 -05:00
Josh Aas
95febf4b8c whitespace/minor cleanup for nsPluginsDirDarwin.cpp, no bug 2008-12-09 12:01:29 -05:00
Josh Aas
dc31683568 Remove support for "main" as a plugin initialization function. b=467429 r=smichaud sr=roc 2008-12-08 23:52:02 -05:00
Josh Aas
95648c862d remove support for CFM binary plugins. b=467417 r=smichaud sr=roc 2008-12-08 21:34:21 -05:00
Phil Ringnalda
bbe7e1d08a Bug 461888 - Remove unused PACKAGE_FILE and PACKAGE_VARS and .pkg files, mozilla-central part, r=bsmedberg 2008-11-03 19:46:28 -08:00
Josh Aas
319412e303 NPAPI impl formatting cleanup, round one. no bug, rs=jst 2008-11-03 14:23:07 -05:00
Dave Townsend
92bdda65fa Bug 455213: Plugins get enabled when updating to Firefox 3.1. r=jst, r=josh 2008-11-02 15:49:03 +00:00
Dave Townsend
d13a725406 Bug 455906: Support severities for blocklist entries. r=robstrong, r=jst
--HG--
rename : toolkit/mozapps/extensions/content/list.xul => toolkit/mozapps/extensions/content/blocklist.xul
rename : toolkit/mozapps/extensions/public/nsIBlocklistService.idl => xpcom/system/nsIBlocklistService.idl
2008-11-02 12:13:48 +00:00
Dave Townsend
d81de86f28 Backed out changeset bbccbf2c7456 2008-11-02 03:27:18 +00:00
Dave Townsend
f6b515d08c Bug 455906: Support severities for blocklist entries. r=robstrong, r=jst
--HG--
rename : toolkit/mozapps/extensions/content/list.xul => toolkit/mozapps/extensions/content/blocklist.xul
rename : toolkit/mozapps/extensions/public/nsIBlocklistService.idl => xpcom/system/nsIBlocklistService.idl
2008-11-02 01:34:45 +00:00
Jesse Ruderman
fdd437d15b Add bug number to FIXME comment 2008-10-28 14:42:21 -07:00
Josh Aas
997cd78337 fix new/malloc/delete/free mismatches. b=458104 r=mstange sr=dougt 2008-10-28 12:29:16 -07:00
Arpad Borsos
8b11d938d2 Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan 2008-10-10 17:04:34 +02:00
Dave Townsend
336531ba7f Backing out changeset 62274f98ccf8 from bug 455213 due to test failures 2008-10-09 12:55:47 +01:00
Dave Townsend
612a33103e Bug 455213: Plugins get enabled when updating to Firefox 3.1. r=jst, r=josh 2008-10-09 10:35:20 +01:00
Josh Aas
7029208c8f Clean up npupp.h and rename it to npfunctions.h. b=455458 r/sr=jst
--HG--
rename : modules/plugin/base/public/npupp.h => modules/plugin/base/public/npfunctions.h
2008-10-07 21:50:25 -04:00
Josh Aas
800552b4bf Stop referring to NPAPI plugins as "4x". b=454807 r/sr=jst 2008-09-15 08:45:01 -04:00
Josh Aas
db38657ac3 replace TRUE/FALSE usage with PR_TRUE/PR_FALSE. Patch by Antonio Gomes. b=454860 r/sr=jst 2008-09-12 16:49:43 -04:00
Josh Aas
97cc9f5009 Clean up ns4xPluginInstance code. b=454809 r/sr=jst 2008-09-12 16:23:30 -04:00
Josh Aas
38275d6c6e clean up ns4xPlugin. b=454279 r/sr=jst 2008-09-11 11:10:26 -04:00
Dave Townsend
3919bf60ce Bug 391728: No placeholder for disabled plugins. r=jst, r=josh, sr=bz 2008-09-09 16:43:21 +01:00
Arpad Borsos
9b6f558fee Bug 398946 - Remove JS_STATIC_DLL_CALLBACK and JS_DLL_CALLBACK from the tree; r=(benjamin + bent.mozilla) 2008-09-07 00:21:43 +02:00
Neil Rashbrook
647777257c Bug 420310 Unable to display uncached unnamed full-page plugin r+sr=jst 2008-08-26 12:40:13 +01:00
Josh Aas
204781a505 Don't stop plugins from loading just because they don't have a resource file. b=451234 r=smichaud sr=roc 2008-08-20 00:23:19 -04:00
Boris Zbarsky
ee8d552dd4 Bug 434163. Make sure to not let our hashtable mutate while we're iterating it. r+sr=jst 2008-08-18 13:06:16 -04:00
Josh Aas
85f462c5bc Fix gcc4.2 compile error. Patch by Simon Howes. b=450880 r=josh sr=roc 2008-08-18 02:25:35 -04:00
Josh Aas
073d83175f add ability to pull plugin info from a plugin's bundle plist file. allows us to load modern plugins that do not use resource forks. b=350109 r=smichaud sr=roc 2008-08-14 08:47:04 -04:00
Vladimir Vukicevic
d5014f52b1 [dfb,422221] Gtk/DirectFB: half-fix/enable plugins for DirectFB port 2008-08-06 13:48:55 -07:00
Vladimir Vukicevic
02e6b86b3b Backing out d883ab4b8f41:7540abc35c97 2008-08-06 16:24:13 -07:00
Vladimir Vukicevic
520cfba897 [dfb,422221] Gtk/DirectFB: half-fix/enable plugins for DirectFB port 2008-08-06 13:48:55 -07:00
Blake Kaplan
8ad8041884 Fix compiler warning: GCC is confused by the break-after-return to think that we can exit the switch without returning. No bug, r+sr=jst 2008-08-04 16:35:37 -07:00
Kathleen Brade
33369ee0be Fixing bug 328778. Make the UA string we pass to plugins be terminated at the last space or at max length if the string doesn't fit rather that just returning NULL. r+sr=jst@mozilla.org 2008-08-04 14:24:50 -07:00
Johnny Stenback
284d4d5208 Landing fix for bug 347805. Add support for passing information about failed HTTP streams to plugins. Patch by dbalev@adobe.com, r+sr=jst@mozilla.org 2008-08-04 14:17:55 -07:00
Dave Townsend
c229cbc346 Merge commit from 3.1a1 release branch 2008-07-25 12:43:43 -04:00
Johnny Stenback
61b8ad1bf4 Bug 444963: Java hangs browser. Release branch landing. r+sr=peterv 2008-07-25 12:42:08 -04:00
Peter Weilbacher
cd6d1e5fb5 [OS/2] Bug 446159: Fix build break in nsPluginsDirOS2.cpp and query plugin file version (for real this time!) 2008-07-25 00:08:33 +00:00
Blake Kaplan
33bb384e59 Reload 'entry' after JS_NewObject, since a nested GC could cause our hashtable to reallocate its store. bug 445229, r+sr=jst 2008-07-23 12:49:29 -04:00
Peter Weilbacher
30d017ac57 [OS/2] Bug 446159: query the plugin version resource on OS/2, r=mkaply 2008-07-19 18:06:47 +00:00
Peter Weilbacher
6b4d0a4822 Bug 446159: fix build break in nsPluginsDir for OS/2 and BeOS 2008-07-19 11:08:19 +00:00
Karl Tomlinson
40d0d78070 NPNVxDisplay for windowless plugins should not return the Display* of an XtBin. b=444252 r+sr=jst 2008-07-17 13:19:54 +12:00
Dave Townsend
8085fe1b73 Bug 427743: Expose file version of plugins. r+sr=jst 2008-07-15 11:50:42 +01:00
Boris Zbarsky
dc4e368d68 Bug 430424: Remove no longer needed code that munges "type" attributes in the DOM. r+sr=jst 2008-07-14 19:35:23 -04:00
Johnny Stenback
93ab034a20 Landing last part of the fix for bug 435334. Make our #ifdef OJI code really be just that, rather than tell us whether Java is available or not. r=joshmoz@gmail.com, sr=jonas@sicking.cc 2008-07-11 14:28:12 -07:00
Mats Palmgren
24a8f7bfba Annotate the out param with [shared] and add a comment about it. b=434429 r+sr=bzbarsky 2008-07-08 02:23:04 +02:00
Benjamin Smedberg
ec69c9db81 Bug 442735 - Annotate classes in dom/content which only appear on the stack, r+sr=jst 2008-06-30 21:03:50 -04:00
Justin Dolske
d7219011dd Bug 438394 – land workaround patch for unkillable hangs when loading VerifiedDownloadPlugin.plugin on trunk. r=josh 2008-06-29 17:05:48 -07:00
Johnny Stenback
6416a797ba Landing fix for bug 319371. Fix how we call NPP_GetURLNotify() in cases where the network load fails. Patch by wbardwel@curl.com, r+sr=jst@mozilla.org 2008-06-27 13:19:37 -07:00
Johnny Stenback
345c76bbcc First part of the fix for bug 435334. Move the JVM auth tools from the OJI code into the plugin code. The code in question is in no way dependent on OJI and will be completely removed once the NPAPI has support for what this code offers. r=joshmoz@gmail.com, sr=jonas@sicking.cc
--HG--
rename : modules/oji/public/nsIJVMAuthTools.idl => modules/plugin/base/public/nsIJVMAuthTools.idl
rename : modules/oji/src/nsJVMAuthTools.cpp => modules/plugin/base/src/nsJVMAuthTools.cpp
rename : modules/oji/src/nsJVMAuthTools.h => modules/plugin/base/src/nsJVMAuthTools.h
2008-06-27 12:27:40 -07:00
Johnny Stenback
7311e73894 Fixing bug 433880. Stop the flash player from crashing when entering full-screen mode. Patch by mats.palmgren@bredband.net, r+sr=jst@mozilla.org 2008-06-18 16:55:38 -07:00
pavlov@pavlov.net
b19f959e02 bug 422024. work around bad plugins causing a crash by using the wrong allocator to allocate. r/sr=jst 2008-04-30 17:17:54 -07:00
gavin@gavinsharp.com
6b243c5e13 Fix wrapping nit from bug 412770 2008-04-23 16:32:50 -07:00
gavin@gavinsharp.com
4d28dbad79 Bug 412770: Add ability to monitor plug-ins at run-time, patch by Fima Kachinski <xrayon@gmail.com>, r+sr=roc, sr=jst, a=beltzner 2008-04-23 16:24:21 -07:00
mats.palmgren@bredband.net
1b3c4d7918 Stop QuickTime and Flip4Mac plugins directly when requested (not off an event). b=426524 r+sr=jst a1.9=beltzner 2008-04-16 13:06:48 -07:00
alfred.peng@sun.com
19e85d635e Bug 426565. Firefox 3 crashes with Java applets. r+sr=jst,a=dsicore. 2008-04-05 21:38:27 -07:00
timeless@mozdev.org
5e0fcde278 Bug 423414 wmp called npapi on the wrong thread crashing [@ JS_RestoreFrameChain] r=jst a=beltzner 2008-03-30 08:23:21 -07:00
timeless@mozdev.org
58e9dcde09 Bug 425398 passed 0 identifier [@ NS_ConvertUTF8toUTF16 - doGetIdentifier - _getstringidentifier] r=jst sr=jst a=beltzner 2008-03-30 07:55:42 -07:00
timeless@mozdev.org
e03e3fc844 backing out 2008-03-30 07:41:47 -07:00
timeless@mozdev.org
d16166d275 Bug 425398 passed 0 identifier [@ NS_ConvertUTF8toUTF16 - doGetIdentifier - _getstringidentifier] r=jst sr=jst a=beltzner 2008-03-30 07:26:43 -07:00
jst@mozilla.org
f5ff3db7a8 Fixing bug 424019. Fix problem with NPN_RemoveProperty() claiming it removed a property when it in fact didn't. r+sr=brendan@mozilla.org 2008-03-28 15:29:14 -07:00
timeless@mozdev.org
74aa6aed94 Bug 424226 Immediate Fx crash when starting venkman [@ nsPluginHostImpl::TrySetUpPluginInstance] r=jst sr=jsr a=shaver 2008-03-24 23:00:31 -07:00
dbaron@dbaron.org
f31447da64 Fixing asymmetry between what timeless landed for bug 394114 and what he backed out. 2008-03-19 15:05:04 -07:00
timeless@mozdev.org
f33eb4a3b4 reverting, wrong patch, missing AMBIGUOUS 2008-03-19 14:55:22 -07:00