Commit Graph

1974 Commits

Author SHA1 Message Date
Nicholas Nethercote
d761b24aaf Bug 1124973 (part 2) - Introduce PL_DHashTableSearch(), and replace most PL_DHashTableLookup() calls with it. r=froydnj.
It feels safer to use a function with a new name, rather than just changing the
behaviour of the existing function.

For most of these cases the PL_DHashTableLookup() result was checked with
PL_DHASH_ENTRY_IS_{FREE,BUSY} so the conversion was easy. A few of them
preceded that check with a useless null check, but the intent of these was
still easy to determine.

I'll do the trickier ones in subsequent patches.
2015-01-22 21:06:55 -08:00
Nicholas Nethercote
de28f29126 Bug 1124920 - Remove PLDHashTable::Operate(). r=froydnj. 2015-01-22 15:43:18 -08:00
Patrick McManus
fdaefb68d6 bug 1116867 - make nsIProgressEventSink and nsITransportEventSink safely scriptable r=mayhemer r=bz
These scriptable interfaces use uint_64 arguments with sentinel values
of UINT64_MAX. However, UINT64_MAX exceeds MAX_SAFE_INTEGER and cannot
be gatewayed to/from javascript - so they cannot be used
correctly. Change them to use signed 64 bit numbers and -1 as the
sentinnel. C++ implementations ought to be enough to audit as the
special value could never be used correctly in JS anyhow - also
audited OnProgressChange() uses for downstream use of this data.
---
 dom/base/nsXMLHttpRequest.cpp                      | 19 +++++++----
 dom/base/nsXMLHttpRequest.h                        | 10 +++---
 dom/plugins/base/nsPluginStreamListenerPeer.cpp    |  4 +--
 .../webbrowserpersist/nsWebBrowserPersist.cpp      | 14 ++++----
 image/src/imgLoader.cpp                            |  4 +--
 modules/libjar/nsJARChannel.cpp                    |  3 +-
 netwerk/base/public/nsIProgressEventSink.idl       |  8 ++---
 netwerk/base/public/nsITransport.idl               |  8 ++---
 netwerk/base/public/nsNetUtil.h                    | 24 ++++++++++++++
 netwerk/base/src/Dashboard.cpp                     |  2 +-
 netwerk/base/src/nsBaseChannel.cpp                 | 12 +++----
 netwerk/base/src/nsIncrementalDownload.cpp         |  4 +--
 netwerk/base/src/nsSocketTransport2.cpp            |  5 +--
 netwerk/base/src/nsStreamTransportService.cpp      | 38 +++++++++++++---------
 netwerk/base/src/nsTransportUtils.cpp              | 12 +++----
 netwerk/protocol/file/nsFileChannel.cpp            |  8 +++--
 netwerk/protocol/ftp/nsFtpConnectionThread.cpp     |  4 +--
 netwerk/protocol/http/Http2Push.cpp                |  2 +-
 netwerk/protocol/http/Http2Session.cpp             |  2 +-
 netwerk/protocol/http/HttpChannelChild.cpp         | 31 +++++++++---------
 netwerk/protocol/http/HttpChannelChild.h           |  6 ++--
 netwerk/protocol/http/HttpChannelParent.cpp        |  4 +--
 netwerk/protocol/http/HttpChannelParent.h          |  4 +--
 netwerk/protocol/http/NullHttpTransaction.cpp      |  2 +-
 netwerk/protocol/http/PHttpChannel.ipdl            |  2 +-
 netwerk/protocol/http/SpdyPush31.cpp               |  2 +-
 netwerk/protocol/http/SpdySession31.cpp            |  2 +-
 netwerk/protocol/http/TunnelUtils.cpp              |  2 +-
 netwerk/protocol/http/nsAHttpTransaction.h         |  4 +--
 netwerk/protocol/http/nsHttpChannel.cpp            | 30 +++++++++++------
 netwerk/protocol/http/nsHttpConnection.cpp         |  4 +--
 netwerk/protocol/http/nsHttpConnectionMgr.cpp      |  4 +--
 netwerk/protocol/http/nsHttpPipeline.cpp           |  4 +--
 netwerk/protocol/http/nsHttpPipeline.h             |  6 ++--
 netwerk/protocol/http/nsHttpResponseHead.cpp       |  2 +-
 netwerk/protocol/http/nsHttpResponseHead.h         |  2 +-
 netwerk/protocol/http/nsHttpTransaction.cpp        | 32 +++++++++---------
 netwerk/protocol/http/nsHttpTransaction.h          |  2 +-
 netwerk/protocol/wyciwyg/WyciwygChannelChild.cpp   |  2 +-
 netwerk/protocol/wyciwyg/nsWyciwygChannel.cpp      |  3 +-
 netwerk/test/TestIncrementalDownload.cpp           |  7 ++--
 uriloader/base/nsDocLoader.cpp                     | 14 ++++----
 42 files changed, 203 insertions(+), 151 deletions(-)
2015-01-08 14:48:52 -05:00
Nicholas Nethercote
14f46aac14 Bug 1121304 (part 2, attempt 2) - Remove PLDHashTableOps::{alloc,free}Table. r=froydnj. 2015-01-14 14:35:56 -08:00
Phil Ringnalda
cb85f01b15 Backed out 2 changesets (bug 1121304) for consistent b2g hangs in webgl-color-test.html?frame=1&__&preserve&premult&_____
Backed out changeset 20651ac19549 (bug 1121304)
Backed out changeset 758afec77c95 (bug 1121304)
2015-01-14 22:02:23 -08:00
Nicholas Nethercote
60d7115c86 Bug 1121304 (part 2) - Remove PLDHashTableOps::{alloc,free}Table. r=froydnj. 2015-01-14 14:35:56 -08:00
Nicholas Nethercote
c4c1173204 Bug 1120476 (part 4) - Remove PLDHashTableOps::finalize. r=froydnj. 2015-01-13 19:02:35 -08:00
Nicholas Nethercote
7c92773a6f Bug 1120476 (part 3) - Remove PLDHashTable::data. r=froydnj. 2015-01-13 16:42:13 -08:00
Nicholas Nethercote
1f3c873a72 Bug 1120476 (part 2) - Avoid using PLDHashTable::data in nsCommandParams. r=froydnj. 2015-01-13 16:40:47 -08:00
Ehsan Akhgari
d58b165c03 Bug 1119261 - Mark virtual overridden functions as MOZ_OVERRIDE in embedding; r=bsmedberg 2015-01-12 23:26:27 -05:00
Wes Kocher
8fa3a755e3 Backout 58cb6ed02553 (bug 1120622, bug 1120620, bug 1119068, bug 1119268, bug 1119264, bug 1119261) for b2g build bustage on a CLOSED TREE 2015-01-12 14:48:13 -08:00
Ehsan Akhgari
a991ea3091 Bug 1119261 - Mark virtual overridden functions as MOZ_OVERRIDE in embedding; r=bsmedberg 2015-01-12 16:35:04 -05:00
Ryan VanderMeulen
530b23dd16 Bug 1119818 - Bump various UUIDs that were missed when IDL changes landed. r=jib, r=jdm, r=gavin, r=bz, a=me 2015-01-12 10:44:18 -05:00
Michael Pruett
c1d94593ae Bug 1118024 - Use new PL_DHashTable{Add,Lookup,Remove} functions. r=nfroyd 2015-01-05 20:27:28 -06:00
Ehsan Akhgari
3799d571b8 Bug 1114999 - Part 2: Apply MOZ_NO_ADDREF_RELEASE_ON_RETURN to all smart pointer arrow operators that can return refcounted objects; r=jrmuizel 2015-01-06 16:30:03 -05:00
Andrew McCreight
7f23c8d2b6 Bug 1064439, part 16 - Eliminate indirection in nsWebBrowser::mListenerArray. r=jst
Incidentally, this fixes a leak in nsWebBrowser::RemoveWebBrowserListener.
2014-12-16 09:18:02 -08:00
Andrew McCreight
ff849158b9 Bug 1064439, part 15 - Convert nsWebBrowser::mListenerArray to an nsAutoPtr. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
060d938f74 Bug 1064439, part 14 - Turn nsWebBrowser::mStream into an nsRefPtr and eliminate mStreamGuard. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
19f2159bd0 Bug 1064439, part 13 - Use nsAutoPtr for nsWebBrowser::mInitInfo. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
fa293dcef3 Bug 1064439, part 12 - Use nullptr in nsWebBrowser. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
163f4b1e9a Bug 1064439, part 11 - Make nsWebBrowser::mDocShellTreeOwner into an nsRefPtr. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
f94d75c249 Bug 1064439, part 10 - Take advantage of infallible alloc in nsWebBrowser. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
be5262c7ed Bug 1064439, part 9 - Get rid of a take in nsWebBrowser. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
adc175871b Bug 1064439, part 8b - Fix if( in nsWebBrowser.cpp. r=jst 2014-12-16 09:18:02 -08:00
Andrew McCreight
1817e0a074 Bug 1064439, part 8a - Get rid of trailing whitespace in nsWebBrowser. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
abac1a7041 Bug 1064439, part 7 - Surely DefaultTooltipTextProvider doesn't need threadsafe refcounting. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
1f39c35b2f Bug 1064439, part 6 - Get rid of weird C-style cast and QI of DefaultTooltipTextProvider. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
10d90c73f8 Bug 1064439, part 5 - Use nsRefPtrs in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
2b00178dbe Bug 1064439, part 4 - Use less ADDREF in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
58590cbdb6 Bug 1064439, part 3 - Take advantage of infallible new in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
a5d392acfd Bug 1064439, part 2 - Use nullptr in a few places in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
90b989741f Bug 1064439, part 1e - Get rid of more space around parens in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
40bbafe34c Bug 1064439, part 1d - Cuddle else in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
16b56ae1c4 Bug 1064439, part 1c - Get rid of if ( foo ) in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
3d7245314f Bug 1064439, part 1b - Get rid of if( in nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Andrew McCreight
56e19e5384 Bug 1064439, part 1a - Remove trailing whitespace from nsDocShellTreeOwner. r=jst 2014-12-16 09:18:01 -08:00
Ehsan Akhgari
57666729b5 Bug 1109746 - Fix more bad implicit constructors in some random code across the tree
--HG--
extra : amend_source : 48ca151cb1ca2193404c65831556051c02093914
2014-12-13 14:17:04 -05:00
Oleg Romashin
433fc957fc Bug 1103412 - Gecko does not compile with printing disabled. r=mconley 2014-11-22 12:15:00 +01:00
Neil Deakin
480511cee8 Bug 1060529, send the enabled state of child process commands to the parent on update, without the test, r=smaug,ehsan 2014-12-09 10:48:27 -05:00
Wes Kocher
a15fb273c2 Backed out 2 changesets (bug 1060529) for introducing a new intermittent bc1 orange
Backed out changeset 5ddd9eb25925 (bug 1060529)
Backed out changeset d4f962fb38be (bug 1060529)
2014-12-08 16:40:55 -08:00
Neil Deakin
b274e182b9 Bug 1060529, send the enabled state of child process commands to the parent on update, now with improved test, r=smaug,ehsan 2014-12-08 08:12:22 -05:00
Trevor Saunders
dfe4aecd6f bug 1105074 - make more stuff final r=froydnj 2014-11-25 13:56:07 -05:00
Jonathan Watt
f5355c12ae Bug 1103623 - Port most remaining gfxContext::Fill() calls to Moz2D. r=mattwoodrow 2014-11-24 00:04:33 +00:00
Nick Alexander
ec8ac4c085 Bug 1099501 - Export and use ANDROID_TOOLS where appropriate. r=snorp,bnicholson
In certain configurations, in particular when installing the Android SDK
using HomeBrew, one sees a configuration with symlinks like:

    [brian@brian-macbook git]$ ls -l /usr/local/Cellar/android-sdk/23.0.2/
    total 72
    ...
    lrwxr-xr-x   1 brian  admin    38 Nov 14 16:39 platforms -> ../../../var/lib/android-sdk/platforms
    ...
    drwxr-xr-x  26 brian  admin   884 Nov 14 17:43 tools

In this case, we have
ANDROID_SDK=/usr/local/Cellar/android-sdk/23.0.2/platforms/android-21.

It is an anti-pattern to use ANDORID_SDK/.. to find other paths in the
tree.  This pattern is used in at least two places:

1) When we try to find
/usr/local/Cellar/android-sdk/23.0.2/platforms/android-21/../../tools,
we end up in the /usr/local/var/lib subtree.  This patch works around
that by exporting and using ANDROID_TOOLS; ANDROID_TOOLS itself is
extracted using path matching, rather than following .. through the
filesystem.

2) We also need to use ANDROID_SDK_ROOT rather than
ANDROID_SDK/../.. through-out.

--HG--
extra : rebase_source : 5e0323a94f2b80550f17a624e16f338cdeec406d
2014-11-17 11:12:00 -08:00
Sid Stamm
2619fe592c Bug 704320 - Add referrer policy support for nsIWebBrowserPersist and its consumers. (r=jst) 2014-11-18 08:47:14 -05:00
Sid Stamm
dfa7cae372 Bug 704320 - content/dom changes for meta referrer support. (r=jst)
This enables referrer policies for:
- EventSource         (content/base/src/EventSource)
- XMLHttpRequest      (content/base/src/nsXMLHttpRequest)
- HTML media elements (content/html/content/src/HTMLMediaElement)
- window.open         (embedding/components/windowwatcher)
- window.location     (dom/base/nsLocation)
2014-11-18 08:47:03 -05:00
Sid Stamm
cafe8bb1f4 Bug 704320 - apply referrer policies to image loads (r=seth) 2014-11-18 08:46:53 -05:00
Mike Conley
8e659c9a63 Bug 1090444 - The Printing Progress dialog does not show progress or close when opened from the child process. r=blassey.
We now proxy progress updates from the child up to the parent over IPC.

--HG--
extra : rebase_source : a66557462e013ccf2b6e253c4b401d6baa0baa01
2014-11-10 15:18:06 -05:00
Mike Hommey
21ec48314e Bug 1077148 part 4 - Add and use new moz.build templates for Gecko programs and libraries. r=gps
There are, sadly, many combinations of linkage in use throughout the tree.
The main differentiator, though, is between program/libraries related to
Gecko or not. Kind of. Some need mozglue, some don't. Some need dependent
linkage, some standalone.

Anyways, these new templates remove the need to manually define the
right dependencies against xpcomglue, nspr, mozalloc and mozglue
in most cases.

Places that build programs and were resetting MOZ_GLUE_PROGRAM_LDFLAGS
or that build libraries and were resetting MOZ_GLUE_LDFLAGS can now
just not use those Gecko-specific templates.
2014-10-30 13:06:12 +09:00
Blake Kaplan
ac43f08a6a Bug 1049299 - Correctly calculate 3rd-party cookie status for content-process HTTP channels. r=jduell 2014-10-28 14:23:00 +01:00