Commit Graph

564 Commits

Author SHA1 Message Date
Byron Campen [:bwc]
e0a75522b5 Bug 1058331: Plug a leak in TransportLayerDtls::Setup, and remove a suppression. r=mt 2014-08-25 17:15:07 -07:00
Byron Campen [:bwc]
52313e00a3 Bug 1008789: Init username to 0, just in case. r=drno 2014-06-11 10:43:04 -07:00
Shih-Chiang Chien
16aedc2483 Bug 1053454 - disable remote TCP socket creation before TURN-TCP is e10s ready. r=ekr. 2014-09-03 11:02:11 +08:00
Mike Hommey
6258dd8523 Bug 1059090 - Don't require SOURCES to be set for CPP_UNIT_TESTS and SIMPLE_PROGRAMS. r=mshal 2014-09-03 14:16:37 +09:00
Mike Hommey
fc99c53ae5 Bug 1041941 - Use templates for programs, simple programs, libraries and C++ unit tests. r=gps 2014-09-03 14:10:54 +09:00
Ehsan Akhgari
dc28de8143 Bug 1061056 - Fix more bad implicit constructors in WebRTC; r=jesup 2014-09-01 17:43:17 -04:00
Byron Campen [:bwc]
0b5fa1a3c1 Bug 1008786: Zero outparams in nr_reg_fetch_node before we do anything that might abort. r=drno 2014-06-10 11:05:25 -07:00
Byron Campen [:bwc]
32ef235a1e Bug 991037 - Part 2: Convert over to full trickle, which allows some simplification of code, and makes the following work much easier. r=mt 2014-08-07 10:20:26 -07:00
Byron Campen [:bwc]
04e481a1d8 Bug 1057096 - Double the global STUN long-term rate limit. r=jesup
--HG--
extra : rebase_source : e50126158fe8581a3337e31870759618524c782a
2014-08-21 15:35:04 -07:00
Shih-Chiang Chien
d731e8e068 Bug 745283 - Part 3: Support send input stream and multicast operation via PUDPSocket.ipdl. r=jduell, r=mt 2014-05-06 18:32:25 +08:00
Randell Jesup
ba3dc5af84 Bug 1013007 - Re-enable STUN throttling in mid-beta and later. r=bwc 2014-08-11 17:53:51 -04:00
Nathan Froyd
631962a036 Bug 1055281 - check for existence of paths in LOCAL_INCLUDES in moz.build; r=mshal 2014-08-20 11:51:33 -04:00
Byron Campen [:bwc]
04ec4a749f Bug 1024028 - Part 1: Test that checking is reached in ice_unittest. r=drno 2014-08-06 10:36:01 -07:00
Byron Campen [:bwc]
4ffb784cdd Bug 1024028 - Part 2: Add an ice_checking callback that is fired when checking actually starts. r=drno 2014-08-06 11:34:55 -07:00
Shih-Chiang Chien
3d72ae267f Bug 1054908 - Ensure socket_child_ is released on main thread. r=mt 2014-08-18 19:14:00 -04:00
Ehsan Akhgari
846cc77ddd Bug 1053792 - Fix some bad implicit constructors in the mtransport code; r=jesup 2014-08-15 17:41:29 -04:00
Ralph Giles
3c372f1361 Bug 1052610 - Fix an unused variable warning. r=martin.thomson
Disabling the code while leaving the table it uses breaks -Werror.
2014-08-14 10:02:00 -07:00
Ralph Giles
fdccd07b28 Bug 1045231 - Namespace nrAppKit's htonll. r=abr
This avoids conflicts with any system-provided versions, like
on Apple MacOS X 10.10.
2014-08-14 10:05:00 -07:00
Martin Thomson
a7496d2d8d Bug 1052610 - Removing cipher suite profiling. r=ekr 2014-08-13 14:08:00 -05:00
Mike Hommey
a3eba4accf Bug 1050704 - Remove STLPORT_CPPFLAGS from Makefiles. r=mshal 2014-08-09 07:55:09 +09:00
Martin Thomson
f732264a57 Bug 1006207 - Remove offset from Packet class, forcing use of recv over read. r=ekr 2014-08-04 15:35:00 -04:00
Martin Thomson
4c4bff04e7 Bug 1006207 - Remove unused mode_ code. r=ekr 2014-08-04 15:34:00 -04:00
Mike Hommey
0f4c5d9244 Bug 1047267 - Move remaining OS_LIBS and EXTRA_LIBS to moz.build. r=gps
* * *
Bug 1047267 - To fold with "Move remaining OS_LIBS and EXTRA_LIBS to moz.build"
2014-08-07 14:21:03 +09:00
Mike Hommey
490b04e4f0 Bug 1050037 - Remove STLPORT_LIBS/STLPORT_LDFLAGS from Makefiles. r=mshal 2014-08-07 13:48:10 +09:00
EKR
c634b80303 Bug 1028582 - Modify TransportLayerDtls to force a fresh ECDHE server key. r=mt 2014-08-05 09:06:48 -07:00
Martin Thomson
bd58e64361 Bug 996237 - Check for DHE negotiation failure. r=ekr 2014-08-04 11:50:00 -04:00
Martin Thomson
afa8bcbb2e Bug 996237 - Tests for cipher mismatch. r=ekr 2014-08-04 11:50:00 -04:00
Martin Thomson
9b95d04978 Bug 996237 - Unit testing cipher suite selection happy path. r=ekr 2014-08-04 11:49:00 -04:00
Martin Thomson
7b591a212a Bug 996237 - Limit WebRTC cipher profiles. r=ekr 2014-08-04 11:49:00 -04:00
Ed Morley
076cbae1d4 Backed out changeset ab292958d0e7 (bug 996237) for build failures on Android 2014-08-04 15:34:42 +01:00
Ed Morley
7da815226f Backed out changeset 1015ade997be (bug 996237) 2014-08-04 15:34:25 +01:00
Ed Morley
1cbd2f3336 Backed out changeset 5cc4c2e9f1e4 (bug 996237) 2014-08-04 15:34:22 +01:00
Ed Morley
7a0239ee7e Backed out changeset 7c32b87be327 (bug 996237) 2014-08-04 15:34:18 +01:00
Martin Thomson
406a9ecfd2 Bug 996237 - Check for DHE negotiation failure. r=ekr 2014-07-31 17:47:00 -04:00
Martin Thomson
4d4cb1fb06 Bug 996237 - Tests for cipher mismatch. r=ekr 2014-07-31 17:45:00 -04:00
Martin Thomson
dd8aded4a6 Bug 996237 - Unit testing cipher suite selection happy path. r=ekr 2014-07-31 10:47:00 -04:00
Martin Thomson
8c4a34fabd Bug 996237 - Limit WebRTC cipher profiles. r=ekr 2014-07-31 17:45:00 -04:00
Jeff Walden
7760dae108 Bug 1037100 - Remove all use of ScopedDeleteArray from media/. r=ekr
--HG--
extra : rebase_source : 0f32325b868e5e07b0d2966aea7057a940004be9
2014-07-10 20:03:12 -07:00
Ryan VanderMeulen
cde39a4083 Merge inbound to m-c. a=merge 2014-08-01 15:59:05 -04:00
Andrei Vlad Postoaca
77e88a30be Bug 1032438 - Fix warnings in r_bitfield.c. r=abr 2014-07-02 08:35:00 -04:00
Andrew McCreight
6cc44b7ee7 Bug 1029478 - Remove dangerous public destructor of TransportFlow. r=abr 2014-07-31 10:05:58 -07:00
Mike Hommey
ad9b49263a Bug 1041936 part 2 - Directly use the static library "xul" to link into "xul-gtest" instead of having an intermediate library "xul" used by "xul-shared" and "xul-gtest". r=gps 2014-07-23 13:33:09 +09:00
Mike Hommey
71623acdd6 Bug 1036894 part 9 - Replace all EXTRA_DSO_LDOPTS, SHARED_LIBRARY_LIBS and LIBS with EXTRA_LIBS, OS_LIBS or OS_LDFLAGS, appropriately. r=gps
OS_LIBS for libraries that are not part of the gecko tree, EXTRA_LIBS for
libraries, such as NSPR, that are in the tree, but are not handled by
moz.build just yet. Those EXTRA_LIBS may also come from a system library.
However, in cases where the expanded variables are always empty for the
in-tree case, OS_LIBS is used (as for, e.g. MOZ_ZLIB_LIBS). OS_LDFLAGS is
used exclusively for non-library linker flags.

Always pass EXTRA_LIBS before OS_LIBS on linker command lines.

Forbid EXTRA_DSO_LDOPTS, SHARED_LIBRARY_LIBS and LIBS in Makefiles.
2014-07-23 13:31:02 +09:00
Mike Hommey
e5c43ef995 Bug 1036894 part 8 - Move most in-tree library linkage information to moz.build, as USE_LIBS. r=gps 2014-07-23 13:30:52 +09:00
Mike Hommey
90c742edc2 Bug 1036894 part 6 - Emit SimplePrograms for CPP_UNIT_TESTs, and make the corresponding moz.build config look like that of SIMPLE_PROGRAMS. r=gps 2014-07-23 13:29:44 +09:00
Mike Hommey
b99bba5c3f Bug 1041864 - Remove LIBRARY_NAMEs that aren't used. r=mshal 2014-07-23 08:39:56 +09:00
Byron Campen [:bwc]
4e8f07f64c Bug 942188 - Various fixes to role-conflict resolution and some test-cases. r=abr 2013-12-13 20:18:24 -08:00
Byron Campen [:bwc]
2048be3f64 Bug 980270 - Part 1: Plug a couple of common leaks in nICEr. r=drno 2014-03-06 14:43:15 -08:00
Anuj Agarwal
6d12620baf Bug 1028139 - DataBuffer should not be a refcounted class. r=jesup 2014-07-11 16:39:00 +02:00
Nils Ohlmeier [:drno]
4df013587a Bug 1034327 - fix memory leak when TURN client is used. r=bwc 2014-07-03 16:54:00 +02:00
Benoit Jacob
dc08dbb20e Bug 1028588 - Fix dangerous public destructors in media/mtransport - r=abr 2014-06-24 12:36:44 -04:00
Byron Campen [:bwc]
5571ac5825 Bug 1027938 - Bump max transmit count for ICE checks to 7. Also, adjust unit-tests. r=drno 2014-06-19 17:13:12 -07:00
Rishab Arora
0eec37db1a Bug 956525 - Replace 'Lower lower' in log messages with 'Lower layer'. r=abr 2014-01-20 07:38:00 -05:00
Benoit Jacob
5a3aa8f5da Bug 1027251 - Address review comments on mtransport - r=abr
(Sorry about that!)
2014-06-21 00:09:48 -04:00
Benoit Jacob
efe5bdffd5 Bug 1027251 - Fix or whitelist dangerous public destructors in media/mtransport - r=abr 2014-06-20 07:08:24 -04:00
EKR
5986c65e5c Bug 1009227. Unit test for fix for DTLS connection establishment failure. r=mt 2014-06-17 14:30:28 -07:00
Jan Beich
636b64db51 Bug 1024510 - Unbreak --with-system-nss build after bug 1022812. r=mshal 2014-06-16 01:02:25 -04:00
Byron Campen [:bwc]
4a0a0e70ca Bug 1017332 - Part 1: Dump the r_log ringbuffer on all ICE failures. r=ekr, r=jesup 2014-06-12 17:22:00 -07:00
Byron Campen [:bwc]
1f7eeb76d8 Bug 1008796 - Fix return value in nr_ice_component_stun_server_default_cb. r=ekr 2014-06-10 10:45:01 -07:00
Byron Campen [:bwc]
881184c858 Bug 1022776 - Bump max transmit count by 1 and modify unit-tests to compensate. r=ekr 2014-06-09 17:31:44 -07:00
EKR
a2a4a9a1bc Bug 1022812 - Link a debuggable version of NSS into media/mtransport. r=mt 2014-06-11 07:17:02 -07:00
Byron Campen [:bwc]
0a653f0e9c Bug 1004530 - Part 3: Unit test that verifies that new pairs will start when local gather happens after all preceding pairs have failed, provided the grace period has not elapsed. Also a couple more tests that use a new test-case feature. 2014-06-04 17:21:59 -07:00
Byron Campen [:bwc]
582d112d7e Bug 1004530 - Part 2: Unit test for verifying that local candidates gathered after the check timer has stopped are ultimately scheduled. 2014-06-03 10:56:54 -07:00
Byron Campen [:bwc]
e28d5a8b95 Bug 1004530 - Part 1: Allow a grace period for trickle candidates to arrive when all candidate pairs have failed. r=drno, r=ekr 2014-05-01 14:07:54 -07:00
Adam Roach [:abr]
04d763f9a3 Bug 1017755 - Make DTLS 'would have blocked' messages less aggressive r=jesup 2014-05-30 20:02:36 -05:00
Randell Jesup
79df25773b Bug 987979: Patch 3 - Fix various build issues in webrtc.org/Mozilla integration. r=rjesup 2014-05-29 17:05:14 -04:00
Byron Campen [:bwc]
865d18fb03 Bug 891551 - Part 2: (Upliftable) Fix bugs where PR_WOULD_BLOCK_ERROR (or, in some cases, PR_NOT_CONNECTED_ERROR while a TCP socket was connecting) would cause sockets to be abandoned for no good reason (see also bug 985493 and 1001671). r=bwc 2014-05-02 10:49:00 -07:00
Anders Lund
4fb3d4f35c Bug 942188 - Added parsing of ice-lite attribute and start ice checks as controlling if peer is ice-lite. r=abr 2014-05-16 01:32:00 -05:00
Jan Beich
0740628072 Bug 916589 - Rename __offsetof() to avoid conflict with platform-specific definition. r=docfaraday 2013-09-15 10:47:00 +02:00
EKR
b0ca419e1e Bug 1012999: When STUN global rate limit is exceeded, record this in telemetry. r=ekr 2014-05-19 19:16:38 -07:00
Peter Tatrai
f0723f9b3c Bug 891551 - Part 3: Fix bug where we weren't performing a null check in dtor for NrSocket (see also bug 987380). r=bwc 2014-05-02 10:50:00 -07:00
Byron Campen [:bwc]
c32065d176 Bug 891551 - Part 1: A couple of include-what-you-use fixes to the pre-existing code. r=ekr 2014-04-01 13:13:59 -07:00
Nathan Froyd
84fe2fd3b7 Bug 968803 - part 2 - statically type runnable classes that return a result; r=ekr 2014-02-06 10:21:55 -05:00
Nathan Froyd
a994e7598e Bug 968803 - part 1 - factor out class naming into its own function; r=ekr 2014-02-05 16:17:02 -05:00
Birunthan Mohanathas
ff8ce9bd42 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
Byron Campen [:bwc]
43e6a498e7 Bug 1000858: Fix r_gettimeint on win32 which prevented us from sending TURN allocations r=ekr 2014-04-24 16:56:00 -07:00
Byron Campen [:bwc]
f4e4f8cb6b Bug 987942 - Check whether PK11_CreateContextBySymKey returns null. r=ekr 2014-04-01 14:30:58 -07:00
Edgar Chen
2fc8f9200b Bug 978709 - 4.h/6: NetworkInterfaceListService changes. r=vicamo 2014-03-29 15:18:25 +08:00
Ehsan Akhgari
5b9f45a1a5 Bug 798158 - Part 1: Use a pointer-sized type to store refcounts internally; r=bsmedberg 2014-03-27 16:38:33 -04:00
Jessica Jong
6552af2779 Bug 984327 - Part 1: Include dun apn type in isNetworkTypeSecondaryMobile(...) and elsewhere. r=vicamo 2014-03-19 08:39:00 -04:00
Nils Ohlmeier [:drno]
bc5397115e Bug 966569 - Improve the the log messages in case the internal TURN TCP buffer over flow. r=bwc 2014-03-18 08:39:54 -04:00
Neil Rashbrook
c3b2f90f39 Bug 514280 Stop using nsCOMPtr for concrete types r=bsmedberg
--HG--
extra : rebase_source : f8fb50de9292320eb7589dd28dc566d0f5044da6
2014-03-18 00:23:03 +00:00
Wes Kocher
c0dba87922 Backed out 2 changesets (bug 514280) for OSX build bustage on a CLOSED TREE
Backed out changeset 2a015b45d808 (bug 514280)
Backed out changeset a01f97c1ed02 (bug 514280)
2014-03-17 15:19:53 -07:00
Neil Rashbrook
b07eaa1644 Bug 514280 Stop using nsCOMPtr for concrete types r=bsmedberg
--HG--
extra : rebase_source : eaca8b2925eaffb49e29a617cd72c0d6686e6d9e
2014-03-17 19:07:09 +00:00
Kyle Huey
84360900b0 Bug 967364: Pass already_AddRefed by reference instead of by value. r=bsmedberg 2014-03-15 12:00:17 -07:00
Kyle Huey
510a49016d Bug 967364: Rename already_AddRefed::get to take. r=bsmedberg 2014-03-15 12:00:15 -07:00
Byron Campen [:bwc]
61fa945539 Bug 966564 - Make logging more clear when processing an unwrapped indication. r=drno 2014-03-12 10:21:48 -07:00
Chris Peterson
eb44b1f66e Bug 980810 - Part 3: Fix clang -Wstring-conversion warnings in UDPSocket and mtransport code. r=bwc 2014-03-07 22:57:15 -08:00
Byron Campen [:bwc]
964dc99bb7 Bug 786234 - Part 3: Plumbing for filtration, and bundle usage detection. r=abr 2014-01-14 16:29:42 -08:00
Wes Kocher
b5db6f03fa Merge inbound to m-c 2014-02-24 17:45:16 -08:00
Patrick Wang (Chih-Kai Wang)
ef6afd5a92 Bug 969469: use SyncRunnable to get local interface information on gonk. r=bwc 2014-02-18 14:44:45 +08:00
Adam Roach [:abr]
f17dbb14ab Backed out changeset c5334aea6433 (bug 786234) 2014-02-24 12:29:10 -06:00
Alex Xu
dfa9abb426 Bug 967006 - Fix Clang build failure in nICEr. r=abr 2014-02-24 10:09:55 -05:00
Nils Ohlmeier [:drno]
b7ea253545 Bug 972592 - Make ICE 400 response strings more verbose for easier debugging. r=bwc 2014-02-18 09:58:25 -05:00
Byron Campen [:bwc]
8c4cea2760 Bug 786234 - Part 3: Plumbing for filtration and bundle usage detection. r=abr 2014-01-14 16:29:42 -08:00
Ehsan Akhgari
ddc6613b8e Bug 973395 - Move the LOCAL_INCLUDES in media to moz.build; r=glandium 2014-02-18 01:15:48 -05:00
Ms2ger
6e066deaea Bug 968856 - Move unconditional LOCAL_INCLUDES into moz.build; r=mshal 2014-02-15 21:24:59 +01:00
EKR
62b42b7427 Bug 970569 - Fix crasher introduced by bug 928930. r=bwc 2014-02-10 14:45:42 -08:00
Byron Campen [:bwc]
9f5ebeb6ea Bug 961313 - Add the transport protocol to candidate labels. r=abr 2014-01-27 10:35:17 -08:00
Nathan Froyd
4af2623008 Bug 928930 - don't define std::string variables in nricectx.h; r=ekr 2014-01-27 11:02:51 -05:00
Ryan VanderMeulen
f22a8b79ea Backed out changeset ce887b471785 (bug 961313) for buffered_stun_socket_unittest crashes, again. 2014-01-27 09:41:48 -05:00
Byron Campen [:bwc]
2bee0325a6 Bug 962371 - Part 2: Remove some magic constants. r=abr 2014-01-23 11:00:32 -08:00
Byron Campen [:bwc]
c1752a8ad0 Bug 962371 - Part 1: Make priority for TCP relayed candidates lower than UDP relayed candidates. r=abr 2014-01-22 14:13:43 -08:00
Byron Campen [:bwc]
fec16a3224 Bug 961313 - Add the transport protocol to candidate labels. r=abr 2014-01-22 16:50:52 -08:00
Byron Campen [:bwc]
c34d2cbbba Bug 957800 - Make codeword longer to avoid collisions. r=abr 2014-01-10 15:57:15 -08:00
Nils Ohlmeier [:drno]
29faae8931 Bug 962896 - Add source address to STUN logging. r=bwc 2014-01-24 08:43:22 -05:00
Adam Roach [:abr]
3c0eab9979 Bug 930481: Improved failure instrumentation for transport layers r=ekr 2014-01-23 14:21:24 -06:00
Ryan VanderMeulen
b9773bcdeb Backed out changeset 0b2f7df3aada (bug 961313) for buffered_stun_socket_unittest crashes.
CLOSED TREE
2014-01-23 11:23:14 -05:00
Byron Campen [:bwc]
83be00efcc Bug 961313 - Add the transport protocol to candidate labels. r=abr 2014-01-22 16:50:52 -08:00
EKR
a5be4c554b Bug 960296 - Update buffered stun socket size when flushes happen. r=abr 2014-01-16 08:29:00 -08:00
Byron Campen [:bwc]
206c5e3bb0 Bug 906990: Part 13. Get local/remote candidates separately, instead of grabbing them from candidate pairs (means we can get candidates before pairing happens). r=ekr 2013-11-13 13:49:33 -08:00
Ryan VanderMeulen
67393e427e Backed out changesets f04c846c7492, 9bc5c5a8554e, and a4f2af4617da (bug 906990) for WebRTC mochitest failures.
CLOSED TREE
2014-01-13 10:53:40 -05:00
Byron Campen [:bwc]
cd6184313e Bug 906990: Part 13. Get local/remote candidates separately, instead of grabbing them from candidate pairs (means we can get candidates before pairing happens). r=ekr 2013-11-13 13:49:33 -08:00
Byron Campen [:bwc]
886644ff8b Bug 957236 - Fix infinite loop on win32 when network interfaces contain a '.'. r=ekr 2014-01-09 09:11:35 -08:00
Byron Campen [:bwc]
8bc1bdbe36 Bug 950990 - NrIceCtx::ice_completed is fired even on failed contexts, so do not mark such contexts as completed. r=abr 2013-12-17 11:57:13 -08:00
Byron Campen [:bwc]
90ea8e63bb Bug 949708 - Dump RLogRingBuffer on test failures in ice_unittest. r=ekr 2014-01-03 13:36:37 -08:00
Adrian Cruceru
19925e3a08 Bug 923468 - Safety patch for race condition. r=ekr 2014-01-06 12:40:03 -05:00
Martin Thomson
1457296fd1 Bug 946348 - Refactor fingerprint handling. r=abr 2014-01-02 10:50:14 -05:00
Ehsan Akhgari
460de4dd98 Bug 940708 - Part 6: Exclude one more file for Linux ASAN builds
--HG--
extra : rebase_source : 95c28f6d4b32685bb291bff1085fb28915e2b1df
2013-12-20 13:27:50 -05:00
Ehsan Akhgari
9d77e6b741 Bug 940708 - Part 5: Exclude more files from unified builds because of name clashes on RCSSTRING; r=gps
--HG--
extra : rebase_source : 551ec846a9bd266a0ff42d2344cbae41ffeaf29f
2013-12-19 12:08:31 -05:00
Ehsan Akhgari
be7f1e698f Backed out 4 changesets (bug 940708) for ASAN bustage
Backed out changeset 8b081bf3d16c (bug 940708)
Backed out changeset 8d1da29cee34 (bug 940708)
Backed out changeset aedcac877ab0 (bug 940708)
Backed out changeset d4aec392a165 (bug 940708)

--HG--
extra : rebase_source : dec5c491a2233dfe7fe2153559e01313d3583a33
2013-12-20 13:05:29 -05:00
Ehsan Akhgari
6cce839186 Bug 940708 - Part 5: Exclude more files from unified builds because of name clashes on RCSSTRING; r=gps
--HG--
extra : rebase_source : c5df6642d1bca37ba49e5cdb82f5d48b21e2fa87
2013-12-19 12:08:31 -05:00
Byron Campen [:bwc]
0482db0bb6 Bug 942950: Avoid calling done_cb in the wrong order, or multiple times. r=ekr,abr 2013-12-12 13:58:02 -08:00
Ryan VanderMeulen
55b39e4c18 Backed out changeset cffe18264682 (bug 946348) for Windows bustage. 2013-12-19 12:37:46 -05:00
Martin Thomson
2338dfbe00 Bug 946348 - Refactoring fingerprint handling. r=abr 2013-12-19 11:42:19 -05:00
Mike Hommey
883bf3234f Bug 949334 - Use FINAL_LIBRARY for webrtc. r=gps 2013-12-14 11:38:53 +09:00
Ethan Hugg
2258657fc5 Bug 901560 - Datachannel no longer make second ICE component r=abr 2013-08-30 12:51:05 -07:00
Mike Hommey
25972646a7 Bug 778236 - Treat gyp files as if their content was defined in moz.build files. r=gps 2013-12-12 23:41:05 +09:00
Byron Campen [:bwc]
31ca790e8e Bug 906990 - Part 11: Fix bug where the |selected| field on a candidate pair statistic was never set. r=ekr 2013-11-08 16:45:39 -08:00
Byron Campen [:bwc]
2cf843a81a Bug 946733. Simplify turn client ctx lifecycle. r=ekr, martin 2013-12-05 16:08:54 -08:00
Byron Campen [:bwc]
d18d50cb70 Bug 938857. Don't prune candidates once pairing has started r=ekr,abr 2013-11-22 17:47:38 -08:00
EKR
581ab6a60e Bug 906968 - Add support for TURN TCP. r=abr
--HG--
rename : media/mtransport/third_party/nICEr/src/stun/nr_socket_turn.h => media/mtransport/third_party/nICEr/src/stun/nr_socket_buffered_stun.h
2013-12-06 10:20:19 -08:00
Byron Campen [:bwc]
c9afbaa42d Bug 942940 - Fix a potential memory leak. r=abr 2013-12-03 16:11:29 -08:00
Byron Campen [:bwc]
780166e6b8 Bug 942940 - Fix bug where a destroyed peerreflexive candidate could be left in the component list if candidate pair creation/insertion failed for some reason. r=abr 2013-11-25 10:37:21 -08:00
Masatoshi Kimura
1a193bc2f1 Bug 896704 - Remove the MSVC exemption for FAIL_ON_WARNINGS in media/mtransport. r=abr 2013-12-05 21:41:04 +09:00
Byron Campen [:bwc]
66569b240b Bug 942958 - Fix bug where a failure to populate the foundation of a peerreflexive candidate would result in an incorrect error return from nr_ice_peer_peer_rflx_candidate_create. r=ekr 2013-11-25 13:13:05 -08:00
Mike Hommey
dac5b53f4f Bug 944634 - mozmake.py (for gyp) handling of escaping (or lack thereof) for defines is wrong. r=ted 2013-12-03 06:34:21 +09:00
Patrick Wang
33cfc29397 Bug 870660: Part 3: Test case. r=ekr 2013-11-30 00:16:37 +08:00
Patrick Wang
0ad48c580c Bug 870660: Part 2: Implement socket filter for STUN. r=ekr 2013-11-30 00:15:26 +08:00
Mike Hommey
fc98abb416 Bug 942043 - Straighten up zlib linkage wrt shared js and system zlib. r=gps,r=ted 2013-11-22 23:03:21 +09:00
Mike Hommey
9245936f8b Bug 874266 - Move all DEFINES that can be moved to moz.build. r=mshal 2013-11-27 22:55:07 +09:00
Mike Hommey
2b828323f2 Backout changeset 3fd4b546eed4 (bug 874266) and changeset a35d2e3a872f (bug 942043) for ASAN build bustage and Windows test bustage
--HG--
extra : amend_source : f20d09aeff1c8b5cbd0f1d24c7ce04e86f3aed1d
2013-11-28 14:24:05 +09:00
Mike Hommey
d210f8ff00 Bug 874266 - Move all DEFINES that can be moved to moz.build. r=mshal 2013-11-28 13:08:16 +09:00
Mike Hommey
1b90f90106 Bug 942043 - Straighten up zlib linkage wrt shared js and system zlib. r=gps,r=ted 2013-11-28 12:49:43 +09:00
Byron Campen [:bwc]
9cadd5383f Bug 935723. Part 1. Decouple ICE state with ICE gathering state r=ekr,abr,jesup 2013-11-13 14:53:30 -08:00
ISHIKAWA, Chiaki
5cd1075cce Bug 942462 - Fix type in media/mtransport/logging.h. r=ekr 2013-11-25 09:23:45 -05:00
Ehsan Akhgari
f6c12be9e0 Mark the SOURCES variables in media/mtransport moz.build files as non-unifiable, no bug
DONTBUILD
2013-11-22 00:40:58 -05:00
EKR
d31ab43b77 Bug 940709 - Upgrade ICE state change log level. r=bwc 2013-11-19 16:06:08 -08:00
Mike Hommey
8ceb917350 Bug 939074 - Remove most LIBXUL_LIBRARY. rs=gps 2013-11-19 11:48:10 +09:00
Mike Hommey
bb6779efe3 Bug 939044 - Remove most definitions of MODULE. r=mshal 2013-11-19 11:47:39 +09:00
Mike Hommey
d7b6f95761 Bug 935881 - Use FINAL_LIBRARY for all (fake) libraries that end up linked in a single other library. r=gps 2013-11-19 11:47:14 +09:00
Byron Campen [:bwc]
9442c56670 Bug 906384 - Very simple global rate-limiting based on SimpleTokenBucket. Will tolerate a maximum of 8K/sec over 1 sec, and 3.6K/sec over 20 sec. r=ekr 2013-11-17 08:27:44 -08:00
Byron Campen [:bwc]
030f0692f1 Bug 906990: Part 9. Add correlator for ICE candidates. r=ekr 2013-10-25 16:47:14 -07:00
Shih-Chiang Chien
d34ec44031 Bug 869869 - Part 3, add an IPC implementation of NrSocket, r=ekr. 2013-06-19 19:08:06 +08:00
Jonas Finnemann Jensen
601c303bbe Bug 902587 - Part 2A: Refactor late-write-checks as client of IO Interposer. r=BenWa
--HG--
rename : xpcom/build/mozPoisonWrite.h => xpcom/build/LateWriteChecks.h
rename : xpcom/build/mozPoisonWrite.h => xpcom/build/PoisonIOInterposer.h
rename : xpcom/build/mozPoisonWriteBase.cpp => xpcom/build/PoisonIOInterposerBase.cpp
rename : xpcom/build/mozPoisonWriteMac.cpp => xpcom/build/PoisonIOInterposerMac.cpp
rename : xpcom/build/mozPoisonWriteWin.cpp => xpcom/build/PoisonIOInterposerWin.cpp
2013-11-05 07:45:20 -05:00
Byron Campen [:bwc]
3708c3019b Bug 934317: Mutex-protect the RLogRingBuffer, since more than one thread is using it. r=jesup 2013-11-04 15:39:51 -08:00
Byron Campen [:bwc]
d361881889 Bug 906990 - Part 6: Add a codeword field to NrIceCandidatePair so related logging can be pulled from RLogRingBuffer. Proof of concept in ice_unittest. r=ekr 2013-10-24 11:45:10 -07:00
Byron Campen [:bwc]
5980e37958 Bug 906990 - Part 5.1: Enable r_log and RLogRingBuffer so logging can be scraped. Also, tweak log levels so the RLogRingBuffer isn't rapidly overwritten by media packet logging. r=ekr 2013-10-29 11:53:44 -07:00
Byron Campen [:bwc]
8c21ae2c86 Bug 906990 - Part 5: Allow logging related to a given candidate pair to be fetched. r=ekr 2013-10-29 10:45:09 -07:00
Jan-Ivar Bruaroey
878185cc82 Bug 932420: sigslot.h - #ifdef'ed out unused multi-threading to avoid windows.h, r=jesup 2013-10-29 19:49:34 -04:00
Ethan Hugg
f0456f6520 Bug 901560 - Backout of compatibility-breaking datachannel ice component fix r=jesup 2013-10-29 08:52:04 -07:00
Byron Campen [:bwc]
4e9cb54e31 Bug 931186 - Dirt simple token bucket class. r=ekr 2013-10-25 15:15:59 -07:00
Gregory Szorc
9ada834d56 Bug 927837 - Don't manage generated files in configure; r=glandium
--HG--
extra : rebase_source : b502ce209de6a0ae10e130644e424687e4fae85e
2013-10-23 14:43:32 -07:00
Phil Ringnalda
01cb478e04 Back out 1cbb486b4fb7:8e3a17767287 (bug 906990) for leaks
CLOSED TREE
2013-10-28 15:30:11 -07:00
Byron Campen [:bwc]
743926d742 Bug 906990 - Part 11. Enable r_log and RLogRingBuffer so logging can be scraped. Also, tweak log levels so the RLogRingBuffer isn't rapidly overwritten by media packet logging. r=ekr 2013-10-24 11:47:16 -07:00
Byron Campen [:bwc]
61cd1bbc0c Bug 906990 - Part 6: Add a codeword field to NrIceCandidatePair so related logging can be pulled from RLogRingBuffer. Proof of concept in ice_unittest. r=ekr 2013-10-24 11:45:10 -07:00
Byron Campen [:bwc]
d3b84174e3 Bug 906990 - Part 5: Allow logging related to a given candidate pair to be fetched. r=ekr 2013-10-24 11:52:01 -07:00
Ted Mielczarek
154a815b9e Bug 930674 - convert VISIBILITY_FLAGS in Makefile.in to NO_VISIBILITY_FLAGS in moz.build. r=mshal 2013-10-24 15:06:19 -04:00
Ed Morley
c147bacb01 Backed out changeset 2d6c5cbcc213 (bug 902587) for failures during linking on a CLOSED TREE
--HG--
rename : xpcom/build/PoisonIOInterposer.h => xpcom/build/mozPoisonWrite.h
rename : xpcom/build/PoisonIOInterposerBase.cpp => xpcom/build/mozPoisonWriteBase.cpp
rename : xpcom/build/PoisonIOInterposerMac.cpp => xpcom/build/mozPoisonWriteMac.cpp
rename : xpcom/build/PoisonIOInterposerWin.cpp => xpcom/build/mozPoisonWriteWin.cpp
2013-10-25 14:24:34 +01:00
Cykesiopka
a3710e5c11 Bug 914270 - Part 1: Simple/Automated moves. r=joey 2013-10-24 18:51:00 +01:00
Jonas Finnemann Jensen
375ca800b6 Bug 902587 - Part 2A: Refactor late-write-checks as client of IO Interposer r=BenWa
--HG--
rename : xpcom/build/mozPoisonWrite.h => xpcom/build/LateWriteChecks.h
rename : xpcom/build/mozPoisonWrite.h => xpcom/build/PoisonIOInterposer.h
rename : xpcom/build/mozPoisonWriteBase.cpp => xpcom/build/PoisonIOInterposerBase.cpp
rename : xpcom/build/mozPoisonWriteMac.cpp => xpcom/build/PoisonIOInterposerMac.cpp
rename : xpcom/build/mozPoisonWriteWin.cpp => xpcom/build/PoisonIOInterposerWin.cpp
2013-10-24 17:02:00 +01:00
Mike Hommey
1d566f7586 Bug 929905 - Consolidate sources in moz.build. r=gps 2013-10-25 08:23:05 +09:00
Byron Campen [:bwc]
61ed81c2bb Bug 906990 - Part 4: Using more appropriate log-levels (r_log) for errors and other not-quite-right conditions. r=ekr 2013-10-14 10:55:50 -07:00
Mike Hommey
61124c1afc Bug 921492 - Make StrictOrderingOnAppendList use actual alphabetical sorting. r=mshal,r=gps 2013-10-24 08:05:43 +09:00
Mike Hommey
e2ae65f67a Bug 913268 - Make CPP_SOURCES a StrictOrderingOnAppendList. r=mshal 2013-10-24 08:00:23 +09:00
Byron Campen [:bwc]
05e9e307ec Bug 929793 - Fix =/== typo. r=ekr 2013-10-22 16:52:10 -07:00
Jan-Ivar Bruaroey
5e7781f43a Bug 928060: Parse ?transport=[udp|tcp] in TURN uri. r=ehsan 2013-10-18 18:14:21 -04:00
Byron Campen [:bwc]
a27aea96ab Bug 906990 - Part 3: Make it easier to filter out logging related to a given candidate pair r=ekr 2013-10-14 10:00:41 -07:00
Byron Campen [:bwc]
b66662709d Bug 925361 - TestStunServer will retry opening its listen socket by incrementing the port, to a maximum of 10 times. r=ekr 2013-10-10 11:30:38 -07:00
EKR
7905d8ad35 Bug 925337 - Make TestStunServer dtor safe if listen_sock_ is null. r=abr 2013-10-10 07:08:18 -07:00
Byron Campen [:bwc]
2ba62e19b3 Bug 842549 - Part 4: Small fix from ekr to disarm the trickle_cb when the ICE ctx is destroyed. r=abr 2013-09-19 16:08:28 -07:00
EKR
d63e547568 Bug 842549 - Part 1: Generate trickle candidates from nICEr, with testing r=abr 2013-09-19 09:17:52 -07:00
Byron Campen [:bwc]
1eac10cbc9 Bug 918095 - Fix bug where stun requests/responses would be leaked if no callbacks were registered (eg; test cases) r=abr 2013-09-18 14:51:53 -07:00
Ethan Hugg
c15070152a Bug 901560 - Datachannel no longer make second ICE component r=abr 2013-08-30 12:51:05 -07:00
Phil Ringnalda
6fc2c86185 Backed out 4 changesets (bug 842549) for assertions
CLOSED TREE

Backed out changeset 9f2d0e38fdf8 (bug 842549)
Backed out changeset f6941e490ba2 (bug 842549)
Backed out changeset c3444536fd8e (bug 842549)
Backed out changeset 2af2bfe5e66a (bug 842549)
2013-09-19 19:53:33 -07:00
Byron Campen [:bwc]
d8b8d18a7d Bug 842549 - Part 4. Small fix from ekr to disarm the trickle_cb when the ICE ctx is destroyed. r=abr 2013-09-19 16:08:28 -07:00
EKR
05efd23c6a Bug 842549 - Part 1. Generate trickle candidates from nICEr, with testing r=abr 2013-09-19 09:17:52 -07:00
Byron Campen [:bwc]
0003f3b779 Bug 916187. Part 3. Double checking for leaks in new test stun server code, and fixing other things as I see them. r=abr 2013-09-18 12:54:38 -07:00
Byron Campen [:bwc]
4b887a382e Bug 916187. Part 2. Using the test stun server, write some tests to exercise the checking logic written in 908740. r=abr 2013-09-18 12:36:13 -07:00
EKR
1d44884f31 Bug 916187. Part 1. Cleanup of trickle candidates and a test STUN server r=abr 2013-09-13 10:11:44 -07:00
Benoit Jacob
f9813a5b18 Bug 913847 - stop needlessly including nsThreadUtils.h - r=ehsan 2013-09-19 09:54:39 -04:00
Wes Kocher
508c0eaa0a Backed out changeset 554bfe767519 (bug 913847) for leaking on a CLOSED TREE 2013-09-18 17:21:02 -07:00
Benoit Jacob
5bf87f575b Bug 913847 - stop needlessly including nsThreadUtils.h - r=ehsan 2013-09-18 18:50:32 -04:00
Byron Campen [:bwc]
35a45b16d0 Bug 906990 - Some basic testing of GetCandidatePairs r=ekr 2013-09-16 11:03:18 -07:00
Byron Campen [:bwc]
d895ad650e Bug 906990 - Adding a bulk getter for the current state of all ICE candidate pairs(plus a little testing). r=ekr 2013-09-09 10:19:01 -07:00
Brian O'Keefe
535c7c2ade Bug 865673 - Convert objs.mk to objs.mozbuild. r=gps 2013-08-30 09:09:06 -04:00
Eric Rescorla
5e1800a062 Bug 915420 - Use foundation address instead of relay address to determine priority r=bwc 2013-09-11 15:43:09 -07:00
Byron Campen [:bwc]
bbca1ed7e1 Bug 908740 - Reject obviously bogus STUN and TURN candidates. r=ekr 2013-09-10 11:33:19 -07:00
Adam Roach [:abr]
684eb9b88f Bug 906843 - Shorten sleep period for ASSERT_TRUE_WAIT from 200ms to 10ms; change traffic checks to count packets rather than wait 10 seconds r=ekr 2013-09-05 17:11:37 -05:00
Ethan Hugg
6b0b0cb69d Bug 909179 - Fix warning from previous patch CLOSED TREE 2013-09-05 14:57:58 -07:00
EKR
70e9e8021a Bug 909179 - Add ability to disable ICE components r=abr 2013-08-25 19:35:21 -07:00
Patrick Wang
1b1bdeee92 Bug 910990 - prevent from build failure with older version of ethtool in linux. r=abr,ekr,khuey 2013-09-05 00:28:46 +08:00
Mike Hommey
f1cf3b4238 Bug 912293 - Remove now redundant boilerplate from Makefile.in. r=gps 2013-09-05 09:01:46 +09:00
EKR
e99365eafe Bug 905150 - Don't cancel running ICE candidate pairs on nomination. r=abr 2013-08-31 07:35:38 -07:00
EKR
a1897a6d9f Backed out changeset c6907a76e925 for wrong commit message/bug #. 2013-08-31 07:43:08 -07:00
EKR
d6f6fca276 Bug 904598 - Fix TURN long-term auth for Permissions Requests. r=abr 2013-08-31 07:35:38 -07:00
EKR
4d8a0844e6 Fix TURN long-term auth for Permissions Requests
Bug 904598 - Fix TURN long-term auth for Permissions Requests. r=abr
2013-08-13 14:06:56 -07:00
Patrick Wang
fa73bd39ed Bug 825708 - Part 3: test case. r=ekr 2013-08-28 15:27:22 +08:00
Patrick Wang
ec70475244 Bug 825708 - Part 2: calculate priority using properties. r=ekr 2013-08-28 15:27:14 +08:00
Patrick Wang
7f71a952f7 Bug 825708 - Part 1: use nr_local_addr in nr_stun_get_addrs and provide interface type/estimated speed/vpn information for Linux and B2G. r=abr 2013-08-28 15:27:06 +08:00
Ms2ger
add9ce17b9 Bug 883284 - Part e: Move LIBXUL_LIBRARY into moz.build (k-o); r=ted 2013-08-22 08:56:00 +02:00
Ms2ger
4d968c40e1 Bug 882859 - Part b: Move FAIL_ON_WARNINGS into moz.build; r=joey+gps 2013-08-22 08:55:59 +02:00
Landry Breuil
50353212e0 Bug 807492 Part 1.2 - Enable to build media/mtransport on BSD, #defines & #include bits r=abr 2013-08-13 23:59:57 +02:00
Landry Breuil
3efc2cf272 Bug 807492 Part 1.1 - Allow to build media/mtransport on BSD, build bits r=jesup 2013-08-13 23:58:42 +02:00
EKR
1feb527365 Bug 888274. Emit RFC5389 STUN. Accept MAPPED-ADDRESS in response regardless of what we send. r=abr 2013-06-28 07:58:37 -07:00
Ehsan Akhgari
9854ac6166 Bug 872127 - Part 2: Replace mozilla/StandardInteger.h with stdint.h; r=Waldo,ted 2013-07-30 10:25:31 -04:00
Nickolai Zeldovich
7407188631 Bug 823338 - Fix incorrect check for OOM conditions in TransportLayerDtls::GetClientAuthDataHook(). r=ekr 2013-07-24 09:05:55 -04:00
Ms2ger
fb6790e6d8 Bug 888643 - Part b: Move CPP_UNIT_TESTS definitions into moz.build files; r=gps 2013-07-24 09:23:06 +02:00
Joshua Cranmer
96a1370053 Bug 884061 - Part 3o: Use NS_DECL_THREADSAFE_ISUPPORTS in media/, r=abr
--HG--
extra : rebase_source : cdad785f54f50c012ea4f904369b120656c68a55
2013-07-18 21:23:32 -05:00
Randell Jesup
bb58c721b8 Bug 896228: in nicer, return WOULDBLOCK if NSPR SendTo() would block r=ekr 2013-07-22 11:48:24 -04:00
Gervase Markham
acfedfd6cb Bug 715549 - remove last vestiges of tri-licence. DONTBUILD. 2013-07-19 16:08:33 +01:00
Mike Hommey
0f994f506e Bug 887483 - Remove some more useless FORCE_STATIC_LIB and leftover comments from previous removal. r=mshal 2013-07-15 18:48:40 +09:00
EKR
fbd781cc74 Bug 886120 - Make ICE respond before receiving peer credentials r=abr 2013-07-09 20:17:37 -07:00
Mike Shal
5f86d66524 Bug 889572 - Remove EXPORTS from media/mtransport/standalone; r=gps 2013-07-09 13:49:38 -04:00
Suhas Nandakumar
87b0c2687e Bug 889615 - Add Granular logging to Mediapipeline. r=abr 2013-07-03 11:40:36 -07:00
Brian O'Keefe
5f8b5163e8 Bug 875934 - Move LIBRARY_NAME to moz.build (batch #1); r=mshal
--HG--
extra : rebase_source : 385d3fd65475ffc18ee44ae088753649470e214b
2013-06-17 15:21:01 -04:00
Mike Shal
7bc33f0c21 Bug 882738 - Remove SRCS_IN_OBJDIR from Makefile.in; r=joey
From a071ba8cffdd4584b3cd31eae207e5b76b9e9c95 Mon Sep 17 00:00:00 2001
2013-06-13 13:49:01 -04:00
Vladimir Vukicevic
3674b7925e b=882906; remove EXTRA_DSO_LIBS; r=ted 2013-06-13 22:58:22 -04:00
Kyle Machulis
cc47ffce94 Bug 880486 - ns_stun_get_attrs doubly defined on B2G Desktop with MOZ_B2G_RIL [r=pwang] 2013-06-06 18:10:00 -07:00
Jan-Ivar Bruaroey
e119b4ec5d Bug 860397: turn_unittest checks that TURN_SERVER_ADDRESS is IP#s not FQDN r=rjesup 2013-06-05 18:01:07 -04:00
Patrick Wang
5a7d27b6f0 Bug 867933 - Part 2 - provide gonk-specific addrs.c to enable nICEr to enumerate network interfaces in gonk. r=ekr 2013-05-08 13:48:25 +08:00
Mike Shal
994cfe0b6b Bug 864774 - Part 2: Move CPPSRCS to moz.build as CPP_SOURCES; r=joey CLOSED TREE
From 9e0ba7f425143f545eb6c4b26a9a96b5ade4d8e9 Mon Sep 17 00:00:00 2001
2013-04-23 17:54:15 -04:00
Suhas Nandakumar
f064e8a50e Bug 867273 - Force PR_LOG in production builds. r=ekr 2013-05-20 19:11:01 -07:00
Adam Roach [:abr]
2ea8a82a27 Bug 874008: Fix bustage r=ekr 2013-05-21 09:25:10 +08:00
Adam Roach [:abr]
7cbcebdbf9 Bug 874008 - Check format strings for r_log r=ekr 2013-05-21 09:16:07 +08:00
EKR
abc11990dd Bug 856433 - Allow cancellation of nonexistent nrappkit timers off the STS thread. r=abr 2013-04-16 19:29:23 -07:00
EKR
525cbd89e5 Bug 854085. Make thread asserts conditional on DEBUG not MOZ_DEBUG. r=jesup 2013-04-16 13:13:09 -07:00
Mike Shal
77cdb6567d Bug 846634 - Part 2: Move EXPORTS to moz.build; r=joey 2013-04-16 15:24:43 -04:00
EKR
625caee26c Bug 856848 - Fix thread crash r=ehugg
Bug 856848 - Fix thread crash r=ehugg,ekr
2013-04-01 12:34:36 -07:00
Randell Jesup
45a0f4aad4 Bug 860222: use our own isascii() for sanitizing TURN passwords r=glandium 2013-04-11 22:46:23 -04:00
Ryan VanderMeulen
ce7f08851c Backed out changeset f556245d6da1 (bug 856848) for build bustage on a CLOSED TREE. 2013-04-11 15:42:37 -04:00
EKR
e76c82d92e Bug 856848 - Fix thread crash r=ehugg,ekr 2013-04-01 12:34:36 -07:00
Randell Jesup
3ef845228e Bug 830100: Avoid deadlocks by sending packets asynchronously r=ekr 2013-04-11 03:16:03 -04:00
EKR
6ae9e48673 Bug 830100: Refactor transport flow to allow destruction on any thread r=derf 2013-02-19 03:43:34 -08:00
Adam Roach [:abr]
9feb383ace Bug 860143: Check correct variable when setting host r=ekr 2013-04-10 13:37:50 -05:00
Randell Jesup
d6e0e4a028 Backout changeset 5abbf6fd5466 (Bug 830100) for sctp_unittest failure ON A CLOSED TREE r=ryanvm 2013-04-09 17:35:20 -04:00
EKR
30df455b5e Bug 830100: Refactor transport flow to allow destruction on any thread r=derf 2013-02-19 03:43:34 -08:00
EKR
ba81b14698 Bug 786235 - Rewrite TURN stack to match RFC 5766. r=abr 2013-04-06 17:58:58 -07:00
Randell Jesup
77e47da3ea Bug 838380: don't crash browser on server 500 error r=abr 2013-04-08 17:11:31 -04:00
Randell Jesup
a3d71afbe0 Bug 838319: don't assert() on bad STUN input credentials; accept utf8 for UTF-8 r=dmose 2013-04-06 03:29:58 -04:00