Commit Graph

217 Commits

Author SHA1 Message Date
Boris Zbarsky
ab5fa0c6e8 Bug 473390 part 3. Move some HTML frame construction assertions out of the frame constructor and into the relevant frame creation methods. r+sr=roc 2009-01-19 13:31:31 -05:00
Boris Zbarsky
c0de154bc2 Bug 473390 part 2. Call SetInitialChildList on HTML frames even if the child list is empty, to bring HTML in line with everything else. r+sr=roc 2009-01-19 13:31:31 -05:00
Benjamin Smedberg
24e7cb1f78 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
50621e4f9f Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
d0b948876f Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
L. David Baron
57a8e776d8 Rename flags and methods from space manager to float manager. (Bug 191448) r+sr=roc 2009-01-04 19:39:54 -05:00
L. David Baron
b3d748ba11 Fix some missed renames from bug 471356. r+sr=bzbarsky 2009-01-04 14:52:38 -05:00
L. David Baron
23d4f4d4b2 Stop using nsAreaFrame for anything other than xul:label, which is the only thing for which it does anything different from nsBlockFrame, and rename it accordingly. (Bug 471356) r+sr=roc
--HG--
rename : layout/generic/nsAreaFrame.cpp => layout/xul/base/src/nsXULLabelFrame.cpp
rename : layout/generic/nsAreaFrame.h => layout/xul/base/src/nsXULLabelFrame.h
2008-12-29 10:07:38 -05:00
Olli Pettay
c7eb44efac Bug 469720 - tabindex of -1 set in javascript ignored on file input, r+sr=bz 2008-12-17 09:33:33 +02:00
Aiko
ae37af81d5 Combobox steals mouse event after menu is closed with Alt+Up. b=348236 r=mats sr=bzbarsky 2008-12-14 11:17:06 +01:00
Graeme McCutcheon
4d0acd8eae Bug 345339. Make nsPresState not use a hashtable in favor of using less memory and only storing the things it really wants to store. Switch box objects to their own hashtable. r+sr=roc 2008-12-12 14:25:22 -05:00
Robert O'Callahan
a3a3951684 Bug 459613. When we tear down a textcontrol frame, tell its editor that we're blowing away the frame tree so it doesn't try to clear the spellcheck selection, which not only wastes time but does GetPrimaryFrame for during frame destruction which is a no-no. r+sr=mats 2008-12-12 21:34:43 +13:00
L. David Baron
b9d0715bd4 Avoid discontinuity when options drop to height:0 by using CalcFallbackRowHeight only when GetNumberOfOptions() == 0, thus eliminating the last caller of CalcFallbackRowHeight passing a non-zero option count. (Bug 467084) sr=roc r=bzbarsky a=blocking1.9.1+ 2008-12-04 08:09:53 -08:00
L. David Baron
c95d61afc0 Pass the user font set through more reliably and make it a required parameter. (Bug 467084) r+sr=roc a=blocking1.9.1+ 2008-12-04 08:09:53 -08:00
Graeme McCutcheon
db7058c5de Bug 215405. Restore scroll position, but not form state, on no-store and SSL no-cache sites. r+sr=bzbarsky 2008-12-03 12:55:14 -05:00
Markus Stange
7a9f82ce7e Bug 462793 - Changing listbox selection with keyboard no longer scrolls to make the newly selected item visible, r+sr=roc 2008-11-04 15:38:16 +01:00
Benjamin Smedberg
4862de1d3d Bug 461186 - nsTextControlFrame should not implement nsIPhonetic: there's only one caller, and that caller can use nsITextControlFrame directly. This is one less frame that implements an nsISupports-derived interface. r+sr=roc 2008-10-27 20:27:55 -04:00
Theppitak Karoonboonyanan
018ec4b25f Bug 157546. The 'delete' key should delete an entire cluster. r=peterv,r+sr=roc 2008-10-16 20:44:32 +13:00
Mats Palmgren
426e3534c3 Ignore the keypress event if DOMEventToNativeKeyEvent() fails. b=456273 r=Olli.Pettay sr=jonas 2008-10-15 12:50:42 +02:00
Taras Glek
2c733370d0 Bug 456099: outparamdel nsIPrivateDOMEvent r+sr=jst 2008-10-09 16:23:07 -07:00
Boris Zbarsky
d674c8ca02 Bug 433616 part 1. Make it possible to create a document viewer with no parent widget or container, and make various code saner about handling null document/prescontext/documentviewer containers. r=roc, sr=jst 2008-09-28 15:14:28 -04:00
Boris Zbarsky
012ae72fd1 Backing out changesets 2ea77fa990af, 7d2d8869e73c, 93441e4f521e, 43d2ee100f3b, a2d84821ea71 to see whether they're causing the Windows Txul or Mac Tp regressions 2008-09-29 08:51:29 -04:00
Boris Zbarsky
10026a0921 Bug 433616 part 1. Make it possible to create a document viewer with no parent widget or container, and make various code saner about handling null document/prescontext/documentviewer containers. r=roc, sr=jst 2008-09-28 15:14:28 -04:00
Taras Glek
390adbe464 bug 455536: s/NS_ERROR_FAILURE/NS_ERROR_OOM/ outparamdelled nsNodeInfoManager::GetNodeInfo r+sr=jsr 2008-09-25 15:46:52 -07:00
Boris Zbarsky
c1fe6ebd6e Bug 455451. Don't notify from inside frame construction. r+sr=jst 2008-09-25 16:35:46 -04:00
Zack Weinberg
a64209d05b Bug 456792 - Two more API cleanups for nsCSSRendering; patch 1; r+sr=roc 2008-09-25 17:53:27 +02:00
Zack Weinberg
7687ccc76b Bug 456152 - slight API cleanup for nsCSSRendering::PaintBackground; r+sr=roc 2008-09-24 06:07:22 +02:00
Arpad Borsos
d0e70a51bf Bug 452797 - Clean up unused variables in layout/; v6; r+sr=roc 2008-09-20 15:42:03 +02:00
Robert O'Callahan
f79290bb0e Bug 450930. Fire a DOM event when painting so that content and chrome can track what's being repainted. r=smaug,sr=dbaron 2008-09-18 21:47:21 +12:00
Arpad Borsos
eef0edf9d5 Bug 454766 - Add suggested parentheses to layout/; r+sr=roc; (with nits by sgautherie) 2008-09-15 17:40:25 +02:00
Taras Glek
c26ce8e1ab bug 450777:deCOMtaminate nsNodeInfoManager::GetNodeInfo r+sr=jst 2008-09-12 15:32:18 -07:00
Robert Kaiser
2c0122f06d bug 451601 - kill MOZILLA_LOCALE_VERSION, main mozilla-central patch to kill xpfe-style chrome versions, r=ted sr=Neil 2008-09-11 01:08:57 +02:00
Ted Mielczarek
468a3823fc bug 447642 - get rid of --disable-mochitest, replace MOZ_MOCHITEST with ENABLE_TESTS. r=bsmedberg 2008-09-09 13:59:11 -04:00
Taras Glek
9405df90da bug 454292:prbool fixes for layout r+sr=dbaron 2008-09-09 10:07:26 -07:00
timeless@mozdev.org
b0c349250f Backed out changeset 54215f2cbc66
to fix Bug 454186
SM crashes when try to download file [@ nsString::ToInteger - nsTreeBodyFrame::PaintProgressMeter]
2008-09-08 16:00:32 +02:00
Arpad Borsos
1f62482141 Bug 452797 - Clean up unused variables in layout/; r+sr=roc 2008-09-06 20:38:31 +02:00
Robert O'Callahan
be904c4d3d Bug 376662. Convert nsIFrame::GetOffsetTo to not use views. We need to ensure that for popups and scrollframes, views and frames are kept in sync at *all* times. Also fixes bugs in tests for NS_FRAME_NO_MOVE_FRAME. r+sr=bzbarsky 2008-09-06 20:52:56 +12:00
Robert O'Callahan
ca15953a6e Backing out changeset 1bdd5da49865 (for bug 376662) due to regression bug 453661 2008-09-05 15:40:06 +12:00
Robert O'Callahan
1eeada5faa Bug 376662. Make nsIFrame::GetOffsetTo not explicitly use views. r+sr=bzbarsky 2008-09-04 09:35:52 +12:00
Robert O'Callahan
923872866b Bug 331088. Handle file-control frame being torn down while the dialog is up. r=smaug,sr=mats 2008-08-15 22:21:31 +12:00
Boris Zbarsky
e802f1d69d Bug 210094. Make min-height and max-height work on fieldset. r+sr=dbaron 2008-08-08 01:18:00 -04:00
Zack Weinberg
c9153c98a8 Bug 446498 – use new border rendering for focus rectangles, and strip dead code. r+sr=vlad 2008-08-06 12:33:18 +02:00
Mats Palmgren
19dc715bb6 Bug 446663. Make sure that if the user is typing in a text input its text input listener will get the events (so that undo/redo work and oninput is fired). 2008-07-31 17:36:21 -07:00
Mats Palmgren
9dc386954b Bug 446663. Make sure that if the user is typing in a text input its text input listener will get the events (so that undo/redo work and oninput is fired). 2008-07-31 17:34:11 -07:00
Zack Weinberg
3197060cbd Delete nsLayoutUtils::GetAbsoluteCoord(); fold logic into callers and simplify. (Bug 437335) r+sr=dbaron 2008-07-17 16:37:12 -07:00
Andrew Smith ext:(%2C%20Rob%20Arnold%20%3Ctellrob%40gmail.com%3E%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
49c9b3d67e Implement css3 border-image property. (Bug 378217) r=vlad,dbaron,robarnold 2008-07-16 23:30:25 -07:00
L. David Baron
9e4ceade8e Backed out changeset 9b0b2391485c due to linker errors related to nsStyleStructInlines.h not being included enough. 2008-07-16 22:59:14 -07:00
Andrew Smith ext:(%2C%20Rob%20Arnold%20%3Ctellrob%40gmail.com%3E%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
bb4be48531 Implement css3 border-image property. (Bug 378217) r=vlad,dbaron,robarnold 2008-07-16 22:18:38 -07:00
John Daniels
ef0fee1d70 Bug 419532 – deCOMtaminate nsICaret. r+sr=roc 2008-07-16 12:52:01 +02:00
neil@parkwaycc.co.uk
45ebee768d Bug 444466 – Crash [@ nsTextControlFrame::PreDestroy()], r+sr=bz 2008-07-12 11:26:40 +02:00
Mats Palmgren
74d77f1c3f Use the post-reflow GetUsedMargin() value when placing the legend. b=433700 r+sr=dbaron 2008-07-09 17:42:44 +02:00
vladimir@pobox.com
f314638be2 b=431081; native selection box frame missing in fx3 - vista content only; r+sr=roc,a=beltzner 2008-04-28 20:55:07 -07:00
jst@mozilla.org
54ae1d2978 Landing fix for bug 419716. Make us consistently deal how we're pass param tags to object tags when parsing XHTML. Patch by mrbkap@gmail.com and bent.mozilla@gmail.com, r+sr=jonas@sicking.cc, a=beltzner 2008-04-17 15:30:51 -07:00
dbaron@dbaron.org
72f25cf7a0 Backout bug 157546 (making the delete key delete by clusters) to fix blockers bug 419217 and bug 419406. Instead of removing the added test, mark now-failing tests as todo. a=damons 2008-04-14 18:04:18 -07:00
roc+@cs.cmu.edu
1bfe348601 Bug 425253. Propagate reflow-depth tracking through XUL box layout. r+sr=dbaron,a=damon 2008-04-09 21:39:41 -07:00
reed@reedloden.com
daf0485896 Bug 420499 - "Caret browsing mode wrongly engaged" (Mochitest) [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+] 2008-04-08 11:52:48 -07:00
timeless@mozdev.org
d7e775a7be Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore 2008-04-06 05:28:34 -07:00
mats.palmgren@bredband.net
6132a1f02e Disconnect the frame selection object from the pres shell earlier. b=421083 r+sr=roc a1.9=beltzner 2008-04-02 19:42:20 -07:00
masayuki@d-toybox.com
1ff185aac0 Bug 424989 Cannot use reconversion of IMEs from system menu at the focus being on textarea r+sr=roc, b1.9=jonas 2008-03-29 12:38:05 -07:00
jruderman@hmc.edu
18ef573771 Adding crashtest 2008-03-26 21:27:43 -07:00
timeless@mozdev.org
f33eb4a3b4 reverting, wrong patch, missing AMBIGUOUS 2008-03-19 14:55:22 -07:00
timeless@mozdev.org
8074fda8ae Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore 2008-03-19 14:19:35 -07:00
bzbarsky@mit.edu
7b83e29004 Don't use fieldset pref widths as min widths, since pref widths can be unconstrained. Incidentally makes it possible for text to legends to wrap if the page wants it to. Bug 404123 and bug 354502, r+sr=dbaron, a=beltzner. 2008-03-14 13:48:23 -07:00
dbaron@dbaron.org
6dfd3f8a50 Give radio buttons and checkboxes a useful baseline, and switch checkboxes from text-bottom to baseline alignment (to match radios). b=402940 r+sr=bzbarsky a=blocking1.9+ 2008-03-07 09:57:34 -08:00
dbaron@dbaron.org
7003061847 Fix the weird Get* API on nsStyleSides in favor of returning structs by value, to avoid further occurrences of bug 420069. b=420069 r+sr=roc a=beltzner 2008-03-05 16:05:26 -08:00
roc+@cs.cmu.edu
76c8339f01 Bug 405952. Add scrollbar width to pref and min widths for overflow:scroll elements but for no other overflow values. r+sr=bzbarsky,dbaron,dholbert, a=beltzner 2008-02-28 12:37:06 -08:00
masayuki@d-toybox.com
3dcfbbf7fc Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) (retry) r+sr=roc, a1.9b4=beltzner 2008-02-28 07:28:37 -08:00
masayuki@d-toybox.com
f6e10b8d70 backing out the previous patch, becaused qm-centos5-01 dep unit test is orange 2008-02-28 05:59:25 -08:00
masayuki@d-toybox.com
22b844e897 Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) r+sr=roc, a1.9b4=beltzner 2008-02-28 03:01:56 -08:00
roc+@cs.cmu.edu
f19a84e63b Bug 157546. 'Delete' key should delete entire cluster. patch by Theppitak Karoonboonyanan, r+sr=roc,a=schrep 2008-02-21 18:24:04 -08:00
reed@reedloden.com
8980f8d4ec Back out patch from Theppitak Karoonboonyanan in bug 157546 due to test failures. 2008-02-20 03:10:16 -08:00
reed@reedloden.com
a82ed7e493 Bug 157546 - "[CTL-Thai] IM: <delete> key should delete WHOLE Thai "display cell"" [p=thep@linux.thai.net (Theppitak Karoonboonyanan) r+sr=roc a1.9=schrep] 2008-02-20 02:19:31 -08:00
jag@tty.nl
057bc17743 Bug 73353: Clean up our MODULE/REQUIRES story. rs=dbaron, a=brendan 2008-02-18 00:50:04 -08:00
reed@reedloden.com
017aad07f5 Back out Theppitak Karoonboonyanan's patch from bug 157546 due to a regression (bug 417745). 2008-02-15 12:20:55 -08:00
reed@reedloden.com
0aa97a6838 Bug 157546 - "[CTL-Thai] IM: <delete> key should delete WHOLE Thai "display cell"" [p=thep@linux.thai.net (Theppitak Karoonboonyanan) r+sr=roc a1.9=beltzner] 2008-02-14 21:30:34 -08:00
Olli.Pettay@helsinki.fi
84616fb3fc Bug 411212, cannot prevent file-picker from showing on <INPUT TYPE=FILE>, r+sr=roc+bzbarsky, a=mtschrep 2008-01-10 13:55:38 -08:00
reed@reedloden.com
3dac8e3cc2 Bug 409587 - "input[type="file"] cropped when narrow width specified" [p=kinetik@flim.org (Matthew Gregan) r+sr=roc a1.9=beltzner] 2008-01-07 14:18:06 -08:00
jruderman@hmc.edu
d8ad4a1870 Add crashtest. 2008-01-06 15:55:24 -08:00
jruderman@hmc.edu
dab7e37271 Add a crashtest 2008-01-05 22:42:00 -08:00
jruderman@hmc.edu
a93b2a8ab4 Add a crashtest (plus another crashtest I apparently forgot to check in before). 2008-01-05 22:10:06 -08:00
bzbarsky@mit.edu
fc4c66121d Make image controls splittable just like regular images. Bug 409659, r+sr=roc, a=dsicore 2008-01-04 22:44:38 -08:00
neil@parkwaycc.co.uk
dafb9ad144 Make XUL elements really native anonymous b=410119 r=smaug sr+a=sicking 2008-01-04 03:24:41 -08:00
roc+@cs.cmu.edu
fb28ffc853 Bug 407889. Reduce dynamic memory allocations during event handling by having nested invocations of HitTest share a single buffer for reordering display items; this buffer is an nsAutoTArray so it's mostly stack-allocated. r+sr=mats 2008-01-03 18:08:29 -08:00
reed@reedloden.com
b614a0a043 Bug 406407 - "Accelerators for textEdit should not be affected by keyboard group/level" [p=lolkaantimat@gmail.com (Evgeniy Ivanov) r+sr=roc a1.9=stuart] 2007-12-29 12:43:27 -08:00
jruderman@hmc.edu
250a219809 Add crashtests 2007-12-23 17:51:54 -08:00
dholbert@cs.stanford.edu
cc8a4b26d0 Bug 408772: Replace nscoord_MAX-unsafe arithmetic with safe call to NSCoordSaturatingSubtract, in nsComboboxControlFrame::GetIntrinsicWidth. r+sr=bzbarsky a=mtschrep 2007-12-18 11:26:35 -08:00
jruderman@hmc.edu
96d322a608 Add crashtest 2007-12-17 23:19:21 -08:00
jruderman@hmc.edu
6ea81eab14 Add crashtest 2007-12-17 16:35:42 -08:00
jruderman@hmc.edu
4cce8846a5 Add crashtests 2007-12-16 17:23:03 -08:00
jruderman@hmc.edu
559babe015 When you stare into the crashtest, the crashtest also stares back into you. 2007-12-16 17:20:41 -08:00
jruderman@hmc.edu
7149b817ac Add a crashtest 2007-12-16 17:16:39 -08:00
jruderman@hmc.edu
741f931c73 Add crashtest 2007-12-16 17:13:30 -08:00
jruderman@hmc.edu
1e81cca46f Old MacDonald had a farm, EIEIO. And on that farm he had some crashtests, EIEIO. With an mlk here and an assert there, here a crash, there a hang, everywhere a big bang. Old MacDonald had a farm, EIEIO. 2007-12-16 17:10:36 -08:00
jruderman@hmc.edu
72a133ea96 Add crashtest 2007-12-16 16:52:49 -08:00
jruderman@hmc.edu
f0e5e8131b Add crashtest 2007-12-16 14:10:22 -08:00
jruderman@hmc.edu
2d4104d7fe Add two crashtests 2007-12-16 14:08:46 -08:00
jruderman@hmc.edu
ea61e99e3c Crashtest! 2007-12-15 20:55:06 -08:00
jruderman@hmc.edu
9dad778aed Add crashtests 2007-12-15 15:45:02 -08:00
reed@reedloden.com
874a80563f Back out patch from bug 406047, as it is causing orange on Linux and Tp regression on Mac. 2007-12-14 00:55:08 -08:00
reed@reedloden.com
7ef5d7c383 Bug 406407 - "Accelerators for textEdit should not be affected by keyboard group/level" [p=lolkaantimat@gmail.com (Evgeniy Ivanov) r+sr=roc a1.9=stuart] 2007-12-13 23:20:32 -08:00