Commit Graph

479 Commits

Author SHA1 Message Date
dbaron@dbaron.org
56baacb4df Deal with padding inside .gnu_debuglink section being non-null. Not part of build. 2008-05-05 14:51:11 -07:00
nrthomas@gmail.com
d869d563e6 Bug 431788, bootstrap config for Thunderbird 3.0a1, p=rtessner, r=me 2008-05-05 08:25:53 -07:00
nrthomas@gmail.com
c26030f77e Bug 428063, test 3.0 RC1 build2 on staging 2008-05-02 09:58:31 -07:00
nrthomas@gmail.com
35f6412e59 Bug 428063, Support major releases (rename rcN to buildN in update offer), r=bhearsum 2008-04-29 07:01:33 -07:00
bhearsum@mozilla.com
b3d784babf bug 428063: bump staging 1.9 bootstrap to UPDATE_PACKAGING_R4. patch=me 2008-04-28 07:46:32 -07:00
bhearsum@mozilla.com
00ee4965be bug 428063: support major releases & quit using rc in overloaded ways. r=rhelmer,bhearsum, patch=nrthomas 2008-04-28 06:48:21 -07:00
nrthomas@gmail.com
9907d16a03 Bug 428650, patcher in fast mode uses a lot of space in /tmp, r=ccooper 2008-04-24 08:14:57 -07:00
nrthomas@gmail.com
0f373947a5 Bug 421001, include xulrunner code in source tarballs for Firefox releases, r=rhelmer 2008-04-24 07:22:54 -07:00
nrthomas@gmail.com
39fc9fe883 Bug 426259, restore the vars for the external staging, p=rtessner, r=me 2008-04-18 10:16:21 -07:00
nrthomas@gmail.com
7e01442e84 Bug 426559, bootstrap config for Tb2.0.0.14rc1, p=rtessner, r=me 2008-04-17 10:02:46 -07:00
nrthomas@gmail.com
021b224e44 Bug 409347, add verify-locales to the public repo. This is rev 1.9 from /mofo, see there for earlier history 2008-04-12 08:32:22 -07:00
rhelmer@mozilla.com
24c3815658 testing nightlies, need runMozillaTests set here 2008-04-12 00:59:24 -07:00
rhelmer@mozilla.com
65ac5b33f5 bustage fix from bug 427166, this should not be set 2008-04-11 15:43:16 -07:00
nrthomas@gmail.com
ea37b1d346 Update 1.9 staging to same patcher tag as 1.9 production 2008-04-11 03:40:06 -07:00
rhelmer@mozilla.com
664670b055 use wget not LWP, as we do not have LWP in the ref platform linux b=427690 r=nthomas 2008-04-09 13:10:07 -07:00
reed@reedloden.com
85aa35af10 Bug 419615 - "use JSVERSION_LATEST in xpcshell" (use a context callback to set error-reporter and jsversion default) [p=crowder@fiverocks.com (Brian Crowder) r+a1.9=shaver] 2008-04-09 00:27:16 -07:00
rhelmer@mozilla.com
33eda0d721 staging only, back out revision 1.17, kernel fixed 2008-04-08 15:38:59 -07:00
rhelmer@mozilla.com
a1cf4390ff check for signing log over HTTP not locally b=427690 r=nthomas 2008-04-08 11:38:52 -07:00
rhelmer@mozilla.com
62e9bdcf33 merge staging to production b=427166 r=nthomas 2008-04-08 09:40:11 -07:00
nrthomas@gmail.com
13b8a58401 Bug 427769, bootstrap config for Tb2.0.0.x on the staging setup, p=rtessner, r=me 2008-04-08 09:23:34 -07:00
rhelmer@mozilla.com
6c8d0d295d push contents of private dir, not dir itself, and fix up comment b=415970 r=nthomas 2008-04-07 13:16:28 -07:00
rhelmer@mozilla.com
bb5e24cecf bustage fix, staging only - downgrade linux kernel version 2008-04-04 22:05:28 -07:00
rhelmer@mozilla.com
577791c659 typo, staging only - remove duplicate sourceDir entry 2008-04-04 17:09:40 -07:00
rhelmer@mozilla.com
70856e5d6e support ftp-not-on-master for staging b=415180 r=nthomas 2008-04-04 15:13:35 -07:00
nrthomas@gmail.com
5f4588dc69 Bug 426307, bootstrap bump for Fx2.0.0.14rc1, p=joduinn, r=me 2008-04-04 12:17:49 -07:00
rhelmer@mozilla.com
c4b5e1dad2 clean sourcedir in clean_stage target 2008-04-03 19:50:46 -07:00
rhelmer@mozilla.com
8e80f44129 automation should not need slave/ftp on master b=415970 r=nthomas 2008-04-03 19:33:11 -07:00
rhelmer@mozilla.com
b2bf9a45fb automation should not need slave/ftp on master b=415970 r=nthomas 2008-04-03 19:28:42 -07:00
rhelmer@mozilla.com
2d12a7769c automation should not need slave/ftp on master b=415970 r=nthomas 2008-04-03 19:25:18 -07:00
nrthomas@gmail.com
2d8c0cf977 Bug 426259, bootstrap config for Tb20013rc1 2008-03-31 15:54:29 -07:00
rhelmer@mozilla.com
95bac0fcfd bustage fix, staging only - kernel version for linux is wrong 2008-03-29 17:50:43 -07:00
rhelmer@mozilla.com
3ac74885f9 bustage fix for staging only - should push to fx slave 2008-03-28 15:38:19 -07:00
nrthomas@gmail.com
d7d11b1048 Bug 421411, fix up runMozillaTests (migrating nightlies to automation), r=rhelmer 2008-03-28 11:16:36 -07:00
nrthomas@gmail.com
4ac5ed24e5 Bug 425462, re-enable fast-mode now that it's debugged 2008-03-27 14:25:42 -07:00
rhelmer@mozilla.com
30452cfdb2 add removed-files to exclusion list b=425462 r=schrep 2008-03-27 14:19:33 -07:00
nrthomas@gmail.com
4b39bc8da8 Bug 425462, disable patcher's fast-mode for 3.0b5, r=rhelmer 2008-03-27 11:21:18 -07:00
rhelmer@mozilla.com
3d82706a52 bump 3.0b5 for rc2 r=rhelmer p=joduinn b=424242 2008-03-26 18:27:26 -07:00
nrthomas@gmail.com
da94aa6085 Bug 424242, update timestamps for tagging 3.0b5rc1, p=joduinn, r=me 2008-03-26 02:16:58 -07:00
rhelmer@mozilla.com
b2ad99d61f run mozilla tests on staging 2008-03-21 17:59:12 -07:00
rhelmer@mozilla.com
f995c57ea2 check in staging equiv of moz19-bootstrap.cfg b=415180 2008-03-21 14:24:28 -07:00
rhelmer@mozilla.com
7691c3867d preparing for 3.0b5 release b=424242 r=rhelmer p=joduinn 2008-03-21 14:08:14 -07:00
rhelmer@mozilla.com
4ca2b87502 bustage fix for staging only, update to UPDATE_PACKAGING_R3 2008-03-20 15:40:08 -07:00
rhelmer@mozilla.com
9864e10f4f bustage fix, old rc should be 4 for staging 2008-03-20 10:43:17 -07:00
rhelmer@mozilla.com
827ca9ff50 bustage fix for staging only, need to pull correct RC for previous release 2008-03-20 00:18:43 -07:00
rhelmer@mozilla.com
671bbeda85 use new backupsnip script for backups b=422008 r=joduinn 2008-03-19 13:07:36 -07:00
rhelmer@mozilla.com
79c607d68e move pushsnip from mofo repo, split into separate backup script. p=joduinn, r=rhelmer, original pushsnip written by preed b=422008 2008-03-19 13:01:39 -07:00
rhelmer@mozilla.com
2242b4ad7b prepare 1.9 nightly rollout b=421411 r=nthomas 2008-03-18 11:57:29 -07:00
rhelmer@mozilla.com
26a3f47b90 remove RELEASE tag from l10n repo too b=420005 r=bhearsum 2008-03-18 11:26:02 -07:00
rhelmer@mozilla.com
28855e0065 back out last patch, only want on staging 2008-03-17 07:48:32 -07:00
bhearsum@mozilla.com
3c13f21187 bug 409232: pass in product name to verify-locales.pl - Bootstrap changes to call verify-locales.pl w/ new argument. r=nrthomas, patch=me 2008-03-17 07:21:53 -07:00
rhelmer@mozilla.com
d8b9e95cf7 .13 already started, bump to .14, bustage fix 2008-03-16 23:12:11 -07:00
dbaron@dbaron.org
84ec4d87d0 Expose trace-malloc stack tracing. b=422847 r=brendan a=NPOTDB 2008-03-14 17:11:37 -07:00
rhelmer@mozilla.com
fd285c6c73 bustage fix - need to pull date where 3.0b5pre exists 2008-03-14 13:55:48 -07:00
rhelmer@mozilla.com
2c3963ae51 put update tools on path when in fast mode r=coop b=391958 2008-03-14 13:19:44 -07:00
nrthomas@gmail.com
f0c7de0484 Bug 421917, firefox trunk/moz18 builds go to stage-old for Talos, r=rhelmer 2008-03-14 05:37:05 -07:00
nrthomas@gmail.com
f67c55b209 Bug 422733, use stage-old for release automation until we teach it new tricks r=rhelmer 2008-03-14 03:47:52 -07:00
rhelmer@mozilla.com
824031e282 bustage fix, need to pull from more recent pulldate to get b5pre 2008-03-13 21:44:17 -07:00
kairo@kairo.at
11d09afaff bug 410627 - No complete MARs generated for SeaMonkey Mac L10n builds, r=bsmedberg a=rhelmer 2008-03-13 11:39:38 -07:00
rhelmer@mozilla.com
7127cc11dc fix nthomas' comments from bug 420005 r=nthomas 2008-03-13 10:53:41 -07:00
rhelmer@mozilla.com
36bee74a24 search for buildid as printed by post-mozilla-rel.pl::main() not the update-specific code b=415180 r=nthomas 2008-03-12 16:03:55 -07:00
rhelmer@mozilla.com
bfd0ab62a2 migrate 1.9 nightly builders to release automation b=421411 r=nthomas 2008-03-12 10:34:24 -07:00
bhearsum@mozilla.com
2066bfc469 bug 422122: switch bootstrap.cfg for 200013 release back to stage.m.o. r=nrthomas, patch=me 2008-03-12 09:17:25 -07:00
rhelmer@mozilla.com
565106290e bump to next version b=420005 r=nthomas 2008-03-11 16:09:13 -07:00
rhelmer@mozilla.com
38a8595f76 enable fast-patcher mode b=422235 r=nthomas 2008-03-11 15:59:15 -07:00
bhearsum@mozilla.com
aa2caca4dd bug 422122: bootstrap.cfg updates for Fx20013 release. r=joduinn, patch=me 2008-03-11 14:02:59 -07:00
bhearsum@mozilla.com
4cee04e486 bug 420947: bootstrap changes to support new patcher2.pl prettyVersion. r=rhelmer, patch=me 2008-03-10 11:53:05 -07:00
bhearsum@mozilla.com
9aa544a1bb bug 420947: patcher should use 'prettyVersion' in the update dialog (appv) and 'version' for everything else. r=nrthomas, patch=me 2008-03-10 10:42:47 -07:00
rhelmer@mozilla.com
2c5014cdc3 bump timestamp r=nthomas 2008-03-07 20:48:57 -08:00
rhelmer@mozilla.com
15f720974c bump RC for new win32 build b=418926 r=rhelmer p=joduinn 2008-03-07 10:54:40 -08:00
rhelmer@mozilla.com
19f5b24277 use ffxbld for nightly builds b=417147 r=nthomas 2008-03-06 08:58:03 -08:00
rhelmer@mozilla.com
2a14661bb0 bump 1.8 branch configs b=417147 r=nthomas 2008-03-06 08:29:18 -08:00
rhelmer@mozilla.com
95ceb830e6 typo in symbolServer for staging config r=rhelmer 2008-03-05 20:48:37 -08:00
rhelmer@mozilla.com
2e1d2c56c9 bootstrap config for xulrunner releases b=415180 r=nthomas 2008-03-05 20:37:37 -08:00
rhelmer@mozilla.com
a57a633088 track new kernel version b=418926 r=rhelmer p=joduinn 2008-03-03 23:54:19 -08:00
rhelmer@mozilla.com
34736d7a9e bootstrap config for firefox 3.0b4 rc1 b=418926 r=rhelmer p=joduinn 2008-03-03 12:20:43 -08:00
nrthomas@gmail.com
249ba44d9c Fix symbol push on staging by specifying the right key 2008-03-03 04:22:21 -08:00
dbaron@dbaron.org
e84bf8599b Use better name. 2008-03-02 23:26:21 -08:00
dbaron@dbaron.org
1d0030f9c2 Add a simple variant of make-tree to filter refcount logs for a single object. Not part of the build. 2008-03-02 23:24:55 -08:00
nrthomas@gmail.com
8c7ded2147 Bug 401202, clean up Talkback symbols on slaves properly, r=rhelmer 2008-03-02 01:32:14 -08:00
nrthomas@gmail.com
b33bb7e1bf Bug 417561, disable tagging of Talkback now we have prebuilt packages, r=rhelmer 2008-02-29 09:20:51 -08:00
rhelmer@mozilla.com
d300a30edc remove previous config if present b=415261 r=nthomas 2008-02-27 13:17:38 -08:00
rhelmer@mozilla.com
63cec9b230 use dir with rc in the name b=417703 r=nthomas 2008-02-26 14:00:13 -08:00
rhelmer@mozilla.com
8da8c3d78c symbol server key location is platform dependent b=417889 r=nthomas 2008-02-25 10:36:22 -08:00
nrthomas@gmail.com
7b1046480b Bug 410006, don't hardcode firefox in details url, r=rhelmer 2008-02-20 01:57:27 -08:00
nrthomas@gmail.com
e63391bc9e Bug 401202, quoting fix 2008-02-18 04:31:50 -08:00
nrthomas@gmail.com
91e2dcc443 Bug 401202, disable talkback symbol push for nightlies, r pending 2008-02-18 04:24:12 -08:00
nrthomas@gmail.com
00b1fec19c Bug 417703, PatcherConfig doesn't use a product and version specific working directory, r=rhelmer 2008-02-15 07:40:24 -08:00
rhelmer@mozilla.com
09f0dcb46f prepare bootstrap configs for 1.8 nightly release automation rollout b=417147 r=nthomas 2008-02-14 11:01:07 -08:00
rhelmer@mozilla.com
6fbe7609d4 s/MozillaTest/Mozilla1.8-Staging 2008-02-13 01:28:34 -08:00
rhelmer@mozilla.com
9a362c417d should be testsPhoneHome not runMozillaTests 2008-02-13 01:21:30 -08:00
rhelmer@mozilla.com
d67307dd00 add symbolServer and symbolDir b=401202 r=nthomas 2008-02-12 14:13:01 -08:00
nrthomas@gmail.com
cfed4e3fac Bug 417070, automation config bump for Tb2.0.0.12, r=rhelmer 2008-02-12 14:02:29 -08:00
nrthomas@gmail.com
198665fb35 Bug 401202, prevent buildup of Talkback symbols on stagign setup, r=rhelmer 2008-02-12 04:11:31 -08:00
nrthomas@gmail.com
cba2977d6a Bug 401202, upload Talkback symbols for 2.0.0.x releases to symbol server in automation, r=rhelmer 2008-02-12 04:03:35 -08:00
dbaron@dbaron.org
bcbf67300f Make leak-gauge.html not require enhanced privileges. b=414800 2008-02-08 11:55:34 -08:00
dbaron@dbaron.org
5977f55665 Add leak logging for node info managers that can be added to leak-gauge. b=414704 r+sr=sicking a=schrep 2008-02-08 11:55:03 -08:00
rhelmer@mozilla.com
a6ae7a3bee rc3 to pick up locales b=409880 r=nthomas 2008-02-06 16:16:00 -08:00
bhearsum@mozilla.com
17e3de2889 bug bug 409880: make bootstrap Makefile NOT set chmod +s (to match stage.m.o). r=rhelmer, patch=me 2008-02-06 07:07:50 -08:00
rhelmer@mozilla.com
c06d1e9611 bump for fx 30b3 rc3 2008-02-05 10:22:22 -08:00
rhelmer@mozilla.com
d9ea6484aa timestamp for 3.0b3 b=409880 r=rhelmer p=joduinn 2008-02-04 17:51:09 -08:00
rhelmer@mozilla.com
c94f7e1ba4 update for 3.0b3 release, missing timestamp r=nthomas b=409880 2008-02-04 13:13:43 -08:00
rhelmer@mozilla.com
aef0c84167 back out temporary workaround b=414966 r=nthomas 2008-02-04 13:08:23 -08:00
rhelmer@mozilla.com
0061a2a3d6 set gecko rel branch using gmtime not localtime b=414966 r=nthomas 2008-02-04 13:05:51 -08:00
rhelmer@mozilla.com
6c2f7430db always disable complete jump b=388524 r=nthomas 2008-02-04 12:01:00 -08:00
dbaron@dbaron.org
c861e5a715 And actually get the right bug number. b=415426 (which is what the previous checkin was for as well) 2008-02-03 11:59:07 -08:00
dbaron@dbaron.org
3896f75022 Switch back to evil casts, which are the only solution that works across SDK version. b=415252 2008-02-03 11:51:14 -08:00
dbaron@dbaron.org
4425004b4d Match new (more-const) signature for PENUMLOADED_MODULES_CALLBACK and PENUMLOADED_MODULES_CALLBACK64. b=415426 Fixing bustage on Windows tinderbox from SDK upgrade. 2008-02-03 11:34:31 -08:00
rhelmer@mozilla.com
c7376bfcda 20012 rc4 b=414327 r=rhelmer p=joduinn 2008-02-01 20:32:07 -08:00
rhelmer@mozilla.com
87b0fd09be update time cutoff and branch info b=414327 r=rhelmer p=joduinn 2008-01-31 14:29:39 -08:00
rhelmer@mozilla.com
e59ae979ca workaround tz confusion b=414966 r=nthomas 2008-01-31 07:16:05 -08:00
gerv@gerv.net
0b388ba3b2 Recent fixes 2008-01-31 04:37:41 -08:00
gerv@gerv.net
d062ec7392 Merge in recent changes 2008-01-31 04:36:56 -08:00
rhelmer@mozilla.com
7ab02f84b4 back out workaround from bug 414966 now that it's been tagged 2008-01-30 20:28:17 -08:00
rhelmer@mozilla.com
2f63294c73 temporarily disable Date::Manip until it's installed on the slaves, now that we are past Tag 2008-01-30 15:16:30 -08:00
rhelmer@mozilla.com
f2ca4a55e2 temporarily disable unit tests for release r=joduinn a=rhelmer 2008-01-30 15:08:25 -08:00
rhelmer@mozilla.com
8ec2907050 convert found utc CVS date to local time to match branch b=414966 r=coop 2008-01-30 14:40:45 -08:00
rhelmer@mozilla.com
58561b4663 prepare for 20012 rc2 respin b=414327 r=rhelmer p=joduinn 2008-01-30 13:24:38 -08:00
gerv@gerv.net
2aa5f70050 Check in latest version of tools 2008-01-30 09:19:24 -08:00
rhelmer@mozilla.com
b0258ffd27 bump timestamp for fx 2.0.0.12 release b=414327 r=rhelmer p=joduinn 2008-01-28 19:25:12 -08:00
rhelmer@mozilla.com
a750f3b57a bump config for fx 2.0.0.12 release b=414327 r=cthomas 2008-01-28 09:58:56 -08:00
rhelmer@mozilla.com
a1c3913de3 back out assert patch b=413178 2008-01-28 09:11:51 -08:00
nrthomas@gmail.com
dd96a7f16c Bug 408811, assert when Stage finds a file it doesn't know how to deal with, r=rhelmer 2008-01-25 12:31:46 -08:00
rhelmer@mozilla.com
c3e6d36570 assert that verify dirs do not exist before starting verify b=413178 r=nthomas 2008-01-23 10:46:08 -08:00
bhearsum@mozilla.com
2323990c5a bug 412542: rename buildbot buildmasters - update bootstrap configs. r=rhelmer, patch=me 2008-01-23 08:08:06 -08:00
bhearsum@mozilla.com
88b2bdc6f7 bug 411928: Bootstrap::Step::TinderConfig should support nightly mode - add turnOffTests into 1.8 nightly bootstrap.cfg. r=rhelmer, patch=me 2008-01-22 09:53:15 -08:00
bhearsum@mozilla.com
1ee8e3dc6e bug 412454: the Bootstrap Makefile should be more generic - fix the ftp:// url. r=rhelmer, patch=me 2008-01-22 09:32:33 -08:00
rhelmer@mozilla.com
98b8b25119 typo fix b=411928 r=rhelmer 2008-01-18 14:08:22 -08:00
rhelmer@mozilla.com
648076e0b3 determine branches for nightly mode b=411928 p=bhearsum r=rhelmer 2008-01-18 13:02:39 -08:00
rhelmer@mozilla.com
33fec3a1d3 not finding buildid should not be fatal, warn instead b=410806 r=bsmedberg 2008-01-18 08:58:31 -08:00
rhelmer@mozilla.com
14dd6ea1f1 bump relnote URL b=410006 r=cf a=clouserw 2008-01-18 08:16:31 -08:00
bhearsum@mozilla.com
fc47f06af4 bug 411928: Bootstrap::Step::TinderConfig should support Nightly mode. r=rhelmer, patch=me 2008-01-17 11:40:20 -08:00
bhearsum@mozilla.com
1f862fa1cf bug 412454: the Bootstrap Makefile should be more generic - support different versions, products in Makefile. r=rhelmer, patch=me 2008-01-17 11:31:02 -08:00
bhearsum@mozilla.com
3c947e51ef add prettyAusVersion to trunk bootstrap configs. r=rhelmer, patch=me 2008-01-15 14:53:37 -08:00
rhelmer@mozilla.com
0bff0f3868 bump to 2.0.0.12 b=412505 r=bhearsum 2008-01-15 14:32:31 -08:00
rhelmer@mozilla.com
f474379d58 pull patcher and friends from their own tag b=411235 r=bhearsum 2008-01-15 14:14:05 -08:00
rhelmer@mozilla.com
24ede1fe8e pull MozBuild from patcherToolsRev b=411235 r=nthomas 2008-01-15 12:10:42 -08:00
dolske@mozilla.com
185b35213c Bug 412216 - xpcshell tests (make check) don't work on Solaris. r=robc 2008-01-14 19:46:19 -08:00
rhelmer@mozilla.com
730fe56d02 pull patcher from patcherToolsRev b=411235 r=nthomas 2008-01-12 22:16:39 -08:00
rhelmer@mozilla.com
aa74cca6d4 wrap RunShellCommand in run_shell_command method for better logging and error handling r=coop b=391958 2008-01-11 15:10:59 -08:00
ccooper@deadsquid.com
c2f190ff02 b=391958 r=rhelmer - landing again now that bug 375415 is fixed 2008-01-10 13:06:05 -08:00
nrthomas@gmail.com
9f9fdbb49c Bug 375415, update packaging breaks with filenames containing a space, p=Rob Marshall (tH, rdmsoft@bugs.rdmsoft.com), r=bsmedberg 2008-01-10 12:59:46 -08:00
bhearsum@mozilla.com
9d062faf85 bug 411495: sync up automation bootstrap configs with cvs - add nightly 1.8 bootstrap.cfg, update automation config. r=rhelmer, patch=me 2008-01-10 12:53:44 -08:00
bhearsum@mozilla.com
35bfdbd340 bug 411495: sync up staging trunk bootstrap configs with cvs: update pull times for nightly and release bootstraps. r=rhelmer, patch=me 2008-01-09 11:56:20 -08:00
rhelmer@mozilla.com
7d6c9f3d02 gather metadata and be usable as module b=410806 r=bsmedberg 2008-01-09 11:49:23 -08:00
rhelmer@mozilla.com
16458d5e3f support pretty version string for patcher b=410006 r=cf 2008-01-08 10:26:03 -08:00
bhearsum@mozilla.com
651eb3e128 bug 409394: support long version names for alphas/betas in Bootstrap. r=cf, patch=me 2008-01-08 09:39:11 -08:00
ccooper@deadsquid.com
8833c4f628 b=391958 r=rhelmer - backing uot (again) pending fixes for bug 375415 2008-01-07 20:24:46 -08:00
ccooper@deadsquid.com
6be92e9adb b=391358 r=mozpreed - use make_incremental_updates.py 2008-01-04 09:56:38 -08:00
ccooper@deadsquid.com
ac8d71ac09 b=391358 - standardize on patchlist_file 2008-01-04 09:55:17 -08:00
bhearsum@mozilla.com
bac1025e3f bug 409395: factor out Bootstrap's 'useTarGz' logic to a helper function 2007-12-28 06:36:18 -08:00