Commit Graph

39 Commits

Author SHA1 Message Date
L. David Baron
51c52a48cc Bug 709014 patch 1: Honor margin-left and margin-right on elements in inline layout that have 0 width and/or height (commonly, inline-blocks). r=roc
Prior to this patch, we failed to honor:
 * margin-left on elements in inline layout with 0 width and 0 height
 * margin-right on elements in inline layout with 0 width
I think that was because the code in CanPlaceFrame to discard both
margins when the width was 0 was running after the left-margin was
applied, unless the later code in PlaceFrame (checking both width 0 and
height 0) un-applied that left margin.

The assertion count change in test_value_computation.html is due to 2
additional "bad width" assertions (I presume from honoring large
margins that were previously ignored).

The change to 538935-1-ref.html is to match an improvement in rendering
of the margins in the test, where both sides of the margin are now
honored.

The change to layout/reftests/text-overflow/marker-basic-ref.html is to
keep the reference (which uses margins) rendering the same way following
the changes to margin handling.

The new behavior (in the reftests added in layout/reftests/inline/)
matches at least Chromium; I didn't check any other browsers.
2014-02-17 20:07:45 -08:00
Max Vujovic
b725bd88af Bug 913990 - When encountering bogus URI during style computation for filter, fall back to initial value. r=dholbert 2013-10-17 14:37:57 -04:00
Cameron McCormack
f1d52ca69d Bug 915439 - Use longer timeouts for test_value_computation.html and test_value_storage.html. r=bzbarsky 2013-09-19 11:35:19 +10:00
L. David Baron
57d19fbb86 Bug 404077: Annotate known assertions in mochitests. 2013-02-25 18:39:21 -08:00
Edwin Flores
8a6015cf0d Bug 719286 - Add support for -moz-objectValue keyword to CSS parser for SVG glyphs r=dbaron 2012-09-06 16:58:47 +12:00
L. David Baron
db939a352b Add support for unprefixed calc(), and prefer serializing to unprefixed form. (Bug 771678) r=bzbarsky
This also converts all of the tests in layout/style/test/ to using
calc(), except that it duplicates all of the valid values and some of
the invalid values for 'width' and '-moz-column-rule-width' (which are
the two properties that intentionally have extensive calc() tests) in
property_database.js.
2012-07-13 15:06:50 -07:00
Malini Das
a0832b693a Bug 367393 - Add a packed MochiKit that contains only SimpleTest dependencies- plain tests 2/2. r=jmaher, a=test-only 2011-08-12 12:21:44 -04:00
L. David Baron
3efa9fabcc In contexts where the CSS parser accepts numbers and lengths, treat unitless zero as a number rather than a length. (Bug 595648) r=bzbarsky,dholbert a=blocking2.0:betaN+
This patch has the side-effect of changing the representation of '0'
values in properties added by SVG to use the number representation
rather than the length representation.  This requires marking the
stroke-dashoffset:0 test in test_value_computation.html as known to
fail, since computed style code now returns 0 rather than 0px, and also
requires changing some inputs and results in some SMIL tests (which
seems like it's showing a bug that we can't interpolate between
equivalent values when we ought to be able to do so).
2010-12-30 12:59:33 -05:00
Zack Weinberg ext:(%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
e4c76eccb0 Bug 451134 (1/2): switch to the official border-radius property names: purely mechanical changes. r=dbaron a2.0=blocking2.0:beta6
This was generated with the command:

LC_ALL=C grep -irlEZe '[-_]moz[-_]border[-_]radius([-_](top|bottom)(right|left))?' * | xargs -0 perl -pi -e \
    's/-moz-border-radius-(top|bottom)(left|right)/border-${1}-${2}-radius/gi;
     s/_moz_border_radius_(top|bottom)Right/border_${1}_right_radius/g;
     s/_moz_border_radius_(top|bottom)Left/border_${1}_left_radius/g;
     s/-moz-border-radius/border-radius/gi;
     s/_moz_border_radius/border_radius/g;'
2010-09-09 08:21:47 -07:00
L. David Baron
f9bc2d9cef Fix places where I missed clamping negative calc() to 0. (Bug 585715) r=bzbarsky a2.0=blocking2.0:beta6 2010-09-09 08:21:46 -07:00
L. David Baron
af2f9eff65 Fix missing frame in style system mochitests. (Bug 585715) r=bzbarsky a2.0=blocking2.0:beta6 2010-09-09 08:21:46 -07:00
L. David Baron
86686305cb Add a 'display:block' prerequisite for 'width' property tests so that calc() tests will actually have a percentage basis and thus actually test the code. (Bug 585715) r=bzbarsky a2.0=blocking2.0+ 2010-08-11 12:32:52 -07:00
Karl Tomlinson
1b9df1cee4 b=481751 block-height line-height for text input and strut baseline for textarea r=bz,sr=dbaron
--HG--
extra : rebase_source : 1241360066ea9387d15c71936da9468399240640
2009-05-19 10:13:12 +12:00
L. David Baron
8c38aba811 Switch HTML mochitests from using MochiKit.js to packed.js. (Bug 490955) r=sayrer 2009-05-06 13:46:04 -07:00
L. David Baron
fa0ce94791 Don't mess with the max_script_run_time pref since the mochitest harness now does that for us. 2009-03-31 12:37:40 -07:00
L. David Baron
5195ec80b9 Use SimpleTest.executeSoon instead of setTimeout for iteration of properties/descriptors. 2009-03-31 12:37:40 -07:00
L. David Baron
4835f2a61a Make getComputedStyle() for 'outline-width' return values in pixels even when keywords are used. (Bug 474184) r+sr=bzbarsky 2009-01-22 17:28:13 -08:00
L. David Baron
473a55f246 Fix parsing of 'none' values in 'list-style' shorthand. (Bug 474135) r+sr=bzbarsky 2009-01-22 17:28:13 -08:00
L. David Baron
d11612b0aa Distinguish clip:rect(auto,auto,auto,auto) from clip:auto as the spec requires. (Bug 372063) r+sr=bzbarsky 2008-12-29 10:07:38 -05:00
L. David Baron
805646bab5 Reject 0 as a value for -moz-column-count. (Bug 471341) r+sr=bzbarsky 2008-12-29 10:07:38 -05:00
L. David Baron
020fe687d6 Expect percentages to be unsupported for -moz-column-width. I'm not sure why I made it as it is, since they were never supported in either our implementation or the spec. 2008-12-29 10:07:36 -05:00
L. David Baron
8458c5b6b6 Make 'word-spacing: normal' just compute to '0', since that's what CSS 2.1 says to do, and thus change nsStyleText::mWordSpacing from nsStyleCoord to nscoord. (Bug 470705) r+sr=roc 2008-12-27 20:58:14 -05:00
L. David Baron
10fdc6c423 Put 'thin' in the initial_values section instead of the other_values section for border shorthands, since the width should be 0px when border-style is none. 2008-12-16 17:11:38 -08:00
L. David Baron
65434311b9 Allow the initial value of -moz-user-select to be specified with 'auto'. b=432888 r+sr=bzbarsky 2008-06-03 15:25:31 -07:00
dbaron@dbaron.org
3bc7dd28e0 Fix buggy test; rgb() non-% arguments are required to be integers. a=tests 2008-03-13 08:24:22 -07:00
dbaron@dbaron.org
96ccb2946c Clean up empty gNoComputedStyle lists. 2007-07-22 12:57:15 -07:00
dbaron@dbaron.org
bcde3b4813 Add hooks to get correct computed value for logical box properties. 2007-07-22 12:56:13 -07:00
dbaron@dbaron.org
6f3e04c270 Implement remaining properties in computed style (with some hacks for counter() values for content), and fix some page-break-* bugs exposed by the added test coverage. b=316981 r+sr=bzbarsky 2007-07-22 10:58:37 -07:00
tor@cs.brown.edu
7b793ae7ab Bug 316908 - Add SVG to nsComputedDOMStyle. r+sr=dbaron 2007-07-21 07:20:25 -07:00
dbaron@dbaron.org
2be70ea82e Implement -moz-border-start and -moz-border-end. Patch by Simon Montagu <smontagu@smontagu.org> and me. b=74880 r/sr=smontagu/dbaron 2007-07-04 11:51:16 -07:00
bzbarsky@mit.edu
9a024b3234 Apparently we can't handle "thin" here yet. 2007-05-15 20:33:04 -07:00
dbaron@dbaron.org
3e2d05ec11 Remove known failure fixed by patches in bug 379741. 2007-05-10 23:50:35 -07:00
dbaron@dbaron.org
258af67040 Fix bad string comparison preventing 'none' and 'initial' values of 'counter-increment' and 'counter-reset' from being parsed correctly. b=379555 r+sr=dbaron Patch by Daniel Holbert <dholbert@mozilla.com>. 2007-05-03 17:05:16 -07:00
bzbarsky@mit.edu
3e48c43b01 This test passes now. 2007-04-30 21:31:06 -07:00
bzbarsky@mit.edu
4739353ef4 Implement "content: none". Bug 378535, r+sr=dbaron 2007-04-26 21:43:06 -07:00
dbaron@dbaron.org
2861548e6d Add test for computed style on elements with frames as well. 2007-04-25 16:27:36 -07:00
dbaron@dbaron.org
be11deaee0 A bunch of one-liners to fix bugs found by CSS mochitests. b=377731 r+sr=bzbarsky 2007-04-20 17:16:52 -07:00
dbaron@dbaron.org
a6c2821169 Fix setting of prereqs so it doesn't interfere with testing initial values properly. 2007-04-19 20:41:05 -07:00
dbaron@dbaron.org
f5a47a6bb4 Add tests for computed values. 2007-04-18 19:49:44 -07:00