Bobby Holley
1493608251
Bug 658909 - Remove GWNOJO from nsDOMClassInfo. r=mrbkap
2013-03-16 22:58:16 -07:00
Bobby Holley
2261f1ce91
Bug 658909 - Remove GWNOJO from AccessCheck. r=mrbkap
2013-03-16 22:58:16 -07:00
Bobby Holley
2491e8030a
Bug 658909 - Remove GWNOJO from nsXPConnect. r=mrbkap
2013-03-16 22:58:16 -07:00
Bobby Holley
621e6b8496
Bug 658909 - Remove GWNOJO from XPCVariant. r=mrbkap
...
The old code seems to be deciding whether we have a double-wrapped object by
checking _either_ the rv of GWNOJO _or_ the potential slim wrapper. This is
nonsensical, because double-wrapped objects are never slim wrappers.
Furthermore, that variable here is named 'proto', which further suggests
that this code is nonsensical. So let's just check for WNs.
Also, it seems pretty wack to be innerizing here before storing the jsval,
but I'm going to leave that for now.
2013-03-16 22:58:16 -07:00
Bobby Holley
9066876a33
Bug 658909 - Remove GWNOJO from XPCJSID. r=mrbkap
2013-03-16 22:58:15 -07:00
Bobby Holley
9c4d015129
Bug 658909 - Remove GWNOJO from JSValToXPCException. r=mrbkap
2013-03-16 22:58:15 -07:00
Bobby Holley
0d540a32dd
Bug 658909 - Remove GWNOJO from JSObject2NativeInterface. r=mrbkap
2013-03-16 22:58:15 -07:00
Bobby Holley
8a60c09a1f
Bug 658909 - Remove GWNOJO for helper stubs. r=mrbkap
2013-03-16 22:58:15 -07:00
Bobby Holley
5fbd59201c
Bug 658909 - Remove GWNOJO from MarkWrappedNative. r=mrbkap
2013-03-16 22:58:15 -07:00
Bobby Holley
ffb73d345d
Bug 658909 - Add a new, much simpler API for getting WNs from JS objects. r=mrbkap
2013-03-16 22:58:15 -07:00
Bobby Holley
8160c96d4e
Bug 658909 - Stop doing all the crazy stuff in GetWrappedNativeOfJSObject. r=mrbkap
2013-03-16 22:58:14 -07:00
Bobby Holley
5b8d755b22
Bug 658909 - Add a hack to support calling nohelper XPCWN methods without the proper |this|. r=mrbkap
2013-03-16 22:58:14 -07:00
Bobby Holley
24a5c2c905
Bug 658909 - Use JS_{,Strict}PropertyOp instead of null when defining value props in nsDOMClassInfo. r=mrbkap
...
Using JSPropertyOp means a null shape getter, whereas null means that the shape
uses the class getter. This means that stuff like window.top, which is defined
as a non-configurable |own| property in nsDOMClassInfo, was getting set up with
XPC_WN_Helper_GetProperty as its get operation. But this confused
SandboxProxyHandler, which explicitly avoids rebinding class getters/setters,
which in turn meant that our sandboxPrototype feature was relying on the crazy
prototype-climbing behavior of GetWrappedNativeOfJSObject to make stuff like
|this.top| work. We're removing this behavior, so we need to fix nsDOMClassInfo
here.
Here are some DefineProperty cases that I left with null getters/setters:
* nsDOMClassInfo::ResolveConstructor
* The child window stuff at the bottom of nsWindowSH::NewResolve
* Named item resolution in nsNamedArraySH::NewResolve
* document.all stuff (scary!)
* nsHTMLDocumentSH::NewResolve
* nsHTMLFormElementSH::NewResolve
* nsStorage2SH::NewResolve
2013-03-16 22:58:14 -07:00
Bobby Holley
b458ef37b2
Bug 658909 - Implement carefully-checked unwrapping in XPCCallContext. r=mrbkap
2013-03-16 22:58:14 -07:00
Bobby Holley
721351e660
Bug 658909 - Set args at XPCCallContext construct time in XPC_WN_GetterSetter. r=mrbkap
...
It's not clear to me why it's done this way, but it confuses our ability to
determine during wrapper lookup whether we're doing a set or a get. This aligns
the behavior with XPC_WN_CallMethod, including passing JSID_VOID for the name
(which is safe because XPCCallContext explicitly special-cases JSID_VOID and
doesn't call SetName in that case).
2013-03-16 22:58:13 -07:00
Bobby Holley
e04912b20e
Bug 658909 - Initialize the same fields in both XPCCallContext constructors. r=mrbkap
...
This is a huge footgun. XPCCallContext is hot, but it's not too hot to be safe
here. Garbage XPCWN and JSObject pointers are bad.
2013-03-16 22:58:13 -07:00
Bobby Holley
a22cc9ffed
Bug 658909 - Remove unnecessary ccx param. r=mrbkap
2013-03-16 22:58:13 -07:00
Bobby Holley
11ee47784a
Bug 658909 - Make isSafeToUnwrap pseudo-dynamic for SOWs. r=mrbkap
...
This can go away as soon as XBL scopes are no longer behind a pref.
2013-03-16 22:58:13 -07:00
Bobby Holley
b3038807d1
Bug 658909 - Force |this| computation in SandboxCallableProxyHandler::call when using Xrays. r=bz
...
Comment says it all.
2013-03-16 22:58:12 -07:00
Daniel Holbert
64a1dc01a2
Bug 848159: In jsopcode.cpp, cast formalIndex to be unsigned when comparing it against another unsigned value, since we've already asserted it's nonnegative. r=jandem
2013-03-16 21:38:06 -07:00
Bill McCloskey
a3cea08b3a
Bug 759585 - Zones (r=jonco,bhackett,njn,dvander,luke,bz,mccr8,bholley)
2013-03-16 20:36:37 -07:00
Phil Ringnalda
efff21596e
Back out 9bfca2900825 (bug 694254) for incompetent review
2013-03-16 20:35:53 -07:00
Nicolas B. Pierron
33f141f4de
Bug 849014 - Check type inference before optimizing regexp calls. r=sstangl
2013-03-16 20:05:46 -07:00
Trevor Saunders
176ca13c4d
bug 694254 - disable test_focus_browserui.xul on win 7/8 to see if it fixes the leak rs=philor
2013-03-16 22:10:32 -04:00
Brian R. Bondy
17fddad65c
Bug 849342 - Remember passwords preference does not take effect immediately. r=mbrubeck.
2013-03-16 22:12:09 -04:00
Chris Lord
812de7ec1a
Bug 850789 - Pin the dynamic toolbar on screen when the tabs tray is open. r=kats
2013-03-17 01:53:41 +00:00
Chris Lord
4ffa7aa9ae
Bug 850154 - Fix alignment of find-in-page bar after bug 716403. r=sriram
...
Use the RelativeLayout.LayoutParams instead of LinearLayout.LayoutParams to
make sure the find-in-page bar is aligned to the bottom of the page.
2013-03-17 01:53:40 +00:00
Chris Lord
a27262bcbf
Bug 850724 - Don't hide toolbar on load, or pin while loading. r=kats
...
UX decisions have been made to not hide the toolbar after the page has finished
loading, and not to pin the toolbar during page loading. These decisions fix
this bug.
2013-03-17 01:53:40 +00:00
Phil Ringnalda
83349304b8
Merge inbound and m-c
2013-03-16 15:09:36 -07:00
Brian Hackett
d6bc021244
Backout 04695ce03bb6 (bug 836968) for topcrashing on a CLOSED TREE
2013-03-16 15:57:39 -06:00
Ehsan Akhgari
d1f30ea125
Bug 851814 - Do not clobber the high word of SharedLibrary addresses/offset on Win64; r=jrmuizel
...
--HG--
extra : rebase_source : 9bf7d5cd3dd71e0e1b315059bce4836663bc3a65
2013-03-16 15:05:32 -04:00
Ms2ger
9e905712d0
Merge backout on a CLOSED TREE.
2013-03-16 11:09:58 +01:00
Ms2ger
305e7462bd
Backout changeset f4beba4909b0 and changeset 1666ca9b946b for bc test failures.
2013-03-16 11:09:43 +01:00
Ms2ger
1d0a89d921
Bug 766546 - Disable test on Mac OS X on a CLOSED TREE.
2013-03-16 10:32:51 +01:00
Ms2ger
9bfd277605
Backout changeset 46585b03426a for assertion failures in test_input_range_mouse_and_touch_events.html on a CLOSED TREE.
2013-03-16 10:11:26 +01:00
Phil Ringnalda
e2fe56a8ab
Back out 6922ed98876a (bug 851603) for failing a test it should have removed
...
CLOSED TREE
2013-03-16 00:13:19 -07:00
Frank Yan
36a1ef7c74
Bug 848150 - Update icon data url in Google search plugin test. a=test-only
2013-03-15 23:38:49 -07:00
Phil Ringnalda
ad818a76eb
Merge m-c to fx-team
2013-03-15 22:46:04 -07:00
Ehsan Akhgari
efeba2e207
Bug 851603 - Enable Web Audio in Nightly; r=roc
...
--HG--
extra : rebase_source : b79d7f2cb0e6257eae2f65bd8637f718324b43f4
2013-03-16 01:35:22 -04:00
Gregory Szorc
d85437367b
Bug 846083 - Submit an FHR payload after initialization failure; r=rnewman
2013-03-15 21:31:07 -07:00
Gregory Szorc
7ea2ea768e
Bug 845935 - Don't perform FHR activities unless fully initialized; r=rnewman
2013-03-15 21:10:08 -07:00
Gregory Szorc
b6ebd60dd3
Bug 849947 - Flush preferences after FHR document submission; r=glandium, rnewman
2013-03-15 13:19:38 -07:00
Gregory Szorc
bb79108f63
Bug 830408 - Tests for data reporting notification bar; r=gavin
2013-03-15 10:07:39 -07:00
Eddy Bruel
e4eed3e455
Bug 808960 - Can't fetch sources packed in jar bundles when debugging chrome; r=past,vporof
2013-03-14 21:57:00 -07:00
Ryan VanderMeulen
f5c5161a22
Merge m-c to inbound.
2013-03-14 21:45:34 -04:00
Richard Newman
d0a1c92137
Merge m-c to s-c.
2013-03-14 15:31:08 -07:00
Eddy Bruel
9ac01005e6
Bug 820012 - unable to debug scripts loaded via loadSubScript in Browser Debugger; r=past
2013-03-14 15:21:00 -07:00
Tim Taubert
3ba85b9600
Bug 841350 - Drag and drop a CTP tab in a new window makes the CTP icon disappear; r=gavin,ttaubert
2013-03-15 14:13:52 +01:00
Paul Rouget
c018719aeb
merge fx-team to m-c
2013-03-14 15:18:42 -07:00
Hannes Verschore
b2dc08fb88
Backed out changeset 9f39547cfab3 (bug 850534) for yarr crashes on a CLOSED TREE
2013-03-14 23:15:50 +01:00