Gregory Szorc
58bcd2801d
Bug 787273 - Part 2: Refactor Resource and Record to not rely on singletons; r=rnewman
...
Resource currently relies on the Identity singleton to perform
authentication. This is bad magic behavior. Resource instances should
authenticate according to the service instance they are associated with.
This patch removes Identity magic from Resource. Everything using
Resource now explicitly assigns an authenticator which comes from
the service instance/singleton. This required API changes to Collection
and Record.
The preferred method to obtain a Resource instance is to call
getResource() on a service instance.
The end result of this patch looks a little weird, especially in test
code. You have things like Service.resource(Service.cryptoKeysURL).
This ugliness will go away when a unified storage service client is
used.
2012-09-14 16:02:32 -07:00
Gregory Szorc
c9586f34a5
Bug 787273 - Part 1: Remove Records singleton; r=rnewman
...
RecordManager is now an instance of the Service singleton and holds a
reference back to the service which is used to obtain needed "global"
state.
2012-09-14 16:02:32 -07:00
Gregory Szorc
892b21e25b
Bug 786489 - Part 2: Change username through Identity not prefs; r=rnewman
...
The preferred way to change the username is through the Identity
singleton, not by updating a pref and hoping the side-effect is what you
want.
2012-08-29 14:43:41 -07:00
Gregory Szorc
5f41f9020f
Bug 786489 - Part 1: Update serverURL and clusterURL through Service; r=rnewman
...
The preferred method to update serverURL and clusterURL is by going
through the SyncService Service singleton, not by setting preferences.
2012-08-29 14:43:41 -07:00
Gregory Szorc
ae2a788f16
Bug 785225 - Part 11: Burninate trailing whitespace from tests; r=rnewman
2012-08-29 14:43:41 -07:00
Gregory Szorc
45d3f90cf3
Bug 785225 - Part 9: Refactor engines to not use singletons; r=rnewman
...
Engines now maintain a reference to the service they belong to. This
allows them to obtain references to other engine instances belonging to
that service and that service only.
Stores and trackers now maintain a reference to the engine they belong
to.
Engine managers now maintain a reference back to a service.
The clients singleton has been removed. It now exists as an instance
variable on Service. Parts of ClientsEngine do behave as singletons
(e.g. commands). This will be addressed in future refactoring.
2012-08-29 14:43:41 -07:00
Gregory Szorc
88f9794fe7
Bug 785225 - Part 8: Don't expose SyncScheduler as a singleton; r=rnewman
2012-08-29 14:43:41 -07:00
Gregory Szorc
db187465ed
Bug 785225 - Part 7: Bind SendCredentialsController to a Service instance; r=rnewman
2012-08-29 14:43:40 -07:00
Gregory Szorc
5628a0cd3b
Bug 785225 - Park 6: Move StorageCredentialsController to jpakeclient.js; r=rnewman
...
I'm not sure why it was in policies.js, as it has everything to do with
J-PAKE exchange.
2012-08-29 14:43:40 -07:00
Gregory Szorc
bb5d240869
Bug 785225 - Part 5: Partial removal of Clients singleton; r=rnewman
...
Clients was being exported and used as a singleton. We still use Clients
as a singleton in some places, but only in test code. The preferred
method to access Clients is now through a service instance.
Weave.Clients is no longer exposed. Callers go through Weave.Service
now.
2012-08-29 14:43:40 -07:00
Gregory Szorc
57684fd336
Bug 785225 - Part 4: Remove unused exports from Weave; change engine loading; r=rnewman
...
Lots of exports from the Weave global object weren't being used. This
also changes how engines are loaded. There is now a mapping in
service.js of engine name to filename. Before, it was looking at Weave.
2012-08-29 14:43:40 -07:00
Gregory Szorc
b11d37e791
Bug 785225 - Part 3: Don't expose ErrorHandler as a singleton; r=rnewman
...
Some tests still expect there to only be a single instance of
ErrorHandler for the life of the tests. And, ErrorHandler itself is
pretty tighly coupled with being a singleton because it writes out
changes to prefs, etc. But, it's a step in the right direction.
2012-08-29 14:43:40 -07:00
Gregory Szorc
512b106c9a
Bug 783721 - Refactor User API service interaction; r=rnewman
2012-08-29 14:43:39 -07:00
Gregory Szorc
78da7d80a6
Merge mozilla-central into services-central
2012-08-20 09:34:02 -07:00
Gregory Szorc
70ae3d2aef
Bug 781952 - Part 3: Remove unused Service._updateCluster; r=rnewman
2012-08-14 11:34:28 -07:00
Gregory Szorc
46d44b7e4f
Bug 781952 - Part 2: Move cluster management out of service.js; r=rnewman
2012-08-14 11:34:20 -07:00
Gregory Szorc
02c00a0d0b
Bug 781952 - Part 1: Refactor engine syncing logic out of service.js; r=rnewman
2012-08-14 11:34:14 -07:00
Gregory Szorc
b2d302b359
Bug 618233 - Re-disable test_jpakeclient.js on Windows for oranges; r=rnewman
2012-08-13 10:29:28 -07:00
Gregory Szorc
ca4707e2b9
Bug 618233 - Enable test_jpakeclient.js on Windows; r=rnewman
...
May trigger intermittent oranges. Trying to reproduce so we can triage.
2012-08-08 16:43:05 -07:00
Gregory Szorc
cd1c493cc9
Bug 779391 - Move deepCopy into CommonUtils; r=rnewman
2012-08-01 12:05:29 -07:00
Gregory Szorc
b5da03f768
Bug 777989 - Move add-on helper functions out of add-ons engine; r=rnewman
2012-07-30 17:05:33 -07:00
Richard Newman
6999d209a9
Bug 762606 - Another attempt at stopping tests finishing too soon. r=orange
2012-07-28 18:19:27 -07:00
Richard Newman
557a8e3c6c
Bug 762606 - Intermittent test_resource_async.js | test failed (again). r=gps
2012-07-26 14:01:43 -07:00
Richard Newman
1229df592e
Bug 763973 - Intermittent test_resource_async.js | test failed (with xpcshell return code: 0) | false == true. r=gps
2012-07-24 19:55:48 -07:00
Dave Townsend
7a602435d3
Bug 782881 - Protect against attempts to use the Add-ons Manager APIs after shutdown. r=Unfocused
...
Bug 782881 - Protect against attempts to use the Add-ons Manager APIs after shutdown. r=Unfocused
2012-05-10 11:33:02 -07:00
Blair McBride
36643cef64
Backout 42bc5a310a29 (bug 782881) due to multi-orange.
2012-08-15 23:07:45 +12:00
Dave Townsend
2182723b6e
Bug 782881 - Protect against attempts to use the Add-ons Manager APIs after shutdown. r=Unfocused
2012-05-10 11:33:02 -07:00
Benjamin Peterson
da659fcf4b
Bug 722956: clear async io timer, so it doesn't run after shutdown has started. r=philkon
2012-07-12 16:36:41 -07:00
Gregory Szorc
e1fe939f19
Bug 772569 - Remove do_load_httpd_js from services test code; r=rnewman
2012-07-10 11:54:12 -07:00
Gregory Szorc
4b84e41223
Bug 757860 - Load JS HTTP server as a module; r=rnewman
...
--HG--
rename : services/common/tests/unit/aitcserver.js => services/common/aitcserver.js
rename : services/common/tests/unit/storageserver.js => services/common/storageserver.js
2012-06-29 13:28:17 -07:00
Gregory Szorc
da3ef15a1f
Bug 756366 - Preserve Sync credentials during client wipe; r=rnewman
2012-05-22 10:17:53 +02:00
Gregory Szorc
6fd01e4b30
Merge services-central into mozilla-central
2012-05-15 09:39:11 -07:00
Gregory Szorc
17660cf146
Bug 753515 - Move json{Load,Save} from services-sync into services-common; r=mconnor
...
--HG--
rename : services/sync/tests/unit/test_utils_json.js => services/common/tests/unit/test_utils_json.js
2012-05-10 12:21:21 -07:00
Gregory Szorc
fdb09d5559
Merge m-c to s-c
2012-05-03 14:33:48 -07:00
Gregory Szorc
8702cdf9b5
Bug 749957; r=rnewman
2012-05-03 14:25:33 -07:00
Richard Newman
51c4f5af7a
Merge m-c to s-c.
2012-04-20 10:51:26 -07:00
Gregory Szorc
0dfd030129
Bug 745425 - Fix bustage in test_prefs_tracker.js from previous commit; r=bustage
2012-04-17 16:45:32 -07:00
Anant Narayanan
40e445624c
Bug 745425 - Move Utils.encodeBase64url to CommonUtils; r=gps
2012-04-17 15:42:33 -07:00
Gregory Szorc
eb60a9651c
Bug 745396 - Refactor Sync utility functions into services-{common,crypto}; r=rnewman
2012-04-16 12:19:01 -07:00
Matthew Noorenberghe
7cb795d1dd
Bug 739697 - Don't begin a transaction for formhistory.sqlite if there's an existing one since we don't support nesting them. r=zpao,rnewman a=tracking-firefox
...
--HG--
extra : rebase_source : c78eed21037ffbd063230f9f16b1008eebb01310
2012-04-06 15:26:00 -04:00
Paolo Amadini
d40ad60816
Bug 715355 - Deprecate and remove old style GUIDs. r=mak
...
--HG--
extra : rebase_source : 0d0a2ac825ed674075e8e85607a496668953c6c1
2012-04-12 12:27:57 +02:00
Richard Newman
a1735e0ff4
Merge m-c to s-c.
2012-04-09 18:57:46 -07:00
Gregory Szorc
889eca9a49
Bug 743413 - Move some utility functions from sync to common; r=rnewman
...
--HG--
rename : services/sync/tests/unit/test_utils_atob.js => services/common/tests/unit/test_utils_atob.js
rename : services/sync/tests/unit/test_utils_utf8.js => services/common/tests/unit/test_utils_utf8.js
2012-04-09 15:39:59 -07:00
Gregory Szorc
49412510e0
Bug 731494 - Refactor generic code from services/sync into services/common; r=rnewman
...
--HG--
rename : services/sync/modules/async.js => services/common/async.js
rename : services/sync/modules/log4moz.js => services/common/log4moz.js
rename : services/sync/modules/ext/Observers.js => services/common/observers.js
rename : services/sync/modules/ext/Preferences.js => services/common/preferences.js
rename : services/sync/modules/ext/StringBundle.js => services/common/stringbundle.js
rename : services/sync/tests/unit/test_async_chain.js => services/common/tests/unit/test_async_chain.js
rename : services/sync/tests/unit/test_async_querySpinningly.js => services/common/tests/unit/test_async_querySpinningly.js
rename : services/sync/tests/unit/test_log4moz.js => services/common/tests/unit/test_log4moz.js
rename : services/sync/tests/unit/test_Observers.js => services/common/tests/unit/test_observers.js
rename : services/sync/tests/unit/test_Preferences.js => services/common/tests/unit/test_preferences.js
rename : services/sync/tests/unit/test_restrequest.js => services/common/tests/unit/test_restrequest.js
rename : services/sync/tests/unit/test_utils_makeURI.js => services/common/tests/unit/test_utils_makeURI.js
rename : services/sync/tests/unit/test_utils_namedTimer.js => services/common/tests/unit/test_utils_namedTimer.js
rename : services/sync/tests/unit/test_utils_stackTrace.js => services/common/tests/unit/test_utils_stackTrace.js
2012-04-05 23:26:06 -07:00
Marco Bonardo
98ac9c56b8
Bug 737841 - Part 3: remove no more useful redirectsMode query option.
...
r=dietrich rs=gavin
--HG--
rename : toolkit/components/places/tests/queries/test_redirectsMode.js => toolkit/components/places/tests/queries/test_redirects.js
2012-04-07 01:17:53 +02:00
Gregory Szorc
6f41b50825
Bug 741670 - Don't sync hotfix extensions; r=rnewman, Unfocused
2012-04-03 08:55:58 -07:00
Gregory Szorc
bfb043da1b
Bug 739320 - Handle title in received "display URI" Sync commands; r=rnewman
2012-03-28 12:53:57 -07:00
Richard Newman
2a4fc96e59
Bug 739892 - correct type comparison error and typo in 7703db949571 (Bug 739339). a=borkage
2012-03-27 22:21:22 -07:00
Marina Samuel
550215a57b
Bug 739320 - Send title in display URI command; r=gps
2012-03-27 10:13:52 -07:00
Richard Newman
15fde3b635
Bug 739339 - make desktop Sync more robust against malformed bookmark records. r=gps
2012-03-26 18:40:28 -07:00
