wine/gecko
0
0
Fork 0
mirror of https://gitlab.winehq.org/wine/wine-gecko.git synced 2024-09-13 09:24:08 -07:00
Code Issues Packages Projects Releases Wiki Activity
62,925 Commits 1 Branch 166 Tags 1.2 GiB
58bc9cfc09
Commit Graph

648 Commits

Author SHA1 Message Date
Chris AtLee
18a466475d Bug 563008 - fix upload.py on python2.4. r=ted 2010-04-30 14:54:51 -04:00
Dave Townsend
74b7768710 Backout new add-ons manager due to Ts regression on OSX 10.5 
--HG--
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_bug404024.xml => toolkit/mozapps/extensions/test/unit/data/test_bug404024.xml
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_bug417606.xml => toolkit/mozapps/extensions/test/unit/data/test_bug417606.xml
rename : toolkit/mozapps/extensions/test/xpcshell/data/test_bug424262.xml => toolkit/mozapps/extensions/test/unit/data/test_bug424262.xml
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug404024.js => toolkit/mozapps/extensions/test/unit/test_bug404024.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug417606.js => toolkit/mozapps/extensions/test/unit/test_bug417606.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug424262.js => toolkit/mozapps/extensions/test/unit/test_bug424262.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug449027.js => toolkit/mozapps/extensions/test/unit/test_bug449027.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug455906.js => toolkit/mozapps/extensions/test/unit/test_bug455906.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug514327_3.js => toolkit/mozapps/extensions/test/unit/test_bug514327_3.js
rename : toolkit/mozapps/extensions/test/xpcshell/test_bug541420.js => toolkit/mozapps/extensions/test/unit/test_bug541420.js
 2010-05-01 11:04:44 -07:00
Dave Townsend
7dbd88b267 Bug 555486: Add a scope property to add-ons and allow disabling loading add-ons from certain scopes. r=robstrong 2010-04-07 11:08:32 -07:00
Mike Hommey
6e619280f1 Bug 543469 - Remove compiled python objects from automation during 'make clean' [r=ted.mielczarek] 
--HG--
extra : rebase_source : 9a0445c40fe27ec9fced679cc601ce55598d6fb8
 2010-04-19 10:17:51 +02:00
Mike Hommey
2c3fe46119 Bug 557750: Remove vestigial code from the old safebrowsing protocol. r=vlad 2010-04-10 15:59:33 -04:00
Jacek Caban
04c024f872 Bug 551256 - Disable vmwarerecordinghelper on mingw. 
r=ted.mielczarek.
 2010-03-24 00:24:38 +01:00
Jesse Ruderman
6f0e23cf0d Fix bug 539691: disable timeouts when using an interactive debugger, and use a saner timeout-kill method when using a non-interactive debugger. r=ted 2010-03-20 23:08:49 -07:00
Joel Maher
d684032e5d Bug 540617 Process.kill instantiates another Automation() which adds another log handler r=ted 2010-03-18 13:13:33 -07:00
Joel Maher
3d98926580 Bug 543825 use of __import__ needs to be removed from automation.py r=ted 2010-03-18 11:14:14 -07:00
Ted Mielczarek
ba889fe98f bug 411588 - support 64-bit universal binaries on OSX. add a build/macosx/universal/mozconfig-64. r=josh 
--HG--
rename : build/macosx/universal/mozconfig => build/macosx/universal/mozconfig.common
 2010-03-18 10:22:54 -04:00
Smokey Ardisson
198cd4c58a Bug 552028 - Teach flight.mk about Camino-with-toolkit.jar. r=ted. Camino-only, NPOTDB 2010-03-17 20:37:50 -04:00
Ted Mielczarek
67136883ea bustage fix from bug 551941 - remove old binaries before running test 2010-03-17 14:14:08 -04:00
Ted Mielczarek
47d43bb381 bug 551941 - fix 'unify' to recognize 64-bit Mach-O files. r=bsmedberg 
--HG--
extra : rebase_source : 5b9ae5f47929f69d8c0627ed694b6c4354ca995e
 2010-03-17 11:55:56 -04:00
Joel Maher
7f0cf8043f Bug 552441 Update devicemanager to have better error reporting for failed file transactions r=ctalbert a=dholbert for CLOSED TREE landing, NPOTB 2010-03-15 15:45:00 -07:00
Ben Turner
00147d1b0e Bug 551256 - 'Automate VMWare recording over mochitests'. r=ted, a=dholbert for CLOSED TREE 2010-03-15 14:44:29 -07:00
Clint Talbert
1a2a0d923c Backed out changeset 31b7d1785eb2 due to automation.py bustage 2010-03-13 11:57:16 -08:00
Joel Maher
9778c202b6 Bug 543825 remove __import__ from automation.py r=ted 2010-03-13 11:20:27 -08:00
Joel Maher
e1bb662746 Bug 512319 Add options for mochitest to use an external server r=ted 2010-03-13 09:56:24 -08:00
Joel Maher
e2fbedec3f Bug 493748 Refactor xpcshell test harness to enable it to work for remote devices r=ted (comment 14) p=jmaher Landing on a CLOSED TREE 2010-03-12 14:57:29 -08:00
Joel Maher
64cc671e70 Bug 544097 Fixing up leaktest and profileserver tests to run with these changes r=ctalbert p=jmaher. Landed on CLOSED TREE 2010-03-12 13:53:37 -08:00
Joel Maher
d050afae06 Bug 544097 Chaning mochitests to run against mochi.test instead of localhost r=ted, waldo, dwitte p=jmaher. Landed on CLOSED TREE 2010-03-12 13:53:36 -08:00
Brad Lassey
fc1bca48f4 bug 550138 - default thread size is too big r=dougt 2010-03-11 12:28:48 -05:00
Brad Lassey
8857f4c08a bug 548207 - allow make check to run over remote connection from devicemanager.py r=ted,ctalbert,jmaher 
--HG--
rename : build/devicemanager.py => build/mobile/devicemanager.py
 2010-03-10 13:36:45 -05:00
Brad Lassey
88c0c2b388 follow up to bug winmo_xmalloc, removing circular dependency r=dougt 2010-03-10 00:43:26 -05:00
Brad Lassey
bb55fe310f backing out changesets e939397fc6a5, 88529662c474 and 3d7c54b194bb due to random hangs in pgo tests 2010-03-09 22:33:11 -05:00
Joel Maher
be2af66d17 Bug 512319 Add options for mochitest to use an external server p=jmaher r=ted 2010-03-09 11:54:39 -08:00
Joel Maher
661862b905 Bug 544097 changing mochitests to use mochi.test instead of localhost for windows mobile refactoring p=jmaher, r=ted,dwitte, sayrer, waldo, ctalbert 2010-03-09 08:55:39 -08:00
Joel Maher
aef3dc32c3 Bug 544097 changing mochitests to use mochi.test instead of localhost for windows mobile refactoring p=jmaher, r=ted,dwitte, sayrer, waldo, ctalbert 2010-03-09 08:55:39 -08:00
Kyle Huey
7517f91287 Backing out Bug 544097 due to test failures. 2010-03-09 01:16:43 -05:00
Kyle Huey
1d0289c601 Backed out changeset 8ce70abd7777 2010-03-09 01:14:21 -05:00
Brad Lassey
a6d4e38cee bug 551098 - windows mobile crashes on start up since xmalloc landing r=cjones 2010-03-08 22:45:51 -05:00
Joel Maher
cee9b522a0 Bug 544097 Change mochitests to use mochi.test instead of localhost for mobile refactoring p=jmaher r=ted,dwitte,sayrer 2010-03-08 19:21:33 -08:00
Ginn Chen
c31fc239f4 Bug 538723: run_for_effect is not portable for Bourne shell r=ted.mielczarek 2010-03-08 17:30:40 +08:00
Clint Talbert
7ffd9496bc Backed out changeset b4372055f473 -- due to unexplained orange on OS X Leak test (Bd) box 2010-03-07 17:34:23 -08:00
Joel Maher
ef6c5fda3d Bug 544097 - Change mochitests to use mochi.test instead of localhost for mobile test refactoring p=jmaher, r=sayrer,dwitte 2010-03-07 16:08:05 -08:00
Mike Hommey
9d5f4470d3 Bug 541768 - automation.py is not cleaned up. r=ted 2010-03-05 14:41:53 +01:00
Mike Hommey
1ea4f9d095 Bug 541769 - leaktest files are not cleaned up by make clean. r=ted 2010-03-05 13:36:11 +01:00
Robert O'Callahan
8763894793 Bug 536524. Normalize paths when possible/necessary to keep them under MAX_PATH limits. r=bsmedberg 2010-03-05 11:52:59 +13:00
Chris Jones
dda6d9e99e Bug 441324, part 4: Enable infallible operator new (leaving malloc fallible) in Gecko, and play well with the wince shunt. r=bsmedberg r=blassey r=vlad 2010-03-03 23:02:58 -06:00
Chris Jones
2141078f6e Bug 441324, part 3: Configure and build changes for libmozalloc. r=bsmedberg 2010-03-03 23:02:57 -06:00
Serge Gautherie
5e5a1c2817 Bug 501436 - move Gecko 1.9.3 tinderboxes and production builds to Mac OS X 10.5, 10.5 SDK, gcc-4.2; (Bv1) Fix comment too. 
r=ted.mielczarek.
 2010-03-03 11:12:28 +01:00
Karl Tomlinson
ac0dd4cca9 Use SIGABRT to trigger breakpad in hangs on UNIX to make these easier to distinguish from SIGSEGV crashes rs=ted no bug 
--HG--
extra : rebase_source : 6fad8dba8c062f3f0bf54fb29e0f1ae64d0bec0b
 2010-02-25 15:05:48 -08:00
Brad Lassey
57605a591c bug 547627 - formattm test fails on windows mobile r=dougt 2010-02-25 13:12:33 -05:00
Doug Turner
99bbb9251a Backed out Bug 489813 / changeset 0542680c6f74 2010-02-23 23:11:18 -08:00
Doug Turner
8191486eee Bug 489813 - fire geolocation timeout error if the provider fails to response after initial response. r=olli 
--HG--
extra : rebase_source : 03c08ca4f017302e8ae2e63cdb844c62f01c234e
 2010-02-23 20:27:27 -08:00
Joel Maher
b4e4a16416 bug 541410 - add devicemanager.py to mozilla-central r=ctalbert 2010-02-23 11:48:16 -05:00
Brad Lassey
eb2aa14614 bug 547864 - default entry point from winmo tool wrappers is invalid r=dougt 2010-02-22 20:28:38 -05:00
Jesse Ruderman
8dd58baaf8 Bug 539516 - Switch automation.py to use the new python stack fixer. r=ted 
--HG--
rename : tools/rb/fix-macosx-stack.py => tools/rb/fix_macosx_stack.py
 2010-02-21 13:03:20 -08:00
Alex Pakhotin
4dd5624d9c bug 536972 - Cannot uninstall Fennec from Settings -> Memory Settings/Remove Programs r=blassey a=NPOTB 2010-02-04 23:44:24 -08:00
Ted Mielczarek
fffbd88cf3 bug 540627 - provide an environment variable to save minidumps from test runs. r=bsmedberg 
--HG--
extra : rebase_source : d53ac17a06eb938e1fcd9a59e409b3467c04fed9
 2010-02-03 14:15:17 -05:00
Daniel Holbert
7f88cb2313 Backed out changeset 8006ad2d0c06 (tests for bug 542263), since its test 'test_GCrace.html' failed on OSX in its first cycle. 2010-02-02 18:57:15 -08:00
Benjamin Smedberg
49079e3a39 Testcase for bug 542263 - crash at NPObjWrapper_NewResolve or various other places 2010-02-02 17:18:41 -08:00
Benjamin Smedberg
ef77036adb Fix typo in error-handling case that we rarely hit, r=trivial 
--HG--
extra : rebase_source : a6172b6b004f71fd14f818eb5da56dc04f98b46a
 2010-01-26 17:46:47 -05:00
Ted Mielczarek
ac8de218d9 punt on bug 540369, set timeout=None for leaktest 
--HG--
extra : rebase_source : 76440f6d2d263f951bf18e53336d51a779c8a838
 2010-01-26 08:14:01 -05:00
Phil Ringnalda
b64c3e6e94 Try again to fix the Windows debug bloatcycle bustage from bug 540369, by cranking the timeout up to 3540 seconds 2010-01-25 21:22:45 -08:00
Jonathan Griffin
1c21d4f027 Provide a higher timeout for leaktest.py, since it began timing out at 60s after fixing bug 540369. 2010-01-25 17:45:39 -08:00
Jonathan Griffin
f5408fbb58 Bug 540369. Fix unit test hang detection on Windows. r=ted 
--HG--
extra : rebase_source : 9e9c8f45f61585ac0bb3f08d873289003d95c14d
 2010-01-25 12:37:58 -08:00
Jesse Ruderman
dc44a1f223 Bug 540518 - when searching for debugger, ignore directory names. r=jgriffin 2010-01-21 12:02:51 -08:00
Jesse Ruderman
bb44d4d4df Fix bustage from rev 0aeedccc0125 (bug 530475) when running tests with maxTime. 2010-01-19 15:47:57 -08:00
Joel Maher
c606caf24b Bug 530475 - convert test harness python code to classes additional refactoring for automation.py and runtests.py p=jmaher r=ted 2010-01-19 11:45:04 -08:00
Joel Maher
fe0f0b0ff6 Bug 530475 - Convert testharness python code to classes for future integration with mobile framework p=jmaher r=ted 2010-01-15 09:22:54 -08:00
Benjamin Smedberg
576026672e Bug 539290 - Test harness should look for minidumps from child (plugin) processes but not turn the tree orange automatically, r=ted 
--HG--
extra : rebase_source : abc65388958859668b63342c046985e1e4083012
 2010-01-12 16:53:10 -05:00
Clint Talbert
a8699cf98f Orange on Bd builds: Backed out changeset 745af1f3dbf5 2010-01-13 14:44:49 -08:00
Joel Maher
37b4f8d10a Bug 530475, convert test harness python code to classes for future integration with mobile framework. r=ted patch=jmaher 2010-01-13 13:53:26 -08:00
Benjamin Smedberg
19f2d945a4 Import ctypes.wintypes explicitly to avoid a python exception when child processes get hung. 2010-01-08 15:52:37 -05:00
Neil Rashbrook
a711f8a29e Bug 525057 'make clean' deletes automationutils.py r=ted 2010-01-11 23:55:51 +00:00
Clint Talbert
1acc74d9c9 Backed out changeset e67e79969232 due to orange on debug mochitests 2010-01-07 19:57:02 -06:00
Joel Maher
f1b69370ac Bug 530475 - Refactoring test harnesses to classes for easier reuse for mobile testing p=jmaher r=ted 2010-01-07 12:47:19 -06:00
Jesse Ruderman
449c044e61 Bug 532184: add optional maxTime argument to runApp. r=ted 2010-01-06 16:45:46 -08:00
Clint Talbert
cd0159d485 Merging backout to tip - backout of 85cd0f297421 2010-01-06 16:08:37 -06:00
Clint Talbert
4c1d49b91d Backed out changeset 85cd0f297421 - causing orange on leak bloat and linux mochitests 2010-01-06 16:03:29 -06:00
Clint Talbert
3b257a648b Backed out changeset aa6337822028 2010-01-06 16:01:43 -06:00
Mark Banner
9d86fe218d Follow-ups to fix bloat bustage and make xpcshell-test result reporting work with buildbot after the landing of bug 530475. r=ted over irc. 2010-01-06 19:59:12 +00:00
Dave Townsend
2499013b41 Bug 435743: Add expire ssl certificate to the mochitest certdb. r=ted 2010-01-06 10:25:44 -08:00
Joel Maher
4d4376e23a Bug 530475 - convert all python test harnesses to classes for easier reuse, patch=jmaher, r=ted 2010-01-06 12:01:18 -06:00
Benjamin Smedberg
b916205fe7 Bug 535802 - disable the Windows JIT crash dialog when running mochitests, r=ted 2009-12-18 16:16:38 -05:00
Jonathan Griffin
045e42c873 But 535564. Remove log file after all processes are closed. r=bsmedberg 2009-12-22 15:13:59 -08:00
Neil Rashbrook
ba5f0c33fd Bug 525047 'make clean' deletes automationutils.py (backout) 2009-12-18 00:19:53 +00:00
Neil Rashbrook
a2ecb52c78 Bug 525057 'make clean' deletes automationutils.py r=ted 2009-12-17 20:59:10 +00:00
Benjamin Smedberg
ffeebc91f0 Merge mozilla-central into electrolysis 2009-12-16 08:38:42 -05:00
Gavin Sharp
d801147906 Back out revision dbdbe3ad0234 from bug 525047 - every leak test box that's clobbered since it landed has failed, not finding the first thing it tries to import from automationutils 
--HG--
extra : rebase_source : 6c8b3ef583b3ad06de1b395db13bedee735f125e
 2009-12-15 23:35:30 -05:00
Benjamin Smedberg
daab3b8125 Merge mozilla-central into electrolysis. 2009-12-15 20:31:04 -05:00
Jonathan Griffin
c8277833b7 Bug 534934 - mochitest-ipcplugins: OSError: [Errno 10] No child process, r=bsmedberg 2009-12-15 20:21:51 -05:00
Neil Rashbrook
5c00290acc Bug 525057 \'make clean\' deletes automationutils.py r=ted 2009-12-15 21:39:51 +00:00
Benjamin Smedberg
999be86ac2 Merge mozilla-central into electrolysis. 2009-12-14 08:01:18 -05:00
Benjamin Smedberg
422b4b28d2 Merge mozilla-central into electrolysis. One code change was required: in nsDocShell::CreateStaticClone I replaced EnsureDocShell with MaybeCreateDocShell. 2009-12-12 13:38:25 -05:00
Jonathan Griffin
fb84e3c42c Bug 533482. Let plugin crashtest notify testrunner that no leak log is expected when the plugin process is deliberately crashed. r=bsmedberg 2009-12-09 10:51:38 -08:00
Chris Jones
73f7822671 bug 532962: allow run-mozilla.sh to accept debugger arguments. r=luser 2009-12-07 01:10:46 -06:00
Benjamin Smedberg
9911c2f99d Merge mozilla-central into Electrolysis 2009-11-30 12:59:43 -05:00
Jesse Ruderman
8864bcc69f Bug 531479 - Always return exit status of the app, not the stack fixer process. r=dbaron 2009-11-29 13:29:03 -08:00
L. David Baron
fa805f174f Rerun 'make genservercert' in build/pgo and commit the resulting certs to fix expired test server certs and make the tree green. 
--HG--
extra : transplant_source : L%D1V%EAX%C1%C1%E2%8A%DF%F5%AC%AA%B4%DB%D2%D1L%2AS
 2009-11-28 21:30:27 -08:00
Clint Talbert
9d4e70e54d Causing oranges -- Backed out changeset b3c18f150531 2009-11-25 18:00:31 -08:00
Joel Maher
7badfdc5f7 Bug 512319 Add option to allow mochitest to use external web server patch=jmaher r=ted 2009-11-25 17:04:02 -08:00
Ted Mielczarek
d05bbfd9e2 bug 530093 - allow building with VC10. configure+build system changes. r=bsmedberg 2009-11-23 10:20:21 -05:00
Benjamin Smedberg
d9b09766b1 Bug 523208 - ensure mochitest expects multiple processes, original patch by jgriffin, reworked for ted's review comments by bsmedberg, r=ted 2009-11-20 14:48:56 -05:00
Benjamin Smedberg
737515b2c8 Merge mozilla-central into electrolysis. 2009-11-19 12:41:46 -05:00
Jacek Caban
0d5503fb33 Fixed includes on case sensitive systems. (actually, this time) 
Bug 501034 - (Packaged) Unit tests boxes should be able to get a stack trace from browser hangs/timeouts.
r=ted.mielczarek.
 2009-11-19 14:04:44 +01:00
Serge Gautherie
3cdcd65c86 s/CrLf/Lf/g, EOL whitespace removals. 
Bug 501034 - (Packaged) Unit tests boxes should be able to get a stack trace from browser hangs/timeouts; (Dv1).
r=ted.mielczarek.
 2009-11-19 14:01:01 +01:00
Jonathan Griffin
ffd9106373 Bug 519570. Log leaks for child processes in separate files, and handle them in automation.py. r=bsmedberg 2009-11-10 11:16:12 -08:00
Brad Lassey
e496cd2077 bug 515748 - differentiate between wince and winmo (change windows mobile ABI to arm-wince-winmo) r=ted 2009-12-04 14:14:18 -05:00
Ted Mielczarek
f6c0a3e6f9 bug 525370 - figure out windows bustage with hang detection and re-enable it. r=jwalden 
--HG--
extra : rebase_source : 24ea6c09d89f20c21dc7f0b49b6dc62e32cd5934
 2009-10-30 13:00:19 -04:00
Benjamin Smedberg
74932b01fe Bug 519357 - Only load known binary components from the app directory by reading a components.list file, r=vlad 2009-11-05 09:08:49 -05:00
Ted Mielczarek
6732e3ac46 bug 526668 - add option to 'unify' to allow files to match if their sorted contents match. r=bsmedberg 2009-11-05 09:04:49 -05:00
Jesse Ruderman
19da72d7aa automation.py no longer needs to set this SMIL pref, since it is now the default. Bug 532997, r=dholbert 2009-12-04 14:25:31 -08:00
Blake Kaplan
b5c833c8e7 Bug 524690 - Explicitly disable the crashreporter if we have a debugger. r=ted 2009-11-17 03:11:33 -08:00
Jonathan Griffin
7bfd72fed6 Bug 524489. Add the --setpref option to runreftest.py. r=ted 2009-11-11 14:50:35 -08:00
Ted Mielczarek
9dee7ceee5 back out accidental changes (on a CLOSED TREE, no less) 2009-11-11 13:27:09 -05:00
Ted Mielczarek
4d199d793a add some debug output to investigate bug 522729 (on a CLOSED TREE) 2009-11-11 12:32:07 -05:00
David Mandelin
ff172068b2 Bug 515211: remove memory reserve feature from jemalloc, r=jasone 2009-11-02 13:02:37 -08:00
David Mandelin
34cbc0857f Backed out changeset 109b74e8e902 due to tinderbox bustage (was bug 515211) 2009-10-30 11:15:03 -07:00
David Mandelin
a5e5a4367e Bug 515211: remove memory reserve feature from jemalloc, r=jasone 2009-10-30 11:02:38 -07:00
Ted Mielczarek
fc3517d1b5 disable windows hang checking for now, bug 525370 filed to sort it out 2009-10-29 20:25:58 -04:00
Ted Mielczarek
752e9fc299 bustage fix for bug 501034 2009-10-29 19:20:42 -04:00
Ted Mielczarek
943273d508 bug 501034 - add a Win32 helper app to crash a process, and make automation.py use it when the app hangs. r=Waldo 
--HG--
extra : rebase_source : 845326f8cfcd3dfe7ca5b0a98bd0810966cf2809
 2009-10-16 13:34:27 -04:00
Ted Mielczarek
018ffaec34 bug 501034 - add hang detection + breakpad triggering to automation.py. r=Waldo 
--HG--
extra : rebase_source : 088eeeb0c3135d1048dca08f3639642a90b2eab2
 2009-10-13 16:56:24 -04:00
Benjamin Smedberg
87e746210d Bug 524139 - Eval .all.pp instead of including it. This means that in the normal case we avoid any make restarts and the associated I/O that goes with them, which could possibly be slowing Windows builds down considerably r=ted 
--HG--
extra : rebase_source : 9671d212954595ef76b1870957e09ec6bc018e83
 2009-10-23 13:00:19 -04:00
Benjamin Smedberg
3bbf52cdfb Update pymake for additional fixes, including making it work in MozillaBuild 1.4 without manually exporting SHELL, not printing warnings for -include files which don't exist, and parsing errors in browser/locales/Makefile. 2009-10-26 14:08:20 -04:00
Jonathan Griffin
d4cf632233 Bug 523208. Fix string to refer to --setpref instead of --extra-pref. 2009-10-26 09:57:33 -07:00
Phil Ringnalda
4ee2e4bdb1 Bug 523054 - Sweep out some more viewer orts, r=dbaron 2009-10-25 10:03:17 -07:00
Benjamin Smedberg
4dafcde401 Update pymake to pick up the fix for bug 523691 and some other stuff, NPODB. 2009-10-23 11:16:27 -04:00
Ted Mielczarek
6d7a9bbc89 bug 523330 - default symbols path busted for mochitest/reftest. r=bsmedberg 2009-10-21 14:19:51 -04:00
L. David Baron
d60a90ebc7 Set dom.popup_maximum to -1 to work around weirdness with the offline tests and get the tree green again, and because we probably want to do it anyway. CLOSED TREE 2009-10-22 13:49:21 -04:00
Ted Mielczarek
85b235ad3d bug 522829 - add an extra print statement to checkForCrashes to try to figure out what's going wrong 2009-10-20 13:27:02 -04:00
Jonathan Griffin
9d1984bf9a Bug 521457. Add debugger options to runreftest.py and runxpcshelltests.py. r=ted 
--HG--
extra : rebase_source : 420b33b1d44aae7361c25d8bcc15032c303aa80d
 2009-10-19 16:12:09 -07:00
Jonathan Griffin
ba826e31ee Bug 519574. Add --setpref to runtests.py, to add custom prefs to mochitest runs. r=mielczarek 
--HG--
extra : rebase_source : db4f83d61b30b70fe5e3f49b25367f223a1ea5e3
 2009-10-14 10:55:25 -07:00
Ted Mielczarek
331ace7109 bug 515436 - Electrolysis test runs need a special LD_LIBRARY_PATH. fix automation.py and various consumers to not overwrite LD_LIBRARY_PATH. r=bsmedberg 
--HG--
extra : rebase_source : 414a8059faaf7888b53f98712d0b0f6b4863d2ad
 2009-10-08 14:10:47 -04:00
Chris Jones
d215e057fe Merge backout 2009-10-02 18:09:39 -05:00
Chris Jones
08de77b6a4 Backed out changeset 8cbc47eee659 2009-10-02 18:09:08 -05:00
Ted Mielczarek
358f330e27 bug 519194 - No symbols in stack trace on tests of optimized builds (landing without review, consider it a bustage fix) 2009-10-02 14:46:49 -04:00
Chris Jones
3e5fef214c bug 441324: implement infallible ::operator new(), malloc() and friends. make |new Foo()| infallible, but leave |malloc()| fallible for the time being. r=blassey sr=bsmedberg,vlad 2009-10-01 21:50:09 -05:00
Ted Mielczarek
d5ed615fdd bug 518641 followup, don't try to copy files around if the test-package directories don't exist. 
--HG--
extra : rebase_source : baa18363c47218f4020b19c9782155c9aae27992
 2009-10-01 18:07:52 -04:00
Nick Thomas
fcec857885 Bug 518641 followup, delete unified test-package directory (resolves bustage the 2nd time a build slave packages tests) 2009-10-01 17:21:51 +13:00
Ted Mielczarek
670b62afa1 bug 518641 - "make package-tests" doesn't work right on OS X universal builds. r=bsmedberg 
This patch causes us to build archictecture-specific test packages in the
OS X universal build postflight makefile, and unifies them into a universal
test-package (containing the same test files, but universal binaries), and
then special-cases the "package-tests" target to use that pre-generated
test package in the universal build case.

--HG--
extra : rebase_source : 41d1f3fe887a2dbdee3ad560ab46bcb261883690
 2009-09-29 08:31:50 -04:00
Ted Mielczarek
6f1bf78be2 bug 518641 - fix the "unify" script to properly handle Java .class files. r=bsmedberg 
Java .class files and Mach-O fat binaries use the same 4-byte magic
number at the start of the file. 'unify' uses the magic number to detect
Mach-O binaries, so it chokes on Java .class files. This change makes us
use the same heuristic as file(1), which is to check the second 4 bytes
in the file. Java class files put a version number there, and Mach-O
fat binaries put the number of contained architectures there. Conveniently,
Mach defines only 18 architectures, and Java's lowest shipping version
number is 43, so there's no overlap in valid values.

--HG--
extra : rebase_source : 84f5382bca6fa4bde721686f029514a41dfaf6b4
 2009-09-29 08:31:50 -04:00
Brad Lassey
9e1a596830 bug 503710 - PR_FormatTime / strftime() doesn't work on Windows CE shunt r=dougt 2009-09-25 12:52:09 -04:00
Boris Zbarsky
71c43ed5e8 Another fix for bug 485531, working around the bustage from bug 504480. r=ted 2009-09-25 12:47:51 -04:00
Mitchell Field
eb31b31d25 Bug 514665 - fix stupid module name differences on windows. r=ted 2009-09-25 18:41:16 +02:00
Benjamin Smedberg
049331bb27 Build bustage from bug 485409: extra quoting required for PERL now. 2009-09-22 10:13:27 -04:00
Benjamin Smedberg
56a8d84c46 Bug 485409 - Handle a Windows-style path as $srcdir in configure, by modifying the default autoconf M4 macros so that they recognize Z:/ as an absolute path. r=ted 2009-09-22 09:05:48 -04:00
Phil Ringnalda
94cd737ac8 Bug 514211 - Sweep some mouse turds out of build/unix/, r=ted 2009-09-18 19:59:52 -07:00
Serge Gautherie
b361f3d1e5 Bug 469523 - xpcshell-tests: enable leak log in tinderbox (log); (Hv1) Use automationutils.dumpLeakLog(), fix/update automationutils.processLeakLog() log messages 
r=ted.mielczarek
 2009-09-16 17:50:03 +02:00
Josh Aas
f7b71f7247 Use gcc-4.2 and the 10.5 SDK by default in Gecko 1.9.3. Gecko 1.9.3 builds will no longer run on Mac OS X 10.4. b=501436 r=ted 2009-09-15 13:11:24 -04:00
Alex Pakhotin
591a372cf3 Bug 508721 - fixing a bug in argument passing in WinCE build tools, r=blassey 2009-09-10 14:32:32 -07:00
Josh Aas
37c4f0f8a2 Remove build/package/debian. See bug 233323. r=ted 2009-09-10 16:05:41 -04:00
Brad Lassey
752fb7fae5 bug 515415 - [WinCE] Software Update not being applied, path from wgetcwd doesn't always end with a slash r=dougt 2009-09-10 14:45:08 -04:00
Josh Aas
621cf29067 Add executable bits back to config.guess files. b=515002 2009-09-09 08:20:25 -04:00
Josh Aas
099411b764 Sync config.guess to latest version from gnu, include fix for GNU Savannah bug 6827. b=515002 r=ted 2009-09-08 14:55:19 -04:00
Serge Gautherie
750b11805e Bug 469523 - xpcshell-tests: enable leak log in tinderbox (log); (Fv1) Move code to automationutils.py from automation.py.in 
r=ted.mielczarek
 2009-09-06 03:08:49 +02:00
Ted Mielczarek
466d690dc7 Bug 469523 - xpcshell-tests: enable leak log in tinderbox (log); (Gv1a) fix build dependencies of automationutils.py 
r=benjamin
 2009-09-06 03:08:46 +02:00
Benjamin Smedberg
008e309c7f Bug 513032 - remove empty conditionals in our makefiles, r=ted 2009-08-27 10:48:18 -07:00
Brad Lassey
67ebdb3765 bug 506763 - wgetcwd implementation in the WinCE shunt is broken in some circumstances r=dougt 2009-08-28 10:15:24 -04:00
Benjamin Smedberg
cd2c007c60 Additional followup #3 to bug 398573 - remove more REQUIRES by fixing another bug in the script 2009-08-27 09:09:31 -07:00
Benjamin Smedberg
0df64c6bc4 Additional followup to bug 398573 - remove REQUIRES from the tree even when they are in makefile conditional blocks 
--HG--
extra : rebase_source : cc65c34a414e6c67a5651fc9cf0b6bd709ebcdbd
 2009-08-27 08:53:13 -07:00
Serge Gautherie
93b0c2ea9b Backed out changeset: f6bf83b50648 2009-08-26 22:36:55 +02:00
Serge Gautherie
ac322e6f58 Bug 469523 - xpcshell-tests: enable leak log in tinderbox (log); (Fv1) Move code to automationutils.py from automation.py.in 
r=ted.mielczarek
 2009-08-26 18:36:40 +02:00
Benjamin Smedberg
2e9438fd2f Followup to bug 398573 - remove REQUIRES from the tree since it is no longer used... automatically generated patch, rs=ted 2009-08-25 08:59:31 -07:00
Brian Crowder
0f9e2ebea3 fixing an issue w/ global variable in cab builder python script, r=me 2009-08-22 01:02:21 -07:00
Brian Crowder
1e4842ae16 Bug 511936: cab-file building python script should respect MOZ_FASTSTART and add a faststart link to cab installer, r=blassey 2009-08-22 00:13:49 -07:00
Robert Strong
834995a25c Bug 510836 - mozce_shunt.dll loaded with updater.exe. r=blassey, r=vlad 2009-08-20 19:58:47 -07:00
Vladimir Vukicevic
632d2bb1ff b=511568; WinCE shunt not overriding std::nothrow operator new; r=blassey 2009-08-20 18:46:34 -07:00
Karl Tomlinson
04f1f2de08 Bug 477724 avoid pointless shell interpreter hanging around r=bsmedberg 2009-08-21 10:09:54 +12:00
Nick Thomas
a37dce8ff7 Bug 530469, disable parallel make in build/wince/tools, r=ted.mielczarek 2009-08-18 17:23:38 +12:00
Justin Dolske
6c8ffa5616 Bug 509138 - errors reported when building WinCE tools. r=benjamin 2009-08-14 16:22:43 -07:00
Clint Talbert
7de978af0c Bug 482260, Add more comprehensive tests, patch=dougt, r=mfinkle,jmaher,ctalbert 2009-08-14 16:12:09 -07:00
Brad Lassey
c4cb180942 Backed out changeset 08f71a710ae3 due to orange unit tests r=dougt 2009-08-12 19:26:03 -07:00
Doug Turner
5c3eea7d6f Bug 482260. Add more tests cases for geolocation. Also fixes max age not being able to be set to zero. r=mfinkle,jmaher. 2009-08-12 12:17:33 -07:00
Nick Thomas
0a334199c2 Bug 503469, Support packaging WinCE Firefox builds as zip, complete.mar, r=ted.mielczarek 2009-08-11 15:50:32 +12:00
L. David Baron
6c506cbb10 Run output of debug builds through fix-linux-stack/fix-macosx-stack. (Bug 385248) r=ted 2009-08-10 15:52:29 -07:00
Boris Zbarsky
8201eb13da Bug 485531. Make --debugger-gdb work reliably on mac. r=ted 2009-08-06 13:34:49 -04:00
Phil Ringnalda
961c1d7e61 Bug 504239. Remove useless chunk of barely-used script. r=ted 2009-08-04 09:50:18 +12:00
Paul O’Shannessy
7fdd8fa3d2 Bug 506394 - ExpandEnvironmentStringsW in CE shunt isn't quite right, r=vlad 2009-08-01 16:21:58 -07:00
Honza Bambas
b3eafae72d Bug 483440 - PSM doesn't detect invalid OID encodings in Cert Viewer Details tab, r=nelson+johnath 2009-07-29 22:23:27 +02:00
Honza Bambas
58b33ea115 Bug 483437 - PSM doesn't properly escape AVA Values in Cert Viewer Details tab, r=nelson+benjamin 2009-07-29 22:23:27 +02:00
Jim Blandy
337d1489a6 Bug 475654: Allow workaround for NSPR installations with no nspr-config script. a=wes, r=jimb 2009-07-28 13:18:50 -07:00
Ginn Chen
f90d939080 Bug 456719 run-mozilla.sh doesn't work well with ksh93 r=benjamin 2009-07-23 18:09:10 +08:00
Mark Banner
7e8474c02b Bug 503886 Allow non-mozilla central applications to use automation-build.mk. r=bsmedberg 2009-07-17 09:25:41 +01:00
Doug Turner
4786204e9c [Bug 504181 
1] WinCE build tools - optionally force text and rdata to be locked. r=vlad
 2009-07-16 11:32:03 -07:00
Vladimir Vukicevic
35e3f1f00f b=503123; add some additional defines/include paths to WinCE tools; r=dougt 2009-07-08 16:34:01 -07:00
Brad Lassey
0b95a139ae bug 498844 - need _wchdir for updater (in shunt) r=dougt 2009-07-08 11:46:36 -04:00
Robert Kaiser
52826bd829 bug 498500 - Mac DMG unpackaging is unreliable, r=ted 2009-07-06 18:13:57 +02:00
Vladimir Vukicevic
d802f9f6ef b=501180; add flag to disable compress for cabwiz to make_wince_cab; r=blassey 2009-07-01 11:38:00 -07:00
Brad Lassey
0162065e05 bug 50070 - mozconfig2configure can't handle paths with parenthesis r=ted 2009-06-24 16:21:14 -04:00
Chris AtLee
e7936ee1eb Bug 499161 - Set xrePath when creating the environment for the main process. r=ted 2009-06-18 15:13:20 -04:00
Brad Lassey
79067a3630 bug 498394 - wince shunt's unlink has wrong return value r=dougt 2009-06-18 07:34:12 -04:00
Hiroyuki Ikezoe
9ba5a69876 bug 491795 - argpath_conv in toolspath should support Fe option r=blassey 2009-06-18 07:33:01 -04:00
Brad Lassey
8856cad042 bug 491796 - arm-wince-gcc should support link and entry options r=dougt 2009-06-18 07:28:57 -04:00
Dave Townsend
2a16aa282c Bug 497884: Intermittent failure in test_classifier.html and test_classifier_worker.html. r=sdwilsh 2009-06-17 11:47:08 +01:00
Joel Maher
f2847c7f2e Bug 489817 - migrate existing geolocation tests from mochitest to browser-chrome; r=(ctalbert + doug.turner) 2009-06-08 21:50:04 +02:00
Hiroyuki Ikezoe
21d14dbaa8 bug 493648 - build errors due to mozce_shunt.h is in dist/include (caused by bug 488175) r=bsmedberg, blassey 2009-05-19 14:15:51 -04:00
Asaf Romano
599c561678 backing out bogus checkin again 2009-05-18 04:18:37 +03:00
Asaf Romano
4b1e16bc03 bug 490068 - leak window after showing bookmarks panel. r=dietrich. 2009-05-17 23:14:27 +03:00
Josh Aas
7b18a43803 Remove a perl module used to build on classic Mac OS (MacCVS). rs=bsmedberg 2009-05-14 16:41:55 -04:00
Josh Aas
109f956de0 Sync config.guess with latest from gnu "config" package. See bug for changelog. b=492623 r=ted 2009-05-12 23:47:03 -04:00
Ted Mielczarek
eea55d01da bug 483062 - figure out how to get crash stacks from xpcshell tests - another followup bustage fix 2009-05-12 07:57:44 -04:00
Ted Mielczarek
7aa5da833a bug 483062 - figure out how to get crash stacks from xpcshell tests - followup bustage fix for leak tests 2009-05-12 07:28:44 -04:00
Ted Mielczarek
4f4b086565 bug 483062 - figure out how to get crash stacks from xpcshell tests. r=bsmedberg 
--HG--
extra : rebase_source : 70355805b7f71c016eaa7aaea1d1916a23316b8a
 2009-05-11 15:54:39 -04:00
Olli Pettay
1f7cf9b660 Bug 486502 - Dispatch test events only when running mochitest/chrome/browser-chrome, r+sr=roc 2009-05-06 07:30:39 +03:00
tn
01c2b0f2ae Bug 490951 - Fix timeout for scripts when running mochitests; r=ted.mielczarek 2009-05-06 01:11:19 +02:00
Vladimir Vukicevic
58748cabbd Move jemalloc.obj inside MOZ_MEMORY for WinCE shunt; r=wince 2009-04-28 11:07:05 -07:00
Vladimir Vukicevic
4cfd3d019a b=490037; export localtime_r/gmtime_r from CE shunt; r=dougt 2009-04-24 12:55:12 -07:00
Vladimir Vukicevic
9be2078d7e b=488608; enable jemalloc on CE6; r+sr=stuart 2009-04-24 10:31:18 -07:00
Vladimir Vukicevic
03f71abbf7 adding missing file 2009-04-24 11:40:20 -07:00
Vladimir Vukicevic
801b1f9b61 Backed out changeset 1eec75c27e2f 2009-04-24 10:43:19 -07:00
Vladimir Vukicevic
aa56e5c711 b=488608; enable jemalloc on CE6; r+sr=stuart 2009-04-24 10:31:18 -07:00
Vladimir Vukicevic
99583ecc93 b=89487; clean up mozce_shunt, add def file; r=dougt 2009-04-24 10:30:30 -07:00
Hiroyuki Ikezoe
e7a154472f Bug 488804 - Cleanup in build/wince/shunt/map.cpp. r=blassey 2009-04-21 09:50:23 +02:00
Serge Gautherie
5c536971f8 Bug 482598 - Requesting a tinderbox for Mac with --enable-accessibility; (Bv1) Force a leak threshold for test suite; r=jwalden+bmo 2009-04-21 00:26:03 +02:00
Ben Hearsum
a69495324f bug 486992: post_upload.py errors aren't caught - use sys.exit(non-zero) when exceptions are caught in upload.py. r=ted 2009-04-20 12:42:58 -04:00
Ginn Chen
1e9057e2f1 Bug 487602 Failed to compile firefox on Solaris r=bsmedberg 2009-04-20 15:22:06 +08:00
Ginn Chen
0f7ef1fa64 Back out bug 487602 2009-04-14 17:04:43 +08:00
Ginn Chen
a9f1c99903 Bug 487602 failed to compile firefox on Solaris r=bsmedberg 2009-04-14 16:42:50 +08:00
Hiroyuki Ikezoe
983ce3f149 bug 485280 - Need more buffer size of arm-wince tools r=blassey 2009-04-13 22:49:06 -04:00
Serge Gautherie
a789e5828a Bug 484231 - A Mochitest crashdump turns the waterfall orange but misses to |TinderboxPrint|; (Bv1) runtests.py.in: return |status| instead of |0|, and 3 (unrelated) nits; r=jwalden+bmo 2009-04-10 12:30:32 +02:00
Honza Bambas
137cc26e8a Bug 480713 - nsDocLoader doesn't clear requests from mRequestInfoHash, security UI may not report mixed content, r,sr=jst 2009-04-08 10:45:32 +02:00
John Wolfe
e456c19b02 Bug 476733 - WinCE Dynamic CAB INF File Production Needed - r+ted 2009-04-07 23:44:03 -04:00
Serge Gautherie
e279585251 Bug 469518 - Enable Reftest leak log in tinderbox (log); (Ev1) Parse the log and support a leak threshold; r=jwalden+bmo 2009-04-05 15:03:46 +02:00
Makoto Kato
b68fa392fb Bug 485264 followup - quote things to death, r=bsmedberg 2009-04-03 13:48:08 -04:00
Benjamin Smedberg
0ba8d594a1 Update pymake 2009-04-02 12:26:17 -04:00
Robert O'Callahan
64b6352d5f Bug 475441. Make the media cache size really small while we're running mochitests, to give the cache code a thorough workout. r=doublec 2009-04-01 13:52:56 +13:00
Benjamin Smedberg
e9a284b15d Update pymake for better memory usage and faster execution. 2009-04-01 16:13:55 -04:00
Robert O'Callahan
cb7e64f24f Backed out changeset c166dc4af167 2009-04-01 16:18:14 +13:00
Robert O'Callahan
7df6bc888e Bug 475441. Make the media cache size really small while we're running mochitests, to give the cache code a thorough workout. r=doublec 
--HG--
extra : rebase_source : c8ab78a79557ecf02ca4f11d3d8d83fb3685f1f1
 2009-04-01 13:52:56 +13:00
Benjamin Smedberg
21a20179b4 Update pymake with --keep-going and other fixes 2009-03-31 17:10:23 -04:00
Brad Lassey
abc0d86d49 bug 465996 - M_SQRT_1_2 missing from windows ce headers r=dougt 2009-03-31 12:27:25 -04:00
Brad Lassey
183b8bf73f bug 485227 - Don't force link jemalloc on windows ce r=ted, crowder 2009-03-31 12:27:25 -04:00
Benjamin Smedberg
4374e7b7a1 Followup to bug 474703 for pymake: use core_abspath to get Windows-style absolute paths correct, r=ted 2009-03-31 12:04:53 -04:00
Benjamin Smedberg
b7dbb7cee0 Bug 485264 - Not enough quotes in mozprog.m4 when suggestions contain spaces r=ted 2009-03-31 08:41:50 -04:00
Walter Meinl
b2a122ec44 Bug 484287 - [OS/2] simplify test_os2.cmd; r=mozilla@Weilbacher.org 2009-03-27 00:45:15 +01:00
Benjamin Smedberg
241c1b5040 Update pymake to tip of my repo, NPODB. 2009-03-26 16:24:51 -04:00
Brad Lassey
0994d0ae06 bug 481579 - changes to shunt and tools for jemalloc on windows ce r=dougt 2009-03-23 21:16:03 -04:00
Brad Lassey
2650b63bae bug 476201 - follow up, missed some of the changes in the first push, r=ted 2009-03-21 15:20:49 -04:00
Brad Lassey
13c9b1c088 bug 476201 - devenv builds shunt lib in source dir, remove visual studio projects r=ted 2009-03-21 14:59:51 -04:00
Benjamin Smedberg
5e6515d97a Import pymake into Mozilla. This is not used by default (yet), but this snapshot should be good enough for doing relative-srcdir builds on Windows. r=ted 2009-03-19 10:19:38 -04:00
Serge Gautherie
a71bcbb5a6 Bug 482236 - runtests.py.in : wrong leak detection on this case; (Av1a) Support a negative 'Total' value; r=(dbaron + jwalden+bmo) 2009-03-17 15:22:59 +01:00
Serge Gautherie
a92965be5e Bug 469518 - Enable Reftest leak log in tinderbox (log); (Dv1) Early return in processLeakLog(); r=jwalden+bmo 2009-03-17 15:22:57 +01:00
Ginn Chen
1233d3dcd9 Bug 480967 Don't leak MSYS paths into makefiles, fix Solaris bustage r=bsmedberg 2009-03-11 16:51:47 +08:00
Dave Camp
45cf011897 Bug 482073 - test_classifier.html issues leading to intermittent failures. r=waldo 2009-03-10 14:57:59 -07:00
Daniel Holbert
7ae02c63e7 Bug 473705 auxiliary patch: Enable SMIL pref during mochitests. r+sr=roc 2009-03-10 13:35:25 -07:00
Benjamin Smedberg
3305b96ed7 Bug 481732 - Check for crash minidumps in unit tests and dump them, if the MINIDUMP_STACKWALK path is set in the environment, r=ted 2009-03-10 13:36:14 -04:00
Serge Gautherie
e693d3246b Bug 469518 - Enable Reftest leak log in tinderbox (log); (Cv1) "Fix" processLeakLog() arguments; r=jwalden+bmo 2009-03-10 15:10:25 +01:00
Serge Gautherie
d0a01b63f4 Bug 469518 - Enable Reftest leak log in tinderbox (log); (Bv1b) Move leak log parsing code to automation.py.in from runtests.py.in; r=jwalden+bmo 2009-03-09 21:00:55 +01:00
Benjamin Smedberg
c4cc33cfae Bug 40967 - Avoid leaking MSYS paths in Makefiles: use c:/dir/path paths whenever possible, r=ted 2009-03-09 10:55:41 -04:00
Ben Turner
7b2f1bd35e Bug 480279 - 'Allow mochitests to launch under a debugger or valgrind'. r=waldo. 2009-03-06 15:28:20 -08:00
Serge Gautherie
5dd75974c9 Bug 480077 - automation.py.in : additional fix to bug 472706 for |runApp()| return value(s); (Bv1a) Replace external times by internal duration ++; r=jwalden+bmo 2009-03-05 19:01:39 +01:00
Asaf Romano
6d0f9d36c6 I have no idea how did that happen. backing out this part. 2009-02-26 16:18:23 -08:00
Asaf Romano
fe4d91cd12 Bug 480149 - DOMLinkAdded and DOMLinkRemoved events for link elements should be dispatched when swapping docshells. r+sr=bz. 2009-02-26 14:05:42 -08:00
Jonas Sicking
fea9eede61 Bug 479521: Don't follow unsafe same-site to cross-site redirects. Also fix a bug where reusing a XHR object that had been used cross site could result in the second request being more restrictive than it should be. r/sr=jst 2009-02-24 11:46:51 -08:00
Jonas Sicking
b2248a4405 Backed out changeset 4130ff1e52f3 (bug 479521) due to test failures. 2009-02-24 15:38:40 -08:00
Jonas Sicking
ca2acd2b73 Bug 479521: Don't follow unsafe same-site to cross-site redirects. Also fix a bug where reusing a XHR object that had been used cross site could result in the second request being more restrictive than it should be. r/sr=jst 2009-02-24 11:46:51 -08:00
Dave Camp
0a853feebb Bug 474703 - mochitest broken when TOPSRCDIR is relative. r=ted 2009-02-22 11:09:09 -08:00