Commit Graph

13684 Commits

Author SHA1 Message Date
Bobby Holley
2589449122 Bug 834732 - Audit callers of GetNativeContext and use AutoPushJSContext where appropriate. r=mrbkap 2013-02-26 11:04:13 -08:00
Bobby Holley
210cff1d9f Bug 834732 - Introduce AutoPushJSContext. r=mrbkap
It's annoying to add yet another RAII class, but we're solving a different
problem here. In particular, there are lots of callers that grab a cx off
of an nsIScriptContext and use it without pushing. Most of the time this
is ok, since that cx is also the active cx. But it's hard to tell when we
might potentially violate that invariant. What's more, we don't want to just
use an nsCxPusher, because that does expensive things even when the cx matches
the one on the top of the stack. Most of these consumers should just switch
to AutoJSContext, but doing such a change en masse is a pretty risky thing to
do. So let's introduce a class that gives us good performance in the common case
and correctness in the uncommon case.
2013-02-26 11:04:12 -08:00
Bobby Holley
5b3fac708a Bug 834732 - Push a cx in AdoptNode. r=mrbkap 2013-02-26 11:04:12 -08:00
Bobby Holley
e83e186c1b Bug 834732 - Make nsCxPusher.Push(JSContext*) infallible. r=mrbkap
We leave the nsIDOMEventTarget* versions fallible for now, but this makes the
common case a lot simpler. Note that this means that pushing a null JSContext,
a bug, is no longer handled at runtime. But I think we should just assert
against it, since there are already callers that don't check the return value.
2013-02-26 11:04:11 -08:00
Bobby Holley
784a476fb8 Bug 834732 - Remove PushBehavior. r=mrbkap
Now that we only have ALWAYS_PUSH and ASSERT_SCRIPT_CONTEXT, we have uniform
release-mode behavior everywhere. Remove the crap.
2013-02-26 11:04:11 -08:00
Bobby Holley
99fefbe87b Bug 834732 - Move cx pushing into nsPluginProtoChainInstallRunner. r=mrbkap
This gets rid of the last use of REQUIRE_SCRIPT_CONTEXT. \o/
2013-02-26 11:04:10 -08:00
Bobby Holley
90a1dbb7be Bug 834732 - Make SafeAutoJSContext actually push something. r=mrbkap
Currently it never does, because the SafeJSContext doesn't have an
nsIScriptContext behind it. :-(
2013-02-26 11:04:10 -08:00
Bobby Holley
e04f8d807d Bug 834732 - Get rid of footgun bool param for nsCxPusher and use an explicit enum. r=mrbkap
The goal here is to get rid of this crap entirely, and make nsCxPusher always
push. But that's a scary change, so we do it in chunks. This patch, in particular,
should have zero behavioral change. This means preserving some very wrong behavior.
For instance, currently SafeAutoJSContext never pushes a damn thing, because the
safe JSContext doesn't have an associated nsIScriptContext. We preserve this
behavior, and in fact convert various similarly-buggy consumers to
SafeAutoJSContext, so that we can hoist the behavioral change into a subsequent
patch.
2013-02-26 11:04:09 -08:00
Andrea Marchesini
25838567db Bug 842986 - Implement MozFrameLoaderOwner on HTMLFrameElement. r=bz 2013-02-26 12:02:32 -05:00
Robert Longson
85dc58ac04 Bug 785606 - Support viewBox=none from SVG 1.2 Tiny r=jwatt 2013-02-26 16:58:06 +00:00
Jacek Caban
b59eb40039 Bug 844905 - Change MediaResource::GetContentType return type to nsCString. r=cpearce 2013-02-26 12:02:20 +01:00
Paul Adenot
e3f9f4377e Bug 844951 - Setting playbackRate and mozPreservesPitch before the decoder creation should work. r=kinetik 2013-02-26 09:52:23 +01:00
Paul Adenot
4f2efc2090 Bug 844563 - Crash [@ mozilla::MediaDecoder::SetPreservesPitch], add tests. r=kinetik 2013-02-26 09:52:11 +01:00
Paul Adenot
a123bbbf99 Bug 844563 - Crash [@ mozilla::MediaDecoder::SetPreservesPitch]. r=kinetik 2013-02-26 09:51:59 +01:00
Chris Pearce
6a6b754413 Bug 805613 - Don't remove fullscreen approved observer on documents which don't add it, prevents assertion failure spam. r=bz 2013-02-26 18:40:53 +13:00
Chris Pearce
b8e8ab3f2f Bug 805613 - Support multiple concurrent fullscreen documents. r=bz 2013-02-26 18:40:53 +13:00
Ehsan Akhgari
a3ea24d66e Bug 844169 - Part 2: Rename nsIDOMHTMLIFrameElement.allowfullscreen to allowFullscreen in order to comply with the spec; r=cpearce 2013-02-25 20:59:33 -05:00
L. David Baron
4f4296979b Bug 404077: Annotate known assertions in mochitests. 2013-02-25 18:39:21 -08:00
Ehsan Akhgari
621cb2d14d Bug 844169 - Part 1: Rename nsHTMLIFrameElement to mozilla::dom::HTMLIFrameElement; r=bzbarsky
--HG--
rename : content/html/content/src/nsHTMLIFrameElement.cpp => content/html/content/src/HTMLIFrameElement.cpp
rename : content/html/content/src/nsHTMLIFrameElement.h => content/html/content/src/HTMLIFrameElement.h
extra : rebase_source : 67c393954a0c46f80b8729277504e9ced5c64d33
2013-02-22 19:59:26 -05:00
Bobby Holley
076b7bfcfa Bug 843711 - Fix up new |Components| culprits in test suite. r=mccr8 2013-02-25 10:43:03 -08:00
Ryan VanderMeulen
a496eb61f0 Backed out changesets 77a94dc888c9 and 3f6e6912e71a (bug 831144) for Android mochitest failures on a CLOSED TREE. 2013-02-25 12:35:33 -05:00
Jim Chen
56e587e829 Bug 831144 - Add Android XBL key bindings; r=neil
--HG--
rename : content/xbl/builtin/unix/Makefile.in => content/xbl/builtin/android/Makefile.in
rename : content/xbl/builtin/unix/jar.mn => content/xbl/builtin/android/jar.mn
2013-02-25 11:33:29 -05:00
Jonathan Kew
3c10c07d3e bug 844454 - don't try to get a Unicode decoder for an empty charset name. r=hsivonen 2013-02-25 15:56:19 +00:00
Henri Sivonen
0b10e7dbee Bug 844792 - Warn about the upcoming removal of multipart support in XHR. r=smaug. 2013-02-25 17:12:13 +02:00
Timothy Nikkel
1528be2bd9 Bug 689623. Part 12. Assume images in popups are visible. r=mats 2013-02-24 18:59:23 -06:00
Timothy Nikkel
c6b1e4c2dc Bug 689623. Part 9. Make images default to visible when they have a frame created for them. r=mats 2013-02-24 18:59:23 -06:00
Timothy Nikkel
9eabef3617 Bug 689623. Part 8. Add an 'unlocked draw' notification for images that are drawn when not locked so we catch any images that become visible through a means other than scrolling. r=joe,mats 2013-02-24 18:59:22 -06:00
Timothy Nikkel
9141b5c507 Bug 689623. Part 4. Add a visible count to nsIImadeLoadingContent, and use it when locking the image. r=joe 2013-02-24 18:59:21 -06:00
Timothy Nikkel
32f180e11f Bug 689623. Part 3. In nsImageLoadingContent add a flag to TrackImage that skips the check if we have a frame so that we can use TrackImage everywhere (including FrameCreated) instead of AddImage. r=joe 2013-02-24 18:59:21 -06:00
Timothy Nikkel
9fec1adf6b Bug 689623. Part 2. In nsImageLoadingContent make the discard request an optional part of UntrackImage so that we can use UntrackImage everywhere instead of RemoveImage. r=joe 2013-02-24 18:59:21 -06:00
Peter Van der Beken
60efffbed9 Fix for bug 844225 (Remove some DOMCI and quickstubs). r=bz. 2013-01-10 10:54:46 +01:00
Peter Van der Beken
7af1e79973 Fix for bug 844136 (Really convert HTMLLegendElement to WebIDL). r=bz.
--HG--
extra : rebase_source : df3560b808dba2603768b160c9c21ff242726898
2013-02-22 17:12:58 +01:00
Jonathan Kew
fbc635408f bug 808288 - part 2 - render the font's .notdef glyph for missing glyphs in <canvas>. r=bas 2012-11-03 16:17:17 +00:00
Ehsan Akhgari
dbd98a978d Bug 836072 - Validate the arguments to AudioParam.exponentialRampToValueAtTime() correctly; r=roc
--HG--
extra : rebase_source : 4da10bc054e2d978b3639a537bd46b2614586647
2013-01-29 18:30:22 -05:00
Ms2ger
696d7f50c0 Bug 844439 - Disable webgl-color-test.html reftests on B2G for R6 oranges on a CLOSED TREE. 2013-02-23 14:20:37 +01:00
David Humphrey (:humph)
88eee16b7a Bug 629801 Implement HTML5 <time> element. r=smaug, peterv, hsivonen 2013-02-22 10:07:42 -05:00
Boris Zbarsky
29043e89b0 Bug 842561. Assert that our inheritance chain is correct for WebIDL objects. r=peterv
We could drop the descriptor for Text if we changed nsIDocument::CreateTextNode
to return an already_AddRefed<Text>, but then we'd need more casting in
nsDocument.cpp for the XPCOM CreateTextNode.  Not sure which way is better,
really.
2013-02-22 09:56:29 -05:00
Boris Zbarsky
4f88923cd8 Bug 842726. Kill off GetterShim and the classinfo support for chrome-only stuff on Document now that we can do that via WebIDL. r=peterv 2013-02-22 09:56:29 -05:00
Masatoshi Kimura
eff9403238 Bug 843489 - Drop support for .createEvent("progressevent"). r=smaug 2013-02-23 14:49:59 +09:00
Masatoshi Kimura
58be2f3664 Bug 842372 - Part 2: Hide getUserData and setUserData from content. r=bz 2013-02-23 13:46:06 +09:00
Masatoshi Kimura
8eff8e0afb Bug 842372 - Part 1: Implement nsINode::ShouldExposeUserData. r=bholley 2013-02-23 13:46:05 +09:00
Phil Ringnalda
f8406b2842 Back out 5520e123f526 (bug 763879) for b2g mochitest-8 and mochitest-9 failures 2013-02-22 20:40:24 -08:00
Sid Stamm
4820de61f9 Bug 763879 - implement inline stylesheet blocking for CSP (r=dbaron) 2012-08-30 10:58:24 -07:00
Masatoshi Kimura
9a22966985 Bug 843489 - Make initProgressEvent() [noscript]. r=smaug 2013-02-23 09:14:35 +09:00
Ehsan Akhgari
08ba6f9b51 Bug 838582 - Part 2: Move HTMLTextAreaElement to Web IDL bindings; r=bzbarsky 2013-02-19 00:54:23 -05:00
Ryan VanderMeulen
486f369f1f Backed out 6 changesets (bug 832920, bug 825341, bug 838582, bug 842726, bug 629801, bug 842561) for Linux32 debug mochitest-2 and Windows/OSX mochitest-browser-chrome failures on a CLOSED TREE. 2013-02-22 15:30:06 -05:00
Ehsan Akhgari
b855a12fa5 Bug 838582 - Part 2: Move HTMLTextAreaElement to Web IDL bindings; r=bzbarsky
--HG--
extra : rebase_source : f8933c4973220dc8845b9ce2f63e91b366167117
2013-02-19 00:54:23 -05:00
Jonathan Mayer
4bd2d83991 Bug 818340 - change third party cookie handling to block third party cookies from sites I haven't visited. (r=jdm, r=dolske)
--HG--
extra : rebase_source : f486f39feac1fb743edc920618bec29884d515f1
2013-02-22 08:16:01 -08:00
Ryan VanderMeulen
6c7d5c0ade Backed out changeset 78c3801aed19 (bug 825329) for intermittent orange. 2013-02-22 11:45:32 -05:00
Bobby Holley
5da3947b0e Bug 843231 - Alter the XBL scope test to make it compatible with reading the dom.xbl_scopes only once per global. r=bz
--HG--
rename : content/xbl/test/test_bug821850.xhtml => content/xbl/test/file_bug821850.xhtml
2013-02-22 07:56:03 -08:00