Commit Graph

26 Commits

Author SHA1 Message Date
Rick Eyre
57a293b49e Bug 865407 - Part 4: Expose TextTrackCue::DisplayState to chrome JS. r=rillian, r=bz 2013-12-12 11:27:30 -05:00
Rick Eyre
af35c2dfc6 Bug 949643 - Implement VTTCue::PositionAlign. r=rillian 2013-12-13 12:57:48 -05:00
Rick Eyre
86640b66f3 Bug 950830 - Clean up TextTrackCue style and TODO comments. r=rillian 2013-12-16 14:49:22 -05:00
Rick Eyre
c4a5a3c5a6 Bug 949642 - Implement VTTCue::LineAlign. r=rillian 2013-12-13 09:29:15 -05:00
Wes Kocher
19e7b8c082 Backed out changeset df0855f26e4d (bug 949642) for introducing a new intermittent failure 2013-12-20 18:33:55 -08:00
Wes Kocher
58a13fe0cb Backed out changeset 6532bf066bb4 (bug 882299) 2013-12-20 18:33:04 -08:00
Wes Kocher
9c61949d24 Backed out changeset 00aa14a1f461 (bug 950830) 2013-12-20 18:32:20 -08:00
Rick Eyre
5655b03c49 Bug 950830 - Clean up TextTrackCue style and TODO comments. r=rillian 2013-12-16 14:49:22 -05:00
Rick Eyre
68a00515c1 Bug 882299 - Implement VTTCue::Line. r=smaug, r=rillian 2013-12-16 14:35:01 -05:00
Rick Eyre
4fdaf8fb73 Bug 949642 - Implement VTTCue::LineAlign. r=rillian 2013-12-13 09:29:15 -05:00
Rick Eyre
2837cf469c Bug 950049 - Rename VTTCue::TextTrackCueAlign to AlignSetting. r=rillian 2013-12-13 09:44:50 -05:00
Ehsan Akhgari
65f992afec Bug 922933 - Don't #include nsIDocument.h in nsIContent.h; r=jst
--HG--
extra : rebase_source : 51f56fa27604224eacc2ba384bb826c49f4f917f
2013-10-02 07:40:07 -04:00
Rick Eyre
d6b2116792 Bug 917945 - Part 2: Add RegionId attribute to VTTCue. r=rillian 2013-09-18 13:29:20 -04:00
Rick Eyre
aa35aad13b Bug 895091 - Part 2: Add WebVTT parser and wrapper IDls r=rillian, ted, gwagner, khuey
- Added vtt.js, a JS WebVTT parser, to Gecko.
- Added a wrapper to interface between it and Gecko.
- Updated TextTrackCue and WebVTTListener to work with it.

--HG--
rename : content/media/WebVTTLoadListener.cpp => content/media/WebVTTListener.cpp
rename : content/media/WebVTTLoadListener.h => content/media/WebVTTListener.h
2013-09-19 08:26:00 -07:00
Rick Eyre
d59dfb9494 Bug 895091 - Part 1: Remove references to C WebVTT parser and unused code r=rillian
- Remove left over references to WebVTT C parser in TextTrackCue and
WebVTTListener classes.
- Remove miscellaneous unused code as well and included libraries as
well.
2013-09-10 06:53:00 -07:00
Marcus Saad
90fe20b7ad Bug 903425 - Update TextTrackCue::Vertical to be a DirectionSetting enum. r=rillian
Following up with the changes made in http://dev.w3.org/html5/webvtt/#dfn-dom-vttcue-vertical, this patch comes to create a new enum to validate and control the possible values for TextTrackCue::Vertical. Throwing behavior was removed for spec conformance.
2013-09-12 11:07:14 -03:00
Rick Eyre
d91df96fac Bug 868509 - Rename TextTrackCue to VTTCue r=rillian
This way we can ensure that JS code written for WebVTT is spec
compliant while at the same time not having to abstract VTTCue
from TextTrackCue.

--HG--
rename : dom/webidl/TextTrackCue.webidl => dom/webidl/VTTCue.webidl
2013-08-27 13:07:00 -07:00
Kyle Huey
bf31d78a83 Bug 903772: Part 3 - Refactor GlobalObject. r=peterv 2013-08-22 22:17:08 -07:00
Rick Eyre
7b90a3a973 Bug 905320 - Fix TextTrack classes to utilize cycle collection correctly. r=khuey
We were incorrectly using the wrapper cache cycle collection macros when that
functionality was already implemented by the base classes. Therefore, we
should instead use the inherited version of the cycle collection macros.
2013-08-15 11:11:15 -04:00
Marcus Saad
664e93ad34 Bug 882743 - Make TextTrackCue setters throw. r=rillian, r=bz
From 8f5dccf7fd5f5d2a74341ead60586346e4ab3ead Mon Sep 17 00:00:00 2001
Now throwing javascript exceptions from attribute setters for TextTrack-related DOM classes.
As can be seen in http://dev.w3.org/html5/webvtt/#webvtt-api, some of the attributes require validation and throwing.
There is no validation implemented to the align property because there is a bug opened against the spec to change it to an Enum.
When cleared, it should have the IDL changed to remove the throwing.
Validation comments were removed from the properties that didn't have proper validation defined by the spec.
2013-07-24 14:18:54 -04:00
Ralph Giles
05565a4994 Bug 894104 - Part 3: remove TextTrackCue's mGlobal. r=bz
From 095c76c72dd5915b2fa8ec74f4e2b0b45de244f1 Mon Sep 17 00:00:00 2001
Since we keep a document reference we no longer need the
separate global. It was only used in GetParentObject() and
we can return nullptr there (meaning 'use whatever magic global')
or return the document instead, which is what this patch does.
2013-07-18 15:01:48 -07:00
Ralph Giles
ac4de9f961 Bug 894104 - Part 1: Retain a document reference for GetCueAsHTML.
From 447985000db919e2f054012ca10f03d626c401b1 Mon Sep 17 00:00:00 2001
 r=bz
Save a copy of the owning document at creation time instead
of looking it up from mGlobal in each call. This ensures it
is available even if we're called after our window is unlinked
at teardown.

Make the constructors throw if a window is not available,
so we can return an INVALID_STATE_ERR if we're called
in an incomplete environment.
2013-07-16 22:14:40 -07:00
Ralph Giles
2ec3570c84 Bug 887463 - remove webvtt parser library. r=cpearce. 2013-07-09 17:02:00 -07:00
Rick Eyre
41e11bfdcb Bug 882714 - Implement TextTrackCue::DisplayState r=rillian
- Renamed mCueDiv to mDisplayState to match spec.
- Introduced mReset which is set whenever TextTrackCue changes in
a way that will mean we have to rebuild the computed cuetext of the
TextTrackCue.
2013-07-04 23:24:43 +02:00
Rick Eyre
3800bbb044 Bug 833382 - Implement WebVTTLoadListener r=cpearce,bz
- Implemented WebVTTLoadListener to manage the webvtt parser.
- TextTrackCue now handles the conversion of webvtt nodes to
  anonymous content which will be displayed on the video div
  overlay.
- HTMLTrackElement manages the lifetime of the WebVTTLoadListener.
2013-06-10 08:30:00 -07:00
Ralph Giles
3d52d52549 Bug 833385 - Implement HTMLTrackElement and TextTrack. r=bz,Ms2ger
Add webidl interfaces and implementations of the HTML <track>
element and related TextTrack, TextTrackList, TextTrackCue,
and TextTrackCueList dom objects.

Visibility is controlled by the media.webvtt.enabled pref,
which defaults to false.

HTMLMediaElement:NewURIFromString() is hoisted to
nsGenericHTMLElement so it's available to the track
element as well.

This patch is primarily work by Dale Karp, David Humphrey
and others as Seneca College.
2013-05-22 00:14:00 +08:00