Commit Graph

2918 Commits

Author SHA1 Message Date
L. David Baron
b109fbe639 Bug 404077: Adjust annotations of expected assertions. 2013-02-27 14:55:16 -08:00
Peter Van der Beken
60efffbed9 Fix for bug 844225 (Remove some DOMCI and quickstubs). r=bz. 2013-01-10 10:54:46 +01:00
L. David Baron
05d5d9dfa9 Bug 404077: Use navigator.platform.startsWith rather than navigator.platform.indexOf, at Jesse's suggestion. 2013-02-26 22:23:08 -08:00
Jonathan Watt
40d69457ad Bug 842163 - Show a focus ring around <input type=range>. r=mounir. 2013-02-26 21:26:41 +00:00
Kyle Huey
c28e572034 Bug 816498: Fix some things about background attribute handling that are still broken. r=bz
As filed the bug is about table backgrounds failing to print.  The root cause of this is that we load images from the original document, because print/print-preview documents (which are static clones of the original) cannot do loads.  This results in an entry in the css::ImageValue's request table under the original document, but entry under the printing document.  Then we do layout, try to get the request, and fail, and nothing is displayed.  The solution to this is to force us to clone the request for the printing document if we're loading off the original document.  I manually verified that this does not regress Bug 560235.

While writing a test for this, we discovered another problem.  The reftest print code does not actually use the printing codepath.  Instead it takes an existing document, tears down its presshell, and creates a new presshell for printing.  Fixing the above bug did not make the reftest print test pass because ImageLoader does not deal properly with presshell destruction/recreation.  It assumes that when the presshell is destroyed all of the css::ImageValues can be cleared of their entries for that document.  This fails for ImageValues for mapped attributes because they are held alive by the content tree.  When a new presshell for this document is then created there is no entry for the document and thus no image request to paint.  The fix for this is to only clear the frame to request and request to frame mapping hashtables and not to clear the document's entry on the ImageValue when the presshell is destroyed.  The destruction of the ImageLoader (which is held from a strong reference on the document) is when those entries are removed.  The final change is to change css::ImageValue's hashtable from holding a strong reference to the keys (which are documents) to holding raw pointer references.  This is safe because we clear the relevant entry when the corresponding ImageLoader dies, and is needed to prevent a reference cycle that was being broken by presshell destruction.

--HG--
rename : layout/reftests/backgrounds/table-background-ref.html => layout/reftests/backgrounds/table-background-print-ref.html
rename : layout/reftests/backgrounds/table-background.html => layout/reftests/backgrounds/table-background-print.html
2013-02-23 06:59:43 -08:00
Mats Palmgren
fc31aa02d6 Bug 843322 - Make CSS 'text-overflow' apply to ::-moz-placeholder. r=roc 2013-02-23 11:38:15 +01:00
Phil Ringnalda
f8406b2842 Back out 5520e123f526 (bug 763879) for b2g mochitest-8 and mochitest-9 failures 2013-02-22 20:40:24 -08:00
Nicholas Cameron
c6411d69df Bug 845188; initialise CommonAnimationData::mGenerationCount; r=roc 2013-02-26 19:21:26 +13:00
L. David Baron
4f4296979b Bug 404077: Annotate known assertions in mochitests. 2013-02-25 18:39:21 -08:00
Sid Stamm
4820de61f9 Bug 763879 - implement inline stylesheet blocking for CSP (r=dbaron) 2012-08-30 10:58:24 -07:00
Daniel Holbert
4987835a8d Bug 812822 part 3: Add a TreeMatchContext flag to indicate that we should skip flex item style fixup, and use it when framing anonymous content in ConstructFrame(). r=bz 2013-02-20 23:35:03 -08:00
Daniel Holbert
dc9d1895ce Bug 812822 part 2: Skip flex-item style fixup when resolving style for pseudo-elements. r=bz 2013-02-20 23:35:02 -08:00
Daniel Holbert
938d346252 Bug 812822 part 1: Add flag 'eSkipFlexItemStyleFixup' to let our nsStyleContext creation functions skip the flex-item-specific chunk of ApplyStyleFixups(). r=bz 2013-02-20 23:34:58 -08:00
Cameron McCormack
801773f4d6 Bug 842772 - Followup to address review comments. 2013-02-20 11:58:25 +11:00
Cameron McCormack
f8e992d7af Bug 842772 - Don't test for mask-type when the pref is disabled. r=dbaron 2013-02-20 11:24:42 +11:00
Cameron McCormack
58fda9ceeb Bug 842829 - Fix test_condition_text.html to parse the style sheet after the pref is set. r=dbaron 2013-02-20 11:25:10 +11:00
Matt Woodrow
2d2e695b90 Bug 840480 r=roc 2013-02-20 13:13:01 +13:00
L. David Baron
bd530b05fd Bug 563195: Add -Wshadow to CFLAGS/CXXFLAGS for layout/style. r=ted
Since this directory has FAIL_ON_WARNINGS set, this will cause any
shadowing warnings triggered by headers included in layout/style to
cause errors.

Once this patch is reviewed, I'll write and attach patches to fix the
warnings needed to land this.
2013-02-17 22:56:32 -08:00
L. David Baron
c429083306 Bug 563195: Fix -Wshadow warnings in layout/style. r=bzbarsky 2013-02-17 22:56:32 -08:00
Zack Weinberg
def7baa066 Bug 842134: fix serialization of unquoted url() in CSS. r=heycam 2013-02-17 22:03:55 -05:00
L. David Baron
2dc2fa21d4 Bug 841983: Require whitespace around 'not', 'and', and 'or' keywords in @supports rules. r=heycam
Matches spec change in https://dvcs.w3.org/hg/csswg/rev/34b185ae3bac .
2013-02-16 21:29:38 -08:00
Zack Weinberg
b78db0f4d6 Bug 543151, part A4: unify the inner text-scanning loops used by GatherIdent, ScanString, NextURL. r=heycam 2013-02-16 18:27:53 -05:00
Zack Weinberg
0fbb550fc0 Bug 543151, part A3: convert the scanner to use peek/advance. r=heycam 2013-02-16 18:27:53 -05:00
Zack Weinberg
57e2a60ca6 Bug 543151, part A2: Introduce the new peek/advance API and reimplement the old read/pushback API on top of it. r=heycam 2013-02-16 18:27:53 -05:00
Zack Weinberg
575de8ae8c Bug 543151, part A1: Preliminary cleanups to the scanner/parser interface and the organization of nsCSSScanner.cpp. r=heycam 2013-02-16 18:27:53 -05:00
L. David Baron
f75e32c2f2 Bug 781360 patch 4: Remove the Get from nsStyleContext::GetStyleData and nsIFrame::GetStyleDataExternal, which never return null. r=dholbert 2013-02-16 13:51:03 -08:00
L. David Baron
5ef4421fa5 Bug 781360 patch 3: Rename {nsIFrame,nsStyleContext,nsComputedDOMStyle}::GetStyle* to Style*, since they can never return null. r=dholbert
Except for the changes in:
  layout/generic/nsIFrame.h (part)
  layout/style/nsComputedDOMStyle.h (all)
  layout/style/nsRuleNode.cpp (part)
  layout/style/nsStyleContext.cpp (part)
  layout/style/nsStyleContext.h (part)
(see patch 3b in the bug), this patch was written with the sed script:
s/\<GetStyle\(Font\|Color\|List\|Text\|Visibility\|Quotes\|UserInterface\|TableBorder\|SVG\|Background\|Position\|TextReset\|Display\|Content\|UIReset\|Table\|Margin\|Padding\|Border\|Outline\|XUL\|SVGReset\|Column\)\>/Style\1/g
2013-02-16 13:51:02 -08:00
L. David Baron
ed0e6eb8a7 Bug 781360 patch 2: Rename nsRuleNode::GetPresContext to PresContext, since it can never return null. r=dholbert 2013-02-16 13:04:54 -08:00
L. David Baron
8f3a364f1f Bug 781360 patch 1: Rename nsStyleContext::GetRuleNode to RuleNode, since it can never return null. r=dholbert
This makes it conform to our convention that getters returning pointers
that can never be null do not begin with "Get".

nsStyleContext's rule node is never null because we require a rule node
in order to construct a style context.
2013-02-16 13:04:53 -08:00
Daniel Holbert
35466de209 Bug 834107: Replace helper-function GetContainingBlockFor() with direct calls to nsIFrame::GetContainingBlock(), in nsComputedDOMStyle.cpp. r=dbaron 2013-02-16 10:34:34 -08:00
Jonathan Watt
05055eec39 Bug 838256, part 2 - Overhaul and complete the layout pieces for <input type=range>. r=dholbert for the combined diff with the previous changeset. 2013-02-16 17:57:21 +00:00
Wes Johnston
daa8624c27 Bug 838256, part 1 - Initial work on the layout pieces for <input type=range>. DONTBUILD separately from jwatt's changeset (the next one) to finish this work. r=dholbert for the combined diff. 2013-02-16 17:57:21 +00:00
Daniel Holbert
0f83a47917 Bug 841873 test changes: Tweak reftests/mochitests/crashtests to remove assumptions about the flexbox pref's default setting. (test-only) 2013-02-15 17:17:21 -08:00
Mounir Lamouri
5a8ed7a0d1 Bug 841828 - Show the appropriate cursor on disabled text fields. r=bz 2013-02-16 10:58:28 +00:00
L. David Baron
27b5ab689a Bug 841896: Rename CSSKeyframesRule.insertRule to appendRule to match spec change.
Note that this does not change the IID of nsIDOMMozCSSKeyframesRule
since neither the method signature nor semantics have changed; only the
name is different.
2013-02-15 21:38:34 -08:00
L. David Baron
b387f0fbea Bug 841789, patch 1: Rename nsIFrame::GetStyleContext() to nsIFrame::StyleContext() since it can never return null. r=dholbert
This makes it conform to our convention that getters returning pointers
that can never be null do not begin with "Get".
2013-02-15 21:38:33 -08:00
Boris Zbarsky
44f18e46f3 Bug 840898. Flag our nullable return value as actually being nullable. r=tbsaunde 2013-02-15 22:36:15 -05:00
Jesse Ruderman
b12615f104 Bug 840402 - Add some more values to property_database.js. r=dbaron 2013-02-15 18:42:48 -08:00
Avi Halachmi
ad77774fb9 Bug 838758: Cache GradientStops instead of gfxPattern. r=jrmuizel
Our gfxPattern cache is currently way too specific, which causes lots of
unnecessary cache misses. The only thing that we actually need to key on is the
color stops.

This switches the cache to hold GradientStops instead of gfxPatterns. This
improves our cache hit rate and is simpler. It also avoids doing caching when
not using Azure, which currently has no benefit.

Average paint times results (in ms)
(on windows 7 x64, i7-3630qm, HD4000)
-------------------------------------
m-c
open: 3.5 close: 3.3

m-c cache-key
open: 2.6 close: 2.4

ux
open: 7.3 close: 5.2

ux cache-key
open: 6.9 close: 5.3
2013-02-15 20:54:49 +02:00
Trevor Saunders
dacbf11a24 bug 840906 - densISupportsify nsDOMRGBCSSColor r=mccr8 2013-02-13 16:39:23 -05:00
L. David Baron
313fd38cc9 Bug 840367: Fix misnaming of keyword IDs in nsCSSKeywordList.h. r=heycam 2013-02-13 11:53:56 -08:00
L. David Baron
4368b654a3 Bug 836329: Fix regression handling 'rem' units in media queries. r=bzbarsky
I confirmed that the added tests fail without the patch and pass with
the patch.
2013-02-13 11:53:56 -08:00
Boris Zbarsky
7218702798 Bug 833808 part 2. Add some utilities for working with selectors to inspector utils. r=dbaron 2013-02-13 10:11:53 -05:00
Boris Zbarsky
81c0b2b097 Bug 618479 part 1. Clean up the nsTArray binary-insert code a little bit. r=jlebar,kinetik 2013-02-13 10:11:53 -05:00
Daniel Holbert
f41ff81c5c Followup for Bug 840317: use an unsigned loop variable when iterating up to an unsigned value, to fix warnings-as-errors build error. r=bustage,trivial CLOSED TREE 2013-02-11 17:27:14 -08:00
Cameron McCormack
85dbbf856b Bug 840317 - Re-evaluate media queries in scoped style sheets. r=dbaron 2013-02-12 11:48:44 +11:00
Cameron McCormack
a867cdc272 Bug 655877 - Part 11b: Use the right hints when reflowing due to dominant-baseline change. r=jwatt 2013-02-11 17:22:16 +11:00
L. David Baron
c9f05dae46 Bug 765599: Make CSS insertRule methods throw SYNTAX_ERR when given an empty rule or more than one rule. r=bzbarsky
This implements the proposed spec clarification in
http://lists.w3.org/Archives/Public/www-style/2013Feb/0229.html which
makes us compatible with WebKit on the insertRule tests in this patch.

I confirmed that the test reports 7 failures without the patch, but
passes with the patch.  (I'm a little disturbed by the way our
testharness.js integration elides runs of successive passes.)
2013-02-09 22:56:49 -08:00
L. David Baron
c0a08c5665 Bug 835007: Make 'transition-property: all' work as an item within a list. r=bzbarsky
No changes to the transition manager are needed since
nsTransitionManager::StyleContextChanged already makes the appropriate
calls to ConsiderStartingTransition for 'all', and that existing code
should work fine within a loop (just like the existing code to handle
shorthands or other property duplication works).
2013-02-09 22:56:49 -08:00
Robert Strong
2615fbe80d Back out Bug 678392 2013-02-08 16:52:12 -08:00
Stephen Pohl
edc1aa01df Swipe availability check - Bug 678392 - [10.7] Add support for swipe animation as in Safari. r=smichaud 2013-02-08 13:57:28 -08:00
Alexandre Poirot
a665cb3ea1 Bug 821695 - Do not load videocontrols.xml if the audio/video tag does not need it. r=roc
--HG--
extra : rebase_source : 567194ec6ee1862af1d7988aa9a0c3b50f07788a
2013-02-01 08:47:55 -05:00
Boris Zbarsky
0f14b8f99f Bug 837031. When unlinking a keyframe rule, make sure to DropReference on its declaration. r=smaug 2013-02-06 14:24:04 +00:00
Seth Fowler
e315e0e91d Bug 836124 - Replace GetCurrentFrameIsOpaque() with [noscript] FrameIsOpaque(aWhichFrame). r=joe 2013-02-04 14:22:30 -08:00
Jonathan Watt
311968ccaf Bug 835883 - Give the -moz-orient property an 'auto' value, and make that its initial value. r=dholbert. 2013-02-02 19:13:22 +01:00
Daniel Holbert
1afe51a6f8 Bug 836604: Collapse nsStyleSet::GetContext()'s boolean parameters into a 'flags' parameter. r=bz 2013-02-01 08:02:29 -08:00
Ryan VanderMeulen
0bcd6af670 Backed out changeset e521791fe3cc (bug 821695) for mochitest-2 orange.
--HG--
extra : rebase_source : 681bd3b9bf50fbc7c3f5a55a40f473180e10608b
2013-02-01 10:06:19 -05:00
Alexandre Poirot
d78573b158 Bug 821695 - Do not load videocontrols.xml if the audio/video tag does not need it. r=roc 2013-02-01 08:47:55 -05:00
L. David Baron
0031324622 Bug 836530 followup: fix tests for new ASCII range. 2013-01-31 21:09:40 -08:00
L. David Baron
68ac09e29e Bug 836530: Make all non-ASCII characters be CSS identifier characters. r=bzbarsky
This is as was proposed in
http://lists.w3.org/Archives/Public/www-style/2013Jan/0394.html
and resolved in the CSS Working Group's teleconference on 2013-01-30.

This removes a difference between Gecko and other browsers.
2013-01-31 20:09:47 -08:00
Henri Sivonen
bb181e9318 Bug 820508 part 2 - UA stylesheet for <main>. r=bzbarsky. 2013-01-29 14:31:45 +02:00
L. David Baron
022804a80d Bug 835169: Remove unused mapping into style of table cols attribute. r=bzbarsky 2013-01-28 21:16:22 -08:00
Peter Van der Beken
bfc9de7860 Fix for bug 816088 (webIDL bindings try to extract nsISupports from the global object in static properties in workers). r=bz.
--HG--
extra : rebase_source : 5668d9e01bff0fe7831d98018428856e5940a620
2012-12-03 17:07:49 +01:00
Ed Morley
19dd19ed37 Backout f3c145bd1dd2 & 5075690572a9 for OS X startup failures 2013-01-28 11:08:21 +00:00
Peter Van der Beken
70a2f7c413 Fix for bug 816088 (webIDL bindings try to extract nsISupports from the global object in static properties in workers). r=bz.
--HG--
extra : rebase_source : 68e5630591f6209e2af9c5cd2321fed8edd3de24
2012-12-03 17:07:49 +01:00
Ryan VanderMeulen
3561a5836e Merge m-c to inbound. 2013-01-26 21:23:50 -05:00
Ryan VanderMeulen
517ca6292f Merge m-c to fx-team. 2013-01-26 21:21:39 -05:00
Matthew Noorenberghe
91dfb7f3b4 Bug 816803 - Add system metric and media query keyword to detect whether the current Windows desktop theme supports Aero Glass. r=jimm,sr=roc
--HG--
extra : rebase_source : 56b27cbbbcc0cde254ef7aa7087f11360c476390
2013-01-16 19:27:16 -08:00
Martijn Wargers
51a3a66b69 Bug 363950 - crashtest. 2013-01-26 14:15:30 +01:00
Mounir Lamouri
4c2b124e68 Bug 819871 - Make ":-moz-placeholder" parsable but without any effect on styling. r=dbaron,bz 2013-01-24 09:30:28 +00:00
Chris Peterson
81bf7b134b Bug 816298 - Part 1: Allow child elements to override -moz-user-select:none. r=ehsan
--HG--
extra : rebase_source : f4e08713be0691c25b22510977c978088655ec8b
2013-01-08 16:33:17 -08:00
John Daggett
01d6b65920 Bug 833624. Bump up size of int's in mOrder to allow more than 256 CSS properties. r=dbaron 2013-01-24 02:24:27 +09:00
Dão Gottwald
8cad5b3aee Bug 813550 - Location bar's placeholder in an RTL chrome should be aligned on the right. r=ehsan a=nonlibxul 2013-01-22 00:13:04 +01:00
Boris Zbarsky
9a22977552 Bug 774980. Hook up nsCSSKeyframeRule to cycle collection. r=smaug 2013-01-18 23:32:12 -05:00
Mark Finkle
8237809a34 Backout 3b91d62ca343 and 662d0cd47316 for test failures 2013-01-17 20:44:46 -05:00
Mark Finkle
5522f78d9d Bug 831123 - Disable CSS error reporting by default to improve pageload performance r=blassey r=jmaher 2013-01-17 18:38:47 -05:00
Trevor Saunders
b98e34aed0 bug 822289 - remove NS_IMPL_CYCLE_COLLECTION_CLASS and friends r=mccr8 2013-01-12 07:40:33 -05:00
Cameron McCormack
39a2dac253 Bug 829363 - Make :scope match style scope roots. r=bzbarsky 2013-01-16 15:48:29 +11:00
Boris Zbarsky
8612fe0238 Bug 827799. Apply clip to outer table frames as needed. r=roc 2013-01-15 14:04:24 -05:00
Trevor Saunders
4f48cd4e2c bug 830396 - add back nsIDOMCSSValueList r=bz 2013-01-14 12:29:27 -05:00
Mats Palmgren
d5826be6d7 Bug 786533 - Replace NS_MIN/NS_MAX with std::min/std::max and #include <algorithm> where needed. r=ehsan 2013-01-15 13:22:03 +01:00
Ehsan Akhgari
dbaf74bc59 Backed out changeset 5af4c6bd5104 (bug 827075) because it is no longer necessary 2013-01-14 16:21:54 -05:00
Cameron McCormack
21a5427224 Bug 828805 - Followup warning removal. 2013-01-13 11:45:23 +11:00
Cameron McCormack
3170bacd4d Bug 828805 - Followup build fix. 2013-01-13 11:17:00 +11:00
Cameron McCormack
b8c8bf6c2c Bug 828805 - Implement SVG paint-order property. r=bz,roc 2013-01-13 10:27:53 +11:00
David Zbarsky
6168609ec2 Bug 827149 - Remove some uses of nsIDOMHTMLBodyElement r=bz 2013-01-12 16:53:01 -05:00
Seth Fowler
d32b956841 Bug 811391 - Part 2: Tests. r=dbaron 2013-01-09 16:05:19 -08:00
Seth Fowler
67775c2f19 Bug 811391 - Part 1: Ignore @page declarations involving viewport units. r=dbaron
* * *
Bug 811391 followup: Fix out-of-order init list, to fix build warning (treated as error).
2013-01-09 16:03:55 -08:00
Ehsan Akhgari
2711ec5e76 Backed out 2 changesets (bug 811391) because of build bustage
Backed out changeset c20904b75bcc (bug 811391)
Backed out changeset f0a00bf2ba8e (bug 811391)
2013-01-12 16:05:11 -05:00
Brendan Dahl
0dd6b2e3a8 Bug 827591 - Be more careful changing declarations on page rules. r=dbaron 2013-01-09 10:33:09 -08:00
Seth Fowler
48088dc93b Bug 811391 - Part 2: Tests. r=dbaron 2013-01-09 16:05:19 -08:00
Seth Fowler
a45a8ce8df Bug 811391 - Part 1: Ignore @page declarations involving viewport units. r=dbaron 2013-01-09 16:03:55 -08:00
Daniel Holbert
f03386ee5e Bug 829168: Mark layout/style as FAIL_ON_WARNINGS, on non-MSVC compilers. r=bz 2013-01-12 10:49:12 -08:00
Daniel Holbert
ca0da46939 Bug 829369: Cast pointer-subtraction to a size_t (after ensuring it'll be nonnegative) when comparing it to a nsTArray's size, to fix signed/unsigned comparison build warning. r=dbaron 2013-01-12 01:56:15 -08:00
Chris Peterson
b483c0b61c Bug 829344 - Part 4: Fix gcc -Wlogical-op warnings from PRBool/bool conversion. r=ehsan 2013-01-10 17:56:51 -08:00
L. David Baron
647e6ccc5a Bug 822891: Make animationiteration events fire when we're running off-main-thread animations and throttling style changes. r=nrc 2013-01-11 09:53:14 -08:00
Zack Weinberg
02d54c729f Bug 413958: report the text of the offending line in CSS error messages. r=dbaron 2013-01-11 12:27:43 -05:00
Ms2ger
fea92580b3 Merge latest PGO-green m-i changeset to m-c. 2013-01-11 14:48:33 +01:00
Ms2ger
41958008fc Bug 825407 - Get rid of GetElementParent; r=mounir 2013-01-11 09:43:01 +01:00
L. David Baron
569efd78bf Bug 827687, patch 2: Be more careful walking segments. r=bzbarsky 2013-01-10 21:14:51 -08:00