Commit Graph

461 Commits

Author SHA1 Message Date
Ian Neal
081ca4e9b3 Test for Bug 291780 - List outdent is not working properly r=ehsan 2011-08-10 00:14:58 +01:00
Ian Neal
49689844b3 Test for Bug 290026 - Outdent of List does not work properly r=ehsan 2011-08-10 00:14:53 +01:00
Ehsan Akhgari
6690ac6ddf Merge the latest green changeset on mozilla-inbound to mozilla-central 2011-08-09 08:09:13 -04:00
Jan Varga
5020b003ce Bug 617528 Part 2 - Core implementation r=smaug
--HG--
rename : content/html/content/test/test_bug418756.html => content/html/content/test/test_checked.html
2011-08-08 19:31:32 +02:00
Fabien Cazenave
5dd43c9b97 Bug 674861 - contentEditable lists should not be splittable; r=ehsan
In design mode, pressing [Return] twice in a list (ol, ul, dl) splits the list
and inserts a paragraph. When the list is the active editing host, it should not
be split.
2011-08-02 15:04:43 -04:00
Henri Sivonen
0176915bb7 Bug 596182 - Make fragment parsers global. Remove resulting dead code. r=Olli.Pettay, r=bzbarsky. 2011-08-01 10:48:24 +03:00
Henri Sivonen
147c3287ec Bug 482909 part 2 - Implement an HTML/SVG/MathML sanitizer independently of parsers or serializers. r=bzbarsky. 2011-07-29 14:48:04 +03:00
Michael Wu
6a28121ce1 Bug 671417 - Incorrect use of PRBool when other types are more appropriate or vice versa, r=bz,ehsan,dwitte,joe,vlad,luke,mak,roc 2011-07-26 23:43:37 -07:00
Fabien Cazenave
0999dbd2e1 Bug 620319 - crash [@ nsHTMLEditor::GetInlinePropertyBase] if !aAttribute; r=ehsan
Adds a null check to avoid dereferencing a null pointer.

--HG--
extra : rebase_source : 75b97cafad2318af60956d88d12da51a00224949
2011-07-26 18:09:12 -04:00
Fabien Cazenave
bf28416694 Bug 620283 - crash [@ nsHTMLEditor::RemoveStyleInside] if !aAttribute; r=ehsan
Adds a null check to avoid dereferencing a null pointer.

--HG--
extra : rebase_source : ba8bfcabbc2f17b0b0cea1d90dbed54a8471bad9
2011-07-26 18:08:55 -04:00
Fabien Cazenave
9e280efb90 Bug 460740 - [contentEditable] invalid results when pressing Enter in a bunch of different cases; r=ehsan
In some situations, pressing Enter in a contentEditable node fails:
 * in an editable paragraph, list item or header, pressing Enter
   creates another editable block;
 * in an inline editable node, pressing Enter does nothing.

That's because nsHTMLEditRules::WillInsertBreak doesn't check for the active
editing host. This patch should fix it.
2011-07-26 17:38:23 -04:00
Jonathan Kamens
e4101fc489 Bug 489202 - selection moves to top when html containing meta, link, or style elements is pasted or inserted; r=ehsan 2011-07-26 13:59:50 -04:00
Fabien Cazenave
2c92600954 Bug 688599 - do not expand selection for deletion outside of the active editing host; r=ehsan
When a selection in an inline element is to be deleted, it is first expanded to
the parent block in order not to leave any empty inline element. This patch
ensures that the selection cannot be expanded outside of the contentEditable
element (active editing host).
2011-07-25 17:11:46 -04:00
Ehsan Akhgari
cadef9ec48 Merge mozilla-central and mozilla-inbound 2011-07-24 12:52:51 -04:00
Joel Maher
344f4a7302 Bug 666654 - split eventutils.js functions that are chrome only into chromeutils.js. r=ted, a=test-only 2011-07-23 09:02:40 -04:00
Ms2ger
2a3176b2ee Bug 666665 - Remove isindex content code; r=sicking+hsivonen 2011-07-23 11:45:38 +02:00
Fabien Cazenave
81bff8a94d Bug 449243 - contentEditable: insert <p> instead of <br>; r=ehsan
In editable elements, create a paragraph instead of a <br> node
when [Return] is pressed:
 * once in a header node (<h[1..6]>);
 * twice in a list item node (<li>).
2011-07-22 12:19:17 -04:00
Mounir Lamouri
2e1dfaef9e Bug 669310 - Fixes various includes and forward declarations. f=Ms2ger r=jst 2011-07-20 12:18:54 -07:00
Ehsan Akhgari
ee5215c7a6 Revert to changeset e0ce7821fce1 because the latest push broke all of the builds DONTBUILD 2011-07-19 16:25:54 -04:00
Mounir Lamouri
5937d63965 Bug 669310 - Fixes various includes and forward declarations. f=Ms2ger r=jst 2011-07-19 11:22:43 -07:00
Mounir Lamouri
b088e154d6 Backed out bug 669310, bug 668013, bug 667887 and bug 669886 due to build bustage. 2011-07-19 10:49:48 -07:00
Mounir Lamouri
d2f5a3b4c3 Bug 669310 - Fixes various includes and forward declarations. f=Ms2ger r=jst 2011-07-18 17:05:10 -07:00
arno renevier
ba6b969048 Bug 417418 - do not treat context click as double click anymore in editor; r=ehsan 2011-07-18 14:42:56 -04:00
Ehsan Akhgari
13c7a908e4 Backout changeset 65e0d40a57b7 (bug 417418) because of unit test failure 2011-07-18 16:29:22 -04:00
arno renevier
89a10e6166 Bug 417418 - do not treat context click as double click anymore in editor; r=ehsan 2011-07-18 14:42:56 -04:00
Ehsan Akhgari
a6b5feed16 Bug 671672 - Reduce a bunch of console spam in debug builds caused by the HTML editor; r=roc 2011-07-14 17:06:37 -04:00
Ehsan Akhgari
4a9dec68d7 Bug 414526 - Backspace at the beginning of a contenteditable element or delete at the end of one should not affect the rest of the contenteditable elements on the page; r=roc
The main fix here involves the introduction of the nsHTMLEditor::IsNodeInActiveEditor
API.  This API returns true if the current selection in the document falls
inside the active editable section.  The patch adds a bunch of checks using
this API to various places in the code to make sure that editing operations do
not escape their editing host.

There are also some unrelated fixes to range promotion code which fix the
bugs that have existed in that code before, but because of the lack of this
check were not uncovered before.

This patch also removes the nsTextEditUtils::InBody API which only made sense
in designMode documents, and was insufficient for contenteditable elements.
2011-07-14 11:25:07 -04:00
Ms2ger
7a41ef9f3e Bug 670499 - Make nsEditor::CreateEventListeners return void; r=ehsan 2011-07-15 12:18:35 +02:00
Simon Montagu
ae37ce037d Undefine caret bidi level during reflow instead of on text entry. Bug 664087, r=roc 2011-07-05 08:42:32 +03:00
Jonas Sicking
5491caaaf4 Bug 661297 Part 1: Remove Add/RemoveEventListenerByIID API. r=smaug 2011-08-08 11:26:26 -07:00
Ehsan Akhgari
c6e514aa14 Bug 549262 - Enable the (shift-)space shortcut key for scrolling up/down in pages containing editable elements; r=roc
--HG--
extra : rebase_source : 99706dd2e678052b345b011ea76f17370ad1a227
2010-09-06 16:59:41 -04:00
Ehsan Akhgari
beba2dbb1d Bug 439808 - Make sure that deleting a selection works in inline contenteditable elements which have a non-editable parent block; r=roc
--HG--
extra : rebase_source : 74d3df996b904032696000daa532d217140d3b2d
2011-06-29 21:01:59 -04:00
Jonas Sicking
cc14f402b6 Bug 663461 Part 1: Remove Add/RemoveEventListenerByIID from editor. r=smaug 2011-06-27 16:34:54 -07:00
Wolfgang Germund
db7ef51c94 Bug 664095 - Remove the override stylesheets when the editor is detached from the document as opposed to when it's destroyed for compatibility with the expected behavior from Composer; r=ehsan 2011-06-24 13:55:43 -04:00
Jonas Sicking
864793d608 Bug 658714 Part 9: Don't use EventGroups for system-group. r=smaug 2011-06-23 19:18:02 -07:00
Jonas Sicking
6a04ff1d9f Bug 658714 Part 6: Fixups after search'n'replace s/nsPIDOMEventTarget/nsIDOMEventTarget/. r=smaug 2011-06-23 19:18:01 -07:00
Jonas Sicking
e3f6b769a1 Bug 658714 Part 5: Search'n'replace nsPIDOMEventTarget to nsIDOMEventTarget. r=smaug 2011-06-23 19:18:00 -07:00
Ed Morley
576fc154e6 Bug 665359 - Remove unused variable res from nsHTMLEditor::AddPositioningOffset; r=ehsan
DONTBUILD
2011-06-20 14:53:51 -04:00
Joel Maher
a184675917 Bug 664165 - move editor/libeditor/html/tests/test_contenteditable_text_input_handling.html to mochitest-chrome. r=masayuki, a=test-only 2011-06-19 11:56:44 -04:00
Masayuki Nakano
db1e5b26fa Bug 664437 editor should use mozilla::Preferences r=ehsan 2011-06-17 09:59:29 +09:00
Jonas Sicking
17ec46a39a Bug 659053 Part 1: Merge nsIDOM3Node into nsIDOMNode. Also removes Node.getFeature. r=peterv 2011-06-14 00:56:48 -07:00
Matt Brubeck
830f102cc9 Bug 663959 - Mark crashtests as asserting intermittently [r=ehsan] 2011-06-13 14:24:04 -07:00
Dominic Fandrey
0ab2f46136 Bug 645398 - Substitute PR_(MAX|MIN|ABS|ROUNDUP) macro calls; r=roc 2011-06-02 14:56:50 +02:00
Ms2ger
35e44f908f Bug 659113 - Remove nsIDOMNSHTMLDocument; r=bz 2011-05-28 09:43:57 +02:00
Ehsan Akhgari
319dc53b8e Bug 658516 - nsHTMLEditRules.cpp:5810:52: warning: comparison between signed and unsigned integer expressions. r=roc
--HG--
extra : rebase_source : 6772483c9ca0eb23444850db1f30f0144516a861
2011-05-25 10:10:45 +02:00
Ms2ger
c36c459144 Bug 657210 - Outparamdel nsEditor::GetPresShell; r=ehsan 2011-05-22 14:43:13 +02:00
Craig Topper
4e38ca20a7 Bug 658143 - Part 1: Changes nsCOMPtr<nsFrameSelection> to nsRefPtr. r=roc 2011-05-18 20:10:49 -07:00
Ms2ger
48b02e4f5a Bug 657160 - Remove NS_NewTextEditRules; r=ehsan 2011-05-15 12:16:45 +02:00
Ms2ger
63679730f9 Bug 657160 - Remove NS_NewHTMLEditRules; r=ehsan 2011-05-15 12:15:35 +02:00
Ms2ger
f828b0aa18 Bug 656996 - Remove NS_NewHTMLCSSUtils; r=ehsan 2011-05-15 12:07:30 +02:00
Ms2ger
d5df8a6e33 Bug 655514 - Remove nsIDOMDocumentTraversal; f=ehsan r=jonas 2011-05-15 12:07:30 +02:00
Ed Morley
082d53f39b Bug 655756 - Remove final XP_MAC remnants; r=josh 2011-05-10 20:24:48 +02:00
Mounir Lamouri
7211c91c57 Bug 514437 - Content part of the progress element. r=smaug 2011-04-09 10:22:02 -07:00
Matt Brubeck
1b17575132 Back out changeset bfb48178c8ec (finish backing out bug 514437) to fix tests on a CLOSED TREE. 2011-05-09 19:38:05 -07:00
Jonas Sicking
549cf0a0a2 Bug 643786. Don't fire DOMNodeRemoved when removing the editor created <br>. r=ehsan 2011-05-09 12:33:04 -07:00
Jonas Sicking
0e17979856 Bug 650493 Part 1: Simplify mutation events by firing all but DOMNodeRemoved off of script runners, and DOMNodeRemoved before starting any update batches or aquiring any state. r=smaug/peterv 2011-05-09 12:33:03 -07:00
Mounir Lamouri
dd977ba6ef Bug 514437 - Content part of the progress element. r=smaug 2011-04-09 10:22:02 -07:00
Sebastian Kromp
d80897722a Bug 633750 - deCOM nsIHTMLEditRules and move methods to nsHTMLEditRules. r=ehsan 2011-05-07 10:04:56 +02:00
Ms2ger
941e819c63 Bug 616684 - Remove support for DOM Views; r=sicking,ehsan 2011-04-24 08:54:25 +02:00
Neil Rashbrook
fefcb1dbbc Bug 647682 Can't copy and paste local links in <editor> documents r=ehsan f=bz 2011-04-28 20:59:45 +01:00
Ehsan Akhgari
d2a61eb331 Backout changeset 13f6847dd840 (bug 616684) because it changes code semantics in a bad way, which results in problems like the crash in bug 652580, possibly among others 2011-04-25 17:05:17 -04:00
Ms2ger
295bf7256b Bug 616684 - Remove support for DOM Views; r=sicking 2011-04-24 08:54:25 +02:00
David Zbarsky
5ecf0a2bd3 Bug 610305: decom nsEventStateManager r=smaug 2011-04-21 19:35:52 +02:00
Mounir Lamouri
b4cf8cd184 Backed out changeset c1a7c1bc1aeb due to busted build. 2011-04-20 22:26:06 +02:00
David Zbarsky
c4d29900ed Bug 610305: decom nsEventStateManager r=smaug 2011-04-20 21:42:33 +02:00
Ehsan Akhgari
f9088e8fe4 Bug 649566 - @keyframe(s) missing from <style> sanitizing code in nsHTMLFragmentContentSink; r=bzbarsky 2011-04-13 18:12:32 -04:00
Kyle Huey
29d5f43cb5 Merge m-c to bs. 2011-03-31 07:17:15 -04:00
Kyle Huey
75ee2642d1 Merge m-c to bs. 2011-03-26 12:12:37 -04:00
Ehsan Akhgari
b50ffe71b6 Bug 611457 - Move the object which is supposed to survive the function's return out of the function so that a possible garbage collection doesn't collect it before it should be used; r=roc a=test-only 2011-03-12 00:07:37 -05:00
Ehsan Akhgari
b8feac7449 Bug 618041 - Move the object which is supposed to survive the function's return out of the function so that a possible garbage collection doesn't collect it before it should be used; r=roc a=test-only 2011-03-12 00:11:01 -05:00
Ehsan Akhgari
c6ae64d9aa Bug 635757 - Adjust the assertion count as a result of bug 633738; r=roc a=test
DONTBUILD this simple assertion annotation adjustment!
2011-02-21 23:53:40 -05:00
Mats Palmgren
7958218e24 Bug 635636 - Don't return a value from void function. a=bustage 2011-02-21 21:43:54 +01:00
Mats Palmgren
b765f11bf5 Bug 635636 - Crash [@ nsHTMLEditRules::DocumentModifiedWorker] with navigated-away designMode document; r,a=ehsan 2011-02-21 15:34:16 -05:00
Ehsan Akhgari
075288f489 Bug 635532 - Don't try to hide the editor anonymous UIs during the cycle collection unlink phase needlessly. r=roc,jst, a=blocker 2011-02-19 21:43:07 -08:00
Kyle Huey
da2a416c73 Bug 633709: Convert bogus assert into a warning. r+a=ehsan
--HG--
extra : rebase_source : 5928d5a4309bd98e0cf4cd3041f36ba64d992706
2011-02-19 17:49:23 -05:00
Peter Van der Beken
2552abd64a Fix for bug 633738 (quora.com bloats out of control (part 3)) - mark some known assertions caused by bug 439258. r=bz, a=jst. 2011-02-17 12:19:13 +01:00
Peter Van der Beken
d78216fbaf Fix for bug 633738 (quora.com bloats out of control (part 3)) - make nsHTMLEditor participate in CC, clear editor from SHistory if we're not storing anything else. r=jst, a=jst. 2011-02-16 13:07:47 +01:00
Serge Gautherie
c690e45a6f Bug 634626 - test_bug366682 failures because spellchecking is disabled; (Bv1) s/CR+LF/LF/g, Remove ending whitespaces.
r=jmaher (a=test-only).
DONTBUILD
2011-02-17 20:19:35 +01:00
Ehsan Akhgari
4d76d777f1 Back out changeset 0fd8793db7f3 (bug 633738) because of various oranges in different test suites on multiple platforms; a=orange 2011-02-14 18:45:23 -05:00
Peter Van der Beken
b9ca9b2552 Fix for bug 633738. Fix leak due to session history code keeping an editor alive too long. Patch by peterv and bz, r=jst@jstenback.com, a=blocker 2011-02-14 14:26:14 -08:00
Mounir Lamouri
d33f310364 Bug 629845 (2/2) - GetRoot() returning null isn't unexpected. r=ehsan a=blocking-final 2011-02-11 02:01:49 +01:00
Mounir Lamouri
350253af3e Bug 629845 (1/2) - Don't make nsHTMLDocument::EditingStateChanged fails if BeginningOfDocument fails. r=ehsan a=blocking-final 2011-02-11 01:59:37 +01:00
Ehsan Akhgari
fa1dcf4c12 Bug 632326 - Synthesize a Paste command instead of calling the internal goDoCommand in the test for bug 520189; r=roc a=test-only 2011-02-08 21:50:51 -05:00
Benjamin Smedberg
92bd44c461 Bug 617539 - Remove branch interfaces, nsIHTMLEditor_MOZILLA_2_0_BRANCH, straight backout of revision e9d979b4b4a0, r=ehsan 2011-03-25 11:03:33 -04:00
arno renevier
0a36ca716b Bug 497115 - nsHTMLEditor.cpp contains unnecessary includes; r=peterv sr=peterv 2011-03-23 23:23:39 -04:00
Ehsan Akhgari
8d74540d77 Test case for bug 635636; r=roc 2011-02-21 16:58:07 -05:00
Ehsan Akhgari
d98dd1278c Bug 642704 - Part 3: Remove test_set.py because it confuses our mochitest suite runner, and we don't need it to run the BrowserScope RichText2 suite; r=roc 2011-03-19 16:45:29 -04:00
Ehsan Akhgari
11e4fe7769 Bug 642704 - Part 2: Add a test driver to run the BrowserScope RichText2 test suite as a mochitest; r=roc 2011-03-19 16:44:30 -04:00
Ehsan Akhgari
705f18833c Bug 642704 - Part 1: Import the BrowserScope RichText2 test suite files into the tree; r=roc 2011-03-18 18:15:24 -04:00
Ehsan Akhgari
e4ad8f774b Bug 640321 - Register the mouse event handlers for the editor in the system group; r=roc 2011-03-16 15:34:30 -04:00
Ehsan Akhgari
c06813a2c5 Bug 407127 - Part 6: Remove the presshell argument to nsIEditor::Init as it's no longer necessary; r=roc 2011-03-11 00:40:31 -05:00
Ehsan Akhgari
343b9d2aa6 Bug 407127 - Part 3: Get the selection controller for HTML editors from the presshell, instead of holding on to a presshell reference masked as a selection controller; r=roc 2011-03-11 00:40:30 -05:00
Ehsan Akhgari
6ef553932d Bug 407127 - Part 2: Refactor the editor so that it only touches mSelConWeak in GetSelectionController, to make removing it for HTML editors easier; r=roc 2011-03-11 00:40:30 -05:00
Ehsan Akhgari
586a904360 Bug 407127 - Part 1: Refactor the editor so that it only touches mPresShellWeak in GetPresShell, to make removing it easier; r=roc 2011-03-11 00:40:30 -05:00
Boris Zbarsky
890788b82e Bug 632904. Check IsEditable(), not content states, if we care about editability. r=ehsan,masayuki 2011-03-23 10:45:21 -04:00
Chris Jones
8991442744 Rollup of bug 615386, parts 1-6. Teach the reftest harness about <browser remote>. r=dbaron,roc,ted a=a
--HG--
rename : layout/tools/reftest/reftest.js => layout/tools/reftest/reftest-content.js
2011-02-03 13:54:10 -06:00
Ehsan Akhgari
561113cc04 Bug 628980 - browserscope richedit tests load http://www.google.com/intl/en_ALL/images/logo.gif over the network; r=roc a=NPOTB 2011-01-27 00:26:33 -05:00
Ehsan Akhgari
d48edb3f7d Bug 622371 - Only set the selection to the beginning of the editable document if the editor is being initialized by entering designMode; r=bzbarsky a=blocking-final+ 2011-01-06 17:13:51 -05:00
Ehsan Akhgari
b3f2d74515 Bug 620906 - Back out part of bug 289384 to make sure that scrollbars work in CKEditor fields again; r=roc a=blocking-final+ 2011-01-11 16:00:44 -05:00
timeless@mozdev.org
186210bc44 Bug 620423 - nsHTMLEditor::ParseCFHTML foolishly checks aStuffToPaste instead of *aStuffToPaste; r=neil a=roc 2011-01-11 10:20:31 -05:00