- I've refactored the way we set modes as well, making it a part
of the TextTrack ctors.
- I've also changed TextTracks in the track tests to have their
mode set to 'hidden' in order to be able to call TextTrack::Cues.
This is correct since TextTracks with a mode of 'disabled' do not
return null for their cue lists.
* mDirty needs to be set to false after the list has been recomputed.
* The loop that adds cues to the list doesn't work properly when the
list has become dirty as we check if endTime < playback time and
since we start from pos 0 we will never get past the first cue.
- Updated RemoveCue to throw NotFoundError if the cue being removed is
not in the cue list.
- Updated AddCue to not add cues that are already in the list. This is
done by reference comparing.
This way we can ensure that JS code written for WebVTT is spec
compliant while at the same time not having to abstract VTTCue
from TextTrackCue.
--HG--
rename : dom/webidl/TextTrackCue.webidl => dom/webidl/VTTCue.webidl
- Removed HTMLMediaElement::AsyncAwaitStableState and exposed a new method,
HTMLMediaElement::RunInStableState, that allows any nsIRunnable to run on
the app shell and take advantage of IsCancelled() code in an nsMediaEvent.
- HTMLTrackElement now uses this to call HTMLTrackElement::LoadResource.
- Changed test_texttrackcue.html to listen for MediaElement's "loadedmetadata"
to ensure that we wait until the cues are loaded before testing and set
preload=auto to get it to pass on Android.
