Commit Graph

245 Commits

Author SHA1 Message Date
sspitzer@mozilla.org
eff0598e5c fix for bug #394226: can't drag favicon to an empty bookmarks toolbar r=dietrich, mconnor a=mconnor for m8 2007-09-07 16:16:18 -07:00
sspitzer@mozilla.org
4b0bd8fb03 fix for bug #394527: livemark feed URIs should show up as "bookmarked" (gold star on) in the url bar and in url bar autocomplete search results for performance: when searching previous autocomplete results, we don't need to regenerate the hash tables (of livemark item ids and livemark feed URIs). when searching previous autocomplete results, if we find any, tell the front end immediately, instead of waiting for our first db query to return. r=dietrich, a=mconnor for m8 2007-09-07 14:47:21 -07:00
enndeakin@sympatico.ca
e1b612785e Bug 394397, make cut/copy/paste menus sticky, r=mano, a=mconnor 2007-09-07 05:28:48 -07:00
mozilla.mano@sent.com
e72a9c65fa Bug 175124 - improve open in tabs behaviour (see comment 26), this also enables 'Open All in Tabs' for host nodes in the history sidebar (bug 369919) and for saved searches (queries), patch by mconnor and me. 2007-09-02 12:03:24 -07:00
dietrich@mozilla.com
8393b84957 Bug 317847 Implement "Save this Search" (r=mano) 2007-09-01 14:23:36 -07:00
sspitzer@mozilla.org
961c0d46d0 fix for bug #393887: Star icon shouldn't be set for items in RSS / Live Bookmarks. r=dietrich 2007-08-31 17:04:23 -07:00
enndeakin@sympatico.ca
a0b52957c1 Bug 195031, support sticky bookmarks menus, r=mano,sr=bz, blocking bug 2007-08-30 08:43:10 -07:00
mozilla.mano@sent.com
41bfc7b363 Bug 385266 - New starring, bookmarking and tagging UI, changes noted in comment 333. r=dietrich. 2007-08-28 14:47:43 -07:00
sspitzer@mozilla.org
18fa0438fe supplimental fix for bug #386287: inconsistent use of title / name in bookmarks UI r=mano 2007-08-27 17:40:47 -07:00
mozilla.mano@sent.com
7c1760b346 Bug 393924 - Stop setting the bookmarkFeedURI annotation on livemark children. r=sspitzer. 2007-08-27 17:35:55 -07:00
sspitzer@mozilla.org
972ce584c2 fix for bug #393879: "view | show columns | name" is not disabled r=mano 2007-08-27 15:44:18 -07:00
mozilla.mano@sent.com
b133f3891a Bug 393445 - Button icon for tag list should be changed after the list is expanded. r=dietrich. 2007-08-24 11:05:17 -07:00
dietrich@mozilla.com
c2a60edd1f Bug 382639 bookmark toolbar change not reflected in UI (for stevewon@gmail.com, r=dietrich) 2007-08-23 15:24:34 -07:00
mozilla.mano@sent.com
fcbc60329b Bug 378632 - Viewing history by site in sidebar doesn't organise by site. r=mconnor. 2007-08-23 02:27:53 -07:00
gavin@gavinsharp.com
0b758ec54e Bug 386789: create JSON utilities module and use it for search suggest/sessionstore/Places, patch by Simon Bünzli <zeniko@gmail.com>, r=sspitzer, sr+a=brendan 2007-08-22 07:47:56 -07:00
mozilla.mano@sent.com
15e5163626 Bug 385266 - New add-bookmark ui, another round of changes, see comment 23 on the bug. r=dietrich. 2007-08-22 07:42:37 -07:00
dietrich@mozilla.com
14210bf691 Bug 387748 add a tag column in the organizer center pane, for tagged items (for christineyen+bugs@gmail.com, r=mano) 2007-08-21 15:31:44 -07:00
dietrich@mozilla.com
a367b86927 Bug 384239 "Search in Bookmarks" search field looks much worse on mac than it does on windows (r=sspitzer) 2007-08-19 13:12:00 -07:00
rflint@ryanflint.com
196631dafa Bug 338295 - Microsummaries should be removed when they cease to exist. r=myk 2007-08-17 20:27:22 -07:00
rflint@ryanflint.com
778825f8c0 Bug 341341 - automatically update installed microsummary generators (places unit test fixes). r=mano 2007-08-17 15:19:52 -07:00
mozilla.mano@sent.com
4540312ba5 Bug 385266 - New starring, bookmarking and tagging UI, further work. Make Bookmark This Page/Frame/Link use the new panel. r=dietirch. 2007-08-17 00:22:12 -07:00
mozilla.mano@sent.com
18ad48a0ed Bug 385266 - New starring, bookmarking and tagging UI. This is work-in-progress and not yet enabled for anything but the star button itself. Smart folders are not yet hooked up either. r=dietrich. 2007-08-15 18:15:50 -07:00
rflint@ryanflint.com
b641790654 Bug 392079 - Don't pass bad URIs from link elements beyond extractFromPage. r=myk 2007-08-14 23:18:30 -07:00
sspitzer@mozilla.org
9d755fa725 fix for bug #392003: first run migration / import from IE is slow, history import should use "run in batch" r=sayrer 2007-08-14 07:20:42 -07:00
sspitzer@mozilla.org
e9786b6582 fix for bug #387007: with lots of places data on the clipboard, command update is very slow: Places inefficiently determines whether or not it is able to paste patch=Christine Yen <christineyen+bugs@gmail.com> r=sspitzer 2007-08-11 09:08:52 -07:00
sspitzer@mozilla.org
f05a4e4e30 fix for bug #388111: copy and paste from bookmarks into notepad.exe, and we lose newlines patch=Christine Yen <christineyen+bugs@gmail.com> r=sspitzer 2007-08-10 08:50:15 -07:00
sspitzer@mozilla.org
25b223cb2d fix for bug #386788: DnD of multiple items of multiple types only drops part of selection patch=Christine Yen <christineyen+bugs@gmail.com> r=sspitzer 2007-08-02 23:10:00 -07:00
sspitzer@mozilla.org
4e2c4b2708 fix for bug #386787: Dragging / dropping multiple items causes the order of items to reverse patch=Christine Yen <christineyen+bugs@gmail.com> r=sspitzer 2007-08-02 22:52:05 -07:00
sspitzer@mozilla.org
21de63fb54 fix for bug #389782: history sidebar doesn't show the same results as fx 2, dup licate uris when grouped by site, last visited, or most visited r=dietrich 2007-08-02 22:41:31 -07:00
mozilla.mano@sent.com
f4ad6ec2f8 Bug 390716 - toolbar sub-folders are broken. r=dietrich. 2007-08-02 18:01:04 -07:00
mozilla.mano@sent.com
290a984bcd Bug 390712 - reloading a live bookmark generates warnings. r=dietirch. 2007-08-02 15:52:21 -07:00
mozilla.mano@sent.com
cc5d68d75b Fix history sidebar (need to QI the root to nsINavHistoryResultQueryNode), regressed by bug 382877 2007-08-02 15:27:02 -07:00
mozilla.mano@sent.com
3f958cc2b2 Bug 382877 - dynamic containers implementation, part 1. r=dietrich. 2007-08-02 13:19:44 -07:00
sspitzer@mozilla.org
113e9f840b fix for bug #389202: errors when I attempt to add a new folder with a description (new folder dialog doesn't dismiss)
r=dietrich, a=mconnor for M7
2007-07-29 21:11:52 -07:00
sspitzer@mozilla.org
0eb5fca39a fix for bug #384897: in-product links to AMO should be https:// (and not http://)
patch by Simon 'sipaq' Paquet <bugzilla@babylonsounds.com>

r=sspitzer, morgamic
a=mconnor for M7
2007-07-28 20:19:33 -07:00
sspitzer@mozilla.org
41a1c0c9fa fix for bug #389912: Cannot move folder with "move" button in Bookmark Manager
r=mano, a=mconnor for M7
2007-07-27 22:12:22 -07:00
rflint@ryanflint.com
0be9e3eb35 Bug 373500 - Generated titles (microsummaries) are not used in tree and menu places views. r=mano 2007-07-25 20:31:40 -07:00
mozilla.mano@sent.com
7f1f57f063 Bug 388672 - Can't add a POST keyword search bookmark. r=stevewon. 2007-07-24 14:32:29 -07:00
mozilla.mano@sent.com
8e50112fae Bug 388148 - Places View for Menus broken since bug #337855. r=dietrich. 2007-07-24 13:50:41 -07:00
mozilla.mano@sent.com
67258253c1 Bug 388695 - getBookmarkIdsForURI should sort by relevance. r=dietrich, sayrer. 2007-07-22 16:25:49 -07:00
sspitzer@mozilla.org
0b0adb6c68 fix for bug #389032: problems when changing search scope within Bookmarks Manager
r=mano
2007-07-21 01:34:42 -07:00
sspitzer@mozilla.org
4b984102cc fix for bug #388860: New folder button on Add Bookmark panel does nothing.
r=mano
2007-07-21 01:30:07 -07:00
sspitzer@mozilla.org
fa011e030d backing out, tree is closed 2007-07-19 21:22:07 -07:00
sspitzer@mozilla.org
79ba6b5ec5 fix for bug #388860: New folder button on Add Bookmark panel does nothing
r=dietrich
2007-07-19 21:18:44 -07:00
mozilla.mano@sent.com
15f04b5ba3 Backing out bug 388695 due to tinderbox suckage. 2007-07-18 21:01:53 -07:00
mozilla.mano@sent.com
bdd104cfbc Fix orange from bug 388695. 2007-07-18 19:50:58 -07:00
mozilla.mano@sent.com
292f2e1daa Bug 388337 - Pasting a folder which contains sub-folders fails. r=sspitzer. 2007-07-18 14:39:23 -07:00
philringnalda@gmail.com
dc70d1612e Bug 386392 followup, make bookmark sidebar and bookmarks as home page work post-MOZ_PLACES_BOOKMARKS, r=gavin 2007-07-17 21:31:07 -07:00
mozilla.mano@sent.com
0419606b62 Bug 386392 - Drop pre places/places-bookmarks support from browser/. r=gavin. 2007-07-17 14:08:24 -07:00
mozilla.mano@sent.com
fe83315080 We don't implement classinfo after all (i.e. shut the console errors), follow-up patch on bug 376004. 2007-07-16 12:47:19 -07:00
mozilla.mano@sent.com
7df9db0546 Fix missed caller to use the new service (bug 376004), patch by Steve Won <swon@mozilla.com>, r=me. 2007-07-16 12:37:51 -07:00
mozilla.mano@sent.com
f8417811ce Missing changes for bug 376004. 2007-07-15 13:11:35 -07:00
mozilla.mano@sent.com
79feca49e7 Bug 376004 - Places Transactions must not live in the window global scope. patch by Steve Won and me. 2007-07-15 02:44:50 -07:00
sspitzer@mozilla.org
bfecea6b96 fix for bug #387952: Folder annotations should be kept intact for delete / undo transactions
patch=Christine Yen <cyen@mozilla.com>
r=sspitzer
2007-07-13 21:17:51 -07:00
sspitzer@mozilla.org
e13da5f762 fix for bug #378558: Organize Bookmarks - paste doesn't work after cut
includes fixes for:

bug #341953:  unable to paste links into the organize bookmarks dialog
bug #383044:  Drag-and-drop bookmark creation should support meta-data
bug #385381:  Paste doesn't work in the bookmarks Manager during copy if item is modified between copy and paste

r=sspitzer
2007-07-13 17:25:26 -07:00
philringnalda@gmail.com
f013da0b9d Bug 387833 - Cannot add keyword bookmark (because (get|set)PageAnnotationString is noscript now), r=mano 2007-07-11 23:05:15 -07:00
sspitzer@mozilla.org
ca17cee351 fix for bug #387172: text in search box in bookmark manager doesn't update until I switch folders
patch=Steve Won <swon@mozilla.com>
r=sspitzer
2007-07-11 19:09:47 -07:00
sspitzer@mozilla.org
74ae517038 code cleanup for bug #387203: getFolderContents() returns the root result node instead of the result itself.
r=mano
2007-07-11 18:18:20 -07:00
mozilla.mano@sent.com
0f3555aa18 Bug 385828 - Insertion, removal and move operations of items should update the last-modified field of their containing folder. r=dietrich. 2007-07-11 15:38:13 -07:00
sspitzer@mozilla.org
fc1606d42d fix for bug #331307: Bookmarks toolbar chevron is left-aligned instead of right-aligned
patch=Steve Won <swon@mozilla.com>
r=mano
2007-07-11 12:59:14 -07:00
mozilla.mano@sent.com
501fbf8e09 Bug 331654 - Provide a way to handle annotations values in a type-agnostic way. r=dietrich. 2007-07-11 02:57:59 -07:00
sspitzer@mozilla.org
a70e7bcb8b fix for bug #385990: bail out early of command updating for history queries
r=dietrich
2007-07-10 09:20:54 -07:00
mozilla.mano@sent.com
07b1baf1c4 Bug 386876 - hide the always disabled 'New Bookmark...' menu item from the history sidebar. r=sspitzer. 2007-07-09 15:54:58 -07:00
thunder@mozilla.com
4c812e94be Bug 334408: Fix broken test. r=gavin 2007-07-08 20:56:44 -07:00
thunder@mozilla.com
e249c6ee74 Bug 334408: Import/export the last charset used to bookmarks.html. r=mano 2007-07-08 19:22:50 -07:00
philringnalda@gmail.com
812d6a9f76 Bug 327748 - Bookmark Properties dialog missing keyboard accesskeys, patch by Ehsan Akhgari <ehsan.akhgari@gmail.com>, r=mano 2007-07-08 18:36:03 -07:00
jwalden@mit.edu
e3c4baccae Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
sspitzer@mozilla.org
b301ce9ef5 fix for bug #373207 l10n: rename entity / properties that changed due to bug #373211 (search.all.label, cmd.find.label, places.title, etc)
patch=Steve Won <swon@mozilla.com>

r=sspitzer
2007-07-06 18:17:21 -07:00
sspitzer@mozilla.org
a2f891b8b3 fix for bug #334244: Click-drag-release on bookmarks toolbar folder drags the folder
patch=Steve Won <swon@mozilla.com>

r=dietrich
2007-07-06 18:12:37 -07:00
sspitzer@mozilla.org
bc972863cd fix for bug #386705: Description field of new bookmark is not populated even though it has <META name="description" content="...">
fix by=Marco Bonardo <mak77@supereva.it>

r=sspitzer
2007-07-03 08:39:33 -07:00
mozilla.mano@sent.com
7b934b2314 Bug 262329 - Sort By Name should sort between separators. r=sspitzer. 2007-07-01 05:23:38 -07:00
mozilla.mano@sent.com
9e50ac2d58 Bug 386159 - Menu-view performance improvements. r=dietrich, a=mconnor. 2007-06-28 13:33:21 -07:00
dietrich@mozilla.com
d429b8c71d backing out, per mano 2007-06-28 11:56:37 -07:00
dietrich@mozilla.com
f812d9d6ea Bug 386159 Menu-view performance improvements (for mano, r=dietrich) 2007-06-28 11:22:37 -07:00
mozilla.mano@sent.com
f136101493 Attempt to fix bug 385545 - toolbar folder contents aren't visible some time after loading. r=dietrich, a=mconnor. 2007-06-27 23:50:46 -07:00
sspitzer@mozilla.org
a4c02456ab fix for bug #381751: when I drop a bookmark or link in the sidebar or bookmark manager dialog, it frequently doesn't go where I expect it to go
fix for bug #385970:  Drag and drop around folders reacts incorrectly to mouse position

fix for bug #382679:  moving items in the organizer down are off by 1

patch by=Christine Yen <cyen@mozilla.com>

r=sspitzer
2007-06-26 18:38:50 -07:00
dtownsend@oxymoronical.com
4dad1c1885 Bug 247116 - Web pages bounce/shake/jump (places version of patch). r=mano 2007-06-26 18:13:28 -07:00
sspitzer@mozilla.org
2aafb0b267 fix for bug #382118: New separators cannot be deleted
patch=Christine Yen <cyen@mozilla.com>

r=sspitzer
2007-06-26 17:02:17 -07:00
sspitzer@mozilla.org
590f31b086 fix for bug #383840: problems when manually importing bookmarks exported from places based bookmark builds
fix for bug #381225:  on import, places bookmarks builds attempt to merge in bookmarks.html, where firefox 2 appends bookmarks

fix for bug #380449:  potential data loss on export of LAST_MODIFIED, DATE_ADDED and ICON_URI attributes

r=dietrich
2007-06-25 19:38:34 -07:00
mozilla.mano@sent.com
1b25d4835a Bug 385614 - Assert like mad when deleting Livemarks from left pane in the BM. r=dietrich. 2007-06-24 17:00:17 -07:00
sspitzer@mozilla.org
853359a4e9 fix for bug #384731: "Bookmark This Page" throws exception on close in bookmarkProperties.js if you have "bookmarkPropertiesDialog/lastUsed" annotations that point to itemIds for folder that don't exist
fix for bug #384733:  "Add Bookmark" dialog truncated if you have "bookmarkPropertiesDialog/lastUsed" annotations that point to itemIds for folder that don't exist

r=mano
2007-06-22 16:19:47 -07:00
sspitzer@mozilla.org
9cffddc61a backing out fix for bug #373944 as it causes a performance regression, see bug #385208 2007-06-20 15:46:54 -07:00
sspitzer@mozilla.org
ae49d2b81b fix for bug #373944: revert the workarounds for bug #373719, bug #373721, bug #374150 and bug #374166 caused by bug #267833.
Now that bug #373756, it is safe to do this.  But note, even when I revert the fix for bug #373756, I am not seeing the problems we saw after bug #267833 first landed.

r=mano
2007-06-20 00:43:51 -07:00
mozilla.mano@sent.com
a956febc57 Fix typo. 2007-06-20 00:27:41 -07:00
sspitzer@mozilla.org
7228bda8ed fix for bug #380735: Persist open state of the "age in days" and "site" containers in the history sidebar
r=dietrich
2007-06-19 22:19:06 -07:00
sspitzer@mozilla.org
8847d7a2d8 fix for bug #383572: changes made to bookmarks don't show in bookmark searches / Crash [@ nsCOMArray_base::InsertObjectAt nsNavHistoryFolderResultNode::OnItemChanged] deleting "ghost" bookmark
r=dietrich
2007-06-19 09:25:11 -07:00
sspitzer@mozilla.org
dc733c8c66 supplimental checkin for bug #383681: While BM is in a sorted view, adding a new separator is added below the position index, not the bookmark.
r=mano
2007-06-19 09:13:19 -07:00
sspitzer@mozilla.org
d4db964d77 fix for bug #383681: While BM is in a sorted view, adding a new separator is added below the position index, not the bookmark.
disable the "insert separator" from a sorted view and from views that are excluding items.

patch=Christine Yen <cyen@mozilla.com>

r=sspitzer
2007-06-18 21:19:39 -07:00
mozilla.mano@sent.com
df5b1d76e7 Bug 384936 - Folders in bookmarks menu are inaccessible after moving a bookmark to/in the menu. r=sspitzer. 2007-06-18 19:25:41 -07:00
sspitzer@mozilla.org
006402d0e9 fix for bug #384671: when resetting the history sidebar view, don't use applyFilter()
this is needed for bug #380735, for when we persist day and host container
open state in the history sidebar.

additionally, call load() instead of using .place directly to avoid doing queriesToQueryString() only to call queryStringToQueries().

r=mano
2007-06-18 18:31:51 -07:00
mozilla.mano@sent.com
24c272f8c2 Bug 384763 - left click broken in bookmarks menu. r=ssptizer. 2007-06-18 17:16:09 -07:00
sspitzer@mozilla.org
0314d1b6da fix for bug #384677: for history sidebar and history menu, don't specify begin / end times
r=dietrich
2007-06-18 17:08:17 -07:00
kherron@fmailbox.com
264271c49e Backing out patch for bug 376991. 2007-06-17 08:09:44 -07:00
kherron@fmailbox.com
629f5b5d26 Bug 367991 - Remove the places-specific calendar widget. Patch by Asaf Romano <mano@mozilla.com>, r=sspitzer. 2007-06-17 05:52:56 -07:00
mozilla.mano@sent.com
2104094fcf Bug 384690 - bookmarks menu is broken. r=dietrich. 2007-06-16 20:14:08 -07:00
kherron@fmailbox.com
3ef7e96849 Bug 381329 - Build fails with GCC-4.3 due to extra semi-colons and '-pedantic' flag. Patch by Art Haas <ahaas@airmail.net>. r+sr=roc. 2007-06-16 12:53:59 -07:00
sspitzer@mozilla.org
2f0c4a4330 fix for bug #382136: in Bookmarks Menu - delete separator at bottom position, deletes bookmark
r=dietrich
2007-06-15 22:07:42 -07:00
sspitzer@mozilla.org
623aced10e fix for bug #384670: current collection searches in bookmark organizer window search all of bookmarks
r=dietrich
2007-06-15 22:03:40 -07:00
mozilla.mano@sent.com
7d4df6bb57 Bug 384515 - ASSERT: null node when moving the root node in a places tree. r=dietrich. 2007-06-15 18:55:15 -07:00
mozilla.mano@sent.com
56a3006a8d Bug 337855 - Don't rebuild places menus on each open. patch by seth, dietrich & me, r=dietrich/me. 2007-06-15 18:53:06 -07:00