Commit Graph

189 Commits

Author SHA1 Message Date
L. David Baron
5efb37b7c1 Make cycle collector's purple buffer consist of entries that the objects in the purple buffer can point to, and remove the notion of scan delay (which was previously set to 0). (Bug 490695) r+sr=peterv r=bsmedberg 2009-05-06 13:46:04 -07:00
L. David Baron
a8fbab994c Use the purple buffer in ExplainLiveExpectedGarbage. (Bug 488603) r+sr=peterv 2009-04-24 15:45:34 -07:00
L. David Baron
1d193a2b78 Reverse the meaning of suspectCurrentCount and rename it to expectedGarbageCount. (Bug 488603) r+sr=peterv 2009-04-24 15:45:34 -07:00
L. David Baron
23e03f54d1 When we print warnings about objects that should have been collected, see if they're in the purple buffer and print different warnings if they are. (Bug 488603) r+sr=peterv 2009-04-24 15:45:34 -07:00
Peter Van der Beken
5832c7c26e Fix for bug 423473 (Cycle collector should restart after getting a fault). r/sr=jst.
--HG--
extra : rebase_source : fd82c02bef434c36383df0862af2399455caa65b
2009-04-09 14:02:48 +02:00
Robert O'Callahan
e4d777c4ce Bug 475023. Fix DEBUG_CC compilation for nsCStringArray removal. r+sr=roc
--HG--
extra : rebase_source : e217b220febb4a5770efb562580210992fa88126
2009-01-30 20:16:16 +13:00
Fred Jendrzejewski
8759b06c00 Bug 466622. Replace nsCStringArray with nsTArray<nsCString> for more consistent code and fewer heap allocations. r+sr=roc,r=bsmedberg
--HG--
extra : rebase_source : b963bf5de9d9c445b14620479691482512e0faf2
2009-01-22 17:15:34 +13:00
Arpad Borsos
8b11d938d2 Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan 2008-10-10 17:04:34 +02:00
Peter Van der Beken
c993fed597 Address review comment for bug 423471 - Cycle collection shouldn't fault when traversing script objects of languages that don't participate. r/sr=dbaron. 2008-06-21 19:47:46 +02:00
Peter Van der Beken
b222a800ca Bug 423471 - Cycle collection shouldn't fault when traversing script objects of languages that don't participate. r/sr=dbaron. 2008-06-21 17:25:29 +02:00
dbaron@dbaron.org
e0f067e2c8 Print shortest path to expected garbage for unlink deficiencies as well. b=422848 r+sr=peterv a=DEBUG_CC only (not part of default build) 2008-03-27 10:09:51 -07:00
dbaron@dbaron.org
537f2f5b13 Add knowledge of edge names to cycle collector, ifdef DEBUG_CC. b=420514 r+sr=peterv a=damons 2008-03-17 16:11:08 -07:00
dbaron@dbaron.org
d65e4ef335 Fix DEBUG_CC bustage on Windows resulting from bug 402966 (and bug 407034). r+sr=peterv a=Not part of the default build (DEBUG_CC only) 2008-03-07 09:55:51 -08:00
Olli.Pettay@helsinki.fi
5bf8e82603 Bug 415025, try to improve CC scheduling, r=peterv, sr=jst 2008-02-25 09:47:25 -08:00
dougt@meer.net
c8c57fc064 Fixes for Windows CE. b=418662, r=bsmedberg, a=damons 2008-02-22 16:22:47 -08:00
bent.mozilla@gmail.com
45df174c7f Bug 414977 - "insufficient unlink methods in some DOM classes?". Move the warning until after XPConnect deferred releases, r=dbaron, sr=peterv, a=blocking1.9+. 2008-02-22 12:25:12 -08:00
peterv@propagandism.org
1b59a2020d Fix DEBUG_CC builds. 2008-02-15 14:23:16 -08:00
peterv@propagandism.org
a61edec0f0 Fix for bug 405128 (Remove some nsDeque use from cycle collector). r/sr=dbaron, a=beltzner. 2008-02-15 05:12:55 -08:00
dbaron@dbaron.org
6520043418 Warn when Unlink doesn't do what it should. b=414972 r+sr=peterv a=not part of default build (DEBUG_CC only) 2008-02-08 11:48:51 -08:00
peterv@propagandism.org
6d9909d3c6 Fix for bug 407034 (JS_Assert "!rt->gcRunning" unbinding link elements in cycle collector with JS protocol handlers), r/sr=dbaron. 2008-01-29 18:05:43 -08:00
peterv@propagandism.org
ac2b416a74 Try to fix orange 2008-01-29 13:42:05 -08:00
peterv@propagandism.org
02be459ead Fix for bug 407034 (JS_Assert "!rt->gcRunning" unbinding link elements in cycle collector with JS protocol handlers), r/sr=dbaron. 2008-01-29 12:48:32 -08:00
reed@reedloden.com
d36f99afff Bug 376530 - "Fix CycleCollector building with uClibc library" [p=romaxa@gmail.com (romaxa) r+sr=peterv a1.9=schrep] 2008-01-21 16:17:41 -08:00
dbaron@dbaron.org
1757dd0834 Fix DEBUG_CC bustage treating all XPConnect roots as expected garbage. b=410116 r+sr=peterv Not part of default build (DEBUG_CC-only). 2008-01-11 14:24:04 -08:00
dbaron@dbaron.org
6551d2d4c3 Fix DEBUG_CC bustage from bug 402966. All changes #ifdef DEBUG_CC (not part of the default build). 2008-01-10 14:27:07 -08:00
peterv@propagandism.org
bd933a00a4 Fix for bug 402966 (JS_Assert "!rt->gcRunning"). r/sr=dbaron. 2008-01-10 06:10:03 -08:00
mozilla@weilbacher.org
fcb3808c78 [OS/2] Bug 404407: improve memory consumption on OS/2. Part 1, call heapmin after cycle collection, r=dbaron 2008-01-09 13:14:08 -08:00
bzbarsky@mit.edu
cdc3680e78 Report cycle collector faults to the error console and the observer service. Bug 410295, r+sr=peterv, a=schrep 2008-01-06 14:05:10 -08:00
jruderman@hmc.edu
8f16e0d9c1 Fix DEBUG_CC compilation error (bug 410036). r+sr=peterv, a=blocking1.9+. DEBUG_CC-only change. 2008-01-04 19:57:09 -08:00
jst@mozilla.org
858f753261 Landing patch for bug 401687. Stop reference counting JS objects in the cycle collector. Patch by peterv@propagandism.org, r+sr=dbaron@mozilla.com,igor@mir2.org, a=dsicore@mozilla.com 2007-11-01 15:51:57 -07:00
Olli.Pettay@helsinki.fi
a78cbac9b4 Landing (again) Bug 373462, bug 385322, Better scheduling of cycle collection/gc, r+sr=sicking,jst 2007-10-22 14:42:25 -07:00
Olli.Pettay@helsinki.fi
69d3a1fc7a backout Bug 373462, bug 385322. Still regress tp/talos 2007-10-21 09:46:54 -07:00
Olli.Pettay@helsinki.fi
cad8f0b8c4 Test-landing (again) Bug 373462, bug 385322, Better scheduling of cycle collection/gc, r+sr=sicking,jst 2007-10-21 07:09:29 -07:00
Olli.Pettay@helsinki.fi
2fb8ea7b56 back out Bug 373462 / bug 385322 (again :( ) 2007-09-29 10:33:22 -07:00
Olli.Pettay@helsinki.fi
a6aedd78ae Bug 373462 / bug 385322, Better scheduling of cycle collection/gc, r+sr=jst 2007-09-29 08:02:57 -07:00
Olli.Pettay@helsinki.fi
f9c785fb8b backout the test patch for Bug 373462 and 385322 2007-09-23 09:10:12 -07:00
Olli.Pettay@helsinki.fi
1d42d7ad32 Testland a patch for Bug 373462 and 385322, 'Better scheduling of cycle collection/gc' 2007-09-23 07:05:27 -07:00
Olli.Pettay@helsinki.fi
3d3dee855b backout patch for Bug 373462, Bug 385322 2007-09-21 03:00:47 -07:00
Olli.Pettay@helsinki.fi
08d334c65d Bug 373462, Bug 385322, Better scheduling of cycle collection/gc, r=jst, sr=sicking, a=sicking 2007-09-21 01:54:36 -07:00
dbaron@dbaron.org
39d72c1b19 Remove incorrect use of NS_METHOD. b=394566 r+sr=peterv a=bzbarsky 2007-09-17 17:30:06 -07:00
jwalden@mit.edu
287840b3af Unbreak DEBUG_CC on Windows (calling convention mismatch); apparently nobody really uses it there. NPOTDB, rs=sicking 2007-08-30 14:47:26 -07:00
dbaron@dbaron.org
bb94f6cdcf Fix bustage. 2007-08-22 18:29:54 -07:00
dbaron@dbaron.org
c7baafe98b Print path to expected garbage along with refcount imbalances. b=387224 r=graydon a=brendan 2007-08-22 17:47:47 -07:00
dbaron@dbaron.org
1a55872e93 When doing ExplainLiveExpectedGarbage, suspect all nsXPCWrappedJS so that we get more objects in the graph. b=387224 r=graydon a=brendan 2007-08-22 17:47:24 -07:00
dbaron@dbaron.org
456ce4796e Make ExplainLiveExpectedGarbage print *all* references to JS objects with refcount imbalances. b=387224 r=graydon a=brendan 2007-08-22 17:46:43 -07:00
benjamin@smedbergs.us
0e047142a4 Bug 386025 - Expose cycle-collection symbols, r=graydon 2007-08-06 07:34:02 -07:00
dbaron@dbaron.org
afa55bb19c Explain another possibility in this debugging printf. DEBUG_CC only. 2007-07-14 12:06:10 -07:00
dbaron@dbaron.org
044741fe41 Make ExplainLiveExpectedGarbage traverse the suspectCurrent roots, since now that it's more accurate, more graph is always better. b=387005 r=graydon 2007-07-08 12:26:44 -07:00
jwalden@mit.edu
e3c4baccae Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
dbaron@dbaron.org
174c979c27 Make Fault give more information, #ifdef DEBUG_CC. b=386947 r=graydon 2007-07-05 15:38:38 -07:00
dbaron@dbaron.org
8e293c01db In ExplainLiveExpectedGarbage, print only the externally-referenced nodes from which the expected garbage is reachable. b=387005 r=graydon 2007-07-05 15:20:16 -07:00
dbaron@dbaron.org
2f9c58d2d1 Make suspectCurrent assertion not fire constantly after we Fault. b=386664 r+sr=peterv 2007-07-03 14:21:57 -07:00
dbaron@dbaron.org
ad25bf5b7f Change cycle collector aging constant from 10 to 0. b=381199 r+sr=peterv 2007-06-27 13:41:26 -07:00
dbaron@dbaron.org
eb0effca3c Fix gcc warning about casting string literal to char*, DEBUG-only. 2007-06-27 13:40:52 -07:00
dbaron@dbaron.org
c406f481be Keep the purple bit in sync with the purple buffer when suspect and forget calls are dropped on the floor. b=385548 r=graydon 2007-06-27 10:51:48 -07:00
dbaron@dbaron.org
32b9b04c86 Back out 385548 to try to fix test orange. 2007-06-26 22:26:38 -07:00
dbaron@dbaron.org
02448989cf Don't set the purple bit when suspect calls are dropped on the floor. b=385548 r=graydon 2007-06-26 21:47:40 -07:00
dbaron@dbaron.org
eb732c3fce Print the warning message for failure to suspect or unlink only for the objects that are the roots of what would have been collected. b=385549 r=graydon 2007-06-25 13:36:24 -07:00
dbaron@dbaron.org
86b826726a Back out again. 2007-06-21 17:30:41 -07:00
dbaron@dbaron.org
1b35379c96 See if using mScanDelay of 1 instead of 0 fixes the leak regression. 2007-06-21 16:49:37 -07:00
dbaron@dbaron.org
8a1ffc4a83 Change cycle collector aging constant from 10 to 0. b=381199 r+sr=peterv 2007-06-21 16:02:53 -07:00
graydon@mozilla.com
16a5902d61 Bug 384942, dump graph on cycle collection fault.
r=dbaron
2007-06-18 18:29:10 -07:00
dbaron@dbaron.org
d4580a96f6 Back out bug 381199. 2007-06-13 17:12:16 -07:00
dbaron@dbaron.org
315c9bfadc Change cycle collector aging constant from 10 to 0. b=381199 r+sr=peterv 2007-06-13 16:22:19 -07:00
peterv@propagandism.org
2646ce169d Fix for bug 383651 (Re-entrancy into nsCycleCollector::Collect can result in a crash). Patch by ak.miller@auckland.ac.nz, r=graydon, sr=dbaron. 2007-06-08 03:17:21 -07:00
dbaron@dbaron.org
bcec47ef49 Don't loop through all the possible shutdown collections when we suspect all native wrappers. b=383234 r+sr=peterv 2007-06-06 15:09:00 -07:00
dbaron@dbaron.org
56b18ce3b6 Shutdown in one cycle when we set mScanDelay to 0. b=383234 r+sr=peterv 2007-06-06 15:08:25 -07:00
dbaron@dbaron.org
df22213243 strdup when allocating mName so we have useful pointers. b=383234 r+sr=peterv 2007-06-06 15:07:29 -07:00
dbaron@dbaron.org
ace8e8711d Print info about things that are suspected on the extra collections at shutdown to catch deficiencies in traversal that cause us to need the extra collections. b=383234 r+sr=peterv 2007-06-06 15:06:56 -07:00
dbaron@dbaron.org
99dfb4bbf6 When explaining why expected garbage was not collected, list the known references when some were unknown. b=383234 r+sr=peterv 2007-06-06 15:06:00 -07:00
dbaron@dbaron.org
747b9fa729 Make DEBUG_CC compile again. b=383234 r+sr=peter 2007-06-06 15:04:26 -07:00
peterv@propagandism.org
98955fbcad Fix for bug 368774 (Make cycle collector work with refcounted non-XPCOM objects). r=dbaron, sr=sicking. 2007-05-24 07:10:02 -07:00
jonas@sicking.cc
36cb23b6c1 Relanding bug 378987. Don't try to collect windows, documents or elements of actively viewed pages. r=bz/jst sr=jst 2007-05-10 13:21:12 -07:00
jst@mozilla.org
bdfbc4a316 Backing out Jonas' last changes due to tinderbox orange, per Jonas' request. 2007-05-09 17:42:33 -07:00
jonas@sicking.cc
ccae61e56a Relanding bug 378987. Don't try to collect windows, documents or elements of actively viewed pages. r=bz/jst sr=jst 2007-05-09 16:33:28 -07:00
jonas@sicking.cc
1c214cc3a2 back out last patch since leaks went through the roof 2007-05-07 18:03:08 -07:00
jonas@sicking.cc
9179b005a4 Don't attempt to cycle collect documents, windows and elements that are currently being viewed. r=bz, sr=jst b=378987 2007-05-07 16:45:25 -07:00
dbaron@dbaron.org
0f8b649a97 Remove extra class names to address Neil's comments. b=378514 2007-05-03 16:07:26 -07:00
dbaron@dbaron.org
c7cfb02cfd Record results of cycle collection traversal so we only have to call the traversal APIs once per collection. b=378514 sr=peterv r=graydon 2007-04-25 14:12:11 -07:00
peterv@propagandism.org
44535293b8 Fix for bug 376854 (CycleCollector depends on uninitialized values (ageSelectionCallback and nsPurpleBuffer::BumpGeneration)). r/sr=dbaron. 2007-04-25 11:33:55 -07:00
dbaron@dbaron.org
436a51a9c7 Followup fixes to making cycle collector use more efficient hashtables: shrink size of table and fix warnings on 64-bit machines. b=377606 sr=peterv r=graydon 2007-04-23 16:34:33 -07:00
peterv@propagandism.org
fa1d45ea66 Fix for bug 372110 (Make cycle-collection debugging features optional at compile time). r=graydon, sr=jst. 2007-04-21 10:43:19 -07:00
peterv@propagandism.org
6d262baa21 Reorder members to make struct smaller and try to lower MH down again. 2007-04-20 01:51:31 -07:00
peterv@propagandism.org
01dc49f9b9 Fix for bug 377606 (Switch cycle collector to more efficient hashtables). Patch by graydon, r=peterv, sr=dbaron. 2007-04-20 01:01:01 -07:00
peterv@propagandism.org
7498a7fcd9 Fix for bug 373693 (Cycle collector makes AddRef about 6x slower). r=graydon, sr=dbaron. 2007-04-18 03:10:35 -07:00
peterv@propagandism.org
d1329c5052 Fix for bug 375075 (Stop leaking the cycle collector on shutdown). r=bsmedberg, sr=dbaron. 2007-03-27 02:49:06 -07:00
peterv@propagandism.org
a48211b9d5 Backing out change for debugging tinderbox orange. 2007-03-23 09:10:21 -07:00
peterv@propagandism.org
821b938944 Temporarily enable cycle collection timing for debug builds to figure out tinderbox orange. Will back out after qm-xserve01 tinderbox has cycled. 2007-03-23 08:11:53 -07:00
hg@mozilla.com
465265d0d4 Free the (distributed) Lizard! Automatic merge from CVS: Module mozilla: tag HG_REPO_INITIAL_IMPORT at 22 Mar 2007 10:30 PDT, 2007-03-22 10:30:00 -07:00