Commit Graph

84 Commits

Author SHA1 Message Date
Kartikaya Gupta
fbe4beb181 Bug 715326 - Fix viewport position when zooming up a page that is smaller than the viewport on both axes. r=pcwalton
Take a page that has width PW and height PH, where PW is less
than the viewport width VW and PH is less than the viewport height
VH, and VW/PW > VH/PH. If we scale this up to fit the viewport,
then the vertical viewport position ends up scrolled to the bottom
(or partway to the bottom depending on how long the page is). This
fixes that by shifting the focal point in this case.
2012-01-12 22:47:56 -05:00
Kartikaya Gupta
bb00f53b94 Bug 713011 - Add a check to ensure we are running on the correct thread. r=blassey 2012-01-11 17:08:14 -05:00
Kartikaya Gupta
d22dffb0d4 Bug 716673 - Fix up copyright and authors. r=pcwalton 2012-01-10 10:06:11 -05:00
Kartikaya Gupta
81aff56834 Bug 716673 - Pull out duplicated hard-coded strings as static variables. r=pcwalton 2012-01-10 10:06:10 -05:00
Kartikaya Gupta
62222ffa24 Bug 716673 - Split out the Axis class from the PanZoomController. r=pcwalton 2012-01-10 10:06:08 -05:00
Kartikaya Gupta
e8461b8c51 Bug 716673 - Split out a SubdocumentScrollHelper from the PanZoomController. r=pcwalton 2012-01-10 10:06:05 -05:00
Kartikaya Gupta
47ca55bbb5 Bug 716673 - Encapsulate the fling state in Axis. r=pcwalton 2012-01-10 10:06:03 -05:00
Kartikaya Gupta
2d917018bf Bug 716673 - Encapsulate the velocity, locked, and disableSnap variables in Axis. r=pcwalton 2012-01-10 10:06:01 -05:00
Kartikaya Gupta
8a93b6f933 Bug 716673 - Use the locked velocity instead of unlocked velocity in a couple of places. r=pcwalton 2012-01-10 10:05:59 -05:00
Kartikaya Gupta
b927405877 Bug 716673 - Fix up the advanceFling() step. r=pcwalton
- Refactor the code a little to ensure we don't do any flinging
  if the panning is being overridden.
- Collapse duplicated/inconsistent code in the fling-termination
  conditions so that it makes sense now.
2012-01-10 10:05:57 -05:00
Kartikaya Gupta
78ab72ec22 Bug 716673 - Collapse unused WAITING_TO_SNAP and SNAPPING flingstates into STOPPED. r=pcwalton 2012-01-10 10:05:55 -05:00
Kartikaya Gupta
ce93ccd236 Bug 716673 - Completely encapsulate Axis variables lastTouchPos and touchPos. r=pcwalton 2012-01-10 10:05:53 -05:00
Kartikaya Gupta
37b010df8a Bug 716673 - Completely encapsulate Axis variable firstTouchPos. r=pcwalton 2012-01-10 10:05:51 -05:00
Kartikaya Gupta
cbc7a48aaa Bug 716673 - Refactor some more duplicated code from the track() functions. r=pcwalton 2012-01-10 10:05:49 -05:00
Kartikaya Gupta
373c8a080c Bug 716673 - Refactor some repeated code into a startTouch method. r=pcwalton 2012-01-10 10:05:48 -05:00
Kartikaya Gupta
8f611820ca Bug 716673 - Misc cleanups in PanZoomController. r=pcwalton
- Remove unused imports.
- Move all class variables together, and make some final.
- Fix up some comments.
- Remove unused methods.
- Remove some dead code
- Move some functions around so they are grouped based on behaviour.
2012-01-10 10:05:46 -05:00
Kartikaya Gupta
6c1ed49ef0 Bug 716673 - Remove some dead code. r=pcwalton
Events that come in for the non-primary pointer are ACTION_POINTER_DOWN
rather than ACTION_DOWN, so this code will never get exercised.
2012-01-10 10:05:43 -05:00
Kartikaya Gupta
149e223a11 Bug 716673 - Refactor some code that sends messages to Gecko. r=pcwalton 2012-01-10 10:05:42 -05:00
Kartikaya Gupta
67cf21cbba Bug 716673 - Remove unnecessary finalize() function. r=pcwalton
The finalize will never be called because GeckoAppShell holds
on to the PZC (as a GeckoEventListener) thereby preventing it
from ever getting GC'd.
2012-01-10 10:05:40 -05:00
Chris Peterson
200596fe4c Bug 714874 - Fix Java warnings about redundant casts. r=pcwalton r=dougt a=dougt 2012-01-06 12:21:49 -08:00
Chris Peterson
c4b1d936b9 Bug 714874 - Fix some Java warnings. r=dougt a=dougt 2012-01-05 10:49:33 -08:00
Kartikaya Gupta
bbadda79a3 Bug 715164 - Guard against another race condition in PZC. r=pcwalton 2012-01-05 18:13:25 -08:00
Kartikaya Gupta
5a5c192707 Bug 715011 - Ensure that panning of subwindows can still happen while the top window is locked on one or both axes. r=Cwiiis 2012-01-04 13:25:11 -05:00
Patrick Walton
463cb8081a Bug 709492 - Part 3: Tie viewport updates to drawing to avoid page transition flicker. r=kats 2012-01-03 22:55:04 -08:00
Mark Finkle
7cc92e7c95 Bug 714711 - A few unused local variables in PanZoomController.onScaleEnd [r=kats] 2012-01-03 12:19:49 -05:00
Kartikaya Gupta
a36adcca90 Bug 713586 - Robustify against undetected race conditions. r=pcwalton
The exception in bug 713586 can only occur if there are race conditions
in the PanZoomController that we haven't fixed yet. Until the race conditions
are fixed, we can robustify the code from dying horribly by making
the bounce-related variables local to the BounceRunnable, so that
different BounceRunnables running concurrently don't interfere with each
other.
2012-01-02 19:06:49 -05:00
Patrick Walton
dfec4981df Backed out bug 709492 due to breakage with external urls. r=backout 2011-12-30 18:47:06 -05:00
Kartikaya Gupta
05156a1fb5 Bug 713729 - Ensure that a fling is in progress when doing velocity-based fling adjustments. r=pcwalton 2011-12-29 22:29:16 -05:00
Patrick Walton
84ee2f57dd Bug 709492 - Part 4: Hide the page when navigating, and expose it when the new page appears. r=kats 2011-12-29 15:10:30 -08:00
Kartikaya Gupta
20d96ebe14 Bug 712386 - Limit how much zoom can be applied. r=Cwiiis 2011-12-27 00:56:57 -05:00
Geoff Lankow
c46fa0acaf Backed out 3 changesets (bug 710297, bug 712386, bug 712761) for perma-orange on Android native m1 and m2
Backed out changeset 3b1e6033d3ff (bug 712761)
Backed out changeset bb41941cdf9d (bug 710297)
Backed out changeset d4f9960e286a (bug 712386)
2011-12-28 01:00:02 +13:00
Margaret Leibovic
07e8d1406f Bug 711216 - Form autocomplete popup doesn't disappear when input gets out of view after pinch zoom [r=mfinkle] 2011-12-21 17:03:21 -08:00
Kartikaya Gupta
88063c04a6 Bug 712386 - Limit how much zoom can be applied. r=Cwiiis 2011-12-27 00:56:57 -05:00
Kartikaya Gupta
00b68564c6 Bug 711453 - Fix infinite zoom scale. r=pcwalton 2011-12-20 17:15:09 -05:00
Kartikaya Gupta
e475dfb3a6 Bug 709817 - Don't clobber mState if animations are aborted. r=pcwalton
Ensure that if the animation is aborted by changing the value of
mState (such as if we get an onTouchStart and set the mState to
TOUCHING), then we don't clobber it and set it back to NOTHING.
Only set it back to NOTHING when the animation finishes normally.
2011-12-20 16:53:39 -05:00
Kartikaya Gupta
b74f03c21e Bug 709817 - Ensure PZC is always accessed on the UI thread. r=pcwalton
Ensure that all public functions in PZC are always called from
the UI thread, so that internal variables are not mutated on
different threads. I also made animatedZoomTo private so that
it can't be inadvertently called from a non-UI thread outside
the class.
2011-12-20 16:53:39 -05:00
Kartikaya Gupta
6a504879ae Bug 709817 - (Cleanup) Replace geometryChanged() with abortAnimation() and remove dead calls. r=pcwalton
Since the geometryChanged function does nothing if the parameter passed
in is false, better to rename the function to be more indicative of
what it actually does, and remove all the resulting dead code.
2011-12-20 16:53:39 -05:00
Kartikaya Gupta
2082d75da1 Bug 712037 - Add lots of logging to help diagnose viewport issues. r=Cwiiis 2011-12-19 22:32:41 -05:00
Kartikaya Gupta
4947890040 Bug 711232 - Avoid unnecessary bounce animations. r=pcwalton 2011-12-16 17:01:02 -05:00
Kartikaya Gupta
3a22a4cc3c Bug 711453 - Avoid potentially corrupting the fling velocity. r=pcwalton 2011-12-19 09:26:41 -05:00
Doug Turner
42115e5a4e Backout of 9d027bf631d3 2011-12-17 21:52:54 -08:00
Kartikaya Gupta
11ed3102a7 Bug 711232 - Avoid unnecessary bounce animations. r=pcwalton 2011-12-16 17:01:02 -05:00
Patrick Walton
50bfe0d0b5 Bug 710119 - Use a low friction for long flings and a high friction for short ones. r=Cwiiis 2011-12-15 12:04:49 -08:00
Kartikaya Gupta
b663bbf45e Bug 708893 - Allow panning after releasing pinch zoom finger. r=pcwalton 2011-12-15 14:50:04 -05:00
Kartikaya Gupta
31486683a9 Bug 710393 - Stop using Math.copySign which doesn't exist on Froyo. r=Cwiiis a=ehsan 2011-12-14 16:57:29 -05:00
Sriram Ramasubramanian
efefacb497 Bug 695444 - Form history autocomplete. r=mfinkle a=android-only 2011-12-06 16:44:08 -08:00
Patrick Walton
2adc6acc0a Bug 710096 - Hold the monitor on the layer controller when adjusting and rendering the viewport metrics. r=Cwiiis a=java-only 2011-12-13 14:43:08 -08:00
Doug Turner
9cc75f8b7b Bug 709595 - Add a name for each java thread and timer to aide with debugging. r=blassey
--HG--
extra : rebase_source : 1f5472ef5301739425b162d5ce4b28a577daf0fb
2011-12-12 16:27:35 +08:00
Chris Lord
baa353615d Bug 705092 - Kinetic scrolling is too slow. r=pcwalton a=java-only
This introduces a friction factor, so that the deceleration is relative to
the current velocity. Now, the faster you scroll, the slower the view
decelerates, allowing you to page through longer pages easier.
2011-12-12 18:56:15 +00:00
Kartikaya Gupta
46f2f122ed Bug 704738 - Resize page content on device rotation. r=Cwiiis a=java-only
Some cleanup: ensure we abort and re-bounce the viewport
if the device is rotated during a double-tap zoom. Also
rename variables to be more appropriate
2011-12-12 11:22:34 -05:00