Commit Graph

360 Commits

Author SHA1 Message Date
Ed Morley
7bc582f20f Backout 4997c6f8b24d (bug 616542) for causing locally run mochitest-browser-chrome test runs to fail 2011-11-05 18:35:59 +00:00
Rail Aliiev
8a56fd9db2 Bug 616542 - Shorten file path length of mochitest; r=ted 2011-11-04 21:13:42 +00:00
Ms2ger
46522f17ea Bug 697210 - Part c: Remove nsIDocument::CreateElem's aDocumentDefaultType argument; r=bz 2011-10-29 22:21:20 +02:00
Ms2ger
b063085157 Bug 690120 - Make nsEditor::GetAttributeValue not use attribute nodes; r=ehsan 2011-10-29 22:19:27 +02:00
Ms2ger
731edba0b8 Bug 684821 - Remove nsIDOMNSHTMLElement; r=peterv 2011-10-29 22:03:55 +02:00
Ehsan Akhgari
dbe53002d5 Backout changeset be42bc18185a (bug 612128) because of bug 688423 2011-10-25 22:32:55 -04:00
Ehsan Akhgari
574c7ff0d7 Backout changeset a4d5ca366ef1 (bug 612128 followup) because of bug 688423 2011-10-25 22:31:15 -04:00
Ehsan Akhgari
7190838338 Bug 612128 followup - Adjust the assertion count because bug bug 695364 should be fixed now 2011-10-20 14:01:12 -04:00
Ehsan Akhgari
317cb20a80 Bug 612128 - Prevent the editor from modifying nodes which are not under an editing host; r=roc,bzbarsky
This patch ensures that the NODE_IS_EDITABLE flag is only set on nodes living
under an editing host.  Things like text controls which used to have that flag
previously will not have it any more.  The flag would be set on their anonymous
div node instead.  Note that if text controls actually fall under an editing
host, they will get the NODE_IS_EDITABLE flag.

This patch also makes nsHTMLEditor::IsEditable return sane results (text nodes
are always considered to be editable).

--HG--
extra : rebase_source : 37317b4d95c2ea957be81420583a98a24f0864ac
2010-11-16 15:45:49 -05:00
Ehsan Akhgari
568b8f7b5a Bug 688789 - Stop touching the frame tree to determine whether a node is editable or not; r=roc 2011-10-17 00:11:29 -04:00
Ehsan Akhgari
2a602a5685 Bug 690892 - Replace PR_TRUE/PR_FALSE with true/false on mozilla-central; rs=dbaron
Landing on a CLOSED TREE
2011-10-17 10:59:28 -04:00
Quentin Headen
2fe3ac75d0 Bug 364914 - Do not spell check the contents of a textarea until it's focused for the first time; r=ehsan 2011-10-16 22:06:24 -04:00
Michael Wu
d8e503c38b Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones
--HG--
rename : tools/trace-malloc/bloatblame.c => tools/trace-malloc/bloatblame.cpp
2011-09-28 23:19:26 -07:00
Graeme McCutcheon
6171ee4207 Bug 46555 - "Select All" should only be enabled when editor is non-empty. r=ehsan, gavin 2011-09-23 22:44:53 +01:00
Ehsan Akhgari
85e673bce7 Backout changeset a72195ce0eaa (bug 612128) becasue of Fennec regressions 2011-09-22 18:09:44 -04:00
Ehsan Akhgari
ec2d83e852 Bug 612128 - Prevent the editor from modifying nodes which are not under an editing host; r=roc,bzbarsky
This patch ensures that the NODE_IS_EDITABLE flag is only set on nodes living
under an editing host.  Things like text controls which used to have that flag
previously will not have it any more.  The flag would be set on their anonymous
div node instead.  Note that if text controls actually fall under an editing
host, they will get the NODE_IS_EDITABLE flag.

This patch also makes nsHTMLEditor::IsEditable return sane results (text nodes
are always considered to be editable).
2010-11-16 15:45:49 -05:00
Ehsan Akhgari
5512725a02 Bug 98160 - Add support for platform native text switching keyboard shortcuts in bidi UI on Windows; r=roc 2011-09-15 10:54:50 -04:00
Jesper Kristensen
90f5bdbe17 Bug 591780 - Part 1: Backend support for adding and removing spell checker dictionaries at runtime; r=ehsan 2011-09-13 14:58:54 -04:00
Masayuki Nakano
27777a6f2a Bug 669028 part.9 editor should use mozilla::LookAndFeel rather than nsILookAndFeel r=ehsan 2011-09-09 11:27:12 +09:00
Ms2ger
0038e2e573 Bug 684807 - Annotate crashtest assertions on Android; r=philor 2011-09-06 18:35:43 +02:00
Ed Morley
4923d068c0 Backout a422b9ff0a9e (bug 591780 part 1) for causing 8% Ts regression on multiple platforms; a=khuey 2011-09-06 14:32:26 +01:00
Jesper Kristensen
ffe4248d12 Bug 591780 - Part 1: Backend support for adding and removing spell checker dictionaries at runtime; r=ehsan 2011-09-05 18:44:34 -04:00
Marco Castelluccio
7cb0506077 Bug 682744 - Sprinkle some do_QueryObject fairy dust around the tree; r=khuey 2011-08-30 22:45:31 +01:00
Ms2ger
b12351fbda Bug 672054 - Part a: Remove nsIDOMNSUIEvent; r=smaug 2011-08-26 09:43:49 +02:00
Ehsan Akhgari
1a870eac6e Backout changeset 46dc0fb0b1cb (bug 674770) because of yet another mochitest-3 Windows failure
--HG--
extra : rebase_source : a0739cd5d2eb66015d785c107151507f8a8113e3
2011-08-18 16:25:11 -04:00
Fabien Cazenave
fd200a56fc Bug 680060 - [queryCommandEnabled] check `GetIsSelectionEditable' results; r=ehsan 2011-08-18 11:34:52 -04:00
Ehsan Akhgari
f53498d5e9 Bug 674770 - contenteditable breaks middle-click to open links when middlemouse.paste=true; r=roc 2011-07-28 17:42:38 -04:00
Jonas Sicking
923d52af7d Bug 667612: Make addEventListener not throw if passed a null listener. r=smaug 2011-08-18 02:45:00 -07:00
Fabien Cazenave
4862d93606 Bug 676401 - The document.queryCommandEnabled API doesn't take the active editing host into account; r=ehsan
* adding an `isSelectionEditable' readonly attribute in <nsIEditor>;
 * modified all ::IsCommandEnabled methods in editor/ to take it into account:

./libeditor/base/nsEditorCommands.cpp (15 commands)
  nsUndoCommand                   'undo'
  nsRedoCommand                   'redo'
  nsClearUndoCommand              'clearUndo'
  nsCutCommand                    'cut'
  nsCutOrDeleteCommand            ?
  nsCopyCommand                   'copy'
  nsCopyOrDeleteCommand           ?
  nsPasteCommand                  'paste'
  nsPasteTransferableCommand      ?
  nsSwitchTextDirectionCommand    ?
  nsDeleteCommand                 'delete'
  nsSelectAllCommand              'selectAll'
  nsSelectionMoveCommands         ?
  nsInsertPlaintextCommand        ?
  nsPasteQuotationCommand         ?

./composer/src/nsComposerCommands.cpp (15 commands)
  nsBaseStateUpdatingCommand      ?
  nsPasteNoFormattingCommand      ?
  nsRemoveListCommand             ?
  nsIndentCommand                 'indent'
  nsOutdentCommand                'outdent'
  nsMultiStateCommand             ?
  nsHighlightColorStateCommand    'hiliteColor'
  nsAbsolutePositioningCommand    ?
  nsDecreaseZIndexCommand         ?
  nsIncreaseZIndexCommand         ?
  nsRemoveStylesCommand           'removeFormat'
  nsIncreaseFontSizeCommand       'increaseFontSize'
  nsDecreaseFontSizeCommand       'decreaseFontSize'
  nsInsertHTMLCommand             'insertHTML'
  nsInsertTagCommand              ?

./composer/src/nsComposerDocumentCommands.cpp (3 commands)
  nsSetDocumentOptionsCommand     ?
  nsSetDocumentStateCommand       ?
  nsDocumentStateCommand          n/a (unpatched)
2011-08-17 13:28:03 -04:00
Graeme McCutcheon
8ded7124eb Bug 318065 - Don't notify editor observers until bogus node state is reset. r=ehsan 2011-08-16 13:55:23 +01:00
Ms2ger
66ab4757eb Merge m-c to m-i 2011-08-13 14:47:03 +02:00
Malini Das
a0832b693a Bug 367393 - Add a packed MochiKit that contains only SimpleTest dependencies- plain tests 2/2. r=jmaher, a=test-only 2011-08-12 12:21:44 -04:00
Malini Das
e306b1b5aa Bug 367393 - Add a packed MochiKit that contains only SimpleTest dependencies- chrome. r=jmaher, a=test-only 2011-08-12 12:21:36 -04:00
Ms2ger
72dee98c7b Bug 677340 - Return already_AddRefed instead of nsCOMPtr from various functions in editor/; r=ehsan 2011-08-11 15:29:59 +02:00
Ms2ger
d377c55ed2 Bug 677101, part c - Reduce nsIDOMText.h inclusions; r=volkmar 2011-08-11 15:29:58 +02:00
Jan Varga
5020b003ce Bug 617528 Part 2 - Core implementation r=smaug
--HG--
rename : content/html/content/test/test_bug418756.html => content/html/content/test/test_checked.html
2011-08-08 19:31:32 +02:00
arno renevier
2485241198 Bug 338427 - Spellchecker should respect the langi attribute; r=ehsan 2011-08-12 15:12:45 -04:00
Michael Wu
706be3a5e8 Bug 671185 - Incorrect return of NS_ERROR_* codes in functions returning PRBool, r=mak,ehsan,taras,biesi,pike,khuey,dholbert,josh,bjacob,bsmith 2011-07-25 21:57:58 -07:00
Joel Maher
c3a05191bb Bug 666649 - remove enablePrivilege from various places in the harness and chrome tests. r=ted, a=test-only 2011-07-21 16:21:25 -04:00
Mounir Lamouri
2e1dfaef9e Bug 669310 - Fixes various includes and forward declarations. f=Ms2ger r=jst 2011-07-20 12:18:54 -07:00
Ehsan Akhgari
4a9dec68d7 Bug 414526 - Backspace at the beginning of a contenteditable element or delete at the end of one should not affect the rest of the contenteditable elements on the page; r=roc
The main fix here involves the introduction of the nsHTMLEditor::IsNodeInActiveEditor
API.  This API returns true if the current selection in the document falls
inside the active editable section.  The patch adds a bunch of checks using
this API to various places in the code to make sure that editing operations do
not escape their editing host.

There are also some unrelated fixes to range promotion code which fix the
bugs that have existed in that code before, but because of the lack of this
check were not uncovered before.

This patch also removes the nsTextEditUtils::InBody API which only made sense
in designMode documents, and was insufficient for contenteditable elements.
2011-07-14 11:25:07 -04:00
Ms2ger
7a41ef9f3e Bug 670499 - Make nsEditor::CreateEventListeners return void; r=ehsan 2011-07-15 12:18:35 +02:00
Jonas Sicking
cc14f402b6 Bug 663461 Part 1: Remove Add/RemoveEventListenerByIID from editor. r=smaug 2011-06-27 16:34:54 -07:00
Jonas Sicking
5e5e6bd544 Bug 658714 Part 10: Remove nsIDOM3EventTarget/nsIDOMEventGroup. r=smaug 2011-06-23 19:18:02 -07:00
Jonas Sicking
864793d608 Bug 658714 Part 9: Don't use EventGroups for system-group. r=smaug 2011-06-23 19:18:02 -07:00
Jonas Sicking
26f99e3cdb Bug 658714 Part 7: DeCOMtaminate nsEventListenerManager. r=smaug 2011-06-23 19:18:01 -07:00
Jonas Sicking
6a04ff1d9f Bug 658714 Part 6: Fixups after search'n'replace s/nsPIDOMEventTarget/nsIDOMEventTarget/. r=smaug 2011-06-23 19:18:01 -07:00
Jonas Sicking
e3f6b769a1 Bug 658714 Part 5: Search'n'replace nsPIDOMEventTarget to nsIDOMEventTarget. r=smaug 2011-06-23 19:18:00 -07:00
Jonas Sicking
8fed9108b1 Bug 658714 Part 1: Merge nsPIDOMEventTarget into nsIDOMEventTarget. r=smaug,bent 2011-06-23 19:17:58 -07:00
Ehsan Akhgari
49d9a2f639 Bug 660199 - Avoid using invalid C++ casts when registering/unregistering editor event listeners; r=roc 2011-06-20 09:55:22 -04:00
Masayuki Nakano
db1e5b26fa Bug 664437 editor should use mozilla::Preferences r=ehsan 2011-06-17 09:59:29 +09:00
Joel Maher
5b6fcbed46 Bug 663215 - move test_selection_move_commands.xul to mochitest-chrome. r=roc, a=test-only 2011-06-10 11:11:45 -04:00
Ms2ger
d823c7ef2c Bug 657210 - Address review comment 2011-05-23 18:54:57 +02:00
Ms2ger
c36c459144 Bug 657210 - Outparamdel nsEditor::GetPresShell; r=ehsan 2011-05-22 14:43:13 +02:00
Ms2ger
3388f3994d Bug 657160 - Remove NS_NewCaret; r=ehsan,roc 2011-05-15 12:17:09 +02:00
Ed Morley
082d53f39b Bug 655756 - Remove final XP_MAC remnants; r=josh 2011-05-10 20:24:48 +02:00
Mounir Lamouri
7211c91c57 Bug 514437 - Content part of the progress element. r=smaug 2011-04-09 10:22:02 -07:00
Matt Brubeck
1b17575132 Back out changeset bfb48178c8ec (finish backing out bug 514437) to fix tests on a CLOSED TREE. 2011-05-09 19:38:05 -07:00
Mounir Lamouri
dd977ba6ef Bug 514437 - Content part of the progress element. r=smaug 2011-04-09 10:22:02 -07:00
Ed Morley
81db8d5e09 Bug 654737 - Remove WinCE code from editor/*; r=ehsan 2011-05-06 11:05:57 +02:00
David Zbarsky
5ecf0a2bd3 Bug 610305: decom nsEventStateManager r=smaug 2011-04-21 19:35:52 +02:00
Mounir Lamouri
b4cf8cd184 Backed out changeset c1a7c1bc1aeb due to busted build. 2011-04-20 22:26:06 +02:00
David Zbarsky
c4d29900ed Bug 610305: decom nsEventStateManager r=smaug 2011-04-20 21:42:33 +02:00
Ehsan Akhgari
1eafc52dd0 Bug 650083 - nsEditor.cpp:1147: warning: unused variable 'rv'; r=roc 2011-04-14 23:45:24 -04:00
Ehsan Akhgari
4153f12b55 Bug 617539 - Remove nsIEditor_MOZILLA_2_0_BRANCH; r=roc 2011-04-11 16:00:32 -04:00
Peter Van der Beken
afdf1551f1 Fix for bug 584048 (Clean up cycle collection code) - remove NS_IMPL_CYCLE_COLLECTING_ADDREF_AMBIGUOUS/NS_IMPL_CYCLE_COLLECTING_RELEASE_AMBIGUOUS. r=bent. 2011-03-06 12:11:31 +01:00
Ehsan Akhgari
b4def61223 Bug 646194 - Fix the bound checking when deleting previous words to prevent crashes when the caret is at the beginning of an editable area; r=roc 2011-04-06 11:28:08 -07:00
Ehsan Akhgari
ba2ed13afe Bug 642588 - Clean up the drag & drop caret on the editor correctly when the mouse leaves the editable field; r=roc 2011-03-18 14:57:02 -04:00
Ehsan Akhgari
e4ad8f774b Bug 640321 - Register the mouse event handlers for the editor in the system group; r=roc 2011-03-16 15:34:30 -04:00
Ehsan Akhgari
7a77702d1e Bug 641466 - Correct the array bounds checking so that the last surrogate pair in a textbox can be deleted correctly; r=roc 2011-03-16 15:34:29 -04:00
Ehsan Akhgari
b528286d7e Bug 639695 - Reconnect the HTML editor to the new presentation of a contenteditable document when it changes; r=roc
This fixes things such as the caret not showing up after the presshell for a
document containing a contenteditable element is recreated.
2011-03-11 18:45:20 -05:00
Ehsan Akhgari
c06813a2c5 Bug 407127 - Part 6: Remove the presshell argument to nsIEditor::Init as it's no longer necessary; r=roc 2011-03-11 00:40:31 -05:00
Ehsan Akhgari
c504ea4d07 Bug 407127 - Part 5: Fix the editor to not rely on cached presshells and selection controllers, because they may not always be valid; r=roc 2011-03-11 00:40:31 -05:00
Ehsan Akhgari
bb48d9cae8 Bug 407127 - Part 4: Avoid using the presshell needlessly because it may not always be available; r=roc 2011-03-11 00:40:30 -05:00
Ehsan Akhgari
343b9d2aa6 Bug 407127 - Part 3: Get the selection controller for HTML editors from the presshell, instead of holding on to a presshell reference masked as a selection controller; r=roc 2011-03-11 00:40:30 -05:00
Ehsan Akhgari
6ef553932d Bug 407127 - Part 2: Refactor the editor so that it only touches mSelConWeak in GetSelectionController, to make removing it for HTML editors easier; r=roc 2011-03-11 00:40:30 -05:00
Ehsan Akhgari
586a904360 Bug 407127 - Part 1: Refactor the editor so that it only touches mPresShellWeak in GetPresShell, to make removing it easier; r=roc 2011-03-11 00:40:30 -05:00
Ehsan Akhgari
af800fd6a1 Bug 636465 - Reset the spellchecking override status when detaching an editor object from the content node; r,a=roc 2011-03-01 15:04:42 -08:00
Neil Rashbrook
42274702a1 Bug 635420 - Clicking on content within Normal tab of Composer and stops switching to other tabs; r=ehsan a=bsmedberg 2011-02-28 13:04:05 -08:00
Jesse Ruderman
75fe047e55 Add bug number to comment. a=NPOTB DONTBUILD 2011-02-24 13:43:48 -08:00
Ehsan Akhgari
1989a9bf06 Bug 636074 follow-up: move the assertion count adjustment because a test was added in between 2011-02-23 15:28:33 -08:00
Kyle Huey
d50f7a5a54 Bug 636107 - Part 2: Maintain better hygiene by not passing uninitialized pointer values around; r=ehsan a=blocking-final+ 2011-02-23 07:20:58 -05:00
Ehsan Akhgari
bcb0f84a06 Bug 636074 - Part 1: Forget the transaction pointer when creating transaction objects in order to pass it to the caller instead of swapping it with random values; r=roc a=blocking-final+ 2011-02-23 14:22:07 -08:00
Kyle Huey
8408dbe11c Bug 633709: Actually commit the test. r+a=ehsan 2011-02-19 18:40:52 -05:00
Kyle Huey
da2a416c73 Bug 633709: Convert bogus assert into a warning. r+a=ehsan
--HG--
extra : rebase_source : 5928d5a4309bd98e0cf4cd3041f36ba64d992706
2011-02-19 17:49:23 -05:00
Kyle Huey
846a72981f Bug 633709: Fix editor's handling of txn objects. r+a=ehsan
--HG--
extra : rebase_source : c44055ca4378a8213e3b60b61b16df8dd9758a88
2011-02-19 17:18:37 -05:00
Kyle Huey
015e84ddd4 Bug 633709: Test.
--HG--
extra : rebase_source : 6bae5d01331df279551577606806fc35d91993a3
2011-02-19 17:04:26 -05:00
Ehsan Akhgari
9bd0f72c58 Bug 336091 - Initialize the out parameters of nsEditor::GetStartNodeAndOffset correctly; r,a=roc
--HG--
extra : rebase_source : 7ae5b960263f2412c21b0cbcebf6f95a4ddb2e73
2011-02-09 14:07:56 -05:00
Ehsan Akhgari
b1d2463ed9 Bug 629172 - Fix the regression in switching the text input direction using Cmd/Ctrl+Shift+X; r=roc a=blocking-final+
--HG--
extra : rebase_source : 57471865db00c1efa07bb746df42de8278027b36
2011-01-27 00:26:33 -05:00
Ehsan Akhgari
bde6418f39 Bug 625452 - Make sure all plaintext editor commands generate trusted input events; r=roc a=blocking-final+ 2011-01-15 23:16:45 -05:00
Ehsan Akhgari
3d3c16632b Bug 623193 - Fennec crash [@ nsEditor::InsertTextIntoTextNodeImpl ]; r,a=roc 2011-01-09 20:14:58 -05:00
Ehsan Akhgari
9a4fb543ef Bug 527935 - Part 3: Generate the input event for editor IME transaction commits if needed; r=roc a=blocking-final+ 2010-12-17 14:47:11 -08:00
Ehsan Akhgari
393e54e609 Bug 527935 - Fire the input event for text controls with the correct trusted-ness status; r=roc a=blocking-final+ 2010-12-07 01:30:05 -05:00
Jesse Ruderman
3be9494c60 Bug 475132 - add crashtest 2010-12-12 12:54:25 -08:00
Jesse Ruderman
8a7fe7c658 Bug 407079 - add crashtest 2010-12-12 12:54:25 -08:00
Ehsan Akhgari
d7ede6881c Bug 611798 - Do not pretent that we need the presshell to exist in order to turn off update view batching when the editor operations finish, because we don't; r=bzbarsky a=blocking-final+
This patch should fix all of the possible cases where a browser window stops painting when the presshell dies in the middle of an editor operation.
2010-12-10 17:14:26 -05:00
Ehsan Akhgari
2337dae8c9 Back out bug 612128 because it regressed Fennec with bug 618357, which blocks Fennec beta3; a=blocking-fennecb3+ 2010-12-10 21:20:00 -05:00
Ehsan Akhgari
30e6f309f2 Bug 612128 - document.execCommand("inserthtml") may insert HTML inside non-editable parts of a document; r=roc,bz a=bz 2010-11-16 15:45:49 -05:00
Neil Deakin
2eeca289de Bug 527749 - Drag events out of order; r=smaug,dao a=blocking-betaN+ 2010-12-03 11:19:55 -05:00
Ehsan Akhgari
ed92562d68 Bug 615015 - "ASSERTION: bad action nesting!"; r,a=roc
--HG--
extra : rebase_source : 3e972a7f5dad81b5cba1b8ee93c16798fdc809c2
2010-12-01 00:24:09 -05:00