Commit Graph

533 Commits

Author SHA1 Message Date
Bernd
1144f148f4 bug 505894 remove double null check r=timeless 2010-03-06 10:53:03 +01:00
Bernd
ee60430533 bug 484256 remove remaining border widths limits that are now obsolete as borders have a 2 byte storage r=fantasai 2010-03-06 10:53:03 +01:00
Bernd
65b8d4cc9c bug 229247 remove no op quirk code r=bzbarsky 2010-03-06 10:53:02 +01:00
Bernd
7492b03bef bug 281241 if a content based column looses its content based children we need to create anonymous cols r=bzbarsky 2010-03-06 10:53:02 +01:00
Daniel Holbert
9513bd93b3 Bug 452319 followup: cast mRgIndex to be unsigned, to fix signed-unsigned-comparison compiler warning. r=bernd 2010-03-05 10:41:54 -08:00
Boris Zbarsky
abae116f82 Bug 527977 part 3. Change the style context cached struct storage; inline GetStyle* and PeekStyle* now that they're pretty dead-simple. r=zwol, sr=dbaron 2010-03-02 18:27:21 -05:00
Robert O'Callahan
55f8af472c Bug 542620. Fix incorrect usage of nsFrameList. r=bzbarsky 2010-02-12 10:40:46 +13:00
Daniel Holbert
11234125d1 Bug 539585 followup: Fix new instance of "warning: format '%p' expects type 'void*'" in nsTableFrame.cpp. (no review, just fixing one new instance of this problem) 2010-02-02 12:06:58 -08:00
Robert O'Callahan
6f230353bb Bug 542620. Need to paint the table background if columns or column-groups have backgrounds. r=dbaron
--HG--
extra : rebase_source : aebb3f9c4c83d2eecc779939e87dcf7195f5d103
2010-02-02 12:21:13 +13:00
L. David Baron
6207e37f4a Always create nsDisplayTableBorderBackground when we're doing event delivery. (Bug 541668) r=roc 2010-01-24 12:06:20 -08:00
Bernd
7b3827461f bug 538479 add initialization code that I wrongly removed r=dbaron
--HG--
extra : rebase_source : 63ec32369dcdae83638a3be5635e25ebc757b1cd
2010-01-19 18:49:12 +01:00
Daniel Holbert
41a9eb240f Bug 539585: Fix "warning: format '%p' expects type 'void*'" in layout directory. r=dbaron 2010-01-17 15:11:06 -08:00
Bernd
547f5ac844 bug 28800 remove support for scrollable rowgroups moa=roc r=bzbarsky 2010-01-16 17:05:46 +01:00
Bernd
f4a1800dfb bug 43178 - replace incorrect border, frame and rules handling code in content by css rules, initial patch - fantasai, a lof of input - bz r=bzbarsky 2010-01-09 16:33:03 +01:00
fantasai
1ffb0c06ef Bug 508473 part III: Pass destruction root to frame destruction methods r=bz sr=roc 2009-12-24 00:21:15 -05:00
fantasai
1e880721fb Bug 508473 Part II: Remove DeletingFrameSubtree r=bz sr=roc 2009-12-24 00:20:41 -05:00
Daniel Holbert
fff90b5882 Bug 536463: Rename nsTableOuterFrame::GetMargin to 'GetChildMargin', so it won't hide unrelated inherited method. r=dbaron 2009-12-22 18:59:29 -08:00
L. David Baron
1714bc196e Fix assertions in the scrollable row group case. (Bug 531461) r=roc 2009-12-13 19:40:55 -08:00
L. David Baron
592f811eba Address my own review comment and undo one of the changes in bug 531461. 2009-12-12 11:35:26 -08:00
Robert O'Callahan
19da2f1872 Bug 530686. Only create an nsDisplayTableBorderBackground when it's going to have something to paint, since having one can disable some scrolling optimizations. r=dbaron 2009-12-12 10:50:30 -08:00
Robert O'Callahan
97c78b1258 Bug 531461. Avoid creating an nsDisplayTableBorderBackground if every part of the table is hidden. r=dbaron 2009-12-12 10:50:25 -08:00
Boris Zbarsky
99027aa785 Bug 525608 part 3. Change all style set consumers that ask for a pseudo style context to indicate what they're actually asking for (pseudo-element, anonymous box, or xul tree thing). r=dbaron 2009-12-11 02:37:40 -05:00
Boris Zbarsky
e9f228c7d5 Backing out bug 525608 and bug 525952 2009-12-10 18:28:08 -08:00
Boris Zbarsky
0a82b262db Bug 525608 part 3. Change all style set consumers that ask for a pseudo style context to indicate what they're actually asking for (pseudo-element, anonymous box, or xul tree thing). r=dbaron 2009-12-10 14:36:05 -08:00
Jesse Ruderman
b4b916d596 Add crashtests for a few bugs 2009-12-06 17:53:38 -08:00
Bernd
ef756ed2b5 testcases for the bugs fixed by the checkin for bug 452319 2009-11-08 20:11:07 +01:00
Bernd
770f7109b0 reorganize border collapse painting code to make a little bit more readable bug 452319 r=fantasai sr=bz 2009-11-05 10:26:00 +01:00
Dão Gottwald
23928799d1 Backed out changeset 524233171fa4 2009-11-05 10:25:26 +01:00
Dão Gottwald
f125923eda reorganize border collapse painting code to make a little bit more readable bug 452319 r=fantasai sr=bz 2009-11-05 09:03:51 +01:00
Boris Zbarsky
5215a681c7 Bug 525295. Rename nsStyleContext::GetPseudoType to GetPseudo. r=dbaron 2009-10-29 17:17:56 -04:00
L. David Baron
1e581250d4 Make unconstrained width assertions into warnings because we can hit them when we clamp really large widths. (Bug 525100) r=roc 2009-10-28 20:22:28 -07:00
Reed Loden
d1bd3c0e15 Bug 506267 - [r=bzbarsky sr=dbaron] 2009-10-02 21:09:57 -05:00
Boris Zbarsky
4fc405cefa Bug 512336. Make frame lists doubly-linked. r=roc,fantasai 2009-10-02 12:27:37 -04:00
Robert O'Callahan
d56dfa741e Bug 513082. Instead of passing aDirtyRect to nsDisplayItem::Paint, have nsDisplayList::OptimizeVisibility (renamed to ComputeVisibility) compute the intersection of the visible region with the bounds of each display item and store the result in the item's mVisibleRect. This lets us do less work to paint display items which have a small intersection with the visible region but a large intersection with the bounding-box of the visible region. r=dbaron
--HG--
extra : rebase_source : 76db4b87ef9e5a6e9de7677edc08c26e2cbc462e
2009-09-07 12:35:14 +12:00
Boris Zbarsky
d52b43f127 Bug 515534. Simplify some nsTableRowGroupFrame methods by assuming that the frame constructor did not screw up. r=bernd 2009-09-18 14:52:58 -04:00
Mats Palmgren
7ca7fe2f91 Bug 233463, patch 3 - Make Destroy/RemoveFrame() methods void and assert that the frame to remove is present. r=bzbarsky 2009-09-18 13:09:36 +02:00
Mats Palmgren
377056c269 Bug 233463, patch 2 - Introduce nsFrameList::mLastChild member for fast access to the last sibling frame. r=bzbarsky 2009-09-18 13:09:36 +02:00
Mats Palmgren
9aacd90f4f Bug 233463, patch 1 - Minor cleanup of frame list related code in nsTableRowGroupFrame. r=bzbarsky 2009-09-18 13:09:35 +02:00
Mats Palmgren
8279fd683e Bug 233463, patch 0 - Use nsFrameList methods instead of nsIFrame::SetNextSibling. r=bzbarsky 2009-09-18 13:09:35 +02:00
Mats Palmgren
948203eb7d Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX. b=512106 r=roc 2009-09-16 17:01:36 +02:00
Bobby Holley
0b02012ed8 Bug 435296 - Sync decode handling for decode-on-draw. r=roc 2009-09-12 16:44:18 -06:00
Zack Weinberg
17eb5a6efc Bug 497495 part 3: Add methods to every nsFrame subclass that expose the as-allocated identity of every frame object. Also some cleanups to the QueryFrame implementation. r=dbaron sr=roc 2009-09-12 17:49:24 +01:00
Mats Palmgren
03553bc4a0 Remove/simplify frame list use. b=510137 r=bernd 2009-09-04 23:07:43 +02:00
Benjamin Smedberg
008e309c7f Bug 513032 - remove empty conditionals in our makefiles, r=ted 2009-08-27 10:48:18 -07:00
Jesse Ruderman
e1a92dde70 Add more crashtests 2009-08-27 21:11:40 -07:00
Jesse Ruderman
15e3a448a6 Add crashtests 2009-08-27 19:48:20 -07:00
Benjamin Smedberg
0df64c6bc4 Additional followup to bug 398573 - remove REQUIRES from the tree even when they are in makefile conditional blocks
--HG--
extra : rebase_source : cc65c34a414e6c67a5651fc9cf0b6bd709ebcdbd
2009-08-27 08:53:13 -07:00
Robert O'Callahan
75dc1beb9c Backed out changeset e2927bb26412 2009-08-26 14:49:18 -07:00
Zack Weinberg
18c763f2c5 Bug 497495 part 3a: rationalize the queryframe-implementation macro naming scheme, restructure the implementation to detect duplicate entries, and a couple fixes to the frame ID enumeration. r=dbaron sr=roc
Bug 497495 part 3b: update users of queryframe macros (strictly mechanical change). r=dbaron

--HG--
extra : rebase_source : ee672a17934227b408b83dc6b5cc4e4909652f72
2009-08-26 09:27:42 -07:00
Benjamin Smedberg
2e9438fd2f Followup to bug 398573 - remove REQUIRES from the tree since it is no longer used... automatically generated patch, rs=ted 2009-08-25 08:59:31 -07:00
Mats Palmgren
aa2293c455 Crash test for bug 430374. 2009-08-24 01:21:49 +02:00
Ryo Kawaguchi
54bb0a0d80 Implement background-image: -moz-image-rect(), which allows a region of an image to be used as a background image. (Bug 113577) r=roc, dbaron 2009-08-21 13:39:25 -07:00
Michael Ventnor
8ae6cd75f4 Bug 479220: Implement support for CSS gradients: -moz-linear-gradient() and -moz-radial-gradient(). r=roc, dbaron 2009-08-01 08:53:40 -07:00
Makoto Kato
292748dbba Bug 434733: Don't apply width on colgroups to columns that have their own width. r=dbaron 2009-08-01 08:53:40 -07:00
Dão Gottwald
bf4108370b Backed out changeset c086fca6fc55 2009-07-31 14:35:48 +02:00
Michael Ventnor
61ed5fe1e2 Bug 479220 - Implement the CSS gradients proposal. r=roc,dbaron sr=roc 2009-07-31 13:32:32 +02:00
Boris Zbarsky
f2936464e5 Bug 281387. Make nsIFrame::Append/InsertFrames use nsFrameList. r=bernd,roc, sr=dbaron 2009-07-30 13:23:32 -04:00
Boris Zbarsky
5fefb45a48 Bug 504221 part 12. Switch SetInitialChildList to nsFrameList. r=fantasai, r+sr=roc 2009-07-28 08:53:20 -04:00
Boris Zbarsky
c749fe8981 Bug 504221 part 8. Make CreateAnonymousColFrames saner. r=bernd, sr=roc 2009-07-28 08:53:18 -04:00
Boris Zbarsky
db6ff446ab Bug 504221 part 5. Switch from GetFirstChild to GetChildList (returning an nsFrameList). For now, keep a GetFirstChild shim so callers don't have to be updated. r=fantasai, r+sr=roc 2009-07-28 08:51:09 -04:00
Boris Zbarsky
b0259fd19b Bug 504221 part 3. Switch overflowFrames storage to nsFrameList. r=fantasai, r+sr=roc 2009-07-28 08:51:09 -04:00
Michael Kohler
404670f1f3 Bug 106386 - Correct misspellings in source code (old); Part 2; r=timeless 2009-07-27 10:47:02 +02:00
Robert O'Callahan
4ef62fb0ed Bug 371839. Remove ParentDisablesSelection, which is effectively unused. r=bzbarsky
--HG--
extra : rebase_source : 920c501f033e026709ec15792cadbb2f24462a0a
2009-07-27 10:06:30 +12:00
Robert O'Callahan
14dbcb0874 Bug 371839. Simplify SetSelected signature and semantics, and reimplement it in nsTextFrame much more efficiently. r=bzbarsky
--HG--
extra : rebase_source : 18c390e3ebd09de82b1a23699c56b741f928ca37
2009-07-27 10:05:41 +12:00
Robert O'Callahan
fb7ad45e60 Bug 371839. Remove useless SetSelected implementations. r=bzbarsky
--HG--
extra : rebase_source : 57629a43328f3dbc97a5d0595186a32150722db4
2009-07-27 10:03:16 +12:00
Robert O'Callahan
f26c241975 Bug 505184. When 'deflation' of the background area is not required, paint table backgrounds using a dedicated nsDisplayBackground instead of the multipurpose nsDisplayTableBorderBackground. r=fantasai 2009-07-22 12:44:52 +12:00
Daniel Holbert
8a129b1c9f Bug 479166: rename variable "computedPaginatedHeight" to "computedUnpaginatedHeight" and reduce its scope, and also fix some build warnings, all in nsTableCellFrame. r=bernd 2009-07-21 13:05:49 -07:00
Jesse Ruderman
9ee3484d6d Add crashtest for bug 448988 2009-07-14 12:57:09 -07:00
Benjamin Smedberg
369492d616 Bug 503376 - Remove unused CalcAutoMargin function which stopped being used in bug 478614, r=bernd 2009-07-13 12:31:32 -04:00
Bernd
ce52d35f28 bug 240245 remove some bizarre col frame construction code that is never called. r=bzbarsky 2009-07-12 19:47:10 +02:00
Alexander Surkov
df93a01d0c Bug 437980 - 9 tests fail in table_indexes.html chrome test file, r=marcoz, davidb, bernd 2009-06-29 18:54:26 +08:00
Bernd
5c0c166ec7 adopt caption vertical margins to latest CSS2.1 revision, bug 478614, r/sr=dbaron 2009-06-28 15:51:46 +02:00
Bernd
8aa449421d bug 325292 - place the needtocollapse flag on the first inflow so that works in pagination mode r/sr=roc 2009-06-21 18:34:03 +02:00
Bernd
a52d85f388 refactor the setting of continous borders in the border collapse computation bug 452319 r=fantasia sr=roc
* * *
* * *
* * *
* * *
2009-06-21 18:31:40 +02:00
L. David Baron
0d06184f97 Remove support for fallback background colors. (Bug 496721) r+sr=bzbarsky 2009-06-16 08:00:20 -07:00
Robert O'Callahan
8c7da0cfb7 Bug 494667. Don't apply optimization to shrink drawn background area to exclude solid borders, if we're not going to draw those borders (e.g. in tables with collapsing borders). r+sr=dbaron,a=beltzner 2009-05-28 17:01:42 +12:00
Bernd
1b7eae0fba bug 492661 - track the visibility of cols and colgroups independently of the presence of cells r/sr=roc 2009-05-16 16:22:56 +02:00
Arpad Borsos
319919e714 Bug 492520 - Optimize some Frame classes for memory usage; r+sr=roc 2009-05-12 12:13:09 +02:00
Daniel Holbert
0947631c3a Bug 490909: Remove old layout debugging code, patch #2: remove 'VerifyTree' & related code. r+sr=dbaron 2009-05-12 12:03:09 -07:00
Boris Zbarsky
26d5258bfb Bug 490182. Ask to reflow the right frame. r=bernd, sr=dbaron. 2009-05-11 09:17:25 -04:00
L. David Baron
8c38aba811 Switch HTML mochitests from using MochiKit.js to packed.js. (Bug 490955) r=sayrer 2009-05-06 13:46:04 -07:00
Bob Clary
a0f8a81e55 bug 391898 - replace img src=http://i with about:blank to prevent time out during test. 2009-04-24 10:08:26 -07:00
Bob Clary
d8afbb50c2 bug 370360 - crash test by Eli Friedman. 2009-04-24 10:08:17 -07:00
Bob Clary
6e984b43c2 bug 344000 - crash test by Bernd. 2009-04-24 10:08:14 -07:00
Bob Clary
009c46c113 bug 343087 - crash test by Jesse Ruderman. 2009-04-24 10:08:13 -07:00
Bob Clary
ce105717af bug 339246 - crash test by Jesse Ruderman. 2009-04-24 10:08:13 -07:00
Bob Clary
ff9f19ff4c bug 339130 - crash test by Jesse Ruderman. 2009-04-24 10:08:13 -07:00
Bob Clary
6edc8468d3 bug 316636 - crash test by Martijn Wargers, Bernd. 2009-04-24 10:08:09 -07:00
Bob Clary
ec2808d91b bug 308752 - crash test by Jesse Ruderman, Martijn Wargers, Bernd. 2009-04-24 10:08:08 -07:00
Boris Zbarsky
ecaf9149f5 Bug 489479. Make nsTableFrame::InsertFrames handle a framelist that includes both colgroups and rowgroups being inserted at the end of the principal child list. r=bernd, sr=roc 2009-04-23 10:17:46 -04:00
Bernd
d38a1d09be bug 413091 - empty first column needs a cellspacing before as we assume always in the code to have cellspacing on the left and right side, r/sr=dbaron 2009-04-18 10:22:34 +02:00
Boris Zbarsky
8ee479696a Bug 488388. Handle inserts at the end of a colgroup that has anonymous colframe kids. r=bernd, sr=roc 2009-04-15 17:44:53 -04:00
Boris Zbarsky
307ccebf4c Bug 484448. Fix handling of whitespace kids of table-related frames. r=bernd, sr=roc
--HG--
rename : layout/reftests/table-anonymous-boxes/white-space-1.html => layout/reftests/table-anonymous-boxes/white-space-7.html
2009-04-08 12:56:16 -04:00
Boris Zbarsky
d44950aed3 Bug 487899. Start column indices incorrect in nsCellMap::ExpandWithCells if an array with more than one cell is passed in. r=bernd, sr=roc 2009-04-13 11:31:39 -04:00
Boris Zbarsky
25164496ef Backed out changeset 0ea22856b5d9 (bug 484448). 2009-04-08 15:56:43 -04:00
Boris Zbarsky
f70fe28e08 Bug 484448. Fix handling of whitespace kids of table-related frames. r=bernd, sr=roc
--HG--
rename : layout/reftests/table-anonymous-boxes/white-space-1.html => layout/reftests/table-anonymous-boxes/white-space-7.html
rename : layout/reftests/table-anonymous-boxes/white-space-1-ref.html => layout/reftests/table-anonymous-boxes/white-space-ref.html
2009-04-08 12:56:16 -04:00
Jonathan Kew
bdab93a7ca Bug 475968. Eliminate NS_FRAME_OUTSIDE_CHILDREN flag, store small overflow areas cheaply within the frame. r+sr=roc 2009-04-06 12:31:50 +12:00
Arpad Borsos
420adcef91 Bug 481932 - use do_QueryFrame instead of IS_TABLE_CELL + cast; r+sr=roc 2009-03-24 23:10:06 +01:00
Arpad Borsos
b8c7bb681a Bug 481881 - use better template arguments for nsTArray<T> after bug 474369, layout part; r+sr=roc 2009-03-12 08:26:29 +01:00
Karl Tomlinson
6a5bf5d169 backout dac7c3176b33 from bug 481881 2009-03-11 17:09:22 +13:00
Arpad Borsos
27f29d685d Bug 481881 - use better template arguments for nsTArray<T> after bug 474369, layout part r+sr=roc 2009-03-11 15:26:36 +13:00
L. David Baron
fa9a21c33d Implement multiple background layers, implement fallback background color, and make -moz-background-inline-policy no longer be part of the background shorthand. (Bug 322475) r+sr=roc,bzbarsky 2009-02-19 21:29:21 -08:00
L. David Baron
2eb748571c Backed out changeset fde0b361f25e (bug 322475, main patch) due to Mac talos startup failures and hitting the NS_ABORT_IF_FALSE in SetupBackgroundClip, which may be related. 2009-02-19 13:51:46 -08:00
L. David Baron
d9ac02ed8c Implement multiple background layers, implement fallback background color, and make -moz-background-inline-policy no longer be part of the background shorthand. (Bug 322475) r+sr=roc,bzbarsky 2009-02-19 12:33:09 -08:00
L. David Baron
a91aa25ab0 Back out all 8 changesets that I just landed (bugs 477959, 477961, 322475, 478899, 475215, 478156) again, because Talos Try server builds lie about which changesets they're testing. 2009-02-19 09:06:18 -08:00
L. David Baron
51ef1de194 Implement multiple background layers, implement fallback background color, and make -moz-background-inline-policy no longer be part of the background shorthand. (Bug 322475) r+sr=roc,bzbarsky 2009-02-19 07:29:28 -08:00
L. David Baron
8b207bcc51 Revert (back out) the previous 11 changesets (bugs 477959, 477961, 477963, 477962, 322475, 478899, 475215, 478156), due to Mac talos orange with (as usual) no useful diagnostic. 2009-02-18 18:59:47 -08:00
L. David Baron
366992262c Implement multiple background layers, implement fallback background color, and make -moz-background-inline-policy no longer be part of the background shorthand. (Bug 322475) r+sr=roc,bzbarsky 2009-02-18 17:13:25 -08:00
Daniel Holbert
cbad7fb59b whitespace-only: align 'aPresContext' with other parameters in methods within nsTableFrame.cpp 2009-02-18 11:47:22 -08:00
Daniel Holbert
d3052afe52 Bug 478785: Remove unneeded availHeight variable in nsTableCellFrame::Reflow, plus minor whitespace cleanup. r=dbaron 2009-02-16 16:02:21 -08:00
Daniel Holbert
caf6538b6a whitespace only: fix alignment of parameters for nsTableCellFrame::SetSelected 2009-02-16 14:26:57 -08:00
Zack Weinberg
bea9955522 Bug 476557. Update view manager cache of page background color in PresShell::Paint, not nsCSSRendering::PaintBackground; permits a small API cleanup. r+sr=roc
--HG--
extra : rebase_source : dcf1475dd8b695eb18513e97ca35b08a4affd19f
2009-02-16 14:11:34 +13:00
Jesse Ruderman
f154077a31 Add crashtests 2009-02-13 14:54:17 -08:00
Daniel Holbert
aad0f923ea typo fix in a comment: s/glock/block/ CLOSED TREE a=sdwilsh|sheriff 2009-02-12 15:10:59 -08:00
Jesse Ruderman
68344d4b52 Add a bunch of crashtests 2009-02-10 22:18:05 -08:00
Jesse Ruderman
c9eb6349ac Add some crashtests 2009-02-10 16:36:04 -08:00
Michael Ventnor
b480b09ba3 Bug 476738. Implement 'inset' box-shadows. r+sr=roc,r=dbaron 2009-02-10 21:45:13 +13:00
Jesse Ruderman
5f1cc5c3ce Add a bunch of crashtests 2009-02-10 00:09:40 -08:00
Bernd
acce04933d include the border width for border collapsed tables as required by CSS 2.1. We implemented before what CSS 2.0 required and it was ugly, so the spec changed. r=fantasai sr=roc, bug 155955 2009-02-08 17:46:42 +01:00
Bernd
3ba502a047 remove dead debugging code r/sr=bzbarsky bug 475075 2009-02-08 17:45:28 +01:00
Arpad Borsos
b2f9b630db Bug 474369 - get rid of nsVoidArray, layout/tables part. r+sr=roc 2009-02-05 10:09:50 +01:00
Daniel Holbert
f093208f71 Whitespace-only: Fix parameter indentation in nsTableCellFame.cpp 2009-01-14 21:06:03 -08:00
Daniel Holbert
3a78be97fc Whitespace-only: Fix parameter indentation in nsTableRowFrame.cpp and nsTableRowGroupFrame.cpp 2009-01-14 14:16:43 -08:00
L. David Baron
5d6a678da1 Clean up CalcAvailWidth. (Bug 444928) r=bernd 2009-01-13 11:50:40 -08:00
Benjamin Smedberg
24e7cb1f78 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
50621e4f9f Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
d0b948876f Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Michael Ventnor
318cfd2e10 Bug 472410. Don't adjust selection colors if the background is a -moz-appearance that we can't know anything about. r+sr=roc 2009-01-09 13:29:38 +13:00
L. David Baron
57a8e776d8 Rename flags and methods from space manager to float manager. (Bug 191448) r+sr=roc 2009-01-04 19:39:54 -05:00
L. David Baron
b3d748ba11 Fix some missed renames from bug 471356. r+sr=bzbarsky 2009-01-04 14:52:38 -05:00
L. David Baron
a5129c520e Fix slight errors when widths can't be round-tripped through floats. (Bug 467141) r+sr=roc 2008-12-04 08:09:53 -08:00
L. David Baron
7aa294ceb7 Remove now-unneeded argument from GetWidthInfo. (Bug 466108) r=dholbert sr=roc 2008-12-04 08:09:52 -08:00
Michael Ventnor
0a7591b341 Bug 453641. Make box-shadow work on tables and table parts. r+sr=roc 2008-12-03 14:20:21 +13:00
Bernd
18e359b826 bug 458924 - activate the DidResizeColumns mechanism when column widths changes in fixed layout. r/sr=dbaron 2008-11-27 18:23:52 -08:00
L. David Baron
17759307a2 Distribute extra space in fixed-layout tables where all columns have widths proportionally rather than equally, for compatibility. (Bug 445142) r=bernd sr=roc a=blocking1.9.1+ 2008-11-25 15:22:39 -08:00
L. David Baron
a5f7856bf5 Back out 6ce5f62a59455c79b3e12414989d3727f283b7c3 due to mac startup failures. 2008-11-25 14:38:06 -08:00
L. David Baron
3cd243672f Distribute extra space in fixed-layout tables where all columns have widths proportionally rather than equally, for compatibility. (Bug 445142) r=bernd sr=roc a=blocking1.9.1+ 2008-11-25 13:27:54 -08:00
L. David Baron
be3321e732 Simplify conditions, part 2, since we're really only trying to avoid IsGeometryDirty if we're not going to need any reflow at all. (Bug 438509) r=dholbert sr=roc a=blocking1.9.1+ 2008-11-25 13:27:53 -08:00
L. David Baron
c0cc02dfd5 Simplify condition, part 1, since mVResize already implies IsGeometryDirty thanks to the code immediately above. (Bug 438509) r=dholbert sr=roc a=blocking1.9.1+ 2008-11-25 13:27:53 -08:00
L. David Baron
3dbd3c34af Avoid exponential growth of special height reflows. (Bug 438509) r=dholbert sr=roc a=blocking1.9.1+ 2008-11-25 13:27:53 -08:00
L. David Baron
58064fc1f3 Remove nsHTMLReflowState::mPercentHeightReflowInitiator, which is write-only. (Bug 438509) r+sr=roc a=blocking1.9.1+ 2008-11-25 13:27:53 -08:00
Robert O'Callahan
a722f955fd Bug 462972 - 'Fix nsChangeHint comparisons'. r=bernd, sr=dbaron 2008-11-04 14:03:14 -08:00
Bernd
4b7f58df3e bug 462849 degenerated colgroups can be empty r/sr=bzbarsky 2008-11-03 19:30:38 +01:00
Robert O'Callahan
e639c5c883 Bug 442304. Don't try to clip table cells in %-overheight situations in quirks mode. (Basically we're just removing a quirk here.) r=bernd,r+sr=dbaron 2008-11-03 14:01:49 +13:00
Bernd
7c0832937a bug 286797 dynamic changes of the border color require a update of the cellmap as there is stored where a new segment starts. This is used by painting. r/sr=bzbarsky 2008-11-02 19:41:35 +01:00
Bernd
62d4cebdde bug 258377 remove inline on PeekStyleData so that it can be called from the layout library r/sr=bzbarsky 2008-11-01 09:52:29 +01:00
Benjamin Smedberg
9696613a50 Relanding bug 461410 - nsILineIterator is never used outside of layout - set nsresults to replicate the existing code more correctly, which fixes the mochitest failures, r+sr=roc with nits noted by Mats Palmgren 2008-10-30 12:17:59 -07:00
Benjamin Smedberg
4214b72dd5 Backed out changeset d4c9a0776667 (deCOM nsILineEnumerator) due to regression from it or bug 461212 2008-10-28 02:49:14 -04:00
Benjamin Smedberg
dd4c950cff Bug 461410 - nsILineIterator is never used outside of layout, and doesn't need to be refcounted: the callers can just destroy it when they're done with it. We can't do this with a virtual destructor, however, because nsTableRowGroupFrame implements the interface directly, while nsLineIterator is a separately-allocated class. So clients are expected to call DisposeLineIterator when they're done with it.
Instead of accessing nsILineIterator using QueryInterface, we add a nsIFrame::GetLineIterator API, which is cleaner and more efficient all at the same time!

r+sr=roc
2008-10-28 00:47:19 -04:00
Bernd
6f6f59a250 mac build bustage disable the code in question 2008-10-26 13:06:28 +01:00
Bernd
d84cc10e42 trying to fix mac burning 2008-10-26 11:56:39 +01:00
Bernd
6777c42861 bug 258377, make border collapsed tables to listen for dynamic border style changes r/sr=bzbarsky 2008-10-26 11:11:34 +01:00
Bernd
b17b2cbcd4 bug 360422 remove obsolete code r/sr=bzbarsky 2008-10-26 10:24:59 +01:00
Bernd
f08db4eb5c bug 451170, avoid hanging by going to the next frame instead of quering the same frame again. r/sr=bzbarsky 2008-10-26 10:20:42 +01:00
Robert O'Callahan
85ea5a3965 Bug 460240. Need to repaint the overflow area if the overflow area changes, the frame has effects/outline/box-shadow, and the frame size has not changed. r+sr=bzbarsky 2008-10-21 20:42:28 +13:00
Mats Palmgren
d7a5093ec9 Subtract the row index from the row count, not the col count. b=284852 r=bernd sr=bzbarsky 2008-10-19 10:25:14 +02:00
Bernd
ffc4c848b4 trigger fixed layout if the width cahnges from auto to fixed, bug 426629r/sr=dbaron 2008-10-18 19:25:26 +02:00
Jesse Ruderman
cff82b676c Add bug 370897 crashtest 2008-10-16 14:49:40 -07:00
Mats Palmgren
f4da1f1107 Regression test for bug 300912. 2008-10-13 01:53:44 +02:00
Arpad Borsos
8b11d938d2 Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan 2008-10-10 17:04:34 +02:00
Bernd
316d5ec8e1 add comment for bug 76331 as requested by the reviewer 2008-09-27 13:25:28 +02:00
Bernd
7988560536 use the right method to insert more than one frame, bug 456041 r/sr=bzbarsky 2008-09-27 13:07:29 +02:00
Zack Weinberg
a64209d05b Bug 456792 - Two more API cleanups for nsCSSRendering; patch 1; r+sr=roc 2008-09-25 17:53:27 +02:00
L. David Baron
bb1dbb4eec For fixed-layout tables, leave room for the cell spacing for all columns, whether they have cells originating in them or not, since we don't know if cells for those columns will arrive as the table loads incrementally. (Bug 444928) r=bernd sr=roc 2008-09-24 10:14:35 -07:00
Zack Weinberg
7687ccc76b Bug 456152 - slight API cleanup for nsCSSRendering::PaintBackground; r+sr=roc 2008-09-24 06:07:22 +02:00
Bernd
5afcd8c5a4 make sure that the height from a fixed height tbody gets distributed, bug 439639, r=dholbert, sr=roc 2008-09-20 11:30:30 +02:00
Robert O'Callahan
f79290bb0e Bug 450930. Fire a DOM event when painting so that content and chrome can track what's being repainted. r=smaug,sr=dbaron 2008-09-18 21:47:21 +12:00
Bernd
3df8e64982 CSS 2.1 empty-cell handling of the excotic cases, bug 76331, r/sr=roc 2008-09-13 16:38:29 +02:00
L. David Baron
b4d9cdbfa1 Convert border spacing storage from nsStyleCoord to nscoord. (Bug 443057) r+sr=bzbarsky 2008-09-12 20:45:37 -07:00
Zack Weinberg
0f68a207ca Bug 453916: treat transparency strictly as a special case of color alpha. r+sr=dbaron 2008-09-12 08:35:53 -07:00
Ted Mielczarek
468a3823fc bug 447642 - get rid of --disable-mochitest, replace MOZ_MOCHITEST with ENABLE_TESTS. r=bsmedberg 2008-09-09 13:59:11 -04:00
Graeme McCutcheon
b6ce570b3c Bug 451252 - "Highlight All" find selection not visible in elements that have -moz-user-select: none set; r+sr=roc 2008-09-07 16:12:50 +02:00
Jesse Ruderman
c8a8a43522 Add bug 392132's testcase as a crashtest 2008-09-06 22:37:29 -07:00
Bernd
321a788704 CSS 2.1 compliance empty-cells does not apply in border-collapsed tables, initial patch by William Wedin, bug 392047, r/sr=roc 2008-08-26 09:59:34 +02:00
Bernd
35ddb1c278 remove obsolete assert and comment bug 430374 r/sr=bzbarsky 2008-08-24 10:06:57 +02:00
Boris Zbarsky
d9344bb542 Bug 449362 - "Table border is rendered incorrectly when the table cell size changes due to javascript." [r+sr=roc] 2008-08-20 01:45:29 -05:00
Robert O'Callahan
86e7983c19 Bug 423823. Clip overflowing background when tbody is scrollable. r=fantasai,sr=dbaron 2008-08-16 21:10:29 +12:00
Justin Dolske
effb24337d Backed out changeset 7362e63c648e (relanding bug 449422) 2008-08-13 20:49:57 -07:00
Justin Dolske
b2d3e7aa5b Backed out changeset e7c43898c379 2008-08-13 16:29:57 -07:00
Boris Zbarsky
4ba9e11774 Bug 449422. Assert early and hopefully not often when table-row frames have the wrong display type. r=bernd, sr=roc 2008-08-07 17:05:19 -04:00
Mats Palmgren
0443739378 Manually calculate the overflow area contribution from our children when not reflowing them. b=428278 r=bernd sr=dbaron 2008-08-07 16:19:33 +02:00
Boris Zbarsky
51736fd513 Bug 416845 tests 2008-08-06 17:38:25 -04:00
Mats Palmgren
d0d73a5ec1 Bug 416845. Use the right x position when distributing height to rows. r=bernd, sr=bzbarsky 2008-08-06 16:53:36 -04:00
Bernd
c98687f036 make the table column dimension setting rtl aware bug 89856 r/sr=roc 2008-08-04 09:27:32 +02:00
Bernd
2b01da090f make sure that we initialize the BCDamageArea bug 351068 r/sr=bzbarsky 2008-08-04 09:14:39 +02:00
Andrew Smith ext:(%2C%20Rob%20Arnold%20%3Ctellrob%40gmail.com%3E%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
49c9b3d67e Implement css3 border-image property. (Bug 378217) r=vlad,dbaron,robarnold 2008-07-16 23:30:25 -07:00
L. David Baron
9e4ceade8e Backed out changeset 9b0b2391485c due to linker errors related to nsStyleStructInlines.h not being included enough. 2008-07-16 22:59:14 -07:00
Andrew Smith ext:(%2C%20Rob%20Arnold%20%3Ctellrob%40gmail.com%3E%2C%20L.%20David%20Baron%20%3Cdbaron%40dbaron.org%3E)
bb4be48531 Implement css3 border-image property. (Bug 378217) r=vlad,dbaron,robarnold 2008-07-16 22:18:38 -07:00
Bernd
8346cb9495 limit mathml row- and colspans as we do for html bug 443089 r/sr=bzbarsky 2008-07-16 17:02:18 +02:00
Zack Weinberg
58cf580d4a Remove eStyleUnit_Chars and the special cases for it throughout layout, and make ch units go through the normal eStyleUnit_Coord cases. (Bug 363706) r+sr=dbaron 2008-07-15 14:31:36 -07:00
Robert O'Callahan
7e15def36c Bug 444688. Use an IsFrameOfType check instead of a frame state bit to detect whether a frame excludes ignorable whitespace children. r+sr=dbaronlayout 2008-07-14 10:41:18 +12:00
mats.palmgren@bredband.net
0139c4c667 Wallpaper a crash. b=430814 r=bernd sr=roc a1.9=mconnor 2008-04-27 14:10:23 -07:00
dholbert@cs.stanford.edu
5e90a6931d Bug 428521: Allow DistributeWidthToColumns to complete BTLS_PREF_WIDTH runs in situations with guess_min < aWidth <= guess_pref. (Reverts optimization from 368504 in which I'd thought that a run with aWidth <= guess_pref would be skippable) r+sr=dbaron a=beltzner 2008-04-24 11:48:34 -07:00
jruderman@hmc.edu
47059fe1c7 Add a crashtest 2008-04-22 21:34:53 -07:00
roc+@cs.cmu.edu
35910e2c7c Bug 316500. Fix merge regression so that fixed-background tables display correctly. r+sr=mats,a=damon 2008-04-21 15:00:48 -07:00
dholbert@cs.stanford.edu
cd2cd226bc Bug 409084: When determining if a row or rowgroup isTopOfPage, check if the previous row has positive YMost, rather than just checking if there *is* a previous row. r=bernd sr=dbaron a1.9=beltzner 2008-04-17 11:18:41 -07:00
dbaron@dbaron.org
646994512a Don't let columns with no cells originating in them expand in the pass for expanding zero-width columns. b=425972 r=dholbert sr=roc a=blocking1.9+ 2008-04-08 12:07:16 -07:00
roc+@cs.cmu.edu
d0931d8767 Bug 422678. Table rows whose style-height doesn't fit in the available height (but whose cells do) should be marked incomplete during reflow. r=bernd,sr=dbaron 2008-04-08 05:28:34 -07:00
timeless@mozdev.org
2901e3ff19 Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore 2008-04-07 23:18:35 -07:00
bmlk@gmx.de
9a1928e320 lookup all columns for possible originating cells, bug 426706 r/sr=bzbarsky a=beltzner 2008-04-06 05:16:45 -07:00
bmlk@gmx.de
8e66beaecd initialize all border parameters so that the border is initialized even for empty rowgroups bug 424434 r/sr=bzbarsky a=mtschrep 2008-04-06 05:12:04 -07:00
roc+@cs.cmu.edu
4f41fd4761 Bug 416735. When a table frame paints the backgrounds for all its parts, make sure those parts notify the table frame display item when they are background-attachment:fixed. r+sr=dbaron 2008-04-06 04:34:14 -07:00
dholbert@cs.stanford.edu
e8be5abb47 Whitespace-only change: clean up parameter indentation in nsTableRowGroupFrame 2008-04-02 14:52:04 -07:00
bzbarsky@mit.edu
8deea0cbbf Invalidate the original overflow rect too when the frame moves. Bug 424766, r+sr=roc 2008-04-01 16:27:25 -07:00
bzbarsky@mit.edu
b55f4a5c9e Invalidate things correctly when the caption or inner table is resized. Bug 424465, r=bernd, sr=roc 2008-04-01 14:53:19 -07:00
jruderman@hmc.edu
27d6d56cb6 Add crashtest 2008-03-27 00:03:22 -07:00
bmlk@gmx.de
ce0b61a41b lookup all columns for possible originating cells, bug 423514 r/sr=bzbarsky a=mtschrep 2008-03-26 22:03:02 -07:00
bmlk@gmx.de
230b1fc082 use the firstinflow when looking up rowgroups bug 424291 r/sr=bzbarsky a=mtschrep 2008-03-21 13:37:31 -07:00
dbaron@dbaron.org
06705510dc Additional fix on top of roc's patch for bug 421069 to fix the regression it caused. r=dholbert approval1.9b5=damon 2008-03-20 18:19:13 -07:00
dbaron@dbaron.org
128863679e Don't do translation during table border painting. b=421069 Patch by Robert O'Callahan <roc@ocallahan.org>. r+sr=dbaron approval1.9b5=damon 2008-03-20 18:18:30 -07:00
dbaron@dbaron.org
c633f035a4 Backing out bug 421069 (which I landed earlier today for roc) because it caused bug 424016. 2008-03-19 22:58:00 -07:00
dbaron@dbaron.org
9e7d833654 Don't do translation during table border painting. b=421069 Patch by Robert O'Callahan <roc@ocallahan.org>. r+sr=dbaron 2008-03-19 16:02:38 -07:00
dbaron@dbaron.org
f31447da64 Fixing asymmetry between what timeless landed for bug 394114 and what he backed out. 2008-03-19 15:05:04 -07:00
timeless@mozdev.org
f33eb4a3b4 reverting, wrong patch, missing AMBIGUOUS 2008-03-19 14:55:22 -07:00
bzbarsky@mit.edu
71f4c3f4b8 Comment fix 2008-03-16 17:22:54 -07:00
bzbarsky@mit.edu
b607f1de90 Invalidate tables a little harder. Bug 421632, r+sr=roc 2008-03-16 13:32:48 -07:00
jruderman@hmc.edu
72906022c3 Add a crashtest 2008-03-08 22:37:45 -08:00
surkov.alexander@gmail.com
17652cbd2d Bug 416742 - Regression: multiple rowgroups interfere with getColumnAtIndex(), r=bernd, sr=roc, a=beltzner 2008-03-07 02:14:35 -08:00
dbaron@dbaron.org
898743fc16 Compute the shrink-wrapping size of table outer frames correctly. b=363402 r+sr=roc a1.9b4=beltzner 2008-02-28 09:55:04 -08:00
dbaron@dbaron.org
6447298324 Fix horizontal positions of top and bottom captions in the presence of non-left-aligned tables. b=363248,386704 r+sr=roc a=blocking1.9+ 2008-02-26 18:03:11 -08:00
dbaron@dbaron.org
a6ec36aaa1 Make 'top' and 'bottom' captions follow the CSS2.1 behavior and put the old behavior into 'top-outside' and 'bottom-outside'. b=363248,386704 r+sr=roc a=blocking1.9+ 2008-02-26 18:02:20 -08:00
dbaron@dbaron.org
5ddc11de0c Split nsTableOuterFrame::OuterReflowChild. b=363248,386704 r+sr=roc a=blocking1.9+ 2008-02-26 18:01:33 -08:00
dholbert@cs.stanford.edu
efc080a9fb Bug 413180: Stop distributing span pct-width to cols when there are only 0-width cols left. r+sr=dbaron a=beltzner 2008-02-22 09:15:27 -08:00
dholbert@cs.stanford.edu
2bbfd20d93 Bug 413286: Let empty auto-width columns be expanded. r+sr=dbaron a=blocking1.9+ 2008-02-21 19:25:56 -08:00
bmlk@gmx.de
adfea54748 adding crashtests 2008-02-20 21:20:34 -08:00
bmlk@gmx.de
2821c28b31 expand the cellmap to cover empty content rows when rebuilding the cellmap bug 351326 r/sr=bzbarsky a=mtschrep 2008-02-20 21:11:36 -08:00
bmlk@gmx.de
31a48f3747 make the lineiterator interface for tables a little more sane bug 388700 r/sr=roc a=mtschrep 2008-02-20 12:22:18 -08:00
fantasai.cvs@inkedblade.net
d4dc37580f switch GetOverflowAreaProperty callers to GetOverflowRect b=417116 r+sr=roc a=roc 2008-02-19 23:08:55 -08:00
jag@tty.nl
057bc17743 Bug 73353: Clean up our MODULE/REQUIRES story. rs=dbaron, a=brendan 2008-02-18 00:50:04 -08:00
bzbarsky@mit.edu
b868c2220d Make sure that changes to the "span" attribute on a colgroup actually work. Bug 404309, r=bernd, sr=dbaron, a=beltzner 2008-02-14 20:19:28 -08:00
bmlk@gmx.de
e8a8395029 document the lineiterator interface and all its current flaws. Make :GetNextSiblingOnLine more efficient. bug 388700 r/sr=roc a=mtschrep 2008-02-09 09:10:58 -08:00
bzbarsky@mit.edu
8b8a07f4a7 Fix bug 416073: invalidate more things as needed during table reflow to prevent glitches. r+sr=roc 2008-02-08 01:36:32 -08:00
surkov.alexander@gmail.com
cb05baabd9 Bug 410052 - bustage fix on windows 2008-02-06 23:23:00 -08:00
surkov.alexander@gmail.com
d35a90484c Bug 410052 - Fix our nsHTMLAccessibleTable class so GetIndexAt and GetRowAtIndex and GetColumnAtIndex behave consistently, patch=me, marcoz, r=marcoz, me, bernd, sr=roc, blocking1.9+=dsicore 2008-02-06 23:03:26 -08:00
bzbarsky@mit.edu
5dd3d3e48e Don't invalidate the entire table just because we reflowed something inside it. Bug 414298, r+sr+a=roc 2008-02-06 14:01:41 -08:00
dholbert@cs.stanford.edu
ab4b6e0c48 Bug 403669 - Dirty the table geometry when we split row groups. r+sr=dbaron, a=blocking1.9+ 2008-01-26 17:54:48 -08:00
bmlk@gmx.de
b87613ce0a do not compare with a unconstrained size, bug 390049 r/sr=roc a=mtschrep 2008-01-19 22:42:31 -08:00
bmlk@gmx.de
d4884cc771 remove dead code, bug 282009 r/sr=roc a=mtschrep 2008-01-19 22:34:03 -08:00
dholbert@cs.stanford.edu
2d3395bf81 Bug 368504: Create and use DistributeWidthToColumns for colspan-width and table-width distribution. r+sr=dbaron a=blocking1.9+ 2008-01-17 20:18:21 -08:00
mats.palmgren@bredband.net
41aa517a29 Add a null-check to wallpaper bug 411582. b=411582 r+sr=bzbarsky a=mtschrep 2008-01-15 15:29:53 -08:00
jruderman@hmc.edu
2bf3a7eca8 Adding a crashtest 2008-01-06 15:27:19 -08:00
jruderman@hmc.edu
e177e1b027 Add crashtest 2008-01-05 22:17:05 -08:00
jruderman@hmc.edu
dd56ef7661 Add crashtest 2008-01-05 21:03:55 -08:00
jruderman@hmc.edu
235c9a0f6e Add crashtests 2008-01-04 23:01:34 -08:00
jruderman@hmc.edu
1bad4bbffe Add a crashtest 2008-01-04 20:48:46 -08:00
jruderman@hmc.edu
36782297d9 Add crashtest 2008-01-04 20:14:54 -08:00
jruderman@hmc.edu
09a23e534c Add crashtest for WFM bug 2008-01-04 17:31:25 -08:00
roc+@cs.cmu.edu
fb28ffc853 Bug 407889. Reduce dynamic memory allocations during event handling by having nested invocations of HitTest share a single buffer for reordering display items; this buffer is an nsAutoTArray so it's mostly stack-allocated. r+sr=mats 2008-01-03 18:08:29 -08:00
roc+@cs.cmu.edu
0162b3ede9 Bug 408749. Reflow captions with unconstrained height, because we have no logic to reflow their continuations. r+sr=bzbarsky 2007-12-20 19:25:36 -08:00
jruderman@hmc.edu
82a6f4d33e Add crashtest 2007-12-16 22:38:48 -08:00