Commit Graph

2901 Commits

Author SHA1 Message Date
L. David Baron
0e7ae1f64b Bug 563195: Add -Wshadow to CFLAGS/CXXFLAGS for layout/style. r=ted
Since this directory has FAIL_ON_WARNINGS set, this will cause any
shadowing warnings triggered by headers included in layout/style to
cause errors.

Once this patch is reviewed, I'll write and attach patches to fix the
warnings needed to land this.
2013-02-17 22:56:32 -08:00
L. David Baron
a418f3704b Bug 563195: Fix -Wshadow warnings in layout/style. r=bzbarsky 2013-02-17 22:56:32 -08:00
Zack Weinberg
f03df97325 Bug 842134: fix serialization of unquoted url() in CSS. r=heycam 2013-02-17 22:03:55 -05:00
L. David Baron
27140199ac Bug 841983: Require whitespace around 'not', 'and', and 'or' keywords in @supports rules. r=heycam
Matches spec change in https://dvcs.w3.org/hg/csswg/rev/34b185ae3bac .
2013-02-16 21:29:38 -08:00
Zack Weinberg
324e50ea81 Bug 543151, part A4: unify the inner text-scanning loops used by GatherIdent, ScanString, NextURL. r=heycam 2013-02-16 18:27:53 -05:00
Zack Weinberg
59b9cbc048 Bug 543151, part A3: convert the scanner to use peek/advance. r=heycam 2013-02-16 18:27:53 -05:00
Zack Weinberg
781c8690dc Bug 543151, part A2: Introduce the new peek/advance API and reimplement the old read/pushback API on top of it. r=heycam 2013-02-16 18:27:53 -05:00
Zack Weinberg
ad3efbd714 Bug 543151, part A1: Preliminary cleanups to the scanner/parser interface and the organization of nsCSSScanner.cpp. r=heycam 2013-02-16 18:27:53 -05:00
L. David Baron
1162fa289b Bug 781360 patch 4: Remove the Get from nsStyleContext::GetStyleData and nsIFrame::GetStyleDataExternal, which never return null. r=dholbert 2013-02-16 13:51:03 -08:00
L. David Baron
822b2ca3bc Bug 781360 patch 3: Rename {nsIFrame,nsStyleContext,nsComputedDOMStyle}::GetStyle* to Style*, since they can never return null. r=dholbert
Except for the changes in:
  layout/generic/nsIFrame.h (part)
  layout/style/nsComputedDOMStyle.h (all)
  layout/style/nsRuleNode.cpp (part)
  layout/style/nsStyleContext.cpp (part)
  layout/style/nsStyleContext.h (part)
(see patch 3b in the bug), this patch was written with the sed script:
s/\<GetStyle\(Font\|Color\|List\|Text\|Visibility\|Quotes\|UserInterface\|TableBorder\|SVG\|Background\|Position\|TextReset\|Display\|Content\|UIReset\|Table\|Margin\|Padding\|Border\|Outline\|XUL\|SVGReset\|Column\)\>/Style\1/g
2013-02-16 13:51:02 -08:00
L. David Baron
e1162bb557 Bug 781360 patch 2: Rename nsRuleNode::GetPresContext to PresContext, since it can never return null. r=dholbert 2013-02-16 13:04:54 -08:00
L. David Baron
f756f736e2 Bug 781360 patch 1: Rename nsStyleContext::GetRuleNode to RuleNode, since it can never return null. r=dholbert
This makes it conform to our convention that getters returning pointers
that can never be null do not begin with "Get".

nsStyleContext's rule node is never null because we require a rule node
in order to construct a style context.
2013-02-16 13:04:53 -08:00
Daniel Holbert
5601dc5fa0 Bug 834107: Replace helper-function GetContainingBlockFor() with direct calls to nsIFrame::GetContainingBlock(), in nsComputedDOMStyle.cpp. r=dbaron 2013-02-16 10:34:34 -08:00
Jonathan Watt
9a999c1cb4 Bug 838256, part 2 - Overhaul and complete the layout pieces for <input type=range>. r=dholbert for the combined diff with the previous changeset. 2013-02-16 17:57:21 +00:00
Wes Johnston
e38c741da9 Bug 838256, part 1 - Initial work on the layout pieces for <input type=range>. DONTBUILD separately from jwatt's changeset (the next one) to finish this work. r=dholbert for the combined diff. 2013-02-16 17:57:21 +00:00
Daniel Holbert
567af6c177 Bug 841873 test changes: Tweak reftests/mochitests/crashtests to remove assumptions about the flexbox pref's default setting. (test-only) 2013-02-15 17:17:21 -08:00
Mounir Lamouri
dbbb67d3ea Bug 841828 - Show the appropriate cursor on disabled text fields. r=bz 2013-02-16 10:58:28 +00:00
L. David Baron
ba8841c136 Bug 841896: Rename CSSKeyframesRule.insertRule to appendRule to match spec change.
Note that this does not change the IID of nsIDOMMozCSSKeyframesRule
since neither the method signature nor semantics have changed; only the
name is different.
2013-02-15 21:38:34 -08:00
L. David Baron
63fdfec174 Bug 841789, patch 1: Rename nsIFrame::GetStyleContext() to nsIFrame::StyleContext() since it can never return null. r=dholbert
This makes it conform to our convention that getters returning pointers
that can never be null do not begin with "Get".
2013-02-15 21:38:33 -08:00
Boris Zbarsky
824de2ea6e Bug 840898. Flag our nullable return value as actually being nullable. r=tbsaunde 2013-02-15 22:36:15 -05:00
Jesse Ruderman
41735266e9 Bug 840402 - Add some more values to property_database.js. r=dbaron 2013-02-15 18:42:48 -08:00
Avi Halachmi
22359abefa Bug 838758: Cache GradientStops instead of gfxPattern. r=jrmuizel
Our gfxPattern cache is currently way too specific, which causes lots of
unnecessary cache misses. The only thing that we actually need to key on is the
color stops.

This switches the cache to hold GradientStops instead of gfxPatterns. This
improves our cache hit rate and is simpler. It also avoids doing caching when
not using Azure, which currently has no benefit.

Average paint times results (in ms)
(on windows 7 x64, i7-3630qm, HD4000)
-------------------------------------
m-c
open: 3.5 close: 3.3

m-c cache-key
open: 2.6 close: 2.4

ux
open: 7.3 close: 5.2

ux cache-key
open: 6.9 close: 5.3
2013-02-15 20:54:49 +02:00
Trevor Saunders
60c334769d bug 840906 - densISupportsify nsDOMRGBCSSColor r=mccr8 2013-02-13 16:39:23 -05:00
L. David Baron
7621b6de00 Bug 840367: Fix misnaming of keyword IDs in nsCSSKeywordList.h. r=heycam 2013-02-13 11:53:56 -08:00
L. David Baron
973546e2ad Bug 836329: Fix regression handling 'rem' units in media queries. r=bzbarsky
I confirmed that the added tests fail without the patch and pass with
the patch.
2013-02-13 11:53:56 -08:00
Boris Zbarsky
83af484d87 Bug 833808 part 2. Add some utilities for working with selectors to inspector utils. r=dbaron 2013-02-13 10:11:53 -05:00
Boris Zbarsky
880e764352 Bug 618479 part 1. Clean up the nsTArray binary-insert code a little bit. r=jlebar,kinetik 2013-02-13 10:11:53 -05:00
Daniel Holbert
80fd9ba7fe Followup for Bug 840317: use an unsigned loop variable when iterating up to an unsigned value, to fix warnings-as-errors build error. r=bustage,trivial CLOSED TREE 2013-02-11 17:27:14 -08:00
Cameron McCormack
7d776dcf48 Bug 840317 - Re-evaluate media queries in scoped style sheets. r=dbaron 2013-02-12 11:48:44 +11:00
Cameron McCormack
d426c836aa Bug 655877 - Part 11b: Use the right hints when reflowing due to dominant-baseline change. r=jwatt 2013-02-11 17:22:16 +11:00
L. David Baron
f8ff60d603 Bug 765599: Make CSS insertRule methods throw SYNTAX_ERR when given an empty rule or more than one rule. r=bzbarsky
This implements the proposed spec clarification in
http://lists.w3.org/Archives/Public/www-style/2013Feb/0229.html which
makes us compatible with WebKit on the insertRule tests in this patch.

I confirmed that the test reports 7 failures without the patch, but
passes with the patch.  (I'm a little disturbed by the way our
testharness.js integration elides runs of successive passes.)
2013-02-09 22:56:49 -08:00
L. David Baron
a860d586f9 Bug 835007: Make 'transition-property: all' work as an item within a list. r=bzbarsky
No changes to the transition manager are needed since
nsTransitionManager::StyleContextChanged already makes the appropriate
calls to ConsiderStartingTransition for 'all', and that existing code
should work fine within a loop (just like the existing code to handle
shorthands or other property duplication works).
2013-02-09 22:56:49 -08:00
Robert Strong
5c07fa06f7 Back out Bug 678392 2013-02-08 16:52:12 -08:00
Stephen Pohl
9c1b816b92 Swipe availability check - Bug 678392 - [10.7] Add support for swipe animation as in Safari. r=smichaud 2013-02-08 13:57:28 -08:00
Alexandre Poirot
27e2713da8 Bug 821695 - Do not load videocontrols.xml if the audio/video tag does not need it. r=roc
--HG--
extra : rebase_source : 567194ec6ee1862af1d7988aa9a0c3b50f07788a
2013-02-01 08:47:55 -05:00
Boris Zbarsky
2a81855e95 Bug 837031. When unlinking a keyframe rule, make sure to DropReference on its declaration. r=smaug 2013-02-06 14:24:04 +00:00
Seth Fowler
9e646b4929 Bug 836124 - Replace GetCurrentFrameIsOpaque() with [noscript] FrameIsOpaque(aWhichFrame). r=joe 2013-02-04 14:22:30 -08:00
Jonathan Watt
312edf7655 Bug 835883 - Give the -moz-orient property an 'auto' value, and make that its initial value. r=dholbert. 2013-02-02 19:13:22 +01:00
Daniel Holbert
6ee3cf6e54 Bug 836604: Collapse nsStyleSet::GetContext()'s boolean parameters into a 'flags' parameter. r=bz 2013-02-01 08:02:29 -08:00
Ryan VanderMeulen
72b0f5eec0 Backed out changeset e521791fe3cc (bug 821695) for mochitest-2 orange.
--HG--
extra : rebase_source : 681bd3b9bf50fbc7c3f5a55a40f473180e10608b
2013-02-01 10:06:19 -05:00
Alexandre Poirot
2d12db67a2 Bug 821695 - Do not load videocontrols.xml if the audio/video tag does not need it. r=roc 2013-02-01 08:47:55 -05:00
L. David Baron
0eb63ee170 Bug 836530 followup: fix tests for new ASCII range. 2013-01-31 21:09:40 -08:00
L. David Baron
4a936c7846 Bug 836530: Make all non-ASCII characters be CSS identifier characters. r=bzbarsky
This is as was proposed in
http://lists.w3.org/Archives/Public/www-style/2013Jan/0394.html
and resolved in the CSS Working Group's teleconference on 2013-01-30.

This removes a difference between Gecko and other browsers.
2013-01-31 20:09:47 -08:00
Henri Sivonen
5636baf78e Bug 820508 part 2 - UA stylesheet for <main>. r=bzbarsky. 2013-01-29 14:31:45 +02:00
L. David Baron
c2221a17ac Bug 835169: Remove unused mapping into style of table cols attribute. r=bzbarsky 2013-01-28 21:16:22 -08:00
Peter Van der Beken
b9d2ae906f Fix for bug 816088 (webIDL bindings try to extract nsISupports from the global object in static properties in workers). r=bz.
--HG--
extra : rebase_source : 5668d9e01bff0fe7831d98018428856e5940a620
2012-12-03 17:07:49 +01:00
Ed Morley
bc0702d0d7 Backout f3c145bd1dd2 & 5075690572a9 for OS X startup failures 2013-01-28 11:08:21 +00:00
Peter Van der Beken
b46afdef94 Fix for bug 816088 (webIDL bindings try to extract nsISupports from the global object in static properties in workers). r=bz.
--HG--
extra : rebase_source : 68e5630591f6209e2af9c5cd2321fed8edd3de24
2012-12-03 17:07:49 +01:00
Ryan VanderMeulen
e8cdcbd932 Merge m-c to inbound. 2013-01-26 21:23:50 -05:00
Ryan VanderMeulen
94e8455af6 Merge m-c to fx-team. 2013-01-26 21:21:39 -05:00
Martijn Wargers
36f45cccf3 Bug 368740 - crashtest 2013-01-26 21:28:56 +01:00
Matthew Noorenberghe
efdff8b5c5 Bug 816803 - Add system metric and media query keyword to detect whether the current Windows desktop theme supports Aero Glass. r=jimm,sr=roc
--HG--
extra : rebase_source : 56b27cbbbcc0cde254ef7aa7087f11360c476390
2013-01-16 19:27:16 -08:00
Martijn Wargers
b0a912518c Bug 363950 - crashtest. 2013-01-26 14:15:30 +01:00
Mounir Lamouri
78aa4c4e95 Bug 819871 - Make ":-moz-placeholder" parsable but without any effect on styling. r=dbaron,bz 2013-01-24 09:30:28 +00:00
Chris Peterson
eab3c189d8 Bug 816298 - Part 1: Allow child elements to override -moz-user-select:none. r=ehsan
--HG--
extra : rebase_source : f4e08713be0691c25b22510977c978088655ec8b
2013-01-08 16:33:17 -08:00
John Daggett
698f1eb124 Bug 833624. Bump up size of int's in mOrder to allow more than 256 CSS properties. r=dbaron 2013-01-24 02:24:27 +09:00
Dão Gottwald
e7a08c52ce Bug 813550 - Location bar's placeholder in an RTL chrome should be aligned on the right. r=ehsan a=nonlibxul 2013-01-22 00:13:04 +01:00
Boris Zbarsky
889e1ea478 Bug 774980. Hook up nsCSSKeyframeRule to cycle collection. r=smaug 2013-01-18 23:32:12 -05:00
Mark Finkle
37f68aa322 Backout 3b91d62ca343 and 662d0cd47316 for test failures 2013-01-17 20:44:46 -05:00
Mark Finkle
3e021efaaa Bug 831123 - Disable CSS error reporting by default to improve pageload performance r=blassey r=jmaher 2013-01-17 18:38:47 -05:00
Trevor Saunders
9f0ad48b28 bug 822289 - remove NS_IMPL_CYCLE_COLLECTION_CLASS and friends r=mccr8 2013-01-12 07:40:33 -05:00
Cameron McCormack
5ec3748408 Bug 829363 - Make :scope match style scope roots. r=bzbarsky 2013-01-16 15:48:29 +11:00
Boris Zbarsky
0f2a047c94 Bug 827799. Apply clip to outer table frames as needed. r=roc 2013-01-15 14:04:24 -05:00
Trevor Saunders
ddbe49139b bug 830396 - add back nsIDOMCSSValueList r=bz 2013-01-14 12:29:27 -05:00
Mats Palmgren
6c53161814 Bug 786533 - Replace NS_MIN/NS_MAX with std::min/std::max and #include <algorithm> where needed. r=ehsan 2013-01-15 13:22:03 +01:00
Ehsan Akhgari
597517a42f Backed out changeset 5af4c6bd5104 (bug 827075) because it is no longer necessary 2013-01-14 16:21:54 -05:00
Cameron McCormack
c428579a9c Bug 828805 - Followup warning removal. 2013-01-13 11:45:23 +11:00
Cameron McCormack
c643ccbaed Bug 828805 - Followup build fix. 2013-01-13 11:17:00 +11:00
Cameron McCormack
572084f298 Bug 828805 - Implement SVG paint-order property. r=bz,roc 2013-01-13 10:27:53 +11:00
David Zbarsky
ae40c85085 Bug 827149 - Remove some uses of nsIDOMHTMLBodyElement r=bz 2013-01-12 16:53:01 -05:00
Seth Fowler
c3007a9ded Bug 811391 - Part 2: Tests. r=dbaron 2013-01-09 16:05:19 -08:00
Seth Fowler
221cb13546 Bug 811391 - Part 1: Ignore @page declarations involving viewport units. r=dbaron
* * *
Bug 811391 followup: Fix out-of-order init list, to fix build warning (treated as error).
2013-01-09 16:03:55 -08:00
Ehsan Akhgari
4754760218 Backed out 2 changesets (bug 811391) because of build bustage
Backed out changeset c20904b75bcc (bug 811391)
Backed out changeset f0a00bf2ba8e (bug 811391)
2013-01-12 16:05:11 -05:00
Brendan Dahl
d282d196eb Bug 827591 - Be more careful changing declarations on page rules. r=dbaron 2013-01-09 10:33:09 -08:00
Seth Fowler
3925c7d5bb Bug 811391 - Part 2: Tests. r=dbaron 2013-01-09 16:05:19 -08:00
Seth Fowler
ecc937ddc1 Bug 811391 - Part 1: Ignore @page declarations involving viewport units. r=dbaron 2013-01-09 16:03:55 -08:00
Daniel Holbert
6ad20ea285 Bug 829168: Mark layout/style as FAIL_ON_WARNINGS, on non-MSVC compilers. r=bz 2013-01-12 10:49:12 -08:00
Daniel Holbert
be140b9731 Bug 829369: Cast pointer-subtraction to a size_t (after ensuring it'll be nonnegative) when comparing it to a nsTArray's size, to fix signed/unsigned comparison build warning. r=dbaron 2013-01-12 01:56:15 -08:00
Chris Peterson
f913a80fc9 Bug 829344 - Part 4: Fix gcc -Wlogical-op warnings from PRBool/bool conversion. r=ehsan 2013-01-10 17:56:51 -08:00
L. David Baron
54f28b4875 Bug 822891: Make animationiteration events fire when we're running off-main-thread animations and throttling style changes. r=nrc 2013-01-11 09:53:14 -08:00
Zack Weinberg
576dd3ca60 Bug 413958: report the text of the offending line in CSS error messages. r=dbaron 2013-01-11 12:27:43 -05:00
Ms2ger
3c26b8b8e4 Merge latest PGO-green m-i changeset to m-c. 2013-01-11 14:48:33 +01:00
Ms2ger
3afadd016c Bug 825407 - Get rid of GetElementParent; r=mounir 2013-01-11 09:43:01 +01:00
L. David Baron
fc4d4d9f2a Bug 827687, patch 2: Be more careful walking segments. r=bzbarsky 2013-01-10 21:14:51 -08:00
L. David Baron
3ead73e907 Bug 827687: Fix edge case in calculation of whichIteration. r=bzbarsky 2013-01-10 21:14:51 -08:00
L. David Baron
7f995ece9b Bug 827717: Change record of CSS animation start to be before delay so that dynamic changes to animation-delay are honored. r=bzbarsky
This matches the CSS Working Group consensus recorded in
http://lists.w3.org/Archives/Public/www-style/2012Nov/0261.html , though
the spec hasn't yet been updated.
2013-01-10 21:14:51 -08:00
L. David Baron
e906bade03 Bug 827698: Use the length of the 'animation-name' list when determining how many animations to run. r=bzbarsky
NOTE:  The tests in test_animations.html fail without the patch; the
tests in test_shorthand_property_getters.html are only tangentially
related and pass both with and without the patch.
2013-01-10 21:14:51 -08:00
Trevor Saunders
0f5eb0fd07 bug 829288 - fix layout/ warnings on mingw r=dholbert 2013-01-10 02:04:09 -05:00
L. David Baron
f6c701d8f7 Bug 822721 followup: remove bogus assertion to fix orange. 2013-01-09 08:51:14 -08:00
L. David Baron
4ff18eaae8 Fix bustage from bug 822721. 2013-01-08 20:53:16 -08:00
L. David Baron
585c1005ff Bug 827704: Fix 'visibility' animation so that it doesn't animate between values when one of them is not 'visibile'. r=bzbarsky 2013-01-08 20:37:29 -08:00
L. David Baron
c9b4c7bd69 Bug 827579: Remove post-resolve callback concept from style system. r=bzbarsky 2013-01-08 20:37:29 -08:00
L. David Baron
2b0c14944b Bug 822721: Call CalcStyleDifference and process the style change list resulting from the miniflush we do to update throttled animations prior to seeing if we need to start transitions. r=bzbarsky
The CalcStyleDifference call is absolutely necessary even if we didn't
need to process the change list, because it causes the new style
context to have cached structs that we might need for a later
comparison.  This is important because, as an optimization, we only
compare structs that have been retrieved.  This optimization requires
that when we replace a style context, we fetch all the structs on the
new style context that had been fetched on the old style context (which
is normally necessary anyway in order to do comparison so we can process
the changes appropriately).

However, actually processing the change list is also necessary to fix
the bug; it's the actual change from the miniflush that matters here.
Based on dholbert's debugging information, I think it's mostly likely
because we were failing to process the UpdateOverflow hint.
2013-01-08 20:37:29 -08:00
Daniel Holbert
993adbf969 Bug 829112: Fix "comparison between signed and unsigned integer expressions" warnings in nsStyleSet.cpp. r=bz 2013-01-10 10:40:53 -08:00
Daniel Holbert
3ff7170bbe Bug 828838: Fix nsCSSRuleProcessor init-list order. r=heycam 2013-01-10 07:55:43 -08:00
Cameron McCormack
24f1ed33ac Bug 508725 - Part 6: Modify selector matching to take style scopes into account. r=dbaron 2013-01-09 10:25:48 +11:00
Cameron McCormack
38c06ea95f Bug 508725 - Part 5: Record the <style scoped> elements in scope in preparation for selector matching. r=dbaron 2013-01-09 10:25:48 +11:00
Cameron McCormack
e1fe24451a Bug 508725 - Part 4: Add a content flag representing whether an element is a scoped style root. r=dbaron 2013-01-09 10:25:47 +11:00
Cameron McCormack
58c56890d2 Bug 508725 - Part 3: Create a rule processor for each style scope. r=dbaron 2013-01-09 10:25:47 +11:00
Cameron McCormack
a357d10fde Bug 508725 - Part 2: Record on nsCSSStyleSheets whether they are for a <style scoped>. r=dbaron 2013-01-09 10:25:47 +11:00