The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
Switch to stdio for reading the file snippet. I can't figure
out how to cleanly read a minimum subset into a vector with
ifstream. Previously we were asking it to read zero bytes,
so the argument validation in read_box_from_buffer() was
rejecting the data without trying to parse it.
With this and the v0.0.9 changes to catch eof, we can remove
the expected fail on the street.mp4 test.
libvpx dropped vpx_mem_set_functions,
only use it if an external libvpx
is used and still has it.
update update.py
add vpx_dsp_rtcd.h
rebase disable_pthread_on_mingw.patch
add vp9_filter_restore_aligment.patch
drop msvc2015.patch
This conversion was done with the script:
find . -name '*.cpp' -o -name '*.h' -o -name '*.mm' -o -name '*.idl' | \
egrep -v 'cairo-win32-refptr.h|RefPtr.h|TestRefPtr.cpp' | \
xargs sed -i -e 's/mozilla::TemporaryRef</already_AddRefed</g' \
-e 's/TemporaryRef</already_AddRefed</g'
Manual fixups were performed in the following instances:
- We handled mfbt/RefPtr.h manually so as to not convert TemporaryRef itself
into already_AddRefed.
- The following files had explicit Move() calls added to make up for the lack
of a copy constructor on already_AddRefed:
dom/base/ImageEncoder.cpp
dom/media/MediaTaskQueue.{h,cpp}
dom/media/webaudio/PannerNode.cpp
- A redundant overload for MediaTaskQueue::Dispatch was deleted.
- A few manual fixups were required in mfbt/tests/TestRefPtr.cpp.
- Comments, using declarations, and forward declarations relating to
TemporaryRef in dom/canvas/ and gfx/layers/ were changed to refer to
already_AddRefed.
Calls to WrapRunnable* copy their arguments already; we don't need to
copy them a second time when constructing the actual runnable. In
addition to making things more efficient, this change also permits calls
to WrapRunnable to correctly handle objects that can only be moved, and
not copied.
vp9_thread.c has changed directories, which mach doesn't handle
properly, resulting in "No rule to make target" for the old source
file path.
Bump clobber for libvpx file renames.
Add a null buffer test.
Add a street.mp4 test.
We have trouble parsing gizmo.mp4, and the dom/media/gtest
already exposes the file, which is confusing since we apparently
can't have duplicates in TEST_HARNESS_FILES.
The street.mp4 test always fails because we don't catch
the eof in the rust code.