Benjamin Smedberg
24e7cb1f78
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
50621e4f9f
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
Benjamin Smedberg
d0b948876f
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Robert O'Callahan
a3a3951684
Bug 459613. When we tear down a textcontrol frame, tell its editor that we're blowing away the frame tree so it doesn't try to clear the spellcheck selection, which not only wastes time but does GetPrimaryFrame for during frame destruction which is a no-no. r+sr=mats
2008-12-12 21:34:43 +13:00
Markus Stange
7a9f82ce7e
Bug 462793 - Changing listbox selection with keyboard no longer scrolls to make the newly selected item visible, r+sr=roc
2008-11-04 15:38:16 +01:00
Benjamin Smedberg
4862de1d3d
Bug 461186 - nsTextControlFrame should not implement nsIPhonetic: there's only one caller, and that caller can use nsITextControlFrame directly. This is one less frame that implements an nsISupports-derived interface. r+sr=roc
2008-10-27 20:27:55 -04:00
Theppitak Karoonboonyanan
018ec4b25f
Bug 157546. The 'delete' key should delete an entire cluster. r=peterv,r+sr=roc
2008-10-16 20:44:32 +13:00
Mats Palmgren
426e3534c3
Ignore the keypress event if DOMEventToNativeKeyEvent() fails. b=456273 r=Olli.Pettay sr=jonas
2008-10-15 12:50:42 +02:00
Taras Glek
390adbe464
bug 455536: s/NS_ERROR_FAILURE/NS_ERROR_OOM/ outparamdelled nsNodeInfoManager::GetNodeInfo r+sr=jsr
2008-09-25 15:46:52 -07:00
Arpad Borsos
eef0edf9d5
Bug 454766 - Add suggested parentheses to layout/; r+sr=roc; (with nits by sgautherie)
2008-09-15 17:40:25 +02:00
Taras Glek
c26ce8e1ab
bug 450777:deCOMtaminate nsNodeInfoManager::GetNodeInfo r+sr=jst
2008-09-12 15:32:18 -07:00
Mats Palmgren
9dc386954b
Bug 446663. Make sure that if the user is typing in a text input its text input listener will get the events (so that undo/redo work and oninput is fired).
2008-07-31 17:34:11 -07:00
Zack Weinberg
3197060cbd
Delete nsLayoutUtils::GetAbsoluteCoord(); fold logic into callers and simplify. (Bug 437335) r+sr=dbaron
2008-07-17 16:37:12 -07:00
John Daniels
ef0fee1d70
Bug 419532 – deCOMtaminate nsICaret. r+sr=roc
2008-07-16 12:52:01 +02:00
neil@parkwaycc.co.uk
45ebee768d
Bug 444466 – Crash [@ nsTextControlFrame::PreDestroy()], r+sr=bz
2008-07-12 11:26:40 +02:00
jst@mozilla.org
54ae1d2978
Landing fix for bug 419716. Make us consistently deal how we're pass param tags to object tags when parsing XHTML. Patch by mrbkap@gmail.com and bent.mozilla@gmail.com, r+sr=jonas@sicking.cc, a=beltzner
2008-04-17 15:30:51 -07:00
dbaron@dbaron.org
72f25cf7a0
Backout bug 157546 (making the delete key delete by clusters) to fix blockers bug 419217 and bug 419406. Instead of removing the added test, mark now-failing tests as todo. a=damons
2008-04-14 18:04:18 -07:00
roc+@cs.cmu.edu
1bfe348601
Bug 425253. Propagate reflow-depth tracking through XUL box layout. r+sr=dbaron,a=damon
2008-04-09 21:39:41 -07:00
reed@reedloden.com
daf0485896
Bug 420499 - "Caret browsing mode wrongly engaged" (Mochitest) [p=chris@pearce.org.nz (Chris Pearce [cpearce]) r+sr=roc a=blocking1.9+]
2008-04-08 11:52:48 -07:00
timeless@mozdev.org
d7e775a7be
Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore
2008-04-06 05:28:34 -07:00
mats.palmgren@bredband.net
6132a1f02e
Disconnect the frame selection object from the pres shell earlier. b=421083 r+sr=roc a1.9=beltzner
2008-04-02 19:42:20 -07:00
masayuki@d-toybox.com
1ff185aac0
Bug 424989 Cannot use reconversion of IMEs from system menu at the focus being on textarea r+sr=roc, b1.9=jonas
2008-03-29 12:38:05 -07:00
timeless@mozdev.org
f33eb4a3b4
reverting, wrong patch, missing AMBIGUOUS
2008-03-19 14:55:22 -07:00
timeless@mozdev.org
8074fda8ae
Bug 394114 Interfaces missing from various QI implementations. r=jag sr=jag a=dsicore
2008-03-19 14:19:35 -07:00
masayuki@d-toybox.com
3dcfbbf7fc
Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) (retry) r+sr=roc, a1.9b4=beltzner
2008-02-28 07:28:37 -08:00
masayuki@d-toybox.com
f6e10b8d70
backing out the previous patch, becaused qm-centos5-01 dep unit test is orange
2008-02-28 05:59:25 -08:00
masayuki@d-toybox.com
22b844e897
Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) r+sr=roc, a1.9b4=beltzner
2008-02-28 03:01:56 -08:00
roc+@cs.cmu.edu
f19a84e63b
Bug 157546. 'Delete' key should delete entire cluster. patch by Theppitak Karoonboonyanan, r+sr=roc,a=schrep
2008-02-21 18:24:04 -08:00
reed@reedloden.com
8980f8d4ec
Back out patch from Theppitak Karoonboonyanan in bug 157546 due to test failures.
2008-02-20 03:10:16 -08:00
reed@reedloden.com
a82ed7e493
Bug 157546 - "[CTL-Thai] IM: <delete> key should delete WHOLE Thai "display cell"" [p=thep@linux.thai.net (Theppitak Karoonboonyanan) r+sr=roc a1.9=schrep]
2008-02-20 02:19:31 -08:00
reed@reedloden.com
017aad07f5
Back out Theppitak Karoonboonyanan's patch from bug 157546 due to a regression (bug 417745).
2008-02-15 12:20:55 -08:00
reed@reedloden.com
0aa97a6838
Bug 157546 - "[CTL-Thai] IM: <delete> key should delete WHOLE Thai "display cell"" [p=thep@linux.thai.net (Theppitak Karoonboonyanan) r+sr=roc a1.9=beltzner]
2008-02-14 21:30:34 -08:00
neil@parkwaycc.co.uk
dafb9ad144
Make XUL elements really native anonymous b=410119 r=smaug sr+a=sicking
2008-01-04 03:24:41 -08:00
reed@reedloden.com
b614a0a043
Bug 406407 - "Accelerators for textEdit should not be affected by keyboard group/level" [p=lolkaantimat@gmail.com (Evgeniy Ivanov) r+sr=roc a1.9=stuart]
2007-12-29 12:43:27 -08:00
reed@reedloden.com
874a80563f
Back out patch from bug 406047, as it is causing orange on Linux and Tp regression on Mac.
2007-12-14 00:55:08 -08:00
reed@reedloden.com
7ef5d7c383
Bug 406407 - "Accelerators for textEdit should not be affected by keyboard group/level" [p=lolkaantimat@gmail.com (Evgeniy Ivanov) r+sr=roc a1.9=stuart]
2007-12-13 23:20:32 -08:00
Olli.Pettay@helsinki.fi
2976ce8f18
Bug 368760, r=mats, sr=roc, a=blocking1.9+
2007-11-22 12:47:33 -08:00
Olli.Pettay@helsinki.fi
a6b454f086
Bug 388558, 'change' event isn't dispatched if user selects input field value from the autocomplete list, r=jst, sr=sicking, a=mconnor
2007-10-02 09:56:07 -07:00
joshmoz@gmail.com
df46920114
extra measure of security for password textfields on Mac OS X. b=394107 r=smorgan sr=roc
2007-09-27 09:01:32 -07:00
bzbarsky@mit.edu
11b0a24baf
Only update the select command for focused text inputs. Bug 394792, r=roc, sr=neil, a=roc
2007-09-14 15:33:40 -07:00
bzbarsky@mit.edu
32444ff39f
Make maxlength not affect initial values or scripted sets. Bug 345267, r+sr=mats, a=dbaron
2007-08-21 20:22:21 -07:00
bzbarsky@mit.edu
e234beb50d
Make auto-height abs-pos textfields with top and bottom offsets both set use their intrinsic height, per spec. Bug 385870, r+sr+a=dbaron
2007-08-21 20:07:25 -07:00
bzbarsky@mit.edu
e27b046432
Account for the padding on our anonymous div when sizing. Bug 388086, r+sr+a=dbaron
2007-08-02 15:06:00 -07:00
bzbarsky@mit.edu
38a4896ea0
Avoid doing some work when initializing textfields. Bug 221150, patch by
...
peterv and a little bit me, r=me, sr=roc
2007-07-24 17:11:22 -07:00
Olli.Pettay@helsinki.fi
471f24da3f
Bug 355367, textbox onchange doesn't fire if user tabs out and value changed in onkeydown, r=jst, sr=sicking
2007-07-20 16:19:19 -07:00
mrbkap@gmail.com
1ef0efdcd0
Backing out this change to see if it fixes the test failures.
2007-07-09 16:05:44 -07:00
mrbkap@gmail.com
5baf2ef023
Attempt to re-enable async reflow and painting in editor. bug 174823, r+sr=roc
2007-07-09 14:55:18 -07:00
jwalden@mit.edu
e3c4baccae
Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
2007-07-08 00:08:04 -07:00
mats.palmgren@bredband.net
db689821bf
Cleanup implementations of QueryInterface. b=385750 r+sr=dbaron r+sr=jst
2007-07-03 19:15:31 -07:00
Olli.Pettay@helsinki.fi
7ec10e025c
Bug 363089, Remove nsIDOMEventReceiver (this time passes mochitest), r+sr=jst
2007-05-14 02:11:38 -07:00
