Commit Graph

801 Commits

Author SHA1 Message Date
Dan Mills
fb99c9f85e fix bookmark deletion sync 2008-11-25 01:49:02 +09:00
Dan Mills
e5c9923591 add some debug chatter 2008-11-25 01:48:38 +09:00
Dan Mills
409940f099 clean up sync function, get last timestamp properly from post result, save correct snapshot at the end, only attempt to post changes to server if there are any changes at all 2008-11-25 01:04:14 +09:00
Dan Mills
46c108167d add tmp hack to work around server payload json decoding bug 2008-11-25 01:03:01 +09:00
Dan Mills
5b84631f1a enable batch upload, yay! 2008-11-20 10:38:53 +09:00
Dan Mills
e3f35ddd81 merge with upstream changes 2008-11-20 09:25:32 +09:00
Dan Mills
35bbc1b8c0 work with NewEngine 2008-11-20 09:21:12 +09:00
Dan Mills
48b9bd885e more NewEngine impl 2008-11-20 09:20:25 +09:00
Dan Mills
45c250d767 make it so filters can be called (to e.g. manually copy resource data out 2008-11-20 09:19:51 +09:00
Dan Mills
0ee5550418 attempt at fixing login/server setup, needs more work still 2008-11-20 09:18:35 +09:00
Dan Mills
5642c55e6b remove unused fields, add half-baked impl to get password from ui 2008-11-20 09:17:15 +09:00
Dan Mills
d8e17d1e30 add filter to wbo to set their id automatically based on uri 2008-11-20 09:16:08 +09:00
Dan Mills
a542b05bc8 collection class 2008-11-20 09:15:34 +09:00
Dan Mills
67f89e00ec add rsa gen debug messages 2008-11-20 09:15:16 +09:00
Dan Mills
14b5494b13 record import (cache) fix 2008-11-20 09:14:42 +09:00
Anant Narayanan
6fc8951de6 Fix redeclaration (bug #463870) 2008-11-13 01:51:24 +01:00
Dan Mills
cf0df0d424 cache crypto meta objects 2008-11-08 20:24:12 -08:00
Dan Mills
b12787f2f2 crypto changes: private keys get their own iv and salt, crypto meta records get a separate iv and no salt. various fixes in crypto code and other wbo related objects. fix crypto tests to match. 2008-11-08 02:00:33 -08:00
Dan Mills
7091144051 make sure records always have a data field that represents their state (e.g. for serialization); add some pki routines (createKeypair); add incoming/outgoing queue to NewEngine 2008-11-06 23:23:35 -08:00
Dan Mills
43d4c7b865 say sync complete when it is! 2008-11-06 19:19:32 -08:00
Dan Mills
6f6665b8e1 remove some sharing code, derive from NewEngine 2008-11-06 19:18:46 -08:00
Dan Mills
8d20157eb8 add a temp NewEngine class that will talk to the 0.3 server 2008-11-06 19:18:07 -08:00
Dan Mills
f617e369b1 lots o' fixes 2008-11-06 17:37:17 -08:00
Dan Mills
934870ff34 onException cleanup 2008-11-06 17:36:41 -08:00
Dan Mills
ac2f30d7d5 url -> uri 2008-11-06 17:36:19 -08:00
Dan Mills
32e411e1a4 print exception in async stack traces, skip async frames in async stack traces 2008-11-06 17:34:34 -08:00
Dan Mills
d918ddef75 use util module's stack formatter 2008-11-06 17:32:33 -08:00
Dan Mills
d3af90034a hg merge 2008-11-03 15:02:00 -08:00
Dan Mills
6151afb26d fix log4moz calls (new api), fix module imports for renamed modules 2008-11-03 15:00:38 -08:00
Dan Mills
11eb07f4eb remove lots of code that will not be needed with new server 2008-11-03 14:59:45 -08:00
Dan Mills
9e8b4efb40 remove server lock wrapper; change local lock to work with service.js local locking api 2008-11-03 14:57:59 -08:00
Dan Mills
8c5dd2449d makeUri: don't throw on invalid uris, return null instead 2008-11-03 14:56:56 -08:00
Dan Mills
aa849d577c log4moz api change: Log4Moz.Service is gone. There is now a Log4Moz.repository which will auto-instantiate to a LoggerRepository (but can also be set if one wishes to use a different one). Also includes some other minor changes, e.g. formatters are now optional (and default to a BasicFormatter if not provided) 2008-11-03 14:48:53 -08:00
Dan Mills
3de7d24138 Update Observers js module to latest version 2008-11-03 14:40:28 -08:00
Dan Mills
bf42503d89 add prefs js module 2008-11-03 14:40:09 -08:00
Dan Mills
644df6d0c3 remove dav.js (gone) and remote.js (resources now in resource.js) 2008-11-03 14:38:34 -08:00
Dan Mills
a8e372f80f add base record types for the new weave server api 2008-11-03 14:37:51 -08:00
Dan Mills
77c85160e0 updates to resource class, use a new Auth service with pluggable 'authenticator' objects 2008-11-03 14:36:29 -08:00
Dan Mills
3cc9e0fa65 bump version to 0.2.7 2008-10-16 12:32:40 -07:00
Dan Mills
6a2010fc4c disable bookmark sharing hooks 2008-10-16 12:30:30 -07:00
Dan Mills
75326713c1 Bug 443489: use the correct cookie xpcom interface 2008-10-16 12:29:21 -07:00
Dan Mills
14d2156bc7 Add some logging helpers to log4moz, written by myk 2008-08-19 17:28:02 -07:00
Dan Mills
7ff40bec59 Bug 450526: fix tag sync bug created by a typo in deepCopy. Fix by Mishail <mishail.mishail@gmail.com> 2008-08-14 17:23:11 -07:00
Dan Mills
e53290c477 catch exceptions from microsummaries that don't have a static title set 2008-08-13 15:23:15 -07:00
Dan Mills
72f3cc9e31 Bug 450396: password engine does not define a tracker 2008-08-13 15:19:56 -07:00
Dan Mills
1237305322 bump version to 0.2.6 2008-08-08 15:14:04 -07:00
Dan Mills
556e90536f merge upstream changes 2008-08-08 14:43:36 -07:00
Dan Mills
1f877adb30 move some code from the engine to remote.js; rename FileEngine to BlobEngine (since it doesn't actually sync complete files); clean up SyncEngine's sync method 2008-08-08 14:42:57 -07:00
Dan Mills
394f9d047f small fix in _fixParents; change reconcile to 1) not require a deepEquals to drop an incoming/outgoing command pair, merely a GUID match (we can do this because we know we'll drop server changes and use client ones, and because we know we'll actually do a fresh diff at the end to send commands to the server), and 2) check for creates of existing guids after the first pass (since we might find command pairs that go away and thus not hit that error) 2008-08-08 14:40:52 -07:00
Dan Mills
37058a3f80 whitespace fix 2008-08-08 12:34:01 -07:00
Anant Narayanan
2e689699eb Automated merge with ssh://anarayanan@mozilla.com@hg.mozilla.org/labs/weave 2008-08-07 20:00:46 -07:00
Anant Narayanan
c200956d6a Syncing for Awesome bar (bug 437133, r=thunder) 2008-08-07 20:00:35 -07:00
Dan Mosedale
f692f246c1 Fix a typo that could cause an error in appendDelta() 2008-08-06 14:51:41 -07:00
Anant Narayanan
f21fbf8051 Client-side OAuth support (bug 444528, r=thunder) 2008-08-04 17:34:21 -07:00
Anant Narayanan
94b9dfcd2e Automated merge with ssh://anarayanan@mozilla.com@hg.mozilla.org/labs/weave 2008-08-04 17:23:36 -07:00
Anant Narayanan
8d3528d073 Asynchronous bookmark sharing (bug 449113, r=thunder) 2008-08-04 17:23:23 -07:00
Dan Mills
f9a54a3f51 refresh clients on a timer when changed via the prefpane, otherwise just wait until next sync 2008-07-31 01:59:03 -07:00
Dan Mills
a0b0f5f888 sync client data when client prefs change 2008-07-31 01:02:41 -07:00
Chris Beard
1070b0cce4 UI for clients 2008-07-31 00:39:57 -07:00
Dan Mills
c5a94ec81c filter out invalid tags when applying edit commands 2008-07-31 00:21:22 -07:00
Dan Mills
010357f05a add a hack that supresses a strange error (this._remote.status.data is null, even though it was downloaded correctly) 2008-07-31 00:20:55 -07:00
Dan Mills
3fc5d0e8a1 fix typo in utils deepCopy 2008-07-30 23:37:21 -07:00
Dan Mills
691d0bae83 do log some stack traces 2008-07-30 22:53:27 -07:00
Dan Mills
7181afe98b have RemoteStore inherit from Store 2008-07-30 22:53:11 -07:00
Dan Mills
6b50b61a62 fix snapshot typos in SyncEngine 2008-07-30 22:52:49 -07:00
Dan Mills
0102f2cd60 more tab sync fixes, only disposing is left to fix; also allow the notify wrapper to pass along an optional data payload 2008-07-30 21:58:13 -07:00
Dan Mills
16810a84f4 get tab sync halfway working again, with fileengine 2008-07-30 00:05:09 -07:00
Dan Mills
eef307467c use client GUID (from ClientData) for FileEngine 2008-07-29 18:38:58 -07:00
Dan Mills
2dccefbe5d some more ClientData fixes; *do* wipe the server when there is no version file; upload the version file when needed; refresh ClientData on login 2008-07-29 18:34:10 -07:00
Dan Mills
26596e7d96 ClientData fixes; export to chrome as well 2008-07-29 18:15:13 -07:00
Dan Mills
a81ac5e9da Remote.put doesn't require the data arg anymore 2008-07-29 17:35:10 -07:00
Dan Mills
bbcd17ac62 mostly finish up ClientData impl 2008-07-29 17:34:21 -07:00
Dan Mills
25255efdbb allow Resource.put to have no data arg (in which case it will use its internal _data property) 2008-07-29 17:33:53 -07:00
Dan Mills
bd870bb118 initial client data module from chris+me 2008-07-29 15:44:36 -07:00
Dan Mills
59721cd147 Keychain's constructor doesn't need an identity anymore 2008-07-29 15:39:09 -07:00
Dan Mills
0ecc2cdce5 sync the *latest* 10 back-button entries per tab (not the earliest ones) 2008-07-29 15:37:59 -07:00
Dan Mills
7b63f59feb get crypto working with FileEngine 2008-07-29 12:04:41 -07:00
Dan Mills
acc0a427fd initial try to get crypto working with FileEngine 2008-07-29 11:03:06 -07:00
Dan Mills
58affe8131 Implement FileEngine 2008-07-25 17:02:43 -07:00
Dan Mills
a4fb63a8a0 print exceptions that come from engines 2008-07-25 16:54:37 -07:00
Dan Mills
c678010dcf split Engine into SyncEngine and FileEngine 2008-07-25 01:06:23 -07:00
Dan Mills
05a50f8f8b Default to not doing anything for resetGUIDs. Define an observer for subclasses to use 2008-07-24 19:29:11 -07:00
Dan Mills
ea65089051 when making deep copies of an object, default to alphabetically sorting the properties for adding 2008-07-23 15:46:48 -07:00
Dan Mills
8a7e0e07a2 only wrap the first 10 entries in a tab 2008-07-23 15:46:13 -07:00
Dan Mills
aaabd53604 merge upstream changes 2008-07-21 18:24:35 -07:00
Dan Mills
9ca663413e Fix network timeouts, make them take into account progress; re-upload new snapshot after 25 deltas 2008-07-21 18:23:51 -07:00
Dan Mosedale
533147ac4b Minor refactoring to allow for multiple application embeddings of Weave.
Also adds a Thunderbird embedding of weave and a fix to set the
username/password during verifyPassphrase (bug 446444), r=thunder@mozilla.com.
2008-07-21 18:12:27 -07:00
Dan Mills
b6cd1a1acd version bump to 0.2.5 2008-07-17 21:27:50 -07:00
Dan Mills
236663a98b fixes to request timeout code 2008-07-17 21:27:01 -07:00
Dan Mills
448faf27c3 time out requests after 30 seconds 2008-07-17 20:40:29 -07:00
Dan Mills
2e67371ec9 check at startup if the crypto module appears to be working and alert the user if not 2008-07-17 20:39:55 -07:00
Dan Mills
112006ce5f rollback last commit (1843a139184a), it causes cookie unit test to fail 2008-07-16 21:11:18 -07:00
Dan Mills
76d45e6917 Bug 443489: Use nsICookie2 interface instead of nsICookie. Patch by fabrice@bellet.info 2008-07-16 20:51:25 -07:00
Dan Mills
f1bea5c26d allow deep copies of objects to optionally copy object properties in alphabetical order. This is useful to guarantee the order in which they would be serialized as json (which may depend on the order in which properties are added) 2008-07-16 19:36:06 -07:00
Dan Mills
610f300600 during version check don't attempt to wipe the server when the version file isn't found (that was a workaround for old clients, before the version file existed) 2008-07-16 19:34:35 -07:00
Dan Mills
01d4a7e2f7 fix a strict warning when onComplete is null 2008-07-16 19:33:07 -07:00
Dan Mills
839d464575 version bump to 0.2.4 2008-07-12 21:08:36 -07:00
Dan Mills
cf199a8cbf fix sanity checks in getKeypair, cause key 404s to be interpreted as a success condition in verifyPassphrase, re-fetch keys after generating them in initialize 2008-07-12 20:58:19 -07:00
Dan Mills
b3f94ea68a fix verifyPassphrase() 2008-07-12 20:31:27 -07:00
Dan Mills
41dc6fa440 version bump to 0.2.3 2008-07-11 19:01:36 -07:00
Dan Mills
cd8154bbd9 rethrow exceptions the fault tolerance module says are bad. catch lock exceptions in the notify wrapper and don't rethrow them (hack) 2008-07-11 19:01:06 -07:00
Dan Mills
d734b12ae4 add last exception to fault tolerance module 2008-07-11 18:55:42 -07:00
Dan Mills
ffdc89548f login code refactoring 2008-07-11 17:40:52 -07:00
Dan Mills
f6d457946c beef up fault tolerance module and hook it up to the service 2008-07-11 14:47:15 -07:00
Dan Mills
94709c6381 move formatAsyncFrame to utils, don't print 'regular' stack trace when we have an async exception (it's not useful) 2008-07-11 13:40:06 -07:00
Atul Varma
0c474a106e Automated merge with http://hg.mozilla.org/labs/weave 2008-07-11 12:59:36 -07:00
Chris Beard
bfde197997 - added checks to see if registration is closed, and if so, shows a message to the user on the account creation pane.
- added description to 423 locking warnings, as they are not necessarily a bad thing.  temporary as we really need more reobust management of locking when multiple clients are potentially syncing at once.
- minor clean up of passphrase verification in the wizard. passphrase verification is still a bit buggy though...
2008-07-11 09:38:44 -07:00
Chris Beard
0d444333bb * sync on quit is now also skipped when there is a forced restart of the browser (e.g. updates, extension installs, etc.)
* formatting tweaks and cleanup for modal sync UI
2008-07-10 17:03:56 -07:00
Dan Mills
5a0524b185 merge upstream changes 2008-07-09 17:37:09 -07:00
Dan Mills
15995cac06 cosmetic cleanup to yield calls in the reconciler 2008-07-09 17:36:40 -07:00
Chris Beard
e9ac166a41 * major revision to the login dialog to be more robust, adding error handling, styling and a help link
* some minor hacking of the login progress to improve performance
* expanded the application exit sync dialog to be a general modal sync dialog that will display whenever appropriate (e.g. during initial setup, on manual "sync now" requests, and on application exit)
* added a progress meter and status messages to the modal sync dialog to provide users with a better understanding of what's going on, and to assist in debugging
* added ability to cancel a modal sync request, including on application exit. when cancel is clicked on by the user, it will attempt to cancel the sync at the next opportunity (i.e. before the next sync engine is processed)
2008-07-09 17:17:24 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
98215f2fc8 Made bookmarkSharingManager._updateOutgoingShare tolerant of outgoing shares that are lacking a server path annotation: it will warn that they're invalid and return, rather than dying. 2008-07-09 16:57:55 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
436fb329bb Made wrapping of outgoing shares not crash if an outgoing share is missing an exptected annotation. 2008-07-09 13:45:10 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
3cc4b5541f Restored a line in bookmarkSharingManager.js which I took out by accident when removing debugging dumps and stuff, changeset 969. It should not have been taken out; without it you get 'mounts undefined' error. 2008-07-09 13:24:49 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
3e2ccbce0c Removed a special menu item that I had installed in the main Weave menu just for debugging purposes. 2008-07-08 22:40:52 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
1ebd8b0a44 Merged 2008-07-08 22:39:12 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
a0611ee8e1 I think I have fixed updateIncomingShare now. So everything should work, if I share with a user not myself. 2008-07-08 22:39:05 -07:00
Dan Mills
c2bdb5473d bump version to 0.2.2 2008-07-08 21:25:15 -07:00
Dan Mills
e7a43d3f19 sync every 5 minutes (up from 1); start the score threshold at 75 (down from 100); decrement threshold by 25 each iteration (up from 5). these changes guarantee even small changes will sync in no more than 15 minutes (down from 20) 2008-07-08 21:24:59 -07:00
Dan Mills
011f9243a4 version bump to 0.2.1 2008-07-08 19:40:55 -07:00
Dan Mills
163332a45b remove 'waitOnQuit.enabled' pref, always wait for a running sync before quitting 2008-07-08 19:35:20 -07:00
Atul Varma
899b6df522 Automated merge with http://hg.mozilla.org/labs/weave 2008-07-08 16:51:08 -07:00
Atul Varma
33c970ec5e If an exception is raised by a notification button callback, it is now logged. Also added a unit test for this new behavior. 2008-07-08 16:50:59 -07:00
Dan Mills
33bac67100 merge upstream changes 2008-07-08 16:34:52 -07:00
Dan Mills
1a6a8397c4 Bug 444119: catch errors during a lock and avoid a deadlock 2008-07-08 16:34:27 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
7f36e552e6 Removed a bunch of dump statements that were in bookmarkSharingManager for old debugging stuff that is now done; they were just cluttering up the log. 2008-07-08 15:05:24 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
cfe420f221 updateOutgoingShare now explicitly encodes data to json before encrypting and uploading. 2008-07-08 14:52:31 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
5d937affe2 Fixed a typo in sendXmppNotification call 2008-07-08 14:51:14 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
386784122b Removed debugging dump statements from dav.js. 2008-07-08 14:37:51 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
2895b903a2 Fixed another trivial bug in BookmarkSharingManager._stopSharing that was making it fail at sending out the xmpp notification. 2008-07-08 14:19:26 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
55ec19cf3c Fixed some trivial bugs in BookmarkStore._wrapMountOutgoing that were preventing the outgoing share from working properly. 2008-07-08 14:15:55 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
2b8d2d7cb3 Factored the sending of xmpp notifications in bookmarkSharingManager out into a separate function, to save some duplicated code and make it easier to break xmpp stuff into a separate class later. Also made the bookmarkSharingManager cache the current weave username, which it uses a lot. Finally it now prepends /user/this._myUsername/ to server URLs to make them into absolute paths before sending them to the sharing partner over xmpp, which fixes a leftover TODO from a copule days ago. 2008-07-08 14:11:21 -07:00
Dan Mills
b0bede9548 sigh, my previous unlock change actually breaks unlock. fix fix fix. 2008-07-08 13:56:03 -07:00
Dan Mills
13c049d2de merge upstream changes 2008-07-08 11:59:28 -07:00
Dan Mills
31a5149a4c check that we have a local lock token before trying to delete it (or 'delete' will fail) 2008-07-08 11:58:59 -07:00
Pazu
318f20223c Sync on quit improvements.
A new preference called "waitOnQuit.enabled" was created. This preference controls whether Weave will perform any actions on quit. If false, Weave won't perform any actions on quit, nor wait for any running actions. If true, Weave will wait for any running sync to finish.

The old "syncOnQuit.enabled" preference now controls if Weave will actually perform a full sync on quit or not. If false, no sync is started, but we still wait for an active sync to finish, if waitOnQuit.enable is true.

Both options default to true.
2008-07-08 15:31:47 -03:00
Dan Mills
22d3e6a2d2 Move KeyPair object (which caches keys) to a property of the service. Clear it on logout 2008-07-08 18:37:14 -07:00
Pazu
e4dc334725 Clear KeyPair cache on server wipe, and make new key generation work again. 2008-07-08 17:06:21 -03:00
Pazu
795762882d Performance improvements: keypair is now fetched only once, and cached in memory. 2008-07-08 15:33:17 -03:00
Dan Mills
5082e5e422 keep track of errors during sync and throw after trying all engines 2008-07-08 17:44:00 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
acf0d0ded8 Merged 2008-07-08 01:18:40 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
1cf9a1dea9 Fixed a bunch of bugs in bookmark share: stuf related to server-side paths being incorrect (because the defaultPrefix in DAV was getting reset to an empty string or was getting applied wrong). Discovered that updateOutgoingShare and updateIncomingShare were both calling the same _wrapMount() function, which was incorrect, so I broke that up and fixed what parts are meant to be outgoing and which incoming. 2008-07-08 01:18:30 -07:00
Dan Mills
54a2a8a785 Bug 443385: unconditionally remove saved local token, regardless of whether the UNLOCK command succeeded; also cleans up some variable naming re: local locks in dav.js; cosmetic changes in wrap.js 2008-07-07 22:30:32 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
9cfef4be35 Fixed a whole bunch of bugs in bookmark share, mostly related to adding in needed JsonFilters for remote Resources and fixing the server paths which are passed into DAV for the keyring file and encrypted share data files. (Also fixed a minor bug in DAV itself so that mkcol won't quit right away if you pass it something that starts with a slash.) 2008-07-03 17:57:21 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
6732077b30 Merged 2008-07-01 14:41:12 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
f11ad3f3e3 Updated a couple of comments in bookmark sharing 2008-07-01 14:41:04 -07:00
Atul Varma
d70f1743f8 Automated merge with http://hg.mozilla.org/labs/weave 2008-07-01 12:03:12 -07:00
Atul Varma
7303b375dc Refactored the exception-handling code a bit and made traces produced by async look more like they used to. 2008-07-01 12:03:05 -07:00
Myk Melez
c5d6255581 make sure nsIObserverService notifications have subjects before accessing the subjects' wrappedJSObject properties 2008-07-01 11:29:20 -07:00
Atul Varma
0013cac9d2 Automated merge with http://hg.mozilla.org/labs/weave 2008-07-01 11:12:53 -07:00
Atul Varma
71372f5452 Tracebacks for async coroutines now provide a 'best guess' for where the coroutine was at the time that an exception was thrown, by showing the frame at which the generator's last continuation callback was created.
Added a 'location' property to RequestException, analogous to the 'location' property of wrapped nsIExceptions, so that tracebacks can be made for the exceptions if needed.
2008-07-01 11:12:00 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
11dda58df6 Fixed yet another typo: this._sharing._share, not this._sharing.share. 2008-07-01 10:35:15 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
b7f7372c9f Fixed typo where undefined value was getting passed into share and stopSharing: should be node.itemId, not node.id 2008-07-01 10:31:16 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
fd7f338963 Fixed missing import 2008-07-01 10:27:19 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
a410545ba4 Fixed another typo 2008-07-01 10:26:01 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
fcb7743ce0 Fixed typo in BookmarkSharingManager._bms initialization 2008-07-01 10:24:52 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
10d9360015 Merged 2008-07-01 10:18:43 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
ba7249a10a Made _share() and _stopSharing() take bookmark item ID numbers instead of XUL nodes. 2008-07-01 10:18:35 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
aa859a7626 Made _stopSharing and _stopOutgoingShare more fault-tolerant (they will no longer die if the expected annotation is missing. 2008-07-01 09:58:00 -07:00
Dan Mills
1556cc4511 version bump (0.2.0) 2008-07-01 00:04:47 -07:00
Dan Mills
e53b8d1689 merge upstream changes 2008-06-30 23:42:00 -07:00
Dan Mills
44c908db91 save username/pass in verifyLogin, at least for now 2008-06-30 23:41:47 -07:00
Atul Varma
994e224c7d Automated merge with http://hg.mozilla.org/labs/weave 2008-06-30 23:36:06 -07:00
Atul Varma
e04369a218 Modified sharing.js to obey the new sharing api. 2008-06-30 23:36:00 -07:00
Dan Mills
802f7a254d fix cookie command logging; skip cookie commands for items we don't have 2008-06-30 23:26:35 -07:00
Dan Mills
e9d12f341f continue if there is an edit command for an item we don't have (just print a warning) 2008-06-30 23:25:51 -07:00
Dan Mills
4c4dfecbc8 fix a missing yield, split up a couple of lines for clarity 2008-06-30 23:25:15 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
5d960d2e8f Combined shareData and stopSharingData into one function to reuse code; made it so that if it gets called when Weave.DAV is already locked, instead of failing it sets up an observer that will trigger the share to happen as soon as the sync-succeeded or sync-failed message is received. 2008-06-30 22:30:04 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
dae06b83f1 Added test_bookmark_sharing to version control; note this doesn't pass right now (and in fact the main test is commented out.) 2008-06-30 18:50:06 -07:00
Atul Varma
07f3aacf01 Added documentation for Service._getKeypair(). 2008-06-30 18:09:30 -07:00
Atul Varma
aa2cab9380 The auto-login at startup no longer unconditionally syncs; if the login fails, the sync is now aborted. 2008-06-30 17:55:48 -07:00
Atul Varma
d7ff36daab Fixed a bug from r5a5113a0a405 that caused some syncing unit tests to fail. 2008-06-30 16:55:38 -07:00
Atul Varma
7512505bb7 Added a Service.verifyPassphrase() method. Also, Service.login() now checks to ensure that the user's passphrase is valid, and if it's not, it throws an exception. 2008-06-30 16:50:19 -07:00
Atul Varma
bd11079518 Automated merge with http://hg.mozilla.org/labs/weave 2008-06-30 15:54:21 -07:00
Atul Varma
4c44bcd581 Fixed a potential bug in Service.login() whereby a user's directory wouldn't be created if it didn't exist (though it would in Service.verifyLogin(), which is only called from the setup wizard). 2008-06-30 15:54:15 -07:00
Myk Melez
ac691d002a Automated merge with ssh://hg.mozilla.org/labs/weave/ 2008-06-30 15:16:31 -07:00
Myk Melez
3f7efe892f bug 442711: validate virtual tabs to make sure they have the minimal information necessary to recreate them before trying to save them or notify the user about them 2008-06-30 15:13:07 -07:00
Atul Varma
3e6bb56f61 Moved isPassphraseValid() out of its test suite and into the crypto module. 2008-06-30 14:40:11 -07:00
Dan Mills
c66f11ca21 merge upstream changes 2008-06-30 14:01:10 -07:00
Dan Mills
d7df22716d change onQuit dialog to wait for a running sync in order to start the last sync 2008-06-30 14:00:55 -07:00
Dan Mills
32d1262667 style fixes, js warning fixes 2008-06-30 14:00:06 -07:00
Dan Mills
fdde68445a change AsyncException so it implements toString (which returns the original exception) 2008-06-30 13:58:42 -07:00
Anant Narayanan
7f8e383db6 Fix syntax errors that were causing unit tests to fail 2008-06-30 12:26:41 -07:00
Anant Narayanan
645c447eb6 Fix small bug with PasswordTracker returning scores > 100 2008-06-30 11:33:25 -07:00
Anant Narayanan
f7911b9746 Primitive password tracking support (bug 435320, r=thunder) 2008-06-30 11:19:07 -07:00
Dan Mills
8d3532f8e0 bump version 2008-06-29 17:40:49 -07:00
Dan Mills
cbd9cd6819 import async module 2008-06-29 17:37:11 -07:00
Dan Mills
a4ae67b71a define _resetGUIDs in store 2008-06-29 17:36:59 -07:00
Dan Mills
091c571bd1 import async module 2008-06-29 17:36:35 -07:00
Dan Mills
293b220818 use this._lookup instead of command.data for remove commands 2008-06-29 17:36:13 -07:00
Dan Mills
b32d63ca14 bump version 2008-06-29 11:54:26 -07:00
Dan Mills
3d16ec76a6 fix cooe engine's resetGUIDs method by importing async module; don't call runInBatchMode in bookmark engine's resetGUIDs, it doesn't work atm 2008-06-29 11:44:27 -07:00
Dan Mills
80417871c4 merge upstream changes 2008-06-29 07:07:11 -07:00
Dan Mills
e03543007a make resetguids async 2008-06-29 07:00:53 -07:00
Anant Narayanan
d2a1e9e87d Make PasswordStore process removeCommands correctly (bug 442090, r=thunder) 2008-06-28 01:13:14 -07:00
Anant Narayanan
089c1c0f42 General restructure for performance improvements (bug 441907, r=thunder) 2008-06-27 20:16:43 -07:00
Dan Mills
c0471ca320 make log messages that print raw engine json be trace messages 2008-06-27 14:21:54 -07:00
Dan Mills
1c1346203f merge upstream changes 2008-06-26 17:28:46 -07:00
Dan Mills
226de0e980 bump version to 0.1.32, storage format version (global & engine) to 3 2008-06-26 17:28:30 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
5856868591 Removed unneeded atob() and btoa() definitions from authenticationLayer. 2008-06-26 17:26:21 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
448ef4478e Merged 2008-06-26 17:01:12 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
d654677b9a Fixed several minor bugs with bookmark sharing 2008-06-26 17:00:55 -07:00
Dan Mills
9f77422143 merge upstream changes 2008-06-26 16:38:00 -07:00
Dan Mills
6f246308bc don't even try to sync when the local lock is taken 2008-06-26 16:37:38 -07:00
Atul Varma
b31c786d84 Automated merge with http://hg.mozilla.org/labs/weave 2008-06-26 16:28:55 -07:00
Atul Varma
aa4a046d61 Added an additional check in stores.js to prevent a strict warning from appearing. 2008-06-26 16:27:54 -07:00
Dan Mills
8bc8c1abbb when we abort a lock request because we already hold a token, reset _lockAllowed to allow further requests for locks 2008-06-26 16:26:14 -07:00
Anant Narayanan
62a0ebb31e Add license headers to all files which didn't have them. 2008-06-26 14:49:01 -07:00
Dan Mills
277753d21a tone down tab engine debugging output a bit 2008-06-26 14:34:32 -07:00
Dan Mills
703829a510 fix comment in verifyLogin 2008-06-26 14:30:38 -07:00
Dan Mills
5c7f8c6a40 check login status code in service's verifyLogin; attempt to create user directory when it's a 404 2008-06-26 12:27:54 -07:00
Dan Mills
6badbcac4d merge upstream changes 2008-06-26 12:23:07 -07:00
Dan Mills
2d3216c74e return http status code from dav's checkLogin 2008-06-26 12:22:19 -07:00
Anant Narayanan
dcb7a1ada2 Automated merge 2008-06-26 11:16:02 -07:00
Anant Narayanan
2339871cf6 Prevent multiple lock requests from being executed (bug 441922, r=thunder) 2008-06-26 11:15:02 -07:00
Justin Dolske
4abaf0f90c bustage fix: call this.foo(), not foo(). 2008-06-25 18:32:59 -07:00
Anant Narayanan
ee51a31ea5 Remove runCmd and other openssl related stuff we no longer need. (bug 441898, r=thunder) 2008-06-25 17:10:24 -07:00
Anant Narayanan
b53674f5dc Handle removeCommand in FormEngine correctly. (bug 441874, r=thunder) 2008-06-25 17:09:18 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
3f37543011 Set up bookmarkEngine._incomingShareOffer to use Myk's new Notification stuff to offer a notification to the user, asking them to accept or reject the incoming share. 2008-06-25 15:54:33 -07:00
Myk Melez
cab1d95570 bug 436636: a system for showing various kinds of notifications in one consolidated location 2008-06-25 13:51:39 -07:00
Myk Melez
b379fdece8 the tabs engine needs a constant 2008-06-25 13:51:32 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
6f37a50f99 The share/stop sharing menu item is now added only to normal bookmark folders: Not to the main bookmark menu or to magic folders like 'recently tagged' or whatever. 2008-06-25 11:58:04 -07:00
Atul Varma
92f85d952e Another automated merge. I'm kind of confused at this point, so I hope I'm not breaking anything by mis-merging. 2008-06-25 04:45:22 -07:00
Atul Varma
c747b0559e Automatic merge. 2008-06-25 04:44:25 -07:00
Atul Varma
37225f431c Changed AsyncException so that it dynamically subclasses the exception it's wrapping, and adds an 'asyncStack' property to allow access to the asynchronous call stack. This, along with my previous few commits, makes the processing of stack traces in our code much more streamlined, and also allows our debugging output to be more informative, as stack information is now logged from the point at which an exception was thrown, rather than the point at which it was caught.
Also renamed some things in async.js to be more descriptive and easier-to-understand, albeit a bit more verbose.
2008-06-25 04:43:07 -07:00
Myk Melez
be2bf638be bug 441446: set mozBackgroundRequest on XMPP request object when created rather than when used, since it only needs to be set once 2008-06-25 01:56:17 -07:00
Justin Dolske
b015539e7a Split account verification out from login(), make wizard work for using an existing account, related code cleanup/simplification 2008-06-25 00:22:53 -07:00
Atul Varma
9d7f1afc80 Made exception logging routines more informative and added logtests for them. 2008-06-25 00:13:36 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
1d19d1357f Merged 2008-06-24 21:15:23 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
b24d0c7180 Moved all of the bookmark-share stuff out of the bookmarkEngine class into a new BookmarksSharingManager class. 2008-06-24 21:15:14 -07:00
Atul Varma
7b4737aed7 Fixed something that I should've changed in my last commit; also removed a call to Utils.stackTrace() that shouldn't have been made. 2008-06-24 19:58:50 -07:00
Justin Dolske
e25d17c184 Bustage fix: frame.filename can be null, and the async stack dump can then fail (which causes other problems) 2008-06-24 19:39:58 -07:00
Atul Varma
7327a55d0d Renamed AsyncException.trace and Generator.trace to AsyncException.traceback and Generator.traceback, respectively, to distinguish them from Logger.trace() and also explicitly indicate their noun-like nature (since they're properties). 2008-06-24 19:15:54 -07:00
Atul Varma
caa3295271 Renamed the global trace() function in async.js to traceAsyncFrame(), to avoid confusing it with Logger.trace(), AsyncException.trace, and Generator.trace, all of which are also used in that file. 2008-06-24 19:08:35 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
bc4d891c3a Moved the folder name and annotation for the incoming shares root folder to string constants. 2008-06-24 18:38:29 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
fcd94e31e2 Fixed all the places where I was accidentally calling it incomingShareAnno instead of incomingSharedAnno (note the missing letter d). Same for outgoingSharedAnno. 2008-06-24 18:28:01 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
4cba1fd51c Removed all uses of the 'weave/mounted-shares-id' annotation, since it's been made obsolete by INCOMING_SHARED_ANNO. 2008-06-24 18:23:43 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
0edbf9998f Changes in the annotations relevant to incoming/outgoing share folders are now handled by editCommands in the syncCore. 2008-06-24 18:15:17 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
4bc77b8e05 Annotations on incoming and outgoing share folders are now wrapped for sync, and handled on incoming createCommands. 2008-06-24 18:09:41 -07:00
Myk Melez
8dcf0279c4 bug 441446: set mozBackgroundRequest on XMPP request object when created rather than when used, since it only needs to be set once 2008-06-24 17:45:37 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
2158cdf9c4 Merged 2008-06-24 13:41:25 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
c4fa84f683 Merged 2008-06-24 13:41:12 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
03d94018af Added todo about exception handling 2008-06-24 13:41:01 -07:00
chris@h-194.office.mozilla.org
95d87d63e0 merging 2008-06-24 12:44:26 -07:00
chris@h-194.office.mozilla.org
32d06ac143 added embedded verification method to login (this wants to be it's own object method, but should work well enough for now.)
some formatted cleanup for wizard.js
2008-06-24 12:42:52 -07:00
Dan Mills
e2fc25dbfa Store each delta as a separate file on the server 2008-06-24 12:33:27 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
286e670fb2 Finished the bridge between UI code and bookmark engine so that stopSharing gets called when you pick the menu itme. 2008-06-24 12:22:32 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
ed99f7cb53 Make the stop-sharing-data command work 2008-06-23 18:23:08 -07:00
Justin Dolske
6ed3755104 Bug 433949 - Use WeaveCrypto component (NSS) instead of OpenSSL 2008-06-23 16:23:57 -07:00
Myk Melez
bb55bba909 Automated merge with ssh://hg.mozilla.org/labs/weave/ 2008-06-23 16:22:17 -07:00
Myk Melez
9668227aad wrap notify around lock instead of the other way around so that notify includes locking failure/success in its notifications 2008-06-23 16:22:05 -07:00
Myk Melez
6cdf7d9c0d bug 435341: sync automatically when Firefox quits 2008-06-23 16:10:31 -07:00
Atul Varma
c573243c97 Removed a line of code that was raising a strict warning, and which also just defined an unused local variable that called no functions and therefore had no side effects (unless there were property getters that had side-effects involved, which hopefully wasn't the case). 2008-06-23 14:32:55 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
4489fb2ce3 The XMPP server is now configured to use LDAP for authentication (on sm-labs01, and soon to be on services.mozilla too) so the xmpp username/password will now be the same as the weave username/password. So I now use those to login, and I got rid of the two extra preferences which we used to have for xmpp username/password. 2008-06-20 17:19:10 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
7d953f2669 fixed some minor formatting 2008-06-20 16:46:38 -07:00
Myk Melez
e760fc6a12 make xmpp requests be background requests so they don't get horked by load group problems or throw up auth dialogs 2008-06-20 14:26:40 -07:00
Atul Varma
4c78f8d170 Improved test_passwords so that it syncs, re-syncs, adds a new user, and re-syncs again.
Fixed a strict warning in engines.js.
2008-06-20 14:22:06 -07:00
Atul Varma
4e39258260 Made the tracking of async generators/coroutines more robust for debugging purposes.
Refactored code	in syncCores.js	to use Utils.makeTimerForCall().

Improved test_passwords to perform an additional sync after the initial one.
2008-06-20 13:58:56 -07:00
Atul Varma
ac90aaff04 Refactoring: consolidated duplicate code creating GUIDs via XPCOM gunk into a new function, Utils.makeGUID().
Note that there are some strange things re: whitespace in engines/bookmarks.js in this changeset; I literally only changed one line, though, and I'm not sure where they came from.  Maybe it was js2-mode?
2008-06-20 12:34:29 -07:00
Atul Varma
11abf27a3e Minor code tidying. 2008-06-20 12:27:17 -07:00
Justin Dolske
58435fa195 Small bug fix from my last small bugfix. :( 2008-06-19 20:18:59 -07:00
Atul Varma
aa73eb4763 Fixed a bug in the outstanding-callback-warning system and made Generator.throw() and Generator.cont() private methods because no client code was using them and it could introduce bugs in the system if they do; we can revisit making them public again later if we want. 2008-06-19 19:03:10 -07:00
Atul Varma
237b9c8f1d Removed warning message from ID.get() because it's actually normal to pass in an ID that doesn't exist to it, to test for its existence. Though perhaps there should be an exists() method for such a use case instead. 2008-06-19 16:37:53 -07:00
Atul Varma
93520a6e78 Added more fake prefs to the password test to eliminate strict warnings, added logging code to identity.js to aid in debugging. 2008-06-19 16:03:42 -07:00
Justin Dolske
50174a9bff Fix reference to undefined function and bad async arg. 2008-06-19 15:36:24 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
4f11d0d14d Fixed some more missing commas that were preventing engines/bookmarks.js from loading 2008-06-19 15:25:25 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
28bf4dc4f6 Added missing comma after function definition 2008-06-19 15:23:01 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
d58bdfe874 Backed out changeset 7720a1dd564a because the new crypto stuff that it uses hasn't been enabled yet. 2008-06-19 11:59:52 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
bff803b730 Applied dolske's patch from bug 433949 to make the bookmarkEngine work with the new improved Crypto interface. 2008-06-19 11:41:57 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
467eaba47c merged 2008-06-19 10:51:54 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
5725f10629 Reimplemented most of _updateIncomingShare to work with the new implementation of _updateOutgoingShare. No more need for the ugly hack to temporarily set the root directory of DAV, hooray 2008-06-18 23:27:48 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
423c88e98c Implemented _stopOutgoingShare (though it's still not being called from anywhere). 2008-06-18 23:00:09 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
624280ac82 Added documentation to createIncomingShare, rewrote it a little to be consistent with the other new stuff, and made it use annotations to keep track of the server path to the shared data. 2008-06-18 22:37:06 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
e4d31fe71d Gave the bookmarksEngine a permanent (lazy-initialized) reference to the annotation service, rather than recreating the reference every single time we use the service. Which is a lot of times now. 2008-06-18 20:53:11 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
9cc02dd84a Implemented _updateAllOutgoingShares in bookmarkEngine. 2008-06-18 20:45:01 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
f903901b8e Removed an unneeded yield statement from startXmppClient (this was raising warnings about yeilding without a callback.) 2008-06-18 18:48:17 -07:00
Atul Varma
837747b2b8 Replaced boilerplate XPCOM code with calls to util.js functions. 2008-06-18 18:04:01 -07:00
Atul Varma
4165ed8219 Automated merge with http://hg.mozilla.org/labs/weave 2008-06-18 17:28:38 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
da54b30943 Turned all remaining dump()s in transportLayer.js into Log4Moz debug calls. 2008-06-18 17:23:04 -07:00
Atul Varma
e9670abd3f Added a new property to async.js, Async.outstandingGenerators, which returns the number of generators that haven't yet been finalized. This can be used for diagnostic purposes to determine whether generators haven't yet been called back. 2008-06-18 16:11:15 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
110f387e1c Imported Log4Moz to xmpp/transportLayer.js and xmpp/authenticationLayer.js, so they're no longer raising errors about Log4Moz being undefined (oops, sorry, should have tested before pushing.) 2008-06-18 14:59:06 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
5346076d1f Merged 2008-06-18 14:53:30 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
51c929369d XMPPClient sends its debugging output to log4moz (mostly debug level) now instead of dump, so it's less annoyingly verbose. 2008-06-18 14:50:02 -07:00
Atul Varma
30046913d8 Refactored some file operations into a new function in Utils and out of engines.js. 2008-06-18 14:12:24 -07:00
Justin Dolske
44f48bc439 You have: no tea. (Remove old TEA crypto support) 2008-06-18 13:25:58 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
8c09f36ad5 The xmpp messages that are sent when a share is offered now include the server-side path to the share directory. 2008-06-18 13:16:32 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
2a1462352b Merged 2008-06-18 12:48:26 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
0bef123361 made all calls to Resource.get() and Resource.put() properly asynchronous. 2008-06-18 12:48:20 -07:00
Atul Varma
1ab8baed0c Fixed typos. 2008-06-18 12:45:02 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
03cf0d6f73 Removed the check of whether the directory exists before creating it, in _createOutgoingShare(): realized it's not neccessary since DAV.MKCOL already does it. 2008-06-18 12:41:34 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
c7ac787fb1 Merged 2008-06-18 12:32:52 -07:00
Atul Varma
62236e45cd Replaced a bunch of boilerplate XPCOM with a call to Utils.makeTimerForCall(). 2008-06-18 12:32:20 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
68669b6a0f Merged changes 2008-06-18 12:29:39 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
6503df042f Added documentation to BookmarkEngine._updateOutgoingShare. 2008-06-18 12:29:25 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
eb2aa3c9bb Complete rewrite of _createOutgoingShare and _updateOutgoingShare in BookmarkEngine, using remote.Resource objects and Crypto. 2008-06-18 12:26:51 -07:00
Atul Varma
ce9f6b0af8 Removed an unused constructor parameter from PasswordEngine. 2008-06-18 12:04:49 -07:00
Atul Varma
22a628bfea Moved XPCOM-specific stuff from engines/passwords.js to util.js so they could be easily stubbed-out by unit tests. 2008-06-18 11:54:24 -07:00
Atul Varma
90d243db16 Refactored test_service and module code so that the weave service constructor is called, and auth is done more accurately. 2008-06-17 19:54:09 -07:00
Atul Varma
6b20868829 Fixed a minor typo, though there's a better way to do the unary getter which Myk told me about; will probably substitute that soon. 2008-06-17 11:11:56 -07:00
Atul Varma
f9463209a2 Added a fixme/todo in the code. 2008-06-17 10:23:35 -07:00