Commit Graph

189 Commits

Author SHA1 Message Date
Siddharth Agarwal
e6277ff20e Back out bug 588712 and bug 595337 due to leaks and test failures. a=orange 2010-09-14 23:04:50 +05:30
Ehsan Akhgari
f92191a290 Bug 595337 - Crash [@ nsTextEditorState::InitializeKeyboardEventListeners] on print preview close with iframe, position:fixed and input r,a=roc 2010-09-13 16:36:43 -04:00
Ehsan Akhgari
25c62bf4b2 Bug 240933 - Part 9: Simplify text control frame's DOM point to offset conversion code; r=roc a=dbaron
--HG--
extra : rebase_source : 1ed8187ad31ca40bd0b4d5a5a3c7494aacfee495
2010-07-20 08:47:28 -04:00
Ehsan Akhgari
7b654288bf Back out bug 240933 and bug 590554 because of reftest failure on Win7 and also bug 593211 2010-09-02 19:54:23 -04:00
Ehsan Akhgari
522299167b Bug 240933 - Part 9: Simplify text control frame's DOM point to offset conversion code; r=roc a=dbaron
--HG--
extra : rebase_source : 134895e08a57c7aeb39f25266d8925cde4595159
2010-07-20 08:47:28 -04:00
Ehsan Akhgari
669cfe263b Bug 590302 - Crash [@ nsTextControlFrame::CalcIntrinsicSize] on print preview with textarea, position:fixed; r=roc a=blocking2.0:final+ 2010-08-25 01:44:18 -04:00
Mounir Lamouri
034db79f04 Bug 568441 - Explicitely show the caret in nsTextControlFrame when the content is no longer disabled and focused. r=roc a2.0=blocking+ 2010-08-15 11:19:34 -04:00
David Zbarsky
de6582a359 Remove unneeded nsIDOMNSHTMLInputElement interface by merging it into nsIDOMHTMLInputElement. (Bug 582303) r=jst 2010-08-04 22:40:18 -04:00
Ehsan Akhgari
659cc9b4af Bug 578604 - Crash [@ nsTextControlFrame::SetInitialChildList(nsIAtom*, nsFrameList&) ] when print preview; r=roc a=blocking2.0+ 2010-08-04 22:13:57 -04:00
Ehsan Akhgari
ac64050109 Bug 569397 - Eagerly initialize the input controls with spellcheck="true"; r=roc ui-r=faaborg approval2.0=benjamin 2010-06-02 22:39:29 -04:00
Mounir Lamouri
dbf929d752 Bug 549475: Implement HTML5-specified value sanitization algorithm for HTMLInputElement. r=sicking,ehsan,bsmedberg sr=jst
--HG--
rename : layout/reftests/editor/newline-1.html => layout/reftests/editor/newline-4.html
2010-07-21 02:11:19 +02:00
Timothy Nikkel
976046bf62 Bug 563878. Part 5. Rename nsIFrame::GetWindow(Offset) to GetNearestWidget. r=mats 2010-07-02 14:11:04 -05:00
Ehsan Akhgari
a90f192632 Bug 574898 - "ASSERTION: called nsGenericElement::SetText" with spellcheck; r=roc 2010-06-28 14:04:37 -04:00
Alexander Surkov
1b2bbba526 Bug 573706 - make frame based accessible creation more pellucid, r=davidb, sr=roc 2010-06-28 21:02:03 +09:00
Ehsan Akhgari
8c018044af Bug 570624 - "ASSERTION: called nsGenericElement::SetText"; r=roc
--HG--
extra : rebase_source : 24d41a8eccef1c6d8b3adc6a04ca1a20912263ef
2010-06-09 14:14:42 -04:00
Ehsan Akhgari
d051ffeaed Bug 534785 - Move the ownership of editor and selection controller from the text frame to the content node; r=roc,jst sr=roc
(transplanted from 2437636244f39bbdc7d20b062e2c978b9d85c239)

--HG--
rename : layout/reftests/forms/placeholder/placeholder-14.html => layout/reftests/forms/placeholder/placeholder-18.html
extra : transplant_source : %247cbD%F3%9B%BD%C7%D2%0B%06.%2C%97%8B%9D%85%C29
2010-04-21 16:17:41 -04:00
Ehsan Akhgari
f58add9d96 Bug 336104 - "ASSERTION: no frame, see bug #188946"; r=roc,dbaron 2010-05-21 16:36:42 -04:00
Ehsan Akhgari
a87b134220 Bug 560647 - add startup timeline instrumentation; r=vlad 2010-05-19 19:22:19 -04:00
Mounir Lamouri
cbf74508a5 Bug 557620 - Implement <input type="tel">. r=smaug,dolske,dao sr=sicking 2010-05-12 09:17:07 +02:00
Ehsan Akhgari
d45933ae63 Bug 564115 - activating the browser window scrolls the document (to show the focused text control); r=roc 2010-05-06 19:19:35 -04:00
Ehsan Akhgari
40fcaed7a3 Bug 562447 - when navigating in gmail sometimes get a screen full of white; r=roc 2010-05-06 18:12:21 -04:00
Boris Zbarsky
e98cd67374 Bug 564574. Pass the first appended node to ContentAppended. r=jst, sr=sicking 2010-05-10 21:12:34 -04:00
Jonas Sicking
6f9aebb70a Bug 429175: Make sure to only set aNotify to true when we should. r=peterv 2010-05-03 06:23:36 -07:00
Ehsan Akhgari
87f4d73ed2 Bug 559710 - Don't add a br node under text controls when the editor is not initialized for them yet; r=roc,davidb a=1hr 2010-04-15 21:25:40 -04:00
Daniel Holbert
758abd8221 Bug 560271: Reorder nsTextControlFrame constructor init list to fix build warning. r=ehsan 2010-04-19 12:00:45 -07:00
Ehsan Akhgari
3f2bc0f661 Bug 558954 - Don't show/hide placeholder if we're about to initialize the editor; r=roc 2010-04-12 20:32:29 -04:00
Ehsan Akhgari
12fba145fe Bug 557689 - Mochitest-3 (debug) crash after running test_bug366682.html or test_selection_move_commands.xul as a result of bug 542919 [@ nsCOMPtr<nsIMutationObserver>::assign_with_AddRef] (underlying issue will be fixed in bug 534785); r=jrmuizel 2010-04-12 02:13:17 -04:00
Ehsan Akhgari
6fe4d9dd45 Bug 221820 - Part 7: Wrap the calls to nsTextControlFrame::EnsureEditorInitialized in a weak frame check; r=roc 2010-04-06 16:44:46 -04:00
Ehsan Akhgari
25310966a3 Bug 221820 - Part 5: Make lazy editor initialization compatible with placeholder values; r=bzbarsky 2010-04-06 16:43:39 -04:00
Ehsan Akhgari
af32591ddc Bug 221820 - Part 4: Fix the newline handling for text fields without an editor; r=bzbarsky 2010-02-22 16:15:56 -08:00
Ehsan Akhgari
a2d848318a Bug 221820 - Part 3: Debug-only assertion for reentrancy detection; r=bzbarsky 2010-02-09 20:29:11 -05:00
Ehsan Akhgari
5423b1af2f Bug 221820 - Part 2: Make the editor initialization lazy (initialize only when needed); r=bzbarsky 2010-02-02 10:49:55 -05:00
Ehsan Akhgari
05b0ede6fb Bug 221820 - Part 1: Call EnsureEditorInitialized from all places where editor needs to exist; r=bzbarsky 2010-02-01 23:00:12 -05:00
Ehsan Akhgari
2be5f62bd9 Bug 542919 - Maintain the exact same behavior in editor initialization (don't try to set the editor value if the default value is empty) in an attempt to fix the crash of bug 557689 2010-04-11 16:00:36 -04:00
Ehsan Akhgari
d6856b82d8 Bug 542919 - Refactor the plain text editor initialization to facilitate lazy initialization; r=bzbarsky sr=roc 2010-02-01 23:00:06 -05:00
Ehsan Akhgari
a7ebcd12b9 Back out the editor lazy inititialization patches (bug 221820) to try to solve the orange in bug 557689 2010-04-06 21:08:58 -04:00
Ehsan Akhgari
872be8bd0f Bug 221820 - Part 7: Wrap the calls to nsTextControlFrame::EnsureEditorInitialized in a weak frame check; r=roc
--HG--
extra : rebase_source : e8ea41dfa8e4b591e21176fb654f968671cc3ba1
2010-04-06 16:44:46 -04:00
Ehsan Akhgari
ee08070ca4 Bug 221820 - Part 5: Make lazy editor initialization compatible with placeholder values; r=bzbarsky
--HG--
extra : rebase_source : f7e1954482d34f5a229307ff7a6bc4fa527171ff
2010-04-06 16:43:39 -04:00
Ehsan Akhgari
862eb9644f Bug 221820 - Part 4: Fix the newline handling for text fields without an editor; r=bzbarsky
--HG--
extra : rebase_source : 92d9e491351a6183f0232604cd989c14d10d5fad
2010-02-22 16:15:56 -08:00
Ehsan Akhgari
6fb3c80de5 Bug 221820 - Part 3: Debug-only assertion for reentrancy detection; r=bzbarsky
--HG--
extra : rebase_source : 0b3e81c649178ebff2b08856f652a37be59d7547
2010-02-09 20:29:11 -05:00
Ehsan Akhgari
36c7ad5a5a Bug 221820 - Part 2: Make the editor initialization lazy (initialize only when needed); r=bzbarsky
--HG--
extra : rebase_source : bf84341934b14c78fadc162607721e9325673fc4
2010-02-02 10:49:55 -05:00
Ehsan Akhgari
0170b6dede Bug 221820 - Part 1: Call EnsureEditorInitialized from all places where editor needs to exist; r=bzbarsky
--HG--
extra : rebase_source : 91df07eb7a6a52c35d8f4d52212663045450b95a
2010-02-01 23:00:12 -05:00
Ehsan Akhgari
4605b1985f Bug 542919 - Refactor the plain text editor initialization to facilitate lazy initialization; r=bzbarsky sr=roc
--HG--
extra : rebase_source : 9c043d3cb30420f061d543e11e3000a1f8e18e27
2010-02-01 23:00:06 -05:00
Craig Topper
7b89b159bb Bug 253889: DeCOMtaminate nsIPresShell - GetCaret(). r=roc
--HG--
extra : rebase_source : 2a05050d8cbb10dd3bb763d5d5a158cc5f3dd814
2010-03-31 08:39:31 -04:00
Kyle Huey
afc6c6ca2d Backed out changeset 4b8936ac4a31 2010-03-30 19:56:44 -04:00
Craig Topper
6c9540a26d Bug 253889: More deCOMtamination of nsIPresShell. r=roc 2010-03-28 19:21:11 -04:00
Neil Deakin
0c4cd862d6 Bug 543563, fix build error due to conflict with bug 544472 2010-03-18 16:45:29 -04:00
Neil Deakin
87103f2372 Bug 543563, textarea in xul textbox doesn't take into account any assigned widths/heights, r=dbaron 2010-03-18 15:58:12 -04:00
Ehsan Akhgari
ce65cdd15d Bug 353539 - textarea.focus() puts caret at end without scrolling it into view; r=roc
--HG--
extra : rebase_source : 775c2c16cfbb0ef9a9024dd53c42c803ee08e8ae
2010-03-18 12:14:40 -04:00
Ehsan Akhgari
c4712d086e Bug 231389 - Textarea scrolls to top after changing its .value, regardless of cursor position; r=roc
--HG--
extra : rebase_source : 01f1129bc5289c3b56d15a7965e647002a0b1198
2010-03-18 12:14:08 -04:00
Mounir Lamouri
7f79202969 Bug 549208 - Dragging a text in an input/textarea element doesn't make the placeholder disappear; r=bzbarsky
--HG--
extra : rebase_source : 13dc342d24bef26815bda5ef9958cfcb11a68a10
2010-03-01 10:35:40 -08:00
Mounir Lamouri
54f1561afc Bug 457800 - Implement placeholder attribute for text input fields; r=ehsan,bzbarsky,bolter sr=roc ui-r=faaborg
--HG--
extra : rebase_source : 2e2f3a73553d720b32812603b0ce96c89b9a6261
2010-02-26 10:47:38 -08:00
Alexander Surkov
be2b5e3966 Bug 534527 - Accessibility needs new DOM API part 2, r=smaug, sr=bz 2010-02-20 16:52:50 -08:00
Ehsan Akhgari
5f6014baed Backed out changeset e6cf06cfcef9 2010-02-18 19:03:28 -05:00
Ehsan Akhgari
c83636a241 Bug 542919 - Refactor the plain text editor initialization to facilitate lazy initialization; r=bzbarsky sr=roc
--HG--
extra : rebase_source : 5c6baa16c4f3c91f8564cfdf394d70c8ea507861
2010-02-01 23:00:06 -05:00
Alexander Surkov
73e251f02b Bug 534527 - Accessibility needs new DOM API, r=olli.pettay, sr=roc 2010-02-12 01:34:01 +08:00
Olli Pettay
3a431b9f1b Bug 518122, improve textarea.value+= performance, r=bz 2010-02-07 21:44:32 +02:00
Robert O'Callahan
a923083da5 Bug 526394. Part 18: Remove nsIScrollableViewProvider and its implementations, now that we've removed all its users. r=mats 2009-09-09 17:40:01 +12:00
Robert O'Callahan
7eb8b6c4d7 Bug 526394. Part 17: Convert some selection-related code in nsTextControlFrame and nsSelection. r=mats 2009-09-03 17:23:47 +12:00
Robert O'Callahan
90d248d976 Bug 526394. Part 2: Remove pointless code in nsTextControlFrame, nsGfxScrollFrame handles this already. r=mats 2009-07-29 22:07:04 +12:00
fantasai
1ffb0c06ef Bug 508473 part III: Pass destruction root to frame destruction methods r=bz sr=roc 2009-12-24 00:21:15 -05:00
fantasai
714c1668f7 Bug 508473 Part I: Remove nsIFrame::RemovedAsPrimary r=bz sr=roc 2009-12-24 00:20:20 -05:00
Brad Lassey
926e622d2a bug 530367 - passwords from password manager flash in clear text r=neil 2009-11-25 12:41:23 -05:00
Mats Palmgren
e8faa921de Bug 522787. Always register an editor observer. r=smaug 2009-11-19 12:38:11 +13:00
Boris Zbarsky
3289c85a87 Bug 259636. Don't do sync reflow when setting .value on text inputs. r=roc, sr=dbaron 2009-11-11 18:28:16 -05:00
Robert O'Callahan
e4bc55769e Bug 514660. Use classes instead of an explicit 'style' attribute to style the anonymous DIV of a text control, so that the styles are treated as user-agent styles and not removed when author styling is disabled. r=bzbarsky
--HG--
extra : rebase_source : 949e902529b2e0f48539d40141614038dfea0ea2
2009-09-23 23:02:27 +12:00
David Zbarsky
8d8553ee41 Bug 488249. Replace IsNodeOfType(eHTML) checks with namespace checks. r+sr=jst 2009-08-24 16:02:07 -04:00
Mats Palmgren
948203eb7d Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX. b=512106 r=roc 2009-09-16 17:01:36 +02:00
Zack Weinberg
17eb5a6efc Bug 497495 part 3: Add methods to every nsFrame subclass that expose the as-allocated identity of every frame object. Also some cleanups to the QueryFrame implementation. r=dbaron sr=roc 2009-09-12 17:49:24 +01:00
Boris Zbarsky
36622c6995 Backed out changeset 4aa19414e651 (bug 488249) to fix test orange.
--HG--
extra : rebase_source : ae1c0155ec32b0887eff27ded77c6ba2b37dda64
2009-08-24 20:51:57 -04:00
David Zbarsky
932e28482f Bug 488249. Replace IsNodeOfType(eHTML) checks with namespace checks. r+sr=jst 2009-08-24 16:02:07 -04:00
Hashem Masoud
c8f711113e Bug 489502 - Replace NS_ASSERTION(0, ...) by NS_ERROR(...) in mozilla-central; r=benjamin 2009-08-14 16:09:00 +02:00
Boris Zbarsky
5fefb45a48 Bug 504221 part 12. Switch SetInitialChildList to nsFrameList. r=fantasai, r+sr=roc 2009-07-28 08:53:20 -04:00
Robert O'Callahan
c15bebdcb1 Bug 495385. Text inputs should set the white-space style of the anonymous inner div when that div is created, not later when it will trigger a restyle. r+sr=bzbarsky
--HG--
extra : rebase_source : bef3008f365592d754039e74bac0b428a8c84794
2009-06-13 21:16:27 +12:00
Neil Deakin
79321ef1f8 Bug 178324, refactor focus by moving all focus handling into one place and simplifying it, add many tests, fixes many other bugs too numerous to mention in this small checkin comment, r=josh,smichaud,ere,dbaron,marco,neil,gavin,smaug,sr=smaug (CLOSED TREE) 2009-06-10 14:00:39 -04:00
Boris Zbarsky
9d1a00e650 Bug 492387. Flush out content notifications before initing our editor. r+sr=jst 2009-05-19 10:49:57 -04:00
Karl Tomlinson
1b9df1cee4 b=481751 block-height line-height for text input and strut baseline for textarea r=bz,sr=dbaron
--HG--
extra : rebase_source : 1241360066ea9387d15c71936da9468399240640
2009-05-19 10:13:12 +12:00
Boris Zbarsky
f992c9df1d Bug 478219. Put a script blocker around delayed editor init. r+sr=sicking 2009-03-16 07:50:04 -04:00
Dão Gottwald
3b81a42595 Backed out changeset 12e163f4f272 2009-03-16 15:00:57 +01:00
Boris Zbarsky
914389430a Bug 478219. Put a script blocker around delayed editor init. r+sr=sicking 2009-03-16 07:50:04 -04:00
Boris Zbarsky
a2d0b2c43b Bug 477700. Push a null JSContext around editor init, so it'll work no matter what JS is on the stack. r+sr=smaug 2009-02-16 09:11:41 -05:00
Boris Zbarsky
3574872d3a Bug 335615. Don't do editor init inside frame construction. r=mats, sr=roc 2009-01-29 14:46:17 -05:00
Benjamin Smedberg
24e7cb1f78 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
50621e4f9f Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
d0b948876f Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Robert O'Callahan
a3a3951684 Bug 459613. When we tear down a textcontrol frame, tell its editor that we're blowing away the frame tree so it doesn't try to clear the spellcheck selection, which not only wastes time but does GetPrimaryFrame for during frame destruction which is a no-no. r+sr=mats 2008-12-12 21:34:43 +13:00
Markus Stange
7a9f82ce7e Bug 462793 - Changing listbox selection with keyboard no longer scrolls to make the newly selected item visible, r+sr=roc 2008-11-04 15:38:16 +01:00
Benjamin Smedberg
4862de1d3d Bug 461186 - nsTextControlFrame should not implement nsIPhonetic: there's only one caller, and that caller can use nsITextControlFrame directly. This is one less frame that implements an nsISupports-derived interface. r+sr=roc 2008-10-27 20:27:55 -04:00
Theppitak Karoonboonyanan
018ec4b25f Bug 157546. The 'delete' key should delete an entire cluster. r=peterv,r+sr=roc 2008-10-16 20:44:32 +13:00
Mats Palmgren
426e3534c3 Ignore the keypress event if DOMEventToNativeKeyEvent() fails. b=456273 r=Olli.Pettay sr=jonas 2008-10-15 12:50:42 +02:00
Taras Glek
390adbe464 bug 455536: s/NS_ERROR_FAILURE/NS_ERROR_OOM/ outparamdelled nsNodeInfoManager::GetNodeInfo r+sr=jsr 2008-09-25 15:46:52 -07:00
Arpad Borsos
eef0edf9d5 Bug 454766 - Add suggested parentheses to layout/; r+sr=roc; (with nits by sgautherie) 2008-09-15 17:40:25 +02:00
Taras Glek
c26ce8e1ab bug 450777:deCOMtaminate nsNodeInfoManager::GetNodeInfo r+sr=jst 2008-09-12 15:32:18 -07:00
Mats Palmgren
9dc386954b Bug 446663. Make sure that if the user is typing in a text input its text input listener will get the events (so that undo/redo work and oninput is fired). 2008-07-31 17:34:11 -07:00
Zack Weinberg
3197060cbd Delete nsLayoutUtils::GetAbsoluteCoord(); fold logic into callers and simplify. (Bug 437335) r+sr=dbaron 2008-07-17 16:37:12 -07:00
John Daniels
ef0fee1d70 Bug 419532 – deCOMtaminate nsICaret. r+sr=roc 2008-07-16 12:52:01 +02:00
neil@parkwaycc.co.uk
45ebee768d Bug 444466 – Crash [@ nsTextControlFrame::PreDestroy()], r+sr=bz 2008-07-12 11:26:40 +02:00
jst@mozilla.org
54ae1d2978 Landing fix for bug 419716. Make us consistently deal how we're pass param tags to object tags when parsing XHTML. Patch by mrbkap@gmail.com and bent.mozilla@gmail.com, r+sr=jonas@sicking.cc, a=beltzner 2008-04-17 15:30:51 -07:00
dbaron@dbaron.org
72f25cf7a0 Backout bug 157546 (making the delete key delete by clusters) to fix blockers bug 419217 and bug 419406. Instead of removing the added test, mark now-failing tests as todo. a=damons 2008-04-14 18:04:18 -07:00
roc+@cs.cmu.edu
1bfe348601 Bug 425253. Propagate reflow-depth tracking through XUL box layout. r+sr=dbaron,a=damon 2008-04-09 21:39:41 -07:00