Peter Van der Beken
4189af9d67
Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles). r=bent, sr=bz.
2009-01-14 13:24:10 +01:00
Daniel Holbert
5b26d7d11e
Bug 465928 followup: correct typo in enum name - s/PERSERVE/PRESERVE/. No functional changes. r=roc
2009-01-13 12:28:28 -08:00
Benjamin Smedberg
469b7ca86d
Minor static-checking fixup: give a useful location for the "frame inherits from nsIFrame and nsISupports" warning, NPODB
2009-01-13 11:32:25 -05:00
Jesse Ruderman
118aad7d87
Add crashtest
2009-01-12 16:24:44 -08:00
Benjamin Smedberg
08c8aadf40
Add a static analysis pass to verify that for any do_QueryFrame<Interface> there is an Interface::kFrameIID declared. NPODB, static-checking only.
...
--HG--
extra : rebase_source : 0bcfa5b446d0c19610d9d61dd7e281d3923c8736
2009-01-12 14:21:11 -05:00
Benjamin Smedberg
24e7cb1f78
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Phil Ringnalda
b6fe1a7700
Builds are neccesary, even if you can spell necessary, and even in a CLOSED TREE
2009-01-11 00:46:35 -08:00
Benjamin Smedberg
50621e4f9f
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
Benjamin Smedberg
d0b948876f
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Dave Townsend
0587e6973b
Backed out changeset fe759e3fd895 from bug 469613 due to mochitest failures
2009-01-09 13:46:45 +00:00
Markus Stange
061513f78b
Bug 469613 - Page scrolling by clicking the scrollbar track can get stuck if the page is very long, r+sr=roc
2009-01-09 10:05:24 +01:00
Michael Ventnor
318cfd2e10
Bug 472410. Don't adjust selection colors if the background is a -moz-appearance that we can't know anything about. r+sr=roc
2009-01-09 13:29:38 +13:00
Robert O'Callahan
cca5e6840b
Bug 430332. Defer nsTransformingTextRun::RebuildTextRun until the linebreaker has completely set up the break and capitalization data on the transformed text run. r=smontagu
2009-01-09 13:23:28 +13:00
Robert O'Callahan
ec55ad45cf
Bug 440149. Don't break after empty text at the start of the line, even if we're past the available width. r=smontagu
2009-01-09 13:13:45 +13:00
Mats Palmgren
6d4b0667d0
DEBUG: Make nsBlockFrame::List really print the overflow lines. b=472193 r+sr=roc
2009-01-08 22:17:53 +01:00
Uri Bernstein
def95c60da
Set mMaintainRange to null when there is no selection. b=470212 r=mats sr=roc
2009-01-08 22:17:49 +01:00
Jesse Ruderman
22cd32241d
Add five crashtests
2009-01-06 16:47:56 -08:00
Boris Zbarsky
709cd54c51
Bug 284320. Remove the contentParentFrame hack in subdocument frames, along with the no-longer-used arg it used to be used for. r+sr=roc
2009-01-06 17:29:50 -05:00
L. David Baron
ae71ba3f9c
Change code for handling out-of-nscoord-range values from NS_NOTREACHED to NS_WARNING. (Bug 472218) r+sr=roc
2009-01-06 15:21:00 -08:00
L. David Baron
56e0a57776
Fix tests to match what they should have been testing, and fix nsFloatManager behavior to match what the old code actually did as far as considering floats at the side that did not protrude into the containing block. (Bug 472252) r+sr=roc
2009-01-06 15:21:00 -08:00
L. David Baron
add2ce5a81
Add nsTArray<E>::TruncateLength, which is like SetLength, except only allows shortening of the array. (Bug 191448) r=bsmedberg
2009-01-06 15:21:00 -08:00
Benjamin Smedberg
720c4f5577
Bug 472348 - Some unused variables found by combing the warning database, rs=bz
2009-01-06 14:25:58 -05:00
Robert O'Callahan
0e5439fe27
Bug 429968. Handle situations where first-letter text detects first-letter style should not be applied, by creating a zero-length 'first letter'. r+sr=dbaron
...
--HG--
extra : rebase_source : 650611aec3adb1498dc5d8d6d38212ddf09e32fc
2009-01-05 13:36:56 +13:00
L. David Baron
8f4b3155dc
Give nsFloatManager::FloatInfo a copy constructor to avoid confusing refcount logging. (Bug 191448)
2009-01-04 20:25:58 -05:00
L. David Baron
eee42cfdd7
Replace space manager with a more limited float manager. (Bug 191448) r+sr=roc
...
--HG--
rename : layout/generic/nsSpaceManager.cpp => layout/generic/nsFloatManager.cpp
rename : layout/generic/nsSpaceManager.h => layout/generic/nsFloatManager.h
2009-01-04 19:39:54 -05:00
L. David Baron
57a8e776d8
Rename flags and methods from space manager to float manager. (Bug 191448) r+sr=roc
2009-01-04 19:39:54 -05:00
L. David Baron
82d6666100
Remove the VerifyReflow code that checked the space manager state. (Bug 191448) r+sr=roc
2009-01-04 14:52:38 -05:00
L. David Baron
b3d748ba11
Fix some missed renames from bug 471356. r+sr=bzbarsky
2009-01-04 14:52:38 -05:00
Arpad Borsos
318ec6121d
Bug 471877 - Cleanup GTK includes; r+sr=roc
2009-01-03 08:37:52 +01:00
Jesse Ruderman
cf4b91bb09
Add 19 crashtests
2009-01-01 14:18:58 -08:00
Jonathan Kew
29eda950fd
Bug 470418 - Leak nsStyleContext with RTL, text-transform; r,sr=roc
2009-01-01 16:34:13 +03:30
L. David Baron
23d4f4d4b2
Stop using nsAreaFrame for anything other than xul:label, which is the only thing for which it does anything different from nsBlockFrame, and rename it accordingly. (Bug 471356) r+sr=roc
...
--HG--
rename : layout/generic/nsAreaFrame.cpp => layout/xul/base/src/nsXULLabelFrame.cpp
rename : layout/generic/nsAreaFrame.h => layout/xul/base/src/nsXULLabelFrame.h
2008-12-29 10:07:38 -05:00
L. David Baron
c48e8cee0e
Fix regression in CalcQuirkContainingBlockHeight from change from area frame to block frame in bug 243519. (Bug 471356) r+sr=roc
2008-12-29 10:07:38 -05:00
L. David Baron
d52dad5b98
Give nsPageBreakFrame a frame name for DEBUGging code. (Bug 468645) r+sr=bzbarsky
2008-12-29 10:07:36 -05:00
Robert O'Callahan
374cd3a20b
Bug 449142. Scale video so that it fits in the content-box of the element and has the same aspect ratio as the video source. Also adds some Ogg video reftests. r=doublec,sr=dbaron
2008-12-29 21:20:27 +13:00
Robert O'Callahan
0731a2c4f4
Bug 458296. When a block doesn't carry out the bottom-margin of its children, add that bottom-margin to its overflow area. Also, add the bottom-padding of a scrolled block to its overflow area. r+sr=dbaron
2008-12-29 21:18:40 +13:00
Robert O'Callahan
b817cb2bbf
Bug 469203. Don't try to make toplevel HTML documents transparent, it just doesn't work and the window can disappear in a mysterious way. r+sr=dbaron
2008-12-29 21:17:08 +13:00
L. David Baron
33efe12a98
Fix placement of video controls when top and right padding are different. (Bug 470596) r+sr=roc
2008-12-27 20:58:14 -05:00
L. David Baron
5a497c7cb3
Fix an off-by-border-and-padding error in nsVideoFrame::BuildDisplayList. (Bug 470596) r+sr=roc
2008-12-27 20:58:14 -05:00
L. David Baron
8458c5b6b6
Make 'word-spacing: normal' just compute to '0', since that's what CSS 2.1 says to do, and thus change nsStyleText::mWordSpacing from nsStyleCoord to nscoord. (Bug 470705) r+sr=roc
2008-12-27 20:58:14 -05:00
Jesse Ruderman
f4f6dd881a
Tests for bug 435529 and bug 436823.
2008-12-26 00:15:48 +01:00
L. David Baron
16aba7fd6b
Set up image loaders before reflow for border-image in XUL just like for HTML. (Bug 468473) r+sr=roc
2008-12-23 09:06:56 -05:00
Joe Drew
a29562512b
Bug 393936 - nsIRequest::cancel() must not notify anything sync. Make removal from the loadgroup async, and add another call cancelAndForgetObserver() that removes the listener immediately (since some callsites expect that). Note, however, that this new method shouldn't be used in any new code; it exists only to support code that relied on the broken behaviour prior to this checkin. r=bzbarsky sr=vlad
2008-12-19 17:35:50 -05:00
Ehsan Akhgari
0f987d9366
Bug 470376 - Compiler warnings from landing of bug 441782; r,sr=roc
2008-12-19 14:37:09 +03:30
Ehsan Akhgari
ca2a90bdee
Bug 441782 - bidi.numerals == 4 does not switch numeric shapes in content; r,sr=roc
2008-12-18 23:42:53 +03:30
Robert O'Callahan
9f318c485c
Backed out changeset dcd1ad7a918e
2008-12-18 16:05:16 +13:00
Robert O'Callahan
274f89ff0d
Bug 430332. Defer nsTransformingTextRun::RebuildTextRun until the linebreaker has completely set up the break and capitalization data on the transformed text run. r=smontagu
2008-12-18 14:13:23 +13:00
Robert O'Callahan
25641e6ca4
Bug 467487. Use a better and more explicit check for the case where a text frame's textrun doesn't map enough text for the frame. r=smontagu
...
--HG--
extra : rebase_source : d9f9f7f8d7b84622b3be4f951133074ef7f5846d
2008-12-17 15:14:33 +13:00
Robert O'Callahan
f7a310640f
Bug 467150. Don't clear textruns just because we destroy an empty nsContinuingTextFrame. r=smontagu
...
--HG--
extra : rebase_source : e8d17c0cf1d35f450e62a8b6a35340855395ef72
2008-12-17 15:12:47 +13:00
Robert O'Callahan
ed66190092
Bug 449149. Implement the 'controls' attribute for audio elements. r+sr=bzbarsky,r=dolske,r=enndeakin
...
--HG--
extra : rebase_source : 4d11b963d3082f98269069c68aae33eef365aacb
2008-12-17 13:27:46 +13:00
Markus Stange
c15f2b9d7f
Forgot to add the braces in changeset 58f409bbc149 (bug 391984)
2008-12-15 14:43:31 +01:00
Masayuki Nakano
229283883c
Bug 272847 Text input via IME does not work in windowless Flash movie r=ere+josh, sr=roc
2008-12-15 12:54:54 +09:00
Graeme McCutcheon
4d0acd8eae
Bug 345339. Make nsPresState not use a hashtable in favor of using less memory and only storing the things it really wants to store. Switch box objects to their own hashtable. r+sr=roc
2008-12-12 14:25:22 -05:00
Robert O'Callahan
46299947fc
Backed out changeset 0cb24a4bcd9b
2008-12-13 00:09:56 +13:00
Robert O'Callahan
a6a68372fb
Bug 430332. Defer nsTransformingTextRun::RebuildTextRun until the linebreaker has completely set up the break and capitalization data on the transformed text run. r=smontagu
2008-12-12 21:37:59 +13:00
Markus Stange
975559338c
Bug 391984 - [10.5] Add roundness to context menus, r=josh sr=roc
2008-12-11 15:37:38 +01:00
Robert Sayre
58f4455a2a
Backout JOEDREW! patches for bug 89419 and bug 393936. Looks like they make mochitest leak.
2008-12-11 01:27:58 -08:00
Joe Drew
294499eab5
Bug 393936 - nsIRequest::cancel() must not notify anything sync. Make removal from the loadgroup async, and add another call cancelAndForgetObserver() that removes the listener immediately (since some callsites expect that). Note, however, that this new method shouldn't be used in any new code; it exists only to support code that relied on the broken behaviour prior to this checkin. r=bzbarsky sr=vlad
2008-12-10 16:25:34 -08:00
Neil Rashbrook
be9757b050
Bug 468421 Fix assertion to include other valid cases r+sr=roc (debug-only code)
2008-12-10 12:46:02 +00:00
Robert O'Callahan
088a6b0690
Bug 458898. Make sizeToContent work for HTML documents by ensuring CanvasFrame converts an UNCONSTRAINEDSIZE computed height into its actual desired height. r+sr=dbaron
2008-12-09 13:33:46 +13:00
Robert O'Callahan
bfa41e8f5e
Merged to trunk
2008-12-08 20:52:15 +13:00
Robert O'Callahan
a36f118655
Bug 463242. Ideographic spaces should not get CSS word-spacing, but nonbreaking spaces should. r+sr=dbaron
2008-12-08 14:11:38 +13:00
Mats Palmgren
dd7b00661b
Backing out the tests for bug 421839 to try to fix Tinderbox orange.
2008-12-08 01:58:48 +01:00
Robert O'Callahan
bbdc2a9552
Bug 465913. Don't need to call BreakFromPrevInFlow in nsContainerFrame::DeleteNextInFlowChild. r+sr=dbaron
2008-12-08 13:39:11 +13:00
Mats Palmgren
d6a5513492
Crash test for bug 421839.
2008-12-08 00:11:48 +01:00
Mats Palmgren
1dc0d756d8
Don't crash if views were destroyed while flushing notifications. b=421839 r+sr=roc
2008-12-08 00:11:37 +01:00
Mats Palmgren
d188234a59
Fix the parent pointer for ::first-letter child frame next-in-flows. b=401042 r+sr=roc
2008-12-07 19:21:40 +01:00
L. David Baron
b20fd8f22b
Add a test for bug 468167
2008-12-07 11:22:12 +01:00
Markus Stange
05944a7f56
Partial backout of changeset cfc553938038 (bug 463042) in order to fix bug 468167, "Deleting selected top of document (from below) no longer scrolls what remains into view".
2008-12-07 11:19:47 +01:00
Serge Gautherie
d6255d3171
Backed out changeset: d98cdb0cdd15
2008-12-05 19:26:52 +01:00
Mike Kaplinskiy
b51abf4b07
Bug 440614 - text entry field unable to take focus; r=(bzbarsky + jst + peterv) sr=peterv
2008-12-05 17:27:02 +01:00
L. David Baron
c95d61afc0
Pass the user font set through more reliably and make it a required parameter. (Bug 467084) r+sr=roc a=blocking1.9.1+
2008-12-04 08:09:53 -08:00
Markus Stange
76daa5a7da
Bug 463042 - Smooth scrolling isn't working with the scrollbar or the keyboard arrows, r+sr=roc
2008-12-02 14:18:08 +01:00
Robert O'Callahan
4d8d186dd2
Backing out bug 455826 to try to fix Windows orange.
2008-12-04 15:32:15 +13:00
Robert O'Callahan
7b4bd93240
Backed out changeset aaeb20c61fca
2008-12-04 15:31:42 +13:00
Robert O'Callahan
d2399b84fa
Bug 455826. Don't reconstruct textruns just because we deleted an empty nsContinuingTextFrame. r=smontagu
2008-12-03 09:40:02 +13:00
Robert O'Callahan
70ba87beed
Backing out bug 458898 to try to fix Windows orange
2008-12-04 00:42:49 +13:00
Robert O'Callahan
5364eb1faf
Backed out changeset 357d1c01bde3
2008-12-04 00:42:02 +13:00
Olli Pettay
69276b94ff
Bug 465732 - Don't invalidate plugin after scrolling, r=smichaud, sr=roc
2008-12-03 11:59:33 +02:00
Olli Pettay
70ce07ded0
Bug 467295 - Plugin timer is re-created everytime the page is scrolled, r=josh,sr=roc
2008-12-03 11:30:40 +02:00
Simon Montagu
3ebc1e4e68
Update Unicode data files to Unicode version 5.1. Bug 427350, r=jdaggett
2008-12-03 10:11:01 +02:00
Simon Montagu
3363523acc
Delete all text frame continuations when deleting first letter frame. Bug 466763, r+sr=roc
2008-12-02 22:56:53 -08:00
Robert O'Callahan
7fa4d507b4
Followup comment change for bug 465928.
2008-12-03 14:50:22 +13:00
Robert O'Callahan
f9d2d59b5e
Bug 465928. Avoid SetInvalidateTextRuns being called by nsBlockFrame::DoRemoveFrame when we're just deleting empty continuation frames. r+sr=dbaron
2008-12-03 14:27:19 +13:00
Michael Ventnor
e02630a781
Bug 458031. Take dirty rect into account to limit box-shadow computation. r+sr=roc
2008-12-03 10:16:22 +13:00
Robert O'Callahan
c06c17a0c2
Bug 458898. Fix intrinsic sizing of windows by ensuring CanvasFrame converts an NS_UNCONSTRAINEDSIZE desired height to its actual desired height. r+sr=dbaron
2008-12-03 09:50:16 +13:00
Jesse Ruderman
050af4beec
Add bug 457375 crashtest using the crashtest.diff created by Mats
2008-11-29 19:04:37 -08:00
Jesse Ruderman
5293e9c546
Add bug 452157 crashtests (using the 'crashtests patch' created by dholbert)
2008-11-29 19:01:30 -08:00
Jesse Ruderman
24852c3aec
Add bug 443528 crashtest (based on the crashtest.diff created by Mats) to CLOSED TREE
2008-11-29 18:57:00 -08:00
Jesse Ruderman
d4f3757275
Add bug 345139 crashtest on CLOSED TREE
2008-11-29 18:27:26 -08:00
L. David Baron
16009115b3
Use larger values for no-minimum and no-maximum so that we don't cross them. (Bug 466395) r+sr=roc a191=beltzner
2008-11-27 20:08:32 -08:00
Robert O'Callahan
8ff4467f78
Bug 457398. Don't treat empty lines as the first line for text-indent or first-letter/first-line purposes. r+sr=dbaron
2008-11-27 10:44:47 -08:00
Robert O'Callahan
ab3854de4f
Bug 462968. Sanitize block height. r+sr=dbaron
2008-11-26 11:57:28 +13:00
Robert O'Callahan
e2d6438f48
Bug 459968. Fix some integer overflows in the style system and in min/pref width computation for text. r+sr=dbaron
2008-11-26 11:53:58 +13:00
Robert O'Callahan
0be9ec5c8d
Bug 455826. Look into overflow-lists of inlines to find text when we're building textruns. r=smontagu
2008-11-26 11:51:36 +13:00
Brad Lassey
ea8dd114d1
backing out changesets 026147c91538, fb2326fcfc36, ebf0c7cf17be, 57e6a1e9041e, 1f5d2c249f86 and d7a7824d6990 due to crash on linux talos machines durring tp.
2008-11-26 12:20:26 -05:00
Brad Lassey
9491b0201f
merge
2008-11-26 10:08:45 -05:00
L. David Baron
7372b5e796
Merge roc-1.bundle to land 5 patches for roc.
2008-11-25 20:41:38 -08:00
Boris Zbarsky
bad0b33175
Bug 437142. Be a little more careful with GetPrimaryFrameFor to work around the mess that <area> elements cause. r+sr=roc
2008-11-25 20:49:14 -05:00
L. David Baron
f0a1beced5
Handle some additional codepaths for position: fixed elements inside elements with -moz-transform. (Bug 455171) r+sr=bzbarsky a=blocking1.9.1+
2008-11-25 15:22:39 -08:00
