This changeset allows for history and bookmark observers to be registered via
the category manager. This means the bookmarks service does not have to be
initialized at startup to register observers with it, as well as the history
service.
r=sdwilsh
r=mak
r=dietrich
This changeset allows for history and bookmark observers to be registered via
the category manager. This means the bookmarks service does not have to be
initialized at startup to register observers with it, as well as the history
service.
r=sdwilsh
r=mak
r=dietrich
Not having this callback makes life difficult for anyone trying to synchronize
bookmarks. You cannot get any additional information about a bookmark when
onItemRemoved is called, since it's been removed. Things like a guid no longer
exist, which results in a lot of pain for add-ons that want to synchronize.
r=dietrich
This fixes a crash when we initialize nsNavBookmarks with a database that is out
of date (the schema version is less than the current one). Because the bookmark
service initializes the history service in its Init method, and the history
service tries to get the bookmark service if the database needs an upgrade, we
try to re-enter the bookmark service's constructor. Bad things happen.
Adds a test to ensure that we don't do this again.
r=dietrich
r=MaK77
This adds a new function to nsNavBookmarks that determines if a place id is a
"real" bookmark (not a livemark child). It also makes a number of places use
this new function to unify and simplify a number of code paths.
Additionally, it changes how frecency is calculated for bookmarked items. If a
visit is bookmarked (aIsBookmarked is true in CalculateFrecencyInternal), the
visited bookmark bonus is now added for all visits. The visit bonus was also
cut in half for bookmarks so TRANSITION_BOOKMARK will still end up with the same
value (150).
r=dietrich
r=MaK77
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
It turns out that this is not a safe function to use at all when you start using
the database connection on more than one thread. It also does not work as
expected when triggers are used to insert data into a database.
r=dietrich