Commit Graph

143 Commits

Author SHA1 Message Date
Dietrich Ayala
890e1e64fa Backout bug 498130 due to persistent startup crash on Windows Mobile (bug 519854) 2009-09-30 17:21:39 -07:00
Asaf Romano
0cdda0b913 Bug 498130 - Reduce places-views overhead. r=mak. sr=mconnor. 2009-09-26 11:23:17 +03:00
Marco Bonardo
942029b1e0 Bug 326208 - API should not allow creation of "holes" in bookmark folders, r=dietrich 2009-08-21 11:54:12 +02:00
Marco Bonardo
027b0b2a6f Bug 507058 - nsNavBookmarks::GetBookmarkIdsForURITArray binds to a bogus index, r=sdwilsh 2009-08-03 10:48:08 +02:00
Mark Finkle ext:(%2C%20Shawn%20Wilsher%20%3Cme%40shawnwilsher.com%3E%2C%20Marco%20Bonardo%20%3Cmak77%40bonardo.net%3E)
cf0241bf3f Bug 483980 - Allow history/bookmark observer components to register with a startup category
This changeset allows for history and bookmark observers to be registered via
the category manager.  This means the bookmarks service does not have to be
initialized at startup to register observers with it, as well as the history
service.
r=sdwilsh
r=mak
r=dietrich
2009-03-25 15:31:36 -05:00
Marco Bonardo
aa2951dec7 Bug 482346 - mDBFindURIBookmarks can't use indices to sort, r=sdwilsh r=dietrich 2009-06-24 10:59:14 +02:00
Dietrich Ayala
a110b525d4 Bug 496613 - lazily init the bookmark uri hash (r=marco) 2009-06-12 11:11:47 -07:00
Dietrich Ayala
d4ecc24959 Bug 497563 - Crashes [@ BindStatementURI] (r=sdwilsh)
* * *
2009-06-12 00:34:35 -07:00
Shawn Wilsher
b84cbee827 Backed out changeset d891a7418d95 (bug 483980) 2009-06-11 16:08:07 -07:00
Mark Finkle ext:(%2C%20Shawn%20Wilsher%20%3Cme%40shawnwilsher.com%3E%2C%20Marco%20Bonardo%20%3Cmak77%40bonardo.net%3E)
2cf526db39 Bug 483980 - Allow history/bookmark observer components to register with a startup category
This changeset allows for history and bookmark observers to be registered via
the category manager.  This means the bookmarks service does not have to be
initialized at startup to register observers with it, as well as the history
service.
r=sdwilsh
r=mak
r=dietrich
2009-03-25 15:31:36 -05:00
Marco Bonardo
54f9e18aed Bug 494370 - Better query for mDBGetItemProperties, r=sdwilsh a=beltzner 2009-05-28 00:08:47 +02:00
Marco Bonardo
14124b5b86 Bug 488966 - Add a last_visit_date column with an index to moz_places, r=sdwilsh 2009-05-15 01:28:03 +02:00
Marco Bonardo
00b3590749 Followup to Bug 484019 - Fix corrupt or wrong roots titles in the database and in the Library. Wrong binding. r=sdwilsh 2009-05-15 01:27:58 +02:00
Marco Bonardo
35dff56288 Bug 491954 - Views should select exact columns, r=sdwilsh 2009-05-11 11:05:56 +02:00
Marco Bonardo
5f4896e73d Bug 484019 - Fix corrupt or wrong roots titles in the database and in the Library, r=dietrich 2009-04-30 09:52:40 -07:00
Marco Bonardo
27a80f377c backout Bug 484019 due to test failures. 2009-04-24 17:57:24 +02:00
Marco Bonardo
0d545b7758 Bug 484019 - Fix corrupt or wrong roots titles in the database and in the Library, r=dietrich 2009-04-24 15:11:06 +02:00
Shawn Wilsher
93af15cb71 Bug 487511 - nsINavHistoryObserver has no "onBeforeDeleteURI" callback
r=dietrich
2009-04-10 13:51:40 -04:00
Marco Bonardo
ed7d0cde30 Bug 482353 - 1 sort operation required by mDBGetChildren, r=sdwilsh 2009-04-10 13:39:47 +02:00
Shawn Wilsher
76f7104f4f Backed out changeset 2d1f7c7c7a2b (bug 483980) 2009-03-27 18:33:01 -04:00
Mark Finkle
4f6e409d0d Bug 483980: Allow history/bookmark observer components to register with a startup category, r=sdwilsh 2009-03-25 15:31:36 -05:00
Shawn Wilsher
43f3187b5b Disable inefficient query warning (tracked in bug 482353)
rs=dietrich
2009-03-20 17:02:23 -04:00
Shawn Wilsher
e74d3458f3 Disable inefficient query warning (tracked in bug 482346)
rs=dietrich
2009-03-20 17:02:23 -04:00
Shawn Wilsher
c3bde40cce Bug 468305 - nsINavBookmarksObserver has no "onBeforeItemRemoved" callback
Not having this callback makes life difficult for anyone trying to synchronize
bookmarks.  You cannot get any additional information about a bookmark when
onItemRemoved is called, since it's been removed.  Things like a guid no longer
exist, which results in a lot of pain for add-ons that want to synchronize.
r=dietrich
2009-03-19 15:56:51 -04:00
Drew Willcoxon
8b31027ba9 Bug 455315 - when removing a bookmark we recalculate frecency with wrong isBookmark, r=dietrich 2009-02-16 12:09:19 +01:00
Marco Bonardo
d40d34bee0 Bug 477739 - Exception when clicking star icon (no editBookmarkPanel, broken JSON backup), r=dietrich a=blocking191 2009-02-12 12:32:52 +01:00
Marco Bonardo
d6266d9563 Bug 477916 - Don't allow removing the Places root through bookmarks API, r+a191=dietrich 2009-02-11 11:53:35 +01:00
Marco Bonardo
8af19aa0fb Bug 474582 - With initial migration Shiretoko doesn't import favorites from Internet Explorer 7 anymore, r=dietrich 2009-02-09 19:16:02 +01:00
Marco Bonardo
658f27c658 Backed out changeset 1cf6c5b25fe5 due to crashes on linux unit test boxes 2009-02-04 15:27:18 +01:00
Marco Bonardo
e80ecb6157 Bug 474582 - With initial migration Shiretoko doesn't import favorites from Internet Explorer 7 anymore, r=dietrich 2009-02-04 13:47:13 +01:00
Shawn Wilsher
8075a939ec Bug 476292 - Crashes on startup on OS X and Linux [@ nsNavBookmarks::IsRealBookmark] [@ PL_DHashTableOperate]
This fixes a crash when we initialize nsNavBookmarks with a database that is out
of date (the schema version is less than the current one).  Because the bookmark
service initializes the history service in its Init method, and the history
service tries to get the bookmark service if the database needs an upgrade, we
try to re-enter the bookmark service's constructor.  Bad things happen.

Adds a test to ensure that we don't do this again.

r=dietrich
r=MaK77
2009-02-03 21:58:21 -05:00
Shawn Wilsher
4756beb1ae Bug 449406 - bookmarks of TRANSITION_DOWNLOAD and TRANSITION_EMBED don't show up in the location bar if they've been visited
This adds a new function to nsNavBookmarks that determines if a place id is a
"real" bookmark (not a livemark child).  It also makes a number of places use
this new function to unify and simplify a number of code paths.

Additionally, it changes how frecency is calculated for bookmarked items.  If a
visit is bookmarked (aIsBookmarked is true in CalculateFrecencyInternal), the
visited bookmark bonus is now added for all visits.  The visit bonus was also
cut in half for bookmarks so TRANSITION_BOOKMARK will still end up with the same
value (150).

r=dietrich
r=MaK77
2009-01-27 21:01:33 -05:00
Drew Willcoxon
2ad84319b7 Bug 463674 - changeBookmarkURI() doesn't update internal bookmark hash, r=mak77 2009-01-15 15:37:33 +01:00
Drew Willcoxon
c149de9294 Bug 412132 - after changing a bookmark's location, need to update the frecency of the "old" uri, r=dietrich 2009-01-13 11:48:27 +01:00
mak77@bonardo.net
3d576ef8ce Bug 463471 - temp tables are not correctly synced to disk when the user clear private data on shutdown (r=sdwilsh, r=dietrich) 2008-11-13 22:45:49 -08:00
Dietrich Ayala
127a3341a9 [mq]: backout-bug-463471 2008-11-12 23:50:19 -08:00
Marco Bonardo
36f739f320 Bug 463471 - temp tables are not correctly synced to disk when the user clear private data on shutdown, r=dietrich, sdwilsh a=beltzner 2008-11-12 21:50:02 +01:00
Marco Bonardo
20ae2fab49 Bug 462366 - correct bogus importBookmarksHTML behaviour, r=dietrich a=beltzner 2008-11-12 21:45:53 +01:00
mak77@bonardo.net
234918c058 Bug 418643 - Bookmark folder deletion executes too many SQL statements (r=dietrich) 2008-11-05 14:02:12 -08:00
Shawn Wilsher
c7e57e1cb1 Bug 459781 - create our string bundle in a more sane way
This changeset only creates the string bundle when we need it, and only in one
place as opposed to two separate places.
r=dietrich
2008-10-27 18:52:22 -04:00
Marco Bonardo
27bd310336 Bug 455474 - cleanup nsNavBookmarks::Init
r=dietrich
2008-10-27 18:52:21 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
3fc608c2a6 Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-10-27 18:52:20 -04:00
Marco Bonardo
56441e9d6e Bug 457681 - if ExcludeReadOnlyFolders is false, readonly dynamic containers are still excluded, r=dietrich 2008-10-13 17:58:36 +02:00
Arpad Borsos
8b11d938d2 Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan 2008-10-10 17:04:34 +02:00
Daniel Holbert
72c410a648 Bug 458167 - (comments-only changes) Grammar Nazi Vol1: s/it's/its/ for the posessive version of the word, and a few other misc comment-typos, in these directories: accessible browser config profile rdf toolkit tools xpcom xpfe 2008-10-01 23:49:45 -07:00
Shawn Wilsher
47008f4df3 Backed out changeset c99b7659dc0a (places fsync work) 2008-09-18 15:01:51 -04:00
Marco Bonardo ext:(%2C%20Shawn%20Wilsher%20%3Csdwilsh%40shawnwilsher.com%3E)
ec97557606 Bug 449640 - Modify the places backend to use the temporary tables &
Bug 450705 - Optimize the query changes from the temp table rewrite
This changeset merges patches from two bugs to actually use the temporary tables
created for places.
Bug 449640 patch by Shawn Wilsher <sdwilsh@shawnwilsher.com>
r=dietrich, r=Mak77
Bug 450705 patch by Marco Bonardo <mak77@bonardo.net>
r=sdwilsh, r=dietrich, r=Mardak
2008-09-18 11:10:34 -04:00
Marco Bonardo
1d4ddeb7ae Bug 430442 - Undo and redo in the library are sometimes not correctly working, r=dietrich 2008-09-11 16:16:54 +02:00
Shawn Wilsher
f22841cdcd Bug 452777 - regression from lastInsertRowID: Undo folder deletion mix up views
r=Mak77
2008-09-03 12:45:20 -04:00
Shawn Wilsher
b77395a679 Bug 449884 - Stop using mozIStorageConnection::GetLastInsertRowID
It turns out that this is not a safe function to use at all when you start using
the database connection on more than one thread.  It also does not work as
expected when triggers are used to insert data into a database.
r=dietrich
2008-08-16 18:28:28 -04:00