Commit Graph

5 Commits

Author SHA1 Message Date
Ralph Giles
a17518d61f Bug 865553 - Handle MPEG version 2 packet lengths. r=padenot
Previous code didn't adjust bitrate and scale factors correctly
for computing frame sizes on mpeg 2 and 2.5 files. See
http://blog.coryhill.net/2009/06/calculating-mp3-frame-length.html
for the extra factor of two.

Removes a case for handling length calculation for layer-1 files,
which we don't support.

Adds a tagless mpeg-2 test case for the new sniffer code.

Previous code didn't adjust bitrate and scale factors correctly
for computing frame sizes on mpeg 2 and 2.5 files. See
http://blog.coryhill.net/2009/06/calculating-mp3-frame-length.html
for the extra factor of two.

Removes a case for handling length calculation for layer-1 files,
which we don't support.

Adds a tagless mpeg-2 test case for the new sniffer code.
2013-08-09 10:27:00 -07:00
Ralph Giles
8eecb8487d Bug 862088 - Add raw mp3 sniffing. r=padenot
Attempt to sniff raw mp3 with no id3 tag by looking for a header
followed by a second header at the expected offset from the packet
length.

Adds mp3 sniffing with and without id3 tags to the mediasniffer
xpcshell tests. These files are truncated to 512 bytes. Our method
can require up to 1.5k of data, but these have 208/209 byte packets
so sniffing still works.

notags-bad.mp3 has a corrupt header, and verifies sniffing fails.
notags-scan.mp3 has garbage before the header, and verifies sniffing fails.
he_free.mp is a vbr test vector which isn't sniffable with this method.
fl10.mp2 is an mp2 file, and verifies sniffing fails.
ff-inst.exe verifies bug 875769 doesn't regress.
2013-06-04 12:12:00 -07:00
Ryan VanderMeulen
30ab83ed87 Backed out changesets bde36c2eacc0 and 8dc40bbe844e (bug 862088) for causing bug 875769. 2013-05-25 09:21:29 -04:00
Ralph Giles
5a421fa5b4 Bug 862088 - Fix build by removing obsolete call. r=bustage.
I swear this compiled locally.
2013-05-23 16:33:16 +08:00
Ralph Giles
e77742990d Bug 862088 - Add raw mp3 sniffing.
Attempt to sniff raw mp3 with no id3 tag by looking for a header
followed by a second header at the expected offset from the packet
length.

Adds mp3 sniffing with and without id3 tags to the mediasniffer
xpcshell tests. These files are copies of files in content/media/test
truncated to 512 bytes. Our method can require up to 1.5k of data,
but these have 208/209 byte packets so sniffing still works.

notags-bad.mp3 has a corrupt header, and verifies sniffing fails.

Attempt to sniff raw mp3 with no id3 tag by looking for a header
followed by a second header at the expected offset from the packet
length.

Adds mp3 sniffing with and without id3 tags to the mediasniffer
xpcshell tests. These files are copies of files in content/media/test
truncated to 512 bytes. Our method can require up to 1.5k of data,
but these have 208/209 byte packets so sniffing still works.

notags-bad.mp3 has a corrupt header, and verifies sniffing fails.
2013-05-23 01:07:00 +08:00